[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4003: Logging framework to use only log4j
harikrishna-patnala commented on pull request #4003: URL: https://github.com/apache/cloudstack/pull/4003#issuecomment-638618197 @rhtyd, this is a ready PR and can be merged. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4085: Fix duplicate user entries for vpn usage
blueorangutan commented on pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085#issuecomment-638612581 Packaging result: ✖centos7 ✖debian. JID-1293 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-638612584 Packaging result: ✔centos7 ✔debian. JID-1291 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4117: [VMware] Explicitly controlling VM hardware version
blueorangutan commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-638612580 Packaging result: ✔centos7 ✔debian. JID-1292 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4085: Fix duplicate user entries for vpn usage
blueorangutan commented on pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085#issuecomment-638606831 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4085: Fix duplicate user entries for vpn usage
rhtyd commented on pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085#issuecomment-638606557 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4085: Fix duplicate user entries for vpn usage
rhtyd closed pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4085: Fix duplicate user entries for vpn usage
blueorangutan commented on pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085#issuecomment-638605329 Packaging result: ✖centos7 ✖debian. JID-1290 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4117: [VMware] Explicitly controlling VM hardware version
blueorangutan commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-638603426 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-63860 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4117: [VMware] Explicitly controlling VM hardware version
rhtyd commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-638603022 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4013: Allow IMG extension for QCOW2 format
blueorangutan commented on pull request #4013: URL: https://github.com/apache/cloudstack/pull/4013#issuecomment-638603089 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4128: Role based users in Projects
rhtyd commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-638603100 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4013: Allow IMG extension for QCOW2 format
rhtyd commented on pull request #4013: URL: https://github.com/apache/cloudstack/pull/4013#issuecomment-638602943 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4085: Fix duplicate user entries for vpn usage
blueorangutan commented on pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085#issuecomment-638602492 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4085: Fix duplicate user entries for vpn usage
GabrielBrascher commented on pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085#issuecomment-638602170 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4013: Allow IMG extension for QCOW2 format
blueorangutan commented on pull request #4013: URL: https://github.com/apache/cloudstack/pull/4013#issuecomment-638600928 Packaging result: ✔centos7 ✔debian. JID-1289 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 opened a new pull request #4128: Role based users in Projects
Pearl1594 opened a new pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128 ## Description Enabling Role Based users in projects ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [X] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4079: Fixed HA migrated storage error
blueorangutan commented on pull request #4079: URL: https://github.com/apache/cloudstack/pull/4079#issuecomment-638594583 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network
blueorangutan commented on pull request #4062: URL: https://github.com/apache/cloudstack/pull/4062#issuecomment-638594518 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4046: Display image store disk size used and total disk size stats
blueorangutan commented on pull request #4046: URL: https://github.com/apache/cloudstack/pull/4046#issuecomment-638594432 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4007: Restarting all networks that needs a restart in a VPC
blueorangutan commented on pull request #4007: URL: https://github.com/apache/cloudstack/pull/4007#issuecomment-638594354 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network
rhtyd commented on pull request #4062: URL: https://github.com/apache/cloudstack/pull/4062#issuecomment-638594131 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4013: Allow IMG extension for QCOW2 format
blueorangutan commented on pull request #4013: URL: https://github.com/apache/cloudstack/pull/4013#issuecomment-638594125 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4046: Display image store disk size used and total disk size stats
rhtyd commented on pull request #4046: URL: https://github.com/apache/cloudstack/pull/4046#issuecomment-638594235 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4079: Fixed HA migrated storage error
rhtyd commented on pull request #4079: URL: https://github.com/apache/cloudstack/pull/4079#issuecomment-638594064 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4007: Restarting all networks that needs a restart in a VPC
rhtyd commented on pull request #4007: URL: https://github.com/apache/cloudstack/pull/4007#issuecomment-638594268 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4013: Allow IMG extension for QCOW2 format
rhtyd commented on pull request #4013: URL: https://github.com/apache/cloudstack/pull/4013#issuecomment-638593920 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4000: vm: Reset deviceId to fix missing nic with vm
rhtyd commented on pull request #4000: URL: https://github.com/apache/cloudstack/pull/4000#issuecomment-638593882 Can you check build/Travis failures @ustcweizhou ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4104: Debian10 support
rhtyd commented on pull request #4104: URL: https://github.com/apache/cloudstack/pull/4104#issuecomment-638593515 Kicked matrix smoketests on jenkins by overriding the built systemvmtemplates This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4121: server: fix TransactionLegacy DB connection leaks due to DB switching by B thread
blueorangutan commented on pull request #4121: URL: https://github.com/apache/cloudstack/pull/4121#issuecomment-638592360 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4121: server: fix TransactionLegacy DB connection leaks due to DB switching by B thread
rhtyd commented on pull request #4121: URL: https://github.com/apache/cloudstack/pull/4121#issuecomment-638592129 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4104: Debian10 support
blueorangutan commented on pull request #4104: URL: https://github.com/apache/cloudstack/pull/4104#issuecomment-638590761 Packaging result: ✔centos7 ✔debian. JID-1287 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4121: server: fix TransactionLegacy DB connection leaks due to DB switching by B thread
blueorangutan commented on pull request #4121: URL: https://github.com/apache/cloudstack/pull/4121#issuecomment-638590785 Packaging result: ✔centos7 ✔debian. JID-1288 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4000: vm: Reset deviceId to fix missing nic with vm
blueorangutan commented on pull request #4000: URL: https://github.com/apache/cloudstack/pull/4000#issuecomment-638586311 Packaging result: ✖centos7 ✖debian. JID-1286 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4007: Restarting all networks that needs a restart in a VPC
blueorangutan commented on pull request #4007: URL: https://github.com/apache/cloudstack/pull/4007#issuecomment-638586310 Packaging result: ✔centos7 ✔debian. JID-1285 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4013: Allow IMG extension for QCOW2 format
blueorangutan commented on pull request #4013: URL: https://github.com/apache/cloudstack/pull/4013#issuecomment-638586309 Packaging result: ✖centos7 ✔debian. JID-1284 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4121: server: fix TransactionLegacy DB connection leaks due to DB switching by B thread
blueorangutan commented on pull request #4121: URL: https://github.com/apache/cloudstack/pull/4121#issuecomment-638584212 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4104: Debian10 support
blueorangutan commented on pull request #4104: URL: https://github.com/apache/cloudstack/pull/4104#issuecomment-638584142 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4121: server: fix TransactionLegacy DB connection leaks due to DB switching by B thread
rhtyd commented on pull request #4121: URL: https://github.com/apache/cloudstack/pull/4121#issuecomment-638583960 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4104: Debian10 support
rhtyd commented on pull request #4104: URL: https://github.com/apache/cloudstack/pull/4104#issuecomment-638583985 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4046: Display image store disk size used and total disk size stats
blueorangutan commented on pull request #4046: URL: https://github.com/apache/cloudstack/pull/4046#issuecomment-638583124 Packaging result: ✔centos7 ✖debian. JID-1283 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces
blueorangutan commented on pull request #4048: URL: https://github.com/apache/cloudstack/pull/4048#issuecomment-638583123 Packaging result: ✔centos7 ✖debian. JID-1282 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4077: Disable searching by instance name for customers
blueorangutan commented on pull request #4077: URL: https://github.com/apache/cloudstack/pull/4077#issuecomment-638583122 Packaging result: ✖centos7 ✖debian. JID-1279 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4079: Fixed HA migrated storage error
blueorangutan commented on pull request #4079: URL: https://github.com/apache/cloudstack/pull/4079#issuecomment-638583119 Packaging result: ✔centos7 ✔debian. JID-1278 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4075: Search VR using redundant state
blueorangutan commented on pull request #4075: URL: https://github.com/apache/cloudstack/pull/4075#issuecomment-638583120 Packaging result: ✔centos7 ✖debian. JID-1280 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network
blueorangutan commented on pull request #4062: URL: https://github.com/apache/cloudstack/pull/4062#issuecomment-638583121 Packaging result: ✔centos7 ✔debian. JID-1281 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4109: add support for XCP-ng 7/8 to create it's heartbeat LVM properly
blueorangutan commented on pull request #4109: URL: https://github.com/apache/cloudstack/pull/4109#issuecomment-638574095 Packaging result: ✖centos7 ✔debian. JID-1276 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4104: Debian10 support
blueorangutan commented on pull request #4104: URL: https://github.com/apache/cloudstack/pull/4104#issuecomment-638574096 Packaging result: ✖centos7 ✖debian. JID-1277 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4121: server: fix TransactionLegacy DB connection leaks due to DB switching by B thread
blueorangutan commented on pull request #4121: URL: https://github.com/apache/cloudstack/pull/4121#issuecomment-638574097 Packaging result: ✖centos7 ✖debian. JID-1275 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3794: create Volume Access Groups per cluster instead of CloudStack-RandomUUID()
rhtyd commented on pull request #3794: URL: https://github.com/apache/cloudstack/pull/3794#issuecomment-638573556 I had to looked into iynsho as well :D This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.14'
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 4e80930254aa859a2a80ff148ba56c94485bc322 Merge: 28a1931 debde60 Author: Rohit Yadav AuthorDate: Thu Jun 4 08:29:10 2020 +0530 Merge remote-tracking branch 'origin/4.14' scripts/vm/hypervisor/kvm/kvmvmactivity.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[cloudstack] branch master updated (28a1931 -> 4e80930)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 28a1931 server: Enable revocation checking for uploaded certificates (#4065) add 23fa647 kvm: sending std output to dev/null to prevent garbage output (#4123) add debde60 Merge remote-tracking branch 'origin/4.13' into 4.14 new 4e80930 Merge remote-tracking branch 'origin/4.14' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: scripts/vm/hypervisor/kvm/kvmvmactivity.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[cloudstack] branch 4.14 updated (db55910 -> debde60)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.14 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from db55910 packaging: missing python3 libvirt dependency for CentOS7 (#4124) add 23fa647 kvm: sending std output to dev/null to prevent garbage output (#4123) new debde60 Merge remote-tracking branch 'origin/4.13' into 4.14 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: scripts/vm/hypervisor/kvm/kvmvmactivity.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.13' into 4.14
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.14 in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit debde60c94de37f0a3811e7936323c5019610e00 Merge: db55910 23fa647 Author: Rohit Yadav AuthorDate: Thu Jun 4 08:22:58 2020 +0530 Merge remote-tracking branch 'origin/4.13' into 4.14 scripts/vm/hypervisor/kvm/kvmvmactivity.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[GitHub] [cloudstack] blueorangutan commented on pull request #4053: Secondary Storage Usage Improvements
blueorangutan commented on pull request #4053: URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-638570834 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4053: Secondary Storage Usage Improvements
rhtyd commented on pull request #4053: URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-638570653 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4119: kvm: bump jna version to latest
blueorangutan commented on pull request #4119: URL: https://github.com/apache/cloudstack/pull/4119#issuecomment-638570720 Packaging result: ✖centos7 ✖debian. JID-1274 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4092: engine/schema: add empty DB upgrade path from 4.14.0.0 to 4.15.0.0
rhtyd commented on pull request #4092: URL: https://github.com/apache/cloudstack/pull/4092#issuecomment-638570464 @DaanHoogland you're right I actually wanted that to be moved to 4.14-4.15 upgrade path so I can fix it in here - https://github.com/apache/cloudstack/pull/4104/files We'll have a new systemvmtemplate for 4.15 (Debian 10 based). It won't be problem if we merge #4104 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch 4.13 updated: kvm: sending std output to dev/null to prevent garbage output (#4123)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.13 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.13 by this push: new 23fa647 kvm: sending std output to dev/null to prevent garbage output (#4123) 23fa647 is described below commit 23fa6479853a4af50889c144ea561999717b8f62 Author: Spaceman1984 <49917670+spaceman1...@users.noreply.github.com> AuthorDate: Thu Jun 4 04:47:59 2020 +0200 kvm: sending std output to dev/null to prevent garbage output (#4123) When scripts/vm/hypervisor/kvm/kvmvmactivity.sh is called with an incorrect file name, an error is printed which is then interpreted as output from the script. When an incorrect file name is passed the script prints out: stat: cannot stat ‘b51d7336-d964-44ee-be60-bf62783dabc’: No such file or directory => DEAD <== The KVMHAVMActivityChecker.java checkingHB() process is expecting just => DEAD <== but gets the unexpected error message and interprets the file as alive. --- scripts/vm/hypervisor/kvm/kvmvmactivity.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/vm/hypervisor/kvm/kvmvmactivity.sh b/scripts/vm/hypervisor/kvm/kvmvmactivity.sh index 88ee8f3..7e9b9b6 100755 --- a/scripts/vm/hypervisor/kvm/kvmvmactivity.sh +++ b/scripts/vm/hypervisor/kvm/kvmvmactivity.sh @@ -99,7 +99,7 @@ fi # Second check: disk activity check cd $MountPoint -latestUpdateTime=$(stat -c %Y $(echo $UUIDList | sed 's/,/ /g') | sort -nr | head -1) +latestUpdateTime=$(stat -c %Y $(echo $UUIDList | sed 's/,/ /g') 2> /dev/null | sort -nr | head -1) if [ ! -f $acFile ]; then echo "$SuspectTime:$latestUpdateTime:$MSTime" > $acFile
[GitHub] [cloudstack] rhtyd commented on pull request #4123: Improved kvmvmactivitycheck.sh output
rhtyd commented on pull request #4123: URL: https://github.com/apache/cloudstack/pull/4123#issuecomment-638569472 Nevermind the path fix is in a different PR, this LGTM. Smoketests won't test this specific case, simulator passed the hostha_simualtor tests. I'll merge based on this and that it's a simple change in script ignoring stderr output. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4123: Improved kvmvmactivitycheck.sh output
rhtyd merged pull request #4123: URL: https://github.com/apache/cloudstack/pull/4123 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack-primate] branch master updated: compute: fix list host, cluster not filtered in VM deployment form (#378)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git
The following commit(s) were added to refs/heads/master by this push:
new e30aacf compute: fix list host, cluster not filtered in VM deployment
form (#378)
e30aacf is described below
commit e30aacf311b419f5153ac15e6731e1a64cc3446c
Author: Hoang Nguyen
AuthorDate: Thu Jun 4 09:38:57 2020 +0700
compute: fix list host, cluster not filtered in VM deployment form (#378)
Fixes #376
---
src/views/compute/DeployVM.vue | 22 +-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/src/views/compute/DeployVM.vue b/src/views/compute/DeployVM.vue
index d7b234f..09d36a3 100644
--- a/src/views/compute/DeployVM.vue
+++ b/src/views/compute/DeployVM.vue
@@ -51,6 +51,7 @@
v-decorator="['podid']"
:options="podSelectOptions"
:loading="loading.pods"
+@change="onSelectPodId"
>
option.id === value)
this.zoneSelected = true
this.form.setFieldsValue({
@@ -1109,6 +1118,17 @@ export default {
})
this.fetchAllTemplates()
},
+onSelectPodId (value) {
+ this.podId = value
+
+ this.fetchOptions(this.params.clusters, 'clusters')
+ this.fetchOptions(this.params.hosts, 'hosts')
+},
+onSelectClusterId (value) {
+ this.clusterId = value
+
+ this.fetchOptions(this.params.hosts, 'hosts')
+},
handleSearchFilter (name, options) {
this.params[name].options = { ...this.params[name].options, ...options }
this.fetchOptions(this.params[name], name)
[GitHub] [cloudstack] blueorangutan commented on pull request #4000: vm: Reset deviceId to fix missing nic with vm
blueorangutan commented on pull request #4000: URL: https://github.com/apache/cloudstack/pull/4000#issuecomment-638565421 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4000: vm: Reset deviceId to fix missing nic with vm
rhtyd commented on pull request #4000: URL: https://github.com/apache/cloudstack/pull/4000#issuecomment-638565172 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4001: server: Dedicated hosts should be 'Not Suitable' while find host for m migration
rhtyd closed pull request #4001: URL: https://github.com/apache/cloudstack/pull/4001 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4001: server: Dedicated hosts should be 'Not Suitable' while find host for m migration
rhtyd commented on pull request #4001: URL: https://github.com/apache/cloudstack/pull/4001#issuecomment-638564921 (Did not test it) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] ustcweizhou opened a new pull request #4001: server: Dedicated hosts should be 'Not Suitable' while find host for m migration
ustcweizhou opened a new pull request #4001: URL: https://github.com/apache/cloudstack/pull/4001 ## Description While migrate a vm, in the popup, the host dedicated to other accounts/domains are also 'Suitable" for migration, which is obviously wrong. The same issue happens with api findHostsForMigration ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? with this PR, the hosts dedicated to other domains/accounts are marked as 'Not Suitable'. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4003: Logging framework to use only log4j
rhtyd commented on pull request #4003: URL: https://github.com/apache/cloudstack/pull/4003#issuecomment-638564739 Is this ready for testing or requires more work @DaanHoogland @harikrishna-patnala ? If it requires additional work can you change it to a draft @harikrishna-patnala ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4007: Restarting all networks that needs a restart in a VPC
blueorangutan commented on pull request #4007: URL: https://github.com/apache/cloudstack/pull/4007#issuecomment-638564538 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4004: Fixed null pointer and deployment issue on Xenserver with L2 Guest network with configDrive
rhtyd commented on pull request #4004: URL: https://github.com/apache/cloudstack/pull/4004#issuecomment-638564451 @DaanHoogland can you review this? Thanks (I'm not following this) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4013: Allow IMG extension for QCOW2 format
blueorangutan commented on pull request #4013: URL: https://github.com/apache/cloudstack/pull/4013#issuecomment-638564229 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4007: Restarting all networks that needs a restart in a VPC
rhtyd commented on pull request #4007: URL: https://github.com/apache/cloudstack/pull/4007#issuecomment-638564204 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4013: Allow IMG extension for QCOW2 format
rhtyd commented on pull request #4013: URL: https://github.com/apache/cloudstack/pull/4013#issuecomment-638564044 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4046: Display image store disk size used and total disk size stats
blueorangutan commented on pull request #4046: URL: https://github.com/apache/cloudstack/pull/4046#issuecomment-638562667 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4021: Boot into hardware setup menu on Vmware
rhtyd commented on a change in pull request #4021: URL: https://github.com/apache/cloudstack/pull/4021#discussion_r434955865 ## File path: api/src/main/java/com/cloud/agent/api/to/VirtualMachineTO.java ## @@ -65,6 +65,7 @@ String uuid; String bootType; String bootMode; +boolean enterHardwareSetup; Review comment: @DaanHoogland Is hardware setup same as boot setup? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4046: Display image store disk size used and total disk size stats
rhtyd commented on pull request #4046: URL: https://github.com/apache/cloudstack/pull/4046#issuecomment-638562332 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4046: Display image store disk size used and total disk size stats
rhtyd closed pull request #4046: URL: https://github.com/apache/cloudstack/pull/4046 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4046: Display image store disk size used and total disk size stats
rhtyd commented on a change in pull request #4046:
URL: https://github.com/apache/cloudstack/pull/4046#discussion_r434955382
##
File path:
api/src/main/java/org/apache/cloudstack/api/response/ImageStoreResponse.java
##
@@ -60,6 +60,14 @@
@Param(description = "the scope of the image store")
private ScopeType scope;
+@SerializedName("disksizetotal")
Review comment:
@ravening can you fix this (and other serialised names) to use
`ApiContant`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces
blueorangutan commented on pull request #4048: URL: https://github.com/apache/cloudstack/pull/4048#issuecomment-638562015 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4048: Update DpdkDriverImpl.java to support DPDK trunk interfaces
rhtyd commented on pull request #4048: URL: https://github.com/apache/cloudstack/pull/4048#issuecomment-638561807 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network
blueorangutan commented on pull request #4062: URL: https://github.com/apache/cloudstack/pull/4062#issuecomment-638561431 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4053: Secondary Storage Usage Improvements
rhtyd commented on pull request #4053: URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-638561264 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network
rhtyd commented on pull request #4062: URL: https://github.com/apache/cloudstack/pull/4062#issuecomment-638561047 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd removed a comment on pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network
rhtyd removed a comment on pull request #4062: URL: https://github.com/apache/cloudstack/pull/4062#issuecomment-638560711 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4053: Secondary Storage Usage Improvements
rhtyd closed pull request #4053: URL: https://github.com/apache/cloudstack/pull/4053 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network
rhtyd commented on pull request #4062: URL: https://github.com/apache/cloudstack/pull/4062#issuecomment-638560711 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4065: Enable revocation checking for uploaded certificates
rhtyd merged pull request #4065: URL: https://github.com/apache/cloudstack/pull/4065 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch master updated: server: Enable revocation checking for uploaded certificates (#4065)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new 28a1931 server: Enable revocation checking for uploaded certificates
(#4065)
28a1931 is described below
commit 28a19311f4bb4eda0ce2ccd0dfcaa2ec23f3a029
Author: Artem Smotrakov
AuthorDate: Thu Jun 4 04:17:05 2020 +0200
server: Enable revocation checking for uploaded certificates (#4065)
This update turns on certificate revocation checking for uploaded
certificates:
- Updated `CertServiceImpl` to be able to enable revocation checking.
- Introduced a new parameter `ENABLED_REVOCATION_CHECK` for
`UploadSslCertCmd`.
- Updated `CertServiceTest`.
Even if no CLRs are specified via `PKIXParameters`, the certificates
themselves may still provide info for revocation checking:
- The AIA extension may contains a URL to the OCSP responder.
- The CLRDP extension contains a URL to the CLR.
Those extensions may need to be explicitly enabled by setting the system
properties `com.sun.security.enableAIAcaIssuers` and
`com.sun.security.enableCRLDP` to true. See [Java PKI Programmer's
Guide](https://docs.oracle.com/en/java/javase/11/security/java-pki-programmers-guide.html).
Using a revoked certificate may be dangerous. One of the most common
reasons why a certificate authority (CA) revokes a certificate is that the
private key has been compromised. For example, the private key might have been
stolen by an adversary.
If I understand correctly, the `CertServiceImpl` bean is used for
operations with certificates on a load balancer. In particular, it validates a
certificate chain without revocation checking while uploading a certificate. If
a compromised revoked certificate is then used by the load balancer, then it
may result to compromising TLS connections. However, the attacker has to be
able to implement man-in-the-middle attack to compromise the connections. So
the attacker has to be quite power [...]
This has been discussed on secur...@cloudstack.apache.org
---
.../org/apache/cloudstack/api/ApiConstants.java| 1 +
.../user/loadbalancer/UploadSslCertCmd.java| 7 +++
.../cloudstack/network/ssl/CertServiceImpl.java| 12 ++--
.../cloudstack/network/ssl/CertServiceTest.java| 65 ++
4 files changed, 79 insertions(+), 6 deletions(-)
diff --git a/api/src/main/java/org/apache/cloudstack/api/ApiConstants.java
b/api/src/main/java/org/apache/cloudstack/api/ApiConstants.java
index 2a201db..932f62d 100644
--- a/api/src/main/java/org/apache/cloudstack/api/ApiConstants.java
+++ b/api/src/main/java/org/apache/cloudstack/api/ApiConstants.java
@@ -55,6 +55,7 @@ public class ApiConstants {
public static final String CERTIFICATE_CHAIN = "certchain";
public static final String CERTIFICATE_FINGERPRINT = "fingerprint";
public static final String CERTIFICATE_ID = "certid";
+public static final String ENABLED_REVOCATION_CHECK =
"enabledrevocationcheck";
public static final String CONTROLLER = "controller";
public static final String CONTROLLER_UNIT = "controllerunit";
public static final String COPY_IMAGE_TAGS = "copyimagetags";
diff --git
a/api/src/main/java/org/apache/cloudstack/api/command/user/loadbalancer/UploadSslCertCmd.java
b/api/src/main/java/org/apache/cloudstack/api/command/user/loadbalancer/UploadSslCertCmd.java
index 309e43f..c206a16 100644
---
a/api/src/main/java/org/apache/cloudstack/api/command/user/loadbalancer/UploadSslCertCmd.java
+++
b/api/src/main/java/org/apache/cloudstack/api/command/user/loadbalancer/UploadSslCertCmd.java
@@ -76,6 +76,9 @@ public class UploadSslCertCmd extends BaseCmd {
@Parameter(name = ApiConstants.NAME , type = CommandType.STRING, required
= true, description = "Name for the uploaded certificate")
private String name;
+@Parameter(name = ApiConstants.ENABLED_REVOCATION_CHECK, type =
CommandType.BOOLEAN, description = "Enables revocation checking for
certificates", since = "4.15")
+private Boolean enabledRevocationCheck = Boolean.TRUE;
+
/
/// Accessors ///
/
@@ -112,6 +115,10 @@ public class UploadSslCertCmd extends BaseCmd {
return name;
}
+public Boolean getEnabledRevocationCheck() {
+return enabledRevocationCheck;
+}
+
/
/// API Implementation///
/
diff --git
a/server/src/main/java/org/apache/cloudstack/network/ssl/CertServiceImpl.java
[GitHub] [cloudstack] rhtyd commented on pull request #4065: Enable revocation checking for uploaded certificates
rhtyd commented on pull request #4065: URL: https://github.com/apache/cloudstack/pull/4065#issuecomment-638560445 We've two lgtms and test pass, I'll merge this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8 Support
rhtyd commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-638560036 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4073: Display network name for IP in shared networks
rhtyd commented on a change in pull request #4073:
URL: https://github.com/apache/cloudstack/pull/4073#discussion_r434953602
##
File path:
api/src/main/java/org/apache/cloudstack/api/response/IPAddressResponse.java
##
@@ -150,6 +150,10 @@
@Param(description = "is public ip for display to the regular user", since
= "4.4", authorized = {RoleType.Admin})
private Boolean forDisplay;
+@SerializedName("networkname")
Review comment:
@ravening can you change that to use `ApiConstants`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4068: Adding Centos8 Support
rhtyd closed pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4074: Allow searching networks using name in api
rhtyd commented on pull request #4074: URL: https://github.com/apache/cloudstack/pull/4074#issuecomment-638559561 -1 @ravening can you explain why we need that when we already can search by name using the `keyword` parameter? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4075: Search VR using redundant state
blueorangutan commented on pull request #4075: URL: https://github.com/apache/cloudstack/pull/4075#issuecomment-638558963 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4077: Disable searching by instance name for customers
blueorangutan commented on pull request #4077: URL: https://github.com/apache/cloudstack/pull/4077#issuecomment-638558632 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4075: Search VR using redundant state
rhtyd commented on pull request #4075: URL: https://github.com/apache/cloudstack/pull/4075#issuecomment-638558791 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4077: Disable searching by instance name for customers
rhtyd commented on pull request #4077: URL: https://github.com/apache/cloudstack/pull/4077#issuecomment-638558384 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4077: Disable searching by instance name for customers
rhtyd closed pull request #4077: URL: https://github.com/apache/cloudstack/pull/4077 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4077: Disable searching by instance name for customers
rhtyd commented on pull request #4077: URL: https://github.com/apache/cloudstack/pull/4077#issuecomment-638558035 No need @ravening - PR LGTM @DaanHoogland @andrijapanicsb I checked the API response we don't return the `instancename` to the user as part of the API response, so we can safely assume that end users wouldn't know the internal name of the VM. In case of admins, this is returned such as: ``` "instancename": "i-2-94-QA", ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
