[GitHub] [cloudstack] rhtyd commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.
rhtyd commented on pull request #4137: URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-641712287 @ggoodrich-ipp please check and fix python/lint issues, see travis failure: https://travis-ci.org/github/apache/cloudstack/jobs/696639652 As PR has UI changes, please make submit a PR to the Primate repo [1] as per our agreement and vote to stop changes in the legacy UI [2] towards the next major release (4.15). [1] https://github.com/apache/cloudstack-primate [2] http://markmail.org/message/tblrbrtew6cvrusr This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #3987: Exception in long running Java11/MySQL8 management server
rhtyd commented on issue #3987: URL: https://github.com/apache/cloudstack/issues/3987#issuecomment-641710874 Closing this, we've identified root cause fixed in https://github.com/apache/cloudstack/pull/4121 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed issue #3987: Exception in long running Java11/MySQL8 management server
rhtyd closed issue #3987: URL: https://github.com/apache/cloudstack/issues/3987 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4136: UI doesn't allow login if sessionkey and JSESSIONID cookies are deleted
rhtyd commented on issue #4136: URL: https://github.com/apache/cloudstack/issues/4136#issuecomment-641710337 The issue happens because from code we're unable to clear HttpOnly cookie[1], this cookie can only be cleared by CloudStack (i.e. the server, not the client) and the fix is to call the logout API (which Primate does as well) when we get 401 error on the first API we call to validate auth (listCapabilities). [1] https://owasp.org/www-community/HttpOnly This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4136: UI doesn't allow login if sessionkey and JSESSIONID cookies are deleted
rhtyd commented on issue #4136: URL: https://github.com/apache/cloudstack/issues/4136#issuecomment-641710430 @davidjumani please pick this up. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4003: Logging framework to use only log4j
blueorangutan commented on pull request #4003: URL: https://github.com/apache/cloudstack/pull/4003#issuecomment-641691692 Trillian test result (tid-1656) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 77155 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4003-t1656-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_accounts.py Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py Intermittent failure detected: /marvin/tests/smoke/test_iso.py Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_deployment_planner.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 57 look OK, 26 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestTemplateHierarchy>:setup | `Error` | 1524.77 | test_accounts.py test_13_retrieve_vr_default_files | `Error` | 2.14 | test_diagnostics.py test_14_retrieve_vr_one_file | `Error` | 2.13 | test_diagnostics.py test_15_retrieve_ssvm_default_files | `Error` | 2.12 | test_diagnostics.py test_16_retrieve_ssvm_single_file | `Error` | 2.11 | test_diagnostics.py test_17_retrieve_cpvm_default_files | `Error` | 2.12 | test_diagnostics.py test_18_retrieve_cpvm_single_file | `Error` | 2.11 | test_diagnostics.py test_04_extract_Iso | `Failure` | 1.06 | test_iso.py test_01_add_primary_storage_disabled_host | `Error` | 33.21 | test_primary_storage.py ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py test_01_sys_vm_start | `Failure` | 0.06 | test_secondary_storage.py ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.25 | test_service_offerings.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py test_02_list_cpvm_vm | `Failure` | 0.05 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.05 | test_ssvm.py test_05_stop_ssvm | `Error` | 2.21 | test_ssvm.py test_06_stop_cpvm | `Failure` | 0.06 | test_ssvm.py t
[GitHub] [cloudstack] blueorangutan commented on pull request #4103: [VMware] Enable unmanaging guest VMs
blueorangutan commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-641649675 Trillian test result (tid-1662) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45393 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4103-t1662-vmware-67u3.zip Intermittent failure detected: /marvin/tests/smoke/test_accounts.py Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py Intermittent failure detected: /marvin/tests/smoke/test_iso.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 73 look OK, 5 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestTemplateHierarchy>:setup | `Error` | 1520.42 | test_accounts.py test_13_retrieve_vr_default_files | `Error` | 1.09 | test_diagnostics.py test_14_retrieve_vr_one_file | `Error` | 1.09 | test_diagnostics.py test_15_retrieve_ssvm_default_files | `Error` | 1.08 | test_diagnostics.py test_16_retrieve_ssvm_single_file | `Error` | 1.08 | test_diagnostics.py test_17_retrieve_cpvm_default_files | `Error` | 1.09 | test_diagnostics.py test_18_retrieve_cpvm_single_file | `Error` | 1.09 | test_diagnostics.py test_04_extract_Iso | `Failure` | 1.07 | test_iso.py test_04_extract_template | `Failure` | 28.02 | test_templates.py test_06_download_detached_volume | `Failure` | 53.19 | test_volumes.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4003: Logging framework to use only log4j
blueorangutan commented on pull request #4003: URL: https://github.com/apache/cloudstack/pull/4003#issuecomment-641612062 Trillian test result (tid-1657) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 60244 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4003-t1657-vmware-67u3.zip Intermittent failure detected: /marvin/tests/smoke/test_accounts.py Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py Intermittent failure detected: /marvin/tests/smoke/test_iso.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 77 look OK, 6 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestTemplateHierarchy>:setup | `Error` | 1518.68 | test_accounts.py test_13_retrieve_vr_default_files | `Error` | 2.11 | test_diagnostics.py test_14_retrieve_vr_one_file | `Error` | 1.08 | test_diagnostics.py test_15_retrieve_ssvm_default_files | `Error` | 1.08 | test_diagnostics.py test_16_retrieve_ssvm_single_file | `Error` | 1.08 | test_diagnostics.py test_17_retrieve_cpvm_default_files | `Error` | 1.08 | test_diagnostics.py test_18_retrieve_cpvm_single_file | `Error` | 1.10 | test_diagnostics.py test_04_extract_Iso | `Failure` | 1.07 | test_iso.py test_04_extract_template | `Failure` | 44.87 | test_templates.py test_06_download_detached_volume | `Failure` | 163.19 | test_volumes.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 495.75 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] ggoodrich-ipp opened a new pull request #4137: Adding VPN options for IKE version and IKE split connections.
ggoodrich-ipp opened a new pull request #4137: URL: https://github.com/apache/cloudstack/pull/4137 ## Description IKE version allows selecting ike (autoselect), ikev1, or ikev2. Split connections gives an option of separating the first right subnet from the rest, and kicking out individual statements for each right subnet for better cross-compatibility. Fixes: #3138 ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? We have been running this code in our production cloud for some months. Prior to this change, whenever an update was made to an existing customer gateway, it was wiping out the manual changes made to the configurations to split these out so that the gateway worked properly. Now, this code allows for these to be split into their own connections via the UI. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4130: Fixed null pointer after deleting snapshot, GC and cross cluster vm migration on XCP-NG
blueorangutan commented on pull request #4130: URL: https://github.com/apache/cloudstack/pull/4130#issuecomment-641546893 Trillian test result (tid-1654) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 60447 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4130-t1654-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 55 look OK, 22 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 183.21 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 179.02 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 324.88 | test_privategw_acl.py ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py test_01_sys_vm_start | `Failure` | 0.08 | test_secondary_storage.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.15 | test_service_offerings.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py test_02_list_cpvm_vm | `Failure` | 0.03 | test_ssvm.py test_03_ssvm_internals | `Failure` | 0.03 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.04 | test_ssvm.py test_05_stop_ssvm | `Failure` | 0.04 | test_ssvm.py test_06_stop_cpvm | `Failure` | 0.04 | test_ssvm.py test_07_reboot_ssvm | `Failure` | 0.05 | test_ssvm.py test_08_reboot_cpvm | `Failure` | 0.07 | test_ssvm.py test_09_destroy_ssvm | `Failure` | 0.06 | test_ssvm.py test_10_destroy_cpvm | `Failure` | 0.04 | test_ssvm.py test_02_create_template_with_checksum_sha1 | `Error` | 66.54 | test_templates.py test_03_create_template_with_checksum_sha256 | `Error` | 65.47 | test_templates.py test_04_create_template_with_checksum_md5 | `Error` | 65.41 | test_templates.py test_05_create_template_with_no_checksum | `Error` | 65.39 | test_templates.py test_02_deploy_vm_from_direct_downl
[GitHub] [cloudstack] blueorangutan commented on pull request #4007: Restarting all networks that needs a restart in a VPC
blueorangutan commented on pull request #4007: URL: https://github.com/apache/cloudstack/pull/4007#issuecomment-641544436 Trillian test result (tid-1653) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 60402 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4007-t1653-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_nic.py Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 54 look OK, 23 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_nic | `Error` | 51.24 | test_nic.py test_02_vpc_privategw_static_routes | `Failure` | 178.85 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 181.39 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 239.51 | test_privategw_acl.py ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py test_01_sys_vm_start | `Failure` | 0.08 | test_secondary_storage.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.17 | test_service_offerings.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py test_02_list_cpvm_vm | `Failure` | 0.03 | test_ssvm.py test_03_ssvm_internals | `Failure` | 0.03 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.04 | test_ssvm.py test_05_stop_ssvm | `Failure` | 0.03 | test_ssvm.py test_06_stop_cpvm | `Failure` | 0.03 | test_ssvm.py test_07_reboot_ssvm | `Failure` | 0.03 | test_ssvm.py test_08_reboot_cpvm | `Failure` | 0.03 | test_ssvm.py test_09_destroy_ssvm | `Failure` | 0.03 | test_ssvm.py test_10_destroy_cpvm | `Failure` | 0.02 | test_ssvm.py test_02_create_template_with_checksum_sha1 | `Error` | 66.94 | test_templates.py test_03_create_template_with_checksum_sha256 | `Error` | 66.71 | test_templates.py test_04_create_template_with_checksum_md5 | `Error` | 65.99 | test_templates.py test_
[cloudstack-documentation] branch vnc-ports-on-vsphere-firewall updated (3600f15 -> 4cabb19)
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch vnc-ports-on-vsphere-firewall in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. from 3600f15 Update vsphere.rst add 4cabb19 Update vsphere.rst No new revisions were added by this update. Summary of changes: source/installguide/hypervisor/vsphere.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
[cloudstack-documentation] branch vnc-ports-on-vsphere-firewall updated (ae0aa67 -> 3600f15)
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch vnc-ports-on-vsphere-firewall in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. from ae0aa67 vnc-ports add 3600f15 Update vsphere.rst No new revisions were added by this update. Summary of changes: source/installguide/hypervisor/vsphere.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
[cloudstack-documentation] 01/01: vnc-ports
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a commit to branch vnc-ports-on-vsphere-firewall in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git commit ae0aa67ec631a7accabe4e9c1756fc28137886ef Author: Andrija Panic <45762285+andrijapani...@users.noreply.github.com> AuthorDate: Tue Jun 9 22:06:37 2020 +0200 vnc-ports --- source/installguide/hypervisor/vsphere.rst | 65 +- 1 file changed, 56 insertions(+), 9 deletions(-) diff --git a/source/installguide/hypervisor/vsphere.rst b/source/installguide/hypervisor/vsphere.rst index 4c01b93..8011002 100644 --- a/source/installguide/hypervisor/vsphere.rst +++ b/source/installguide/hypervisor/vsphere.rst @@ -339,19 +339,66 @@ port group so that CloudStack can find it: Extend Port Range for CloudStack Console Proxy ^^ -(Applies only to VMware vSphere version 4.x) - -You need to extend the range of firewall ports that the console proxy -works with on the hosts. This is to enable the console proxy to work -with VMware-based VMs. The default additional port range is 59000-6. -To extend the port range, log in to the VMware ESX service console on -each host and run the following commands: +In production environments (large number of VMs), +it's needed to extend the range of firewall ports that the console proxy +works with on the hosts. The default additional port range is 5-50999 + - see global settings ``vmware.additional.vnc.portrange.size`` + and ``vmware.additional.vnc.portrange.start``. + +Change global setting ``vmware.additional.vnc.portrange.size`` to i.e "1" and restart the +management-server service on each management server. +Add those additional ports to the ESXi firewall on each host. +Log via SSH to every VMware ESX host and edit file ``/etc/rc.local.d/local.sh`` +by adding the following lines just above the "exit 0" line.: .. parsed-literal:: - esxcfg-firewall -o 59000-6,tcp,in,vncextras - esxcfg-firewall -o 59000-6,tcp,out,vncextras + cat < /etc/vmware/firewall/vncAdditionalPorts.xml + + + vncAdditionalPorts + + inbound + tcp + dst + + 51000 + 6 + + + true + false + + + EOF + esxcli network firewall refresh + +This will ensure the needed firewall rules are applied on boot of ESXi hosts. +Repeat the same commands that were just added to local.sh`` + +.. parsed-literal:: + cat < /etc/vmware/firewall/vncAdditionalPorts.xml + + + vncAdditionalPorts + + inbound + tcp + dst + + 51000 + 6 + + + true + false + + + EOF + esxcli network firewall refresh + +Run the script ``/sbin/auto-backup.sh`` Configure NIC Bonding for vSphere ^
[cloudstack-documentation] branch vnc-ports-on-vsphere-firewall created (now ae0aa67)
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch vnc-ports-on-vsphere-firewall in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. at ae0aa67 vnc-ports This branch includes the following new commits: new ae0aa67 vnc-ports The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[GitHub] [cloudstack] weizhouapache commented on pull request #4104: Debian10 support
weizhouapache commented on pull request #4104: URL: https://github.com/apache/cloudstack/pull/4104#issuecomment-640542301 code lgtm did not test it This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4132: Fix delete network with no services
nvazquez commented on pull request #4132: URL: https://github.com/apache/cloudstack/pull/4132#issuecomment-640539152 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed issue #3654: Remote VPN not working if site-to-site VPN exists
rhtyd closed issue #3654: URL: https://github.com/apache/cloudstack/issues/3654 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb opened a new issue #4136: UI doesn't allow login if sessionkey and JSESSIONID cookies are deleted
andrijapanicsb opened a new issue #4136: URL: https://github.com/apache/cloudstack/issues/4136 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ UI (old UI, not Primate) ~~~ # CLOUDSTACK VERSION ~~~ 4.14+ (probably present on all older versions as well) ~~~ To consistently reproduce this, this is what I did: Login into old UI, then open devtools->Application-> cookies Delete the sessionkey and JSESSIONID cookies (to simulate session expiry, in browser but not on mgmt server) Refresh legacy UI and try to log in, you won't be able to login You've to wait until the previous session expires, or clear cache The solution is for legacy UI to call the logout API when 401/unauthorised happens (logout will expire session on backend mgmt server) and clear cookies. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4121: server: fix TransactionLegacy DB connection leaks due to DB switching by B&R thread
rhtyd commented on pull request #4121: URL: https://github.com/apache/cloudstack/pull/4121#issuecomment-641120904 We need another review to get this merged, so we can work towards a 4.14.1.0 release with the two critical issues (a) SG package dependency fix, (b) this issue. Please help review @weizhouapache @wido @GabrielBrascher @svenvogel @kiwiflyer @nvazquez @borisstoyanov and others This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4103: [VMware] Enable unmanaging guest VMs
blueorangutan commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-640588541 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4132: Fix delete network with no services
blueorangutan commented on pull request #4132: URL: https://github.com/apache/cloudstack/pull/4132#issuecomment-640538716 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4131: Health Checkplease don't merge this
blueorangutan commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-640788693 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4104: Debian10 support
rhtyd merged pull request #4104: URL: https://github.com/apache/cloudstack/pull/4104 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4109: add support for XCP-ng 7/8 to create it's heartbeat LVM properly
rhtyd commented on pull request #4109: URL: https://github.com/apache/cloudstack/pull/4109#issuecomment-641315181 @blueorangutan test centos7 xenserver-71 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4071: Dynamic roles improvements
blueorangutan commented on pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-641077045 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #3965: server: Honor vm.destroy.forcestop when expunge a vm
rhtyd merged pull request #3965: URL: https://github.com/apache/cloudstack/pull/3965 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] PaulAngus commented on pull request #4135: Remove use of blacklist/whitelist terms
PaulAngus commented on pull request #4135: URL: https://github.com/apache/cloudstack/pull/4135#issuecomment-640879888 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4114: hypervisor: XCP-ng 8.1 support
blueorangutan commented on pull request #4114: URL: https://github.com/apache/cloudstack/pull/4114#issuecomment-641172321 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3965: server: Honor vm.destroy.forcestop when expunge a vm
blueorangutan commented on pull request #3965: URL: https://github.com/apache/cloudstack/pull/3965#issuecomment-640683826 Trillian test result (tid-1639) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34431 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3965-t1639-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Smoke tests completed. 76 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 228.10 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 221.30 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 957.94 | test_privategw_acl.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #4135: Remove use of blacklist/whitelist terms
borisstoyanov commented on pull request #4135: URL: https://github.com/apache/cloudstack/pull/4135#issuecomment-640790268 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4104: Debian10 support
blueorangutan commented on pull request #4104: URL: https://github.com/apache/cloudstack/pull/4104#issuecomment-640859244 Trillian test result (tid-1638) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 64333 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4104-t1638-xenserver-71.zip Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 80 look OK, 3 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_05_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 1863.68 | test_kubernetes_clusters.py test_01_scale_vm | `Failure` | 24.62 | test_scale_vm.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 459.52 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 403.47 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8 Support
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-641172838 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4130: Fixed null pointer after deleting snapshot, GC and cross cluster vm migration on XCP-NG
rhtyd commented on pull request #4130: URL: https://github.com/apache/cloudstack/pull/4130#issuecomment-640999470 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4131: Health Checkplease don't merge this
rhtyd closed pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4115: cks: fix k8s cluster deployment planner
blueorangutan commented on pull request #4115: URL: https://github.com/apache/cloudstack/pull/4115#issuecomment-641097828 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #4077: Disable searching by instance name for customers
andrijapanicsb commented on pull request #4077: URL: https://github.com/apache/cloudstack/pull/4077#issuecomment-641329322 Overall LGTM, but have not tested it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4114: hypervisor: XCP-ng 8.1 support
rhtyd commented on pull request #4114: URL: https://github.com/apache/cloudstack/pull/4114#issuecomment-641171843 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4103: [VMware] Enable unmanaging guest VMs
nvazquez commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-640587965 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4109: add support for XCP-ng 7/8 to create it's heartbeat LVM properly
rhtyd closed pull request #4109: URL: https://github.com/apache/cloudstack/pull/4109 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4071: Dynamic roles improvements
rhtyd commented on pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-640998000 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4109: add support for XCP-ng 7/8 to create it's heartbeat LVM properly
blueorangutan commented on pull request #4109: URL: https://github.com/apache/cloudstack/pull/4109#issuecomment-641251366 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4071: Dynamic roles improvements
rhtyd closed pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #4104: Debian10 support
rhtyd edited a comment on pull request #4104: URL: https://github.com/apache/cloudstack/pull/4104#issuecomment-640995834 Checked test failures not related to this PR on XenServer, overall all tests have passed. The cale_vm test case failure is due to license issue (it would pass on xcp-ng). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Slair1 commented on issue #3138: StrongSwan with several rightsubnet's - ikev1
Slair1 commented on issue #3138: URL: https://github.com/apache/cloudstack/issues/3138#issuecomment-640910495 @ggoodrich-ipp could you upload a PR to address this? We have had this fixed in our environment for a while now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] PaulAngus commented on pull request #4003: Logging framework to use only log4j
PaulAngus commented on pull request #4003: URL: https://github.com/apache/cloudstack/pull/4003#issuecomment-640740145 @DaanHoogland have your comments bee addressed ? if yes @harikrishna-patnala can you repackage and kick the smoke test matrix? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4115: cks: fix k8s cluster deployment planner
shwstppr commented on pull request #4115: URL: https://github.com/apache/cloudstack/pull/4115#issuecomment-641113846 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] PaulAngus commented on a change in pull request #4135: Remove use of blacklist/whitelist terms
PaulAngus commented on a change in pull request #4135:
URL: https://github.com/apache/cloudstack/pull/4135#discussion_r436992105
##
File path: api/src/main/java/org/apache/cloudstack/query/QueryService.java
##
@@ -94,8 +94,8 @@
ConfigKey AllowUserViewDestroyedVM = new ConfigKey<>("Advanced",
Boolean.class, "allow.user.view.destroyed.vm", "false",
"Determines whether users can view their destroyed or expunging vm
", true, ConfigKey.Scope.Account);
-static final ConfigKey UserVMBlacklistedDetails = new
ConfigKey("Advanced", String.class,
-"user.vm.blacklisted.details", "rootdisksize, cpuOvercommitRatio,
memoryOvercommitRatio, Message.ReservedCapacityFreed.Flag",
+static final ConfigKey UserVMDenyListedDetails = new
ConfigKey("Advanced", String.class,
+"user.vm.DenyListed.details", "rootdisksize, cpuOvercommitRatio,
memoryOvercommitRatio, Message.ReservedCapacityFreed.Flag",
Review comment:
I've fixed incorrect case change - sloppy C&P
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4130: Fixed null pointer after deleting snapshot, GC and cross cluster vm migration on XCP-NG
blueorangutan commented on pull request #4130: URL: https://github.com/apache/cloudstack/pull/4130#issuecomment-640999655 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4003: Logging framework to use only log4j
blueorangutan commented on pull request #4003: URL: https://github.com/apache/cloudstack/pull/4003#issuecomment-640763889 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4007: Restarting all networks that needs a restart in a VPC
rhtyd commented on pull request #4007: URL: https://github.com/apache/cloudstack/pull/4007#issuecomment-640998275 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8 Support
rhtyd commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-641172607 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4104: Debian10 support
rhtyd commented on pull request #4104: URL: https://github.com/apache/cloudstack/pull/4104#issuecomment-640995834 Checked test failures not related to this PR on XenServer, overall all tests have passed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4007: Restarting all networks that needs a restart in a VPC
blueorangutan commented on pull request #4007: URL: https://github.com/apache/cloudstack/pull/4007#issuecomment-640998555 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4109: add support for XCP-ng 7/8 to create it's heartbeat LVM properly
shwstppr commented on pull request #4109: URL: https://github.com/apache/cloudstack/pull/4109#issuecomment-641258592 Packaging OK! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4131: Health Checkplease don't merge this
rhtyd commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-640998970 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] vladimirpetrov commented on pull request #4117: [VMware] Explicitly controlling VM hardware version
vladimirpetrov commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-640681675 The following tests have passed successfully: - Datacenter - version not set, Cluster version not set - hardware version reported as the host's - OK - Datacenter - version set to X, Cluster set to version Y - hardware version reported as Y - OK - Datacenter - version not set Cluster set to version Y - hardware version reported as Y - OK - Datacenter - version set to X, Cluster version not set - hardware version reported as X - OK This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4135: Remove use of blacklist/whitelist terms
blueorangutan commented on pull request #4135: URL: https://github.com/apache/cloudstack/pull/4135#issuecomment-640790750 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4003: Logging framework to use only log4j
harikrishna-patnala commented on pull request #4003: URL: https://github.com/apache/cloudstack/pull/4003#issuecomment-640763442 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4071: Dynamic roles improvements
rhtyd commented on a change in pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#discussion_r437203881 ## File path: engine/schema/src/main/resources/META-INF/db/schema-41400to41500.sql ## @@ -18,3 +18,81 @@ --; -- Schema upgrade from 4.14.0.0 to 4.15.0.0 --; + +ALTER TABLE `cloud`.`roles` ADD COLUMN `is_default` tinyint(1) NOT NULL DEFAULT '0' COMMENT 'is this a default role'; +UPDATE `cloud`.`roles` SET `is_default` = 1 WHERE id IN (1, 2, 3, 4); + +-- Updated Default CloudStack roles with read-only and support admin and user roles +INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Read-Only Admin', 'Admin', 'Default read-only admin role', 1) ON DUPLICATE KEY UPDATE name=name; +INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Read-Only User', 'User', 'Default read-only user role', 1) ON DUPLICATE KEY UPDATE name=name; +INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'Admin-Support', 'Admin', 'Default admin support role', 1) ON DUPLICATE KEY UPDATE name=name; +INSERT INTO `cloud`.`roles` (`uuid`, `name`, `role_type`, `description`, `is_default`) VALUES (UUID(), 'User-Support', 'User', 'Default user support role', 1) ON DUPLICATE KEY UPDATE name=name; + +-- Role permissions for Read-Only Admin +SELECT id INTO @ReadOnlyAdminRoleId FROM `cloud`.`roles` WHERE name = 'Read-Only Admin' AND is_default = 1; +SELECT @ReadOnlyAdminSortOrder:=-1; Review comment: With a debugger I found that execution fails for mvn deploydb with: ``` > Processing upgrade: com.cloud.upgrade.DatabaseUpgradeChecker [WARNING] java.lang.reflect.InvocationTargetException at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62) at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke (Method.java:566) at org.codehaus.mojo.exec.ExecJavaMojo$1.run (ExecJavaMojo.java:297) at java.lang.Thread.run (Thread.java:834) Caused by: com.cloud.utils.exception.CloudRuntimeException: Unable to upgrade the database at com.cloud.upgrade.DatabaseUpgradeChecker.upgrade (DatabaseUpgradeChecker.java:271) at com.cloud.upgrade.DatabaseUpgradeChecker.check (DatabaseUpgradeChecker.java:342) at com.cloud.upgrade.DatabaseCreator.main (DatabaseCreator.java:217) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62) at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke (Method.java:566) at org.codehaus.mojo.exec.ExecJavaMojo$1.run (ExecJavaMojo.java:297) at java.lang.Thread.run (Thread.java:834) Caused by: com.cloud.utils.exception.CloudRuntimeException: Unable to execute upgrade script at com.cloud.upgrade.DatabaseUpgradeChecker.runScript (DatabaseUpgradeChecker.java:209) at com.cloud.upgrade.DatabaseUpgradeChecker.upgrade (DatabaseUpgradeChecker.java:258) at com.cloud.upgrade.DatabaseUpgradeChecker.check (DatabaseUpgradeChecker.java:342) at com.cloud.upgrade.DatabaseCreator.main (DatabaseCreator.java:217) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62) at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke (Method.java:566) at org.codehaus.mojo.exec.ExecJavaMojo$1.run (ExecJavaMojo.java:297) at java.lang.Thread.run (Thread.java:834) Caused by: java.sql.SQLException: Column index out of range. at com.cloud.utils.db.ScriptRunner.runScript (ScriptRunner.java:185) at com.cloud.utils.db.ScriptRunner.runScript (ScriptRunner.java:87) at com.cloud.upgrade.DatabaseUpgradeChecker.runScript (DatabaseUpgradeChecker.java:203) at com.cloud.upgrade.DatabaseUpgradeChecker.upgrade (DatabaseUpgradeChecker.java:258) at com.cloud.upgrade.DatabaseUpgradeChecker.check (DatabaseUpgradeChecker.java:342) at com.cloud.upgrade.DatabaseCreator.main (DatabaseCreator.java:217) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62) at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke (Method.java:566) at org.codehaus.mojo.exec.ExecJavaM
