[cloudstack-primate] 01/02: views: show doclink icon for custom action forms
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git
commit 2da9ad3b30af66a17970e19b5aa25850c62126cf
Author: Rohit Yadav
AuthorDate: Wed Jun 24 14:20:36 2020 +0530
views: show doclink icon for custom action forms
Signed-off-by: Rohit Yadav
---
src/views/AutogenView.vue | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/src/views/AutogenView.vue b/src/views/AutogenView.vue
index 3afcb88..c8a0f5f 100644
--- a/src/views/AutogenView.vue
+++ b/src/views/AutogenView.vue
@@ -82,7 +82,6 @@
+
+{{ $t(currentAction.label) }}
+
+
+
+
[cloudstack-primate] branch master updated (d1b4f09 -> 6fc4c5c)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git. from d1b4f09 config: fix column label to say VM name for backups in listview new 2da9ad3 views: show doclink icon for custom action forms new 6fc4c5c infocard: show project for resources having a projectid The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/components/view/InfoCard.vue | 7 +++ src/views/AutogenView.vue| 11 ++- 2 files changed, 17 insertions(+), 1 deletion(-)
[cloudstack-primate] 02/02: infocard: show project for resources having a projectid
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git
commit 6fc4c5c70420b323411f015732ca0305935b1582
Author: Rohit Yadav
AuthorDate: Thu Jun 25 11:23:56 2020 +0530
infocard: show project for resources having a projectid
Signed-off-by: Rohit Yadav
---
src/components/view/InfoCard.vue | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/components/view/InfoCard.vue b/src/components/view/InfoCard.vue
index 722a89b..6df6c4d 100644
--- a/src/components/view/InfoCard.vue
+++ b/src/components/view/InfoCard.vue
@@ -285,6 +285,13 @@
{{ resource.ipaddress }}
+
+ {{ $t('label.project')
}}
+
+
+{{
resource.project || resource.projectname || resource.projectid }}
+
+
[GitHub] [cloudstack] rhtyd commented on issue #4159: Fail to deploy VM with Ceph (Octopus) as primary storage
rhtyd commented on issue #4159: URL: https://github.com/apache/cloudstack/issues/4159#issuecomment-649229613 +1 Once done, please also send a PR to 4.14 branch to bump the dependency version in pom.xml @wido thnx This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] wido commented on issue #4159: Fail to deploy VM with Ceph (Octopus) as primary storage
wido commented on issue #4159: URL: https://github.com/apache/cloudstack/issues/4159#issuecomment-649227916 I tagged rados-java 0.6.0. Now I need to find somebody who can put it in Maven Central. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch master updated (cbbb401 -> 3ede1ea)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from cbbb401 Merge remote-tracking branch 'origin/4.14' add b534d2b vr: fix backup router health check (#4171) add b79407c api: Adding missing fields to API responses (#4167) add 5526342 server: Do not resize volume of running vm on KVM host if host is not Up or not Enabled (#4148) add 26f4edf Merge remote-tracking branch 'origin/4.13' into 4.14 new 3ede1ea Merge remote-tracking branch 'origin/4.14' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../org/apache/cloudstack/api/ApiConstants.java| 3 +++ .../api/response/DomainRouterResponse.java | 16 +++ .../cloudstack/api/response/IPAddressResponse.java | 11 +- .../api/response/PrivateGatewayResponse.java | 10 - .../api/response/Site2SiteVpnGatewayResponse.java | 8 .../cloudstack/api/response/SystemVmResponse.java | 24 ++ .../cloudstack/api/response/UserVmResponse.java| 13 +++- .../cloudstack/api/response/VpcResponse.java | 8 .../main/java/com/cloud/api/ApiResponseHelper.java | 6 ++ .../api/query/dao/DomainRouterJoinDaoImpl.java | 13 +++- .../com/cloud/api/query/dao/UserVmJoinDaoImpl.java | 7 ++- .../router/VirtualNetworkApplianceManagerImpl.java | 7 ++- .../com/cloud/storage/VolumeApiServiceImpl.java| 17 +++ 13 files changed, 137 insertions(+), 6 deletions(-)
[GitHub] [cloudstack] rhtyd closed issue #4163: health check gateways_check.py for redundant VR will fail for BACKUP router
rhtyd closed issue #4163: URL: https://github.com/apache/cloudstack/issues/4163 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.14'
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 3ede1eaa4985f78fc52016f14b138d3a1a367b26 Merge: cbbb401 26f4edf Author: Rohit Yadav AuthorDate: Thu Jun 25 10:48:02 2020 +0530 Merge remote-tracking branch 'origin/4.14' .../org/apache/cloudstack/api/ApiConstants.java| 3 +++ .../api/response/DomainRouterResponse.java | 16 +++ .../cloudstack/api/response/IPAddressResponse.java | 11 +- .../api/response/PrivateGatewayResponse.java | 10 - .../api/response/Site2SiteVpnGatewayResponse.java | 8 .../cloudstack/api/response/SystemVmResponse.java | 24 ++ .../cloudstack/api/response/UserVmResponse.java| 13 +++- .../cloudstack/api/response/VpcResponse.java | 8 .../main/java/com/cloud/api/ApiResponseHelper.java | 6 ++ .../api/query/dao/DomainRouterJoinDaoImpl.java | 13 +++- .../com/cloud/api/query/dao/UserVmJoinDaoImpl.java | 7 ++- .../router/VirtualNetworkApplianceManagerImpl.java | 7 ++- .../com/cloud/storage/VolumeApiServiceImpl.java| 17 +++ 13 files changed, 137 insertions(+), 6 deletions(-)
[cloudstack] branch 4.14 updated (b534d2b -> 26f4edf)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.14 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from b534d2b vr: fix backup router health check (#4171) add b79407c api: Adding missing fields to API responses (#4167) add 5526342 server: Do not resize volume of running vm on KVM host if host is not Up or not Enabled (#4148) new 26f4edf Merge remote-tracking branch 'origin/4.13' into 4.14 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../org/apache/cloudstack/api/ApiConstants.java| 3 +++ .../api/response/DomainRouterResponse.java | 16 +++ .../cloudstack/api/response/IPAddressResponse.java | 11 +- .../api/response/PrivateGatewayResponse.java | 10 - .../api/response/Site2SiteVpnGatewayResponse.java | 8 .../cloudstack/api/response/SystemVmResponse.java | 24 ++ .../cloudstack/api/response/UserVmResponse.java| 13 +++- .../cloudstack/api/response/VpcResponse.java | 8 .../main/java/com/cloud/api/ApiResponseHelper.java | 6 ++ .../api/query/dao/DomainRouterJoinDaoImpl.java | 13 +++- .../com/cloud/api/query/dao/UserVmJoinDaoImpl.java | 7 ++- .../com/cloud/storage/VolumeApiServiceImpl.java| 17 +++ 12 files changed, 131 insertions(+), 5 deletions(-)
[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.13' into 4.14
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.14
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
commit 26f4edff34b2b05081548ba593763ae55505cedf
Merge: b534d2b 5526342
Author: Rohit Yadav
AuthorDate: Thu Jun 25 10:42:15 2020 +0530
Merge remote-tracking branch 'origin/4.13' into 4.14
Signed-off-by: Rohit Yadav
.../org/apache/cloudstack/api/ApiConstants.java| 3 +++
.../api/response/DomainRouterResponse.java | 16 +++
.../cloudstack/api/response/IPAddressResponse.java | 11 +-
.../api/response/PrivateGatewayResponse.java | 10 -
.../api/response/Site2SiteVpnGatewayResponse.java | 8
.../cloudstack/api/response/SystemVmResponse.java | 24 ++
.../cloudstack/api/response/UserVmResponse.java| 13 +++-
.../cloudstack/api/response/VpcResponse.java | 8
.../main/java/com/cloud/api/ApiResponseHelper.java | 6 ++
.../api/query/dao/DomainRouterJoinDaoImpl.java | 13 +++-
.../com/cloud/api/query/dao/UserVmJoinDaoImpl.java | 7 ++-
.../com/cloud/storage/VolumeApiServiceImpl.java| 17 +++
12 files changed, 131 insertions(+), 5 deletions(-)
diff --cc
api/src/main/java/org/apache/cloudstack/api/response/UserVmResponse.java
index b8b0189,b37e1c8..44eaba7
--- a/api/src/main/java/org/apache/cloudstack/api/response/UserVmResponse.java
+++ b/api/src/main/java/org/apache/cloudstack/api/response/UserVmResponse.java
@@@ -298,14 -290,10 +298,18 @@@ public class UserVmResponse extends Bas
@Param(description = "OS type id of the vm", since = "4.4")
private String osTypeId;
+ @SerializedName(ApiConstants.OS_DISPLAY_NAME)
+ @Param(description = "OS name of the vm", since = "4.13.2")
+ private String osDisplayName;
+
+@SerializedName(ApiConstants.BOOT_MODE)
+@Param(description = "Guest vm Boot Mode")
+private String bootMode;
+
+@SerializedName(ApiConstants.BOOT_TYPE)
+@Param(description = "Guest vm Boot Type")
+private String bootType;
+
public UserVmResponse() {
securityGroupList = new LinkedHashSet();
nics = new LinkedHashSet();
@@@ -882,12 -858,7 +890,15 @@@
return osTypeId;
}
+ public String getOsDisplayName() {
+ return osDisplayName;
+ }
++
+public String getBootType() { return bootType; }
+
+public void setBootType(String bootType) { this.bootType = bootType; }
+
+public String getBootMode() { return bootMode; }
+
+public void setBootMode(String bootMode) { this.bootMode = bootMode; }
-
}
[GitHub] [cloudstack] rhtyd commented on pull request #4148: server: Do not resize volume of running vm on KVM host if host is not Up or not Enabled
rhtyd commented on pull request #4148: URL: https://github.com/apache/cloudstack/pull/4148#issuecomment-64916 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch 4.13 updated (b79407c -> 5526342)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.13 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from b79407c api: Adding missing fields to API responses (#4167) add 5526342 server: Do not resize volume of running vm on KVM host if host is not Up or not Enabled (#4148) No new revisions were added by this update. Summary of changes: .../java/com/cloud/storage/VolumeApiServiceImpl.java| 17 + 1 file changed, 17 insertions(+)
[GitHub] [cloudstack] rhtyd merged pull request #4148: server: Do not resize volume of running vm on KVM host if host is not Up or not Enabled
rhtyd merged pull request #4148: URL: https://github.com/apache/cloudstack/pull/4148 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4171: vr: fix backup router health check
rhtyd merged pull request #4171: URL: https://github.com/apache/cloudstack/pull/4171 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch 4.14 updated: vr: fix backup router health check (#4171)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.14
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.14 by this push:
new b534d2b vr: fix backup router health check (#4171)
b534d2b is described below
commit b534d2bdff629ee2706c185eab728fe61cb46fd6
Author: Abhishek Kumar
AuthorDate: Thu Jun 25 10:37:42 2020 +0530
vr: fix backup router health check (#4171)
Fixes #4163
Added excluded tests in the code for BACKUP router.
Signed-off-by: Abhishek Kumar
---
.../cloud/network/router/VirtualNetworkApplianceManagerImpl.java | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git
a/server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
b/server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
index c895307..0769258 100644
---
a/server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
+++
b/server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
@@ -278,6 +278,7 @@ public class VirtualNetworkApplianceManagerImpl extends
ManagerBase implements V
Configurable, StateListener {
private static final Logger s_logger =
Logger.getLogger(VirtualNetworkApplianceManagerImpl.class);
private static final String CONNECTIVITY_TEST = "connectivity.test";
+private static final String BACKUP_ROUTER_EXCLUDED_TESTS =
"gateways_check.py";
@Inject private EntityManager _entityMgr;
@Inject private DataCenterDao _dcDao;
@@ -1632,7 +1633,11 @@ Configurable, StateListener
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4171: vr: fix backup router health check
rhtyd commented on a change in pull request #4171:
URL: https://github.com/apache/cloudstack/pull/4171#discussion_r445302286
##
File path:
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
##
@@ -1632,7 +1633,11 @@ private SetMonitorServiceCommand
createMonitorServiceCommand(DomainRouterVO rout
command.setAccessDetail(SetMonitorServiceCommand.ROUTER_HEALTH_CHECKS_ENABLED,
RouterHealthChecksEnabled.value().toString());
command.setAccessDetail(SetMonitorServiceCommand.ROUTER_HEALTH_CHECKS_BASIC_INTERVAL,
RouterHealthChecksBasicInterval.value().toString());
command.setAccessDetail(SetMonitorServiceCommand.ROUTER_HEALTH_CHECKS_ADVANCED_INTERVAL,
RouterHealthChecksAdvancedInterval.value().toString());
-
command.setAccessDetail(SetMonitorServiceCommand.ROUTER_HEALTH_CHECKS_EXCLUDED,
RouterHealthChecksToExclude.valueIn(router.getDataCenterId()));
+String excludedTests =
RouterHealthChecksToExclude.valueIn(router.getDataCenterId());
+if (router.getIsRedundantRouter() &&
RedundantState.BACKUP.equals(router.getRedundantState())) {
+excludedTests = excludedTests.isEmpty() ?
BACKUP_ROUTER_EXCLUDED_TESTS : excludedTests + "," +
BACKUP_ROUTER_EXCLUDED_TESTS;
Review comment:
Add a null or empty check
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4171: vr: fix backup router health check
rhtyd commented on a change in pull request #4171:
URL: https://github.com/apache/cloudstack/pull/4171#discussion_r445302286
##
File path:
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
##
@@ -1632,7 +1633,11 @@ private SetMonitorServiceCommand
createMonitorServiceCommand(DomainRouterVO rout
command.setAccessDetail(SetMonitorServiceCommand.ROUTER_HEALTH_CHECKS_ENABLED,
RouterHealthChecksEnabled.value().toString());
command.setAccessDetail(SetMonitorServiceCommand.ROUTER_HEALTH_CHECKS_BASIC_INTERVAL,
RouterHealthChecksBasicInterval.value().toString());
command.setAccessDetail(SetMonitorServiceCommand.ROUTER_HEALTH_CHECKS_ADVANCED_INTERVAL,
RouterHealthChecksAdvancedInterval.value().toString());
-
command.setAccessDetail(SetMonitorServiceCommand.ROUTER_HEALTH_CHECKS_EXCLUDED,
RouterHealthChecksToExclude.valueIn(router.getDataCenterId()));
+String excludedTests =
RouterHealthChecksToExclude.valueIn(router.getDataCenterId());
+if (router.getIsRedundantRouter() &&
RedundantState.BACKUP.equals(router.getRedundantState())) {
+excludedTests = excludedTests.isEmpty() ?
BACKUP_ROUTER_EXCLUDED_TESTS : excludedTests + "," +
BACKUP_ROUTER_EXCLUDED_TESTS;
Review comment:
Add a null or empty check
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[cloudstack] branch 4.13 updated (c03f8a1 -> b79407c)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.13 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from c03f8a1 server: Adding listall to listLdapConfigurations (#4164) add b79407c api: Adding missing fields to API responses (#4167) No new revisions were added by this update. Summary of changes: .../org/apache/cloudstack/api/ApiConstants.java| 3 +++ .../api/response/DomainRouterResponse.java | 16 +++ .../cloudstack/api/response/IPAddressResponse.java | 11 +- .../api/response/PrivateGatewayResponse.java | 10 - .../api/response/Site2SiteVpnGatewayResponse.java | 8 .../cloudstack/api/response/SystemVmResponse.java | 24 ++ .../cloudstack/api/response/UserVmResponse.java| 12 +++ .../cloudstack/api/response/VpcResponse.java | 8 .../main/java/com/cloud/api/ApiResponseHelper.java | 6 ++ .../api/query/dao/DomainRouterJoinDaoImpl.java | 13 +++- .../com/cloud/api/query/dao/UserVmJoinDaoImpl.java | 7 ++- 11 files changed, 114 insertions(+), 4 deletions(-)
[GitHub] [cloudstack] rhtyd closed issue #4161: List API name params response missing though ids are returned
rhtyd closed issue #4161: URL: https://github.com/apache/cloudstack/issues/4161 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4167: Adding missing fields to API responses
rhtyd merged pull request #4167: URL: https://github.com/apache/cloudstack/pull/4167 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4171: vr: fix backup router health check
blueorangutan commented on pull request #4171: URL: https://github.com/apache/cloudstack/pull/4171#issuecomment-649208709 Trillian test result (tid-1840) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 35412 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4171-t1840-kvm-centos7.zip Smoke tests completed. 83 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4176: server: Purge all cookies on logout, set /client path on login
blueorangutan commented on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-649205477 Trillian test result (tid-1841) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 29723 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4176-t1841-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 75 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 173.24 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 174.12 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 250.55 | test_privategw_acl.py test_hostha_kvm_host_degraded | `Error` | 7.57 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4138: Fixed incorrect error message on invalid template type download
blueorangutan commented on pull request #4138: URL: https://github.com/apache/cloudstack/pull/4138#issuecomment-649198647 Trillian test result (tid-1833) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 59748 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4138-t1833-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 55 look OK, 22 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 179.50 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 174.21 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 238.73 | test_privategw_acl.py ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py test_01_sys_vm_start | `Failure` | 0.54 | test_secondary_storage.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.29 | test_service_offerings.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py test_02_list_cpvm_vm | `Failure` | 0.03 | test_ssvm.py test_03_ssvm_internals | `Failure` | 0.03 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.02 | test_ssvm.py test_05_stop_ssvm | `Failure` | 0.03 | test_ssvm.py test_06_stop_cpvm | `Failure` | 0.03 | test_ssvm.py test_07_reboot_ssvm | `Failure` | 0.03 | test_ssvm.py test_08_reboot_cpvm | `Failure` | 0.02 | test_ssvm.py test_09_destroy_ssvm | `Failure` | 0.03 | test_ssvm.py test_10_destroy_cpvm | `Failure` | 0.02 | test_ssvm.py test_02_create_template_with_checksum_sha1 | `Error` | 65.38 | test_templates.py test_03_create_template_with_checksum_sha256 | `Error` | 65.38 | test_templates.py test_04_create_template_with_checksum_md5 | `Error` | 65.37 | test_templates.py test_05_create_template_with_no_checksum | `Error` | 65.36 | test_templates.py
[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-649182503 Trillian test result (tid-1838) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44137 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4128-t1838-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 82 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_add_delete_kubernetes_supported_version | `Error` | 1808.15 | test_kubernetes_supported_versions.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 376.90 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4167: Adding missing fields to API responses
blueorangutan commented on pull request #4167: URL: https://github.com/apache/cloudstack/pull/4167#issuecomment-649153348 Trillian test result (tid-1839) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34930 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4167-t1839-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 76 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 222.48 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 217.03 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 954.97 | test_privategw_acl.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4159: Fail to deploy VM with Ceph (Octopus) as primary storage
rhtyd commented on issue #4159: URL: https://github.com/apache/cloudstack/issues/4159#issuecomment-649144130 Thanks @wido This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4167: Adding missing fields to API responses
blueorangutan commented on pull request #4167: URL: https://github.com/apache/cloudstack/pull/4167#issuecomment-649143961 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4167: Adding missing fields to API responses
rhtyd commented on pull request #4167: URL: https://github.com/apache/cloudstack/pull/4167#issuecomment-649143567 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4167: Adding missing fields to API responses
blueorangutan commented on pull request #4167: URL: https://github.com/apache/cloudstack/pull/4167#issuecomment-649139301 Trillian test result (tid-1830) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 59482 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4167-t1830-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 55 look OK, 22 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 176.11 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 173.99 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 236.34 | test_privategw_acl.py ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py test_01_sys_vm_start | `Failure` | 0.08 | test_secondary_storage.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.15 | test_service_offerings.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py test_01_list_sec_storage_vm | `Failure` | 0.06 | test_ssvm.py test_02_list_cpvm_vm | `Failure` | 0.06 | test_ssvm.py test_03_ssvm_internals | `Failure` | 0.08 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.09 | test_ssvm.py test_05_stop_ssvm | `Failure` | 0.06 | test_ssvm.py test_06_stop_cpvm | `Failure` | 0.06 | test_ssvm.py test_07_reboot_ssvm | `Failure` | 0.06 | test_ssvm.py test_08_reboot_cpvm | `Failure` | 0.11 | test_ssvm.py test_09_destroy_ssvm | `Failure` | 0.11 | test_ssvm.py test_10_destroy_cpvm | `Failure` | 0.10 | test_ssvm.py test_02_create_template_with_checksum_sha1 | `Error` | 65.38 | test_templates.py test_03_create_template_with_checksum_sha256 | `Error` | 65.37 | test_templates.py test_04_create_template_with_checksum_md5 | `Error` | 65.37 | test_templates.py test_05_create_template_with_no_checksum | `Error` | 65.37 | test_templates.py
[GitHub] [cloudstack] nvazquez commented on a change in pull request #4172: [VMware] Support to attach more than 15 data disks in VMware VM
nvazquez commented on a change in pull request #4172:
URL: https://github.com/apache/cloudstack/pull/4172#discussion_r445223266
##
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##
@@ -2098,10 +2101,17 @@ protected StartAnswer execute(StartCommand cmd) {
assert (volumeDsDetails != null);
String[] diskChain = syncDiskChain(dcMo, vmMo, vmSpec,
vol, matchingExistingDisk, dataStoresDetails);
-if (controllerKey == scsiControllerKey &&
VmwareHelper.isReservedScsiDeviceNumber(scsiUnitNumber))
+
+int deviceNumber = -1;
+if (controllerKey ==
vmMo.getIDEControllerKey(ideUnitNumber)) {
+deviceNumber = (ideUnitNumber %
VmwareHelper.MAX_ALLOWED_DEVICES_IDE_CONTROLLER);
Review comment:
Also minor: unnecessary parenthesis
##
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##
@@ -2068,13 +2068,16 @@ protected StartAnswer execute(StartCommand cmd) {
}
}
} else {
-controllerKey =
vmMo.getScsiDiskControllerKeyNoException(diskController);
+if
(VmwareHelper.isReservedScsiDeviceNumber(scsiUnitNumber))
Review comment:
Minor one: can you please add braces to this if statement?
##
File path:
vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java
##
@@ -2412,6 +2419,23 @@ public void ensureScsiDeviceControllers(int count, int
availableBusNum) throws E
}
}
+private boolean isValidScsiDiskController(VirtualSCSIController
scsiDiskController) {
+if (scsiDiskController == null) {
+return false;
+}
+
+List scsiDiskDevicesOnController =
scsiDiskController.getDevice();
+if (scsiDiskDevicesOnController != null &&
scsiDiskDevicesOnController.size() >=
(VmwareHelper.MAX_SUPPORTED_DEVICES_SCSI_CONTROLLER)) {
Review comment:
Maybe also a null check for scsiDiskDevicesOnController?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4103: [VMware] Enable unmanaging guest VMs
nvazquez commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-649120711 @andrijapanicsb @borisstoyanov @rhtyd tests are looking good, are you ok to merge this one? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4053: Secondary Storage Usage Improvements
blueorangutan commented on pull request #4053: URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-649104295 Trillian test result (tid-1836) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28843 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4053-t1836-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_direct_download.py Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py Intermittent failure detected: /marvin/tests/smoke/test_nic.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 74 look OK, 9 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestDirectDownloadTemplates>:setup | `Error` | 0.00 | test_direct_download.py ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py test_01_nic | `Error` | 54.26 | test_nic.py test_01_create_template | `Error` | 28.78 | test_templates.py test_CreateTemplateWithDuplicateName | `Error` | 29.89 | test_templates.py test_01_register_template_direct_download_flag | `Error` | 0.12 | test_templates.py test_02_deploy_vm_from_direct_download_template | `Error` | 0.00 | test_templates.py test_03_deploy_vm_wrong_checksum | `Error` | 0.10 | test_templates.py ContextSuite context=TestTemplates>:setup | `Error` | 294.47 | test_templates.py test_01_template_usage | `Error` | 31.13 | test_usage.py ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py test_disable_oobm_ha_state_ineligible | `Error` | 0.28 | test_hostha_kvm.py test_hostha_configure_default_driver | `Error` | 0.28 | test_hostha_kvm.py test_hostha_enable_ha_when_host_disabled | `Error` | 0.28 | test_hostha_kvm.py test_hostha_enable_ha_when_host_disconected | `Error` | 0.24 | test_hostha_kvm.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 0.25 | test_hostha_kvm.py test_hostha_kvm_host_degraded | `Error` | 0.23 | test_hostha_kvm.py test_hostha_kvm_host_fencing | `Error` | 0.22 | test_hostha_kvm.py test_hostha_kvm_host_recovering | `Error` | 0.25 | test_hostha_kvm.py test_remove_ha_provider_not_possible | `Error` | 0.25 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3976: Enable sending hypervior host name via metadata - VR and Config Drive
blueorangutan commented on pull request #3976: URL: https://github.com/apache/cloudstack/pull/3976#issuecomment-649098348 Trillian test result (tid-1832) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44701 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3976-t1832-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 82 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_redundant_vpc_site2site_vpn | `Failure` | 290.28 | test_vpc_vpn.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4148: server: Do not resize volume of running vm on KVM host if host is not Up or not Enabled
blueorangutan commented on pull request #4148: URL: https://github.com/apache/cloudstack/pull/4148#issuecomment-649098018 Trillian test result (tid-1834) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28154 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4148-t1834-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Smoke tests completed. 76 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 174.28 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 174.93 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 233.75 | test_privategw_acl.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher opened a new pull request #4177: Prevent deploying IPv6 network if Zone has no IPv6 DNS configured
GabrielBrascher opened a new pull request #4177: URL: https://github.com/apache/cloudstack/pull/4177 ## Description If an IPv6 enabled network is created but the Zone hasn't IPv6 DNS1 or DNS2 configured then **dnsmasq** inside the Virtual Router does not start. This PRs adds validation that allows creating an IPv6 network only if the Zone has at least DNS1 or DNS2 configured. Fixes: #4157 ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4165: Allow renaming cluster, host, and storage
GabrielBrascher commented on pull request #4165: URL: https://github.com/apache/cloudstack/pull/4165#issuecomment-649052159 @rhtyd thanks for the feedback, I will prevent cluster renaming on VMware then (maybe on Xenserver as well). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4165: Allow renaming cluster, host, and storage
GabrielBrascher commented on pull request #4165: URL: https://github.com/apache/cloudstack/pull/4165#issuecomment-649051861 @nvazquez thanks for the review! I think that I already did the necessary changes in the method `updateCluster` at `RollingMaintenanceManagerImpl`. Please let me know if I am missing something. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4116: cks: fix template, deployment issues
blueorangutan commented on pull request #4116: URL: https://github.com/apache/cloudstack/pull/4116#issuecomment-649047077 @shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4116: cks: fix template, deployment issues
shwstppr commented on pull request #4116: URL: https://github.com/apache/cloudstack/pull/4116#issuecomment-649046475 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4116: cks: fix template, deployment issues
blueorangutan commented on pull request #4116: URL: https://github.com/apache/cloudstack/pull/4116#issuecomment-649027768 Packaging result: ✔centos7 ✔debian. JID-1454 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4176: server: Purge all cookies on logout, set /client path on login
blueorangutan commented on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-649022023 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4176: server: Purge all cookies on logout, set /client path on login
rhtyd commented on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-649021528 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #4116: cks: fix template, deployment issues
shwstppr commented on a change in pull request #4116:
URL: https://github.com/apache/cloudstack/pull/4116#discussion_r445115883
##
File path:
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java
##
@@ -300,8 +294,7 @@ private boolean
isKubernetesServiceTemplateConfigured(DataCenter zone) {
LOGGER.warn(String.format("Unable to find the template %s to
be used for provisioning Kubernetes cluster nodes", templateName));
return false;
}
-List listZoneTemplate =
templateZoneDao.listByZoneTemplate(zone.getId(), template.getId());
-if (listZoneTemplate == null || listZoneTemplate.isEmpty()) {
+if
(CollectionUtils.isEmpty(templateJoinDao.newTemplateView(template,
zone.getId(), true))) {
Review comment:
@DaanHoogland thanks for pointing it. I'll check that again
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4116: cks: fix template, deployment issues
blueorangutan commented on pull request #4116: URL: https://github.com/apache/cloudstack/pull/4116#issuecomment-649014909 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4116: cks: fix template, deployment issues
shwstppr commented on pull request #4116: URL: https://github.com/apache/cloudstack/pull/4116#issuecomment-649014429 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr closed pull request #4134: cks: fix k8s cluster network deletion
shwstppr closed pull request #4134: URL: https://github.com/apache/cloudstack/pull/4134 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4134: cks: fix k8s cluster network deletion
shwstppr commented on pull request #4134: URL: https://github.com/apache/cloudstack/pull/4134#issuecomment-649012515 Moved #4116 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr closed pull request #4115: cks: fix k8s cluster deployment planner
shwstppr closed pull request #4115: URL: https://github.com/apache/cloudstack/pull/4115 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr edited a comment on pull request #4115: cks: fix k8s cluster deployment planner
shwstppr edited a comment on pull request #4115: URL: https://github.com/apache/cloudstack/pull/4115#issuecomment-649011685 Moved #4116 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4115: cks: fix k8s cluster deployment planner
shwstppr commented on pull request #4115: URL: https://github.com/apache/cloudstack/pull/4115#issuecomment-649011685 Closed in favour of #4116 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4175: Redfish Client & Redfish OOBM Driver
GabrielBrascher commented on a change in pull request #4175:
URL: https://github.com/apache/cloudstack/pull/4175#discussion_r445108884
##
File path:
utils/src/main/java/org/apache/cloudstack/utils/redfish/RedfishClient.java
##
@@ -0,0 +1,378 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+package org.apache.cloudstack.utils.redfish;
+
+import java.io.BufferedReader;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.io.UnsupportedEncodingException;
+import java.net.URISyntaxException;
+import java.nio.charset.StandardCharsets;
+import java.security.KeyManagementException;
+import java.security.NoSuchAlgorithmException;
+import java.util.Base64;
+
+import javax.net.ssl.HostnameVerifier;
+import javax.net.ssl.HttpsURLConnection;
+import javax.net.ssl.SSLContext;
+import javax.net.ssl.SSLSession;
+import javax.net.ssl.TrustManager;
+
+import com.cloud.utils.nio.TrustAllManager;
+import org.apache.commons.httpclient.HttpStatus;
+import org.apache.commons.lang.StringUtils;
+import org.apache.http.HttpResponse;
+import org.apache.http.client.HttpClient;
+import org.apache.http.client.methods.CloseableHttpResponse;
+import org.apache.http.client.methods.HttpGet;
+import org.apache.http.client.methods.HttpPost;
+import org.apache.http.client.utils.URIBuilder;
+import org.apache.http.conn.ssl.SSLConnectionSocketFactory;
+import org.apache.http.entity.StringEntity;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClientBuilder;
+import org.apache.http.protocol.HTTP;
+import org.apache.log4j.Logger;
+
+import com.cloud.utils.net.NetUtils;
+import com.google.common.net.InternetDomainName;
+import com.google.gson.JsonArray;
+import com.google.gson.JsonObject;
+import com.google.gson.JsonParser;
+
+/**
+ * Provides support to a set of REST requests that can be sent to a Redfish
Server.
+ * RedfishClient allows to gather the server Power State, and execute Reset
+ * actions such as 'On', 'ForceOff', 'GracefulShutdown', 'GracefulRestart' etc.
+ */
+public class RedfishClient {
+
+private static final Logger LOGGER = Logger.getLogger(RedfishClient.class);
+
+private String username;
+private String password;
+private boolean useHttps;
+private boolean ignoreSsl;
+
+private final static String SYSTEMS_URL_PATH = "redfish/v1/Systems/";
+private final static String COMPUTER_SYSTEM_RESET_URL_PATH =
"/Actions/ComputerSystem.Reset";
+private final static String REDFISH_RESET_TYPE = "ResetType";
+private final static String POWER_STATE = "PowerState";
+private final static String APPLICATION_JSON = "application/json";
+private final static String ACCEPT = "accept";
+private final static String ODATA_ID = "@odata.id";
+private final static String MEMBERS = "Members";
+private final static String EXPECTED_HTTP_STATUS = "2XX";
+
+/**
+ * Redfish Command type:
+ * ComputerSystemReset: execute Redfish reset commands ({@link
RedfishResetCmd}).
+ * GetSystemId: get the system ID.
+ * GetPowerState: used for get the system power state.
+ */
+public enum
+RedfishCmdType {
+ComputerSystemReset, GetSystemId, GetPowerState
+}
+
+/**
+ * Redfish System Power State:
+ * Off: The state is powered Off.
+ * On: The state is powered On.
+ * PoweringOff: A temporary state between On and Off.
+ * PoweringOn: A temporary state between Off and On.
+ */
+public enum RedfishPowerState {
+On, Off, PoweringOn, PoweringOff
+}
+
+/**
+ *
+ * ForceOff: Turn the unit off immediately (non-graceful
shutdown).
+ * ForceOn: Turn the unit on immediately.
+ * ForceRestart: Perform an immediate (non-graceful) shutdown,
+ * followed by a restart.
+ * GracefulRestart: Perform a graceful shutdown followed by a
restart
+ * of the system.
+ * GracefulShutdown: Perform a graceful shutdown and power off.
+ * Nmi: Generate a Diagnostic Interrupt (usually an NMI on x86
+ * systems) to cease normal operations, perform diagnostic actions and
typically
+ * halt the system.
+ * On:
[GitHub] [cloudstack] blueorangutan commented on pull request #4176: server: Purge all cookies on logout, set /client path on login
blueorangutan commented on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-649001993 Packaging result: ✔centos7 ✔debian. JID-1453 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4175: Redfish Client & Redfish OOBM Driver
GabrielBrascher commented on a change in pull request #4175:
URL: https://github.com/apache/cloudstack/pull/4175#discussion_r445092179
##
File path:
utils/src/main/java/org/apache/cloudstack/utils/redfish/RedfishClient.java
##
@@ -0,0 +1,378 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+package org.apache.cloudstack.utils.redfish;
+
+import java.io.BufferedReader;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.io.UnsupportedEncodingException;
+import java.net.URISyntaxException;
+import java.nio.charset.StandardCharsets;
+import java.security.KeyManagementException;
+import java.security.NoSuchAlgorithmException;
+import java.util.Base64;
+
+import javax.net.ssl.HostnameVerifier;
+import javax.net.ssl.HttpsURLConnection;
+import javax.net.ssl.SSLContext;
+import javax.net.ssl.SSLSession;
+import javax.net.ssl.TrustManager;
+
+import com.cloud.utils.nio.TrustAllManager;
+import org.apache.commons.httpclient.HttpStatus;
+import org.apache.commons.lang.StringUtils;
+import org.apache.http.HttpResponse;
+import org.apache.http.client.HttpClient;
+import org.apache.http.client.methods.CloseableHttpResponse;
+import org.apache.http.client.methods.HttpGet;
+import org.apache.http.client.methods.HttpPost;
+import org.apache.http.client.utils.URIBuilder;
+import org.apache.http.conn.ssl.SSLConnectionSocketFactory;
+import org.apache.http.entity.StringEntity;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClientBuilder;
+import org.apache.http.protocol.HTTP;
+import org.apache.log4j.Logger;
+
+import com.cloud.utils.net.NetUtils;
+import com.google.common.net.InternetDomainName;
+import com.google.gson.JsonArray;
+import com.google.gson.JsonObject;
+import com.google.gson.JsonParser;
+
+/**
+ * Provides support to a set of REST requests that can be sent to a Redfish
Server.
+ * RedfishClient allows to gather the server Power State, and execute Reset
+ * actions such as 'On', 'ForceOff', 'GracefulShutdown', 'GracefulRestart' etc.
+ */
+public class RedfishClient {
+
+private static final Logger LOGGER = Logger.getLogger(RedfishClient.class);
+
+private String username;
+private String password;
+private boolean useHttps;
+private boolean ignoreSsl;
+
+private final static String SYSTEMS_URL_PATH = "redfish/v1/Systems/";
+private final static String COMPUTER_SYSTEM_RESET_URL_PATH =
"/Actions/ComputerSystem.Reset";
+private final static String REDFISH_RESET_TYPE = "ResetType";
+private final static String POWER_STATE = "PowerState";
+private final static String APPLICATION_JSON = "application/json";
+private final static String ACCEPT = "accept";
+private final static String ODATA_ID = "@odata.id";
+private final static String MEMBERS = "Members";
+private final static String EXPECTED_HTTP_STATUS = "2XX";
+
+/**
+ * Redfish Command type:
+ * ComputerSystemReset: execute Redfish reset commands ({@link
RedfishResetCmd}).
+ * GetSystemId: get the system ID.
+ * GetPowerState: used for get the system power state.
+ */
+public enum
+RedfishCmdType {
+ComputerSystemReset, GetSystemId, GetPowerState
+}
+
+/**
+ * Redfish System Power State:
+ * Off: The state is powered Off.
+ * On: The state is powered On.
+ * PoweringOff: A temporary state between On and Off.
+ * PoweringOn: A temporary state between Off and On.
+ */
+public enum RedfishPowerState {
+On, Off, PoweringOn, PoweringOff
+}
+
+/**
+ *
+ * ForceOff: Turn the unit off immediately (non-graceful
shutdown).
+ * ForceOn: Turn the unit on immediately.
+ * ForceRestart: Perform an immediate (non-graceful) shutdown,
+ * followed by a restart.
+ * GracefulRestart: Perform a graceful shutdown followed by a
restart
+ * of the system.
+ * GracefulShutdown: Perform a graceful shutdown and power off.
+ * Nmi: Generate a Diagnostic Interrupt (usually an NMI on x86
+ * systems) to cease normal operations, perform diagnostic actions and
typically
+ * halt the system.
+ * On:
[GitHub] [cloudstack] blueorangutan commented on pull request #4176: server: Purge all cookies on logout, set /client path on login
blueorangutan commented on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-648992111 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4176: server: Purge all cookies on logout, set /client path on login
rhtyd commented on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-648991517 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] wido commented on a change in pull request #4175: Redfish Client & Redfish OOBM Driver
wido commented on a change in pull request #4175:
URL: https://github.com/apache/cloudstack/pull/4175#discussion_r445082792
##
File path:
utils/src/main/java/org/apache/cloudstack/utils/redfish/RedfishClient.java
##
@@ -0,0 +1,378 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+package org.apache.cloudstack.utils.redfish;
+
+import java.io.BufferedReader;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.io.UnsupportedEncodingException;
+import java.net.URISyntaxException;
+import java.nio.charset.StandardCharsets;
+import java.security.KeyManagementException;
+import java.security.NoSuchAlgorithmException;
+import java.util.Base64;
+
+import javax.net.ssl.HostnameVerifier;
+import javax.net.ssl.HttpsURLConnection;
+import javax.net.ssl.SSLContext;
+import javax.net.ssl.SSLSession;
+import javax.net.ssl.TrustManager;
+
+import com.cloud.utils.nio.TrustAllManager;
+import org.apache.commons.httpclient.HttpStatus;
+import org.apache.commons.lang.StringUtils;
+import org.apache.http.HttpResponse;
+import org.apache.http.client.HttpClient;
+import org.apache.http.client.methods.CloseableHttpResponse;
+import org.apache.http.client.methods.HttpGet;
+import org.apache.http.client.methods.HttpPost;
+import org.apache.http.client.utils.URIBuilder;
+import org.apache.http.conn.ssl.SSLConnectionSocketFactory;
+import org.apache.http.entity.StringEntity;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClientBuilder;
+import org.apache.http.protocol.HTTP;
+import org.apache.log4j.Logger;
+
+import com.cloud.utils.net.NetUtils;
+import com.google.common.net.InternetDomainName;
+import com.google.gson.JsonArray;
+import com.google.gson.JsonObject;
+import com.google.gson.JsonParser;
+
+/**
+ * Provides support to a set of REST requests that can be sent to a Redfish
Server.
+ * RedfishClient allows to gather the server Power State, and execute Reset
+ * actions such as 'On', 'ForceOff', 'GracefulShutdown', 'GracefulRestart' etc.
+ */
+public class RedfishClient {
+
+private static final Logger LOGGER = Logger.getLogger(RedfishClient.class);
+
+private String username;
+private String password;
+private boolean useHttps;
+private boolean ignoreSsl;
+
+private final static String SYSTEMS_URL_PATH = "redfish/v1/Systems/";
+private final static String COMPUTER_SYSTEM_RESET_URL_PATH =
"/Actions/ComputerSystem.Reset";
+private final static String REDFISH_RESET_TYPE = "ResetType";
+private final static String POWER_STATE = "PowerState";
+private final static String APPLICATION_JSON = "application/json";
+private final static String ACCEPT = "accept";
+private final static String ODATA_ID = "@odata.id";
+private final static String MEMBERS = "Members";
+private final static String EXPECTED_HTTP_STATUS = "2XX";
+
+/**
+ * Redfish Command type:
+ * ComputerSystemReset: execute Redfish reset commands ({@link
RedfishResetCmd}).
+ * GetSystemId: get the system ID.
+ * GetPowerState: used for get the system power state.
+ */
+public enum
+RedfishCmdType {
+ComputerSystemReset, GetSystemId, GetPowerState
+}
+
+/**
+ * Redfish System Power State:
+ * Off: The state is powered Off.
+ * On: The state is powered On.
+ * PoweringOff: A temporary state between On and Off.
+ * PoweringOn: A temporary state between Off and On.
+ */
+public enum RedfishPowerState {
+On, Off, PoweringOn, PoweringOff
+}
+
+/**
+ *
+ * ForceOff: Turn the unit off immediately (non-graceful
shutdown).
+ * ForceOn: Turn the unit on immediately.
+ * ForceRestart: Perform an immediate (non-graceful) shutdown,
+ * followed by a restart.
+ * GracefulRestart: Perform a graceful shutdown followed by a
restart
+ * of the system.
+ * GracefulShutdown: Perform a graceful shutdown and power off.
+ * Nmi: Generate a Diagnostic Interrupt (usually an NMI on x86
+ * systems) to cease normal operations, perform diagnostic actions and
typically
+ * halt the system.
+ * On: Turn the
[GitHub] [cloudstack] shwstppr commented on a change in pull request #4176: server: Purge all cookies on logout, set /client path on login
shwstppr commented on a change in pull request #4176:
URL: https://github.com/apache/cloudstack/pull/4176#discussion_r445080095
##
File path: server/src/main/java/com/cloud/api/ApiServlet.java
##
@@ -238,9 +238,14 @@ void processRequestInContext(final HttpServletRequest req,
final HttpServletResp
} catch (final IllegalStateException ignored) {
}
}
-Cookie sessionKeyCookie = new
Cookie(ApiConstants.SESSIONKEY, "");
-sessionKeyCookie.setMaxAge(0);
-resp.addCookie(sessionKeyCookie);
+final Cookie[] cookies = req.getCookies();
+if (cookies != null)
Review comment:
@rhtyd missing brace
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4171: vr: fix backup router health check
blueorangutan commented on pull request #4171: URL: https://github.com/apache/cloudstack/pull/4171#issuecomment-648979759 @shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4171: vr: fix backup router health check
shwstppr commented on pull request #4171: URL: https://github.com/apache/cloudstack/pull/4171#issuecomment-648979347 @Doni7722 `createMonitorServiceCommand`, where the exclusion has been added, is the method used to create command which will be sent to the host for running health. This will be called every time health checks run for a router. State is checked from DomainRouterVO which should hold the correct state even if it has been changed. https://github.com/apache/cloudstack/blob/a838a14bd3d42226e858b051f3411a24b718db48/server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java#L1628 https://github.com/apache/cloudstack/blob/a838a14bd3d42226e858b051f3411a24b718db48/server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java#L1652-L1691 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] wido commented on issue #4159: Fail to deploy VM with Ceph (Octopus) as primary storage
wido commented on issue #4159: URL: https://github.com/apache/cloudstack/issues/4159#issuecomment-648977591 I've merged that PR at rados-java. I haven't run into this myself with Ceph Octopus, but good to know. I'll try to get release 0.6.0 out of rados-java. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack-primate] branch master updated: config: fix column label to say VM name for backups in listview
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git
The following commit(s) were added to refs/heads/master by this push:
new d1b4f09 config: fix column label to say VM name for backups in
listview
d1b4f09 is described below
commit d1b4f0928854187c07c1e50a455dc0b25b19df82
Author: Rohit Yadav
AuthorDate: Wed Jun 24 23:10:33 2020 +0530
config: fix column label to say VM name for backups in listview
Signed-off-by: Rohit Yadav
(cherry picked from commit 9d3f040c16087ec2e511098a03a28407f8267bdb)
Signed-off-by: Rohit Yadav
---
src/config/section/storage.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/config/section/storage.js b/src/config/section/storage.js
index 6a406e2..fe0f2ab 100644
--- a/src/config/section/storage.js
+++ b/src/config/section/storage.js
@@ -318,7 +318,7 @@ export default {
title: 'label.backup',
icon: 'cloud-upload',
permission: ['listBackups'],
- columns: [{ name: (record) => { return record.virtualmachinename } },
'status', 'type', 'created', 'account', 'zone'],
+ columns: ['virtualmachinename', 'status', 'type', 'created', 'account',
'zone'],
details: ['virtualmachinename', 'id', 'type', 'externalid', 'size',
'virtualsize', 'volumes', 'backupofferingname', 'zone', 'account', 'domain',
'created'],
actions: [
{
[GitHub] [cloudstack] blueorangutan commented on pull request #4053: Secondary Storage Usage Improvements
blueorangutan commented on pull request #4053: URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-648962479 Trillian test result (tid-1829) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 37993 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4053-t1829-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_direct_download.py Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 75 look OK, 8 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestDirectDownloadTemplates>:setup | `Error` | 0.00 | test_direct_download.py ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py test_01_create_template | `Error` | 57.65 | test_templates.py test_CreateTemplateWithDuplicateName | `Error` | 65.27 | test_templates.py test_01_register_template_direct_download_flag | `Error` | 0.15 | test_templates.py test_02_deploy_vm_from_direct_download_template | `Error` | 0.00 | test_templates.py test_03_deploy_vm_wrong_checksum | `Error` | 0.14 | test_templates.py ContextSuite context=TestTemplates>:setup | `Error` | 269.85 | test_templates.py test_01_template_usage | `Error` | 38.99 | test_usage.py ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py test_disable_oobm_ha_state_ineligible | `Error` | 0.24 | test_hostha_kvm.py test_hostha_configure_default_driver | `Error` | 0.24 | test_hostha_kvm.py test_hostha_enable_ha_when_host_disabled | `Error` | 0.26 | test_hostha_kvm.py test_hostha_enable_ha_when_host_disconected | `Error` | 0.26 | test_hostha_kvm.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 0.26 | test_hostha_kvm.py test_hostha_kvm_host_degraded | `Error` | 0.29 | test_hostha_kvm.py test_hostha_kvm_host_fencing | `Error` | 0.25 | test_hostha_kvm.py test_hostha_kvm_host_recovering | `Error` | 0.26 | test_hostha_kvm.py test_remove_ha_provider_not_possible | `Error` | 0.24 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4176: server: Purge all cookies on logout, set /client path on login
blueorangutan commented on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-648959967 Packaging result: ✖centos7 ✖debian. JID-1452 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4176: server: Purge all cookies on logout, set /client path on login
blueorangutan commented on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-648955003 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4176: server: Purge all cookies on logout, set /client path on login
rhtyd commented on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-648954607 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4176: server: Purge all cookies on logout, set /client path on login
blueorangutan removed a comment on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-648950053 Packaging result: ✖centos7 ✖debian. JID-1451 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Doni7722 commented on pull request #4171: vr: fix backup router health check
Doni7722 commented on pull request #4171: URL: https://github.com/apache/cloudstack/pull/4171#issuecomment-648953499 @shwstppr LGTM - Does it check the state of the Router on every health check (as the state could change anytime)? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4156: Fixed removal of hosts from certsmap when running certificate auto-renew
nvazquez commented on pull request #4156: URL: https://github.com/apache/cloudstack/pull/4156#issuecomment-648950178 Thanks @Spaceman1984, tested manually and looks good. @rhtyd I noticed the internal active certificates map uses the host IP as the key, which is then used for querying in the DB for that IP. Is there any reason for not using the internal host ID or the UUID as the map key and using the host IP instead? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4176: server: Purge all cookies on logout, set /client path on login
blueorangutan commented on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-648950053 Packaging result: ✖centos7 ✖debian. JID-1451 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4176: server: Purge all cookies on logout, set /client path on login
rhtyd commented on a change in pull request #4176:
URL: https://github.com/apache/cloudstack/pull/4176#discussion_r445042517
##
File path: server/src/main/java/com/cloud/api/ApiServlet.java
##
@@ -213,7 +213,7 @@ void processRequestInContext(final HttpServletRequest req,
final HttpServletResp
try {
responseString =
apiAuthenticator.authenticate(command, params, session, remoteAddress,
responseType, auditTrailSb, req, resp);
if (session != null &&
session.getAttribute(ApiConstants.SESSIONKEY) != null) {
-resp.addHeader("SET-COOKIE",
String.format("%s=%s;HttpOnly", ApiConstants.SESSIONKEY,
session.getAttribute(ApiConstants.SESSIONKEY)));
+resp.addHeader("SET-COOKIE",
String.format("%s=%s;HttpOnly;Path=/client", ApiConstants.SESSIONKEY,
session.getAttribute(ApiConstants.SESSIONKEY)));
Review comment:
We need to check if this is necessary or not
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4176: server: Purge all cookies on logout, set /client path on login
blueorangutan commented on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-648945776 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4176: server: Purge all cookies on logout, set /client path on login
rhtyd commented on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-648945360 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4176: server: Purge all cookies on logout, set /client path on login
rhtyd commented on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-648945225 Please review and test @davidjumani @shwstppr cc @Pearl1594 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd opened a new pull request #4176: server: Purge all cookies on logout, set /client path on login
rhtyd opened a new pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176 This will purge all the cookies on logout including multiple sessionkey cookies if passed. On login, this will restrict sessionkey cookie (httponly) to the /client path like the JSESSIONID cookie. Fixes #4136 ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) Needs manual testing This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed issue #4136: UI doesn't allow login if sessionkey and JSESSIONID cookies are deleted
rhtyd closed issue #4136: URL: https://github.com/apache/cloudstack/issues/4136 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack-primate] branch master updated: auth: Removing setting a cookie for sessionkey (#453)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git
The following commit(s) were added to refs/heads/master by this push:
new d8d9231 auth: Removing setting a cookie for sessionkey (#453)
d8d9231 is described below
commit d8d9231a51e2736ba2c17ce0db278aaa761c7cf6
Author: davidjumani
AuthorDate: Wed Jun 24 17:01:11 2020 +
auth: Removing setting a cookie for sessionkey (#453)
Primate should not set sessionkey cookie
---
src/store/modules/user.js | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/store/modules/user.js b/src/store/modules/user.js
index d4a8a59..6d24e5f 100644
--- a/src/store/modules/user.js
+++ b/src/store/modules/user.js
@@ -89,7 +89,6 @@ const user = {
Cookies.set('account', result.account, { expires: 1 })
Cookies.set('domainid', result.domainid, { expires: 1 })
Cookies.set('role', result.type, { expires: 1 })
- Cookies.set('sessionkey', result.sessionkey, { expires: 1 })
Cookies.set('timezone', result.timezone, { expires: 1 })
Cookies.set('timezoneoffset', result.timezoneoffset, { expires: 1 })
Cookies.set('userfullname', result.firstname + ' ' +
result.lastname, { expires: 1 })
[GitHub] [cloudstack] FilippoProjetto commented on pull request #4174: Set prometheus.exporter.enable as not dynamic
FilippoProjetto commented on pull request #4174: URL: https://github.com/apache/cloudstack/pull/4174#issuecomment-648941917 Is it a known flaky test the one failing? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] gaaray2k removed a comment on issue #4168: Problems when using multiple management servers.
gaaray2k removed a comment on issue #4168: URL: https://github.com/apache/cloudstack/issues/4168#issuecomment-648822682 I followed this doc and I see that the agents are being load balanced between the two mgmt servers, but I found another issue. when the console proxy sys vm connects to one mgmt server, I cannot open console from the other mgmt server. I get the message below.. that is a problem when the load balancer for the frontend sends a user to the mgmt server that isnt being used by the console proxy vm. 'Access is denied for the console session. Please close the window and retry again' This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4040: [KVM] Enable PVLAN support on L2 networks
blueorangutan commented on pull request #4040: URL: https://github.com/apache/cloudstack/pull/4040#issuecomment-648877872 Trillian test result (tid-1827) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 37435 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4040-t1827-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Smoke tests completed. 83 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack-primate] branch master updated: autogenview: switch project if a valid UUID projectid query is passed
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git
The following commit(s) were added to refs/heads/master by this push:
new 295bdaf autogenview: switch project if a valid UUID projectid query
is passed
295bdaf is described below
commit 295bdafc51add3a4fc5acb613dd7a71c0c1f7607
Author: Rohit Yadav
AuthorDate: Wed Jun 24 20:22:52 2020 +0530
autogenview: switch project if a valid UUID projectid query is passed
Fixes #450
Signed-off-by: Rohit Yadav
---
src/views/AutogenView.vue | 21 +
1 file changed, 21 insertions(+)
diff --git a/src/views/AutogenView.vue b/src/views/AutogenView.vue
index 9b6f73d..3afcb88 100644
--- a/src/views/AutogenView.vue
+++ b/src/views/AutogenView.vue
@@ -366,6 +366,9 @@ export default {
mounted () {
this.currentPath = this.$route.fullPath
this.fetchData()
+if ('projectid' in this.$route.query) {
+ this.switchProject(this.$route.query.projectid)
+}
},
beforeRouteUpdate (to, from, next) {
this.currentPath = this.$route.fullPath
@@ -383,6 +386,9 @@ export default {
this.itemCount = 0
this.selectedFilter = ''
this.fetchData()
+if ('projectid' in to.query) {
+ this.switchProject(to.query.projectid)
+}
}
},
'$i18n.locale' (to, from) {
@@ -395,6 +401,21 @@ export default {
}
},
methods: {
+switchProject (projectId) {
+ if (!projectId || !projectId.length || projectId.length !== 36) {
+return
+ }
+ api('listProjects', { id: projectId, listall: true, details: 'min'
}).then(json => {
+if (!json || !json.listprojectsresponse ||
!json.listprojectsresponse.project) return
+const project = json.listprojectsresponse.project[0]
+this.$store.dispatch('SetProject', project)
+this.$store.dispatch('ToggleTheme', project.id === undefined ? 'light'
: 'dark')
+this.$message.success(`Switched to "${project.name}"`)
+const query = Object.assign({}, this.$route.query)
+delete query.projectid
+this.$router.replace({ query })
+ })
+},
fetchData (params = { listall: true }) {
if (this.routeName !== this.$route.name) {
this.routeName = this.$route.name
[GitHub] [cloudstack] blueorangutan commented on pull request #4167: Adding missing fields to API responses
blueorangutan commented on pull request #4167: URL: https://github.com/apache/cloudstack/pull/4167#issuecomment-648870585 @davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4167: Adding missing fields to API responses
davidjumani commented on pull request #4167: URL: https://github.com/apache/cloudstack/pull/4167#issuecomment-648870078 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4167: Adding missing fields to API responses
blueorangutan commented on pull request #4167: URL: https://github.com/apache/cloudstack/pull/4167#issuecomment-648867375 Packaging result: ✔centos7 ✔debian. JID-1450 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4117: [VMware] Explicitly controlling VM hardware version
nvazquez commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-648862293 @rhtyd the script ssvm_check reported an error, seems one of the services did not start properly, let's see if the issue persists in the next test results This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4103: [VMware] Enable unmanaging guest VMs
blueorangutan commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-648862646 Trillian test result (tid-1826) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 35940 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4103-t1826-kvm-centos7.zip Smoke tests completed. 83 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rvalle commented on issue #4170: Centos7 RPM packages are x86_64 should be noarch
rvalle commented on issue #4170: URL: https://github.com/apache/cloudstack/issues/4170#issuecomment-648862461 @rhtyd thanks, will test with ubuntu. I was not really looking to virtualize but just to run the management from RPI. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this
blueorangutan commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-648860682 Packaging result: ✔centos7 ✔debian. JID-1449 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4171: vr: fix backup router health check
blueorangutan commented on pull request #4171: URL: https://github.com/apache/cloudstack/pull/4171#issuecomment-648857970 Packaging result: ✔centos7 ✔debian. JID-1448 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4167: Adding missing fields to API responses
blueorangutan commented on pull request #4167: URL: https://github.com/apache/cloudstack/pull/4167#issuecomment-648855274 @davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4167: Adding missing fields to API responses
davidjumani commented on pull request #4167: URL: https://github.com/apache/cloudstack/pull/4167#issuecomment-648854882 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack-primate] branch master updated: config: allow admins to configure global footer html
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git
The following commit(s) were added to refs/heads/master by this push:
new 5780b40 config: allow admins to configure global footer html
5780b40 is described below
commit 5780b4044ae2164b87d9f0925c10e97b342f3a08
Author: Rohit Yadav
AuthorDate: Wed Jun 24 19:41:22 2020 +0530
config: allow admins to configure global footer html
Fixes #452
Signed-off-by: Rohit Yadav
---
public/config.json | 1 +
src/components/page/GlobalFooter.vue | 7 +--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/public/config.json b/public/config.json
index 9f08bb3..ac916c5 100644
--- a/public/config.json
+++ b/public/config.json
@@ -2,6 +2,7 @@
"apiBase": "/client/api",
"docBase": "http://docs.cloudstack.apache.org/en/latest;,
"appTitle": "CloudStack",
+ "footer": "Licensed under the Apache License, Version 2.0.",
"logo": "assets/logo.svg",
"banner": "assets/banner.svg",
"error": {
diff --git a/src/components/page/GlobalFooter.vue
b/src/components/page/GlobalFooter.vue
index 1df96d4..bd63d7a 100644
--- a/src/components/page/GlobalFooter.vue
+++ b/src/components/page/GlobalFooter.vue
@@ -17,7 +17,10 @@
-
+
+
+
+
CloudStack {{ $store.getters.features.cloudstackversion }}
Primate {{ $store.getters.version }}
@@ -46,7 +49,7 @@ export default {
margin: 48px 0 24px;
text-align: center;
-.links {
+.line {
margin-bottom: 8px;
a {
[GitHub] [cloudstack] GabrielBrascher commented on issue #3624: Redfish support for Host HA (Out of Band)
GabrielBrascher commented on issue #3624: URL: https://github.com/apache/cloudstack/issues/3624#issuecomment-648841153 @wido @kiwiflyer PR #4175 is open and ready for review/testing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-648839196 @Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4128: Role based users in Projects
Pearl1594 commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-648838741 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4170: Centos7 RPM packages are x86_64 should be noarch
rhtyd commented on issue #4170: URL: https://github.com/apache/cloudstack/issues/4170#issuecomment-648838574 @rvalle qemu, kvm and kernel on centos7 are very old to support VMs on aarch64. You probably want to try Ubuntu 20.04 instead, try this instead https://rohityadav.cloud/blog/cloudstack-rpi4-kvm/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher opened a new pull request #4175: Redfish Client & Redfish OOBM Driver
GabrielBrascher opened a new pull request #4175: URL: https://github.com/apache/cloudstack/pull/4175 ## Description This PR adds support for the OOBM Redfish protocol, implementing a Java client to send HTTP requests to Redfish supported systems. Implementation overview: - Redfish Java client: a Java Client for Redfish that makes Redfish actions available to the HA workflow via an OOB driver. - OOB Redfish driver: a new Out-of-band driver was created for Redfish, allowing to integrate the Redfish Client with the CloudStack Out-of-band management implementation. Fixes: 3624 **Thanks note:** this implementation counted with the help from our friends at [Yourhosting](https://www.yourhosting.nl/). ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): Configure OOBM with Redfish driver  Check OOBM host tab  Test powering On and Off hosts. Host status is properly shown  ## How Has This Been Tested? We have been able to test on Dell and Supermicro machines and it works fine: 1. via the CloudStack UI, enable redfish oob driver for host n05 2. verified that ACS can retrieve the redfish system ID and system power state 3. powering Off node works as expected, host state transition worked well and the host was indeed powered off 4. powering On also worked as expected, CloudStack host state transition as expected, host is indeed up again This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this
blueorangutan commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-648837371 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this
rhtyd closed pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch master updated (5471802 -> cbbb401)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 5471802 Merge remote-tracking branch 'origin/4.14' add c03f8a1 server: Adding listall to listLdapConfigurations (#4164) add 9642392 Merge remote-tracking branch 'origin/4.13' into 4.14 add cbbb401 Merge remote-tracking branch 'origin/4.14' No new revisions were added by this update. Summary of changes: .../api/command/LdapListConfigurationCmd.java | 8 ++ .../apache/cloudstack/ldap/LdapManagerImpl.java| 3 ++- .../cloudstack/ldap/dao/LdapConfigurationDao.java | 4 +++ .../ldap/dao/LdapConfigurationDaoImpl.java | 30 +- 4 files changed, 37 insertions(+), 8 deletions(-)
[GitHub] [cloudstack] rhtyd commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this
rhtyd commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-648837102 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
