[GitHub] [cloudstack] blueorangutan commented on pull request #4053: Secondary Storage Usage Improvements
blueorangutan commented on pull request #4053: URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-653726094 Trillian test result (tid-1962) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 59216 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4053-t1962-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 82 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 331.79 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | `Error` | 3843.35 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack-primate] branch master updated: iam: UI changes for Dynamic roles improvements (#353)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git
The following commit(s) were added to refs/heads/master by this push:
new 6bb8173 iam: UI changes for Dynamic roles improvements (#353)
6bb8173 is described below
commit 6bb8173e8fef491fc0bf04096046f37754de7d6b
Author: sureshanaparti <12028987+sureshanapa...@users.noreply.github.com>
AuthorDate: Sat Jul 4 11:29:11 2020 +0530
iam: UI changes for Dynamic roles improvements (#353)
This PR addresses the below UI improvements for current Dynamic roles
functionality.
Export rules of a role to a CSV file, with name: .csv_
Import a role with its rules using a CSV file.
Create a role from any of the existing role.
Co-authored-by: davidjumani
---
src/config/section/role.js | 16 +-
src/locales/en.json | 7 +
src/views/iam/CreateRole.vue| 205
src/views/iam/ImportRole.vue| 299
src/views/iam/RolePermissionTab.vue | 48 +-
5 files changed, 564 insertions(+), 11 deletions(-)
diff --git a/src/config/section/role.js b/src/config/section/role.js
index 3dccfa0..cefe1e1 100644
--- a/src/config/section/role.js
+++ b/src/config/section/role.js
@@ -36,12 +36,16 @@ export default {
icon: 'plus',
label: 'label.add.role',
listView: true,
- args: ['name', 'description', 'type'],
- mapping: {
-type: {
- options: ['Admin', 'DomainAdmin', 'User']
-}
- }
+ popup: true,
+ component: () => import('@/views/iam/CreateRole.vue')
+},
+{
+ api: 'importRole',
+ icon: 'cloud-upload',
+ label: 'label.import.role',
+ listView: true,
+ popup: true,
+ component: () => import('@/views/iam/ImportRole.vue')
},
{
api: 'updateRole',
diff --git a/src/locales/en.json b/src/locales/en.json
index 4b64d55..78ad666 100644
--- a/src/locales/en.json
+++ b/src/locales/en.json
@@ -449,6 +449,7 @@
"label.baremetalcpucores": "# of CPU Cores",
"label.baremetalmac": "Host MAC",
"label.baremetalmemory": "Memory (in MB)",
+"label.based.on": "Based on",
"label.basic": "Basic",
"label.basic.mode": "Basic Mode",
"label.basicsetup": "Basic setup",
@@ -777,6 +778,9 @@
"label.enter.token": "Enter token",
"label.error": "Error",
"label.error.code": "Error Code",
+"label.error.file.upload": "File upload failed",
+"label.error.file.read": "Cannot read file",
+"label.error.rules.file.import": "Please choose a valid CSV rules file",
"label.error.something.went.wrong.please.correct.the.following": "Something
went wrong; please correct the following",
"label.error.upper": "ERROR",
"label.error.volume.upload": "Please choose a file",
@@ -937,6 +941,7 @@
"label.ikepolicy": "IKE policy",
"label.images": "Images",
"label.import.backup.offering": "Import Backup Offering",
+"label.import.role": "Import Role",
"label.info": "Info",
"label.info.upper": "INFO",
"label.infrastructure": "Infrastructure",
@@ -1665,6 +1670,8 @@
"label.rule": "Rule",
"label.rule.number": "Rule Number",
"label.rules": "Rules",
+"label.rules.file": "Rules File",
+"label.rules.file.import.description": "Click or drag rule defintions CVS file
to import",
"label.running": "Running VMs",
"label.saml.disable": "SAML Disable",
"label.saml.enable": "SAML Enable",
diff --git a/src/views/iam/CreateRole.vue b/src/views/iam/CreateRole.vue
new file mode 100644
index 000..23730b5
--- /dev/null
+++ b/src/views/iam/CreateRole.vue
@@ -0,0 +1,205 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ {{ $t('label.type') }}
+
+
+ {{ $t('label.role') }}
+
+
+
+
+
+
+
+ {{ role }}
+
+
+
+
+
+
+
+ {{ role.name }}
+
+
+
+
+
+ {{
[GitHub] [cloudstack] blueorangutan commented on pull request #4176: server: Purge all cookies on logout, set /client path on login
blueorangutan commented on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-653725656 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4176: server: Purge all cookies on logout, set /client path on login
rhtyd commented on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-653725614 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd removed a comment on pull request #4176: server: Purge all cookies on logout, set /client path on login
rhtyd removed a comment on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-653722790 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4200: Allow domain admins to create offering without mentioning domainid
rhtyd commented on pull request #4200: URL: https://github.com/apache/cloudstack/pull/4200#issuecomment-653725463 Should domain admins be allowed to create public offerings? They must be restricted only to their domains I think. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4196: fix-debian10-32bit guest_os_hypervisor for VMware
blueorangutan commented on pull request #4196: URL: https://github.com/apache/cloudstack/pull/4196#issuecomment-653725476 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4196: fix-debian10-32bit guest_os_hypervisor for VMware
rhtyd commented on pull request #4196: URL: https://github.com/apache/cloudstack/pull/4196#issuecomment-653725432 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4175: Redfish Client & Redfish OOBM Driver
blueorangutan commented on pull request #4175: URL: https://github.com/apache/cloudstack/pull/4175#issuecomment-653725357 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4175: Redfish Client & Redfish OOBM Driver
rhtyd commented on pull request #4175: URL: https://github.com/apache/cloudstack/pull/4175#issuecomment-653725292 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4165: Allow renaming cluster, host, and storage
blueorangutan commented on pull request #4165: URL: https://github.com/apache/cloudstack/pull/4165#issuecomment-653725250 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4174: Set prometheus.exporter.enable as not dynamic
blueorangutan commented on pull request #4174: URL: https://github.com/apache/cloudstack/pull/4174#issuecomment-653725235 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4174: Set prometheus.exporter.enable as not dynamic
rhtyd commented on pull request #4174: URL: https://github.com/apache/cloudstack/pull/4174#issuecomment-653725190 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4165: Allow renaming cluster, host, and storage
rhtyd commented on pull request #4165: URL: https://github.com/apache/cloudstack/pull/4165#issuecomment-653725153 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4156: Fixed removal of hosts from certsmap when running certificate auto-renew
rhtyd commented on pull request #4156: URL: https://github.com/apache/cloudstack/pull/4156#issuecomment-653725080 ping @nvazquez please review This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4144: Fix Usage failed to get pid
rhtyd commented on pull request #4144: URL: https://github.com/apache/cloudstack/pull/4144#issuecomment-653725052 @div8cn can you check if in the docker container the pid parameter was passed? Depending on how the service runs perhaps this was not passed, look at the cloudstack-usage systemd service for example. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4138: Fixed incorrect error message on invalid template type download
rhtyd commented on pull request #4138: URL: https://github.com/apache/cloudstack/pull/4138#issuecomment-653724883 @nvazquez are you LGTM on this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.
blueorangutan commented on pull request #4137: URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-653724914 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.
rhtyd commented on pull request #4137: URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-653724843 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-653724689 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4117: [VMware] Explicitly controlling VM hardware version
blueorangutan commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-653724606 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4128: Role based users in Projects
rhtyd commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-653724586 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4000: vm: Reset deviceId to fix missing nic with vm
blueorangutan commented on pull request #4000: URL: https://github.com/apache/cloudstack/pull/4000#issuecomment-653724592 Packaging result: ✖centos7 ✖debian. JID-1519 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4116: cks: fix template, deployment issues
blueorangutan commented on pull request #4116: URL: https://github.com/apache/cloudstack/pull/4116#issuecomment-653724620 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4117: [VMware] Explicitly controlling VM hardware version
rhtyd commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-653724576 @blueorangutan test centos7 vmware-67u3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4116: cks: fix template, deployment issues
rhtyd commented on pull request #4116: URL: https://github.com/apache/cloudstack/pull/4116#issuecomment-653724536 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4111: API-call to declare host as dead
blueorangutan commented on pull request #4111: URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-653724542 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4078: Cleanup download urls when SSVM destroyed
blueorangutan commented on pull request #4078: URL: https://github.com/apache/cloudstack/pull/4078#issuecomment-653724565 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4111: API-call to declare host as dead
rhtyd commented on pull request #4111: URL: https://github.com/apache/cloudstack/pull/4111#issuecomment-653724511 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4078: Cleanup download urls when SSVM destroyed
rhtyd commented on pull request #4078: URL: https://github.com/apache/cloudstack/pull/4078#issuecomment-653724455 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4076: Support searching vm's by multiple id
rhtyd commented on pull request #4076: URL: https://github.com/apache/cloudstack/pull/4076#issuecomment-653724428 Closing on previous remark and no further communication. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4076: Support searching vm's by multiple id
rhtyd closed pull request #4076: URL: https://github.com/apache/cloudstack/pull/4076 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-653724425 @rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4069: Ubuntu 20.04 support (as hypervisor)
rhtyd commented on pull request #4069: URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-653724377 Closing due to cherry-picked in https://github.com/apache/cloudstack/pull/4068 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
rhtyd commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-653724336 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4069: Ubuntu 20.04 support (as hypervisor)
rhtyd closed pull request #4069: URL: https://github.com/apache/cloudstack/pull/4069 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4019: server: Move restoreVM to vm work job queue
blueorangutan commented on pull request #4019: URL: https://github.com/apache/cloudstack/pull/4019#issuecomment-653724219 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
blueorangutan commented on pull request #4020: URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-653724202 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4001: server: Dedicated hosts should be 'Not Suitable' while find host for m migration
rhtyd merged pull request #4001: URL: https://github.com/apache/cloudstack/pull/4001 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
rhtyd commented on pull request #4020: URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-653724165 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4016: Fixed private gateway can't be deleted
rhtyd commented on pull request #4016: URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-653724141 ping @Spaceman1984 no update? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch 4.13 updated: server: Dedicated hosts should be 'Not Suitable' while find hosts for vm migration (#4001)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.13
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.13 by this push:
new 4da374b server: Dedicated hosts should be 'Not Suitable' while find
hosts for vm migration (#4001)
4da374b is described below
commit 4da374b6b404d401d6a1f39d4df45e72fcabbbf8
Author: Wei Zhou
AuthorDate: Sat Jul 4 07:31:41 2020 +0200
server: Dedicated hosts should be 'Not Suitable' while find hosts for vm
migration (#4001)
While migrate a vm, in the popup, the host dedicated to other
accounts/domains are also 'Suitable" for migration, which is obviously wrong.
The same issue happens with api findHostsForMigration
---
.../src/main/java/com/cloud/deploy/DeploymentPlanningManager.java | 3 +++
.../main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java | 6 ++
server/src/main/java/com/cloud/server/ManagementServerImpl.java | 5 +
3 files changed, 10 insertions(+), 4 deletions(-)
diff --git
a/engine/components-api/src/main/java/com/cloud/deploy/DeploymentPlanningManager.java
b/engine/components-api/src/main/java/com/cloud/deploy/DeploymentPlanningManager.java
index ee6721a..2266cd5 100644
---
a/engine/components-api/src/main/java/com/cloud/deploy/DeploymentPlanningManager.java
+++
b/engine/components-api/src/main/java/com/cloud/deploy/DeploymentPlanningManager.java
@@ -16,6 +16,7 @@
// under the License.
package com.cloud.deploy;
+import com.cloud.dc.DataCenter;
import com.cloud.deploy.DeploymentPlanner.ExcludeList;
import com.cloud.exception.AffinityConflictException;
import com.cloud.exception.InsufficientServerCapacityException;
@@ -49,4 +50,6 @@ public interface DeploymentPlanningManager extends Manager {
void cleanupVMReservations();
DeploymentPlanner getDeploymentPlannerByName(String plannerName);
+
+void checkForNonDedicatedResources(VirtualMachineProfile vmProfile,
DataCenter dc, ExcludeList avoids);
}
diff --git
a/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
b/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
index a95f4ef..0dd4462 100644
--- a/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
+++ b/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
@@ -351,9 +351,6 @@ StateListener {
}
}
-if (vm.getType() == VirtualMachine.Type.User) {
-checkForNonDedicatedResources(vmProfile, dc, avoids);
-}
if (s_logger.isDebugEnabled()) {
s_logger.debug("Deploy avoids pods: " + avoids.getPodsToAvoid() +
", clusters: " + avoids.getClustersToAvoid() + ", hosts: " +
avoids.getHostsToAvoid());
}
@@ -561,7 +558,8 @@ StateListener {
return null;
}
-private void checkForNonDedicatedResources(VirtualMachineProfile
vmProfile, DataCenter dc, ExcludeList avoids) {
+@Override
+public void checkForNonDedicatedResources(VirtualMachineProfile vmProfile,
DataCenter dc, ExcludeList avoids) {
boolean isExplicit = false;
VirtualMachine vm = vmProfile.getVirtualMachine();
diff --git a/server/src/main/java/com/cloud/server/ManagementServerImpl.java
b/server/src/main/java/com/cloud/server/ManagementServerImpl.java
index fdd6354..40ef0ed 100644
--- a/server/src/main/java/com/cloud/server/ManagementServerImpl.java
+++ b/server/src/main/java/com/cloud/server/ManagementServerImpl.java
@@ -1321,6 +1321,11 @@ public class ManagementServerImpl extends ManagerBase
implements ManagementServe
}
}
+if (vm.getType() == VirtualMachine.Type.User || vm.getType() ==
VirtualMachine.Type.DomainRouter) {
+final DataCenterVO dc = _dcDao.findById(srcHost.getDataCenterId());
+_dpMgr.checkForNonDedicatedResources(vmProfile, dc, excludes);
+}
+
for (final HostAllocator allocator : hostAllocators) {
if (canMigrateWithStorage) {
suitableHosts = allocator.allocateTo(vmProfile, plan,
Host.Type.Routing, excludes, allHosts, HostAllocator.RETURN_UPTO_ALL, false);
[GitHub] [cloudstack] rhtyd commented on pull request #4019: server: Move restoreVM to vm work job queue
rhtyd commented on pull request #4019: URL: https://github.com/apache/cloudstack/pull/4019#issuecomment-653724156 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4001: server: Dedicated hosts should be 'Not Suitable' while find host for m migration
rhtyd commented on pull request #4001: URL: https://github.com/apache/cloudstack/pull/4001#issuecomment-653724074 FWIW LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4001: server: Dedicated hosts should be 'Not Suitable' while find host for m migration
rhtyd commented on a change in pull request #4001:
URL: https://github.com/apache/cloudstack/pull/4001#discussion_r439205308
##
File path: server/src/main/java/com/cloud/server/ManagementServerImpl.java
##
@@ -1321,6 +1321,11 @@ private HypervisorType getHypervisorType(VMInstanceVO
vm, StoragePool srcVolumeP
}
}
+if (vm.getType() == VirtualMachine.Type.User || vm.getType() ==
VirtualMachine.Type.DomainRouter) {
Review comment:
@ustcweizhou what about other systemvms? CPVM, SSVM, ILB etc?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router
blueorangutan commented on pull request #3952: URL: https://github.com/apache/cloudstack/pull/3952#issuecomment-653724021 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3944: vpc/server: Fix network statistics for vpc
blueorangutan commented on pull request #3944: URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-653723985 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
blueorangutan commented on pull request #3902: URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-653723949 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3902: vrouter: Save PlaceHolder nic for VR if network does not have source nat
rhtyd commented on pull request #3902: URL: https://github.com/apache/cloudstack/pull/3902#issuecomment-653723908 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4000: vm: Reset deviceId to fix missing nic with vm
blueorangutan commented on pull request #4000: URL: https://github.com/apache/cloudstack/pull/4000#issuecomment-653723888 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3944: vpc/server: Fix network statistics for vpc
rhtyd commented on pull request #3944: URL: https://github.com/apache/cloudstack/pull/3944#issuecomment-653723883 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3979: Limit API from trying to start a VM that is already running
blueorangutan commented on pull request #3979: URL: https://github.com/apache/cloudstack/pull/3979#issuecomment-653723870 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router
rhtyd commented on pull request #3952: URL: https://github.com/apache/cloudstack/pull/3952#issuecomment-653723852 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4000: vm: Reset deviceId to fix missing nic with vm
rhtyd commented on pull request #4000: URL: https://github.com/apache/cloudstack/pull/4000#issuecomment-653723815 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4000: vm: Reset deviceId to fix missing nic with vm
rhtyd closed pull request #4000: URL: https://github.com/apache/cloudstack/pull/4000 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] ustcweizhou opened a new pull request #4000: vm: Reset deviceId to fix missing nic with vm
ustcweizhou opened a new pull request #4000: URL: https://github.com/apache/cloudstack/pull/4000 ## Description This PR aims to fix the issue which can be reproduced as below: 1. create a vm with 3 networks 2. remove the 2nd network from the vm 3. stop the vm 4. start the vm Expected result: vm is started with 2 nics (on 1st network and 3rd network) Actual result: vm is started with only first nic (on 1st network). ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? With this PR, the vm is started with all nics. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #3979: Limit API from trying to start a VM that is already running
rhtyd commented on pull request #3979: URL: https://github.com/apache/cloudstack/pull/3979#issuecomment-653723826 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4176: server: Purge all cookies on logout, set /client path on login
rhtyd commented on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-653722790 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4182: kvm: pre-add 32 PCI controller for hot-plug issue
blueorangutan commented on pull request #4182: URL: https://github.com/apache/cloudstack/pull/4182#issuecomment-653721795 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4182: kvm: pre-add 32 PCI controller for hot-plug issue
rhtyd commented on pull request #4182: URL: https://github.com/apache/cloudstack/pull/4182#issuecomment-653721728 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4193: Fix usage record count
blueorangutan commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-653710878 Trillian test result (tid-1964) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 35174 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4193-t1964-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Smoke tests completed. 76 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 226.32 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 217.54 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 331.09 | test_privategw_acl.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4138: Fixed incorrect error message on invalid template type download
blueorangutan commented on pull request #4138: URL: https://github.com/apache/cloudstack/pull/4138#issuecomment-653705717 Trillian test result (tid-1963) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32939 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4138-t1963-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 75 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 207.40 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 220.80 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 307.58 | test_privategw_acl.py test_01_redundant_vpc_site2site_vpn | `Failure` | 387.53 | test_vpc_vpn.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4172: [VMware] Support to attach more than 15 data disks in VMware VM
blueorangutan commented on pull request #4172: URL: https://github.com/apache/cloudstack/pull/4172#issuecomment-653691493 Trillian test result (tid-1959) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 38499 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4172-t1959-vmware-67u3.zip Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 77 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_07_reboot_ssvm | `Failure` | 42.31 | test_ssvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4010: New API endpoint to update size of Pod Management IP Range.
blueorangutan commented on pull request #4010: URL: https://github.com/apache/cloudstack/pull/4010#issuecomment-653679477 Packaging result: ✖centos7 ✖debian. JID-1518 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4010: New API endpoint to update size of Pod Management IP Range.
GabrielBrascher commented on pull request #4010: URL: https://github.com/apache/cloudstack/pull/4010#issuecomment-653678177 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4010: New API endpoint to update size of Pod Management IP Range.
blueorangutan commented on pull request #4010: URL: https://github.com/apache/cloudstack/pull/4010#issuecomment-653678257 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4010: New API endpoint to update size of Pod Management IP Range.
GabrielBrascher commented on a change in pull request #4010:
URL: https://github.com/apache/cloudstack/pull/4010#discussion_r449692454
##
File path:
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##
@@ -1463,6 +1464,162 @@ public void doInTransactionWithoutResult(final
TransactionStatus status) {
}
}
+@Override
+@DB
+public void updatePodIpRange(final UpdatePodManagementNetworkIpRangeCmd
cmd) throws ConcurrentOperationException {
+final long podId = cmd.getPodId();
+final String currentStartIP= cmd.getCurrentStartIP();
+final String currentEndIP= cmd.getCurrentEndIP();
+final HostPodVO pod = _podDao.findById(podId);
+
+String newStartIP = cmd.getNewStartIP();
+String newEndIP = cmd.getNewEndIP();
+String vlan = null;
+
+if(newStartIP == null){
+newStartIP= currentStartIP;
+}
+
+if(newEndIP == null){
+newEndIP= currentEndIP;
+}
+
+if(pod == null) {
+throw new InvalidParameterValueException("Unable to find pod by id
" + podId);
+}
+
+final String[] existingPodIpRanges = pod.getDescription().split(",");
+if(existingPodIpRanges.length == 0) {
+throw new InvalidParameterValueException("The IP range cannot be
found since the existing IP range is empty.");
+}
+
+verifyIPRangeParameters(currentStartIP,currentEndIP);
+verifyIPRangeParameters(newStartIP,newEndIP);
+
checkIpRangeContainsTakenAddresses(pod,currentStartIP,currentEndIP,newStartIP,newEndIP);
+
+boolean foundRange = false;
+
+for(String podIpRange: existingPodIpRanges) {
+final String[] existingPodIpRange = podIpRange.split("-");
+
+if(existingPodIpRange.length > 1) {
+if (!NetUtils.isValidIp4(existingPodIpRange[0]) ||
!NetUtils.isValidIp4(existingPodIpRange[1])) {
+continue;
+}
+if (currentStartIP.equals(existingPodIpRange[0]) &&
currentEndIP.equals(existingPodIpRange[1])) {
+foundRange = true;
+vlan = existingPodIpRange[3];
+}
+if (!foundRange && NetUtils.ipRangesOverlap(newStartIP,
newEndIP, existingPodIpRange[0], existingPodIpRange[1])) {
+throw new InvalidParameterValueException("The Start IP and
EndIP address range overlap with private IP :" + existingPodIpRange[0] + "-" +
existingPodIpRange[1]);
+}
+}
+}
+
+if(!foundRange) {
+throw new InvalidParameterValueException("The input IP range: " +
currentStartIP + "-" + currentEndIP + " of pod: " + podId + " is not present.
Please input an existing range.");
+}
+
+List currentIPRange =
listAllIPsWithintheRange(currentStartIP,currentEndIP);
+List newIPRange = listAllIPsWithintheRange(newStartIP,newEndIP);
+
+try {
+final String finalNewEndIP = newEndIP;
+final String finalNewStartIP = newStartIP;
+final Integer vlanId = vlan.equals(Vlan.UNTAGGED) ? null :
Integer.parseInt(vlan);
+
+Transaction.execute(new TransactionCallbackNoReturn() {
+@Override
+public void doInTransactionWithoutResult(final
TransactionStatus status) {
+final long zoneId = pod.getDataCenterId();
+
pod.setDescription(pod.getDescription().replace(currentStartIP+"-",
finalNewStartIP +"-").replace(currentEndIP,
+finalNewEndIP));
+
+HostPodVO lock = null;
+
+try {
+lock = _podDao.acquireInLockTable(podId);
+if (lock == null) {
+String msg = "Unable to acquire lock on table to
update the ip range of POD: " + pod.getName() + ", Update failed.";
+s_logger.warn(msg);
+throw new CloudRuntimeException(msg);
+}
+List iPAddressesToAdd = new
ArrayList(newIPRange);
+iPAddressesToAdd.removeAll(currentIPRange);
+if (iPAddressesToAdd.size()>0){
+for(Long startIP : iPAddressesToAdd){
+_zoneDao.addPrivateIpAddress(zoneId, podId,
NetUtils.long2Ip(startIP), NetUtils.long2Ip(startIP), false, vlanId);
+}
+}else {
+currentIPRange.removeAll(newIPRange);
+if(currentIPRange.size()>0){
+for (Long startIP: currentIPRange){
+
if(!_privateIpAddressDao.deleteIpAddressByPodDc(NetUtils.long2Ip(startIP),podId,zoneId)){
+
[GitHub] [cloudstack] Pearl1594 edited a comment on pull request #4176: server: Purge all cookies on logout, set /client path on login
Pearl1594 edited a comment on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-653620888 @rhtyd As David mentioned, the context path set to any other path than '/' works, however, the same issue of multiple session keys getting added to the api calls crops in for context.path set to '/'. There are 2 session keys : one mapped to Path: / and another mapped to path: '/api'  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4176: server: Purge all cookies on logout, set /client path on login
Pearl1594 commented on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-653620888 @rhtyd As David mentioned, the context path set to any other path than '/' works, however, the same issue of multiple session keys getting added to the api calls crops in for context.path set to '/'. There are 2 session keys : one mapped to Path: / and another mapped to path: '/api'  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4193: Fix usage record count
blueorangutan commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-653612159 @Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4193: Fix usage record count
Pearl1594 commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-653611920 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4193: Fix usage record count
blueorangutan commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-653611698 Packaging result: ✔centos7 ✔debian. JID-1517 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4193: Fix usage record count
blueorangutan commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-653605584 @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4193: Fix usage record count
Pearl1594 commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-653605175 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4138: Fixed incorrect error message on invalid template type download
blueorangutan commented on pull request #4138: URL: https://github.com/apache/cloudstack/pull/4138#issuecomment-653601683 @Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4138: Fixed incorrect error message on invalid template type download
Spaceman1984 commented on pull request #4138: URL: https://github.com/apache/cloudstack/pull/4138#issuecomment-653601359 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4138: Fixed incorrect error message on invalid template type download
blueorangutan commented on pull request #4138: URL: https://github.com/apache/cloudstack/pull/4138#issuecomment-653596078 Packaging result: ✔centos7 ✔debian. JID-1516 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4138: Fixed incorrect error message on invalid template type download
blueorangutan commented on pull request #4138: URL: https://github.com/apache/cloudstack/pull/4138#issuecomment-653587648 @Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4138: Fixed incorrect error message on invalid template type download
Spaceman1984 commented on pull request #4138: URL: https://github.com/apache/cloudstack/pull/4138#issuecomment-653587251 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4053: Secondary Storage Usage Improvements
blueorangutan commented on pull request #4053: URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-653537691 @Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4053: Secondary Storage Usage Improvements
Pearl1594 commented on pull request #4053: URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-653537140 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4193: Fix usage record count
Pearl1594 commented on pull request #4193: URL: https://github.com/apache/cloudstack/pull/4193#issuecomment-653536294 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4198: Kubernetes container service: coreos is EOL
rhtyd commented on issue #4198: URL: https://github.com/apache/cloudstack/issues/4198#issuecomment-653518043 following @Pearl1594 @shwstppr This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4198: Kubernetes container service: coreos is EOL
rhtyd commented on issue #4198: URL: https://github.com/apache/cloudstack/issues/4198#issuecomment-653518139 We're exploring alternative with https://www.flatcar-linux.org/releases/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #4114: hypervisor: XCP-ng 8.1 support
andrijapanicsb commented on pull request #4114: URL: https://github.com/apache/cloudstack/pull/4114#issuecomment-653506074 For the reference ACS 4.13.1.0 + XCPng-7.6: [root@ref-trl-1165-x-M7-andrija-panic-marvin ~]# cat /marvin/smoketests-summary.txt Intermittent failure detected: /marvin/tests/smoke/test_password_server.py Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 73 look OK, 4 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_primary_storage_iscsi | `Error` | 3.10 | test_primary_storage.py test_02_vpc_privategw_static_routes | `Failure` | 264.10 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 245.00 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 351.62 | test_privategw_acl.py test_01_scale_vm | `Failure` | 12.40 | test_scale_vm.py test_02_redundant_VPC_default_routes | `Failure` | 379.15 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4172: [VMware] Support to attach more than 15 data disks in VMware VM
blueorangutan commented on pull request #4172: URL: https://github.com/apache/cloudstack/pull/4172#issuecomment-653491326 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #4172: [VMware] Support to attach more than 15 data disks in VMware VM
borisstoyanov commented on pull request #4172: URL: https://github.com/apache/cloudstack/pull/4172#issuecomment-653490736 @blueorangutan test centos7 vmware-67u3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] olivierlemasle commented on a change in pull request #4193: Fix usage record count
olivierlemasle commented on a change in pull request #4193:
URL: https://github.com/apache/cloudstack/pull/4193#discussion_r449478789
##
File path: server/src/main/java/com/cloud/usage/UsageServiceImpl.java
##
@@ -328,9 +333,20 @@ public boolean
generateUsageRecords(GenerateUsageRecordsCmd cmd) {
break;
case UsageTypes.IP_ADDRESS:
IPAddressVO ip =
_ipDao.findByUuidIncludingRemoved(usageId);
-if (ip != null) {
-usageDbId = ip.getId();
+if (ip == null) {
+break;
+}
+Long networkId = ip.getAssociatedWithNetworkId();
+if (networkId == null) {
+networkId = ip.getSourceNetworkId();
+}
+NetworkDetailVO networkDetail =
_networkDetailsDao.findDetail(networkId, Network.hideIpAddressUsage);
+if (networkDetail != null && networkDetail.getValue() !=
null && networkDetail.getValue().equals("true")) {
Review comment:
As this code is in a test `if (usageId != null)`, it will remove IP
address usage only if the API command `listUsageRecords` was called with a
specific `usageId` parameter.
For API calls like `command=listUsageRecords=xxx=xxx`, it
will include all usage records, including for IP addresses on networks with
"Hide usage".
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] ravening opened a new pull request #4200: Allow domain admins to create offering without mentioning domainid
ravening opened a new pull request #4200:
URL: https://github.com/apache/cloudstack/pull/4200
## Description
Part 1:
While creating disk/service offering by domains we need to
specify domain id else it wont be created. Provide an enhancement
so that we dont need to pass domainid and it will be taken
from the callers user similar to other api's
Another bug fix
Part2:
Currently while creating any offering, we need to
specify a domain id or a list of domain id.
If an offering is created on a domain then all its child
domains should see it and all the parents domain
should see it as well but it should not be visible
to sibling domain
isrecursive=true ensures that all child domains can see it
but if a service offering is created for the domain at the leaf
of the domain path then its parent cant see it if isrecurise
is true. so we need to pass isrecursive=false so that the
parent domain can see the child offerings
### Cloudmonkey works fine but the issue is only with UI
## Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
Without the UI fix
After the UI fix
## How Has This Been Tested?
This has been tested both from cloudmonkey for part1 and part2 and UI for
part2
Part 1
Cloudmonkey api before fix
```
(test1) > create serviceoffering name=without-domainid
displaytext=without-domaindi
Error 431: Unable to create public service offering by admin:
cff2f496-0ab1-4aa9-8447-e89be9e42b10 because it is domain-admin
(test1) > create diskoffering name=without-domain
displaytext=without-domain disksize=10
Error 431: Unable to create public disk offering by admin:
cff2f496-0ab1-4aa9-8447-e89be9e42b10 because it is domain-admin
(test1) >
```
After the fix
```
(test1) > list domains filter=name
{
"count": 1,
"domain": [
{
"name": "test1"
}
]
}
(test1) > create serviceoffering name=without-domain
displaytext=without-domain
{
"serviceoffering": {
"created": "2020-07-02T13:17:39+",
"defaultuse": false,
"displaytext": "without-domain",
"domain": "test1",
"domainid": "c14ffcea-e197-4d6f-b8ff-2ffb854cd443",
"id": "e7bb6b10-060b-4d8a-aec2-831691e868ac",
"iscustomized": true,
"issystem": false,
"isvolatile": false,
"limitcpuuse": false,
"name": "without-domain",
"offerha": false,
"provisioningtype": "thin",
"serviceofferingdetails": {
"domainid": "2"
},
"storagetype": "shared"
}
}
(test1) > create diskoffering name=without-domain
displaytext=without-domain disksize=10
{
"diskoffering": {
"created": "2020-07-02T13:18:32+",
"disksize": 10,
"displayoffering": true,
"displaytext": "without-domain",
"domain": "/test1/",
"domainid": "c14ffcea-e197-4d6f-b8ff-2ffb854cd443",
"id": "552c9c4a-04af-4d6b-b50d-2dd0cb374668",
"iscustomized": false,
"name": "without-domain",
"provisioningtype": "thin",
"storagetype": "shared"
}
}
```
Part 2
cloudmonkey api working as expected without any changes.
```
(test11) > list diskofferings listall=true filter=name isrecursive=true
{
"count": 6,
"diskoffering": [
{
"name": "Small"
},
{
"name": "Medium"
},
{
"name": "Large"
},
{
"name": "Custom"
},
{
"name": "test-11only"
},
{
"name": "test-11andtest2"
}
]
}
```
```
(test11) > list diskofferings listall=true filter=name
{
"count": 9,
"diskoffering": [
{
"name": "Small"
},
{
"name": "Medium"
},
{
"name": "Large"
},
{
"name": "Custom"
},
{
"name": "test1only"
},
{
"name": "test-11only"
},
{
"name": "test1-and-11"
},
{
"name": "root-test1-test11"
},
{
"name": "test-11andtest2"
}
]
}
```
[GitHub] [cloudstack] VincentHermes opened a new issue #4199: HTTPS does not initiate
VincentHermes opened a new issue #4199:
URL: https://github.com/apache/cloudstack/issues/4199
ISSUE TYPE
* Other / HTTPS
COMPONENT NAME
* Webserver
CLOUDSTACK VERSION
* 4.14
CONFIGURATION
* server.properties:
`https.enable=true`
`https.port=8443`
`https.keystore=/etc/cloudstack/management/thecurrentkeystore.pkcs12`
`https.keystore.password=currentkeystorepassword`
* Firewall disabled
OS / ENVIRONMENT
* CentOS7
* MGMT Server on VMWare
* Cloudstack 4.14
* Java 11
* OpenSSL 1.0.2k-fips
SUMMARY
We are not able to access the 4.14 Webserver over HTTPS after upgrading
from a functioning 4.13. The Webserver seems to not send anything back. If we
curl the https it just loads infinitely:
`# curl -v https://localhost:8443/client`
`* About to connect() to localhost port 8443 (#0)`
`* Trying ::1...`
`* Connected to localhost (::1) port 8443 (#0)`
`* Initializing NSS with certpath: sql:/etc/pki/nssdb`
`* CAfile: /etc/pki/tls/certs/ca-bundle.crt`
` CApath: none`
`(waits)`
Previous investigations regarding networking etc can be seen here:
https://lists.apache.org/thread.html/r50fa6f94dae308a598eb2eeb738f4325e29814d8da83de8558bccfb2%40%3Cusers.cloudstack.apache.org%3E
_Using a self-signed certificate actually works, only when using an adequate
certificate (wildcard in our case) it stops functioning_
Commands used:
_Combine Files_
`cat key.key servercert.crt intermediate.crt root.crt > combined.crt`
_Create Keystore_
`openssl pkcs12 -in combined.crt -export -out combined.pkcs12`
_Import Keystore_
`keytool -importkeystore -srckeystore combined.pkcs12 -srcstoretype PKCS12
-destkeystore /etc/cloudstack/management/combined.pkcs12 -deststoretype pkcs12`
_Then change https.keystore= and https.keystore.password= accordingly and
restart cloudstack-management_
Logs found:
`2020-06-29 12:01:02,052 INFO [o.e.j.s.h.ContextHandler] (main:null)
(logid:) Started
o.e.j.w.WebAppContext@311bf055{/client,file:///usr/share/cloudstack-management/webapp/,AVAILABLE}{/usr/share/cloudstack-management/webapp}`
`2020-06-29 12:01:02,053 INFO [o.e.j.s.h.ContextHandler] (main:null)
(logid:) Started o.e.j.s.h.MovedContextHandler@451001e5{/,null,AVAILABLE}`
`2020-06-29 12:01:02,076 INFO [o.e.j.s.AbstractConnector] (main:null)
(logid:) Started ServerConnector@6f46426d{HTTP/1.1,[http/1.1]}{0.0.0.0:8080}`
`2020-06-29 12:01:02,090 INFO [o.e.j.u.s.SslContextFactory] (main:null)
(logid:) x509=X509@25c6abfa(1,h=[our acual domain name],w=[our domain name
again]) for
SslContextFactory@4991c0f7[provider=null,keyStore=file:///etc/cloudstack/management/combined.pkcs12,trustStore=null]`
Things tried:
* Tested Firefox, Chrome, Edge, IE
* Cache cleared / Private Mode
* Multiple Client Systems
* Numerous combinations of key-cert-intermediate-root when generating the
pkcs12
* Keystore only with key and server certificate without any CA's
* Different Certificate Vendors (2 different Wildcard Certificates, Sectigo
and Digicert/RapidSSL)
* Generated Certificate via internal Domains Certificate Authority
* Checked all certificate combinations via certutil in Windows Powershell
* Changed keystore password to minimal ones without special characters (e.g.
123456)
* Changed the `https.port` to any other Port in `server.properties`
* Switched back to java-1.8.0 - of course management server failed to start
* Uploaded certificate chain via 8080 Web GUI - Found working combination of
cert-intermediate-root to work with by opening console proxy in separate window
and checking certificate validity
* Definitely working combination (for firefox) gets the same outcome when
being used as pkcs12
* Updating to a newer Openssl Version fails because its the newest for
CentOS7
* Just in case it has an impact - Outcommented `jdk.tls.disabledAlgorithms`
in `java.security.ciphers`
Further Investigations:
* If we change the keystore password to nonsense it makes no difference
* If we change the keystore name or path to nonsense it almost instantly
says that the Website is unreachable and does not load infinitely and curl says
Connection Refused
* Fresh Install shows the same behaviour
STEPS TO REPRODUCE
* Install Cloudstack 4.14 on CentOS7 (No need to configure Infrastructure)
* Create Keystore and configure HTTPS
* Try to get https://mymgmtserver.mydomain.de:8443/client to respond
EXPECTED RESULTS
* A response from 8443 as it has been before the upgrade or at least an SSL
error regarding a wrong certificate
ACTUAL RESULTS
* Webserver not responding / loading forever no matter what certificate is
used
* Actually it isn't really "not
[GitHub] [cloudstack] weizhouapache opened a new issue #4198: Kubernetes container service: coreos is EOL
weizhouapache opened a new issue #4198: URL: https://github.com/apache/cloudstack/issues/4198 On May 26, 2020, CoreOS Container Linux will reach its end of life and will no longer receive updates. We strongly recommend that users begin migrating their workloads to another operating system as soon as possible. https://coreos.com/os/eol/ # ISSUE TYPE * Improvement Request # COMPONENT NAME ~~~ Kubernetes container service ~~~ # CLOUDSTACK VERSION ~~~ 4.14/4.15 ~~~ # CONFIGURATION # OS / ENVIRONMENT # SUMMARY # STEPS TO REPRODUCE ~~~ ~~~ # EXPECTED RESULTS ~~~ ~~~ # ACTUAL RESULTS ~~~ ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #3945: server: update template to another template type
weizhouapache commented on pull request #3945:
URL: https://github.com/apache/cloudstack/pull/3945#issuecomment-653416433
> @ustcweizhou do we want to restrict this to root admin only?
@rhtyd
I was thinking about the following change
```
-@Parameter(name = "templatetype", type = CommandType.STRING,
description = "the type of the template")
+@Parameter(name = "templatetype", type = CommandType.STRING,
description = "the type of the template", authorized
+ = {RoleType.Admin})
private String templateType;
```
however, when I tested with normal user or domain admin, the api succeed
without templatetype change.
```
(test1) > update template id="ce3d5211-3209-4617-b569-6c533801a20c"
templatetype=SYSTEM
{
"template": {
"account": "test1",
"bits": 0,
"bootable": true,
"created": "2020-06-12T09:54:08+",
"crossZones": false,
"details": {
"rootDiskController": "osdefault"
},
"displaytext": "ubuntu18-minimal-test1",
"domain": "test1",
"domainid": "931bc746-8a9a-45ec-8c50-776b89aed898",
"format": "QCOW2",
"hypervisor": "KVM",
"id": "ce3d5211-3209-4617-b569-6c533801a20c",
"isdynamicallyscalable": false,
"isfeatured": false,
"ispublic": false,
"isready": false,
"name": "ubuntu18-minimal-test1",
"ostypeid": "67bad17c-186e-11ea-83e0-066004001165",
"ostypename": "Apple Mac OS X 10.6 (32-bit)",
"tags": [],
"templatetype": "USER"
}
}
```
without this change, I got following error which looks better.
```
(test1) > update template id="ce3d5211-3209-4617-b569-6c533801a20c"
templatetype=SYSTEM
Error 531: Parameter templatetype can only be specified by a Root Admin,
permission denied
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-653393443 Trillian test result (tid-1951) Environment: kvm-centos8 (x2), Advanced Networking with Mgmt server 8 Total time taken: 2 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t1951-kvm-centos8.zip Intermittent failure detected: /marvin/tests/smoke/test_async_job.py Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_extra_config_data.py Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py Intermittent failure detected: /marvin/tests/smoke/test_password_server.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 73 look OK, 10 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_query_async_job_result | `Failure` | 71.25 | test_async_job.py test_02_deploy_vm_with_extraconfig_kvm | `Error` | 46.87 | test_deploy_vm_extra_config_data.py test_03_update_vm_with_extraconfig_kvm | `Error` | 155.31 | test_deploy_vm_extra_config_data.py test_07_deploy_and_scale_kubernetes_cluster | `Failure` | 516.07 | test_kubernetes_clusters.py test_oobm_background_powerstate_sync | `Failure` | 21.63 | test_outofbandmanagement.py test_oobm_enabledisable_across_clusterzones | `Error` | 29.64 | test_outofbandmanagement.py test_oobm_issue_power_cycle | `Error` | 19.66 | test_outofbandmanagement.py test_oobm_issue_power_off | `Error` | 18.62 | test_outofbandmanagement.py test_oobm_issue_power_on | `Error` | 18.64 | test_outofbandmanagement.py test_oobm_issue_power_reset | `Error` | 19.71 | test_outofbandmanagement.py test_oobm_issue_power_soft | `Error` | 19.64 | test_outofbandmanagement.py test_oobm_issue_power_status | `Error` | 19.66 | test_outofbandmanagement.py test_oobm_multiple_mgmt_server_ownership | `Failure` | 31.45 | test_outofbandmanagement.py test_oobm_zchange_password | `Error` | 7.32 | test_outofbandmanagement.py test_isolate_network_password_server | `Failure` | 12.09 | test_password_server.py test_router_dhcphosts | `Failure` | 12.22 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPHosts>:teardown | `Error` | 23.57 | test_router_dhcphosts.py test_11_migrate_vm | `Error` | 45.80 | test_vm_life_cycle.py test_14_secure_to_secure_vm_migration | `Error` | 85.07 | test_vm_life_cycle.py test_06_download_detached_volume | `Error` | 9.37 | test_volumes.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 373.69 | test_vpc_redundant.py test_hostha_kvm_host_degraded | `Error` | 8.67 | test_hostha_kvm.py test_hostha_kvm_host_fencing | `Error` | 9.78 | test_hostha_kvm.py test_hostha_kvm_host_recovering | `Error` | 9.68 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4186: Adding pagination for quotaSummary and quotaTariffList
blueorangutan commented on pull request #4186: URL: https://github.com/apache/cloudstack/pull/4186#issuecomment-653373629 @davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4186: Adding pagination for quotaSummary and quotaTariffList
davidjumani commented on pull request #4186: URL: https://github.com/apache/cloudstack/pull/4186#issuecomment-653373409 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4186: Adding pagination for quotaSummary and quotaTariffList
blueorangutan commented on pull request #4186: URL: https://github.com/apache/cloudstack/pull/4186#issuecomment-653372621 Packaging result: ✔centos7 ✔debian. JID-1515 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4071: Dynamic roles improvements
blueorangutan commented on pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-653370522 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #4071: Dynamic roles improvements
borisstoyanov commented on pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-653370045 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
