[GitHub] [cloudstack] blueorangutan commented on pull request #4047: Look for active templates for VR deployment
blueorangutan commented on pull request #4047: URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-656889979 Trillian test result (tid-2054) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 3 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4047-t2054-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 81 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_deploy_kubernetes_ha_cluster | `Error` | 3612.81 | test_kubernetes_clusters.py test_04_deploy_and_upgrade_kubernetes_cluster | `Error` | 0.04 | test_kubernetes_clusters.py test_05_deploy_and_upgrade_kubernetes_ha_cluster | `Error` | 0.04 | test_kubernetes_clusters.py test_06_deploy_and_invalid_upgrade_kubernetes_cluster | `Error` | 0.03 | test_kubernetes_clusters.py test_07_deploy_and_scale_kubernetes_cluster | `Error` | 0.03 | test_kubernetes_clusters.py ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 35.52 | test_kubernetes_clusters.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 306.26 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4138: Fixed incorrect error message on invalid template type download
blueorangutan commented on pull request #4138: URL: https://github.com/apache/cloudstack/pull/4138#issuecomment-656760195 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4138: Fixed incorrect error message on invalid template type download
nvazquez commented on pull request #4138: URL: https://github.com/apache/cloudstack/pull/4138#issuecomment-656759727 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4138: Fixed incorrect error message on invalid template type download
blueorangutan commented on pull request #4138: URL: https://github.com/apache/cloudstack/pull/4138#issuecomment-656742553 Packaging result: ✔centos7 ✔debian. JID-1564 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4138: Fixed incorrect error message on invalid template type download
blueorangutan commented on pull request #4138: URL: https://github.com/apache/cloudstack/pull/4138#issuecomment-656731887 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4138: Fixed incorrect error message on invalid template type download
nvazquez commented on pull request #4138: URL: https://github.com/apache/cloudstack/pull/4138#issuecomment-656731435 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #4138: Fixed incorrect error message on invalid template type download
nvazquez commented on a change in pull request #4138:
URL: https://github.com/apache/cloudstack/pull/4138#discussion_r452910190
##
File path:
core/src/main/java/com/cloud/storage/template/HttpTemplateDownloader.java
##
@@ -243,7 +247,6 @@ private boolean copyBytes(File file, InputStream in,
RandomAccessFile out) throw
offset = writeBlock(bytes, out, block, offset);
if (!verifyFormat.isVerifiedFormat() && (offset >= 1048576 ||
offset >= remoteSize)) { //let's check format after we get 1MB or full file
verifyFormat.invoke();
-if (verifyFormat.isInvalid()) return true;
Review comment:
In short, prior to these changes the invoke() method only set the
boolean variable retrieved in case of valid/invalid. After these changes, if it
is invalid invoke() throws an exception, so no need to check isInvalid() in
this line
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] PaulAngus commented on pull request #3900: systemvm: configurable root disk size based on new systemvm template definition
PaulAngus commented on pull request #3900: URL: https://github.com/apache/cloudstack/pull/3900#issuecomment-656617517 bump @ustcweizhou - can you fix conflicts so we can progress into testing please. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] PaulAngus commented on pull request #4200: Allow domain admins to create offering without mentioning domainid
PaulAngus commented on pull request #4200: URL: https://github.com/apache/cloudstack/pull/4200#issuecomment-656603579 Assuming that a domain admin can add offerings to one of their sub-domains, then it makes sense (to me) to ensure that the domain admin is specific. If that's the case, then I am -1 on taking that restriction away (with great power comes great responsibility). We no longer support the legacy UI, so no change should be accepted for it. wrt see child or parent offerings, are you referring to what Users or Domain Admins can see? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 opened a new pull request #4207: Human readable sizes in logs
Spaceman1984 opened a new pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207 ## Description This PR adds a global variable which will control outputting human readable byte sizes in logs. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? This is largely untested, testing is still to be done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack-primate] branch master updated: offerings: Add/remove tags for offerings table and resource views (#524)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git
The following commit(s) were added to refs/heads/master by this push:
new 2f7176e offerings: Add/remove tags for offerings table and resource
views (#524)
2f7176e is described below
commit 2f7176e3c289b34527d0cd8f629eb32fb088713a
Author: davidjumani
AuthorDate: Fri Jul 10 15:19:25 2020 +0530
offerings: Add/remove tags for offerings table and resource views (#524)
---
src/config/section/offering.js | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/config/section/offering.js b/src/config/section/offering.js
index 07156ab..70d91e8 100644
--- a/src/config/section/offering.js
+++ b/src/config/section/offering.js
@@ -28,8 +28,8 @@ export default {
icon: 'cloud',
permission: ['listServiceOfferings', 'listDomains'],
params: { isrecursive: 'true' },
- columns: ['name', 'displaytext', 'cpunumber', 'cpuspeed', 'memory',
'tags', 'domain', 'zone', 'order'],
- details: ['name', 'id', 'displaytext', 'offerha', 'provisioningtype',
'storagetype', 'iscustomized', 'limitcpuuse', 'cpunumber', 'cpuspeed',
'memory', 'tags', 'domain', 'zone', 'created'],
+ columns: ['name', 'displaytext', 'cpunumber', 'cpuspeed', 'memory',
'domain', 'zone', 'order'],
+ details: ['name', 'id', 'displaytext', 'offerha', 'provisioningtype',
'storagetype', 'iscustomized', 'limitcpuuse', 'cpunumber', 'cpuspeed',
'memory', 'hosttags', 'tags', 'domain', 'zone', 'created'],
related: [{
name: 'vm',
title: 'label.instances',
@@ -74,8 +74,8 @@ export default {
docHelp: 'adminguide/service_offerings.html#system-service-offerings',
permission: ['listServiceOfferings', 'listInfrastructure'],
params: { issystem: 'true', isrecursive: 'true' },
- columns: ['name', 'systemvmtype', 'cpunumber', 'cpuspeed', 'memory',
'storagetype', 'tags', 'order'],
- details: ['name', 'id', 'displaytext', 'systemvmtype',
'provisioningtype', 'storagetype', 'iscustomized', 'limitcpuuse', 'cpunumber',
'cpuspeed', 'memory', 'tags', 'domain', 'zone', 'created'],
+ columns: ['name', 'systemvmtype', 'cpunumber', 'cpuspeed', 'memory',
'storagetype', 'order'],
+ details: ['name', 'id', 'displaytext', 'systemvmtype',
'provisioningtype', 'storagetype', 'iscustomized', 'limitcpuuse', 'cpunumber',
'cpuspeed', 'memory', 'hosttags', 'tags', 'domain', 'zone', 'created'],
actions: [{
api: 'createServiceOffering',
icon: 'plus',
@@ -110,7 +110,7 @@ export default {
docHelp:
'adminguide/service_offerings.html#compute-and-disk-service-offerings',
permission: ['listDiskOfferings', 'listDomains'],
params: { isrecursive: 'true' },
- columns: ['name', 'displaytext', 'disksize', 'tags', 'domain', 'zone',
'order'],
+ columns: ['name', 'displaytext', 'disksize', 'domain', 'zone', 'order'],
details: ['name', 'id', 'displaytext', 'disksize', 'provisioningtype',
'storagetype', 'iscustomized', 'tags', 'domain', 'zone', 'created'],
related: [{
name: 'volume',
@@ -181,8 +181,8 @@ export default {
docHelp: 'adminguide/networking.html#network-offerings',
permission: ['listNetworkOfferings', 'listInfrastructure'],
params: { isrecursive: 'true' },
- columns: ['name', 'state', 'guestiptype', 'traffictype', 'networkrate',
'tags', 'domain', 'zone', 'order'],
- details: ['name', 'id', 'displaytext', 'guestiptype', 'traffictype',
'networkrate', 'ispersistent', 'egressdefaultpolicy', 'availability',
'conservemode', 'specifyvlan', 'specifyipranges', 'supportspublicaccess',
'supportsstrechedl2subnet', 'tags', 'service', 'domain', 'zone'],
+ columns: ['name', 'state', 'guestiptype', 'traffictype', 'networkrate',
'domain', 'zone', 'order'],
+ details: ['name', 'id', 'displaytext', 'guestiptype', 'traffictype',
'networkrate', 'ispersistent', 'egressdefaultpolicy', 'availability',
'conservemode', 'specifyvlan', 'specifyipranges', 'supportspublicaccess',
'supportsstrechedl2subnet', 'service', 'tags', 'domain', 'zone'],
actions: [{
api: 'createNetworkOffering',
icon: 'plus',
[cloudstack-primate] branch master updated: project: Restrict project related operations to admins/ domain admins and project owners (#529)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git
The following commit(s) were added to refs/heads/master by this push:
new 55736c3 project: Restrict project related operations to admins/
domain admins and project owners (#529)
55736c3 is described below
commit 55736c3a1c0936c48e6e807284e80b6ab522f8a6
Author: Pearl Dsilva
AuthorDate: Fri Jul 10 15:17:49 2020 +0530
project: Restrict project related operations to admins/ domain admins and
project owners (#529)
Fixes #485
---
src/config/section/project.js | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/src/config/section/project.js b/src/config/section/project.js
index 56e0d46..ed9d0cf 100644
--- a/src/config/section/project.js
+++ b/src/config/section/project.js
@@ -82,7 +82,10 @@ export default {
icon: 'edit',
label: 'label.edit.project.details',
dataView: true,
- args: ['displaytext']
+ args: ['displaytext'],
+ show: (record, store) => {
+return record.account === store.userInfo.account || ['Admin',
'DomainAdmin'].includes(store.userInfo.roletype)
+ }
},
{
api: 'activateProject',
@@ -90,7 +93,9 @@ export default {
label: 'label.activate.project',
message: 'message.activate.project',
dataView: true,
- show: (record) => { return record.state === 'Suspended' }
+ show: (record, store) => {
+return (record.account === store.userInfo.account || ['Admin',
'DomainAdmin'].includes(store.userInfo.roletype)) && record.state ===
'Suspended'
+ }
},
{
api: 'suspendProject',
@@ -99,7 +104,9 @@ export default {
message: 'message.suspend.project',
docHelp: 'adminguide/projects.html#suspending-or-deleting-a-project',
dataView: true,
- show: (record) => { return record.state !== 'Suspended' }
+ show: (record, store) => {
+return (record.account === store.userInfo.account || ['Admin',
'DomainAdmin'].includes(store.userInfo.roletype)) && record.state !==
'Suspended'
+ }
},
{
api: 'addAccountToProject',
@@ -121,7 +128,8 @@ export default {
label: 'label.delete.project',
message: 'message.delete.project',
docHelp: 'adminguide/projects.html#suspending-or-deleting-a-project',
- dataView: true
+ dataView: true,
+ show: (record, store) => { return record.account ===
store.userInfo.account || ['Admin',
'DomainAdmin'].includes(store.userInfo.roletype) }
}
]
}
[cloudstack-primate] branch master updated: github: update test plan templates
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git The following commit(s) were added to refs/heads/master by this push: new fa9a521 github: update test plan templates fa9a521 is described below commit fa9a52116ab35c3167d3c4419948fd04f7ad2af5 Author: Rohit Yadav AuthorDate: Fri Jul 10 15:13:59 2020 +0530 github: update test plan templates Signed-off-by: Rohit Yadav --- .github/ISSUE_TEMPLATE/smoke_test_plan.md | 1 + .github/ISSUE_TEMPLATE/test_full_plan.md | 8 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/smoke_test_plan.md b/.github/ISSUE_TEMPLATE/smoke_test_plan.md index cab8a53..cc065ed 100644 --- a/.github/ISSUE_TEMPLATE/smoke_test_plan.md +++ b/.github/ISSUE_TEMPLATE/smoke_test_plan.md @@ -17,6 +17,7 @@ Note: for User role test exclude after Account/User feature, for DomainAdmin rol - [ ] Add/delete secondary IP address **Compute > Kubernetes** +This requires configuring and setting up CKS: http://docs.cloudstack.apache.org/en/latest/plugins/cloudstack-kubernetes-service.html - [ ] Add Kubernetes cluster - [ ] Start/stop a Kubernetes cluster - [ ] Scale Kubernetes cluster diff --git a/.github/ISSUE_TEMPLATE/test_full_plan.md b/.github/ISSUE_TEMPLATE/test_full_plan.md index 9a8d140..bced270 100644 --- a/.github/ISSUE_TEMPLATE/test_full_plan.md +++ b/.github/ISSUE_TEMPLATE/test_full_plan.md @@ -19,7 +19,7 @@ Note: for User role test exclude after Account/User feature, for DomainAdmin rol - [ ] Context-sensitive help **Dashboard** -- [ ] Fetch latest +- [ ] Fetch latest (only on Admin dashboard) - [ ] View hosts in alert state - [ ] View alerts - [ ] View events @@ -33,6 +33,7 @@ Note: for User role test exclude after Account/User feature, for DomainAdmin rol - [ ] Create new instance **Compute > Kubernetes** +This requires configuring and setting up CKS: http://docs.cloudstack.apache.org/en/latest/plugins/cloudstack-kubernetes-service.html - [ ] Basic search - [ ] Extended search - [ ] Sort @@ -58,7 +59,7 @@ Note: for User role test exclude after Account/User feature, for DomainAdmin rol - [ ] Change affinity - [ ] Change service offering - [ ] Reset Instance Password -- [ ] Assign Instance to Another Account +- [ ] Assign Instance to Another Account (VM must be stopped) - [ ] Network adapters - [ ] - Add network to VM - [ ] - Set default NIC @@ -171,10 +172,9 @@ Note: for User role test exclude after Account/User feature, for DomainAdmin rol - [ ] Restart network - [ ] Delete network - [ ] Acquire new IP (only for isolated networks) -- [ ] Replace ACL list(only for isolated networks) +- [ ] Replace ACL list(only for VPC isolated networks) - [ ] Delete public IP address (only for isolated networks) - [ ] Add/delete egress rule (only for isolated networks) -- [ ] Add/delete egress tags (only for isolated networks) **Network > VPC ** - [ ] Basic search
[cloudstack-primate] branch master updated: component: Adding search option to SettingsTab (#521)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git
The following commit(s) were added to refs/heads/master by this push:
new 56e62e1 component: Adding search option to SettingsTab (#521)
56e62e1 is described below
commit 56e62e19b6856fef594731b2b457d046b4962fda
Author: davidjumani
AuthorDate: Fri Jul 10 13:19:18 2020 +0530
component: Adding search option to SettingsTab (#521)
Adds the option to search settings
---
src/components/view/SettingsTab.vue | 112 +---
1 file changed, 65 insertions(+), 47 deletions(-)
diff --git a/src/components/view/SettingsTab.vue
b/src/components/view/SettingsTab.vue
index 4c9f262..9f33196 100644
--- a/src/components/view/SettingsTab.vue
+++ b/src/components/view/SettingsTab.vue
@@ -1,48 +1,56 @@
-
-
-
-{{ item.name }}
-{{
item.description }}
-
-
-
-
-
-
- {{ item.value }}
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+ {{ item.name
}}
+ {{
item.description }}
+
+
+
+
+
+
+{{ item.value }}
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
