[GitHub] [cloudstack] shwstppr commented on a change in pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
shwstppr commented on a change in pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#discussion_r466812401 ## File path: setup/db/create-database-simulator.sql ## @@ -20,8 +20,8 @@ DROP DATABASE IF EXISTS `simulator`; CREATE DATABASE `simulator`; -GRANT ALL ON simulator.* to cloud@`localhost` identified by 'cloud'; -GRANT ALL ON simulator.* to cloud@`%` identified by 'cloud'; +GRANT ALL ON simulator.* to cloud@`localhost`; +GRANT ALL ON simulator.* to cloud@`%`; Review comment: @andrijapanicsb User `cloud` with the password will already be created in create-database.sql https://github.com/apache/cloudstack/pull/4068/commits/b895cf98f3927b8fbae7c927367e2c1d3bb68e0b#diff-ca79fa3d84677eec693e98f41aca3a0eR58-R59 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
blueorangutan commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-670289459 Trillian test result (tid-2284) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47386 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4207-t2284-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 80 look OK, 4 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_deploy_kubernetes_cluster | `Error` | 0.06 | test_kubernetes_clusters.py test_02_deploy_kubernetes_ha_cluster | `Error` | 0.04 | test_kubernetes_clusters.py test_04_deploy_and_upgrade_kubernetes_cluster | `Error` | 0.03 | test_kubernetes_clusters.py test_05_deploy_and_upgrade_kubernetes_ha_cluster | `Error` | 0.03 | test_kubernetes_clusters.py test_06_deploy_and_invalid_upgrade_kubernetes_cluster | `Error` | 0.03 | test_kubernetes_clusters.py test_07_deploy_and_scale_kubernetes_cluster | `Error` | 0.03 | test_kubernetes_clusters.py test_01_reset_vm_on_reboot | `Error` | 7.20 | test_reset_vm_on_reboot.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 374.11 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | `Error` | 3857.87 | test_vpc_redundant.py test_hostha_kvm_host_fencing | `Error` | 167.28 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
blueorangutan commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-670272208 Trillian test result (tid-2279) Environment: xenserver-70 (x2), Advanced Networking with Mgmt server 7 Total time taken: 52977 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4207-t2279-xenserver-70.zip Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Smoke tests completed. 82 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_add_delete_kubernetes_supported_version | `Error` | 1807.44 | test_kubernetes_supported_versions.py test_04_extract_template | `Failure` | 1.17 | test_templates.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
blueorangutan commented on pull request #4250: URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670270690 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4250: [VMware] OVF Full properties support
nvazquez commented on pull request #4250: URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670270492 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
blueorangutan commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-670256690 Trillian test result (tid-2278) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 49892 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4207-t2278-vmware-67u3.zip Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 77 look OK, 3 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_add_delete_kubernetes_supported_version | `Error` | 1807.80 | test_kubernetes_supported_versions.py test_11_migrate_vm | `Error` | 61.06 | test_vm_life_cycle.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 478.83 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | `Error` | 3799.13 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | `Error` | 3799.16 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Error` | 0.01 | test_vpc_redundant.py ContextSuite context=TestVPCRedundancy>:teardown | `Error` | 0.01 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-670249026 Trillian test result (tid-2280) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47406 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4128-t2280-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 83 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 357.73 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | `Error` | 3815.68 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4235: [VMware] Full OVF properties support
blueorangutan commented on pull request #4235: URL: https://github.com/apache/cloudstack/pull/4235#issuecomment-670240937 Trillian test result (tid-2283) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43727 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4235-t2283-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 82 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_rvpc_network_garbage_collector_nics | `Error` | 3855.17 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on a change in pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
andrijapanicsb commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r466304580
##
File path: scripts/storage/qcow2/managesnapshot.sh
##
@@ -187,6 +187,7 @@ backup_snapshot() {
local snapshotname="$2"
local destPath=$3
local destName=$4
+ local forceShareFlag="-U"
Review comment:
qemu 2.10 I believe, which also means when using qemu-kvm-ev 2.10+ on
i.e. CentOS7+NFS3 PRimary Storage - is fixed!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4016: Fixed private gateway can't be deleted
blueorangutan commented on pull request #4016: URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-670216662 Trillian test result (tid-2281) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40627 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4016-t2281-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 76 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 212.97 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 207.71 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 316.80 | test_privategw_acl.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4180: Added nfs minor version support
blueorangutan commented on pull request #4180: URL: https://github.com/apache/cloudstack/pull/4180#issuecomment-670207716 Trillian test result (tid-2282) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 38972 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4180-t2282-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 75 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 213.71 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 205.60 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 316.96 | test_privategw_acl.py test_01_redundant_vpc_site2site_vpn | `Failure` | 416.34 | test_vpc_vpn.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
blueorangutan commented on pull request #4250: URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670190524 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4250: [VMware] OVF Full properties support
nvazquez commented on pull request #4250: URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670190201 @blueorangutan test centos7 vmware-67u3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
blueorangutan commented on pull request #4250: URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670181963 Packaging result: ✔centos7 ✔debian. JID-1669 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
blueorangutan commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-670179371 Trillian test result (tid-2277) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43959 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4207-t2277-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 72 look OK, 12 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_deploy_kubernetes_cluster | `Error` | 0.07 | test_kubernetes_clusters.py test_02_deploy_kubernetes_ha_cluster | `Error` | 0.03 | test_kubernetes_clusters.py test_04_deploy_and_upgrade_kubernetes_cluster | `Error` | 0.03 | test_kubernetes_clusters.py test_05_deploy_and_upgrade_kubernetes_ha_cluster | `Error` | 0.03 | test_kubernetes_clusters.py test_06_deploy_and_invalid_upgrade_kubernetes_cluster | `Error` | 0.03 | test_kubernetes_clusters.py test_07_deploy_and_scale_kubernetes_cluster | `Error` | 0.03 | test_kubernetes_clusters.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 0.14 | test_routers_network_ops.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 0.15 | test_routers_network_ops.py ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 1.29 | test_routers_network_ops.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.10 | test_service_offerings.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py test_hostha_kvm_host_fencing | `Error` | 370.17 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
blueorangutan commented on pull request #4250: URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670167974 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4250: [VMware] OVF Full properties support
blueorangutan removed a comment on pull request #4250: URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670146341 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4250: [VMware] OVF Full properties support
nvazquez commented on pull request #4250: URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670167687 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4250: [VMware] OVF Full properties support
blueorangutan removed a comment on pull request #4250: URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670160604 Packaging result: ✔centos7 ✔debian. JID-1668 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez removed a comment on pull request #4250: [VMware] OVF Full properties support
nvazquez removed a comment on pull request #4250: URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670145874 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
blueorangutan commented on pull request #4250: URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670160604 Packaging result: ✔centos7 ✔debian. JID-1668 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support
blueorangutan commented on pull request #4250: URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670146341 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez removed a comment on pull request #4250: [VMware] OVF Full properties support
nvazquez removed a comment on pull request #4250: URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670100956 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4250: [VMware] OVF Full properties support
nvazquez commented on pull request #4250: URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670145874 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4235: [VMware] Full OVF properties support
nvazquez commented on pull request #4235: URL: https://github.com/apache/cloudstack/pull/4235#issuecomment-670101780 Closing this PR - moving work to PR #4250 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez closed pull request #4235: [VMware] Full OVF properties support
nvazquez closed pull request #4235: URL: https://github.com/apache/cloudstack/pull/4235 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez opened a new pull request #4250: [VMware] OVF Full properties support
nvazquez opened a new pull request #4250: URL: https://github.com/apache/cloudstack/pull/4250 ## Description WIP ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4250: [VMware] OVF Full properties support
nvazquez commented on pull request #4250: URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-670100956 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4248: vSphere advanced capabilities with datastore support and api improvements
blueorangutan commented on pull request #4248: URL: https://github.com/apache/cloudstack/pull/4248#issuecomment-670087699 @harikrishna-patnala a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4248: vSphere advanced capabilities with datastore support and api improvements
harikrishna-patnala commented on pull request #4248: URL: https://github.com/apache/cloudstack/pull/4248#issuecomment-670087239 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4248: vSphere advanced capabilities with datastore support and api improvements
blueorangutan commented on pull request #4248: URL: https://github.com/apache/cloudstack/pull/4248#issuecomment-670062537 Packaging result: ✔centos7 ✔debian. JID-1667 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4248: vSphere advanced capabilities with datastore support and api improvements
blueorangutan commented on pull request #4248: URL: https://github.com/apache/cloudstack/pull/4248#issuecomment-670042036 @harikrishna-patnala a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4248: vSphere advanced capabilities with datastore support and api improvements
harikrishna-patnala commented on pull request #4248: URL: https://github.com/apache/cloudstack/pull/4248#issuecomment-670041215 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4141: [New feature] Load balancer customization (haproxy-based)
weizhouapache commented on pull request #4141: URL: https://github.com/apache/cloudstack/pull/4141#issuecomment-669956049 > @weizhouapache will this require a new systemvmtemplate? @rhtyd it requires haproxy 1.8+ for http2 support. As I remember haproxy 1.8 is installed in debian10 systemvm template. No other changes is needed in systemvm template This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on issue #4211: VM HA does not work when server is stopped gracefully
GabrielBrascher commented on issue #4211: URL: https://github.com/apache/cloudstack/issues/4211#issuecomment-669915540 @weizhouapache adding to @DaanHoogland's questions: - what is the primary storage used on the tests? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4207: Human readable sizes in logs
Spaceman1984 commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-669911002 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
blueorangutan commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-669911433 @Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
blueorangutan commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-669910562 Packaging result: ✔centos7 ✔debian. JID-1666 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
blueorangutan commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-669896467 @Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on pull request #4207: Human readable sizes in logs
Spaceman1984 commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-669896149 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] wido commented on pull request #4228: Dont add host back after agent service restart
wido commented on pull request #4228: URL: https://github.com/apache/cloudstack/pull/4228#issuecomment-669894978 I have never run into this situation to be honest. But the change seems sane to me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] wido opened a new pull request #4249: Host SSVM Debian ISO on download.cloudstack.org
wido opened a new pull request #4249: URL: https://github.com/apache/cloudstack/pull/4249 ## Description This way we do not depend on Debian keeping the ISO online or changing URLs which can break our build system(s). See also: #4243 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4235: [VMware] Full OVF properties support
blueorangutan commented on pull request #4235: URL: https://github.com/apache/cloudstack/pull/4235#issuecomment-669856135 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4235: [VMware] Full OVF properties support
rhtyd commented on pull request #4235: URL: https://github.com/apache/cloudstack/pull/4235#issuecomment-669855851 @nvazquez there are also Travis/simulator tests failing, pl check. I'll kick test against KVM for regression checks. @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4243: Update SystemVM debian iso from 10.4.0 to 10.5.0
rhtyd merged pull request #4243: URL: https://github.com/apache/cloudstack/pull/4243 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4243: Update SystemVM debian iso from 10.4.0 to 10.5.0
rhtyd commented on pull request #4243: URL: https://github.com/apache/cloudstack/pull/4243#issuecomment-669847049 The systemvm py scripts are patched via systemvm.iso, so we don't need a new template unless there's something in the 10.5 update. I'll merge this as it breaks build and review/compare changes against the June build. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch master updated (562a7db -> 1a2cc40)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 562a7db Merge remote-tracking branch 'origin/4.14' add 1a2cc40 systemvmtemplate: Update debian 10 iso to 10.5.0 (#4243) No new revisions were added by this update. Summary of changes: tools/appliance/systemvmtemplate/template.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
[GitHub] [cloudstack] blueorangutan commented on pull request #4180: Added nfs minor version support
blueorangutan commented on pull request #4180: URL: https://github.com/apache/cloudstack/pull/4180#issuecomment-669844905 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #4180: Added nfs minor version support
borisstoyanov commented on pull request #4180: URL: https://github.com/apache/cloudstack/pull/4180#issuecomment-669844685 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-669844058 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4016: Fixed private gateway can't be deleted
blueorangutan commented on pull request #4016: URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-669844183 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #4128: Role based users in Projects
borisstoyanov commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-669843692 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4235: [VMware] Full OVF properties support
blueorangutan commented on pull request #4235: URL: https://github.com/apache/cloudstack/pull/4235#issuecomment-669843256 Trillian test result (tid-2276) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 49309 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4235-t2276-vmware-67u3.zip Intermittent failure detected: /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py Intermittent failure detected: /marvin/tests/smoke/test_network.py Intermittent failure detected: /marvin/tests/smoke/test_nic.py Intermittent failure detected: /marvin/tests/smoke/test_projects.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 66 look OK, 12 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_3d_gpu_support | `Error` | 327.04 | test_deploy_vgpu_enabled_vm.py test_00_deploy_vm_root_resize | `Failure` | 278.67 | test_deploy_vm_root_resize.py test_01_add_delete_kubernetes_supported_version | `Error` | 1807.57 | test_kubernetes_supported_versions.py test_reboot_router | `Error` | 239.07 | test_network.py test_03_nic_multiple_vmware | `Error` | 360.91 | test_nic.py test_10_project_activation | `Error` | 27.79 | test_projects.py test_01_reset_vm_on_reboot | `Error` | 17.48 | test_reset_vm_on_reboot.py test_08_start_router | `Error` | 13.38 | test_routers.py test_09_reboot_router | `Error` | 1.10 | test_routers.py test_04_change_offering_small | `Error` | 20.67 | test_service_offerings.py test_05_stop_ssvm | `Failure` | 920.82 | test_ssvm.py test_06_stop_cpvm | `Failure` | 919.71 | test_ssvm.py test_07_reboot_ssvm | `Failure` | 36.81 | test_ssvm.py test_01_volume_usage | `Error` | 90.60 | test_usage.py test_07_start_vm | `Error` | 17.45 | test_vm_life_cycle.py test_08_reboot_vm | `Error` | 1.10 | test_vm_life_cycle.py test_11_migrate_vm | `Error` | 52.91 | test_vm_life_cycle.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #4016: Fixed private gateway can't be deleted
borisstoyanov commented on pull request #4016: URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-669843440 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on a change in pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
andrijapanicsb commented on a change in pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#discussion_r466305525 ## File path: setup/db/create-database-simulator.sql ## @@ -20,8 +20,8 @@ DROP DATABASE IF EXISTS `simulator`; CREATE DATABASE `simulator`; -GRANT ALL ON simulator.* to cloud@`localhost` identified by 'cloud'; -GRANT ALL ON simulator.* to cloud@`%` identified by 'cloud'; +GRANT ALL ON simulator.* to cloud@`localhost`; +GRANT ALL ON simulator.* to cloud@`%`; Review comment: @shwstppr I assume a password for this user is set elsewhere? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on a change in pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
andrijapanicsb commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r466304580
##
File path: scripts/storage/qcow2/managesnapshot.sh
##
@@ -187,6 +187,7 @@ backup_snapshot() {
local snapshotname="$2"
local destPath=$3
local destName=$4
+ local forceShareFlag="-U"
Review comment:
qemu 2.10 I believe, which also means when using qemu-kvm-ev 2.10+ on
i.e. CentOS7 is fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] ravening commented on a change in pull request #4230: Enable resetting config values to default value
ravening commented on a change in pull request #4230:
URL: https://github.com/apache/cloudstack/pull/4230#discussion_r466268971
##
File path: engine/schema/src/main/java/com/cloud/dc/ClusterDetailsDaoImpl.java
##
@@ -103,18 +103,31 @@ public void persist(long clusterId, Map
details) {
expunge(sc);
for (Map.Entry detail : details.entrySet()) {
+String name = detail.getKey();
+if (name.equalsIgnoreCase("cpu.overprovisioning.factor")) {
+name = "cpuOvercommitRatio";
+}
+if (name.equalsIgnoreCase("mem.overprovisioning.factor")) {
+name = "memoryOvercommitRatio";
+}
Review comment:
You can run the integration test cases using `nosetests --with-marvin
--marvin-config= test_reset_configuration_settings.py`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs
blueorangutan commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-669771901 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #4207: Human readable sizes in logs
borisstoyanov commented on pull request #4207: URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-669771589 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala opened a new pull request #4248: vSphere advanced capabilities with datastore support and api improvements
harikrishna-patnala opened a new pull request #4248: URL: https://github.com/apache/cloudstack/pull/4248 ## Description Added support for different datastore types like vSAN, vVols, VMFS6, Datastore clusters. Along with these native APIs of vCenter have been used. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue
DaanHoogland commented on pull request #4020: URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-669762391 @weizhouapache there are conflicts. also do you want this on 4.14 or master only? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4243: Update SystemVM debian iso from 10.4.0 to 10.5.0
DaanHoogland commented on pull request #4243: URL: https://github.com/apache/cloudstack/pull/4243#issuecomment-669760306 if you need it you need it and i am fine with it. lgtm in that respect. i do not like the flimsy procedure we use, but i can live with it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4030: some minor changes to make the build run with python 3
DaanHoogland commented on a change in pull request #4030: URL: https://github.com/apache/cloudstack/pull/4030#discussion_r466194209 ## File path: tools/apidoc/gen_toc.py ## @@ -245,10 +245,10 @@ def choose_category(fn): def xml_for(command): name = command['name'] -async = command['async'] and ' (A)' or '' +asyncmethod = command['async'] and ' (A)' or '' Review comment: I think the cygwin specific python is not a good idea in any case `#! /bin/env python` would be better. I think this is being taken into account in ther PRs so maybe i should close, @nvazquez @GabrielBrascher ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
