[GitHub] [cloudstack] DaanHoogland commented on issue #4613: Cannot remove Secondary storage after using new feature "migration of secondary storage"
DaanHoogland commented on issue #4613: URL: https://github.com/apache/cloudstack/issues/4613#issuecomment-766624907 @AlexanderKgr are there system templates still on that secstor? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run
blueorangutan commented on pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-766622463 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd opened a new pull request #4150: [HEALTH][4.14] Health Check Run
rhtyd opened a new pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150 Dummy commit to run health checks on 4.14 branch - DO NOT MERGE This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4150: [HEALTH][4.14] Health Check Run
rhtyd commented on pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-766621750 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4150: [HEALTH][4.14] Health Check Run
rhtyd closed pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4600: server: fix cannot create vm if another vm with same name has been added and removed on the network
blueorangutan commented on pull request #4600: URL: https://github.com/apache/cloudstack/pull/4600#issuecomment-766621269 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4600: server: fix cannot create vm if another vm with same name has been added and removed on the network
rhtyd commented on pull request #4600: URL: https://github.com/apache/cloudstack/pull/4600#issuecomment-766620783 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4588: Enable SNI in SSVM
rhtyd commented on pull request #4588: URL: https://github.com/apache/cloudstack/pull/4588#issuecomment-766620268 @olivierlemasle should this apply for master/4.15 or do you want to change the base branch to 4.14? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4543: marvin and tests python 2to3
blueorangutan removed a comment on pull request #4543: URL: https://github.com/apache/cloudstack/pull/4543#issuecomment-766436356 Packaging result: ✔centos7 ✔centos8 ✖debian. JID-5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4609: API discovery: Prevent overwrite of API parameters in cases where API names are same
blueorangutan commented on pull request #4609: URL: https://github.com/apache/cloudstack/pull/4609#issuecomment-766599200 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4609: API discovery: Prevent overwrite of API parameters in cases where API names are same
rhtyd commented on pull request #4609: URL: https://github.com/apache/cloudstack/pull/4609#issuecomment-766598435 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4329: Adding AutoScaling for cks + CKS CoreOS EOL update
blueorangutan commented on pull request #4329: URL: https://github.com/apache/cloudstack/pull/4329#issuecomment-766597456 @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4329: Adding AutoScaling for cks + CKS CoreOS EOL update
Pearl1594 commented on pull request #4329: URL: https://github.com/apache/cloudstack/pull/4329#issuecomment-766596849 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4610: [UI] Cannot remove tags on host and primary storage
rhtyd commented on issue #4610: URL: https://github.com/apache/cloudstack/issues/4610#issuecomment-766590973 Fixed in https://github.com/apache/cloudstack/pull/4611, can you test latest 4.15 and close @slavkap This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch 4.15 updated: ui: Storage Pool Tags unable to delete last tag (#4611)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.15
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.15 by this push:
new c5b1fec ui: Storage Pool Tags unable to delete last tag (#4611)
c5b1fec is described below
commit c5b1fec11ba38d54454860f4ab76e682d715b71b
Author: Pearl Dsilva
AuthorDate: Mon Jan 25 12:23:44 2021 +0530
ui: Storage Pool Tags unable to delete last tag (#4611)
* UI Storage Pool Tags: unable to delete last tag
* add updatePhysicalNetwork to the list
Co-authored-by: Pearl Dsilva
---
ui/src/views/AutogenView.vue | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/ui/src/views/AutogenView.vue b/ui/src/views/AutogenView.vue
index 0cdf4a6..157d7d7 100644
--- a/ui/src/views/AutogenView.vue
+++ b/ui/src/views/AutogenView.vue
@@ -957,7 +957,8 @@ export default {
if (param.name !== key) {
continue
}
-if (input === undefined || input === null || input === '') {
+if (!input === undefined || input === null ||
+ (input === '' && !['updateStoragePool', 'updateHost',
'updatePhysicalNetwork'].includes(action.api))) {
if (param.type === 'boolean') {
params[key] = false
}
[GitHub] [cloudstack] rhtyd merged pull request #4611: UI Storage Pool Tags: unable to delete last tag
rhtyd merged pull request #4611: URL: https://github.com/apache/cloudstack/pull/4611 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
blueorangutan commented on pull request #4605: URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-766590395 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
rhtyd commented on pull request #4605: URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-766589948 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] utchoang commented on a change in pull request #4611: UI Storage Pool Tags: unable to delete last tag
utchoang commented on a change in pull request #4611:
URL: https://github.com/apache/cloudstack/pull/4611#discussion_r563480419
##
File path: ui/src/views/AutogenView.vue
##
@@ -957,7 +957,8 @@ export default {
if (param.name !== key) {
continue
}
-if (input === undefined || input === null || input === '') {
+if (input === undefined || input === null || (input === '' &&
Review comment:
I understood! Thanks @Pearl1594
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4611: UI Storage Pool Tags: unable to delete last tag
Pearl1594 commented on a change in pull request #4611:
URL: https://github.com/apache/cloudstack/pull/4611#discussion_r563468761
##
File path: ui/src/views/AutogenView.vue
##
@@ -957,7 +957,8 @@ export default {
if (param.name !== key) {
continue
}
-if (input === undefined || input === null || input === '') {
+if (input === undefined || input === null || (input === '' &&
Review comment:
@utchoang doing so would lead to the second condition not being
evaluated when the input param is empty('') and the api is one among - update
physicalnetwork/storagepool/host as the first condition evaluates to true -
because (!input) = string not being undefined, null or empty.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
blueorangutan commented on pull request #4615: URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-766544967 Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2577 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] utchoang commented on a change in pull request #4611: UI Storage Pool Tags: unable to delete last tag
utchoang commented on a change in pull request #4611:
URL: https://github.com/apache/cloudstack/pull/4611#discussion_r563460413
##
File path: ui/src/views/AutogenView.vue
##
@@ -957,7 +957,8 @@ export default {
if (param.name !== key) {
continue
}
-if (input === undefined || input === null || input === '') {
+if (input === undefined || input === null || (input === '' &&
Review comment:
@Pearl1594 In my opinion it will be cleaner like this
`if (!input || (input === '' && !['updateStoragePool',
'updateHost'].includes(action.api)))` {
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
blueorangutan commented on pull request #4615: URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-76653 @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Pearl1594 commented on pull request #4615: URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-766534072 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
blueorangutan commented on pull request #4615: URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-766527492 @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Pearl1594 commented on pull request #4615: URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-766527323 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 opened a new pull request #4615: Secondary storage: Allow store deletion after successful data migration
Pearl1594 opened a new pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615
### Description
This PR fixes the issue reported in
:https://github.com/apache/cloudstack/issues/4613
This issue seems to have cropped up due to code revert that happened by
commit - d864e9dc39b69e590e3df898a03a874a8173fcc6
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### How Has This Been Tested?
1. Migrate data from one image store to another
2. Attempt deleting the store from where all data objects we migrated
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4604: api: add zone, vm name params in listVmSnapshot response
harikrishna-patnala commented on pull request #4604: URL: https://github.com/apache/cloudstack/pull/4604#issuecomment-766519108 > @shwstppr May be some generic approach for the API response objects, to tag both UUID and Name (wherever UUID is returned) might work for all the APIs, and the names can be used appropriately in the UI when required. @sureshanaparti I get your proposal, but that I think it needs significant amount of changes as Name is not part of common interfaces (which I think is required for a generic approach) and it is defined as different names for each resource. May be an another improvement ticket would help this PR to get continued ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #4611: UI Storage Pool Tags: unable to delete last tag
harikrishna-patnala commented on a change in pull request #4611:
URL: https://github.com/apache/cloudstack/pull/4611#discussion_r563441872
##
File path: ui/src/views/AutogenView.vue
##
@@ -957,7 +957,8 @@ export default {
if (param.name !== key) {
continue
}
-if (input === undefined || input === null || input === '') {
+if (input === undefined || input === null || (input === '' &&
+ !['updateStoragePool', 'updateHost'].includes(action.api))) {
Review comment:
@Pearl1594 we have physical networks tags also, I just checked we could
not delete the tag on physical network too, can you please add that here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] utchoang opened a new pull request #4614: Add quickview to the list of VM Snapshot
utchoang opened a new pull request #4614:
URL: https://github.com/apache/cloudstack/pull/4614
### Description
This PR is used to fix the Quick access menu bar missing for VM Snapshots
Fixes https://github.com/apache/cloudstack/issues/4607
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
UI
After fixed:
### How Has This Been Tested?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] utchoang closed pull request #4608: vmsnapshot: Add quickview to the list of VM Snapshot
utchoang closed pull request #4608: URL: https://github.com/apache/cloudstack/pull/4608 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #4608: vmsnapshot: Add quickview to the list of VM Snapshot
utchoang commented on pull request #4608: URL: https://github.com/apache/cloudstack/pull/4608#issuecomment-766473573 Closed to open a new PR with 4.15.0 branch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4543: marvin and tests python 2to3
blueorangutan commented on pull request #4543: URL: https://github.com/apache/cloudstack/pull/4543#issuecomment-766436356 Packaging result: ✔centos7 ✔centos8 ✖debian. JID-5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4543: marvin and tests python 2to3
blueorangutan removed a comment on pull request #4543: URL: https://github.com/apache/cloudstack/pull/4543#issuecomment-765375351 Packaging result: ✔centos7 ✔centos8 ✖debian. JID-4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #4590: Customized HostnameVerifier bypasses the hostname verification
DaanHoogland commented on issue #4590: URL: https://github.com/apache/cloudstack/issues/4590#issuecomment-766413211 @AthenaXiao this is a community driven project, people that experience problems try to get solutions merged. Static analysis has been showing us bad coding practices but without shown exploit no action will be taken. Usually it turns out we are talking about dead code or code that is isolated and unexposed. As this is an integration system, a lot of support for external systems gets implemented and sometimes not phased out in a timely fashion. We get reports like this from time to time and usualy as a result, but seldom do we feel there is a thread serious enough to take action. As said without exploit nobody will be interested to take action. As for potential attack planes, these are the API en the VR/dnmasq/iptables of routers and other system VMs. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
