[GitHub] [cloudstack] weizhouapache commented on pull request #4600: server: fix cannot create vm if another vm with same name has been added and removed on the network
weizhouapache commented on pull request #4600: URL: https://github.com/apache/cloudstack/pull/4600#issuecomment-767354931 @shwstppr thanks for tesitng. however, I made a new commit to add back a line of code as per @DaanHoogland 's comment. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4574: db-schema update 4.15.0 to 4.15.1: correct some guest-os namings
weizhouapache commented on pull request #4574: URL: https://github.com/apache/cloudstack/pull/4574#issuecomment-767352934 > @weizhouapache > id 85 looks somehow strange - I gues it should be "other guest" instead of "SCO OpenServer 5" 樂 > > ```sql > SELECT * FROM cloud.guest_os WHERE id=85; > # id, category_id, name, uuid, display_name, created, removed, is_user_defined > '85', '9', NULL, '78751473-935a-11ea-95f2-005056bb3ebd', 'SCO OpenServer 5', '2020-05-11 09:42:56', NULL, '0' > ``` > > ```sql > SELECT * FROM cloud.guest_os_hypervisor WHERE guest_os_id=85; > # id, hypervisor_type, guest_os_name, guest_os_id, hypervisor_version, uuid, created, removed, is_user_defined > '202', 'VmWare', 'SCO OpenServer 5', '85', 'default', '07511bbc-935b-11ea-95f2-005056bb3ebd', '2020-05-11 09:42:56', NULL, '0' > '1387', 'VMware', 'otherGuest', '85', '4.0', '0864ff31-935b-11ea-95f2-005056bb3ebd', '2020-05-11 09:42:58', NULL, '0' > '1528', 'VMware', 'otherGuest', '85', '4.1', '0870b56f-935b-11ea-95f2-005056bb3ebd', '2020-05-11 09:42:58', NULL, '0' > '1669', 'VMware', 'otherGuest', '85', '5.0', '087d1de5-935b-11ea-95f2-005056bb3ebd', '2020-05-11 09:42:58', NULL, '0' > '1810', 'VMware', 'otherGuest', '85', '5.1', '0888ac46-935b-11ea-95f2-005056bb3ebd', '2020-05-11 09:42:58', NULL, '0' > '1951', 'VMware', 'otherGuest', '85', '5.5', '0895bef6-935b-11ea-95f2-005056bb3ebd', '2020-05-11 09:42:58', NULL, '0' > '2448', 'VMware', 'otherGuest', '85', '6.0', '0cf88f63-935b-11ea-95f2-005056bb3ebd', '2020-05-11 07:43:05', NULL, '0' > '2889', 'VMware', 'otherGuest', '85', '6.5', '0f30e427-935b-11ea-95f2-005056bb3ebd', '2020-05-11 07:43:09', NULL, '0' > '4822', 'VMware', 'otherGuest', '85', '6.7', '1169e8de-935b-11ea-95f2-005056bb3ebd', '2020-05-11 07:43:13', NULL, '0' > '5077', 'VMware', 'otherGuest', '85', '6.7.1', '116b494b-935b-11ea-95f2-005056bb3ebd', '2020-05-11 07:43:13', NULL, '0' > '5332', 'VMware', 'otherGuest', '85', '6.7.2', '116c801a-935b-11ea-95f2-005056bb3ebd', '2020-05-11 07:43:13', NULL, '0' > '5587', 'VMware', 'otherGuest', '85', '6.7.3', '116dbb0a-935b-11ea-95f2-005056bb3ebd', '2020-05-11 07:43:13', NULL, '0' > ``` @mib1185 thanks. @nvazquez since you are author of commit 50ab1b2fbe84aa60d8d7adc12919bebc83b5e003, could you please look at the issue above ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4602: server: keep networks order and ips while move a vm with multiple networks
weizhouapache commented on pull request #4602: URL: https://github.com/apache/cloudstack/pull/4602#issuecomment-767348025 > false, > "isolationuri": "vlan://1234", > "macaddress": "1e:00:0d:00:01:9c", > "netmask": "255.255.255.0", > "networkid": "7e686848-e92a-449a-b1e3-cb0e5116ea7f", > "networkname": "net-a", > "secondaryip": [], @shwstppr I will look into it. what type of zone in simulator env ? advanced zone with isolated networks or security groups ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4601: server: Get vm network/disk statistics and update database per host
blueorangutan commented on pull request #4601: URL: https://github.com/apache/cloudstack/pull/4601#issuecomment-767338623 @shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4601: server: Get vm network/disk statistics and update database per host
shwstppr commented on pull request #4601: URL: https://github.com/apache/cloudstack/pull/4601#issuecomment-767338268 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4601: server: Get vm network/disk statistics and update database per host
blueorangutan commented on pull request #4601: URL: https://github.com/apache/cloudstack/pull/4601#issuecomment-767326704 Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2591 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4601: server: Get vm network/disk statistics and update database per host
blueorangutan commented on pull request #4601: URL: https://github.com/apache/cloudstack/pull/4601#issuecomment-767317405 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4601: server: Get vm network/disk statistics and update database per host
blueorangutan removed a comment on pull request #4601: URL: https://github.com/apache/cloudstack/pull/4601#issuecomment-766732816 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4601: server: Get vm network/disk statistics and update database per host
shwstppr commented on pull request #4601: URL: https://github.com/apache/cloudstack/pull/4601#issuecomment-767317125 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4602: server: keep networks order and ips while move a vm with multiple networks
shwstppr commented on pull request #4602:
URL: https://github.com/apache/cloudstack/pull/4602#issuecomment-767316593
@ustcweizhou maybe it due to Simulator env but while assigning a new user,
VM lost one NIC while IP for default network remained the same. Is this
expected behaviour?
```
> list virtualmachine id=aa71e2fb-7339-485f-877a-3ac61e4b81de
{
"virtualmachine": {
"account": "admin",
"affinitygroup": [],
"cpunumber": 1,
"cpuspeed": 500,
"created": "2021-01-26T11:24:28+0530",
"details": {
"Message.ReservedCapacityFreed.Flag": "false"
},
"displayname": "t2",
"displayvm": true,
"domain": "ROOT",
"domainid": "284bc227-5f98-11eb-b2a8-a0afbd4a2d60",
"guestosid": "283ee5bb-5f98-11eb-b2a8-a0afbd4a2d60",
"haenable": false,
"hypervisor": "Simulator",
"id": "aa71e2fb-7339-485f-877a-3ac61e4b81de",
"instancename": "i-2-6-QA",
"isdynamicallyscalable": false,
"jobid": "32b17768-41c6-485e-b4b8-23cb1c6cf862",
"jobstatus": 0,
"memory": 512,
"name": "t2",
"nic": [
{
"broadcasturi": "vlan://4321",
"extradhcpoption": [],
"gateway": "10.9.8.1",
"id": "22c803ef-e260-496e-901d-af853d51079e",
"ipaddress": "10.9.8.19",
"isdefault": true,
"isolationuri": "vlan://4321",
"macaddress": "1e:00:da:00:01:ab",
"netmask": "255.255.255.0",
"networkid": "62694527-4073-4e8e-840f-1688a4652cd0",
"networkname": "net-b",
"secondaryip": [],
"traffictype": "Guest",
"type": "Shared"
},
{
"broadcasturi": "vlan://1234",
"extradhcpoption": [],
"gateway": "10.9.9.1",
"id": "55cb9940-14c7-46df-a83b-72419bb52ce4",
"ipaddress": "10.9.9.24",
"isdefault": false,
"isolationuri": "vlan://1234",
"macaddress": "1e:00:0d:00:01:9c",
"netmask": "255.255.255.0",
"networkid": "7e686848-e92a-449a-b1e3-cb0e5116ea7f",
"networkname": "net-a",
"secondaryip": [],
"traffictype": "Guest",
"type": "Shared"
}
],
"osdisplayname": "CentOS 5.6 (64-bit)",
"ostypeid": "283ee5bb-5f98-11eb-b2a8-a0afbd4a2d60",
"passwordenabled": false,
"rootdeviceid": 0,
"rootdevicetype": "ROOT",
"securitygroup": [],
"serviceofferingid": "a0194498-2a06-4110-9db1-99020ba9a326",
"serviceofferingname": "Small Instance",
"state": "Stopped",
"tags": [],
"templatedisplaytext": "CentOS 5.6 (64-bit) no GUI (Simulator)",
"templateid": "68a1f0ce-5f98-11eb-b2a8-a0afbd4a2d60",
"templatename": "CentOS 5.6 (64-bit) no GUI (Simulator)",
"userid": "284f2b10-5f98-11eb-b2a8-a0afbd4a2d60",
"username": "admin",
"zoneid": "390f525e-6c46-432d-8552-6519980f34c3",
"zonename": "Sandbox-simulator"
}
}
```
After assigning new user,
```
> assign virtualmachine
virtualmachineid=aa71e2fb-7339-485f-877a-3ac61e4b81de account=admin1
domainid=284bc227-5f98-11eb-b2a8-a0afbd4a2d60
{
"virtualmachine": {
"account": "admin1",
"affinitygroup": [],
"cpunumber": 1,
"cpuspeed": 500,
"created": "2021-01-26T11:24:28+0530",
"details": {
"Message.ReservedCapacityFreed.Flag": "false"
},
"displayname": "t2",
"displayvm": true,
"domain": "ROOT",
"domainid": "284bc227-5f98-11eb-b2a8-a0afbd4a2d60",
"guestosid": "283ee5bb-5f98-11eb-b2a8-a0afbd4a2d60",
"haenable": false,
"hypervisor": "Simulator",
"id": "aa71e2fb-7339-485f-877a-3ac61e4b81de",
"instancename": "i-2-6-QA",
"isdynamicallyscalable": false,
"memory": 512,
"name": "t2",
"nic": [
{
"broadcasturi": "vlan://4321",
"extradhcpoption": [],
"gateway": "10.9.8.1",
"id": "4c1ae559-b16d-4535-a2aa-95095a6904aa",
"ipaddress": "10.9.8.19",
"isdefault": true,
"isolationuri": "vlan://4321",
"macaddress": "1e:00:ea:00:01:ab",
"netmask": "255.255.255.0",
"networkid": "62694527-4073-4e8e-840f-1688a4652cd0",
"networkname": "net-b",
"secondaryip": [],
"traffictype": "Guest",
"type": "Shared"
}
],
"osdisplayname": "CentOS 5.6 (64-bit)",
"ostypeid": "283ee5bb-5f98-11eb-b2a8-a0afbd4a2d60",
"passwordenabled": false,
"rootdeviceid": 0,
"rootdevicetype": "ROOT",
"securitygroup": [],
"serviceofferingid": "a0194498-2a06-4110-9db1-99020ba9a326",
"serviceofferingname": "Small Instance",
"state": "Stopped",
"tags": [],
"templatedisplaytext":
[GitHub] [cloudstack] shwstppr commented on pull request #4259: Reserve memory for host
shwstppr commented on pull request #4259: URL: https://github.com/apache/cloudstack/pull/4259#issuecomment-766726790 @ravening Conflicts here too. Moving to 4.16.0.0 milestone based on base branch please update if needed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4604: api: add zone, vm name params in listVmSnapshot response
rhtyd commented on pull request #4604: URL: https://github.com/apache/cloudstack/pull/4604#issuecomment-766639433 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4329: Adding AutoScaling for cks + CKS CoreOS EOL update
Pearl1594 commented on a change in pull request #4329:
URL: https://github.com/apache/cloudstack/pull/4329#discussion_r563657612
##
File path: tools/appliance/systemvmtemplate/scripts/install_systemvm_packages.sh
##
@@ -70,20 +76,33 @@ function install_packages() {
radvd \
sharutils genisoimage aria2 \
strongswan libcharon-extra-plugins libstrongswan-extra-plugins
strongswan-charon strongswan-starter \
-virt-what open-vm-tools qemu-guest-agent hyperv-daemons
+virt-what open-vm-tools qemu-guest-agent hyperv-daemons cloud-guest-utils \
+apt-transport-https ca-certificates curl gnupg gnupg-agent
software-properties-common cloud-init
apt-get -y autoremove --purge
apt-get clean
apt-get autoclean
+ apt_clean
${apt_get} install links
+ curl -fsSL https://download.docker.com/linux/debian/gpg | sudo apt-key add -
+ apt-key fingerprint 0EBFCD88
+
#32 bit architecture support for vhd-util: not required for 32 bit template
if [ "${arch}" != "i386" ]; then
dpkg --add-architecture i386
apt-get update
${apt_get} install libuuid1:i386 libc6:i386
+
+add-apt-repository \
+"deb [arch=amd64] https://download.docker.com/linux/debian \
+$(lsb_release -cs) \
+stable"
+apt-get update
+${apt_get} install docker-ce docker-ce-cli containerd.io
Review comment:
@weizhouapache With coreOS having reached EOL, we've enabled the
systemVM template to be consumed by CKS for deploying K8s clusters. Hence
docker is installed in the template. However, the service is only run on the
cks nodes
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #3950: Docker build fails in master
DaanHoogland commented on issue #3950: URL: https://github.com/apache/cloudstack/issues/3950#issuecomment-766702478 @ravening is this still an issue? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4591: server: select root disk based on user input during vm import
shwstppr commented on pull request #4591: URL: https://github.com/apache/cloudstack/pull/4591#issuecomment-766678915 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr closed pull request #3804: Display capability info in listNetwork response
shwstppr closed pull request #3804: URL: https://github.com/apache/cloudstack/pull/3804 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4032: Suspending the VM prior to deleting snapshots to avoid corruption, th…
shwstppr commented on pull request #4032: URL: https://github.com/apache/cloudstack/pull/4032#issuecomment-766714686 @ggoodrich-ipp can you please resolve conflicts This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland edited a comment on pull request #4543: marvin and tests python 2to3
DaanHoogland edited a comment on pull request #4543: URL: https://github.com/apache/cloudstack/pull/4543#issuecomment-766833532 packaging and install on centos7 succesfull in trillian @rhtyd . I will look at the travis run next. erratum, not all the trillian scripts work yet. Marvin is not installed in python3 :( This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4150: [HEALTH][4.14] Health Check Run
rhtyd commented on pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-766621750 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4453: Provide cleanup option to force deleting a project
weizhouapache commented on pull request #4453: URL: https://github.com/apache/cloudstack/pull/4453#issuecomment-766910722 @ravening can you resolve the conflicts, and make primate ui change ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4491: fix on changeServiceForVirtualMachine when updating read/write rate
shwstppr commented on pull request #4491: URL: https://github.com/apache/cloudstack/pull/4491#issuecomment-766696066 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4609: API discovery: Prevent overwrite of API parameters in cases where API names are same
blueorangutan commented on pull request #4609: URL: https://github.com/apache/cloudstack/pull/4609#issuecomment-766599200 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4491: fix on changeServiceForVirtualMachine when updating read/write rate
blueorangutan commented on pull request #4491: URL: https://github.com/apache/cloudstack/pull/4491#issuecomment-766696470 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run
blueorangutan commented on pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-766622463 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd removed a comment on pull request #4604: api: add zone, vm name params in listVmSnapshot response
rhtyd removed a comment on pull request #4604: URL: https://github.com/apache/cloudstack/pull/4604#issuecomment-766639433 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4582: Upgrade: check systemvm template before db changes
shwstppr commented on pull request #4582: URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-766683652 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4150: [HEALTH][4.14] Health Check Run
rhtyd closed pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] slavkap commented on issue #4610: [UI] Cannot remove tags on host and primary storage
slavkap commented on issue #4610: URL: https://github.com/apache/cloudstack/issues/4610#issuecomment-766641779 thanks, @rhtyd, it works correctly This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4611: UI Storage Pool Tags: unable to delete last tag
Pearl1594 commented on a change in pull request #4611:
URL: https://github.com/apache/cloudstack/pull/4611#discussion_r563468761
##
File path: ui/src/views/AutogenView.vue
##
@@ -957,7 +957,8 @@ export default {
if (param.name !== key) {
continue
}
-if (input === undefined || input === null || input === '') {
+if (input === undefined || input === null || (input === '' &&
Review comment:
@utchoang doing so would lead to the second condition not being
evaluated when the input param is empty('') and the api is one among - update
physicalnetwork/storagepool/host as the first condition evaluates to true -
because (!input) = string not being undefined, null or empty.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4600: server: fix cannot create vm if another vm with same name has been added and removed on the network
shwstppr commented on pull request #4600: URL: https://github.com/apache/cloudstack/pull/4600#issuecomment-766785992 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #4581: Restore VMware VM naming convention option
shwstppr commented on a change in pull request #4581: URL: https://github.com/apache/cloudstack/pull/4581#discussion_r563605527 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -3844,7 +3848,10 @@ private UserVm createVirtualMachine(DataCenter zone, ServiceOffering serviceOffe // Check is hostName is RFC compliant checkNameForRFCCompliance(hostName); } -instanceName = VirtualMachineName.getVmName(id, owner.getId(), _instance); +instanceName = VirtualMachineName.getVmName(id, owner.getId(), instanceSuffix); Review comment: @harikrishna-patnala default value of `instanceSuffix` is `_instance` (which should get instance.name). Only in case of VMware and instanceFlag it is set to hostname at ln 3832. Therefore, only when instanceFlag and other conditions are satisfied `instanceName` will be `i - - -` and will be later set to hypervisor This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4574: correct db-schema update 4.14.0 to 4.15.0
shwstppr commented on pull request #4574: URL: https://github.com/apache/cloudstack/pull/4574#issuecomment-766686293 @mib1185 can you please fix conflicts and rebase against 4.15 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4611: UI Storage Pool Tags: unable to delete last tag
rhtyd merged pull request #4611: URL: https://github.com/apache/cloudstack/pull/4611 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] mib1185 commented on pull request #4574: correct db-schema update 4.14.0 to 4.15.0
mib1185 commented on pull request #4574: URL: https://github.com/apache/cloudstack/pull/4574#issuecomment-766715842 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #4030: some minor changes to make the build run with python 3
DaanHoogland closed pull request #4030: URL: https://github.com/apache/cloudstack/pull/4030 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on pull request #4591: server: select root disk based on user input during vm import
DK101010 commented on pull request #4591: URL: https://github.com/apache/cloudstack/pull/4591#issuecomment-766767282 > @DK101010 I've refactored logic for handling disks and `datadiskofferinglist` param. As mentioned in the description, correct ROOT disk should be selected now and there won't any need for new API parameters. Will be great if you can test I'm a little bit skeptical regards the offeringMap :D but I will test it this week. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4378: server: Optional destination host when migrate a vm
shwstppr commented on pull request #4378: URL: https://github.com/apache/cloudstack/pull/4378#issuecomment-766730273 @ustcweizhou needs changes in new UI This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4548: Bug/disk order bug during ingest
shwstppr commented on pull request #4548: URL: https://github.com/apache/cloudstack/pull/4548#issuecomment-766690030 @DK101010 closed in favour of #4591. Please re-open if needed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4329: Adding AutoScaling for cks + CKS CoreOS EOL update
blueorangutan commented on pull request #4329: URL: https://github.com/apache/cloudstack/pull/4329#issuecomment-766597456 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4445: Cleanup domain details when domain is deleted
shwstppr commented on pull request #4445: URL: https://github.com/apache/cloudstack/pull/4445#issuecomment-766725981 @ravening Moving to 4.16.0.0 milestone based on base branch please update if needed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] AlexanderKgr commented on issue #4613: Cannot remove Secondary storage after using new feature "migration of secondary storage"
AlexanderKgr commented on issue #4613: URL: https://github.com/apache/cloudstack/issues/4613#issuecomment-766629437 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4032: Suspending the VM prior to deleting snapshots to avoid corruption, th…
weizhouapache commented on pull request #4032: URL: https://github.com/apache/cloudstack/pull/4032#issuecomment-766808374 @ggoodrich-ipp what issue does this pr solve ? Delete a vm snapshot twice ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr closed pull request #4548: Bug/disk order bug during ingest
shwstppr closed pull request #4548: URL: https://github.com/apache/cloudstack/pull/4548 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4588: Enable SNI in SSVM
rhtyd commented on pull request #4588: URL: https://github.com/apache/cloudstack/pull/4588#issuecomment-766620268 @olivierlemasle should this apply for master/4.15 or do you want to change the base branch to 4.14? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4600: server: fix cannot create vm if another vm with same name has been added and removed on the network
rhtyd commented on pull request #4600: URL: https://github.com/apache/cloudstack/pull/4600#issuecomment-766620783 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4604: api: add zone, vm name params in listVmSnapshot response
blueorangutan commented on pull request #4604: URL: https://github.com/apache/cloudstack/pull/4604#issuecomment-766641577 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4534: Migrate vm across clusters
weizhouapache commented on pull request #4534: URL: https://github.com/apache/cloudstack/pull/4534#issuecomment-766815988 > @ustcweizhou I guess this will need changes in new UI now > I've not tested yet but cross-cluster migration could result in failure when there are only cluster-scoped primary stores so do we handle that? In case of VMware this could fail even with vMotion enabled with current master something that has been changed in #4385 @shwstppr it is addressed in this pr. if vm has volumes on cluster-wide storage, migrate will fail. migraiton is possible only if (1) all volumes are on zone-wide storage (2) source cluster and dest cluster have same hypervisor type. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4615: Secondary storage: Allow store deletion after successful data migration
Pearl1594 commented on a change in pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#discussion_r563572941
##
File path: server/src/main/java/com/cloud/api/query/dao/TemplateJoinDaoImpl.java
##
@@ -522,6 +522,7 @@ public TemplateResponse newIsoResponse(TemplateJoinVO iso) {
sc.setParameters("store_id", storeId);
sc.setParameters("type", TemplateType.USER);
sc.setParameters("templateState", VirtualMachineTemplate.State.Active);
+sc.setParameters("public", Boolean.FALSE);
Review comment:
@shwstppr Deletion of image stores will be prevented only if there are
private user templates present on the respective store.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] slavkap closed issue #4610: [UI] Cannot remove tags on host and primary storage
slavkap closed issue #4610: URL: https://github.com/apache/cloudstack/issues/4610 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4601: server: Get vm network/disk statistics and update database per host
weizhouapache commented on pull request #4601: URL: https://github.com/apache/cloudstack/pull/4601#issuecomment-766860780 @DaanHoogland thanks for review. modified some debug message @shwstppr code is changed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #3804: Display capability info in listNetwork response
shwstppr commented on pull request #3804: URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-766701585 @ravening Moving to 4.16 based on base branch. Please update if needed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #3804: Display capability info in listNetwork response
DaanHoogland commented on pull request #3804: URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-766760230 > @ravening Moving to 4.16 based on base branch. Please update if needed made it 4.15 (didn't try 4.14, making assumptions) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache edited a comment on pull request #4616: Add logs to api removeVpnUser
weizhouapache edited a comment on pull request #4616: URL: https://github.com/apache/cloudstack/pull/4616#issuecomment-767026936 I am more interested in the reason and the fix. do you have clue ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #4581: Restore VMware VM naming convention option
harikrishna-patnala commented on a change in pull request #4581: URL: https://github.com/apache/cloudstack/pull/4581#discussion_r563524961 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -3844,7 +3848,10 @@ private UserVm createVirtualMachine(DataCenter zone, ServiceOffering serviceOffe // Check is hostName is RFC compliant checkNameForRFCCompliance(hostName); } -instanceName = VirtualMachineName.getVmName(id, owner.getId(), _instance); +instanceName = VirtualMachineName.getVmName(id, owner.getId(), instanceSuffix); Review comment: here `instanceName` variable is used to set name on hypervisor but the same variable is used later for internal name. `instanceSuffix` is assigned based on displayName (not considering instanceNameFlag), does this effect the case where flag is false and displayName is provided ? In that case internal-name should be `i - - -` but here we are assigning `i - - -`. ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -3844,7 +3848,10 @@ private UserVm createVirtualMachine(DataCenter zone, ServiceOffering serviceOffe // Check is hostName is RFC compliant checkNameForRFCCompliance(hostName); } -instanceName = VirtualMachineName.getVmName(id, owner.getId(), _instance); +instanceName = VirtualMachineName.getVmName(id, owner.getId(), instanceSuffix); Review comment: Thanks @shwstppr I missed the check at 3823 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] ggoodrich-ipp commented on pull request #4032: Suspending the VM prior to deleting snapshots to avoid corruption, th…
ggoodrich-ipp commented on pull request #4032: URL: https://github.com/apache/cloudstack/pull/4032#issuecomment-767046339 > @ggoodrich-ipp what issue does this pr solve ? > Delete a vm snapshot twice ? Well, I think another PR managed to get in there to suspend the VM, but this PR is specifically around suspending, then resuming the VM when doing a snapshot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4479: python3 and nose2 first step
DaanHoogland commented on pull request #4479: URL: https://github.com/apache/cloudstack/pull/4479#issuecomment-766720366 nose2 change will not be implemented This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4534: Migrate vm across clusters
shwstppr commented on pull request #4534: URL: https://github.com/apache/cloudstack/pull/4534#issuecomment-766694809 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4576: Fix: Use Q35 chipset for UEFI x86_64
blueorangutan commented on pull request #4576: URL: https://github.com/apache/cloudstack/pull/4576#issuecomment-766685051 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #4479: python3 and nose2 first step
DaanHoogland closed pull request #4479: URL: https://github.com/apache/cloudstack/pull/4479 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4602: server: keep networks order and ips while move a vm with multiple networks
shwstppr commented on pull request #4602: URL: https://github.com/apache/cloudstack/pull/4602#issuecomment-766731702 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4610: [UI] Cannot remove tags on host and primary storage
rhtyd commented on issue #4610: URL: https://github.com/apache/cloudstack/issues/4610#issuecomment-766590973 Fixed in https://github.com/apache/cloudstack/pull/4611, can you test latest 4.15 and close @slavkap This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
rhtyd commented on pull request #4605: URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-766589948 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4601: server: Get vm network/disk statistics and update database per host
blueorangutan commented on pull request #4601: URL: https://github.com/apache/cloudstack/pull/4601#issuecomment-766732816 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4614: vmsnapshot: Add quickview to the list of VM Snapshot
rhtyd closed pull request #4614: URL: https://github.com/apache/cloudstack/pull/4614 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4562: Prevent KVM from performing volume migrations of running instances
DaanHoogland commented on pull request #4562: URL: https://github.com/apache/cloudstack/pull/4562#issuecomment-766756509 @weizhouapache @shwstppr @GutoVeronezi @rhtyd I am always for merging in the oldest applicable branch first. If we want this in those branches we should rebase it first (imnsho). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4582: Upgrade: check systemvm template before db changes
blueorangutan commented on pull request #4582: URL: https://github.com/apache/cloudstack/pull/4582#issuecomment-766684474 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] mib1185 edited a comment on pull request #4574: db-schema update 4.15.0 to 4.15.1: correct some guest-os namings
mib1185 edited a comment on pull request #4574: URL: https://github.com/apache/cloudstack/pull/4574#issuecomment-766715842 @shwstppr conflicts are resolved and rebase to current `master` is done, or do you mean, i should set this PR again branch `4.15` instead of `master` ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4591: server: select root disk based on user input during vm import
blueorangutan removed a comment on pull request #4591: URL: https://github.com/apache/cloudstack/pull/4591#issuecomment-762246078 @DK101010 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4601: server: Get vm network/disk statistics and update database per host
weizhouapache commented on a change in pull request #4601:
URL: https://github.com/apache/cloudstack/pull/4601#discussion_r563773324
##
File path: server/src/main/java/com/cloud/server/StatsCollector.java
##
@@ -684,18 +684,17 @@ protected void runInContext() {
return;
}
// collect the vm disk statistics(total) from hypervisor. added by
weizhou, 2013.03.
-s_logger.trace("Running VM disk stats ...");
-try {
-Transaction.execute(new TransactionCallbackNoReturn() {
-@Override
-public void doInTransactionWithoutResult(TransactionStatus
status) {
-s_logger.debug("VmDiskStatsTask is running...");
+s_logger.debug("VmDiskStatsTask is running...");
Review comment:
@DaanHoogland the message and level are not changed. moved out from try
block.
Removed the line which is not needed as we have debug message.
`s_logger.trace("Running VM disk stats ...");`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4576: Fix: Use Q35 chipset for UEFI x86_64
shwstppr commented on pull request #4576: URL: https://github.com/apache/cloudstack/pull/4576#issuecomment-766684773 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4616: Add logs to api removeVpnUser
weizhouapache commented on pull request #4616: URL: https://github.com/apache/cloudstack/pull/4616#issuecomment-767026936 I am more interested the reason and the fix. do you have clue ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4362: Match template tags with host tag for vm deployment
shwstppr commented on pull request #4362: URL: https://github.com/apache/cloudstack/pull/4362#issuecomment-766726421 @ravening Needs conflicts to be resolved. Moving to 4.16.0.0 milestone based on base branch please update if needed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4614: vmsnapshot: Add quickview to the list of VM Snapshot
blueorangutan commented on pull request #4614: URL: https://github.com/apache/cloudstack/pull/4614#issuecomment-766773406 UI build: :heavy_check_mark Live QA URL: http://primate-qa.cloudstack.cloud:8080/client/pr/4614 (JID-3828) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4329: Adding AutoScaling for cks + CKS CoreOS EOL update
Pearl1594 commented on pull request #4329: URL: https://github.com/apache/cloudstack/pull/4329#issuecomment-766596849 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4329: Adding AutoScaling for cks + CKS CoreOS EOL update
weizhouapache commented on a change in pull request #4329:
URL: https://github.com/apache/cloudstack/pull/4329#discussion_r563556732
##
File path: tools/appliance/systemvmtemplate/scripts/install_systemvm_packages.sh
##
@@ -70,20 +76,33 @@ function install_packages() {
radvd \
sharutils genisoimage aria2 \
strongswan libcharon-extra-plugins libstrongswan-extra-plugins
strongswan-charon strongswan-starter \
-virt-what open-vm-tools qemu-guest-agent hyperv-daemons
+virt-what open-vm-tools qemu-guest-agent hyperv-daemons cloud-guest-utils \
+apt-transport-https ca-certificates curl gnupg gnupg-agent
software-properties-common cloud-init
apt-get -y autoremove --purge
apt-get clean
apt-get autoclean
+ apt_clean
${apt_get} install links
+ curl -fsSL https://download.docker.com/linux/debian/gpg | sudo apt-key add -
+ apt-key fingerprint 0EBFCD88
+
#32 bit architecture support for vhd-util: not required for 32 bit template
if [ "${arch}" != "i386" ]; then
dpkg --add-architecture i386
apt-get update
${apt_get} install libuuid1:i386 libc6:i386
+
+add-apt-repository \
+"deb [arch=amd64] https://download.docker.com/linux/debian \
+$(lsb_release -cs) \
+stable"
+apt-get update
+${apt_get} install docker-ce docker-ce-cli containerd.io
Review comment:
@davidjumani
we do not need docker installed in systemvm template.
it would be better to create separated folder in tools/appliance/
##
File path: tools/appliance/systemvmtemplate/scripts/install_systemvm_packages.sh
##
@@ -70,20 +76,33 @@ function install_packages() {
radvd \
sharutils genisoimage aria2 \
strongswan libcharon-extra-plugins libstrongswan-extra-plugins
strongswan-charon strongswan-starter \
-virt-what open-vm-tools qemu-guest-agent hyperv-daemons
+virt-what open-vm-tools qemu-guest-agent hyperv-daemons cloud-guest-utils \
+apt-transport-https ca-certificates curl gnupg gnupg-agent
software-properties-common cloud-init
apt-get -y autoremove --purge
apt-get clean
apt-get autoclean
+ apt_clean
${apt_get} install links
+ curl -fsSL https://download.docker.com/linux/debian/gpg | sudo apt-key add -
+ apt-key fingerprint 0EBFCD88
+
#32 bit architecture support for vhd-util: not required for 32 bit template
if [ "${arch}" != "i386" ]; then
dpkg --add-architecture i386
apt-get update
${apt_get} install libuuid1:i386 libc6:i386
+
+add-apt-repository \
+"deb [arch=amd64] https://download.docker.com/linux/debian \
+$(lsb_release -cs) \
+stable"
+apt-get update
+${apt_get} install docker-ce docker-ce-cli containerd.io
Review comment:
@Pearl1594
we could have different template for cks. debian9 is one of an options for
cks template. if cloudstack users want to have centos8 or ubuntu 2004 as cks
template,we could build them as well.
we can create separated folder in tools/appliance/, like
cks-template-debian10, cks-template-centos8, etc
if we use same template on VR and cks, and we need to make more changes in
the template, it will impact the systemvm and vrs as well. cloudstack systemvm
template is quite stable now. do not touch it if possible.
in addition, some packages in systemvm template are not needed for cks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4601: server: Get vm network/disk statistics and update database per host
shwstppr commented on pull request #4601: URL: https://github.com/apache/cloudstack/pull/4601#issuecomment-766732578 @ustcweizhou do you plan to address above comments? @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4591: server: select root disk based on user input during vm import
blueorangutan commented on pull request #4591: URL: https://github.com/apache/cloudstack/pull/4591#issuecomment-766709960 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #4613: Cannot remove Secondary storage after using new feature "migration of secondary storage"
DaanHoogland commented on issue #4613: URL: https://github.com/apache/cloudstack/issues/4613#issuecomment-766624907 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages
blueorangutan commented on pull request #4605: URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-766590395 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4574: db-schema update 4.15.0 to 4.15.1: correct some guest-os namings
weizhouapache commented on pull request #4574: URL: https://github.com/apache/cloudstack/pull/4574#issuecomment-766865506 @mib1185 this pr lgtm one question, there are two "SCO OpenServer 5" (ids are 85 and 324). do you know the difference and plan to change one of them as well ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4602: server: keep networks order and ips while move a vm with multiple networks
blueorangutan commented on pull request #4602: URL: https://github.com/apache/cloudstack/pull/4602#issuecomment-766732296 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4543: marvin and tests python 2to3
DaanHoogland commented on pull request #4543: URL: https://github.com/apache/cloudstack/pull/4543#issuecomment-766833532 packaging and install on centos7 succesfull in trillian @rhtyd . I will look at the travis run next. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #4149: set python explicit during transistion
DaanHoogland closed pull request #4149: URL: https://github.com/apache/cloudstack/pull/4149 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4422: Count resources of virtual routers cpu/memory
shwstppr commented on pull request #4422: URL: https://github.com/apache/cloudstack/pull/4422#issuecomment-766726144 @ravening Moving to 4.16.0.0 milestone based on base branch please update if needed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4609: API discovery: Prevent overwrite of API parameters in cases where API names are same
rhtyd commented on pull request #4609: URL: https://github.com/apache/cloudstack/pull/4609#issuecomment-766598435 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4600: server: fix cannot create vm if another vm with same name has been added and removed on the network
blueorangutan commented on pull request #4600: URL: https://github.com/apache/cloudstack/pull/4600#issuecomment-766621269 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #3868: Nested Virtualisation for hyper-v on kvm
DaanHoogland commented on issue #3868: URL: https://github.com/apache/cloudstack/issues/3868#issuecomment-766696059 @svouland is this still an issue for you with the latest version? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #4615: Secondary storage: Allow store deletion after successful data migration
shwstppr commented on a change in pull request #4615:
URL: https://github.com/apache/cloudstack/pull/4615#discussion_r563569469
##
File path: server/src/main/java/com/cloud/api/query/dao/TemplateJoinDaoImpl.java
##
@@ -522,6 +522,7 @@ public TemplateResponse newIsoResponse(TemplateJoinVO iso) {
sc.setParameters("store_id", storeId);
sc.setParameters("type", TemplateType.USER);
sc.setParameters("templateState", VirtualMachineTemplate.State.Active);
+sc.setParameters("public", Boolean.FALSE);
Review comment:
@Pearl1594 why this change is needed?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #4582: Upgrade: check systemvm template before db changes
weizhouapache closed pull request #4582: URL: https://github.com/apache/cloudstack/pull/4582 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #4611: UI Storage Pool Tags: unable to delete last tag
harikrishna-patnala commented on a change in pull request #4611:
URL: https://github.com/apache/cloudstack/pull/4611#discussion_r563441872
##
File path: ui/src/views/AutogenView.vue
##
@@ -957,7 +957,8 @@ export default {
if (param.name !== key) {
continue
}
-if (input === undefined || input === null || input === '') {
+if (input === undefined || input === null || (input === '' &&
+ !['updateStoragePool', 'updateHost'].includes(action.api))) {
Review comment:
@Pearl1594 we have physical networks tags also, I just checked we could
not delete the tag on physical network too, can you please add that here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] utchoang closed pull request #4608: vmsnapshot: Add quickview to the list of VM Snapshot
utchoang closed pull request #4608: URL: https://github.com/apache/cloudstack/pull/4608 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
blueorangutan commented on pull request #4615: URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-766527492 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4604: api: add zone, vm name params in listVmSnapshot response
harikrishna-patnala commented on pull request #4604: URL: https://github.com/apache/cloudstack/pull/4604#issuecomment-766519108 > @shwstppr May be some generic approach for the API response objects, to tag both UUID and Name (wherever UUID is returned) might work for all the APIs, and the names can be used appropriately in the UI when required. @sureshanaparti I get your proposal, but that I think it needs significant amount of changes as Name is not part of common interfaces (which I think is required for a generic approach) and it is defined as different names for each resource. May be an another improvement ticket would help this PR to get continued ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4615: Secondary storage: Allow store deletion after successful data migration
Pearl1594 commented on pull request #4615: URL: https://github.com/apache/cloudstack/pull/4615#issuecomment-766527323 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #4608: vmsnapshot: Add quickview to the list of VM Snapshot
utchoang commented on pull request #4608: URL: https://github.com/apache/cloudstack/pull/4608#issuecomment-766473573 Closed to open a new PR with 4.15.0 branch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] utchoang commented on a change in pull request #4611: UI Storage Pool Tags: unable to delete last tag
utchoang commented on a change in pull request #4611:
URL: https://github.com/apache/cloudstack/pull/4611#discussion_r563460413
##
File path: ui/src/views/AutogenView.vue
##
@@ -957,7 +957,8 @@ export default {
if (param.name !== key) {
continue
}
-if (input === undefined || input === null || input === '') {
+if (input === undefined || input === null || (input === '' &&
Review comment:
@Pearl1594 In my opinion it will be cleaner like this
`if (!input || (input === '' && !['updateStoragePool',
'updateHost'].includes(action.api)))` {
##
File path: ui/src/views/AutogenView.vue
##
@@ -957,7 +957,8 @@ export default {
if (param.name !== key) {
continue
}
-if (input === undefined || input === null || input === '') {
+if (input === undefined || input === null || (input === '' &&
Review comment:
I understood! Thanks @Pearl1594
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4543: marvin and tests python 2to3
blueorangutan commented on pull request #4543: URL: https://github.com/apache/cloudstack/pull/4543#issuecomment-766436356 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4543: marvin and tests python 2to3
blueorangutan removed a comment on pull request #4543: URL: https://github.com/apache/cloudstack/pull/4543#issuecomment-765375351 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #4590: Customized HostnameVerifier bypasses the hostname verification
DaanHoogland commented on issue #4590: URL: https://github.com/apache/cloudstack/issues/4590#issuecomment-766413211 @AthenaXiao this is a community driven project, people that experience problems try to get solutions merged. Static analysis has been showing us bad coding practices but without shown exploit no action will be taken. Usually it turns out we are talking about dead code or code that is isolated and unexposed. As this is an integration system, a lot of support for external systems gets implemented and sometimes not phased out in a timely fashion. We get reports like this from time to time and usualy as a result, but seldom do we feel there is a thread serious enough to take action. As said without exploit nobody will be interested to take action. As for potential attack planes, these are the API en the VR/dnmasq/iptables of routers and other system VMs. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4491: fix on changeServiceForVirtualMachine when updating read/write rate
blueorangutan commented on pull request #4491: URL: https://github.com/apache/cloudstack/pull/4491#issuecomment-767119637 Trillian test result (tid-3410) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39374 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4491-t3410-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py Smoke tests completed. 82 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 234.29 | test_kubernetes_clusters.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
