[GitHub] [cloudstack] blueorangutan commented on pull request #4626: server: fix failed to remove template/iso if upload from local fails

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4626:
URL: https://github.com/apache/cloudstack/pull/4626#issuecomment-769620557


   @shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been 
kicked to run smoke tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] shwstppr commented on pull request #4626: server: fix failed to remove template/iso if upload from local fails

2021-01-28 Thread GitBox


shwstppr commented on pull request #4626:
URL: https://github.com/apache/cloudstack/pull/4626#issuecomment-769620026


   @blueorangutan test centos7 vmware-67u3



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] shwstppr commented on pull request #4626: server: fix failed to remove template/iso if upload from local fails

2021-01-28 Thread GitBox


shwstppr commented on pull request #4626:
URL: https://github.com/apache/cloudstack/pull/4626#issuecomment-769619620


   @blueorangutan test centos7 vmware-67u3



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] shwstppr removed a comment on pull request #4626: server: fix failed to remove template/iso if upload from local fails

2021-01-28 Thread GitBox


shwstppr removed a comment on pull request #4626:
URL: https://github.com/apache/cloudstack/pull/4626#issuecomment-769619620


   @blueorangutan test centos7 vmware-67u3



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4624: server: fix wrong error message when create isolated network without SourceNat

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4624:
URL: https://github.com/apache/cloudstack/pull/4624#issuecomment-769619259


   @shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] shwstppr commented on pull request #4624: server: fix wrong error message when create isolated network without SourceNat

2021-01-28 Thread GitBox


shwstppr commented on pull request #4624:
URL: https://github.com/apache/cloudstack/pull/4624#issuecomment-769618682


   @blueorangutan test



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4629: server: prevent update vm read-only details

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629#issuecomment-769610660


   Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2619



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4629: server: prevent update vm read-only details

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629#issuecomment-769600624


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4629: server: prevent update vm read-only details

2021-01-28 Thread GitBox


blueorangutan removed a comment on pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629#issuecomment-768929809


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] shwstppr commented on pull request #4629: server: prevent update vm read-only details

2021-01-28 Thread GitBox


shwstppr commented on pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629#issuecomment-769600218


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] shwstppr removed a comment on pull request #4629: server: prevent update vm read-only details

2021-01-28 Thread GitBox


shwstppr removed a comment on pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629#issuecomment-768929070


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4150:
URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-769591512


   Trillian test result (tid-3450)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 43103 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4150-t3450-kvm-centos7.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 82 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 3608.18 | 
test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.10 | 
test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.09 | 
test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 95.64 | 
test_kubernetes_clusters.py
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4150:
URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-769590516


   Trillian test result (tid-3451)
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 43395 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4150-t3451-vmware-65u2.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Smoke tests completed. 80 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_change_offering_small | `Error` | 6.20 | test_service_offerings.py
   test_02_create_template_with_checksum_sha1 | `Error` | 5.15 | 
test_templates.py
   test_03_create_template_with_checksum_sha256 | `Error` | 5.11 | 
test_templates.py
   test_04_create_template_with_checksum_md5 | `Error` | 5.11 | 
test_templates.py
   test_change_service_offering_for_vm_with_snapshots | `Error` | 138.29 | 
test_vm_snapshots.py
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4150:
URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-769575090


   Trillian test result (tid-3449)
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 40248 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4150-t3449-xenserver-71.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 82 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_scale_vm | `Failure` | 10.40 | test_scale_vm.py
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4567: Qemu 2.10 requires `-U` flag to read volume metadata

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4567:
URL: https://github.com/apache/cloudstack/pull/4567#issuecomment-769574642


   Trillian test result (tid-3448)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 42227 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4567-t3448-kvm-centos7.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Smoke tests completed. 84 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_deploy_kubernetes_cluster | `Failure` | 3624.07 | 
test_kubernetes_clusters.py
   test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 22.51 | 
test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 26.61 | 
test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | 
test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | 
test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 78.68 | 
test_kubernetes_clusters.py
   test_04_rvpc_privategw_static_routes | `Failure` | 868.50 | 
test_privategw_acl.py
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4581: Restore VMware VM naming convention option

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4581:
URL: https://github.com/apache/cloudstack/pull/4581#issuecomment-769529458


   Trillian test result (tid-3446)
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 50380 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4581-t3446-vmware-65u2.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 84 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 783.42 | 
test_kubernetes_clusters.py
   test_02_redundant_VPC_default_routes | `Failure` | 269.74 | 
test_vpc_redundant.py
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4581: Restore VMware VM naming convention option

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4581:
URL: https://github.com/apache/cloudstack/pull/4581#issuecomment-769471660


   Trillian test result (tid-3445)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 40556 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4581-t3445-kvm-centos7.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_kubernetes_clusters.py
   Smoke tests completed. 86 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] stedeux commented on issue #4593: list hosts

2021-01-28 Thread GitBox


stedeux commented on issue #4593:
URL: https://github.com/apache/cloudstack/issues/4593#issuecomment-769466310


   > 
   > 
   > @stedeux
   > if you use 4.15.0.0, could you retry after updating global config 
"add.host.on.service.restart.kvm" to "false" ?
   > it is added in #4228
   
   Ok it's work



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] stedeux commented on issue #4593: list hosts

2021-01-28 Thread GitBox


stedeux commented on issue #4593:
URL: https://github.com/apache/cloudstack/issues/4593#issuecomment-769466388


   thank



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] stedeux closed issue #4593: list hosts

2021-01-28 Thread GitBox


stedeux closed issue #4593:
URL: https://github.com/apache/cloudstack/issues/4593


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4581: Restore VMware VM naming convention option

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4581:
URL: https://github.com/apache/cloudstack/pull/4581#issuecomment-769451911


   Trillian test result (tid-3444)
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 37667 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4581-t3444-xenserver-71.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
   Smoke tests completed. 85 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_scale_vm | `Failure` | 11.31 | test_scale_vm.py
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4625: server: throw exception when update vm nic on L2 network

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4625:
URL: https://github.com/apache/cloudstack/pull/4625#issuecomment-769253421


   Trillian test result (tid-3442)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 32395 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4625-t3442-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 83 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] ggoodrich-ipp commented on pull request #3915: Incorporate VR OOB start checks to properly HA the VR

2021-01-28 Thread GitBox


ggoodrich-ipp commented on pull request #3915:
URL: https://github.com/apache/cloudstack/pull/3915#issuecomment-769253272


   > @DaanHoogland starting VR OOB looks not like a normal behavior
   
   @weizhouapache We aren't starting it OOB, we are just running checks when it 
is believed that the VR was started OOB.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] ggoodrich-ipp commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

2021-01-28 Thread GitBox


ggoodrich-ipp commented on pull request #4137:
URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-769249447


   > @ggoodrich-ipp
   > thanks for pr.
   > could you fix the conflicts and make primate ui change ?
   
   Should this be re-targeted to either 4.15 or 4.16 @DaanHoogland @rhtyd, I 
know the conflicts won't be resolved in master, due to the recent UI 
deprecation/switch to primate. We will be working towards getting these 
elements into a PR for primate soon, but it may be easier to include that in a 
separate PR. Thoughts?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] ggoodrich-ipp commented on pull request #4032: Suspending the VM prior to deleting snapshots to avoid corruption, th…

2021-01-28 Thread GitBox


ggoodrich-ipp commented on pull request #4032:
URL: https://github.com/apache/cloudstack/pull/4032#issuecomment-769247937


   I see @DaanHoogland re-targeted this to 4.15, which must have resolved the 
conflicts. Are there any other issues with this PR that need to be addressed 
prior to approval, @weizhouapache @shwstppr ? Let me know, and I'll try to 
accommodate. Thanks!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4150:
URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-769240790


   @rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + 
vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4150: [HEALTH][4.14] Health Check Run

2021-01-28 Thread GitBox


rhtyd commented on pull request #4150:
URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-769239873


   @blueorangutan test matrix 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4622: server: add possibility to scale vm to current custom offerings on UI

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4622:
URL: https://github.com/apache/cloudstack/pull/4622#issuecomment-769217213


   Trillian test result (tid-3443)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 29266 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4622-t3443-kvm-centos7.zip
   Smoke tests completed. 83 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4567: Qemu 2.10 requires `-U` flag to read volume metadata

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4567:
URL: https://github.com/apache/cloudstack/pull/4567#issuecomment-769216926


   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] DaanHoogland commented on pull request #4567: Qemu 2.10 requires `-U` flag to read volume metadata

2021-01-28 Thread GitBox


DaanHoogland commented on pull request #4567:
URL: https://github.com/apache/cloudstack/pull/4567#issuecomment-769215948


   @blueorangutan test



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4150:
URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-769085988


   Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2618



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4150:
URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-769068478


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] shwstppr commented on pull request #4150: [HEALTH][4.14] Health Check Run

2021-01-28 Thread GitBox


shwstppr commented on pull request #4150:
URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-769067412


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4567: Qemu 2.10 requires `-U` flag to read volume metadata

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4567:
URL: https://github.com/apache/cloudstack/pull/4567#issuecomment-769036189


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2617



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] DK101010 commented on pull request #4591: server: select root disk based on user input during vm import

2021-01-28 Thread GitBox


DK101010 commented on pull request #4591:
URL: https://github.com/apache/cloudstack/pull/4591#issuecomment-769031737


   @shwstppr I've tested it in our environment and it works perfectly. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] DaanHoogland commented on issue #4238: uefi vm creation fail

2021-01-28 Thread GitBox


DaanHoogland commented on issue #4238:
URL: https://github.com/apache/cloudstack/issues/4238#issuecomment-769023193


   @gaaray2k can you test this with 4.15, please?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] DaanHoogland commented on issue #4229: Creating a network offering

2021-01-28 Thread GitBox


DaanHoogland commented on issue #4229:
URL: https://github.com/apache/cloudstack/issues/4229#issuecomment-769019601


   @gaaray2k did you solve your issue? (as in can we close this?)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] DaanHoogland commented on issue #4203: VM pass not getting reset

2021-01-28 Thread GitBox


DaanHoogland commented on issue #4203:
URL: https://github.com/apache/cloudstack/issues/4203#issuecomment-769018980


   @gaaray2k is the VM based on a tamplate that contains (the right version of) 
cloud_init?
   This is not a known issue but please add some explanation of the screenshots 
in your description. also please recheck with the latest versions to see if it 
still a problem.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4567: Qemu 2.10 requires `-U` flag to read volume metadata

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4567:
URL: https://github.com/apache/cloudstack/pull/4567#issuecomment-769015026


   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] DaanHoogland commented on pull request #4567: Qemu 2.10 requires `-U` flag to read volume metadata

2021-01-28 Thread GitBox


DaanHoogland commented on pull request #4567:
URL: https://github.com/apache/cloudstack/pull/4567#issuecomment-769014720


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4561: [WIP] Support for persistence mode in L2 networks

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4561:
URL: https://github.com/apache/cloudstack/pull/4561#issuecomment-769012420


   @Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




Jenkins build is back to normal : Cloudstack » cloudstack-apidocs-master #130

2021-01-28 Thread Apache Jenkins Server
See 




[GitHub] [cloudstack] Pearl1594 commented on pull request #4561: [WIP] Support for persistence mode in L2 networks

2021-01-28 Thread GitBox


Pearl1594 commented on pull request #4561:
URL: https://github.com/apache/cloudstack/pull/4561#issuecomment-769012098


   @blueorangutan test



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4561: [WIP] Support for persistence mode in L2 networks

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4561:
URL: https://github.com/apache/cloudstack/pull/4561#issuecomment-769011850


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2616



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4581: Restore VMware VM naming convention option

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4581:
URL: https://github.com/apache/cloudstack/pull/4581#issuecomment-769004306


   @shwstppr a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + 
vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] shwstppr commented on pull request #4581: Restore VMware VM naming convention option

2021-01-28 Thread GitBox


shwstppr commented on pull request #4581:
URL: https://github.com/apache/cloudstack/pull/4581#issuecomment-769003730


   @blueorangutan test matrix



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4561: [WIP] Support for persistence mode in L2 networks

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4561:
URL: https://github.com/apache/cloudstack/pull/4561#issuecomment-768992471


   @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] Pearl1594 commented on pull request #4561: [WIP] Support for persistence mode in L2 networks

2021-01-28 Thread GitBox


Pearl1594 commented on pull request #4561:
URL: https://github.com/apache/cloudstack/pull/4561#issuecomment-768992094


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[cloudstack] branch master updated (3a4a82d -> be5e61a)

2021-01-28 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 3a4a82d  kvm: Replicate `rootDiskController` behavior to 
`dataDiskController`. (#4569)
 add 1bccb95  Fix merge issue from 74bae56642b224e9ccf54bf6ad3dd73b4cf13f41
 add be5e61a  Merge remote-tracking branch 'origin/4.15'

No new revisions were added by this update.

Summary of changes:
 server/src/main/java/com/cloud/vm/UserVmManagerImpl.java | 13 +
 1 file changed, 13 insertions(+)



[cloudstack] branch 4.15 updated: Fix merge issue from 74bae56642b224e9ccf54bf6ad3dd73b4cf13f41

2021-01-28 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.15
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.15 by this push:
 new 1bccb95  Fix merge issue from 74bae56642b224e9ccf54bf6ad3dd73b4cf13f41
1bccb95 is described below

commit 1bccb954c4999d14949351a6b15f518992c43204
Author: Rohit Yadav 
AuthorDate: Thu Jan 28 16:43:59 2021 +0530

Fix merge issue from 74bae56642b224e9ccf54bf6ad3dd73b4cf13f41

Fixes fwd merge issue from origin/4.14

Signed-off-by: Rohit Yadav 
---
 server/src/main/java/com/cloud/vm/UserVmManagerImpl.java | 13 +
 1 file changed, 13 insertions(+)

diff --git a/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java 
b/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
index fcf7008..cc31eac 100644
--- a/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
+++ b/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
@@ -1261,6 +1261,19 @@ public class UserVmManagerImpl extends ManagerBase 
implements UserVmManager, Vir
 return resizeVolumeCmd;
 }
 
+private void resizeRootVolumeOfVmWithNewOffering(VMInstanceVO vmInstance, 
ServiceOfferingVO newServiceOffering)
+throws ResourceAllocationException {
+DiskOfferingVO newROOTDiskOffering = 
_diskOfferingDao.findById(newServiceOffering.getId());
+List vols = 
_volsDao.findReadyRootVolumesByInstance(vmInstance.getId());
+
+for (final VolumeVO rootVolumeOfVm : vols) {
+rootVolumeOfVm.setDiskOfferingId(newROOTDiskOffering.getId());
+ResizeVolumeCmd resizeVolumeCmd = new 
ResizeVolumeCmd(rootVolumeOfVm.getId(), newROOTDiskOffering.getMinIops(), 
newROOTDiskOffering.getMaxIops());
+_volumeService.resizeVolume(resizeVolumeCmd);
+_volsDao.update(rootVolumeOfVm.getId(), rootVolumeOfVm);
+}
+}
+
 @Override
 @ActionEvent(eventType = EventTypes.EVENT_NIC_CREATE, eventDescription = 
"Creating Nic", async = true)
 public UserVm addNicToVirtualMachine(AddNicToVMCmd cmd) throws 
InvalidParameterValueException, PermissionDeniedException, 
CloudRuntimeException {



Build failed in Jenkins: Cloudstack » cloudstack-apidocs-master #129

2021-01-28 Thread Apache Jenkins Server
See 


Changes:

[github] kvm: Replicate `rootDiskController` behavior to `dataDiskController`. 
(#4569)


--
[...truncated 430.40 KB...]
at hudson.model.FingerprintMap.get(FingerprintMap.java:82)
at hudson.model.FingerprintMap.get(FingerprintMap.java:47)
at hudson.util.KeyedDataStorage.getOrCreate(KeyedDataStorage.java:111)
at hudson.model.FingerprintMap.getOrCreate(FingerprintMap.java:68)
at 
hudson.maven.reporters.MavenFingerprinter$PostBuildCallable.call(MavenFingerprinter.java:249)
at 
hudson.maven.reporters.MavenFingerprinter$PostBuildCallable.call(MavenFingerprinter.java:236)
at hudson.maven.MavenBuild$ProxyImpl.execute(MavenBuild.java:454)
at hudson.maven.MavenBuild$ProxyImpl2.execute(MavenBuild.java:586)
at sun.reflect.GeneratedMethodAccessor933.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at hudson.model.Executor$2.call(Executor.java:932)
at hudson.util.InterceptingProxy$1.invoke(InterceptingProxy.java:23)
at com.sun.proxy.$Proxy188.execute(Unknown Source)
at 
hudson.maven.MavenBuildProxy$Filter$AsyncInvoker.call(MavenBuildProxy.java:294)
at hudson.remoting.UserRequest.perform(UserRequest.java:211)
at hudson.remoting.UserRequest.perform(UserRequest.java:54)
at hudson.remoting.Request$2.run(Request.java:369)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at 
org.jenkinsci.remoting.CallableDecorator.call(CallableDecorator.java:18)
at 
hudson.remoting.CallableDecoratorList$1.call(CallableDecoratorList.java:21)
at 
jenkins.util.ContextResettingExecutorService$2.call(ContextResettingExecutorService.java:46)
at 
jenkins.security.ImpersonatingExecutorService$2.call(ImpersonatingExecutorService.java:71)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to 
channel
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1788)
at 
hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)
at hudson.remoting.Channel$2.adapt(Channel.java:1033)
at hudson.remoting.Channel$2.adapt(Channel.java:1029)
at hudson.remoting.FutureAdapter.get(FutureAdapter.java:55)
at 
hudson.maven.AbstractMavenBuilder.waitForAsynchronousExecutions(AbstractMavenBuilder.java:186)
at hudson.maven.Maven3Builder.call(Maven3Builder.java:146)
at hudson.maven.Maven3Builder.call(Maven3Builder.java:70)
at hudson.remoting.UserRequest.perform(UserRequest.java:211)
at hudson.remoting.UserRequest.perform(UserRequest.java:54)
at hudson.remoting.Request$2.run(Request.java:369)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at 
java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at 
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at 
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)
ERROR: Asynchronous execution failure
java.util.concurrent.ExecutionException: java.io.IOException: Unexpected 
Fingerprint type. Expected class hudson.model.Fingerprint or subclass but got 
class hudson.model.Fingerprint$RangeSet
at hudson.remoting.Channel$2.adapt(Channel.java:1035)
at hudson.remoting.Channel$2.adapt(Channel.java:1029)
at hudson.remoting.FutureAdapter.get(FutureAdapter.java:55)
at 
hudson.maven.AbstractMavenBuilder.waitForAsynchronousExecutions(AbstractMavenBuilder.java:186)
at hudson.maven.Maven3Builder.call(Maven3Builder.java:146)
at hudson.maven.Maven3Builder.call(Maven3Builder.java:70)
at hudson.remoting.UserRequest.perform(UserRequest.java:211)
at hudson.remoting.UserRequest.perform(UserRequest.java:54)
at hudson.remoting.Request$2.run(Request.java:369)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at 

[GitHub] [cloudstack] blueorangutan commented on pull request #4567: Qemu 2.10 requires `-U` flag to read volume metadata

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4567:
URL: https://github.com/apache/cloudstack/pull/4567#issuecomment-768964256


   Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2615



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] DaanHoogland commented on issue #4201: VM snapshot deletion failure may put it indefinitely in expunging state

2021-01-28 Thread GitBox


DaanHoogland commented on issue #4201:
URL: https://github.com/apache/cloudstack/issues/4201#issuecomment-768964138


   the statemachine `VMSnapshot.s_fsm`, the transition 
`s_fsm.addTransition(Expunging, Event.OperationSucceeded, Removed)` is never 
executed for this to happen (or an exception occurs).
   `DefaultVMSnapshotStrategy.processAnswer(final VMSnapshotVO vmSnapshot, 
UserVm userVm, final Answer as, Long hostId)` is were is probably should happen.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4567: Qemu 2.10 requires `-U` flag to read volume metadata

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4567:
URL: https://github.com/apache/cloudstack/pull/4567#issuecomment-768956928


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4567: Qemu 2.10 requires `-U` flag to read volume metadata

2021-01-28 Thread GitBox


rhtyd commented on pull request #4567:
URL: https://github.com/apache/cloudstack/pull/4567#issuecomment-768956216


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[cloudstack] branch master updated (f989409 -> 3a4a82d)

2021-01-28 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from f989409  Merge remote-tracking branch 'origin/4.15'
 add 3a4a82d  kvm: Replicate `rootDiskController` behavior to 
`dataDiskController`. (#4569)

No new revisions were added by this update.

Summary of changes:
 .../kvm/resource/LibvirtComputingResource.java | 34 +-
 1 file changed, 27 insertions(+), 7 deletions(-)



[GitHub] [cloudstack] rhtyd merged pull request #4569: Replicate `rootDiskController` behavior to `dataDiskController`.

2021-01-28 Thread GitBox


rhtyd merged pull request #4569:
URL: https://github.com/apache/cloudstack/pull/4569


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4561: [WIP] Support for persistence mode in L2 networks

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4561:
URL: https://github.com/apache/cloudstack/pull/4561#issuecomment-768953154


   Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2614



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4629: server: prevent update vm read-only details

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629#issuecomment-768953153


   Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2613



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] DaanHoogland commented on issue #4628: Fail to create template from Volumes after upgrade 4.15

2021-01-28 Thread GitBox


DaanHoogland commented on issue #4628:
URL: https://github.com/apache/cloudstack/issues/4628#issuecomment-768943297


   double checked and they are supposed to be not nullable. no idea why this is 
happening, yet.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4561: [WIP] Support for persistence mode in L2 networks

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4561:
URL: https://github.com/apache/cloudstack/pull/4561#issuecomment-768935951


   @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] Pearl1594 commented on pull request #4561: [WIP] Support for persistence mode in L2 networks

2021-01-28 Thread GitBox


Pearl1594 commented on pull request #4561:
URL: https://github.com/apache/cloudstack/pull/4561#issuecomment-768935204


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4561: [WIP] Support for persistence mode in L2 networks

2021-01-28 Thread GitBox


Pearl1594 commented on a change in pull request #4561:
URL: https://github.com/apache/cloudstack/pull/4561#discussion_r565956650



##
File path: 
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCleanupPersistentNetworkResourceCommandWrapper.java
##
@@ -0,0 +1,44 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package com.cloud.hypervisor.kvm.resource.wrapper;
+
+import org.apache.log4j.Logger;
+
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.CleanupPersistentNetworkResourceAnswer;
+import com.cloud.agent.api.CleanupPersistentNetworkResourceCommand;
+import com.cloud.agent.api.to.NicTO;
+import com.cloud.hypervisor.kvm.resource.BridgeVifDriver;
+import com.cloud.hypervisor.kvm.resource.LibvirtComputingResource;
+import com.cloud.hypervisor.kvm.resource.VifDriver;
+import com.cloud.resource.CommandWrapper;
+import com.cloud.resource.ResourceWrapper;
+
+@ResourceWrapper(handles = CleanupPersistentNetworkResourceCommand.class)
+public class LibvirtCleanupPersistentNetworkResourceCommandWrapper extends 
CommandWrapper {
+private static final Logger s_logger = 
Logger.getLogger(LibvirtCleanupPersistentNetworkResourceCommandWrapper.class);
+@Override
+public Answer execute(CleanupPersistentNetworkResourceCommand command, 
LibvirtComputingResource serverResource) {
+NicTO nic = command.getNicTO();
+VifDriver driver = serverResource.getVifDriver(nic.getType());
+if (driver instanceof BridgeVifDriver) {

Review comment:
   L2 persistence mode hasn't been extended to support it on ovs for KVM





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4561: [WIP] Support for persistence mode in L2 networks

2021-01-28 Thread GitBox


Pearl1594 commented on a change in pull request #4561:
URL: https://github.com/apache/cloudstack/pull/4561#discussion_r565956004



##
File path: 
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
##
@@ -376,6 +376,7 @@ private void deleteVnetBr(String brName) {
 command.add("-v", vNetId);
 command.add("-p", pName);
 command.add("-b", brName);
+command.add("-d", String.valueOf(deleteBr));

Review comment:
   yes @rhtyd 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4561: [WIP] Support for persistence mode in L2 networks

2021-01-28 Thread GitBox


Pearl1594 commented on a change in pull request #4561:
URL: https://github.com/apache/cloudstack/pull/4561#discussion_r565955659



##
File path: 
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##
@@ -1827,6 +1848,63 @@ private void orchestrateStop(final String vmUuid, final 
boolean cleanUpEvenIfUna
 advanceStop(vm, cleanUpEvenIfUnableToStop);
 }
 
+private void getPersistenceMap(Map vlanToPersistenceMap, 
NetworkVO networkVO) {
+NetworkOfferingVO offeringVO = 
networkOfferingDao.findById(networkVO.getNetworkOfferingId());
+if (offeringVO != null) {
+Pair data = getVMNetworkDetails(networkVO, 
offeringVO.isPersistent());
+Boolean shouldDeleteNwResource = 
(MapUtils.isNotEmpty(vlanToPersistenceMap) && data != null) ? 
vlanToPersistenceMap.get(data.first()) : null;
+if (data != null && (shouldDeleteNwResource == null || 
shouldDeleteNwResource)) {
+vlanToPersistenceMap.put(data.first(), data.second());
+}
+}
+}
+
+private Map getVlanToPersistenceMapForVM(long vmId) {
+List userVmJoinVOS = userVmJoinDao.searchByIds(vmId);
+Map vlanToPersistenceMap = new HashMap<>();
+for (UserVmJoinVO userVmJoinVO : userVmJoinVOS) {
+NetworkVO networkVO = 
_networkDao.findById(userVmJoinVO.getNetworkId());
+getPersistenceMap(vlanToPersistenceMap, networkVO);
+}
+if (userVmJoinVOS.isEmpty()) {
+VMInstanceVO vmInstanceVO = _vmDao.findById(vmId);
+if (vmInstanceVO != null && vmInstanceVO.getType() == 
VirtualMachine.Type.DomainRouter) {
+DomainRouterJoinVO routerVO = 
domainRouterJoinDao.findById(vmId);
+NetworkVO networkVO = 
_networkDao.findById(routerVO.getNetworkId());
+getPersistenceMap(vlanToPersistenceMap, networkVO);
+}
+}
+return vlanToPersistenceMap;
+}
+
+/**
+ *
+ * @param networkVO - the network object used to determine the vlanId from 
the broadcast URI
+ * @param isPersistent - indicates if the corresponding network's network 
offering is Persistent
+ *
+ * @return  - basically returns the vlan 
ID which is used to determine the
+ * bridge name for KVM hypervisor and based on the network and isolation 
type and persistent setting of the offering
+ * we decide whether the bridge is to be deleted (KVM) if the last VM in 
that host is destroyed / migrated
+ */
+private Pair getVMNetworkDetails(NetworkVO networkVO, 
boolean isPersistent) {
+URI broadcastUri = networkVO.getBroadcastUri();
+if (broadcastUri != null) {
+String scheme = broadcastUri.getScheme();
+String vlanId = 
Networks.BroadcastDomainType.getValue(broadcastUri);
+boolean shouldDelete = !((networkVO.getGuestType() == 
Network.GuestType.L2 || networkVO.getGuestType() == Network.GuestType.Isolated) 
&&

Review comment:
   L2 persistence mode isn't supported for VxLAN isolation type





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4561: [WIP] Support for persistence mode in L2 networks

2021-01-28 Thread GitBox


Pearl1594 commented on a change in pull request #4561:
URL: https://github.com/apache/cloudstack/pull/4561#discussion_r565955021



##
File path: core/src/main/java/com/cloud/agent/api/StopCommand.java
##
@@ -36,6 +36,7 @@
 String controlIp = null;
 boolean forceStop = false;
 private Map dpdkInterfaceMapping;
+Map vlanToPersistenceMap;

Review comment:
   There's an explicit check done at the consuming end to ensure this isn't 
null





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] ccycv commented on issue #4187: Migration not working in ACS 4.14 with Basic Network - VMware Local storage

2021-01-28 Thread GitBox


ccycv commented on issue #4187:
URL: https://github.com/apache/cloudstack/issues/4187#issuecomment-768932749


   > @ccycv can youtest this with 4.15 please?
   
   After the upgrade I will test asap and let you know.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4629: server: prevent update vm read-only details

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629#issuecomment-768929809


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] shwstppr commented on pull request #4629: server: prevent update vm read-only details

2021-01-28 Thread GitBox


shwstppr commented on pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629#issuecomment-768929070


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] shwstppr opened a new pull request #4629: server: prevent update vm read-only details

2021-01-28 Thread GitBox


shwstppr opened a new pull request #4629:
URL: https://github.com/apache/cloudstack/pull/4629


   ### Description
   Fixes behaviour in updateVirtualMachine API by disallowing updating 
read-only details of the VM for accounts other than root-admin using API. Such 
read-only details will be copied from original values.
   
   Fixes #4514 
   
   
   
   
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   
   
   
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




Build failed in Jenkins: Cloudstack » cloudstack-apidocs-master #128

2021-01-28 Thread Apache Jenkins Server
See 


Changes:

[github] packaging: build and bundle UI using npm in deb and rpm packages 
(#4605)


--
[...truncated 437.62 KB...]
at hudson.model.FingerprintMap.get(FingerprintMap.java:82)
at hudson.model.FingerprintMap.get(FingerprintMap.java:47)
at hudson.util.KeyedDataStorage.getOrCreate(KeyedDataStorage.java:111)
at hudson.model.FingerprintMap.getOrCreate(FingerprintMap.java:68)
at 
hudson.maven.reporters.MavenFingerprinter$PostBuildCallable.call(MavenFingerprinter.java:249)
at 
hudson.maven.reporters.MavenFingerprinter$PostBuildCallable.call(MavenFingerprinter.java:236)
at hudson.maven.MavenBuild$ProxyImpl.execute(MavenBuild.java:454)
at hudson.maven.MavenBuild$ProxyImpl2.execute(MavenBuild.java:586)
at sun.reflect.GeneratedMethodAccessor933.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at hudson.model.Executor$2.call(Executor.java:932)
at hudson.util.InterceptingProxy$1.invoke(InterceptingProxy.java:23)
at com.sun.proxy.$Proxy188.execute(Unknown Source)
at 
hudson.maven.MavenBuildProxy$Filter$AsyncInvoker.call(MavenBuildProxy.java:294)
at hudson.remoting.UserRequest.perform(UserRequest.java:211)
at hudson.remoting.UserRequest.perform(UserRequest.java:54)
at hudson.remoting.Request$2.run(Request.java:369)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at 
org.jenkinsci.remoting.CallableDecorator.call(CallableDecorator.java:18)
at 
hudson.remoting.CallableDecoratorList$1.call(CallableDecoratorList.java:21)
at 
jenkins.util.ContextResettingExecutorService$2.call(ContextResettingExecutorService.java:46)
at 
jenkins.security.ImpersonatingExecutorService$2.call(ImpersonatingExecutorService.java:71)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to 
channel
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1788)
at 
hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)
at hudson.remoting.Channel$2.adapt(Channel.java:1033)
at hudson.remoting.Channel$2.adapt(Channel.java:1029)
at hudson.remoting.FutureAdapter.get(FutureAdapter.java:55)
at 
hudson.maven.AbstractMavenBuilder.waitForAsynchronousExecutions(AbstractMavenBuilder.java:186)
at hudson.maven.Maven3Builder.call(Maven3Builder.java:146)
at hudson.maven.Maven3Builder.call(Maven3Builder.java:70)
at hudson.remoting.UserRequest.perform(UserRequest.java:211)
at hudson.remoting.UserRequest.perform(UserRequest.java:54)
at hudson.remoting.Request$2.run(Request.java:369)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at 
java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at 
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at 
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)
ERROR: Asynchronous execution failure
java.util.concurrent.ExecutionException: java.io.IOException: Unexpected 
Fingerprint type. Expected class hudson.model.Fingerprint or subclass but got 
class hudson.model.Fingerprint$RangeSet
at hudson.remoting.Channel$2.adapt(Channel.java:1035)
at hudson.remoting.Channel$2.adapt(Channel.java:1029)
at hudson.remoting.FutureAdapter.get(FutureAdapter.java:55)
at 
hudson.maven.AbstractMavenBuilder.waitForAsynchronousExecutions(AbstractMavenBuilder.java:186)
at hudson.maven.Maven3Builder.call(Maven3Builder.java:146)
at hudson.maven.Maven3Builder.call(Maven3Builder.java:70)
at hudson.remoting.UserRequest.perform(UserRequest.java:211)
at hudson.remoting.UserRequest.perform(UserRequest.java:54)
at hudson.remoting.Request$2.run(Request.java:369)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at 

[GitHub] [cloudstack] levindecaro commented on issue #4628: Fail to create template from Volumes after upgrade 4.15

2021-01-28 Thread GitBox


levindecaro commented on issue #4628:
URL: https://github.com/apache/cloudstack/issues/4628#issuecomment-768919123


   the original VM has the following option preset, when i try to create a 
template from this VM's Volume, it tried to inject kvm.vnc.address and 
kvm.vnc.port into vm_template_details, however it failed to inject 
kvm.vnc.address with NULL, so i changed the value field to NULLABLE to 
workaround this problem, but not sure it is expected behaviour or due to the 
upgrade.
   
   
   ```
   memoryOvercommitRatio
   1.0
   Message.ReservedCapacityFreed.Flag
   true
   cpuOvercommitRatio
   12
   rootDiskController
   scsi
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




Build failed in Jenkins: Cloudstack » cloudstack-apidocs-master #127

2021-01-28 Thread Apache Jenkins Server
See 


Changes:

[github] ui: Add quickview to the list of VM Snapshot (#4614)

[github] systemvm: Fixed typo (#4621)

[github] server: fix on changeServiceForVirtualMachine when updating read/write 
rate  (#4491)

[github] server: fix cannot create vm if another vm with same name has been 
added and removed on the network (#4600)

[github] ui: Fix screenshot path on README of ui (#4620)


--
[...truncated 404.21 KB...]
at hudson.model.FingerprintMap.load(FingerprintMap.java:47)
at hudson.util.KeyedDataStorage.get(KeyedDataStorage.java:161)
at hudson.model.FingerprintMap.get(FingerprintMap.java:82)
at hudson.model.FingerprintMap.get(FingerprintMap.java:47)
at hudson.util.KeyedDataStorage.getOrCreate(KeyedDataStorage.java:111)
at hudson.model.FingerprintMap.getOrCreate(FingerprintMap.java:68)
at 
hudson.maven.reporters.MavenFingerprinter$PostBuildCallable.call(MavenFingerprinter.java:249)
at 
hudson.maven.reporters.MavenFingerprinter$PostBuildCallable.call(MavenFingerprinter.java:236)
at hudson.maven.MavenBuild$ProxyImpl.execute(MavenBuild.java:454)
at hudson.maven.MavenBuild$ProxyImpl2.execute(MavenBuild.java:586)
at sun.reflect.GeneratedMethodAccessor933.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at hudson.model.Executor$2.call(Executor.java:932)
at hudson.util.InterceptingProxy$1.invoke(InterceptingProxy.java:23)
at com.sun.proxy.$Proxy188.execute(Unknown Source)
at 
hudson.maven.MavenBuildProxy$Filter$AsyncInvoker.call(MavenBuildProxy.java:294)
at hudson.remoting.UserRequest.perform(UserRequest.java:211)
at hudson.remoting.UserRequest.perform(UserRequest.java:54)
at hudson.remoting.Request$2.run(Request.java:369)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at 
org.jenkinsci.remoting.CallableDecorator.call(CallableDecorator.java:18)
at 
hudson.remoting.CallableDecoratorList$1.call(CallableDecoratorList.java:21)
at 
jenkins.util.ContextResettingExecutorService$2.call(ContextResettingExecutorService.java:46)
at 
jenkins.security.ImpersonatingExecutorService$2.call(ImpersonatingExecutorService.java:71)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to 
channel
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1788)
at 
hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)
at hudson.remoting.Channel$2.adapt(Channel.java:1033)
at hudson.remoting.Channel$2.adapt(Channel.java:1029)
at hudson.remoting.FutureAdapter.get(FutureAdapter.java:55)
at 
hudson.maven.AbstractMavenBuilder.waitForAsynchronousExecutions(AbstractMavenBuilder.java:186)
at hudson.maven.Maven3Builder.call(Maven3Builder.java:146)
at hudson.maven.Maven3Builder.call(Maven3Builder.java:70)
at hudson.remoting.UserRequest.perform(UserRequest.java:211)
at hudson.remoting.UserRequest.perform(UserRequest.java:54)
at hudson.remoting.Request$2.run(Request.java:369)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at 
java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at 
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at 
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)
ERROR: Asynchronous execution failure
java.util.concurrent.ExecutionException: java.io.IOException: Unexpected 
Fingerprint type. Expected class hudson.model.Fingerprint or subclass but got 
class hudson.model.Fingerprint$RangeSet
at hudson.remoting.Channel$2.adapt(Channel.java:1035)
at hudson.remoting.Channel$2.adapt(Channel.java:1029)
at hudson.remoting.FutureAdapter.get(FutureAdapter.java:55)
at 
hudson.maven.AbstractMavenBuilder.waitForAsynchronousExecutions(AbstractMavenBuilder.java:186)
at hudson.maven.Maven3Builder.call(Maven3Builder.java:146)
at hudson.maven.Maven3Builder.call(Maven3Builder.java:70)
at 

[GitHub] [cloudstack] DaanHoogland commented on issue #4195: Count mismatch for list diskofferings api

2021-01-28 Thread GitBox


DaanHoogland commented on issue #4195:
URL: https://github.com/apache/cloudstack/issues/4195#issuecomment-768910678


   @ravening , @davidjumani did some improvcements in this respect fr 4.15 
(I'll link the pull if i get time to find it) can you try with 4.15 please?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] DaanHoogland commented on issue #4187: Migration not working in ACS 4.14 with Basic Network - VMware Local storage

2021-01-28 Thread GitBox


DaanHoogland commented on issue #4187:
URL: https://github.com/apache/cloudstack/issues/4187#issuecomment-768908882


   @ccycv can youtest this with 4.15 please?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4626: server: fix failed to remove template/iso if upload from local fails

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4626:
URL: https://github.com/apache/cloudstack/pull/4626#issuecomment-768907454


   Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2612



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] DaanHoogland commented on issue #4628: Fail to create template from Volumes after upgrade 4.15

2021-01-28 Thread GitBox


DaanHoogland commented on issue #4628:
URL: https://github.com/apache/cloudstack/issues/4628#issuecomment-768907019


   @levindecaro can you deduce what kind of value shoud have been in that 
field, and then fill it as workaround?
   if this is indeed due to upgrade issue a default value should have been 
inserted for this details table.
   Having said that the field value in table vm_template_details is nullable in 
my local db, can you check that?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[cloudstack] branch master updated (e6fef05 -> f989409)

2021-01-28 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from e6fef05  Merge remote-tracking branch 'origin/4.15'
 add abec6d1  packaging: build and bundle UI using npm in deb and rpm 
packages (#4605)
 new f989409  Merge remote-tracking branch 'origin/4.15'

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 INSTALL.md |  6 +++
 client/pom.xml |  3 +-
 debian/cloudstack-management.install   |  1 +
 .../cloudstack-ui.install  |  6 +--
 debian/control |  7 ++-
 debian/rules   | 14 ++
 packaging/centos7/cloud.spec   | 29 +++
 packaging/centos8/cloud.spec   | 29 +++
 pom.xml| 56 +++---
 tools/travis/before_install.sh |  6 +++
 ui/{ => public}/error.html |  0
 11 files changed, 123 insertions(+), 34 deletions(-)
 copy core/src/main/resources/META-INF/cloudstack/allocator/module.properties 
=> debian/cloudstack-ui.install (93%)
 rename ui/{ => public}/error.html (100%)



[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.15'

2021-01-28 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit f98940953b1632d20aa68ca34439d01a6f359d64
Merge: e6fef05 abec6d1
Author: Rohit Yadav 
AuthorDate: Thu Jan 28 14:31:04 2021 +0530

Merge remote-tracking branch 'origin/4.15'

 INSTALL.md |  6 +++
 client/pom.xml |  3 +-
 debian/cloudstack-management.install   |  1 +
 ...ck-management.install => cloudstack-ui.install} | 22 +
 debian/control |  7 ++-
 debian/rules   | 14 ++
 packaging/centos7/cloud.spec   | 29 +++
 packaging/centos8/cloud.spec   | 29 +++
 pom.xml| 56 +++---
 tools/travis/before_install.sh |  6 +++
 ui/{ => public}/error.html |  0
 11 files changed, 123 insertions(+), 50 deletions(-)




[GitHub] [cloudstack] blueorangutan commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-768904579


   Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2611



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4624: server: fix wrong error message when create isolated network without SourceNat

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4624:
URL: https://github.com/apache/cloudstack/pull/4624#issuecomment-768904423


   Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2610



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[cloudstack] branch 4.15 updated: packaging: build and bundle UI using npm in deb and rpm packages (#4605)

2021-01-28 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.15
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.15 by this push:
 new abec6d1  packaging: build and bundle UI using npm in deb and rpm 
packages (#4605)
abec6d1 is described below

commit abec6d1fff24e650aeffe626714251a78fd4fdd2
Author: Rohit Yadav 
AuthorDate: Thu Jan 28 14:29:31 2021 +0530

packaging: build and bundle UI using npm in deb and rpm packages (#4605)

This changes deb and rpm packaging to build the UI using npm and bundle
it in the `cloudstack-management` package and a new `cloudstack-ui`
package. The `cloudstack-ui` package will install the UI under
`/usr/share/cloudstack-ui/`. For both packages the config.json will not
be overridden on upgrade and hosted at /etc/cloudstack/management
for the cloudstack-mangement package, and at /etc/cloudstack/ui for the
cloudstack-ui package. The cloudstack-ui package is for advanced users
who only want the UI want to setup reverse proxy (separate hosting of UI).

Signed-off-by: Rohit Yadav 
---
 INSTALL.md |  6 +++
 client/pom.xml |  3 +-
 debian/cloudstack-management.install   |  1 +
 ...ck-management.install => cloudstack-ui.install} | 22 +
 debian/control |  7 ++-
 debian/rules   | 14 ++
 packaging/centos7/cloud.spec   | 29 +++
 packaging/centos8/cloud.spec   | 29 +++
 pom.xml| 56 +++---
 tools/travis/before_install.sh |  6 +++
 ui/{ => public}/error.html |  0
 11 files changed, 123 insertions(+), 50 deletions(-)

diff --git a/INSTALL.md b/INSTALL.md
index 6840626..45173c1 100644
--- a/INSTALL.md
+++ b/INSTALL.md
@@ -28,6 +28,12 @@ Set up Maven (3.6.0):
 # echo export PATH=/usr/local/maven/bin:${PATH} >> ~/.bashrc # or .zshrc 
or .profile
 # source ~/.bashrc
 
+Setup up NodeJS (LTS):
+
+# curl -sL https://rpm.nodesource.com/setup_12.x | sudo bash -
+# sudo yum install nodejs
+# sudo npm install -g @vue/cli npm-check-updates
+
 Start the MySQL service:
 
 $ service mysqld start
diff --git a/client/pom.xml b/client/pom.xml
index 9873499..ba7f755 100644
--- a/client/pom.xml
+++ b/client/pom.xml
@@ -607,7 +607,8 @@
 
 
 
-
+
+
 
 
 
diff --git a/debian/cloudstack-management.install 
b/debian/cloudstack-management.install
index 289a495..e637541 100644
--- a/debian/cloudstack-management.install
+++ b/debian/cloudstack-management.install
@@ -21,6 +21,7 @@
 /etc/cloudstack/management/server.properties
 /etc/cloudstack/management/java.security.ciphers
 /etc/cloudstack/management/log4j-cloud.xml
+/etc/cloudstack/management/config.json
 /etc/default/cloudstack-management
 /etc/security/limits.d/cloudstack-limits.conf
 /etc/sudoers.d/cloudstack
diff --git a/debian/cloudstack-management.install b/debian/cloudstack-ui.install
similarity index 51%
copy from debian/cloudstack-management.install
copy to debian/cloudstack-ui.install
index 289a495..391c7b5 100644
--- a/debian/cloudstack-management.install
+++ b/debian/cloudstack-ui.install
@@ -15,23 +15,5 @@
 # specific language governing permissions and limitations
 # under the License.
 
-/etc/cloudstack/management/ehcache.xml
-/etc/cloudstack/management/db.properties
-/etc/cloudstack/management/environment.properties
-/etc/cloudstack/management/server.properties
-/etc/cloudstack/management/java.security.ciphers
-/etc/cloudstack/management/log4j-cloud.xml
-/etc/default/cloudstack-management
-/etc/security/limits.d/cloudstack-limits.conf
-/etc/sudoers.d/cloudstack
-/var/cache/cloudstack/management
-/var/log/cloudstack/management
-/var/lib/cloudstack/mnt
-/var/lib/cloudstack/management
-/usr/bin/cloudstack-update-xenserver-licenses
-/usr/bin/cloudstack-setup-management
-/usr/bin/cloudstack-setup-databases
-/usr/bin/cloudstack-migrate-databases
-/usr/bin/cloudstack-setup-encryption
-/usr/bin/cloudstack-sysvmadm
-/usr/share/cloudstack-management/*
+/etc/cloudstack/ui/config.json
+/usr/share/cloudstack-ui/*
diff --git a/debian/control b/debian/control
index 15467dc..15d3fb5 100644
--- a/debian/control
+++ b/debian/control
@@ -3,7 +3,7 @@ Section: libs
 Priority: extra
 Maintainer: Wido den Hollander 
 Build-Depends: debhelper (>= 9), openjdk-11-jdk | java11-sdk | java11-jdk | 
zulu-11, genisoimage,
- python-mysql.connector | 

[GitHub] [cloudstack] rhtyd merged pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages

2021-01-28 Thread GitBox


rhtyd merged pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.15'

2021-01-28 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit e6fef05f304b3b8726cee56b2778ff7e43225ae9
Merge: cbcd698 74bae56
Author: Rohit Yadav 
AuthorDate: Thu Jan 28 14:25:40 2021 +0530

Merge remote-tracking branch 'origin/4.15'

 .../java/com/cloud/vm/dao/VMInstanceDaoImpl.java|  1 +
 .../main/java/com/cloud/vm/UserVmManagerImpl.java   | 21 ++---
 systemvm/test/runtests.sh   |  4 ++--
 ui/README.md|  2 +-
 ui/src/components/view/ListView.vue |  8 +++-
 5 files changed, 21 insertions(+), 15 deletions(-)



[cloudstack] branch master updated (cbcd698 -> e6fef05)

2021-01-28 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from cbcd698  Merge remote-tracking branch 'origin/4.15'
 add 2a7f84e  ui: Add quickview to the list of VM Snapshot (#4614)
 add 7ba0374  ui: Fix screenshot path on README of ui (#4620)
 add b84a675  systemvm: Fixed typo (#4621)
 add 4a779de  server: fix on changeServiceForVirtualMachine when updating 
read/write rate  (#4491)
 add 182cea7  server: fix cannot create vm if another vm with same name has 
been added and removed on the network (#4600)
 add 74bae56  Merge remote-tracking branch 'origin/4.14' into 4.15
 new e6fef05  Merge remote-tracking branch 'origin/4.15'

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../java/com/cloud/vm/dao/VMInstanceDaoImpl.java|  1 +
 .../main/java/com/cloud/vm/UserVmManagerImpl.java   | 21 ++---
 systemvm/test/runtests.sh   |  4 ++--
 ui/README.md|  2 +-
 ui/src/components/view/ListView.vue |  8 +++-
 5 files changed, 21 insertions(+), 15 deletions(-)



[GitHub] [cloudstack] rhtyd closed issue #4125: Command changeServiceForVirtualMachine fails to update read/write rate

2021-01-28 Thread GitBox


rhtyd closed issue #4125:
URL: https://github.com/apache/cloudstack/issues/4125


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd closed issue #4607: [UI] Quick access menu bar missing for VM Snapshots

2021-01-28 Thread GitBox


rhtyd closed issue #4607:
URL: https://github.com/apache/cloudstack/issues/4607


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[cloudstack] branch 4.15 updated (7ba0374 -> 74bae56)

2021-01-28 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch 4.15
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 7ba0374  ui: Fix screenshot path on README of ui (#4620)
 add b84a675  systemvm: Fixed typo (#4621)
 add 4a779de  server: fix on changeServiceForVirtualMachine when updating 
read/write rate  (#4491)
 add 182cea7  server: fix cannot create vm if another vm with same name has 
been added and removed on the network (#4600)
 new 74bae56  Merge remote-tracking branch 'origin/4.14' into 4.15

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../java/com/cloud/vm/dao/VMInstanceDaoImpl.java|  1 +
 .../main/java/com/cloud/vm/UserVmManagerImpl.java   | 21 ++---
 systemvm/test/runtests.sh   |  4 ++--
 3 files changed, 13 insertions(+), 13 deletions(-)



[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.14' into 4.15

2021-01-28 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.15
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 74bae56642b224e9ccf54bf6ad3dd73b4cf13f41
Merge: 7ba0374 182cea7
Author: Rohit Yadav 
AuthorDate: Thu Jan 28 14:24:25 2021 +0530

Merge remote-tracking branch 'origin/4.14' into 4.15

Signed-off-by: Rohit Yadav 

 .../java/com/cloud/vm/dao/VMInstanceDaoImpl.java|  1 +
 .../main/java/com/cloud/vm/UserVmManagerImpl.java   | 21 ++---
 systemvm/test/runtests.sh   |  4 ++--
 3 files changed, 13 insertions(+), 13 deletions(-)




[GitHub] [cloudstack] levindecaro commented on issue #4628: Fail to create template from Volumes after upgrade 4.15

2021-01-28 Thread GitBox


levindecaro commented on issue #4628:
URL: https://github.com/apache/cloudstack/issues/4628#issuecomment-768899846


   > `Column 'value' cannot be null`
   
   yes, but it shouldn't be, the problematic VM was created since 4.14.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on a change in pull request #4561: [WIP] Support for persistence mode in L2 networks

2021-01-28 Thread GitBox


rhtyd commented on a change in pull request #4561:
URL: https://github.com/apache/cloudstack/pull/4561#discussion_r565907779



##
File path: 
api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkCmd.java
##
@@ -16,13 +16,13 @@
 // under the License.
 package org.apache.cloudstack.api.command.user.network;
 
+import org.apache.cloudstack.api.BaseCmd;
 import org.apache.log4j.Logger;
 
 import org.apache.cloudstack.acl.RoleType;
 import org.apache.cloudstack.api.APICommand;
 import org.apache.cloudstack.api.ApiConstants;
 import org.apache.cloudstack.api.ApiErrorCode;
-import org.apache.cloudstack.api.BaseCmd;

Review comment:
   Import reshuffle does not look sortable. You can fix your intellij 
settings or get preset settings (mine are here 
https://github.com/rhtyd/dotfiles/blob/master/intellij/settings.jar)

##
File path: core/src/main/java/com/cloud/agent/api/MigrateCommand.java
##
@@ -40,6 +40,7 @@
 private boolean executeInSequence = false;
 private List migrateDiskInfoList = new ArrayList<>();
 private Map dpdkInterfaceMapping = new HashMap<>();
+Map vlanToPersistenceMap;

Review comment:
   Just a note - if field is not initialised, the consumer of getter must 
do a NPE check.

##
File path: 
plugins/api/discovery/src/main/java/org/apache/cloudstack/discovery/ApiDiscoveryServiceImpl.java
##
@@ -67,7 +68,7 @@ public boolean start() {
 if (s_apiNameDiscoveryResponseMap == null) {
 long startTime = System.nanoTime();
 s_apiNameDiscoveryResponseMap = new HashMap();
-Set> cmdClasses = new HashSet>();
+Set> cmdClasses = new LinkedHashSet>();

Review comment:
   minor minor nit - The other PR/fix has come here.

##
File path: 
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##
@@ -2864,6 +2962,33 @@ public boolean shutdownNetworkElementsAndResources(final 
ReservationContext cont
 return success;
 }
 
+private void cleanupPersistentnNetworkResources(NetworkVO network) {
+long networkOfferingId = network.getNetworkOfferingId();
+NetworkOfferingVO offering = 
_networkOfferingDao.findById(networkOfferingId);
+if (offering != null) {
+if (networkMeetsPersistenceCriteria(network, offering, true) &&
+
_networksDao.getOtherPersistentNetworksCount(network.getId(), 
network.getBroadcastUri().toString(), offering.isPersistent()) == 0) {
+List hosts = 
resourceManager.listAllUpAndEnabledHostsInOneZoneByType(Host.Type.Routing, 
network.getDataCenterId());
+for (HostVO host : hosts) {
+try {
+NicTO to = createNicTOFromNetworkAndOffering(network, 
offering, host);
+CleanupPersistentNetworkResourceCommand cmd = new 
CleanupPersistentNetworkResourceCommand(to);
+CleanupPersistentNetworkResourceAnswer answer = 
(CleanupPersistentNetworkResourceAnswer) _agentMgr.send(host.getId(), cmd);
+if (answer == null) {
+s_logger.warn("Unable to get an answer to the 
CleanupPersistentNetworkResourceCommand from agent:" + host.getId());
+}
+
+if (!answer.getResult()) {
+s_logger.warn("Unable to setup agent " + 
host.getId() + " due to " + answer.getDetails());
+}
+} catch (Exception e) {
+s_logger.warn("Failed to cleanup network resources");

Review comment:
   Can we log on which host it was failed, or one of the warning/log above?

##
File path: 
core/src/main/java/com/cloud/agent/api/CleanupPersistentNetworkResourceCommand.java
##
@@ -0,0 +1,43 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package com.cloud.agent.api;
+
+import com.cloud.agent.api.to.NicTO;
+
+public class CleanupPersistentNetworkResourceCommand extends Command{

Review comment:
   minor nit - space after `Command {`

##
File path: 

[GitHub] [cloudstack] weizhouapache commented on pull request #4605: packaging: build and bundle UI using npm in deb and rpm packages

2021-01-28 Thread GitBox


weizhouapache commented on pull request #4605:
URL: https://github.com/apache/cloudstack/pull/4605#issuecomment-768887207


   > @weizhouapache we've two LGTMs, are you testing this? Thanks.
   
   @rhtyd yes, tested ok. reviewing code. I will get back to you in 30 min.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd closed pull request #4150: [HEALTH][4.14] Health Check Run

2021-01-28 Thread GitBox


rhtyd closed pull request #4150:
URL: https://github.com/apache/cloudstack/pull/4150


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] weizhouapache commented on issue #4628: Fail to create template from Volumes after upgrade 4.15

2021-01-28 Thread GitBox


weizhouapache commented on issue #4628:
URL: https://github.com/apache/cloudstack/issues/4628#issuecomment-768881117


   `Column 'value' cannot be null`
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4626: server: fix failed to remove template/iso if upload from local fails

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4626:
URL: https://github.com/apache/cloudstack/pull/4626#issuecomment-768880787


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4626: server: fix failed to remove template/iso if upload from local fails

2021-01-28 Thread GitBox


rhtyd commented on pull request #4626:
URL: https://github.com/apache/cloudstack/pull/4626#issuecomment-768880150


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4588: Enable SNI in SSVM

2021-01-28 Thread GitBox


rhtyd commented on pull request #4588:
URL: https://github.com/apache/cloudstack/pull/4588#issuecomment-768877731


   @olivierlemasle have you tested if copy template across works with the fix?
   
   Otherwise, it will require this manual test case - setup zone/env with SSL 
enable for systemvms, add another zone with cluster/hosts etc and try to use 
the copyTemplate API.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4622: server: add possibility to scale vm to current custom offerings on UI

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4622:
URL: https://github.com/apache/cloudstack/pull/4622#issuecomment-768877264


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-768877115


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4625: server: throw exception when update vm nic on L2 network

2021-01-28 Thread GitBox


blueorangutan commented on pull request #4625:
URL: https://github.com/apache/cloudstack/pull/4625#issuecomment-768876978


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




  1   2   >