[GitHub] [cloudstack] shwstppr commented on issue #4594: The network documentation contains dangling hyperlinks.

2021-02-04 Thread GitBox


shwstppr commented on issue #4594:
URL: https://github.com/apache/cloudstack/issues/4594#issuecomment-773848852


   @vladimirpetrov please test 
https://github.com/apache/cloudstack-documentation/pull/185



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4643: VM dynamic scaling option granularity

2021-02-04 Thread GitBox


harikrishna-patnala commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-773836392


   @blueorangutan ui



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4643: VM dynamic scaling option granularity

2021-02-04 Thread GitBox


harikrishna-patnala commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-773835496


   These failed test cases are commonly seen on all PRs, not related to this PR 
changes.
   
   test_01_scale_vm on XenServer is failing with License error 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] shwstppr edited a comment on issue #4654: VM's name and display name in UI

2021-02-04 Thread GitBox


shwstppr edited a comment on issue #4654:
URL: https://github.com/apache/cloudstack/issues/4654#issuecomment-773823098


   @harikrishna-patnala @vladimirpetrov @PaulAngus @weizhouapache @ravening 
@rhtyd @davidjumani @andrijapanicsb, others: opinion on this?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] harikrishna-patnala commented on issue #4654: VM's name and display name in UI

2021-02-04 Thread GitBox


harikrishna-patnala commented on issue #4654:
URL: https://github.com/apache/cloudstack/issues/4654#issuecomment-773827166


   @shwstppr In my opinion list view should show "Display Name" of the VM 
because the displayname itself is meant for that.
   so I would like to see display name instead of name. Details tab anyways 
shows both Display Name and Name



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] shwstppr commented on issue #4654: VM's name and display name in UI

2021-02-04 Thread GitBox


shwstppr commented on issue #4654:
URL: https://github.com/apache/cloudstack/issues/4654#issuecomment-773823098


   @harikrishna-patnala @vladimirpetrov @PaulAngus @weizhouapache @ravening 
@rhtyd @davidjumani @andrijapanicsb opinion on this?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] shwstppr opened a new issue #4654: VM's name and display name in UI

2021-02-04 Thread GitBox


shwstppr opened a new issue #4654:
URL: https://github.com/apache/cloudstack/issues/4654


   In new UI, for the VM detail view shows VM's display name while VM's name is 
shown in the list view. It is fine when VM is deployed from the UI itself but 
name and display name can have different values when deployed from cmk.
   
   Old UI used to show `name` of the VM in the list view and there was no info 
tab in detail view,
   ![Screenshot from 2021-02-05 
11-31-12](https://user-images.githubusercontent.com/153340/106996466-11c11d00-67a7-11eb-84bb-0734d83df386.png)
   ![Screenshot from 2021-02-05 
11-31-26](https://user-images.githubusercontent.com/153340/106996481-15ed3a80-67a7-11eb-9352-6b236bf533bc.png)
   
   New UI
   ![Screenshot from 2021-02-05 
11-40-24](https://user-images.githubusercontent.com/153340/106996490-1be31b80-67a7-11eb-9cda-4de4c02ec7ba.png)
   ![Screenshot from 2021-02-05 
11-40-43](https://user-images.githubusercontent.com/153340/106996526-2d2c2800-67a7-11eb-8690-8cf809d7f684.png)
   
   Few queries here,
   - Is this behaviour okay from the user perspective?
   - Should UI display VM's `displayname` in the list view?
   - Should new UI show VM's `name` in the info tab in detail view?
   
   
   # ISSUE TYPE
   
* Other
   
   # COMPONENT NAME
   ~~~
   UI
   ~~~
   
   # CLOUDSTACK VERSION
   ~~~
   4.15.0
   ~~~
   
   # CONFIGURATION
   N/A
   
   
   # OS / ENVIRONMENT
   N/A
   
   
   # SUMMARY
   
   
   
   # STEPS TO REPRODUCE
   
   
   # EXPECTED RESULTS
   
   
   ~~~
   
   ~~~
   
   # ACTUAL RESULTS
   
   
   
   ~~~
   
   ~~~
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4577: [HEALTH] 4.16/master Health Check please don't merge this

2021-02-04 Thread GitBox


blueorangutan commented on pull request #4577:
URL: https://github.com/apache/cloudstack/pull/4577#issuecomment-773813287


   Packaging result: :heavy_check_mark: centos7 heavy_check_mark: centos8 
:heavy_check_mark: debian. JID-[S]17



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] PranaliM commented on issue #4095: updateDiskOffering can't add/edit tag on existent disk Offering

2021-02-04 Thread GitBox


PranaliM commented on issue #4095:
URL: https://github.com/apache/cloudstack/issues/4095#issuecomment-773809838


   Thanks @RodrigoDLopez, this helps.
   Do we have a similar option for editing host tags in service offerings ? If 
not, could we consider adding that?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4653: Update cloud-setup-databases.in - help message fix

2021-02-04 Thread GitBox


blueorangutan commented on pull request #4653:
URL: https://github.com/apache/cloudstack/pull/4653#issuecomment-773799043


   Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2651



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4653: Update cloud-setup-databases.in - help message fix

2021-02-04 Thread GitBox


blueorangutan commented on pull request #4653:
URL: https://github.com/apache/cloudstack/pull/4653#issuecomment-773789910


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] shwstppr commented on pull request #4653: Update cloud-setup-databases.in - help message fix

2021-02-04 Thread GitBox


shwstppr commented on pull request #4653:
URL: https://github.com/apache/cloudstack/pull/4653#issuecomment-773789408


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run

2021-02-04 Thread GitBox


blueorangutan commented on pull request #4150:
URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-773740844


   Trillian test result (tid-3495)
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 49470 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4150-t3495-vmware-65u2.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Smoke tests completed. 81 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_03_deploy_and_upgrade_kubernetes_cluster | `Error` | 3755.25 | 
test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 114.24 | 
test_kubernetes_clusters.py
   test_02_create_template_with_checksum_sha1 | `Error` | 5.11 | 
test_templates.py
   test_03_create_template_with_checksum_sha256 | `Error` | 5.11 | 
test_templates.py
   test_04_create_template_with_checksum_md5 | `Error` | 5.11 | 
test_templates.py
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4651: marvin: fix test failures when changing service offering of a VM

2021-02-04 Thread GitBox


blueorangutan commented on pull request #4651:
URL: https://github.com/apache/cloudstack/pull/4651#issuecomment-773718887


   Trillian test result (tid-3496)
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 41292 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4651-t3496-vmware-67u3.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_kubernetes_clusters.py
   Smoke tests completed. 85 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 801.35 | 
test_kubernetes_clusters.py
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run

2021-02-04 Thread GitBox


blueorangutan commented on pull request #4150:
URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-773656100


   Trillian test result (tid-3494)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 35717 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4150-t3494-kvm-centos7.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_kubernetes_supported_versions.py
   Smoke tests completed. 83 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)

2021-02-04 Thread GitBox


blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-773654847


   Trillian test result (tid-3489)
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 45153 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4304-t3489-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Smoke tests completed. 83 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 802.71 | 
test_kubernetes_clusters.py
   test_04_change_offering_small | `Error` | 5.20 | test_service_offerings.py
   test_change_service_offering_for_vm_with_snapshots | `Error` | 141.65 | 
test_vm_snapshots.py
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity

2021-02-04 Thread GitBox


blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-773639802


   Trillian test result (tid-3492)
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 39835 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4643-t3492-vmware-65u2.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Smoke tests completed. 84 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 778.21 | 
test_kubernetes_clusters.py
   test_change_service_offering_for_vm_with_snapshots | `Error` | 140.93 | 
test_vm_snapshots.py
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run

2021-02-04 Thread GitBox


blueorangutan commented on pull request #4150:
URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-773634249


   Trillian test result (tid-3493)
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33147 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4150-t3493-xenserver-71.zip
   Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 82 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_scale_vm | `Failure` | 8.34 | test_scale_vm.py
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity

2021-02-04 Thread GitBox


blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-773587284


   Trillian test result (tid-3490)
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33415 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4643-t3490-xenserver-71.zip
   Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
   Smoke tests completed. 85 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_scale_vm | `Failure` | 11.62 | test_scale_vm.py
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity

2021-02-04 Thread GitBox


blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-773585520


   Trillian test result (tid-3491)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33095 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4643-t3491-kvm-centos7.zip
   Smoke tests completed. 86 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] andrijapanicsb opened a new pull request #4653: Update cloud-setup-databases.in - help message fix

2021-02-04 Thread GitBox


andrijapanicsb opened a new pull request #4653:
URL: https://github.com/apache/cloudstack/pull/4653


   ### Description
   
   This PR...
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   ### Types of changes
   
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### How Has This Been Tested?
   No need to?
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[cloudstack] 01/01: Update cloud-setup-databases.in

2021-02-04 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a commit to branch help-message-fix
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 609095d9f91c77bdf28df7e78c70f9fd18d3a7f4
Author: Andrija Panic <45762285+andrijapani...@users.noreply.github.com>
AuthorDate: Thu Feb 4 20:48:33 2021 +0100

Update cloud-setup-databases.in
---
 setup/bindir/cloud-setup-databases.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/setup/bindir/cloud-setup-databases.in 
b/setup/bindir/cloud-setup-databases.in
index 15a8176..53617be 100755
--- a/setup/bindir/cloud-setup-databases.in
+++ b/setup/bindir/cloud-setup-databases.in
@@ -179,7 +179,7 @@ Sql parameters:
 ***
 Please run:
 
-cloud-setup-database -h
+cloudstack-setup-databases -h
 
 for full help
 ''' % msg



[cloudstack] branch help-message-fix created (now 609095d)

2021-02-04 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a change to branch help-message-fix
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


  at 609095d  Update cloud-setup-databases.in

This branch includes the following new commits:

 new 609095d  Update cloud-setup-databases.in

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.




[GitHub] [cloudstack] andrijapanicsb closed pull request #4652: help text fix

2021-02-04 Thread GitBox


andrijapanicsb closed pull request #4652:
URL: https://github.com/apache/cloudstack/pull/4652


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] andrijapanicsb opened a new pull request #4652: help text fix

2021-02-04 Thread GitBox


andrijapanicsb opened a new pull request #4652:
URL: https://github.com/apache/cloudstack/pull/4652


   ### Description
   
   This PR...
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   ### Types of changes
   
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   No need to test - simple comment/help text update to reflect true script name
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[cloudstack] branch andrijapanicsb-patch-1 created (now 3d27321)

2021-02-04 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a change to branch andrijapanicsb-patch-1
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


  at 3d27321  help text fix

This branch includes the following new commits:

 new 3d27321  help text fix

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.




[cloudstack] 01/01: help text fix

2021-02-04 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository.

andrijapanic pushed a commit to branch andrijapanicsb-patch-1
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 3d27321cb1e139dc4ea08f7dc517e3bd4c015d46
Author: Andrija Panic <45762285+andrijapani...@users.noreply.github.com>
AuthorDate: Thu Feb 4 20:42:03 2021 +0100

help text fix
---
 setup/bindir/cloud-setup-databases.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/setup/bindir/cloud-setup-databases.in 
b/setup/bindir/cloud-setup-databases.in
index 98f7139..bd23c2b 100755
--- a/setup/bindir/cloud-setup-databases.in
+++ b/setup/bindir/cloud-setup-databases.in
@@ -179,7 +179,7 @@ Sql parameters:
 ***
 Please run:
 
-cloud-setup-database -h
+cloudstack-setup-databases -h
 
 for full help
 ''' % msg



[GitHub] [cloudstack] blueorangutan commented on pull request #4639: cks: use HttpsURLConnection for checking api server

2021-02-04 Thread GitBox


blueorangutan commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-773507040


   Trillian test result (tid-3486)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33562 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4639-t3486-kvm-centos7.zip
   Smoke tests completed. 83 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] nxsbi commented on pull request #4639: cks: use HttpsURLConnection for checking api server

2021-02-04 Thread GitBox


nxsbi commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-773498653


   Is there any option for Verbose logging which would have logged the 
ipAddress and Port that were used in the? That would have made it easier to 
determine the problem of not being able to connect to VR IP on port ... 
Just a thought. 
   
   `
   socket.connect(new InetSocketAddress(ipAddress, port), 1)`



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] nxsbi commented on issue #4637: Kubernetes cluster creation Error - Kubernetes cluster kubeconfig not available currently in Isolated Network

2021-02-04 Thread GitBox


nxsbi commented on issue #4637:
URL: https://github.com/apache/cloudstack/issues/4637#issuecomment-773489306


   IF the Management server setup uses a VLAN for its networking, appropriate 
Firewall rules need to be added to any router/hardware firewall to allow 
communication from management VLAN to all VLANs used for Public traffic where 
Kubernetes Cluster could be created.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] nxsbi closed issue #4637: Kubernetes cluster creation Error - Kubernetes cluster kubeconfig not available currently in Isolated Network

2021-02-04 Thread GitBox


nxsbi closed issue #4637:
URL: https://github.com/apache/cloudstack/issues/4637


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] nxsbi commented on issue #4637: Kubernetes cluster creation Error - Kubernetes cluster kubeconfig not available currently in Isolated Network

2021-02-04 Thread GitBox


nxsbi commented on issue #4637:
URL: https://github.com/apache/cloudstack/issues/4637#issuecomment-773486212


   @shwstppr That was it!! The Management Server was not able to reach the 
Virtual router on port  via ssh. 
   Turned out, the main Hardware firewall (outside of Cloudstack) does not 
allow inter VLAN communication as a default. That is what was blocking it. I 
added rule to allow the communication, and was able to create a cluster just 
now! 
   
   Thanks so much
   
   Perhaps we need to add a note in the documentation that for Kubernetes 
cluster creation, IF the Management server setup uses a VLAN for its 
networking, appropriate Firewall rules need to be added to allow communication 
from management VLAN to all VLANs used for Public traffic where Kubernetes 
Cluster could be created. 
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] nxsbi commented on pull request #4639: cks: use HttpsURLConnection for checking api server

2021-02-04 Thread GitBox


nxsbi commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-773483059


   @shwstppr That was it!! The Management Server was not able to reach the 
Virtual router on port  via ssh. 
   Turned out, the main Hardware firewall (outside of Cloudstack) does not 
allow inter VLAN communication as a default. That is what was blocking it. I 
added rule to allow the communication, and was able to create a cluster just 
now! 
   
   Thanks so much! 
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] shwstppr commented on issue #4637: Kubernetes cluster creation Error - Kubernetes cluster kubeconfig not available currently in Isolated Network

2021-02-04 Thread GitBox


shwstppr commented on issue #4637:
URL: https://github.com/apache/cloudstack/issues/4637#issuecomment-773456915


   @nxsbi Service uses SSH over ports  to +n. SSH on worker nodes is 
done only during k8s version upgrade.
   Firewall and port forwarding rules must be automatically provisioned by the 
service in the cluster's network.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] shwstppr commented on pull request #4639: cks: use HttpsURLConnection for checking api server

2021-02-04 Thread GitBox


shwstppr commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-773455467


   @nxsbi service is not being able to connect to SSH with VR public IP and 
forwarded port (must be ), failing here
   
https://github.com/apache/cloudstack/blob/280c13a4bb103dd748ec304bfe0714a148c24602/plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/utils/KubernetesClusterUtil.java#L247-L253
   
   Are you able to manually do SSH from the management server?
   `ssh -i /root/.ssh/id_rsa.cloud -p  core@public_ip_of_network`
   
   Firewall and port forwarding rules must be automatically provisioned by the 
service in the cluster's network.
   Service uses SSH over  to +n ports. SSH on worker nodes are done 
only during k8s version upgrade



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] andrijapanicsb closed issue #4535: UI allows ISO images, uploaded/registered as not extractable to be downloaded

2021-02-04 Thread GitBox


andrijapanicsb closed issue #4535:
URL: https://github.com/apache/cloudstack/issues/4535


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] nxsbi edited a comment on issue #4637: Kubernetes cluster creation Error - Kubernetes cluster kubeconfig not available currently in Isolated Network

2021-02-04 Thread GitBox


nxsbi edited a comment on issue #4637:
URL: https://github.com/apache/cloudstack/issues/4637#issuecomment-773450124


   @shwstppr But my management server is able to curl -k the public IP. It 
fails on curl only without -k option.
   
   So this should be working right? Do I need any other port besides 6443 open? 
Does it communicate in any other way besides https? 
   
   
![image](https://user-images.githubusercontent.com/71042351/106922958-6dfe4100-66c2-11eb-843f-8cb11128d400.png)
   
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] nxsbi commented on issue #4637: Kubernetes cluster creation Error - Kubernetes cluster kubeconfig not available currently in Isolated Network

2021-02-04 Thread GitBox


nxsbi commented on issue #4637:
URL: https://github.com/apache/cloudstack/issues/4637#issuecomment-773450124


   @shwstppr But my management server is able to curl -k the public IP. It 
fails on curl only without -k option.
   
   
![image](https://user-images.githubusercontent.com/71042351/106922958-6dfe4100-66c2-11eb-843f-8cb11128d400.png)
   
   So this should be working right? Do I need any other port besides 6443 open? 
Does it communicate in any other way besides https? 
   
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] nxsbi commented on pull request #4639: cks: use HttpsURLConnection for checking api server

2021-02-04 Thread GitBox


nxsbi commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-773432881


   @shwstppr 
   Management server is able to curl -k the public IP of the VR. But it throws 
error if using just curl (without -k)
   
   
![image](https://user-images.githubusercontent.com/71042351/106922815-460edd80-66c2-11eb-9a53-f03266a7fce0.png)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] vladimirpetrov commented on issue #4594: The network documentation contains dangling hyperlinks.

2021-02-04 Thread GitBox


vladimirpetrov commented on issue #4594:
URL: https://github.com/apache/cloudstack/issues/4594#issuecomment-773428121


   The last link - "'About Elastic IP” on the page:
   
   
[https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr184//adminguide/networking.html#isolated-networks](https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr184//adminguide/networking.html#isolated-networks)
   
   
![image](https://user-images.githubusercontent.com/12384665/106921704-edb4fb80-6714-11eb-93e5-4e25088485a1.png)
   
   is still broken, it links to the following url:
   
   
[https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr184//adminguide/advanced_zone_config.html#about-elastic-ip](https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr184//adminguide/advanced_zone_config.html#about-elastic-ip)
   
   which is unavailable:
   
   
![image](https://user-images.githubusercontent.com/12384665/106921915-2654d500-6715-11eb-93da-2522c31d0487.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] DaanHoogland commented on pull request #4651: marvin: fix test failures when changing service offering of a VM

2021-02-04 Thread GitBox


DaanHoogland commented on pull request #4651:
URL: https://github.com/apache/cloudstack/pull/4651#issuecomment-773352583


   tests are never critical for release unless they relate to a fix i'd say. In 
this case it is a corner case, let's include it.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4329: Adding AutoScaling for cks + CKS CoreOS EOL update

2021-02-04 Thread GitBox


blueorangutan commented on pull request #4329:
URL: https://github.com/apache/cloudstack/pull/4329#issuecomment-773315181


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2650



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4650: test: hardware required for changeserviceoffering

2021-02-04 Thread GitBox


rhtyd commented on pull request #4650:
URL: https://github.com/apache/cloudstack/pull/4650#issuecomment-773317136


   Looks like you've fixed it as well cc @Pearl1594 @DaanHoogland 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4651: marvin: fix test failures when changing service offering of a VM

2021-02-04 Thread GitBox


rhtyd commented on pull request #4651:
URL: https://github.com/apache/cloudstack/pull/4651#issuecomment-773316394


   We want this in 4.14 branch, @Pearl1594 cc @shwstppr @DaanHoogland 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4651: marvin: fix test failures when changing service offering of a VM

2021-02-04 Thread GitBox


blueorangutan commented on pull request #4651:
URL: https://github.com/apache/cloudstack/pull/4651#issuecomment-773307785


   @Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been 
kicked to run smoke tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] Pearl1594 commented on pull request #4651: marvin: fix test failures when changing service offering of a VM

2021-02-04 Thread GitBox


Pearl1594 commented on pull request #4651:
URL: https://github.com/apache/cloudstack/pull/4651#issuecomment-773307090


   @blueorangutan test centos7 vmware-67u3



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] Pearl1594 commented on pull request #4651: marvin: fix test failures when changing service offering of a VM

2021-02-04 Thread GitBox


Pearl1594 commented on pull request #4651:
URL: https://github.com/apache/cloudstack/pull/4651#issuecomment-773306378


   > @Pearl1594 does this need to go in 4.14?
   
   @shwstppr I don't see these test failures on 4.14 based PRs



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4651: marvin: fix test failures when changing service offering of a VM

2021-02-04 Thread GitBox


blueorangutan commented on pull request #4651:
URL: https://github.com/apache/cloudstack/pull/4651#issuecomment-773304094


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2649



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] shwstppr commented on pull request #4651: marvin: fix test failures when changing service offering of a VM

2021-02-04 Thread GitBox


shwstppr commented on pull request #4651:
URL: https://github.com/apache/cloudstack/pull/4651#issuecomment-773298677


   @Pearl1594 does this need to go in 4.14?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4329: Adding AutoScaling for cks + CKS CoreOS EOL update

2021-02-04 Thread GitBox


blueorangutan commented on pull request #4329:
URL: https://github.com/apache/cloudstack/pull/4329#issuecomment-773285430


   @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] Pearl1594 commented on pull request #4329: Adding AutoScaling for cks + CKS CoreOS EOL update

2021-02-04 Thread GitBox


Pearl1594 commented on pull request #4329:
URL: https://github.com/apache/cloudstack/pull/4329#issuecomment-773285177


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4651: marvin: fix test failures when changing service offering of a VM

2021-02-04 Thread GitBox


blueorangutan commented on pull request #4651:
URL: https://github.com/apache/cloudstack/pull/4651#issuecomment-773274706


   @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] Pearl1594 commented on pull request #4651: marvin: fix test failures when changing service offering of a VM

2021-02-04 Thread GitBox


Pearl1594 commented on pull request #4651:
URL: https://github.com/apache/cloudstack/pull/4651#issuecomment-773274273


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] Pearl1594 opened a new pull request #4651: marvin: fix test failures when changing service offering of a VM

2021-02-04 Thread GitBox


Pearl1594 opened a new pull request #4651:
URL: https://github.com/apache/cloudstack/pull/4651


   
   ### Description
   
   This PR fixes the test failures noticed on VMware test runs where in change 
of service offering for a VM fails with the following error:
   ```
   2021-02-04 11:58:05,241 - CRITICAL - EXCEPTION: 
test_04_change_offering_small: ['Traceback (most recent call last):\n', '  File 
"/usr/lib64/python2.7/unittest/case.py", line 369, in run\ntestMethod()\n', 
'  File "/marvin/tests/smoke/test_service_offerings.py", line 511, in 
test_04_change_offering_small\n
self.apiclient.changeServiceForVirtualMachine(cmd)\n', '  File 
"/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", 
line 1086, in changeServiceForVirtualMachine\nresponse = 
self.connection.marvinRequest(command, response_type=response, 
method=method)\n', '  File 
"/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in 
marvinRequest\nraise e\n', 'CloudstackAPIException: Execute cmd: 
changeserviceforvirtualmachine failed, due to: errorCode: 431, errorText:VM 
current state is : PowerOn. But VM should be in PowerOff state.\n']
   
   ```
   This seems to be a consequence of changing the enabling volumeresize with 
changeServiceForVirtualMachine introduced with : 
https://github.com/apache/cloudstack/pull/4491. The failure is seen in 
**test_service_offerings.py -> test_04_change_offering_small**  and 
**test_vm_snapshots.py -> test_change_service_offering_for_vm_with_snapshots**
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [X] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [X] Minor
   - [ ] Trivial
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run

2021-02-04 Thread GitBox


blueorangutan commented on pull request #4150:
URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-773266689


   @rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + 
vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4150: [HEALTH][4.14] Health Check Run

2021-02-04 Thread GitBox


rhtyd commented on pull request #4150:
URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-773266333


   @blueorangutan test matrix



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] shwstppr commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR

2021-02-04 Thread GitBox


shwstppr commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-773260094


   @weizhouapache @rhtyd I'm to reproduce the issue with 4.14 with Ubuntu18 
mgmt and hosts. Testing the fix now



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host

2021-02-04 Thread GitBox


weizhouapache commented on a change in pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#discussion_r570161351



##
File path: 
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##
@@ -4498,7 +4498,7 @@ private void 
handlePowerOffReportWithNoPendingJobsOnVM(final VMInstanceVO vm) {
 String.format("VM %s is at %s and we received a %s 
report while there is no pending jobs on it"
 , vm.getInstanceName(), vm.getState(), 
vm.getPowerState()));
 }
-if(vm.isHaEnabled() && vm.getState() == State.Running
+if((HighAvailabilityManager.ForceHA.value() || vm.isHaEnabled()) 
&& vm.getState() == State.Running

Review comment:
   @harikrishna-patnala yes,  it is a cluster-scope setting.
   But cloudstack does not consider it before.
   ```
   _forceHA = ForceHA.value();
   ```
   
same as other cluster-scope settings in 
https://github.com/apache/cloudstack/blob/master/engine/components-api/src/main/java/com/cloud/ha/HighAvailabilityManager.java.
   
   I am wondering if we should fix all of them in a pr.
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] weizhouapache commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR

2021-02-04 Thread GitBox


weizhouapache commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-773239570


   > > @shwstppr can you test with Ubuntu 18.04 and see if that helps? 
@weizhouapache is the env adv zone or adv zone with SG, or some other 
permutation?
   > 
   > @rhtyd @shwstppr I use advanced zone with isolated networks.
   > I will test with shared networks.
   
   tested with shared network in advanced zone.
   it has the same issue.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] weizhouapache commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR

2021-02-04 Thread GitBox


weizhouapache commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-773223902


   > @shwstppr can you test with Ubuntu 18.04 and see if that helps? 
@weizhouapache is the env adv zone or adv zone with SG, or some other 
permutation?
   
   @rhtyd @shwstppr I use advanced zone with isolated networks.
   I will test with shared networks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] shwstppr opened a new pull request #4650: test: hardware required for changeserviceoffering

2021-02-04 Thread GitBox


shwstppr opened a new pull request #4650:
URL: https://github.com/apache/cloudstack/pull/4650


   ### Description
   
   With #4491, root disks of VMs will be resized while changing service 
offering.
   On simulator this would fail and will need actual hypervisor to test.
   Component test test_01_change_service_offering  in test_mm_domain_limits.py 
has been tagged to require hardware to address this.
   This will skip run for this test on travis.
   
   
   
   
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [x] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   
   
   
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity

2021-02-04 Thread GitBox


blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-773213085


   @harikrishna-patnala a Trillian-Jenkins matrix job (centos7 mgmt + xs71, 
centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run 
smoke tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4643: VM dynamic scaling option granularity

2021-02-04 Thread GitBox


harikrishna-patnala commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-773212294


   @blueorangutan test matrix



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity

2021-02-04 Thread GitBox


blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-773211211


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2648



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4577: [HEALTH] 4.16/master Health Check please don't merge this

2021-02-04 Thread GitBox


blueorangutan commented on pull request #4577:
URL: https://github.com/apache/cloudstack/pull/4577#issuecomment-773207319


   [S] Packaging result: :heavy_multiplication_x: centos7 
:heavy_multiplication_x: centos8 :heavy_check_mark: debian. JID-16



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] shwstppr commented on issue #4637: Kubernetes cluster creation Error - Kubernetes cluster kubeconfig not available currently in Isolated Network

2021-02-04 Thread GitBox


shwstppr commented on issue #4637:
URL: https://github.com/apache/cloudstack/issues/4637#issuecomment-773198073


   @nxsbi as correctly mentioned by @weizhouapache Kubernetes service connects 
cluster's master/nodes via the VR **public IP**. This is one of the requirement 
right now.
   #4639 just tries to fix SSL validation issue while trying to access API 
server of k8s cluster.
   From your logs shared in the PR, it seems management server is not being 
able to reach master VM through VR's public IP



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity

2021-02-04 Thread GitBox


blueorangutan commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-773187712


   @harikrishna-patnala a Jenkins job has been kicked to build packages. I'll 
keep you posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run

2021-02-04 Thread GitBox


blueorangutan commented on pull request #4150:
URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-773187679


   Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2647



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] harikrishna-patnala commented on pull request #4643: VM dynamic scaling option granularity

2021-02-04 Thread GitBox


harikrishna-patnala commented on pull request #4643:
URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-773186872


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[cloudstack] branch VMDynamicScalabilityGranularity updated (d31321b -> 46ba6fd)

2021-02-04 Thread harikrishna
This is an automated email from the ASF dual-hosted git repository.

harikrishna pushed a change to branch VMDynamicScalabilityGranularity
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from d31321b  Reverted 414 to 415 schema file empty line changes
 add 46ba6fd  Added marvin tests required for these changes

No new revisions were added by this update.

Summary of changes:
 test/integration/smoke/test_scale_vm.py | 207 
 tools/marvin/marvin/lib/base.py |   8 +-
 2 files changed, 214 insertions(+), 1 deletion(-)



[GitHub] [cloudstack] blueorangutan commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host

2021-02-04 Thread GitBox


blueorangutan commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-773185617


   Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2646



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] sureshanaparti edited a comment on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)

2021-02-04 Thread GitBox


sureshanaparti edited a comment on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-773183135


   > test_04_change_offering_small  Error   4.29
test_service_offerings.py
   > This could turn out a bug or limitation, we haven't seen it elsewhere I 
believe.
   
   Observed error (errorText:VM current state is : PowerOn. But VM should be in 
PowerOff state.) in test "test_04_change_offering_small" - VM is stopped, and 
followed by triggering _changeServiceForVirtualMachine_ API. Updated   test to 
confirm the VM 'Stopped' state and trigger the _changeServiceForVirtualMachine_ 
API. and Re-triggered the smoke tests.
   
   This above test failure/error is not related to the changes in this PR.
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] sureshanaparti commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)

2021-02-04 Thread GitBox


sureshanaparti commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-773183135


   > test_04_change_offering_small  Error   4.29
test_service_offerings.py
   > This could turn out a bug or limitation, we haven't seen it elsewhere I 
believe.
   
   Observed error (errorText:VM current state is : PowerOn. But VM should be in 
PowerOff state.) in test "test_04_change_offering_small" - VM is stopped, and 
followed by triggering _changeServiceForVirtualMachine_ API. Updated   test to 
confirm the VM 'Stopped' state and trigger the _changeServiceForVirtualMachine_ 
API.
   
   This above test failure/error is not related to the changes in this PR.
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] sureshanaparti commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)

2021-02-04 Thread GitBox


sureshanaparti commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-773176841


   @blueorangutan test centos7 vmware-67u3



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4304: Storage plugin for Dell EMC PowerFlex/ScaleIO (formerly VxFlexOS)

2021-02-04 Thread GitBox


blueorangutan commented on pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#issuecomment-773177213


   @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has 
been kicked to run smoke tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run

2021-02-04 Thread GitBox


blueorangutan commented on pull request #4150:
URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-773163583


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4150: [HEALTH][4.14] Health Check Run

2021-02-04 Thread GitBox


rhtyd commented on pull request #4150:
URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-773162759


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd closed pull request #4150: [HEALTH][4.14] Health Check Run

2021-02-04 Thread GitBox


rhtyd closed pull request #4150:
URL: https://github.com/apache/cloudstack/pull/4150


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host

2021-02-04 Thread GitBox


blueorangutan commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-773160950


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host

2021-02-04 Thread GitBox


rhtyd commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-773160322


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on issue #4594: The network documentation contains dangling hyperlinks.

2021-02-04 Thread GitBox


rhtyd commented on issue #4594:
URL: https://github.com/apache/cloudstack/issues/4594#issuecomment-773159976


   Closing based on https://github.com/apache/cloudstack-documentation/pull/184 
@vladimirpetrov pl check, re-open if you see something we've missed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd closed issue #4594: The network documentation contains dangling hyperlinks.

2021-02-04 Thread GitBox


rhtyd closed issue #4594:
URL: https://github.com/apache/cloudstack/issues/4594


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[cloudstack-documentation] branch 4.14 updated: fix dangling links (#184)

2021-02-04 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.14
in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git


The following commit(s) were added to refs/heads/4.14 by this push:
 new 81e1718  fix dangling links (#184)
81e1718 is described below

commit 81e171868a5e1498114c45dabafbd751618ad546
Author: Abhishek Kumar 
AuthorDate: Thu Feb 4 14:51:43 2021 +0530

fix dangling links (#184)

Signed-off-by: Abhishek Kumar 
Co-authored-by: dahn 
---
 source/adminguide/networking.rst   | 24 +---
 source/adminguide/systemvm.rst |  2 +-
 source/adminguide/virtual_machines.rst |  6 +++---
 3 files changed, 17 insertions(+), 15 deletions(-)

diff --git a/source/adminguide/networking.rst b/source/adminguide/networking.rst
index b8dd66d..3fe59c6 100644
--- a/source/adminguide/networking.rst
+++ b/source/adminguide/networking.rst
@@ -60,7 +60,7 @@ account. Isolated networks have the following properties.
entire network
 
 For more information, see `“Configure Guest Traffic in an Advanced Zone” 
-`_.
+`_.
 
 
 Shared Networks
@@ -85,7 +85,7 @@ Basic zones in CloudStack 3.0.3 and later versions.
 -  Source NAT per zone is not supported in Shared Network when the
service provider is virtual router. However, Source NAT per account
is supported. For information, see `“Configuring a Shared Guest 
-   Network” `_.
+   Network” `_.
 
 
 L2 Networks
@@ -271,7 +271,7 @@ To create a network offering:
   or not. The network that you can provision without having to
   deploy a VM on it is termed persistent network. For more
   information, see `“Persistent
-  Networks” `_.
+  Networks” `_.
 
-  **Specify VLAN**. (Isolated guest networks only) Indicate whether
   a VLAN could be specified when this offering is used. If you
@@ -284,7 +284,7 @@ To create a network offering:
   isolated part of CloudStack. A VPC can have its own virtual
   network topology that resembles a traditional physical network.
   For more information on VPCs, see `“About Virtual
-  Private Clouds” `_.
+  Private Clouds” 
`_.
 
-  **Supported Services**. Select one or more of the possible network
   services. For some services, you must also choose the service
@@ -302,8 +302,10 @@ To create a network offering:
   === 
 
= =
   Supported Services  Description  
Isolated  Shared   
   === 
 
= =
-  DHCPFor more information, see `“DNS and DHCP” 
`_. Supported Supported
-  DNS For more information, see `“DNS and DHCP” 
`_. Supported Supported
+  DHCPFor more information, see `“DNS and  
Supported Supported
+  DHCP” `_.
+  DNS For more information, see `“DNS and  
Supported Supported
+  DHCP”  `_.
   Load Balancer   If you select Load Balancer, you can choose the 
CloudStack virtual   Supported Supported
   router or any other load balancers that have been 
configured in
   the cloud.
@@ -318,13 +320,13 @@ To create a network offering:
   virtual router or any other Port Forwarding 
providers that have
   been configured in the cloud.
   VPN For more information, see `“Remote Access
Supported Not Supported
-  VPN” `_.
+  VPN” 
`_.
   User Data   For more information, see `“User Data and Meta   
Not Supported Supported
   Data” `_.
-  Network ACL For more information, see `“Configuring Network 
Access   Supported Not Supported
-  Control List” 
`_.
+  Network ACL For more information, see `“Configuring Network 
Access Control List  Supported Not Supported
+  ” 
`_.
   Security Groups For more information, see `“Adding a Security
Not Supported Supported
-  Group” `_.
+  Group” 
`_.
   === 
 
= =
 
 
@@ -385,7 +387,7 @@ To create a network offering:
   -  Elastic IP is enabled.
 
   For information on Elastic IP, see `“About Elastic IP” 
-  `_.
+

[GitHub] [cloudstack] rhtyd commented on pull request #4644: [WIP] server: destroy ssvm, cpvm on last host maintenance

2021-02-04 Thread GitBox


rhtyd commented on pull request #4644:
URL: https://github.com/apache/cloudstack/pull/4644#issuecomment-773156790


   Edge case, not critical issue moved to next milestone.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on issue #3719: VMware: SystemVMs not cleared after forcing them to stop

2021-02-04 Thread GitBox


rhtyd commented on issue #3719:
URL: https://github.com/apache/cloudstack/issues/3719#issuecomment-773156653


   Edge case, not critical issue moved to next milestone.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4588: Enable SNI in SSVM

2021-02-04 Thread GitBox


rhtyd commented on pull request #4588:
URL: https://github.com/apache/cloudstack/pull/4588#issuecomment-773155445


   Moved to next milestone, needs several round of multi-zone testing.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[cloudstack] branch 4.14 updated (78f73c1 -> 4de6ac3)

2021-02-04 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch 4.14
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 78f73c1  server: Fix update capacity for hosts take long time if there 
are many service offerings (#4623)
 add 4de6ac3  server: Get vm network/disk statistics and update database 
per host (#4601)

No new revisions were added by this update.

Summary of changes:
 .../main/java/com/cloud/server/StatsCollector.java | 55 +++---
 1 file changed, 27 insertions(+), 28 deletions(-)



[GitHub] [cloudstack] rhtyd merged pull request #4601: server: Get vm network/disk statistics and update database per host

2021-02-04 Thread GitBox


rhtyd merged pull request #4601:
URL: https://github.com/apache/cloudstack/pull/4601


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[cloudstack] branch 4.14 updated: server: Fix update capacity for hosts take long time if there are many service offerings (#4623)

2021-02-04 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.14
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.14 by this push:
 new 78f73c1  server: Fix update capacity for hosts take long time if there 
are many service offerings (#4623)
78f73c1 is described below

commit 78f73c1bc631fdba997fe19d44cdd0ea58243e11
Author: Wei Zhou 
AuthorDate: Thu Feb 4 10:13:57 2021 +0100

server: Fix update capacity for hosts take long time if there are many 
service offerings (#4623)

Steps to reproduce the issue:

(1)Create 1 service offerings (by db changes below or cloudmonkey).

```
DROP PROCEDURE IF EXISTS cloud.insert_service_offering;

DELIMITER $$
CREATE PROCEDURE cloud.insert_service_offering()
BEGIN
  DECLARE count INT DEFAULT 1;
  SET @offeringid = (select max(id)+1 from disk_offering);

  WHILE count > 0 DO
INSERT INTO disk_offering 
(id,name,uuid,display_text,disk_size,type,created) values 
(@offeringid,'test-offering-wei',uuid(), 'test-offering-wei',0,'Service',now());
INSERT INTO service_offering (id,cpu,speed,ram_size) values 
(@offeringid, 1, 500,256);
SET @offeringid = @offeringid + 1;
SET count = count - 1;
  END WHILE;
END $$
DELIMITER ;

CALL cloud.insert_service_offering();

mysql> CALL cloud.insert_service_offering();
Query OK, 0 rows affected (2 min 30.85 sec)
```

(2) Check the total time of periodical capacity check in cloudstack.

Without this patch, it spend 2.5 seconds (2 hosts)
```
2021-01-15 16:10:12,793 DEBUG [c.c.a.AlertManagerImpl] 
(CapacityChecker:ctx-5d5f3b3b) (logid:f5eb68ba) Running Capacity Checker ...
2021-01-15 16:10:15,287 DEBUG [c.c.a.AlertManagerImpl] 
(CapacityChecker:ctx-5d5f3b3b) (logid:f5eb68ba) Done running Capacity Checker 
...
```

With this patch ,it spend 1.3 seconds (2 hosts)
```
2021-01-15 16:12:43,604 DEBUG [c.c.a.AlertManagerImpl] 
(CapacityChecker:ctx-a2a7f3f1) (logid:f7e0a4c5) Running Capacity Checker ...
2021-01-15 16:12:44,927 DEBUG [c.c.a.AlertManagerImpl] 
(CapacityChecker:ctx-a2a7f3f1) (logid:f7e0a4c5) Done running Capacity Checker 
...
```

If there are 100 hosts, the total time will be reduced from 100+ seconds to 
around 10 seconds.
---
 .../src/main/java/com/cloud/capacity/CapacityManager.java|  5 +
 server/src/main/java/com/cloud/alert/AlertManagerImpl.java   | 12 +++-
 .../main/java/com/cloud/capacity/CapacityManagerImpl.java| 11 +++
 3 files changed, 27 insertions(+), 1 deletion(-)

diff --git 
a/engine/components-api/src/main/java/com/cloud/capacity/CapacityManager.java 
b/engine/components-api/src/main/java/com/cloud/capacity/CapacityManager.java
index 98287bb..8827ca4 100644
--- 
a/engine/components-api/src/main/java/com/cloud/capacity/CapacityManager.java
+++ 
b/engine/components-api/src/main/java/com/cloud/capacity/CapacityManager.java
@@ -16,10 +16,13 @@
 // under the License.
 package com.cloud.capacity;
 
+import java.util.Map;
+
 import org.apache.cloudstack.framework.config.ConfigKey;
 import org.apache.cloudstack.storage.datastore.db.StoragePoolVO;
 
 import com.cloud.host.Host;
+import com.cloud.service.ServiceOfferingVO;
 import com.cloud.storage.VMTemplateVO;
 import com.cloud.vm.VirtualMachine;
 
@@ -99,6 +102,8 @@ public interface CapacityManager {
 
 void updateCapacityForHost(Host host);
 
+void updateCapacityForHost(Host host, Map 
offeringsMap);
+
 /**
  * @param pool storage pool
  * @param templateForVmCreation template that will be used for vm creation
diff --git a/server/src/main/java/com/cloud/alert/AlertManagerImpl.java 
b/server/src/main/java/com/cloud/alert/AlertManagerImpl.java
index 5a7a8b4..75b8cc7 100644
--- a/server/src/main/java/com/cloud/alert/AlertManagerImpl.java
+++ b/server/src/main/java/com/cloud/alert/AlertManagerImpl.java
@@ -75,6 +75,8 @@ import com.cloud.host.HostVO;
 import com.cloud.network.dao.IPAddressDao;
 import com.cloud.org.Grouping.AllocationState;
 import com.cloud.resource.ResourceManager;
+import com.cloud.service.ServiceOfferingVO;
+import com.cloud.service.dao.ServiceOfferingDao;
 import com.cloud.storage.StorageManager;
 import com.cloud.utils.NumbersUtil;
 import com.cloud.utils.component.ManagerBase;
@@ -121,6 +123,8 @@ public class AlertManagerImpl extends ManagerBase 
implements AlertManager, Confi
 private ConfigurationManager _configMgr;
 @Inject
 protected ConfigDepot _configDepot;
+@Inject
+ServiceOfferingDao _offeringsDao;
 
 private Timer _timer = null;
 private long _capacityCheckPeriod = 60L * 60L * 1000L; // One hour by 
default.
@@ -275,8 +279,14 @@ public class AlertManagerImpl extends ManagerBase 
implements AlertManager, Confi
 // get all hosts...even if they are not 

[GitHub] [cloudstack] rhtyd merged pull request #4623: server: Fix update capacity for hosts take long time if there are many service offerings

2021-02-04 Thread GitBox


rhtyd merged pull request #4623:
URL: https://github.com/apache/cloudstack/pull/4623


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4627: VR: fix expunging vm will remove dhcp entries of another vm in VR

2021-02-04 Thread GitBox


rhtyd commented on pull request #4627:
URL: https://github.com/apache/cloudstack/pull/4627#issuecomment-773150101


   @shwstppr can you test with Ubuntu 18.04 and see if that helps? 
@weizhouapache is the env adv zone or adv zone with SG, or some other 
permutation?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4646: Add global settings for VM migration flags

2021-02-04 Thread GitBox


DaanHoogland commented on a change in pull request #4646:
URL: https://github.com/apache/cloudstack/pull/4646#discussion_r570051942



##
File path: 
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##
@@ -422,6 +426,13 @@
 "Indicates whether the host in down state can be put 
into maintenance state so thats its not enabled after it comes back.",
 true, ConfigKey.Scope.Zone, null);
 
+protected final ConfigKey KvmVmMigrateSpeed = new 
ConfigKey<>("Advanced", Integer.class, KVM_VM_MIGRATE_SPEED, "-1",
+"set the vm migrate speed (in MiB/s) on KVM. By default, it will 
try to guess the speed of the guest network (in MBps).", true);
+protected final ConfigKey KvmVmMigrateDowntime = new 
ConfigKey<>("Advanced", Integer.class, KVM_VM_MIGRATE_DOWNTIME, "-1",
+"Sets maximum tolerable time in milliseconds for which the domain 
is allowed to be paused at the end of live migration on KVM.", true);
+protected final ConfigKey KvmVmMigratePauseAfter = new 
ConfigKey<>("Advanced", Integer.class, KVM_VM_MIGRATE_PAUSE_AFTER, "-1",
+"Set an upper limit in milliseconds for how long live migration on 
KVM should wait, at which point VM is paused and migration will finish quickly. 
 Less than 1 means disabled.", true);
+

Review comment:
   these belong in the hypervisor plugin for KVM, not here.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] soreana opened a new pull request #4649: add creation date as a value for domains and accounts.

2021-02-04 Thread GitBox


soreana opened a new pull request #4649:
URL: https://github.com/apache/cloudstack/pull/4649


   ### Description
   
   This PR enables the cloudstack to store the creation time of accounts and 
domains. We already implemented and used this feature in our platforms. We 
thought it might be useful for the community too. 
   
   The changes in this PR are as small as adding some fields and the 
setter/getter method. Although the database changes might seem scary, they are 
minor changes. Except defining the `add_created_column_in_domain_and_account` 
procedure, I only added the following lines in `account_view` and 
`domain_view`. Generally speaking, in the mentioned procedure, I added the 
`created` column to the `account` and `domain` tables, and I ignore its 
creation if they have already existed.
   
   ```
   `account`.`created` AS `created`,
   ...
   `domain`.`created` AS `created`,
   ```
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   
   
   
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] weizhouapache commented on issue #4637: Kubernetes cluster creation Error - Kubernetes cluster kubeconfig not available currently in Isolated Network

2021-02-04 Thread GitBox


weizhouapache commented on issue #4637:
URL: https://github.com/apache/cloudstack/issues/4637#issuecomment-773131690


   > @shwstppr Per your last comment - Management Server needs to be able to 
SSH to VMs through VR.
   > That means Management Server needs to be able to connect to VR (and vice 
versa).
   > FYI - I have limited understanding of how that communication needs to 
happen, and I am trying to learn here, so excuse my silly question...
   > 
   > If the Management server sits on its own VLAN with a single NIC, the VR is 
on its own VLAN (its created as an Isolated Network by default, which gets its 
own VLAN) , Both have Internet connectivity, but the VR is not exposed (meaning 
the Public IP assigned is just another VLAN), how would they ever be able to 
communicate? Secondly, dosen't that introduce a huge security risk if the 
network is accessible from the VR (and hence any VM on that VR) to Management 
server?
   > 
   > Again, I do not know if my assumption here is completely off, so please 
correct/explain as needed
   > 
   > EDIT  I Think I answered my own question after some more research... 
The Management server connects to the Virtualization Host (XCP-ng in my case), 
and uses the "ssh -i /root/.ssh/id_rsa.cloud -p 3922 root@LinkLocal" to get 
into the VR
   > 
   > NOTE #2 -- In #4639 I added more details of my testing with the new build 
you provided. However it still failed. Here is a link for ease -- [#4639 
(comment)](https://github.com/apache/cloudstack/pull/4639#issuecomment-773014094)
   
   @nxsbi as far as I know, when kubernetes cluster is created, some port 
forwarding rules are added for vms in the cluster. for example, 
   VR public IP: -> master
   VR public IP:2223 -> node-1
   VR public IP:2224 -> node-2
   
   mgt server connects to kubernetes master/nodes via the VR public IP and 
ports above, not linklocal IP.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] nxsbi commented on pull request #4639: cks: use HttpsURLConnection for checking api server

2021-02-04 Thread GitBox


nxsbi commented on pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#issuecomment-773117724


   @shwstppr 
   > cat /var/log/cloudstack/management/management-server.log | grep -i 4ac48e69
   
   Here it is. I have cleansed the log for IP, passwords, Keys etc. so you may 
see X.. For IP I only changed the management LAN IPs and external IPs. You 
will see them as 192.168.100.XXX where XXX is the actual last bit of correct IP 
or  as 172.100.100.100
   
[mgmt-4ac48e69cleansed.log](https://github.com/apache/cloudstack/files/5924132/mgmt-4ac48e69cleansed.log)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org