[GitHub] [cloudstack] shwstppr commented on issue #6593: Problem With Separating Traffic Type for vmware host in Cloudstack UI

2022-08-04 Thread GitBox


shwstppr commented on issue #6593:
URL: https://github.com/apache/cloudstack/issues/6593#issuecomment-1206050372

   Fixed with #6612 
   Please reopen if you face this again after the fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] shwstppr closed issue #6593: Problem With Separating Traffic Type for vmware host in Cloudstack UI

2022-08-04 Thread GitBox


shwstppr closed issue #6593: Problem With Separating Traffic Type for vmware 
host in Cloudstack UI
URL: https://github.com/apache/cloudstack/issues/6593


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[cloudstack] branch 4.17 updated: ui: fix hypervisortrafficlabel for phy nw traffic (#6612)

2022-08-04 Thread shwstppr
This is an automated email from the ASF dual-hosted git repository.

shwstppr pushed a commit to branch 4.17
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.17 by this push:
 new 167cd17d7c ui: fix hypervisortrafficlabel for phy nw traffic (#6612)
167cd17d7c is described below

commit 167cd17d7c39d0529f076a33d4a59c2e08c9cb1b
Author: Abhishek Kumar 
AuthorDate: Fri Aug 5 10:42:13 2022 +0530

ui: fix hypervisortrafficlabel for phy nw traffic (#6612)

Fixes: #6593

Before fix UI was setting vlan to 'null' when no value was passed. Now it 
just leaves the vlan value empty in the trafficlabel.

Signed-off-by: Abhishek Kumar 
---
 ui/src/views/infra/zone/ZoneWizardLaunchZone.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui/src/views/infra/zone/ZoneWizardLaunchZone.vue 
b/ui/src/views/infra/zone/ZoneWizardLaunchZone.vue
index 7f23c3b643..1fd8e49abf 100644
--- a/ui/src/views/infra/zone/ZoneWizardLaunchZone.vue
+++ b/ui/src/views/infra/zone/ZoneWizardLaunchZone.vue
@@ -248,7 +248,7 @@ export default {
 if (trafficLabel.length > 0) {
   trafficLabel += ','
 }
-trafficLabel += trafficConfig.vlanId
+trafficLabel += trafficConfig.vlanId || ''
   }
   if ('vSwitchType' in trafficConfig) {
 if (trafficLabel.length > 0) {



[GitHub] [cloudstack] shwstppr merged pull request #6612: ui: fix hypervisortrafficlabel for phy nw traffic

2022-08-04 Thread GitBox


shwstppr merged PR #6612:
URL: https://github.com/apache/cloudstack/pull/6612


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details

2022-08-04 Thread GitBox


blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1205908067

   Trillian test result (tid-4621)
   Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 39638 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6276-t4621-vmware-70u3.zip
   Smoke tests completed. 100 look OK, 1 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_deploy_vm_from_iso | `Error` | 7.84 | test_deploy_vm_iso.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] jbampton commented on pull request #6273: Add `pre-commit` workflow with 3 Git hooks

2022-08-04 Thread GitBox


jbampton commented on PR #6273:
URL: https://github.com/apache/cloudstack/pull/6273#issuecomment-120583

   Hey @DaanHoogland  best practice is to use only one type of line ending in a 
project.
   
   From the prettier site:
   
   "When people collaborate on a project from different operating systems, it 
becomes easy to end up with mixed line endings in a shared git repository. It 
is also possible for Windows users to accidentally change line endings in a 
previously committed file from LF to CRLF. Doing so produces a large git diff 
and thus makes the line-by-line history for a file (git blame) harder to 
explore."
   
   https://prettier.io/docs/en/options.html#end-of-line


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6581: [Veeam] enable volume attach/detach in VMs with Backup Offerings

2022-08-04 Thread GitBox


blueorangutan commented on PR #6581:
URL: https://github.com/apache/cloudstack/pull/6581#issuecomment-1205810178

   Trillian test result (tid-4619)
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 43275 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6581-t4619-vmware-67u3.zip
   Smoke tests completed. 100 look OK, 1 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 0.01 | 
test_kubernetes_clusters.py
   test_02_upgrade_kubernetes_cluster | `Failure` | 0.01 | 
test_kubernetes_clusters.py
   test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.01 | 
test_kubernetes_clusters.py
   test_04_autoscale_kubernetes_cluster | `Failure` | 0.01 | 
test_kubernetes_clusters.py
   test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 0.01 | 
test_kubernetes_clusters.py
   test_06_delete_kubernetes_cluster | `Failure` | 0.01 | 
test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.01 | 
test_kubernetes_clusters.py
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.01 | 
test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.01 | 
test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6282: [Veeam] restored VMs without NICs

2022-08-04 Thread GitBox


blueorangutan commented on PR #6282:
URL: https://github.com/apache/cloudstack/pull/6282#issuecomment-1205729989

   Trillian test result (tid-4612)
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 45229 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6282-t4612-vmware-67u3.zip
   Smoke tests completed. 100 look OK, 1 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_03_ping_in_ssvm_success | `Failure` | 14.44 | test_diagnostics.py
   test_08_arping_in_ssvm | `Failure` | 5.17 | test_diagnostics.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6460: Add new parameter to createLoadBalancerRule API

2022-08-04 Thread GitBox


blueorangutan commented on PR #6460:
URL: https://github.com/apache/cloudstack/pull/6460#issuecomment-1205700197

   Trillian test result (tid-4618)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 37051 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6460-t4618-kvm-centos7.zip
   Smoke tests completed. 101 look OK, 0 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] ahmadamirahmadi007 commented on issue #6601: apache apidocs FAILURE in Build From Source

2022-08-04 Thread GitBox


ahmadamirahmadi007 commented on issue #6601:
URL: https://github.com/apache/cloudstack/issues/6601#issuecomment-1205683384

   
![pythonver](https://user-images.githubusercontent.com/104001728/182936727-5d3d8d77-7537-4c02-b5aa-611b4a5859d3.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6491: Add live migration of system VMs

2022-08-04 Thread GitBox


blueorangutan commented on PR #6491:
URL: https://github.com/apache/cloudstack/pull/6491#issuecomment-1205659265

   Trillian test result (tid-4615)
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 39770 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6491-t4615-vmware-65u2.zip
   Smoke tests completed. 101 look OK, 0 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6491: Add live migration of system VMs

2022-08-04 Thread GitBox


blueorangutan commented on PR #6491:
URL: https://github.com/apache/cloudstack/pull/6491#issuecomment-1205654849

   Trillian test result (tid-4613)
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 39371 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6491-t4613-xenserver-71.zip
   Smoke tests completed. 101 look OK, 0 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6491: Add live migration of system VMs

2022-08-04 Thread GitBox


blueorangutan commented on PR #6491:
URL: https://github.com/apache/cloudstack/pull/6491#issuecomment-1205651310

   Trillian test result (tid-4614)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 39017 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6491-t4614-kvm-centos7.zip
   Smoke tests completed. 101 look OK, 0 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #5909: Quota custom tariffs

2022-08-04 Thread GitBox


sonarcloud[bot] commented on PR #5909:
URL: https://github.com/apache/cloudstack/pull/5909#issuecomment-1205646479

   SonarCloud Quality Gate failed.  [![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate 
failed')](https://sonarcloud.io/dashboard?id=apache_cloudstack=5909)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack=5909=false=BUG)
 
[![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png
 
'E')](https://sonarcloud.io/project/issues?id=apache_cloudstack=5909=false=BUG)
 [4 
Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=5909=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack=5909=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=5909=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=5909=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=5909=false=SECURITY_HOTSPOT)
 
[![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png
 
'E')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=5909=false=SECURITY_HOTSPOT)
 [2 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=5909=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack=5909=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=5909=false=CODE_SMELL)
 [64 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=5909=false=CODE_SMELL)
   
   
[![42.3%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/40-16px.png
 
'42.3%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=5909=new_coverage=list)
 [42.3% 
Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=5909=new_coverage=list)
  
   
[![0.5%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.5%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=5909=new_duplicated_lines_density=list)
 [0.5% 
Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=5909=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] GutoVeronezi commented on issue #5891: Quota: custom tariffs

2022-08-04 Thread GitBox


GutoVeronezi commented on issue #5891:
URL: https://github.com/apache/cloudstack/issues/5891#issuecomment-1205593607

   As explained the issue description, we choose [J2V8] to be our JS engine 
based on its relevance, performance and implementation; However, we faced a 
dependency on a GCC version higher or equal to 4.9. CentOS7, by default, is 
shipped with GCC 4.8, therefore, to build the packages we would need to build a 
newer GCC version and install it. In order to avoid this barrier, we searched 
for another JS engine and found [Nashorn Engine] (standalone). 
   
   "The Nashorn JavaScript engine was first incorporated into JDK 8 via [JEP 
174] as a replacement for the Rhino scripting engine" ([JEP 372]). Due to the 
rapid pace of development of ECMAScript, the community found Nashorn 
challenging to maintain. Then, in JDK 11, they started the engine deprecation 
([JEP 335]). After that, the OpenJDK community created a standalone version of 
the [Nashorn Engine], which is available for JDK 11 and after.
   
   Currently, ACS is developed under JDK 11, which still has the engine as 
built-in; however, looking at future compatibility, we decided to use the 
standalone [Nashorn Engine] version.
   
   [Nashorn Engine] (standalone) will attend our necessities with JS processing 
inside Java, allowing users to write rules for Quota tariffs, equally as we 
achieved with [J2V8].
   
   
   [J2V8]: https://github.com/eclipsesource/J2V8
   [Nashorn Engine]: https://github.com/openjdk/nashorn
   [JEP 174]: https://openjdk.org/jeps/174
   [JEP 335]: https://openjdk.org/jeps/335
   [JEP 372]: https://openjdk.org/jeps/372
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] GutoVeronezi commented on pull request #5909: Quota custom tariffs

2022-08-04 Thread GitBox


GutoVeronezi commented on PR #5909:
URL: https://github.com/apache/cloudstack/pull/5909#issuecomment-1205592600

   As explained in #5891, we choose [J2V8] to be our JS engine based on its 
relevance, performance and implementation; However, we faced a dependency on a 
GCC version higher or equal to 4.9. CentOS7, by default, is shipped with GCC 
4.8, therefore, to build the packages we would need to build a newer GCC 
version and install it. In order to avoid this barrier, we searched for another 
JS engine and found [Nashorn Engine] (standalone) (which has a similar 
performance compared to [J2V8]). 
   
   "The Nashorn JavaScript engine was first incorporated into JDK 8 via [JEP 
174] as a replacement for the Rhino scripting engine" ([JEP 372]). Due to the 
rapid pace of development of ECMAScript, the community found Nashorn 
challenging to maintain. Then, in JDK 11, they started the engine deprecation 
([JEP 335]). After that, the OpenJDK community created a standalone version of 
the [Nashorn Engine], which is available for JDK 11 and after.
   
   Currently, ACS is developed under JDK 11, which still has the engine as 
built-in; however, looking at future compatibility, we decided to use the 
standalone [Nashorn Engine] version.
   
   [Nashorn Engine] (standalone) will attend our necessities with JS processing 
inside Java, allowing users to write rules for Quota tariffs, equally as we 
achieved with [J2V8].
   
   
   [J2V8]: https://github.com/eclipsesource/J2V8
   [Nashorn Engine]: https://github.com/openjdk/nashorn
   [JEP 174]: https://openjdk.org/jeps/174
   [JEP 335]: https://openjdk.org/jeps/335
   [JEP 372]: https://openjdk.org/jeps/372
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] xuanyuanaosheng commented on issue #6614: can not create VM In this situation

2022-08-04 Thread GitBox


xuanyuanaosheng commented on issue #6614:
URL: https://github.com/apache/cloudstack/issues/6614#issuecomment-1205360609

   I am using the template:
   
   
![image](https://user-images.githubusercontent.com/4197714/182876676-76465fc0-e607-44c4-a8ac-a74fb9fa335f.png)
   
   It is has the **Direct Download** option


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] slavkap commented on issue #6614: can not create VM In this situation

2022-08-04 Thread GitBox


slavkap commented on issue #6614:
URL: https://github.com/apache/cloudstack/issues/6614#issuecomment-1205320379

   @xuanyuanaosheng, can you confirm that you're trying to deploy a VM with a 
direct download template? If so, this is not supported for Ceph storage.
   [enhancment request](https://github.com/apache/cloudstack/issues/3065)
   [info for Direct download 
feature](https://www.shapeblue.com/cloudstack-feature-first-look-direct-download-agnostic-of-the-storage-provider/)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6589: [Veeam] disable jobs but keep backups

2022-08-04 Thread GitBox


blueorangutan commented on PR #6589:
URL: https://github.com/apache/cloudstack/pull/6589#issuecomment-1205278322

   Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 
:heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 3908


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6587: Updated resource counter to include correct size after volume creation/resize and other improvements

2022-08-04 Thread GitBox


blueorangutan commented on PR #6587:
URL: https://github.com/apache/cloudstack/pull/6587#issuecomment-1205277521

   Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 
:heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 3907


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6550: Emc networker b

2022-08-04 Thread GitBox


blueorangutan commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1205277141

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 
:heavy_check_mark: debian :heavy_check_mark: suse15. LL-JID 96


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6386: [VMWare] Limit IOPS in Compute/Disk Offerings

2022-08-04 Thread GitBox


blueorangutan commented on PR #6386:
URL: https://github.com/apache/cloudstack/pull/6386#issuecomment-1205256929

   Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 
:heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 3906


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] joseflauzino commented on pull request #6401: VM stats history visualization

2022-08-04 Thread GitBox


joseflauzino commented on PR #6401:
URL: https://github.com/apache/cloudstack/pull/6401#issuecomment-1205250409

   @rohityadavcloud 
   
   > How does the backend API/DB handle as the data grows - my concern is if 
this would always grow with time and create issues we perhaps hit like with the 
usage server (I understand they are not in this PR but the feature)
   
   The amount of data that is kept in the database is controlled by the cloud 
administrators. This can be done through the global configuration 
`vm.stats.max.retention.time`, which was created in PR #5984 (please, in spec 
#5935, see sections 
[2.2](https://github.com/apache/cloudstack/issues/5935#2-proposed-changes--22-configuration-proposal)
 and 
[2.3](https://github.com/apache/cloudstack/issues/5935#2-proposed-changes--23-data-cleaning-proposal)
 for details).
   
   > Is this framework expandable to other resources such as volumes, systemvms 
and virtual routers?
   
   At the code level we would need to analyze how much it would be reusable. 
But for sure, at the very least, the idea (including the design and some logics 
of the code) can be extended to the other resources/elements.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] joseflauzino commented on pull request #6401: VM stats history visualization

2022-08-04 Thread GitBox


joseflauzino commented on PR #6401:
URL: https://github.com/apache/cloudstack/pull/6401#issuecomment-1205247188

   Thanks for the tests and review, @shwstppr .
   
   I'll test your suggestions soon.
   
   About the possible improvements you commented on:
   
   > default time period could be used the current time minus stats retention 
time. This is just my opinion. It will give better UX as user will see some 
stats when view is opened first.
   
   Depending on the data retention settings and the amount of VM instances in 
the cloud, using the current time minus the retention time can bring in a 
massive amount of data. So the delay in loading the VM stats could be very 
large when accessing this view. The idea of filtering by the last hour of 
available data when accessing this view is safer for this initial version. 
Maybe in the future, we can think of something more elaborate based on feedback 
from ACS users.
   
   > Something for future maybe, functionality could be extended to other 
system vms and VRs as well. Or maybe other resources too.
   
   I think so too! In the future it would be nice to have this for system VMs 
and other cloud resources.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] xuanyuanaosheng opened a new issue, #6614: can not create VM In this situation

2022-08-04 Thread GitBox


xuanyuanaosheng opened a new issue, #6614:
URL: https://github.com/apache/cloudstack/issues/6614

   # ISSUE TYPE
   
* Bug Report
   
   
   # CLOUDSTACK VERSION
   1.  CloudStack 4.15.2.0
   2.  ceph version 15.2.16
   3.  cloudstack agent os version: Oracle Linux Server 8.3
   
   
   The cloudstack env using the Ceph RBD and  local storage as cloudstack 
cluster primary storage.
   
   
![image](https://user-images.githubusercontent.com/4197714/182854368-7455cfc0-39e2-44a9-a71b-5fd8cff51d9c.png)
   
   The cloudstack agent host info:
   ```
   # rpm -qa | grep libvirt
   libvirt-daemon-6.0.0-37.1.0.1.module+el8.5.0+20490+52363fdb.x86_64
   
libvirt-daemon-driver-storage-iscsi-6.0.0-37.1.0.1.module+el8.5.0+20490+52363fdb.x86_64
   
libvirt-daemon-driver-nwfilter-6.0.0-37.1.0.1.module+el8.5.0+20490+52363fdb.x86_64
   
libvirt-daemon-driver-storage-mpath-6.0.0-37.1.0.1.module+el8.5.0+20490+52363fdb.x86_64
   libvirt-daemon-kvm-6.0.0-37.1.0.1.module+el8.5.0+20490+52363fdb.x86_64
   
libvirt-daemon-config-network-6.0.0-37.1.0.1.module+el8.5.0+20490+52363fdb.x86_64
   libvirt-dbus-1.3.0-2.module+el8.3.0+7860+a7792d29.x86_64
   
libvirt-daemon-driver-interface-6.0.0-37.1.0.1.module+el8.5.0+20490+52363fdb.x86_64
   
libvirt-daemon-config-nwfilter-6.0.0-37.1.0.1.module+el8.5.0+20490+52363fdb.x86_64
   
libvirt-daemon-driver-storage-rbd-6.0.0-37.1.0.1.module+el8.5.0+20490+52363fdb.x86_64
   libvirt-nss-6.0.0-37.1.0.1.module+el8.5.0+20490+52363fdb.x86_64
   libvirt-gobject-3.0.0-1.el8.x86_64
   libvirt-gconfig-3.0.0-1.el8.x86_64
   libvirt-libs-6.0.0-37.1.0.1.module+el8.5.0+20490+52363fdb.x86_64
   
libvirt-daemon-driver-secret-6.0.0-37.1.0.1.module+el8.5.0+20490+52363fdb.x86_64
   
libvirt-daemon-driver-storage-gluster-6.0.0-37.1.0.1.module+el8.5.0+20490+52363fdb.x86_64
   libvirt-docs-6.0.0-37.1.0.1.module+el8.5.0+20490+52363fdb.x86_64
   python3-libvirt-6.0.0-1.module+el8.3.0+7860+a7792d29.x86_64
   
libvirt-daemon-driver-qemu-6.0.0-37.1.0.1.module+el8.5.0+20490+52363fdb.x86_64
   
libvirt-daemon-driver-storage-disk-6.0.0-37.1.0.1.module+el8.5.0+20490+52363fdb.x86_64
   
libvirt-daemon-driver-storage-6.0.0-37.1.0.1.module+el8.5.0+20490+52363fdb.x86_64
   libvirt-devel-6.0.0-37.1.0.1.module+el8.5.0+20490+52363fdb.x86_64
   
libvirt-daemon-driver-storage-core-6.0.0-37.1.0.1.module+el8.5.0+20490+52363fdb.x86_64
   
libvirt-daemon-driver-storage-iscsi-direct-6.0.0-37.1.0.1.module+el8.5.0+20490+52363fdb.x86_64
   libvirt-6.0.0-37.1.0.1.module+el8.5.0+20490+52363fdb.x86_64
   libvirt-bash-completion-6.0.0-37.1.0.1.module+el8.5.0+20490+52363fdb.x86_64
   libvirt-lock-sanlock-6.0.0-37.1.0.1.module+el8.5.0+20490+52363fdb.x86_64
   libvirt-glib-3.0.0-1.el8.x86_64
   libvirt-client-6.0.0-37.1.0.1.module+el8.5.0+20490+52363fdb.x86_64
   libvirt-admin-6.0.0-37.1.0.1.module+el8.5.0+20490+52363fdb.x86_64
   
libvirt-daemon-driver-network-6.0.0-37.1.0.1.module+el8.5.0+20490+52363fdb.x86_64
   
libvirt-daemon-driver-storage-logical-6.0.0-37.1.0.1.module+el8.5.0+20490+52363fdb.x86_64
   
libvirt-daemon-driver-nodedev-6.0.0-37.1.0.1.module+el8.5.0+20490+52363fdb.x86_64
   
libvirt-daemon-driver-storage-scsi-6.0.0-37.1.0.1.module+el8.5.0+20490+52363fdb.x86_64
   
   
   # rpm -qa | grep cloudstack
   cloudstack-agent-4.15.2.0-1.el8.x86_64
   cloudstack-common-4.15.2.0-1.el8.x86_64
   
   # rpm -qa | grep ceph
   python3-ceph-argparse-15.2.16-0.el8.x86_64
   python3-ceph-common-15.2.16-0.el8.x86_64
   python3-cephfs-15.2.16-0.el8.x86_64
   libcephfs2-15.2.16-0.el8.x86_64
   ceph-common-15.2.16-0.el8.x86_64
   
   # virsh list
Id   Name State
   
1v-25921-VM   running
2s-25922-VM   running
3r-25817-VM   running
   
   
   ```
   
   The virsh pool seems ok
   ```
   # virsh pool-list
Name   StateAutostart
   
0edb0e58-6b90-3bee-8e7b-13007b0f7bf9   active   no
b4fb50ca-79f2-46ba-bd1b-092f9bd14d4e   active   no
   
   ```
   
   
![image](https://user-images.githubusercontent.com/4197714/182855742-f2e641a5-3f18-4745-9d97-bc365f613d81.png)
   
   
   The system VM and virtual routers VM status seems OK:
   
   
![image](https://user-images.githubusercontent.com/4197714/182855152-6c63af1e-ad1c-4e40-86ed-aa3d0ef63c71.png)
   
   
   
![image](https://user-images.githubusercontent.com/4197714/182855335-e670bcdd-75ab-407b-b335-080dd30744fc.png)
   
   
   I can not create the VM:
   
   
![image](https://user-images.githubusercontent.com/4197714/182852918-4c0718dd-372d-49d6-aa3d-29c9fde40921.png)
   
   The details error:
   ```
   2022-08-04 18:06:37,920 DEBUG [cloud.agent.Agent] (Agent-Handler-4:null) 
(logid:) Received response: Seq 32-27:  { Ans: , MgmtId: 345052215515, via: 32, 
Ver: v
   1, Flags: 100010, 
[{"com.cloud.agent.api.PingAnswer":{"_command":{"hostType":"Routing","hostId":"32","wait":"0","bypassHostMaintenance":"false"},"result":"true
   

[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details

2022-08-04 Thread GitBox


blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1205223857

   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-70u3) has 
been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details

2022-08-04 Thread GitBox


DaanHoogland commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1205223291

   @blueorangutan test centos7 vmware-70u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6386: [VMWare] Limit IOPS in Compute/Disk Offerings

2022-08-04 Thread GitBox


blueorangutan commented on PR #6386:
URL: https://github.com/apache/cloudstack/pull/6386#issuecomment-1205221683

   @DaanHoogland a Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6386: [VMWare] Limit IOPS in Compute/Disk Offerings

2022-08-04 Thread GitBox


DaanHoogland commented on PR #6386:
URL: https://github.com/apache/cloudstack/pull/6386#issuecomment-1205221156

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] nvazquez opened a new issue, #6613: Improvement on administrator alerts

2022-08-04 Thread GitBox


nvazquez opened a new issue, #6613:
URL: https://github.com/apache/cloudstack/issues/6613

   # ISSUE TYPE
* Improvement Request
   
   # COMPONENT NAME
   ~~~
   Alerts
   ~~~
   
   # CLOUDSTACK VERSION
   ~~~
   4.16.1 and onwards
   ~~~
   
   # CONFIGURATION
   Use the default values for the configurations:
   - capacity.check.period : 30
   - alert.purge.delay : 0
   - alert.purge.interval : 86400
   - Define notification thresholds for cluster capacity: (for example 
cluster.storage.capacity.notificationthreshold : 0.75 )
   
   # OS / ENVIRONMENT
   N/A
   
   
   # SUMMARY
   The first time a cluster threshold is exceeded CloudStack notifies the 
administrator by sending an email and creates a record on the `alert` table. If 
the alert.purge.delay value is set to 0 (default value) then this record is 
never deleted, so the next time the threshold is exceeded the administrator 
does not get notified. CloudStack queries the database and searches for records 
on the `alert` table for the same alert type and cluster, and in case it finds 
an existing records it does not send the notification email.
   
   Example:
   
   DB:
   
   mysql> select * from alert where type = 3 and cluster_id = 1 and archived = 
false;
   
+---+--+--++++--++-+-+--+--+-+---+
   | id| uuid | type | cluster_id | pod_id 
| data_center_id | subject  
| sent_count | created  
   | last_sent   | resolved | archived | name| 
content 
  |
   
+---+--+--++++--++-+-+--+--+-+---+
   | 28623 | 885be044-4507-4a18-b71a-44af87ada1cf |3 |  1 |  1 
|  1 | System Alert: Remaining unallocated Storage is low in 
cluster BNZ-CL-001 pod BNZ-POD-01 of availability zone BNZ |  1 | 
2021-09-05 02:41:48 | 2021-09-05 02:41:48 | NULL |0 | 
ALERT.STORAGE.ALLOCATED | Unallocated storage space is low, total: 20971496 MB, 
allocated: 16332262 MB (77.88%) |
   
+---+--+--++++--++-+-+--+--+-+---+
   1 row in set (1.26 sec)
   
   
   Logs:
   
   2022-08-03 00:01:53,297 DEBUG [c.c.a.AlertManagerImpl] 
(CapacityChecker:ctx-166624fc) (logid:8e4ca7a5) System Alert: Remaining 
unallocated Storage is low in cluster BNZ-CL-001 pod BNZ-POD-01 of availability 
zone BNZ
   2022-08-03 00:01:53,298 DEBUG [c.c.a.AlertManagerImpl] 
(CapacityChecker:ctx-166624fc) (logid:8e4ca7a5) Unallocated storage space is 
low, total: 62914488 MB, allocated: 50750692 MB (80.67%)
   2022-08-03 00:01:53,298 WARN  [c.c.a.AlertManagerImpl] 
(CapacityChecker:ctx-166624fc) (logid:8e4ca7a5) alertType=[3] dataCenterId=[1] 
podId=[1] clusterId=[1] message=[System Alert: Remaining unallocated Storage is 
low in cluster BNZ-CL-001 pod BNZ-POD-01 of availability zone BNZ].
   
   2022-08-03 00:01:54,255 DEBUG [c.c.a.AlertManagerImpl] 
(CapacityChecker:ctx-166624fc) (logid:8e4ca7a5) Have already sent: 1 emails for 
alert type '3' -- skipping send email
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6612: ui: fix hypervisortrafficlabel for phy nw traffic

2022-08-04 Thread GitBox


blueorangutan commented on PR #6612:
URL: https://github.com/apache/cloudstack/pull/6612#issuecomment-1205058543

   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6612 (SL-JID-2080)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6612: ui: fix hypervisortrafficlabel for phy nw traffic

2022-08-04 Thread GitBox


blueorangutan commented on PR #6612:
URL: https://github.com/apache/cloudstack/pull/6612#issuecomment-1205052397

   @acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] acs-robot commented on pull request #6612: ui: fix hypervisortrafficlabel for phy nw traffic

2022-08-04 Thread GitBox


acs-robot commented on PR #6612:
URL: https://github.com/apache/cloudstack/pull/6612#issuecomment-1205051556

   Found UI changes, kicking a new UI QA build
   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6571: [WIP] VM Autoscaling with virtual router

2022-08-04 Thread GitBox


blueorangutan commented on PR #6571:
URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1205039697

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 
:heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3905


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on issue #6593: Problem With Separating Traffic Type for vmware host in Cloudstack UI

2022-08-04 Thread GitBox


shwstppr commented on issue #6593:
URL: https://github.com/apache/cloudstack/issues/6593#issuecomment-1205024781

   @ahmadamirahmadi007 In case of different physical networks, server was 
failing to add your cluster while facing problem with wrong vlan,
   ```
   2022-07-31 08:14:02,240 INFO  [c.c.h.v.m.VmwareManagerImpl] 
(qtp681094281-498:ctx-7b80359c ctx-12777883) (logid:0d78ed6c) Preparing network 
on host com.cloud.hypervisor.vmware.util.VmwareContext@36fe5de2 for 
vSwitch0,null,vmwaresvs
   2022-07-31 08:14:02,260 WARN  [c.c.h.v.VmwareServerDiscoverer] 
(qtp681094281-498:ctx-7b80359c ctx-12777883) (logid:0d78ed6c) Unable to connect 
to Vmware vSphere server. service address: vcsa1.acs.lab.local. 
java.lang.NumberFormatException: For input string: "null"
   ```
   
   This seems to be a bug in the UI which adds the wrong hypervisor traffic 
label. I've created PR #6612 to fix it.
   Currently traffic label for your different physical networs will read like,
   `vSwitch0,null,vmwaresvs`
   Though they should be like the following if you are not using a VLAN:
   `vSwitch0,,vmwaresvs`
   
   You can update the VMware traffic label by going into the particular 
physical network and using the Update traffic label action from the top right 
list of actions
   ![Screenshot from 2022-08-04 
14-51-56](https://user-images.githubusercontent.com/153340/182816639-e586c733-4abd-46a5-9ef0-58a68b698c87.png)
   
   Regarding your second query, option to select switch type isn't present in 
the physical network form as these networks are not linked to a particular 
swtich type. Rather it is the traffic type - Management, Public, Guest, etc.
   You may continue to add physical network using the form and then add the 
desired traffic type to it (Add Traffic type action in physical network). After 
adding the desired traffic type you will have to update the VMware traffic 
label using the Update traffic label action. Unfortunately there isn't a select 
UI here so you will have to manually add the label in format,
   
   SWITCHNAME,VLAN,SWITCHTYPE
   eg:
   `vSwitch0,,vmwaresvs`
   `vSwitch1,201,vmwaredvs`
   `vSwitch2,untagged,vmwaredvs`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6571: [WIP] VM Autoscaling with virtual router

2022-08-04 Thread GitBox


sonarcloud[bot] commented on PR #6571:
URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1205020541

   SonarCloud Quality Gate failed.  [![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate 
failed')](https://sonarcloud.io/dashboard?id=apache_cloudstack=6571)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6571=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6571=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=6571=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6571=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6571=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=6571=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6571=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6571=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6571=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6571=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6571=false=CODE_SMELL)
 [110 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=6571=false=CODE_SMELL)
   
   
[![0.3%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png
 
'0.3%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=6571=new_coverage=list)
 [0.3% 
Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=6571=new_coverage=list)
  
   
[![0.8%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.8%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=6571=new_duplicated_lines_density=list)
 [0.8% 
Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=6571=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6612: ui: fix hypervisortrafficlabel for phy nw traffic

2022-08-04 Thread GitBox


blueorangutan commented on PR #6612:
URL: https://github.com/apache/cloudstack/pull/6612#issuecomment-1205019766

   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6612 (SL-JID-2079)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details

2022-08-04 Thread GitBox


blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1205019300

   Trillian Build Failed (tid-4620)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on issue #6601: apache apidocs FAILURE in Build From Source

2022-08-04 Thread GitBox


DaanHoogland commented on issue #6601:
URL: https://github.com/apache/cloudstack/issues/6601#issuecomment-1205013900

   @ahmadamirahmadi007 what does `python --version` say?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details

2022-08-04 Thread GitBox


blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1205011387

   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-70u3) has 
been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6612: ui: fix hypervisortrafficlabel for phy nw traffic

2022-08-04 Thread GitBox


blueorangutan commented on PR #6612:
URL: https://github.com/apache/cloudstack/pull/6612#issuecomment-1205011444

   @acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6571: [WIP] VM Autoscaling with virtual router

2022-08-04 Thread GitBox


blueorangutan commented on PR #6571:
URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1205011415

   @weizhouapache a Jenkins job has been kicked to build packages. It will be 
bundled with
   
SystemVM template(s). I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details

2022-08-04 Thread GitBox


DaanHoogland commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1205011075

   @blueorangutan test centos7 vmware-70u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #6571: [WIP] VM Autoscaling with virtual router

2022-08-04 Thread GitBox


weizhouapache commented on PR #6571:
URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1205010544

   
   @blueorangutan package
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6581: [Veeam] enable volume attach/detach in VMs with Backup Offerings

2022-08-04 Thread GitBox


blueorangutan commented on PR #6581:
URL: https://github.com/apache/cloudstack/pull/6581#issuecomment-1205010302

   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has 
been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] acs-robot commented on pull request #6612: ui: fix hypervisortrafficlabel for phy nw traffic

2022-08-04 Thread GitBox


acs-robot commented on PR #6612:
URL: https://github.com/apache/cloudstack/pull/6612#issuecomment-1205010278

   Found UI changes, kicking a new UI QA build
   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6581: [Veeam] enable volume attach/detach in VMs with Backup Offerings

2022-08-04 Thread GitBox


DaanHoogland commented on PR #6581:
URL: https://github.com/apache/cloudstack/pull/6581#issuecomment-1205009075

   @blueorangutan test centos7 vmware-67u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] shwstppr opened a new pull request, #6612: ui: fix hypervisortrafficlabel for phy nw traffic

2022-08-04 Thread GitBox


shwstppr opened a new pull request, #6612:
URL: https://github.com/apache/cloudstack/pull/6612

   ### Description
   
   Fixes: #6593
   
   Before fix UI was setting vlan to 'null' when no value was passed. Now it 
just leaves the vlan value empty in the trafficlabel.
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6589: [Veeam] disable jobs but keep backups

2022-08-04 Thread GitBox


blueorangutan commented on PR #6589:
URL: https://github.com/apache/cloudstack/pull/6589#issuecomment-1205006402

   Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 
:heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 3904


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6587: Updated resource counter to include correct size after volume creation/resize and other improvements

2022-08-04 Thread GitBox


blueorangutan commented on PR #6587:
URL: https://github.com/apache/cloudstack/pull/6587#issuecomment-1204990675

   Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 
:heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 3902


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6571: [WIP] VM Autoscaling with virtual router

2022-08-04 Thread GitBox


blueorangutan commented on PR #6571:
URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1204990674

   Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 
:heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 3903


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6460: Add new parameter to createLoadBalancerRule API

2022-08-04 Thread GitBox


DaanHoogland commented on code in PR #6460:
URL: https://github.com/apache/cloudstack/pull/6460#discussion_r937544114


##
api/src/main/java/org/apache/cloudstack/api/command/user/loadbalancer/CreateLoadBalancerRuleCmd.java:
##
@@ -107,7 +107,8 @@ public class CreateLoadBalancerRuleCmd extends 
BaseAsyncCreateCmd /*implements L
 @Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.UUID, 
entityType = DomainResponse.class, description = "the domain ID associated with 
the load balancer")
 private Long domainId;
 
-@Parameter(name = ApiConstants.CIDR_LIST, type = CommandType.LIST, 
collectionType = CommandType.STRING, description = "the CIDR list to forward 
traffic from. Multiple entries must be separated by a single comma character 
(,). This parameter is deprecated. Do not use.")
+@Parameter(name = ApiConstants.CIDR_LIST, type = CommandType.LIST, 
collectionType = CommandType.STRING, description = "the CIDR list to allow 
traffic, all other CIDRs"

Review Comment:
   can you add the since parameter to the `@Parameter` annotation, please? i.e:
   ```suggestion
   @Parameter(name = ApiConstants.CIDR_LIST, type = CommandType.LIST, 
collectionType = CommandType.STRING, since="4.18.0.0" description = "the CIDR 
list to allow traffic, all other CIDRs"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] ahmadamirahmadi007 commented on issue #6601: apache apidocs FAILURE in Build From Source

2022-08-04 Thread GitBox


ahmadamirahmadi007 commented on issue #6601:
URL: https://github.com/apache/cloudstack/issues/6601#issuecomment-1204980567

   result of  mvn clean install -Dnoredist -P developer,systemvm -pl 
:cloud-apidoc :
   
![apidoc](https://user-images.githubusercontent.com/104001728/182809531-6c559cd0-d5bd-4cbd-b849-ab37e6e3ea4b.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #6341: Enable system VM volume migration for KVM

2022-08-04 Thread GitBox


shwstppr commented on PR #6341:
URL: https://github.com/apache/cloudstack/pull/6341#issuecomment-1204978686

   @GutoVeronezi can you please check why tests from `test_vpc_routers` are 
failing on travis repeatedly


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6460: Add new parameter to createLoadBalancerRule API

2022-08-04 Thread GitBox


blueorangutan commented on PR #6460:
URL: https://github.com/apache/cloudstack/pull/6460#issuecomment-1204978536

   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6460: Add new parameter to createLoadBalancerRule API

2022-08-04 Thread GitBox


DaanHoogland commented on PR #6460:
URL: https://github.com/apache/cloudstack/pull/6460#issuecomment-1204978282

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details

2022-08-04 Thread GitBox


blueorangutan commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1204976447

   @DaanHoogland unsupported parameters provided. Supported mgmt server os are: 
`centos7, centos6, suse15, alma8, ubuntu18, ubuntu22, ubuntu20, rocky8`. 
Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-rocky8, kvm-alma8, 
kvm-ubuntu18, kvm-ubuntu20, kvm-ubuntu22, kvm-suse15, vmware-55u3, vmware-60u2, 
vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, vmware-70u3, 
xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, 
xcpng81, xcpng82`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6276: api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details

2022-08-04 Thread GitBox


DaanHoogland commented on PR #6276:
URL: https://github.com/apache/cloudstack/pull/6276#issuecomment-1204975623

   @blueorangutan test centos7 vmaware-70u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6589: [Veeam] disable jobs but keep backups

2022-08-04 Thread GitBox


blueorangutan commented on PR #6589:
URL: https://github.com/apache/cloudstack/pull/6589#issuecomment-1204963204

   @DaanHoogland a Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6581: [Veeam] enable volume attach/detach in VMs with Backup Offerings

2022-08-04 Thread GitBox


blueorangutan commented on PR #6581:
URL: https://github.com/apache/cloudstack/pull/6581#issuecomment-1204963069

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 
:heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3901


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6589: [Veeam] disable jobs but keep backups

2022-08-04 Thread GitBox


DaanHoogland commented on PR #6589:
URL: https://github.com/apache/cloudstack/pull/6589#issuecomment-1204961731

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6571: [WIP] VM Autoscaling with virtual router

2022-08-04 Thread GitBox


blueorangutan commented on PR #6571:
URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1204957425

   @weizhouapache a Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #6571: [WIP] VM Autoscaling with virtual router

2022-08-04 Thread GitBox


weizhouapache commented on PR #6571:
URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1204956442

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6571: [WIP] VM Autoscaling with virtual router

2022-08-04 Thread GitBox


blueorangutan commented on PR #6571:
URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1204956071

   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6571 (SL-JID-2078)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland closed pull request #6589: [Veeam] disable jobs but keep backups

2022-08-04 Thread GitBox


DaanHoogland closed pull request #6589: [Veeam] disable jobs but keep backups
URL: https://github.com/apache/cloudstack/pull/6589


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6589: [Veeam] disable jobs but keep backups

2022-08-04 Thread GitBox


DaanHoogland commented on code in PR #6589:
URL: https://github.com/apache/cloudstack/pull/6589#discussion_r937518011


##
utils/src/main/java/com/cloud/utils/UuidUtils.java:
##
@@ -28,6 +28,10 @@ public final static String first(String uuid) {
 return uuid.substring(0, uuid.indexOf('-'));
 }
 
+public static boolean isUuid(String data) {

Review Comment:
   ok, so then it makes sense not to xall the method validate...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6571: [WIP] VM Autoscaling with virtual router

2022-08-04 Thread GitBox


blueorangutan commented on PR #6571:
URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1204948639

   @acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] acs-robot commented on pull request #6571: [WIP] VM Autoscaling with virtual router

2022-08-04 Thread GitBox


acs-robot commented on PR #6571:
URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1204947644

   Found UI changes, kicking a new UI QA build
   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6460: Add new parameter to createLoadBalancerRule API

2022-08-04 Thread GitBox


blueorangutan commented on PR #6460:
URL: https://github.com/apache/cloudstack/pull/6460#issuecomment-1204946918

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 
:heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3900


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6587: Updated resource counter to include correct size after volume creation/resize and other improvements

2022-08-04 Thread GitBox


blueorangutan commented on PR #6587:
URL: https://github.com/apache/cloudstack/pull/6587#issuecomment-1204945338

   @DaanHoogland a Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[cloudstack] branch 4.18-vm-autoscaling updated (16afb13f49 -> a183c19b92)

2022-08-04 Thread weizhou
This is an automated email from the ASF dual-hosted git repository.

weizhou pushed a change to branch 4.18-vm-autoscaling
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


from 16afb13f49 AS: check user api/secret key and endpoint.url only when lb 
provider is netscaler
 add a410227df3 AS UI: show 'close' button when all are processed
 add fd531cad25 AS: cancel monitor task when AS group is removed
 add 158231c3b7 AS: insert inactive-dummy statistics record instead of 
marking all as Inactive when scale up/down
 add a183c19b92 AS: list autoscale vmgroups by name

No new revisions were added by this update.

Summary of changes:
 .../user/autoscale/ListAutoScaleVmGroupsCmd.java  |  7 +++
 .../com/cloud/network/as/AutoScaleManagerImpl.java| 19 +++
 ui/src/views/compute/CreateAutoScaleVmGroup.vue   | 13 +++--
 3 files changed, 29 insertions(+), 10 deletions(-)



[GitHub] [cloudstack] DaanHoogland commented on pull request #6587: Updated resource counter to include correct size after volume creation/resize and other improvements

2022-08-04 Thread GitBox


DaanHoogland commented on PR #6587:
URL: https://github.com/apache/cloudstack/pull/6587#issuecomment-1204944683

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6386: [VMWare] Limit IOPS in Compute/Disk Offerings

2022-08-04 Thread GitBox


blueorangutan commented on PR #6386:
URL: https://github.com/apache/cloudstack/pull/6386#issuecomment-1204941664

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 
:heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 3899


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6550: Emc networker b

2022-08-04 Thread GitBox


blueorangutan commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1204936206

   Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 
:heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3898


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6581: [Veeam] enable volume attach/detach in VMs with Backup Offerings

2022-08-04 Thread GitBox


blueorangutan commented on PR #6581:
URL: https://github.com/apache/cloudstack/pull/6581#issuecomment-1204887231

   @DaanHoogland a Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6581: [Veeam] enable volume attach/detach in VMs with Backup Offerings

2022-08-04 Thread GitBox


DaanHoogland commented on PR #6581:
URL: https://github.com/apache/cloudstack/pull/6581#issuecomment-1204886051

   Unfortunately I don´t have a setup with veeam, so my tests won´t help to 
assess the code/functionality.
   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6491: Add live migration of system VMs

2022-08-04 Thread GitBox


DaanHoogland commented on PR #6491:
URL: https://github.com/apache/cloudstack/pull/6491#issuecomment-1204883396

   @Pearl1594  @rohityadavcloud  could you shine your lights on this, please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6491: Add live migration of system VMs

2022-08-04 Thread GitBox


blueorangutan commented on PR #6491:
URL: https://github.com/apache/cloudstack/pull/6491#issuecomment-1204883319

   @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 
mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6491: Add live migration of system VMs

2022-08-04 Thread GitBox


DaanHoogland commented on PR #6491:
URL: https://github.com/apache/cloudstack/pull/6491#issuecomment-1204882540

   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6550: Emc networker b

2022-08-04 Thread GitBox


DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1204871477

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6369: UI: Upgrade ant-design-vue to version 3.x

2022-08-04 Thread GitBox


sonarcloud[bot] commented on PR #6369:
URL: https://github.com/apache/cloudstack/pull/6369#issuecomment-1204877565

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack=6369)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6369=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6369=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=6369=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6369=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6369=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=6369=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6369=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6369=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6369=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6369=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6369=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=6369=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_cloudstack=6369=coverage=list)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=apache_cloudstack=6369=duplicated_lines_density=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6460: Add new parameter to createLoadBalancerRule API

2022-08-04 Thread GitBox


blueorangutan commented on PR #6460:
URL: https://github.com/apache/cloudstack/pull/6460#issuecomment-1204877436

   @DaanHoogland a Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6460: Add new parameter to createLoadBalancerRule API

2022-08-04 Thread GitBox


DaanHoogland commented on PR #6460:
URL: https://github.com/apache/cloudstack/pull/6460#issuecomment-1204876974

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6386: [VMWare] Limit IOPS in Compute/Disk Offerings

2022-08-04 Thread GitBox


blueorangutan commented on PR #6386:
URL: https://github.com/apache/cloudstack/pull/6386#issuecomment-1204875480

   @DaanHoogland a Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6386: [VMWare] Limit IOPS in Compute/Disk Offerings

2022-08-04 Thread GitBox


DaanHoogland commented on PR #6386:
URL: https://github.com/apache/cloudstack/pull/6386#issuecomment-1204874674

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6282: [Veeam] restored VMs without NICs

2022-08-04 Thread GitBox


blueorangutan commented on PR #6282:
URL: https://github.com/apache/cloudstack/pull/6282#issuecomment-1204873533

   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has 
been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6282: [Veeam] restored VMs without NICs

2022-08-04 Thread GitBox


DaanHoogland commented on PR #6282:
URL: https://github.com/apache/cloudstack/pull/6282#issuecomment-1204872705

   @blueorangutan test centos7 vmware-67u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6550: Emc networker b

2022-08-04 Thread GitBox


blueorangutan commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1204872558

   @DaanHoogland a Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6369: UI: Upgrade ant-design-vue to version 3.x

2022-08-04 Thread GitBox


blueorangutan commented on PR #6369:
URL: https://github.com/apache/cloudstack/pull/6369#issuecomment-1204838109

   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6369 (SL-JID-2077)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6369: UI: Upgrade ant-design-vue to version 3.x

2022-08-04 Thread GitBox


blueorangutan commented on PR #6369:
URL: https://github.com/apache/cloudstack/pull/6369#issuecomment-1204833124

   @acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] acs-robot commented on pull request #6369: UI: Upgrade ant-design-vue to version 3.x

2022-08-04 Thread GitBox


acs-robot commented on PR #6369:
URL: https://github.com/apache/cloudstack/pull/6369#issuecomment-1204832665

   Found UI changes, kicking a new UI QA build
   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org