[GitHub] [cloudstack] AlexanderKgr commented on issue #6941: Xcp-ng 8.2.1 - issues reverting to vm snapshot
AlexanderKgr commented on issue #6941: URL: https://github.com/apache/cloudstack/issues/6941#issuecomment-1334836330 snapshot with memory works as it should -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] AlexanderKgr opened a new issue, #6941: Xcp-ng 8.2.1 - issues reverting to vm snapshot
AlexanderKgr opened a new issue, #6941: URL: https://github.com/apache/cloudstack/issues/6941 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ Vm restore ~~~ # CLOUDSTACK VERSION ~~~ 4.17.1.0 ~~~ # CONFIGURATION Advanced Networking # OS / ENVIRONMENT Ubuntu server 20.04 # SUMMARY When trying to restore a "disk" vm snapshot and vm is poweroff i have the following message ![0-02-05-e01893be44079cb86b45ad152a3b507ff7dd27d7b995f9416b0a92e0ac7e4cc4_e6fab0de0573277d](https://user-images.githubusercontent.com/25532758/205231554-aac2a21f-acda-4df4-b1e8-4348d7d644cd.jpg) and from the cs logs ![0-02-05-2156f986e60bfd407fb9a5fa9d2a803e9804c45d28d1722b88f23f0e39f7362d_d8f125d0384ac741](https://user-images.githubusercontent.com/25532758/205231631-559c91b8-3a11-4f0f-a0bb-4ed9e0f3e9a1.jpg) When trying to restore a "disk" vm and the vm is powered off from console i have the following message ![0-02-05-783b345223258c4eee84888d8861429b1f552fa233536ac90152e9141ab0359d_45cd3ca2ad89b7cb](https://user-images.githubusercontent.com/25532758/205231770-a153346f-3089-400d-b985-6adc75e66518.jpg) Which is normal is some consideration # STEPS TO REPRODUCE ~~~ Create a vm, take a disk snapshot and try to restore. You will have the error i describe ~~~ # EXPECTED RESULTS ~~~ Restore vm to snapshot ~~~ # ACTUAL RESULTS ~~~ Error messages ~~~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] happyalexkg opened a new issue, #6940: Live Storage migration Ubuntu 20, does not work
happyalexkg opened a new issue, #6940: URL: https://github.com/apache/cloudstack/issues/6940 Hello, Team I tring use Live Migration with Volume Migration with Shared Storage (Ceph) on KVM (Ubuntu 20). But it's failed with: 2022-12-02 09:58:27,651 DEBUG [o.a.c.e.o.VolumeOrchestrator] (Work-Job-Executor-92:ctx-136c4df4 job-442/job-443 ctx-6b9bcc45) (logid:ca6829a0) Failed to migrated vm VM instance {id: "87", name: "i-2-87-VM", uuid: "0780ecb5-a878-4553-8d94-8538a3fff08c", type="User"} along with its volumes. Can't find strategy to move data. Source Host: ceph-osd01, Destination Host: ceph-osd02, Volume UUIDs: c252edd8-5119-4d70-b3b6-65bca49beeba I'm tring migrate Vm from one Ceph Pool to Another Ceph pool. Both in same Zone and Cluster -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] boring-cyborg[bot] commented on issue #6940: Live Storage migration Ubuntu 20, does not work
boring-cyborg[bot] commented on issue #6940: URL: https://github.com/apache/cloudstack/issues/6940#issuecomment-1334732299 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6939: When VM is created and ROOT volume is created it should emit a VOLUME.CREATE event
sonarcloud[bot] commented on PR #6939: URL: https://github.com/apache/cloudstack/pull/6939#issuecomment-1334681431 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache_cloudstack=6939) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6939=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6939=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=6939=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6939=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6939=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=6939=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6939=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6939=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6939=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6939=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6939=false=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=6939=false=CODE_SMELL) [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=6939=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=6939=new_coverage=list) [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=6939=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=6939=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6939: When VM is created and ROOT volume is created it should emit a VOLUME.CREATE event
codecov[bot] commented on PR #6939: URL: https://github.com/apache/cloudstack/pull/6939#issuecomment-1334676651 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6939?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#6939](https://codecov.io/gh/apache/cloudstack/pull/6939?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (a2e4c2f) into [main](https://codecov.io/gh/apache/cloudstack/commit/3d8ea4f3b3ee1c009871e00d20ea03087cdc18a0?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (3d8ea4f) will **increase** coverage by `0.00%`. > The diff coverage is `0.00%`. ```diff @@Coverage Diff@@ ## main#6939 +/- ## = Coverage 10.87% 10.87% + Complexity 7118 7117-1 = Files 2485 2485 Lines245522 245532 +10 Branches 3833538337+2 = + Hits 2670126706+5 - Misses 215550 21+5 Partials 3271 3271 ``` | [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6939?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...n/java/com/cloud/vm/VirtualMachineManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6939/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZW5naW5lL29yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9jb20vY2xvdWQvdm0vVmlydHVhbE1hY2hpbmVNYW5hZ2VySW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | | | [...stack/engine/orchestration/VolumeOrchestrator.java](https://codecov.io/gh/apache/cloudstack/pull/6939/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZW5naW5lL29yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svZW5naW5lL29yY2hlc3RyYXRpb24vVm9sdW1lT3JjaGVzdHJhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | | | [.../src/main/java/com/cloud/vm/UserVmManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6939/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3ZtL1VzZXJWbU1hbmFnZXJJbXBsLmphdmE=) | `6.70% <0.00%> (+<0.01%)` | :arrow_up: | | [...dstack/network/contrail/model/ModelObjectBase.java](https://codecov.io/gh/apache/cloudstack/pull/6939/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdEJhc2UuamF2YQ==) | `21.15% <0.00%> (-7.70%)` | :arrow_down: | | [...rg/apache/cloudstack/quota/QuotaStatementImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6939/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZnJhbWV3b3JrL3F1b3RhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3F1b3RhL1F1b3RhU3RhdGVtZW50SW1wbC5qYXZh) | `40.26% <0.00%> (+3.98%)` | :arrow_up: | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6511: [HEALTH] 4.18/main Health Check, please don't merge this!
blueorangutan commented on PR #6511: URL: https://github.com/apache/cloudstack/pull/6511#issuecomment-1334658971 Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6899: Count Resource Virtual Router
blueorangutan commented on PR #6899: URL: https://github.com/apache/cloudstack/pull/6899#issuecomment-1334656528 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4733 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] mprokopchuk opened a new pull request, #6939: When VM is created and ROOT volume is created it should emit a VOLUME.CREATE event
mprokopchuk opened a new pull request, #6939: URL: https://github.com/apache/cloudstack/pull/6939 ### Description When VM is created and ROOT volume is created it should emit a VOLUME.CREATE event. Steps to reproduce: 1. Create VM 2. Check events 3. VOLUME.CREATE for the ROOT volume is not present ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ### Feature/Enhancement Scale or Bug Severity Feature/Enhancement Scale - [ ] Major - [X] Minor Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [X] Minor - [ ] Trivial ### Screenshots (if appropriate): After the fix (see highlighted VOLUME.CREATE event) https://user-images.githubusercontent.com/742444/205193513-33184a97-5c16-4559-888e-986a25528872.png;> ### How Has This Been Tested? Tested manually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6526: [HEALTH] 4.17 Health Check please don't merge this
blueorangutan commented on PR #6526: URL: https://github.com/apache/cloudstack/pull/6526#issuecomment-1334647612 Trillian Build Failed (tid-5339) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6526: [HEALTH] 4.17 Health Check please don't merge this
blueorangutan commented on PR #6526: URL: https://github.com/apache/cloudstack/pull/6526#issuecomment-1334645948 Trillian test result (tid-5329) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39281 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6526-t5329-xenserver-71.zip Smoke tests completed. 101 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6526: [HEALTH] 4.17 Health Check please don't merge this
blueorangutan commented on PR #6526: URL: https://github.com/apache/cloudstack/pull/6526#issuecomment-1334633569 Trillian test result (tid-5330) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 38034 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6526-t5330-kvm-centos7.zip Smoke tests completed. 96 look OK, 5 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_list_snapshots_with_removed_data_store | `Error` | 8.43 | test_snapshots.py test_02_list_snapshots_with_removed_data_store | `Error` | 8.43 | test_snapshots.py test_01_add_primary_storage_disabled_host | `Error` | 0.63 | test_primary_storage.py test_01_primary_storage_nfs | `Error` | 0.12 | test_primary_storage.py ContextSuite context=TestStorageTags>:setup | `Error` | 0.21 | test_primary_storage.py test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 30.82 | test_kubernetes_clusters.py test_07_deploy_kubernetes_ha_cluster | `Failure` | 56.40 | test_kubernetes_clusters.py test_08_upgrade_kubernetes_ha_cluster | `Failure` | 35.93 | test_kubernetes_clusters.py test_09_delete_kubernetes_ha_cluster | `Failure` | 33.92 | test_kubernetes_clusters.py ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 117.50 | test_kubernetes_clusters.py test_01_secure_vm_migration | `Error` | 158.25 | test_vm_life_cycle.py test_02_unsecure_vm_migration | `Error` | 267.94 | test_vm_life_cycle.py test_03_secured_to_nonsecured_vm_migration | `Error` | 139.70 | test_vm_life_cycle.py test_08_migrate_vm | `Error` | 41.68 | test_vm_life_cycle.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 302.73 | test_hostha_kvm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6526: [HEALTH] 4.17 Health Check please don't merge this
blueorangutan commented on PR #6526: URL: https://github.com/apache/cloudstack/pull/6526#issuecomment-1334625964 @rohityadavcloud a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6511: [HEALTH] 4.18/main Health Check, please don't merge this!
blueorangutan commented on PR #6511: URL: https://github.com/apache/cloudstack/pull/6511#issuecomment-1334625951 @rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6511: [HEALTH] 4.18/main Health Check, please don't merge this!
rohityadavcloud commented on PR #6511: URL: https://github.com/apache/cloudstack/pull/6511#issuecomment-1334625487 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6526: [HEALTH] 4.17 Health Check please don't merge this
rohityadavcloud commented on PR #6526: URL: https://github.com/apache/cloudstack/pull/6526#issuecomment-1334625317 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6899: Count Resource Virtual Router
blueorangutan commented on PR #6899: URL: https://github.com/apache/cloudstack/pull/6899#issuecomment-1334617804 @soreana a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] soreana commented on pull request #6899: Count Resource Virtual Router
soreana commented on PR #6899: URL: https://github.com/apache/cloudstack/pull/6899#issuecomment-1334617346 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6930: debian build: add python3-setuptools to dependencies
codecov[bot] commented on PR #6930: URL: https://github.com/apache/cloudstack/pull/6930#issuecomment-1334397206 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6930?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#6930](https://codecov.io/gh/apache/cloudstack/pull/6930?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b37e0ab) into [main](https://codecov.io/gh/apache/cloudstack/commit/4abb8b9ebf17494a27adc755730858a7e6382b89?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (4abb8b9) will **increase** coverage by `0.03%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## main#6930 +/- ## + Coverage 10.87% 10.90% +0.03% - Complexity 7115 7181 +66 Files 2485 2485 Lines245507 248802+3295 Branches 3833439925+1591 + Hits 2669527135 +440 - Misses 215543 218304+2761 - Partials 3269 3363 +94 ``` | [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6930?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...rver/src/main/java/com/cloud/vm/UserVmManager.java](https://codecov.io/gh/apache/cloudstack/pull/6930/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3ZtL1VzZXJWbU1hbmFnZXIuamF2YQ==) | `100.00% <0.00%> (ø)` | | | [...java/com/cloud/tags/TaggedResourceManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6930/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3RhZ3MvVGFnZ2VkUmVzb3VyY2VNYW5hZ2VySW1wbC5qYXZh) | `9.28% <0.00%> (+0.26%)` | :arrow_up: | | [.../src/main/java/com/cloud/vm/UserVmManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6930/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3ZtL1VzZXJWbU1hbmFnZXJJbXBsLmphdmE=) | `7.19% <0.00%> (+0.48%)` | :arrow_up: | | [...in/java/com/cloud/server/ManagementServerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6930/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3NlcnZlci9NYW5hZ2VtZW50U2VydmVySW1wbC5qYXZh) | `6.34% <0.00%> (+1.14%)` | :arrow_up: | | [...apache/cloudstack/alert/snmp/SnmpTrapAppender.java](https://codecov.io/gh/apache/cloudstack/pull/6930/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hbGVydC1oYW5kbGVycy9zbm1wLWFsZXJ0cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9hbGVydC9zbm1wL1NubXBUcmFwQXBwZW5kZXIuamF2YQ==) | `61.05% <0.00%> (+2.10%)` | :arrow_up: | | [...n/java/com/cloud/storage/VolumeApiServiceImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6930/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3N0b3JhZ2UvVm9sdW1lQXBpU2VydmljZUltcGwuamF2YQ==) | `15.35% <0.00%> (+2.48%)` | :arrow_up: | | [...rg/apache/cloudstack/quota/QuotaStatementImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6930/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZnJhbWV3b3JrL3F1b3RhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3F1b3RhL1F1b3RhU3RhdGVtZW50SW1wbC5qYXZh) | `40.26% <0.00%> (+3.98%)` | :arrow_up: | | [...dstack/network/contrail/model/ModelObjectBase.java](https://codecov.io/gh/apache/cloudstack/pull/6930/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdEJhc2UuamF2YQ==) | `28.84% <0.00%> (+7.69%)` | :arrow_up: | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn
[GitHub] [cloudstack] codecov[bot] commented on pull request #6938: Create API to reassign volume
codecov[bot] commented on PR #6938: URL: https://github.com/apache/cloudstack/pull/6938#issuecomment-1334232308 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6938?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#6938](https://codecov.io/gh/apache/cloudstack/pull/6938?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (d9733cf) into [main](https://codecov.io/gh/apache/cloudstack/commit/3d8ea4f3b3ee1c009871e00d20ea03087cdc18a0?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (3d8ea4f) will **increase** coverage by `0.02%`. > The diff coverage is `47.82%`. ```diff @@ Coverage Diff @@ ## main#6938 +/- ## + Coverage 10.87% 10.89% +0.02% - Complexity 7118 7137 +19 Files 2485 2485 Lines245522 245613 +91 Branches 3833538346 +11 + Hits 2670126765 +64 - Misses 215550 215573 +23 - Partials 3271 3275 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6938?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ck/engine/subsystem/api/storage/VolumeService.java](https://codecov.io/gh/apache/cloudstack/pull/6938/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZW5naW5lL2FwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9lbmdpbmUvc3Vic3lzdGVtL2FwaS9zdG9yYWdlL1ZvbHVtZVNlcnZpY2UuamF2YQ==) | `0.00% <ø> (ø)` | | | [...tack/storage/endpoint/DefaultEndPointSelector.java](https://codecov.io/gh/apache/cloudstack/pull/6938/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3N0b3JhZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svc3RvcmFnZS9lbmRwb2ludC9EZWZhdWx0RW5kUG9pbnRTZWxlY3Rvci5qYXZh) | `0.00% <0.00%> (ø)` | | | [...e/cloudstack/storage/volume/VolumeServiceImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6938/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3N0b3JhZ2Uvdm9sdW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N0b3JhZ2Uvdm9sdW1lL1ZvbHVtZVNlcnZpY2VJbXBsLmphdmE=) | `2.28% <0.00%> (-0.05%)` | :arrow_down: | | [...in/java/com/cloud/server/ManagementServerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6938/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3NlcnZlci9NYW5hZ2VtZW50U2VydmVySW1wbC5qYXZh) | `5.19% <0.00%> (-0.01%)` | :arrow_down: | | [...n/java/com/cloud/storage/VolumeApiServiceImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6938/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3N0b3JhZ2UvVm9sdW1lQXBpU2VydmljZUltcGwuamF2YQ==) | `14.40% <70.96%> (+1.55%)` | :arrow_up: | | [...rg/apache/cloudstack/quota/QuotaStatementImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6938/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZnJhbWV3b3JrL3F1b3RhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3F1b3RhL1F1b3RhU3RhdGVtZW50SW1wbC5qYXZh) | `40.26% <0.00%> (+3.98%)` | :arrow_up: | | [...cloudstack/network/contrail/model/ModelObject.java](https://codecov.io/gh/apache/cloudstack/pull/6938/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdC5qYXZh) | `33.33% <0.00%> (+4.16%)` | :arrow_up: | | [...dstack/network/contrail/model/ModelObjectBase.java](https://codecov.io/gh/apache/cloudstack/pull/6938/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdEJhc2UuamF2YQ==) | `44.23% <0.00%> (+15.38%)` | :arrow_up: | |
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6938: Create API to reassign volume
sonarcloud[bot] commented on PR #6938: URL: https://github.com/apache/cloudstack/pull/6938#issuecomment-1334228207 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache_cloudstack=6938) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6938=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6938=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=6938=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6938=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6938=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=6938=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6938=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6938=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6938=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6938=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6938=false=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=6938=false=CODE_SMELL) [![29.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/25-16px.png '29.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=6938=new_coverage=list) [29.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=6938=new_coverage=list) [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=6938=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=6938=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6508: Inserts timer in check detach volume
blueorangutan commented on PR #6508: URL: https://github.com/apache/cloudstack/pull/6508#issuecomment-1334195385 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] JoaoJandre opened a new pull request, #6938: Create API to reassign volume
JoaoJandre opened a new pull request, #6938: URL: https://github.com/apache/cloudstack/pull/6938 ### Description ACS has an API to change the account that owns a VM; however, it is not possible to perform the same type of operation for volumes. Therefore, we created the API `assignVolume` to allow the transition of volumes between accounts. For this, the user executing the operation needs the following: - permission to the `assignVolume` API - must be able to access the account that will receive the volume - must be able to access the volume being moved to a new account ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [X] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ### Feature/Enhancement Scale or Bug Severity Feature/Enhancement Scale - [ ] Major - [X] Minor Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? | N | Test | Result | Expected behavior? | | -- | -- | -- | -- | |1| Call the API to change a volume's owner between two different accounts | the volume's owner was changed | yes | |2| Call the API to change the volume's owner to its own account | Exception | yes | |3| Call the API to change the volume's owner to a disabled account | Exception | yes | |4| Call the API to change the volume's owner to a locked account | Exception | yes | |5| Call the API to change the volume's owner while the volume is attached | Exception | yes | |6| Call the API to change the volume's owner while the volume has a snapshot | Exception | yes | |7| Call the API to change a volume's owner between two different accounts, while the volume is on the secondary storage | The volume was moved from the original accounts secondary storage directory to the new owner's secondary storage directory and then was reassigned | yes | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6812: Normalize encryption on global configurations values
blueorangutan commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1334136509 Trillian Build Failed (tid-5334) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6508: Inserts timer in check detach volume
blueorangutan commented on PR #6508: URL: https://github.com/apache/cloudstack/pull/6508#issuecomment-1334136160 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6508: Inserts timer in check detach volume
DaanHoogland commented on PR #6508: URL: https://github.com/apache/cloudstack/pull/6508#issuecomment-1334135182 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6917: Improvements and cleanup on the javadocs of QemuImg
blueorangutan commented on PR #6917: URL: https://github.com/apache/cloudstack/pull/6917#issuecomment-1334124614 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 4731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6930: debian build: add python3-setuptools to dependencies
blueorangutan commented on PR #6930: URL: https://github.com/apache/cloudstack/pull/6930#issuecomment-1334123528 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 4730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency
blueorangutan commented on PR #6892: URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1334118174 Trillian Build Failed (tid-5332) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6812: Normalize encryption on global configurations values
blueorangutan commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1334093884 Trillian Build Failed (tid-5333) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #6859: Exported metrics have a domain instead of the full path
DaanHoogland commented on issue #6859: URL: https://github.com/apache/cloudstack/issues/6859#issuecomment-1334074021 that said, I´d say go for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #6859: Exported metrics have a domain instead of the full path
DaanHoogland commented on issue #6859: URL: https://github.com/apache/cloudstack/issues/6859#issuecomment-1334072873 To tell you the truth @vdombrovski , I don´t know how this is used and whether it would break anything. It seems alright to me, but in my experience even changing log messages can break things (like monitorring systems) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6812: Normalize encryption on global configurations values
blueorangutan commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1334067906 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6812: Normalize encryption on global configurations values
DaanHoogland commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1334067086 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency
blueorangutan commented on PR #6892: URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1334066712 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6892: Externalize KVM HA heartbeat frequency
DaanHoogland commented on PR #6892: URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1334066248 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6927: Fix migration path of PR #5909
blueorangutan commented on PR #6927: URL: https://github.com/apache/cloudstack/pull/6927#issuecomment-1334055007 Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 4729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] vdombrovski commented on issue #6859: Exported metrics have a domain instead of the full path
vdombrovski commented on issue #6859: URL: https://github.com/apache/cloudstack/issues/6859#issuecomment-1334051274 I've detailed the proposed fix above. I'd like to know if it is OK having this breaking change to be more accurate on the reported labels, or whether it's better to add another "path" label to the existing metric without changing the name label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6930: debian build: add python3-setuptools to dependencies
blueorangutan commented on PR #6930: URL: https://github.com/apache/cloudstack/pull/6930#issuecomment-1334031790 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6930: debian build: add python3-setuptools to dependencies
DaanHoogland commented on PR #6930: URL: https://github.com/apache/cloudstack/pull/6930#issuecomment-1334030575 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency
blueorangutan commented on PR #6892: URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1334027266 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6812: Normalize encryption on global configurations values
blueorangutan commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1334027269 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4728 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6917: Improvements and cleanup on the javadocs of QemuImg
blueorangutan commented on PR #6917: URL: https://github.com/apache/cloudstack/pull/6917#issuecomment-1334014029 Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 4726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6930: debian build: add python3-setuptools to dependencies
weizhouapache commented on PR #6930: URL: https://github.com/apache/cloudstack/pull/6930#issuecomment-1334008892 > @weizhouapache is this ready for review/merge? Yes @DaanHoogland , moved to ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #6930: debian build: add python3-setuptools to dependencies
weizhouapache closed pull request #6930: debian build: add python3-setuptools to dependencies URL: https://github.com/apache/cloudstack/pull/6930 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6898: Fix spelling
DaanHoogland commented on PR #6898: URL: https://github.com/apache/cloudstack/pull/6898#issuecomment-1333985489 This PR has a merge problem in the package jobs. I am try it manually but so far have not reproduced the problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6936: host affinity: fix vm cannot be started if a vm is stopped in the affinity group
codecov[bot] commented on PR #6936: URL: https://github.com/apache/cloudstack/pull/6936#issuecomment-1333979491 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6936?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#6936](https://codecov.io/gh/apache/cloudstack/pull/6936?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b59d993) into [4.17](https://codecov.io/gh/apache/cloudstack/commit/cf32f77e3dedfc75ea89278aacaaef89537f5d8e?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (cf32f77) will **increase** coverage by `0.00%`. > The diff coverage is `50.00%`. ```diff @@Coverage Diff@@ ## 4.17#6936 +/- ## = Coverage 10.34% 10.34% + Complexity 6614 6611-3 = Files 2451 2451 Lines242355 242356+1 Branches 3792537926+1 = + Hits 2507125072+1 + Misses 214195 214194-1 - Partials 3089 3090+1 ``` | [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6936?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...che/cloudstack/affinity/HostAffinityProcessor.java](https://codecov.io/gh/apache/cloudstack/pull/6936/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hZmZpbml0eS1ncm91cC1wcm9jZXNzb3JzL2hvc3QtYWZmaW5pdHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svYWZmaW5pdHkvSG9zdEFmZmluaXR5UHJvY2Vzc29yLmphdmE=) | `69.23% <50.00%> (-1.83%)` | :arrow_down: | | [...dstack/network/contrail/model/ModelObjectBase.java](https://codecov.io/gh/apache/cloudstack/pull/6936/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdEJhc2UuamF2YQ==) | `21.15% <0.00%> (-7.70%)` | :arrow_down: | | [...apache/cloudstack/syslog/AlertsSyslogAppender.java](https://codecov.io/gh/apache/cloudstack/pull/6936/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hbGVydC1oYW5kbGVycy9zeXNsb2ctYWxlcnRzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N5c2xvZy9BbGVydHNTeXNsb2dBcHBlbmRlci5qYXZh) | `56.49% <0.00%> (-2.26%)` | :arrow_down: | | [...rg/apache/cloudstack/quota/QuotaStatementImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6936/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-ZnJhbWV3b3JrL3F1b3RhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3F1b3RhL1F1b3RhU3RhdGVtZW50SW1wbC5qYXZh) | `40.26% <0.00%> (+3.98%)` | :arrow_up: | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6851: api,server: fix listing vm metrics for infra resources
DaanHoogland commented on code in PR #6851: URL: https://github.com/apache/cloudstack/pull/6851#discussion_r1037272474 ## plugins/metrics/src/main/java/org/apache/cloudstack/api/ListVMsMetricsCmd.java: ## @@ -42,9 +44,9 @@ */ @APICommand(name = ListVMsMetricsCmd.APINAME, description = "Lists VM metrics", responseObject = VmMetricsResponse.class, requestHasSensitiveInfo = false, responseHasSensitiveInfo = false, responseView = ResponseObject.ResponseView.Full, -since = "4.9.3", authorized = {RoleType.Admin, RoleType.ResourceAdmin, RoleType.DomainAdmin, RoleType.User}) +since = "4.9.3", authorized = {RoleType.ResourceAdmin, RoleType.DomainAdmin, RoleType.User}) @Deprecated(since = "4.17.0") Review Comment: let's remove the deprecation annotation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6851: api,server: fix listing vm metrics for infra resources
DaanHoogland commented on code in PR #6851: URL: https://github.com/apache/cloudstack/pull/6851#discussion_r1037271018 ## plugins/metrics/src/main/java/org/apache/cloudstack/api/ListVMsMetricsCmdByAdmin.java: ## @@ -0,0 +1,74 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.cloudstack.api; + +import org.apache.cloudstack.acl.RoleType; +import org.apache.cloudstack.api.command.admin.AdminCmd; +import org.apache.cloudstack.api.response.ClusterResponse; +import org.apache.cloudstack.api.response.HostResponse; +import org.apache.cloudstack.api.response.PodResponse; +import org.apache.cloudstack.api.response.StoragePoolResponse; +import org.apache.cloudstack.response.VmMetricsResponse; + +@APICommand(name = ListVMsMetricsCmd.APINAME, description = "Lists VM metrics", responseObject = VmMetricsResponse.class, +requestHasSensitiveInfo = false, responseHasSensitiveInfo = false, responseView = ResponseObject.ResponseView.Full, +since = "4.9.3", authorized = {RoleType.Admin}) Review Comment: it shouldn´t, there are others without this annotation parameter are there? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6851: api,server: fix listing vm metrics for infra resources
DaanHoogland commented on code in PR #6851: URL: https://github.com/apache/cloudstack/pull/6851#discussion_r1037269465 ## plugins/metrics/src/main/java/org/apache/cloudstack/api/ListVMsMetricsCmdByAdmin.java: ## @@ -0,0 +1,74 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.cloudstack.api; + +import org.apache.cloudstack.acl.RoleType; +import org.apache.cloudstack.api.command.admin.AdminCmd; +import org.apache.cloudstack.api.response.ClusterResponse; +import org.apache.cloudstack.api.response.HostResponse; +import org.apache.cloudstack.api.response.PodResponse; +import org.apache.cloudstack.api.response.StoragePoolResponse; +import org.apache.cloudstack.response.VmMetricsResponse; + +@APICommand(name = ListVMsMetricsCmd.APINAME, description = "Lists VM metrics", responseObject = VmMetricsResponse.class, +requestHasSensitiveInfo = false, responseHasSensitiveInfo = false, responseView = ResponseObject.ResponseView.Full, +since = "4.9.3", authorized = {RoleType.Admin}) +@Deprecated(since = "4.17.0") Review Comment: @shwstppr ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6869: Support for parameter `cidrlist` added to the UI
blueorangutan commented on PR #6869: URL: https://github.com/apache/cloudstack/pull/6869#issuecomment-1333949557 UI build: :heavy_multiplication_x: (SL-JID-2655) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6927: Fix migration path of PR #5909
blueorangutan commented on PR #6927: URL: https://github.com/apache/cloudstack/pull/6927#issuecomment-1333944775 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6927: Fix migration path of PR #5909
DaanHoogland commented on PR #6927: URL: https://github.com/apache/cloudstack/pull/6927#issuecomment-1333943918 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6845: [WIP] new plugins: Add non strict affinity groups
blueorangutan commented on PR #6845: URL: https://github.com/apache/cloudstack/pull/6845#issuecomment-1333943568 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6930: debian build: add python3-setuptools to dependencies
DaanHoogland commented on PR #6930: URL: https://github.com/apache/cloudstack/pull/6930#issuecomment-1333939865 @weizhouapache is this ready for review/merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6803: ui,server,api: resource metrics improvements
DaanHoogland commented on PR #6803: URL: https://github.com/apache/cloudstack/pull/6803#issuecomment-1333936372 > This PR is addressing several changes in different contexts (VM stats, disk stats, system VM stats, and UI). I think it would be better both for managing, reviewing, and testing if they were separated in different PRs, also improving the description of the changes and how they would affect users. Any concerns in how it affects users @GutoVeronezi ? cc @shwstppr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6869: Support for parameter `cidrlist` added to the UI
blueorangutan commented on PR #6869: URL: https://github.com/apache/cloudstack/pull/6869#issuecomment-1333930800 @DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6869: Support for parameter `cidrlist` added to the UI
DaanHoogland commented on PR #6869: URL: https://github.com/apache/cloudstack/pull/6869#issuecomment-1333930403 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6936: host affinity: fix vm cannot be started if a vm is stopped in the affinity group
sonarcloud[bot] commented on PR #6936: URL: https://github.com/apache/cloudstack/pull/6936#issuecomment-1333874756 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack=6936) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6936=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6936=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=6936=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6936=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6936=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=6936=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6936=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6936=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6936=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6936=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6936=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=6936=false=CODE_SMELL) [![38.5%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/25-16px.png '38.5%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=6936=new_coverage=list) [38.5% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=6936=new_coverage=list) [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=6936=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=6936=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6526: [HEALTH] 4.17 Health Check please don't merge this
blueorangutan commented on PR #6526: URL: https://github.com/apache/cloudstack/pull/6526#issuecomment-1333865291 Trillian Build Failed (tid-5331) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6845: [WIP] new plugins: Add non strict affinity groups
blueorangutan commented on PR #6845: URL: https://github.com/apache/cloudstack/pull/6845#issuecomment-1333851144 @vladimirpetrov a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] vladimirpetrov commented on pull request #6845: [WIP] new plugins: Add non strict affinity groups
vladimirpetrov commented on PR #6845: URL: https://github.com/apache/cloudstack/pull/6845#issuecomment-1333850312 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6526: [HEALTH] 4.17 Health Check please don't merge this
blueorangutan commented on PR #6526: URL: https://github.com/apache/cloudstack/pull/6526#issuecomment-1333814390 @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6526: [HEALTH] 4.17 Health Check please don't merge this
DaanHoogland commented on PR #6526: URL: https://github.com/apache/cloudstack/pull/6526#issuecomment-1333813824 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6898: Fix spelling
blueorangutan commented on PR #6898: URL: https://github.com/apache/cloudstack/pull/6898#issuecomment-1333807829 Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 4724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6898: Fix spelling
blueorangutan commented on PR #6898: URL: https://github.com/apache/cloudstack/pull/6898#issuecomment-1333806553 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6898: Fix spelling
DaanHoogland commented on PR #6898: URL: https://github.com/apache/cloudstack/pull/6898#issuecomment-1333805217 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Arceoavs opened a new issue, #6937: Extraconfig values cannot be added for VMs that are shut down
Arceoavs opened a new issue, #6937: URL: https://github.com/apache/cloudstack/issues/6937 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ VM Management ~~~ # CLOUDSTACK VERSION ~~~ 4.17.1.0 ~~~ # CONFIGURATION N/A # OS / ENVIRONMENT N/A # SUMMARY When a user (with admin rights or without) creates an extraconfig under Settings for a VM that is switched off, one cannot enter a value in the Value input field. The UI refuses any keyboard input and the browser displays error messages. ![image](https://user-images.githubusercontent.com/16841883/205068736-2b3a5ae3-fbd4-4735-903c-71b86b267eea.png) # STEPS TO REPRODUCE ~~~ Create a VM. Switch it off. Go to Settings and try to add a configuration. Look at the Browser console. ~~~ # EXPECTED RESULTS ~~~ Values can be set. ~~~ # ACTUAL RESULTS ~~~ Values cannot be set. ~~~ Output in the Browser console: ``` config and theme applied [App.vue:40:12](webpack:///src/App.vue) Object { data: {…}, status: 401, statusText: "Unauthorized", headers: {…}, config: {…}, request: XMLHttpRequest } [request.js:37:12](webpack:///src/utils/request.js) Some cookies are misusing the recommended “SameSite“ attribute 22 Cookie “rl_anonymous_id” has been rejected because it is already expired. [api](https://sparci-cloudstack.uni-koblenz.de/client/api/?command=logout=json) Cookie “rl_page_init_referrer” has been rejected because it is already expired. [api](https://sparci-cloudstack.uni-koblenz.de/client/api/?command=logout=json) Cookie “rl_page_init_referring_domain” has been rejected because it is already expired. [api](https://sparci-cloudstack.uni-koblenz.de/client/api/?command=logout=json) Cookie “rl_user_id” has been rejected because it is already expired. [api](https://sparci-cloudstack.uni-koblenz.de/client/api/?command=logout=json) Cookie “rl_trait” has been rejected because it is already expired. [api](https://sparci-cloudstack.uni-koblenz.de/client/api/?command=logout=json) Object { data: {…}, status: 432, statusText: "432", headers: {…}, config: {…}, request: XMLHttpRequest } [request.js:37:12](webpack:///src/utils/request.js) Error: Request failed with status code 432 exports createError.js:16 exports settle.js:17 c xhr.js:54 [SamlDomainSwitcher.vue:85:18](webpack:///src/components/header/SamlDomainSwitcher.vue) Object { data: {…}, status: 431, statusText: "Request Header Fields Too Large", headers: {…}, config: {…}, request: XMLHttpRequest } [request.js:37:12](webpack:///src/utils/request.js) Uncaught (in promise) Error: Request failed with status code 431 exports createError.js:16 exports settle.js:17 c xhr.js:54 [createError.js:16:14](webpack:///node_modules/axios/lib/core/createError.js) TypeError: Invalid attempt to spread non-iterable instance. In order to be iterable, non-array objects must have a [Symbol.iterator]() method. Babel 2 C generate.js:341 run reactivity.esm-bundler.js:167 get value reactivity.esm-bundler.js:1101 Q generate.js:553 run reactivity.esm-bundler.js:167 get value reactivity.esm-bundler.js:1101 setup generate.js:558 g runtime-core.esm-bundler.js:155 C runtime-core.esm-bundler.js:164 u runtime-core.esm-bundler.js:1726 run reactivity.esm-bundler.js:167 h runtime-core.esm-bundler.js:1790 tn runtime-core.esm-bundler.js:328 P runtime-core.esm-bundler.js:5168 e runtime-core.esm-bundler.js:5080 run reactivity.esm-bundler.js:167 U runtime-core.esm-bundler.js:4968 W runtime-core.esm-bundler.js:4901 C runtime-core.esm-bundler.js:4489 e runtime-core.esm-bundler.js:5107 run reactivity.esm-bundler.js:167 U runtime-core.esm-bundler.js:4968 W runtime-core.esm-bundler.js:4901 C runtime-core.esm-bundler.js:4489 e runtime-core.esm-bundler.js:5107 run reactivity.esm-bundler.js:167 U runtime-core.esm-bundler.js:4968 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache opened a new pull request, #6936: host affinity: fix vm cannot be started if a vm is stopped in the affinity group
weizhouapache opened a new pull request, #6936: URL: https://github.com/apache/cloudstack/pull/6936 ### Description This PR fixes #6933 ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ### Feature/Enhancement Scale or Bug Severity Feature/Enhancement Scale - [ ] Major - [ ] Minor Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez closed pull request #6935: Fix hosts VMs listing
nvazquez closed pull request #6935: Fix hosts VMs listing URL: https://github.com/apache/cloudstack/pull/6935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6935: Fix hosts VMs listing
nvazquez commented on PR #6935: URL: https://github.com/apache/cloudstack/pull/6935#issuecomment-1333745030 Closing this one in favour of #6851 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6935: Fix hosts VMs listing
sonarcloud[bot] commented on PR #6935: URL: https://github.com/apache/cloudstack/pull/6935#issuecomment-1333725990 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack=6935) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6935=false=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6935=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=6935=false=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6935=false=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6935=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=6935=false=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6935=false=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6935=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6935=false=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6935=false=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6935=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=6935=false=CODE_SMELL) [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=6935=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=6935=new_coverage=list) [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=6935=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=6935=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6935: Fix hosts VMs listing
blueorangutan commented on PR #6935: URL: https://github.com/apache/cloudstack/pull/6935#issuecomment-1333691859 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6851: api,server: fix listing vm metrics for infra resources
rohityadavcloud commented on PR #6851: URL: https://github.com/apache/cloudstack/pull/6851#issuecomment-1333668891 cc @nvazquez -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud closed issue #6931: List Instances in Host lists all instances
rohityadavcloud closed issue #6931: List Instances in Host lists all instances URL: https://github.com/apache/cloudstack/issues/6931 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on issue #6931: List Instances in Host lists all instances
rohityadavcloud commented on issue #6931: URL: https://github.com/apache/cloudstack/issues/6931#issuecomment-1333668021 Duplicate of https://github.com/apache/cloudstack/issues/6786 closing this. @alexandremattioli @nvazquez we've another PR from Abhishek. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #6935: Fix hosts VMs listing
rohityadavcloud commented on code in PR #6935: URL: https://github.com/apache/cloudstack/pull/6935#discussion_r1037029748 ## api/src/main/java/org/apache/cloudstack/api/command/user/vm/ListVMsCmd.java: ## @@ -65,6 +66,9 @@ public class ListVMsCmd extends BaseListTaggedResourcesCmd implements UserCmd { @Parameter(name = ApiConstants.GROUP_ID, type = CommandType.UUID, entityType = InstanceGroupResponse.class, description = "the group ID") private Long groupId; +@Parameter(name = ApiConstants.HOST_ID, type = CommandType.UUID, entityType = HostResponse.class, description = "the host ID") +private Long hostId; Review Comment: @nvazquez we can't do this; allow end users to pass this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] alexandremattioli commented on issue #6931: List Instances in Host lists all instances
alexandremattioli commented on issue #6931: URL: https://github.com/apache/cloudstack/issues/6931#issuecomment-1333652944 Thanks @nvazquez -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on issue #6931: List Instances in Host lists all instances
nvazquez commented on issue #6931: URL: https://github.com/apache/cloudstack/issues/6931#issuecomment-1333646349 @alexandremattioli I've posted a quick fix, its actually the API that's broken, the UI is passing the params correctly: (localcloud) > list virtualmachines hostid=ab815b86-a9ad-499c-a60f-4d85123d57c4 filter=id,name,hostid { "count": 1, "virtualmachine": [ { "hostid": "ab815b86-a9ad-499c-a60f-4d85123d57c4", "id": "f3621224-0f19-4e55-bf3b-8504bd5ce346", "name": "VM-f3621224-0f19-4e55-bf3b-8504bd5ce346" } ] } (localcloud) > list virtualmachinesmetrics hostid=ab815b86-a9ad-499c-a60f-4d85123d57c4 filter=id,name,hostid { "count": 2, "virtualmachine": [ { "hostid": "734acbc4-80c9-44c0-aaab-75f276469fd4", "id": "35fef250-5c4d-4705-b707-069102a32991", "name": "VM-35fef250-5c4d-4705-b707-069102a32991" }, { "hostid": "ab815b86-a9ad-499c-a60f-4d85123d57c4", "id": "f3621224-0f19-4e55-bf3b-8504bd5ce346", "name": "VM-f3621224-0f19-4e55-bf3b-8504bd5ce346" } ] } -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6935: Fix hosts VMs listing
blueorangutan commented on PR #6935: URL: https://github.com/apache/cloudstack/pull/6935#issuecomment-1333642213 @nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6935: Fix hosts VMs listing
nvazquez commented on PR #6935: URL: https://github.com/apache/cloudstack/pull/6935#issuecomment-1333640885 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez opened a new pull request, #6935: Fix hosts VMs listing
nvazquez opened a new pull request, #6935: URL: https://github.com/apache/cloudstack/pull/6935 ### Description This PR fixes the 'View Instances' listing for hosts. The hostid parameter was removed for the listVirtualMachineMetrics API by PR: #6143 so despite the parameter was passed correctly in the UI, the API returned all the VMs and didnt filter them by host ID Fixes: #6931 ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ### Feature/Enhancement Scale or Bug Severity Feature/Enhancement Scale - [ ] Major - [ ] Minor Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6898: Fix spelling
blueorangutan commented on PR #6898: URL: https://github.com/apache/cloudstack/pull/6898#issuecomment-1333608189 Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 4722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6924: [Draft] User two factor authentication
blueorangutan commented on PR #6924: URL: https://github.com/apache/cloudstack/pull/6924#issuecomment-1333601685 Trillian Build Failed (tid-5328) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #6851: api,server: fix listing vm metrics for infra resources
rohityadavcloud commented on code in PR #6851: URL: https://github.com/apache/cloudstack/pull/6851#discussion_r1036953610 ## plugins/metrics/src/main/java/org/apache/cloudstack/api/ListVMsMetricsCmdByAdmin.java: ## @@ -0,0 +1,74 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.cloudstack.api; + +import org.apache.cloudstack.acl.RoleType; +import org.apache.cloudstack.api.command.admin.AdminCmd; +import org.apache.cloudstack.api.response.ClusterResponse; +import org.apache.cloudstack.api.response.HostResponse; +import org.apache.cloudstack.api.response.PodResponse; +import org.apache.cloudstack.api.response.StoragePoolResponse; +import org.apache.cloudstack.response.VmMetricsResponse; + +@APICommand(name = ListVMsMetricsCmd.APINAME, description = "Lists VM metrics", responseObject = VmMetricsResponse.class, +requestHasSensitiveInfo = false, responseHasSensitiveInfo = false, responseView = ResponseObject.ResponseView.Full, +since = "4.9.3", authorized = {RoleType.Admin}) Review Comment: it might cause issue with apidocs generation - to be clear this isn't adding a new API; but an admin cmd (api with admin specific params) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6912: vmware: fix vmware vm snapshot operations for datastorecluster
blueorangutan commented on PR #6912: URL: https://github.com/apache/cloudstack/pull/6912#issuecomment-1333547556 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6511: [HEALTH] 4.18/main Health Check, please don't merge this!
blueorangutan commented on PR #6511: URL: https://github.com/apache/cloudstack/pull/6511#issuecomment-1333546701 Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6526: [HEALTH] 4.17 Health Check please don't merge this
blueorangutan commented on PR #6526: URL: https://github.com/apache/cloudstack/pull/6526#issuecomment-1333536557 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] xuanyuanaosheng opened a new issue, #6934: Please add a test button in Domains LDAP config
xuanyuanaosheng opened a new issue, #6934: URL: https://github.com/apache/cloudstack/issues/6934 # ISSUE TYPE * Improvement Request * Enhancement Request # COMPONENT NAME * LDAP Config # SUMMARY Please add a button to test the ldaps connection or a list button to list some user button. ![image](https://user-images.githubusercontent.com/4197714/205022886-bff7c22e-aad4-45b2-8e39-01994ae43a17.png) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] vladimirpetrov opened a new issue, #6933: VMs using strict host affinity cannot be started
vladimirpetrov opened a new issue, #6933: URL: https://github.com/apache/cloudstack/issues/6933 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ API ~~~ # CLOUDSTACK VERSION ~~~ 4.18 ~~~ # CONFIGURATION N/A # OS / ENVIRONMENT N/A # SUMMARY When all VMs using the same strict host affinity group are stopped, they cannot be started anymore. # STEPS TO REPRODUCE ~~~ 1. Create a new strict host affinity group 2. Deploy two VMs which use this affinity group 3. Stop both VMs 4. Try to start any of the VMs ~~~ # EXPECTED RESULTS ~~~ The VMs should start normally. ~~~ # ACTUAL RESULTS ~~~ The VMs cannot be started anymore. ~~~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] xuanyuanaosheng closed issue #6920: The cloudstack version 4.17.1.0 Second storage only has S3
xuanyuanaosheng closed issue #6920: The cloudstack version 4.17.1.0 Second storage only has S3 URL: https://github.com/apache/cloudstack/issues/6920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] xuanyuanaosheng commented on issue #6920: The cloudstack version 4.17.1.0 Second storage only has S3
xuanyuanaosheng commented on issue #6920: URL: https://github.com/apache/cloudstack/issues/6920#issuecomment-1333489076 I will close this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] xuanyuanaosheng opened a new issue, #6932: Usage problem: Is there another way besides "Setting Up a Site-to-Site VPN Connection" ?
xuanyuanaosheng opened a new issue, #6932: URL: https://github.com/apache/cloudstack/issues/6932 Is there another way besides "Setting Up a Site-to-Site VPN Connection" ? like aws line -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6512: Refactor test and change IP range
blueorangutan commented on PR #6512: URL: https://github.com/apache/cloudstack/pull/6512#issuecomment-1333475325 Trillian Build Failed (tid-5325) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6512: Refactor test and change IP range
blueorangutan commented on PR #6512: URL: https://github.com/apache/cloudstack/pull/6512#issuecomment-1333464020 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6912: vmware: fix vmware vm snapshot operations for datastorecluster
blueorangutan commented on PR #6912: URL: https://github.com/apache/cloudstack/pull/6912#issuecomment-1333435389 @vladimirpetrov a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] vladimirpetrov commented on pull request #6912: vmware: fix vmware vm snapshot operations for datastorecluster
vladimirpetrov commented on PR #6912: URL: https://github.com/apache/cloudstack/pull/6912#issuecomment-1333434929 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6924: [Draft] User two factor authentication
blueorangutan commented on PR #6924: URL: https://github.com/apache/cloudstack/pull/6924#issuecomment-1333408002 Trillian Build Failed (tid-5324) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org