[GitHub] [cloudstack] blueorangutan commented on pull request #6936: host affinity: fix vm cannot be started if a vm is stopped in the affinity group
blueorangutan commented on PR #6936: URL: https://github.com/apache/cloudstack/pull/6936#issuecomment-1336088429 Trillian test result (tid-5377) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44512 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6936-t5377-kvm-centos7.zip Smoke tests completed. 100 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_08_upgrade_kubernetes_ha_cluster | `Failure` | 3640.25 | test_kubernetes_clusters.py test_09_delete_kubernetes_ha_cluster | `Failure` | 0.06 | test_kubernetes_clusters.py ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 78.51 | test_kubernetes_clusters.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6571: [WIP] VM Autoscaling with virtual router
blueorangutan commented on PR #6571: URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1336025436 Trillian test result (tid-5374) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45171 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6571-t5374-vmware-65u2.zip Smoke tests completed. 104 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_08_upgrade_kubernetes_ha_cluster | `Failure` | 860.59 | test_kubernetes_clusters.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6511: [HEALTH] 4.18/main Health Check, please don't merge this!
blueorangutan commented on PR #6511: URL: https://github.com/apache/cloudstack/pull/6511#issuecomment-1336012700 Trillian test result (tid-5372) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43294 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6511-t5372-vmware-65u2.zip Smoke tests completed. 104 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6930: debian build: add python3-setuptools to dependencies
blueorangutan commented on PR #6930: URL: https://github.com/apache/cloudstack/pull/6930#issuecomment-1336006225 Trillian test result (tid-5376) Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22 Total time taken: 39554 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6930-t5376-kvm-ubuntu22.zip Smoke tests completed. 100 look OK, 4 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_DeployVmAntiAffinityGroup | `Error` | 35.65 | test_affinity_groups.py test_DeployVmAntiAffinityGroup_in_project | `Error` | 88.37 | test_affinity_groups_projects.py test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 22.84 | test_kubernetes_clusters.py test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.06 | test_kubernetes_clusters.py test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.06 | test_kubernetes_clusters.py test_09_delete_kubernetes_ha_cluster | `Failure` | 0.06 | test_kubernetes_clusters.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 304.24 | test_hostha_kvm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6571: [WIP] VM Autoscaling with virtual router
blueorangutan commented on PR #6571: URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1335960088 Trillian test result (tid-5364) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41622 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6571-t5364-xenserver-71.zip Smoke tests completed. 105 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6825: resolve sanity check last id file acces problems
blueorangutan commented on PR #6825: URL: https://github.com/apache/cloudstack/pull/6825#issuecomment-1335955145 Trillian test result (tid-5367) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39854 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6825-t5367-kvm-centos7.zip Smoke tests completed. 103 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_08_upgrade_kubernetes_ha_cluster | `Failure` | 790.64 | test_kubernetes_clusters.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6571: [WIP] VM Autoscaling with virtual router
blueorangutan commented on PR #6571: URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1335942547 Trillian test result (tid-5365) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39491 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6571-t5365-kvm-centos7.zip Smoke tests completed. 105 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6511: [HEALTH] 4.18/main Health Check, please don't merge this!
blueorangutan commented on PR #6511: URL: https://github.com/apache/cloudstack/pull/6511#issuecomment-1335873278 Trillian test result (tid-5357) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39817 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6511-t5357-kvm-centos7.zip Smoke tests completed. 103 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_08_upgrade_kubernetes_ha_cluster | `Failure` | 577.84 | test_kubernetes_clusters.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6508: Inserts timer in check detach volume
blueorangutan commented on PR #6508: URL: https://github.com/apache/cloudstack/pull/6508#issuecomment-1335840620 Trillian test result (tid-5345) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43810 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6508-t5345-kvm-centos7.zip Smoke tests completed. 102 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_08_upgrade_kubernetes_ha_cluster | `Failure` | 578.89 | test_kubernetes_clusters.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 463.01 | test_vpc_redundant.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6526: [HEALTH] 4.17 Health Check please don't merge this
blueorangutan commented on PR #6526: URL: https://github.com/apache/cloudstack/pull/6526#issuecomment-1335829700 Trillian test result (tid-5349) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40741 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6526-t5349-kvm-centos7.zip Smoke tests completed. 100 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 467.52 | test_vpc_redundant.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6511: [HEALTH] 4.18/main Health Check, please don't merge this!
blueorangutan commented on PR #6511: URL: https://github.com/apache/cloudstack/pull/6511#issuecomment-1335810051 Trillian test result (tid-5356) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 35127 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6511-t5356-xenserver-71.zip Smoke tests completed. 104 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6917: Improvements and cleanup on the javadocs of QemuImg
blueorangutan commented on PR #6917: URL: https://github.com/apache/cloudstack/pull/6917#issuecomment-1335767747 Trillian test result (tid-5344) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40114 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6917-t5344-kvm-centos7.zip Smoke tests completed. 101 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_07_arping_in_vr | `Failure` | 5.19 | test_diagnostics.py test_create_pvlan_network | `Error` | 0.05 | test_pvlan.py test_08_upgrade_kubernetes_ha_cluster | `Failure` | 549.12 | test_kubernetes_clusters.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] stephankruggg commented on pull request #6892: Externalize KVM HA heartbeat frequency
stephankruggg commented on PR #6892: URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1335631869 > @stephankruggg in my test env I keep seeing this: > > ``` > "2022-12-02 14:36:53 Adding KVM host pr6892-t5375-kvm-centos7-kvm1.", "🙈 Error: (HTTP 530, error code ) Could not add host at [http://10.0.33.209/] with zone [1], pod [1] and cluster [1] due to: [ can't setup agent, due to com.cloud.utils.exception.CloudRuntimeException: Failed to setup certificate in the KVM agent's keystore file, please see logs and configure manually! - Failed to setup certificate in the KVM agent's keystore file, please see logs and configure manually!] > ``` > > can you explain that? Hi, @DaanHoogland, I have not observed this error during my tests. The changes do not seem to affect certificates in KVM, thus, could you send some of the logs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6512: Refactor test and change IP range
blueorangutan commented on PR #6512: URL: https://github.com/apache/cloudstack/pull/6512#issuecomment-1335621944 Trillian test result (tid-5348) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31923 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6512-t5348-kvm-centos7.zip Smoke tests completed. 91 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #6803: ui,server,api: resource metrics improvements
GutoVeronezi commented on PR #6803: URL: https://github.com/apache/cloudstack/pull/6803#issuecomment-1335575437 > > This PR is addressing several changes in different contexts (VM stats, disk stats, system VM stats, and UI). I think it would be better both for managing, reviewing, and testing if they were separated in different PRs, also improving the description of the changes and how they would affect users. > > Any concerns in how it affects users @GutoVeronezi ? cc @shwstppr @DaanHoogland, in both approaches users will have the feature; therefore, it does not affect them directly. As the changes are not dependent on each other, the suggestion to segregating it in several PRs focus on facilitating the reviewing, testing, and management of the features. In my opinion, it would be more interesting to have single scope PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts
blueorangutan commented on PR #6783: URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1335567464 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6841: default should map always, not require the minHypervisorVersion
blueorangutan commented on PR #6841: URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1335567465 Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts
blueorangutan commented on PR #6783: URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1335563998 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 4753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6936: host affinity: fix vm cannot be started if a vm is stopped in the affinity group
blueorangutan commented on PR #6936: URL: https://github.com/apache/cloudstack/pull/6936#issuecomment-1335560079 @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6936: host affinity: fix vm cannot be started if a vm is stopped in the affinity group
weizhouapache commented on PR #6936: URL: https://github.com/apache/cloudstack/pull/6936#issuecomment-1335559536 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] AlexanderKgr commented on issue #6941: Xcp-ng 8.2.1 - issues reverting to vm snapshot
AlexanderKgr commented on issue #6941: URL: https://github.com/apache/cloudstack/issues/6941#issuecomment-1335512115 Let me clear this. 1st scenario tried to restore a disk snapshot while the instance is off (from cloudstack and from xen orchestra) Received the error that hypervisor doesn't support guest os - while the instance was working normaly if booted. It was for a colleague that he wanted to revert his instance to a previous state. So tried the 2nd scenario. Shuted down the instance only from console and tried to restored it from xen orchestra, where there wasn't any snapshot. Tried from cloudstack to restore and i had the error that i couldn't restore disk in a running instance which is normal. Tried scenarios with disk and memory and everything is working. Summing up "disk" snapshots with xcp-ng does not work! Please try it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] vladimirpetrov closed issue #6933: VMs using strict host affinity cannot be started
vladimirpetrov closed issue #6933: VMs using strict host affinity cannot be started URL: https://github.com/apache/cloudstack/issues/6933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] vladimirpetrov commented on issue #6933: VMs using strict host affinity cannot be started
vladimirpetrov commented on issue #6933: URL: https://github.com/apache/cloudstack/issues/6933#issuecomment-1335509475 LGTM based on manual testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6902: fix of removing the Iops limits on StorPool volumes
blueorangutan commented on PR #6902: URL: https://github.com/apache/cloudstack/pull/6902#issuecomment-1335473814 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts
blueorangutan commented on PR #6783: URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1335454421 Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 4751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6841: default should map always, not require the minHypervisorVersion
blueorangutan commented on PR #6841: URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1335453071 Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6858: allow a new upgrade version without DB changes to be inserted
blueorangutan commented on PR #6858: URL: https://github.com/apache/cloudstack/pull/6858#issuecomment-1335446995 Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 4749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] StepBee commented on issue #6807: Custom Constrained Service Offering vs Qemu - CPU topology doesn't match maximum vcpu count
StepBee commented on issue #6807: URL: https://github.com/apache/cloudstack/issues/6807#issuecomment-1335442683 @DaanHoogland indeed i happily saw it and would we ready to test. I have to admit i would require a hint how to obtain this patch (i see only 1 file was changed and would require replacement) or the patched release - never tested before and relied on the releases. Do you have a hint/link for a hint for me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6892: Externalize KVM HA heartbeat frequency
DaanHoogland commented on PR #6892: URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1335385885 @stephankruggg in my test env I keep seeing this: ``` "2022-12-02 14:36:53 Adding KVM host pr6892-t5375-kvm-centos7-kvm1.", "🙈 Error: (HTTP 530, error code ) Could not add host at [http://10.0.33.209/] with zone [1], pod [1] and cluster [1] due to: [ can't setup agent, due to com.cloud.utils.exception.CloudRuntimeException: Failed to setup certificate in the KVM agent's keystore file, please see logs and configure manually! - Failed to setup certificate in the KVM agent's keystore file, please see logs and configure manually!] ``` can you explain that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency
blueorangutan commented on PR #6892: URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1335375583 Trillian Build Failed (tid-5375) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6902: fix of removing the Iops limits on StorPool volumes
blueorangutan commented on PR #6902: URL: https://github.com/apache/cloudstack/pull/6902#issuecomment-1335339657 @nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6902: fix of removing the Iops limits on StorPool volumes
nvazquez commented on PR #6902: URL: https://github.com/apache/cloudstack/pull/6902#issuecomment-1335338977 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a diff in pull request #6902: fix of removing the Iops limits on StorPool volumes
nvazquez commented on code in PR #6902:
URL: https://github.com/apache/cloudstack/pull/6902#discussion_r1038211490
##
plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/driver/StorPoolPrimaryDataStoreDriver.java:
##
@@ -273,9 +273,11 @@ public void resize(DataObject data,
AsyncCompletionCallback cal
try {
SpConnectionDesc conn =
StorPoolUtil.getSpConnection(data.getDataStore().getUuid(),
data.getDataStore().getId(), storagePoolDetailsDao, primaryStoreDao);
-StorPoolUtil.spLog("StorpoolPrimaryDataStoreDriverImpl.resize:
name=%s, uuid=%s, oldSize=%d, newSize=%s, shrinkOk=%s", name, vol.getUuid(),
oldSize, payload.newSize, payload.shrinkOk);
+long maxIops = payload.newMaxIops == null ? Long.valueOf(0) :
payload.newMaxIops;
Review Comment:
Maybe also add a null check for payload?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6943: [Veeam] Fix escape powershell comand when listing Veeam repository names
sonarcloud[bot] commented on PR #6943: URL: https://github.com/apache/cloudstack/pull/6943#issuecomment-1335338011 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6943) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6943&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6943&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6943&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6943&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6943&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6943&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6943&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6943&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6943&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6943&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6943&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6943&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6943&metric=coverage&view=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6943&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6943&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6812: Normalize encryption on global configurations values
blueorangutan commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1335325329 Trillian Build Failed (tid-5373) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a diff in pull request #6899: Count Resource Virtual Router
nvazquez commented on code in PR #6899:
URL: https://github.com/apache/cloudstack/pull/6899#discussion_r1038193298
##
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java:
##
@@ -1398,15 +1405,152 @@ private void
logBootModeParameters(Map para
}
}
+/**
+ * Returns the service offering by the given configuration.
+ *
+ * @param configName name of the config
+ * @return the service offering found or null if not found
+ */
+public ServiceOffering getServiceOfferingByConfig(String configName) {
+ServiceOffering defaultRouterOffering = null;
+final String globalRouterOffering = configDao.getValue(configName);
Review Comment:
Instead of the configDao, can we access the setting via
`VirtualNetworkApplianceManager.VirtualRouterServiceOffering` (for
`router.service.offering`)?
##
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java:
##
@@ -1398,15 +1405,152 @@ private void
logBootModeParameters(Map para
}
}
+/**
+ * Returns the service offering by the given configuration.
+ *
+ * @param configName name of the config
+ * @return the service offering found or null if not found
+ */
+public ServiceOffering getServiceOfferingByConfig(String configName) {
+ServiceOffering defaultRouterOffering = null;
+final String globalRouterOffering = configDao.getValue(configName);
+
+if (globalRouterOffering != null) {
+defaultRouterOffering =
_serviceOfferingDao.findByUuid(globalRouterOffering);
+}
+
+if (defaultRouterOffering == null) {
+defaultRouterOffering =
_serviceOfferingDao.findByName(ServiceOffering.routerDefaultOffUniqueName);
+}
+
+return defaultRouterOffering;
+}
+
+/**
+ * Counts VR resources for the domain if global setting is true.
+ * if value is "all" count all VR resources else get diff of
+ * current VR offering and default VR offering
+ *
+ * @param offering VR service offering
+ * @param defaultRouterOffering default VR service offering
+ * @param owner account
+ * @return a Pair of cpu and ram
+ */
+private Pair resolveCpuAndMemoryCount(ServiceOffering
offering, ServiceOffering defaultRouterOffering, Account owner) {
+Integer cpuCount = 0;
+Integer memoryCount = 0;
+if
(COUNT_ALL_VR_RESOURCES.equalsIgnoreCase(ResourceCountRoutersType.valueIn(owner.getDomainId(
{
+cpuCount = offering.getCpu();
+memoryCount = offering.getRamSize();
+} else if
(COUNT_DELTA_VR_RESOURCES.equalsIgnoreCase(ResourceCountRoutersType.valueIn(owner.getDomainId(
{
+// Default offering value can be greater than current offering
value
+if (offering.getCpu() >= defaultRouterOffering.getCpu()) {
+cpuCount = offering.getCpu() - defaultRouterOffering.getCpu();
+}
+if (offering.getRamSize() >= defaultRouterOffering.getRamSize()) {
+memoryCount = offering.getRamSize() -
defaultRouterOffering.getRamSize();
+}
+}
+
+return Pair.of(cpuCount.longValue(), memoryCount.longValue());
+}
+
+private void validateResourceCount(Pair cpuMemoryCount,
Account owner) {
+final Long cpuCount = cpuMemoryCount.first();
+final Long memoryCount = cpuMemoryCount.second();
+try {
+if (cpuCount > 0) {
+_resourceLimitMgr.checkResourceLimit(owner, ResourceType.cpu,
cpuCount);
+}
+if (memoryCount > 0) {
+_resourceLimitMgr.checkResourceLimit(owner,
ResourceType.memory, memoryCount);
+}
+} catch (ResourceAllocationException ex) {
+throw new CloudRuntimeException(String.format("Unable to
deploy/start routers due to {}", ex.getMessage()));
+}
+}
+
+/**
+ * Check if resource count can be allocated to account/domain
+ *
+ * @param cpuMemoryCount a Pair of cpu and ram
+ * @param owner the account
+ */
+private void calculateResourceCount(Pair cpuMemoryCount,
Account owner, boolean isIncrement) {
+validateResourceCount(cpuMemoryCount, owner);
+final Long cpuCount = cpuMemoryCount.first();
+final Long memoryCount = cpuMemoryCount.second();
+
+// Increment the resource count
+if (s_logger.isDebugEnabled()) {
+if(isIncrement) {
+s_logger.debug(String.format("Incrementing the CPU count with
value %s and RAM value with %s", cpuCount, memoryCount));
+} else {
+s_logger.debug(String.format("Decrementing cpu resource count
with value %s and memory resource with value %s",cpuCount, memoryCount));
+}
+}
+
+if(isIncrement) {
+_resourceLimitMgr.incrementResourceCount(owner.getAcco
[GitHub] [cloudstack] codecov[bot] commented on pull request #6943: [Veeam] Fix escape powershell comand when listing Veeam repository names
codecov[bot] commented on PR #6943: URL: https://github.com/apache/cloudstack/pull/6943#issuecomment-1335297554 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6943?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#6943](https://codecov.io/gh/apache/cloudstack/pull/6943?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9e6ca61) into [main](https://codecov.io/gh/apache/cloudstack/commit/3d8ea4f3b3ee1c009871e00d20ea03087cdc18a0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3d8ea4f) will **increase** coverage by `0.00%`. > The diff coverage is `n/a`. ```diff @@Coverage Diff@@ ## main#6943 +/- ## = Coverage 10.87% 10.88% - Complexity 7118 7121+3 = Files 2485 2485 Lines245522 245522 Branches 3833538335 = + Hits 2670126714 +13 + Misses 215550 215536 -14 - Partials 3271 3272+1 ``` | [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6943?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...rg/apache/cloudstack/backup/veeam/VeeamClient.java](https://codecov.io/gh/apache/cloudstack/pull/6943/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9iYWNrdXAvdmVlYW0vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svYmFja3VwL3ZlZWFtL1ZlZWFtQ2xpZW50LmphdmE=) | `16.40% <ø> (ø)` | | | [...apache/cloudstack/syslog/AlertsSyslogAppender.java](https://codecov.io/gh/apache/cloudstack/pull/6943/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hbGVydC1oYW5kbGVycy9zeXNsb2ctYWxlcnRzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N5c2xvZy9BbGVydHNTeXNsb2dBcHBlbmRlci5qYXZh) | `58.75% <0.00%> (+2.25%)` | :arrow_up: | | [...rg/apache/cloudstack/quota/QuotaStatementImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6943/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZnJhbWV3b3JrL3F1b3RhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3F1b3RhL1F1b3RhU3RhdGVtZW50SW1wbC5qYXZh) | `40.26% <0.00%> (+3.98%)` | :arrow_up: | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6939: When VM is created and ROOT volume is created it should emit a VOLUME.CREATE event
blueorangutan commented on PR #6939: URL: https://github.com/apache/cloudstack/pull/6939#issuecomment-1335260489 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6511: [HEALTH] 4.18/main Health Check, please don't merge this!
blueorangutan commented on PR #6511: URL: https://github.com/apache/cloudstack/pull/6511#issuecomment-1335259557 Trillian Build Failed (tid-5371) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6832: Allow root admin to deploy in VPCs in child domains
blueorangutan commented on PR #6832: URL: https://github.com/apache/cloudstack/pull/6832#issuecomment-1335254025 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6858: allow a new upgrade version without DB changes to be inserted
blueorangutan commented on PR #6858: URL: https://github.com/apache/cloudstack/pull/6858#issuecomment-1335254026 Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 4747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6841: default should map always, not require the minHypervisorVersion
blueorangutan commented on PR #6841: URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1335254024 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] SadiJr opened a new pull request, #6943: [Veeam] Fix escape powershell comand when listing Veeam repository names
SadiJr opened a new pull request, #6943:
URL: https://github.com/apache/cloudstack/pull/6943
PR #5774 introduced a functionality to allow operators to choose in which
Veeam's repository, if more than one is configured, ACS' clone job will be
executed. However, a change was missing in the PR and caused the errors
reported in #6599.
This PR addresses the fix for #6599.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
It was tested in a local laboratory:
- I assigned three VMs to three Backup Offerings;
- Before, the assign fails, with the same message reported in issue #6599;
- Now the assign works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #6941: Xcp-ng 8.2.1 - issues reverting to vm snapshot
DaanHoogland commented on issue #6941: URL: https://github.com/apache/cloudstack/issues/6941#issuecomment-1335215630 @AlexanderKgr you can revert a disk to a disk snapshot and a vm to a vm snapshot. It seems you are trying to revert a vm to a disk snapshot. Is that correct? Also you are describing in both examples restoring a powered off vm to a disk snapshot . Am I misunderstanding your scenarios? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #6940: Live Storage migration Ubuntu 20, does not work
DaanHoogland commented on issue #6940: URL: https://github.com/apache/cloudstack/issues/6940#issuecomment-1335198996 @happyalexkg is this something you were able to do in older versions? I am not sure if this was ever implemented. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
sonarcloud[bot] commented on PR #6942: URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1335188335 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6942) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6942&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6942&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6942&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6942&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6942&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6942&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6942&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6930: debian build: add python3-setuptools to dependencies
blueorangutan commented on PR #6930: URL: https://github.com/apache/cloudstack/pull/6930#issuecomment-1335184946 Trillian Build Failed (tid-5370) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6924: [Draft] User two factor authentication
weizhouapache commented on code in PR #6924:
URL: https://github.com/apache/cloudstack/pull/6924#discussion_r1038114229
##
api/src/main/java/org/apache/cloudstack/api/command/admin/user/UpdateUserCmd.java:
##
@@ -80,6 +80,9 @@ public class UpdateUserCmd extends BaseCmd {
@Parameter(name = ApiConstants.USERNAME, type = CommandType.STRING,
description = "Unique username")
private String username;
+@Parameter(name = ApiConstants.MANDATE_2FA, type = CommandType.BOOLEAN,
description = "Provide true to mandate the user to use two factor
authentication has to be enabled. This parameter is only used to mandate 2FA,
not to disable 2FA")
Review Comment:
@harikrishna-patnala
is `mandate2fa` a parameter only for admins (root admin, domain admin) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6511: [HEALTH] 4.18/main Health Check, please don't merge this!
blueorangutan commented on PR #6511: URL: https://github.com/apache/cloudstack/pull/6511#issuecomment-1335181757 Trillian Build Failed (tid-5369) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
andrijapanicsb commented on PR #6942: URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1335181942 thx @rohityadavcloud For the record: this has been impossible to reproduce in my test env (based on the instructions given by the relevant third party) - the problem is when doing multiple volume snapshots in multiple clusters, at the exact same time - ACS tries to add iptables rule inside SSVM to allow outgoing traffic (to vCenter I think) - and since there are multiple concurrent attempts to add iptable rule - some of those would fail (since iptable has an internal locking mechanism where it creates a lock while an rule is being added, so another rule/thread can not run) - so some of the snapshot jobs would fail as a consequence of not being able to add iptable rule. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6939: When VM is created and ROOT volume is created it should emit a VOLUME.CREATE event
DaanHoogland commented on code in PR #6939:
URL: https://github.com/apache/cloudstack/pull/6939#discussion_r1038105245
##
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java:
##
@@ -871,7 +879,16 @@ public DiskProfile allocateRawVolume(Type type, String
name, DiskOffering offeri
_resourceLimitMgr.incrementResourceCount(vm.getAccountId(),
ResourceType.volume, vol.isDisplayVolume());
_resourceLimitMgr.incrementResourceCount(vm.getAccountId(),
ResourceType.primary_storage, vol.isDisplayVolume(), new Long(vol.getSize()));
}
-return toDiskProfile(vol, offering);
+DiskProfile diskProfile = toDiskProfile(vol, offering);
+
+// Set context information for VOLUME.CREATE event for ROOT disk.
+CallContext volumeContext = CallContext.current();
+if (type == Type.ROOT && volumeContext != null &&
volumeContext.getEventResourceType() == ApiCommandResourceType.Volume) {
+volumeContext.setEventDetails("Volume Id: " +
this._uuidMgr.getUuid(Volume.class, diskProfile.getVolumeId()) + " Vm Id: " +
this._uuidMgr.getUuid(VirtualMachine.class, vm.getId()));
+volumeContext.setEventResourceId(diskProfile.getVolumeId());
+}
Review Comment:
can you extract this to a separate method?
##
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java:
##
@@ -485,15 +486,22 @@ public void doInTransactionWithoutResult(final
TransactionStatus status) throws
s_logger.debug("Allocating disks for " + vmFinal);
}
-String rootVolumeName = String.format("ROOT-%s",
vmFinal.getId());
-if (template.getFormat() == ImageFormat.ISO) {
-volumeMgr.allocateRawVolume(Type.ROOT, rootVolumeName,
rootDiskOfferingInfo.getDiskOffering(), rootDiskOfferingInfo.getSize(),
-rootDiskOfferingInfo.getMinIops(),
rootDiskOfferingInfo.getMaxIops(), vmFinal, template, owner, null);
-} else if (template.getFormat() == ImageFormat.BAREMETAL) {
-s_logger.debug(String.format("%s has format [%s]. Skipping
ROOT volume [%s] allocation.", template.toString(), ImageFormat.BAREMETAL,
rootVolumeName));
-} else {
-volumeMgr.allocateTemplatedVolumes(Type.ROOT,
rootVolumeName, rootDiskOfferingInfo.getDiskOffering(), rootDiskSizeFinal,
-rootDiskOfferingInfo.getMinIops(),
rootDiskOfferingInfo.getMaxIops(), template, vmFinal, owner);
+// Create new Volume context and inject event resource type,
id and details to generate VOLUME.CREATE event for the ROOT disk.
+CallContext volumeContext =
CallContext.register(CallContext.current(), ApiCommandResourceType.Volume);
+try {
+String rootVolumeName = String.format("ROOT-%s",
vmFinal.getId());
+if (template.getFormat() == ImageFormat.ISO) {
+volumeMgr.allocateRawVolume(Type.ROOT, rootVolumeName,
rootDiskOfferingInfo.getDiskOffering(), rootDiskOfferingInfo.getSize(),
+rootDiskOfferingInfo.getMinIops(),
rootDiskOfferingInfo.getMaxIops(), vmFinal, template, owner, null);
+} else if (template.getFormat() == ImageFormat.BAREMETAL) {
+s_logger.debug(String.format("%s has format [%s].
Skipping ROOT volume [%s] allocation.", template.toString(),
ImageFormat.BAREMETAL, rootVolumeName));
+} else {
+volumeMgr.allocateTemplatedVolumes(Type.ROOT,
rootVolumeName, rootDiskOfferingInfo.getDiskOffering(), rootDiskSizeFinal,
+rootDiskOfferingInfo.getMinIops(),
rootDiskOfferingInfo.getMaxIops(), template, vmFinal, owner);
+}
+} finally {
+// Remove volumeContext and pop vmContext back
+CallContext.unregister();
}
Review Comment:
can you extract this to a separate method?
##
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java:
##
@@ -1006,6 +1024,14 @@ public List allocateTemplatedVolumes(Type
type, String name, DiskOf
profiles.add(diskProfile);
}
+// Set context information for VOLUME.CREATE event for ROOT disk.
+CallContext volumeContext = CallContext.current();
+if (type == Type.ROOT && volumeContext != null &&
volumeContext.getEventResourceType() == ApiCommandResourceType.Volume) {
+String volumeIds = profiles.stream().map(diskProfile ->
this._uuidMgr.getUuid(Volume.class,
diskProfile.getVolumeId())).collect(Collectors.joining(", "));
+volumeContext.setEventDetails("Volume Id: " + volumeIds + " Vm Id:
" + this._uui
[GitHub] [cloudstack] blueorangutan commented on pull request #6939: When VM is created and ROOT volume is created it should emit a VOLUME.CREATE event
blueorangutan commented on PR #6939: URL: https://github.com/apache/cloudstack/pull/6939#issuecomment-1335172901 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6939: When VM is created and ROOT volume is created it should emit a VOLUME.CREATE event
DaanHoogland commented on PR #6939: URL: https://github.com/apache/cloudstack/pull/6939#issuecomment-1335172462 @mprokopchuk thanks for this enhancement. I wonder if this was a problem for more users than just you. It has been in here forever. My worry is that results from the usage service will be different and might create an issue for some users, but let's test that. Can you have a look at > SonarCloud Quality Gate failed.[](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6939) > > [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6939&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6939&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6939&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6939&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6939&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6939&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6939&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6939&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6939&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6939&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6939&resolved=false&types=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6939&resolved=false&types=CODE_SMELL) > > [ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6930: debian build: add python3-setuptools to dependencies
blueorangutan commented on PR #6930: URL: https://github.com/apache/cloudstack/pull/6930#issuecomment-1335164400 @DaanHoogland a Trillian-Jenkins test job (ubuntu22 mgmt + kvm-ubuntu22) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6930: debian build: add python3-setuptools to dependencies
DaanHoogland commented on PR #6930: URL: https://github.com/apache/cloudstack/pull/6930#issuecomment-1335163656 @blueorangutan test ubuntu22 kvm-ubuntu22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6526: [HEALTH] 4.17 Health Check please don't merge this
blueorangutan commented on PR #6526: URL: https://github.com/apache/cloudstack/pull/6526#issuecomment-1335153780 Trillian test result (tid-5338) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40236 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6526-t5338-kvm-centos7.zip Smoke tests completed. 100 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_redundant_VPC_default_routes | `Failure` | 488.24 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 460.13 | test_vpc_redundant.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
rohityadavcloud commented on PR #6942: URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1335138328 cc @andrijapanicsb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
rohityadavcloud commented on PR #6942: URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1335137621 This is hard to test/reproduce. I think this code is called by multiple threads which can cause xlock/iptables locking issue where the command fails and when it does ip routing rules aren't added. By putting synchronized on the method and logging/trying three times seem to be working in a rare-case env. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud opened a new pull request, #6942: ssvm: synchorise when adding iptables and routing rules
rohityadavcloud opened a new pull request, #6942: URL: https://github.com/apache/cloudstack/pull/6942 Use synchronised in NfsSecondaryStorageResource when adding iptables and routing rules; try three times and check/log for error. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6825: resolve sanity check last id file acces problems
blueorangutan commented on PR #6825: URL: https://github.com/apache/cloudstack/pull/6825#issuecomment-1335120930 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6571: [WIP] VM Autoscaling with virtual router
blueorangutan commented on PR #6571: URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1335118469 @weizhouapache a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6571: [WIP] VM Autoscaling with virtual router
weizhouapache commented on PR #6571: URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1335117774 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6526: [HEALTH] 4.17 Health Check please don't merge this
blueorangutan commented on PR #6526: URL: https://github.com/apache/cloudstack/pull/6526#issuecomment-1335103162 Trillian test result (tid-5337) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 37172 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6526-t5337-xenserver-71.zip Smoke tests completed. 101 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6899: Count Resource Virtual Router
blueorangutan commented on PR #6899: URL: https://github.com/apache/cloudstack/pull/6899#issuecomment-1335103047 Trillian Build Failed (tid-5363) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sptest232 commented on issue #6599: Assign VM To Backup Offering Failed
sptest232 commented on issue #6599: URL: https://github.com/apache/cloudstack/issues/6599#issuecomment-1335092901 Also problems (with the exception of the problem with method PS "GetBackupTargetRepository()") with CloudStack 4.17.1.0 + Veeam Backup and Replication 11.0.1.1261 ### PowerShell Add-PSSnapin VeeamPSSnapin;$Job = Get-VBRJob -name "predef";$Job.GetBackupTargetReposito**ry() ^| se**lect Name | Format-List At line:1 char:94 + ... Get-VBRJob -name "predef";$Job.GetBackupTargetRepository() ^| select ... **Unexpected token '^' in expression or statement.** + CategoryInfo : ParserError: (:) [], ParentContainsErrorRecordException + FullyQualifiedErrorId : UnexpectedToken Add-PSSnapin VeeamPSSnapin;$Job = Get-VBRJob -name "predef";$Job.GetBackupTargetRepositor**y() | s**elect Name | Format-List Add-PSSnapin : No snap-ins have been registered for Windows PowerShell version 5. At line:1 char:1 + Add-PSSnapin VeeamPSSnapin;$Job = Get-VBRJob -name "predef";$Job.GetB ... + CategoryInfo : InvalidArgument: (VeeamPSSnapin:String) [Add-PSSnapin], PSArgumentException + FullyQualifiedErrorId : AddPSSnapInRead,Microsoft.PowerShell.Commands.AddPSSnapinCommand **Name : Default Backup Repository** # CloudStack log 2022-12-02 14:04:30,692 ERROR [c.c.u.s.SshHelper] (API-Job-Executor-3:ctx-c9a1fec5 job-45 ctx-441a8bba) (logid:87897a61) SSH execution of command PowerShell Add-PSSnapin VeeamPSSnapin;$Job = Get-VBRJob -name "adhoc";$Job.GetBackupTargetRepository() ^| select Name | Format-List has an error status code in return. Result output: 'Format-List' is not recognized as an internal or external command, operable program or batch file. 2022-12-02 14:04:30,697 ERROR [o.a.c.b.v.VeeamClient] (API-Job-Executor-3:ctx-c9a1fec5 job-45 ctx-441a8bba) (logid:87897a61) Veeam PowerShell commands [PowerShell Add-PSSnapin VeeamPSSnapin;$Job = Get-VBRJob -name "adhoc";$Job.GetBackupTargetRepository() ^| select Name | Format-List] failed due to: ['Format-List' is not recognized as an internal or external command, operable program or batch file. ]. 2022-12-02 14:04:30,699 WARN [o.a.c.b.v.VeeamClient] (API-Job-Executor-3:ctx-c9a1fec5 job-45 ctx-441a8bba) (logid:87897a61) Exception caught while trying to clone Veeam job: com.cloud.utils.exception.CloudRuntimeException: Failed to get Repository Name from Job [name: adhoc]. at org.apache.cloudstack.backup.veeam.VeeamClient.getRepositoryNameFromJob(VeeamClient.java:367) at org.apache.cloudstack.backup.veeam.VeeamClient.listBackupRepository(VeeamClient.java:343) at org.apache.cloudstack.backup.veeam.VeeamClient.cloneVeeamJob(VeeamClient.java:461) at org.apache.cloudstack.backup.VeeamBackupProvider.assignVMToBackupOffering(VeeamBackupProvider.java:148) at org.apache.cloudstack.backup.BackupManagerImpl$1.doInTransaction(BackupManagerImpl.java:304) at org.apache.cloudstack.backup.BackupManagerImpl$1.doInTransaction(BackupManagerImpl.java:296) at com.cloud.utils.db.Transaction$3.doInTransaction(Transaction.java:74) at com.cloud.utils.db.Transaction.execute(Transaction.java:62) at com.cloud.utils.db.Transaction.execute(Transaction.java:71) at org.apache.cloudstack.backup.BackupManagerImpl.transactionAssignVMToBackupOffering(BackupManagerImpl.java:296) at org.apache.cloudstack.backup.BackupManagerImpl.assignVMToBackupOffering(BackupManagerImpl.java:292) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344) at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163) at org.apache.cloudstack.network.contrail.management.EventUtils$EventInterceptor.invoke(EventUtils.java:107) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:175) at com.cloud.event.ActionEventInterceptor.invoke(ActionEventInterceptor.java:52) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:175) at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97) at
[GitHub] [cloudstack] blueorangutan commented on pull request #6571: [WIP] VM Autoscaling with virtual router
blueorangutan commented on PR #6571: URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1335092485 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6899: Count Resource Virtual Router
blueorangutan commented on PR #6899: URL: https://github.com/apache/cloudstack/pull/6899#issuecomment-1335081994 Trillian Build Failed (tid-5361) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6858: allow a new upgrade version without DB changes to be inserted
blueorangutan commented on PR #6858: URL: https://github.com/apache/cloudstack/pull/6858#issuecomment-1335080902 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 4742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6511: [HEALTH] 4.18/main Health Check, please don't merge this!
blueorangutan commented on PR #6511: URL: https://github.com/apache/cloudstack/pull/6511#issuecomment-1335073213 Trillian Build Failed (tid-5358) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6936: host affinity: fix vm cannot be started if a vm is stopped in the affinity group
blueorangutan commented on PR #6936: URL: https://github.com/apache/cloudstack/pull/6936#issuecomment-1335071918 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6899: Count Resource Virtual Router
codecov[bot] commented on PR #6899: URL: https://github.com/apache/cloudstack/pull/6899#issuecomment-1335069753 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6899?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#6899](https://codecov.io/gh/apache/cloudstack/pull/6899?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (91796b6) into [main](https://codecov.io/gh/apache/cloudstack/commit/296035d9a57caa62260a666da726ec45b6801c4b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (296035d) will **increase** coverage by `0.52%`. > The diff coverage is `37.00%`. ```diff @@ Coverage Diff @@ ## main#6899 +/- ## + Coverage 10.34% 10.87% +0.52% - Complexity 6610 7120 +510 Files 2451 2485 +34 Lines242340 245693+3353 Branches 3792438363 +439 + Hits 2507026719+1649 - Misses 214182 215702+1520 - Partials 3088 3272 +184 ``` | [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6899?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...estration/service/NetworkOrchestrationService.java](https://codecov.io/gh/apache/cloudstack/pull/6899/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL2FwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9lbmdpbmUvb3JjaGVzdHJhdGlvbi9zZXJ2aWNlL05ldHdvcmtPcmNoZXN0cmF0aW9uU2VydmljZS5qYXZh) | `100.00% <ø> (ø)` | | | [...pi/src/main/java/com/cloud/alert/AlertManager.java](https://codecov.io/gh/apache/cloudstack/pull/6899/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL2NvbXBvbmVudHMtYXBpL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2FsZXJ0L0FsZXJ0TWFuYWdlci5qYXZh) | `100.00% <ø> (ø)` | | | [...n/java/com/cloud/vm/VirtualMachineProfileImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6899/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL2NvbXBvbmVudHMtYXBpL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3ZtL1ZpcnR1YWxNYWNoaW5lUHJvZmlsZUltcGwuamF2YQ==) | `36.44% <0.00%> (-0.70%)` | :arrow_down: | | [...n/java/com/cloud/vm/VirtualMachineManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6899/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL29yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9jb20vY2xvdWQvdm0vVmlydHVhbE1hY2hpbmVNYW5hZ2VySW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | | | [...tack/engine/orchestration/NetworkOrchestrator.java](https://codecov.io/gh/apache/cloudstack/pull/6899/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL29yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svZW5naW5lL29yY2hlc3RyYXRpb24vTmV0d29ya09yY2hlc3RyYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | | | [...stack/engine/orchestration/VolumeOrchestrator.java](https://codecov.io/gh/apache/cloudstack/pull/6899/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL29yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svZW5naW5lL29yY2hlc3RyYXRpb24vVm9sdW1lT3JjaGVzdHJhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...n/java/com/cloud/capacity/dao/CapacityDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6899/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9jYXBhY2l0eS9kYW8vQ2FwYWNpdHlEYW9JbXBsLmphdmE=) | `3.24% <0.00%> (-0.13%)` | :arrow_down: | | [...ema/src/main/java/com/cloud/network/vpc/VpcVO.java](https://codecov.io/gh/apache/cloudstack/pull/6899/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9uZXR3b3JrL3ZwYy9WcGNWTy5qYXZh) | `14.86% <0.00%
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6899: Count Resource Virtual Router
DaanHoogland commented on code in PR #6899:
URL: https://github.com/apache/cloudstack/pull/6899#discussion_r1038021658
##
test/integration/component/test_router_resources.py:
##
@@ -0,0 +1,824 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""
+Test case for router resources
+"""
+
+# Import local modules
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.cloudstackAPI import (scaleSystemVm,
+ stopRouter,
+ startRouter,
+ restartNetwork,
+ updateConfiguration)
+from marvin.lib.utils import (cleanup_resources)
+from marvin.lib.base import (NetworkOffering,
+ ServiceOffering,
+ VirtualMachine,
+ Account,
+ Domain,
+ Network,
+ Router,
+ destroyRouter,
+ Zone,
+ updateResourceCount)
+from marvin.lib.common import (get_zone,
+ get_template,
+ get_domain,
+ list_virtual_machines,
+ list_networks,
+ list_configurations,
+ list_routers,
+ list_service_offering)
+
+import logging
+
+class TestRouterResources(cloudstackTestCase):
+
+@classmethod
+def setupClass(cls):
+cls.testClient = super(
+TestRouterResources, cls
+).getClsTestClient()
+cls.apiclient = cls.testClient.getApiClient()
+
+cls.services = cls.testClient.getParsedTestDataConfig()
+zone = get_zone(cls.apiclient, cls.testClient.getZoneForTests())
+cls.zone = Zone(zone.__dict__)
+cls.template = get_template(cls.apiclient, cls.zone.id)
+cls._cleanup = []
+
+cls.logger = logging.getLogger("TestRouterResources")
+cls.stream_handler = logging.StreamHandler()
+cls.logger.setLevel(logging.DEBUG)
+cls.logger.addHandler(cls.stream_handler)
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.services["ostype"]
+)
+
+cls.service_offering = ServiceOffering.create(
+cls.apiclient,
+cls.services["service_offerings"]["big"]
+)
+
+# Create new domain1
+cls.domain1 = Domain.create(
+cls.apiclient,
+services=cls.services["acl"]["domain1"],
+parentdomainid=cls.domain.id)
+
+# Create account1
+cls.account1 = Account.create(
+cls.apiclient,
+cls.services["acl"]["accountD1"],
+domainid=cls.domain1.id
+)
+
+# Create Network Offering with all the services
+cls.network_offering = NetworkOffering.create(
+cls.apiclient,
+cls.services["isolated_network_offering"]
+)
+# Enable Network offering
+cls.network_offering.update(cls.apiclient, state='Enabled')
+
+cls.network = Network.create(
+cls.apiclient,
+cls.services["isolated_network"],
+accountid=cls.account1.name,
+domainid=cls.account1.domainid,
+networkofferingid=cls.network_offering.id,
+zoneid=cls.zone.id
+)
+
+virtualmachine = VirtualMachine.create(
+cls.apiclient,
+services=cls.services["virtual_machine_userdata"],
+accountid=cls.account1.name,
+domainid=cls.account1.domainid,
+serviceofferingid=cls.service_offering.id,
+networkids=cls.network.id,
+templateid=cls.template.id,
+zoneid=cls.zone.id
+)
Review Comment:
```suggestion
virtualmachine = VirtualMachine.create(
cls.apiclient,
services=cls.se
[GitHub] [cloudstack] sptest232 commented on issue #6599: Assign VM To Backup Offering Failed
sptest232 commented on issue #6599:
URL: https://github.com/apache/cloudstack/issues/6599#issuecomment-1335062902
The same problem with:CloudStack 4.17.1.0 + Veeam Backup and Replication 9.5
Update 4, Veeam Backup Enterprise Manager Service Version 9.5.4.2866 + vSphere
6.5.0.41000, Windows Server 2019 Standard version 1809,
OpenSSH_for_Windows_7.7p1, LibreSSL 2.6.5, PowerShell 5.1.17763.2931
I found that PowerShell VeeamPSSnapin (Veeam Backup and Replication 9.5
Update 4) doesn't have necessary object "**VBRJob**" method
"**GetBackupTargetRepository()**" and it doesn't understand the sign "**^**" in
command "**Add-PSSnapin VeeamPSSnapin;$Job = Get-VBRJob -name
"predef";$Job.GetBackupTargetRepository() ^| select Name | Format-List**" so
CloudStack buckup plugin doesn't work.
Here some logs and information:
http://docs.cloudstack.apache.org/en/latest/adminguide/veeam_plugin.html#veeam-backup-and-recovery-plugin
CloudStack 4.17.1.0
vSphere 6.5.0.41000
Windows Server 2019 Standard version 1809
OpenSSH_for_Windows_7.7p1, LibreSSL 2.6.5
PowerShell 5.1.17763.2931
Veeam Backup and Replication 9.5 Update 4
Veeam Backup Enterprise Manager Service Version 9.5.4.2866
# PowerShell Information
Add-PSSnapin VeeamPSSnapin;$Job = Get-VBRJob -name
"predef";$Job.GetBackupTargetRepository() ^| select Name | Format-List
At line:1 char:94
+ ... Get-VBRJob -name "predef";$Job.GetBackupTargetRepository() ^| select
...
+ ~
Unexpected token '^' in expression or statement.
+ CategoryInfo : ParserError: (:) [],
ParentContainsErrorRecordException
+ FullyQualifiedErrorId : UnexpectedToken
Add-PSSnapin VeeamPSSnapin;$Job = Get-VBRJob -name
"predef";$Job.GetBackupTargetRepository() ^| select Name | Format-List
At line:1 char:94
+ ... Get-VBRJob -name "predef";$Job.GetBackupTargetRepository() ^| select
...
+ ~
Unexpected token '^' in expression or statement.
+ CategoryInfo : ParserError: (:) [],
ParentContainsErrorRecordException
+ FullyQualifiedErrorId : UnexpectedToken
Get-VBRJob -name "predef" | Get-Member
TypeName: Veeam.Backup.Core.CBackupJob
Name MemberType Definition
-- --
CanRunByScheduler Method bool
ISchedulableJob.CanRunByScheduler()
CheckDeleteAllowedMethod void CheckDeleteAllowed()
DeleteMethod void
Delete(Veeam.Backup.Model.CModifiedUserInfo initiator)
DisableScheduler Method void
DisableScheduler(Veeam.Backup.Model.CModifiedUserInfo initiator)
EnableScheduler Method void
EnableScheduler(Veeam.Backup.Model.CModifiedUserInfo initiator)
EqualsMethod bool Equals(System.Object obj)
FindChildEpSyncBackupJob Method Veeam.Backup.Core.CBackupJob
FindChildEpSyncBackupJob()
FindChildOracleLogBackupJob Method Veeam.Backup.Core.CBackupJob
FindChildOracleLogBackupJob()
FindChildSqlLogBackupJob Method Veeam.Backup.Core.CBackupJob
FindChildSqlLogBackupJob()
FindInitialRepository Method Veeam.Backup.Core.CBackupRepository
FindInitialRepository()
FindLastBackupMethod Veeam.Backup.Core.CBackup
FindLastBackup()
FindLastBaseSession Method Veeam.Backup.Core.CBaseSession
FindLastBaseSession()
FindLastOib Method Veeam.Backup.Core.COib
FindLastOib(guid objId)
FindLastSession Method Veeam.Backup.Core.CBackupSession
FindLastSession(), Veeam.Backup.Model.CBaseSessionInfo IJob.FindLastSession()
FindParentJob Method Veeam.Backup.Core.CBackupJob
FindParentJob()
FindSourceWanAccelerator Method Veeam.Backup.Core.CWanAccelerator
FindSourceWanAccelerator()
FindTargetRepository Method Veeam.Backup.Core.CBackupRepository
FindTargetRepository()
FindTargetWanAccelerator Method Veeam.Backup.Core.CWanAccelerator
FindTargetWanAccelerator()
FindUserCryptoKey Method Veeam.Backup.Core.CCryptoKey
FindUserCryptoKey()
GetChildJobs Method Veeam.Backup.Core.CBackupJob[]
GetChildJobs()
GetCredsIdMethod guid GetCredsId()
GetDesktopOij Method Veeam.Backup.Core.CObjectInJob
GetDesktopOij()
GetDiskEffectiveCompression Method int
GetDiskEffectiveCompression(Veeam.Backup.Core.IStorageCommander
storageCommander, guid storageId)
GetEndPointOijs Method Veeam.Backup.Core.CEndPointOij[]
GetEndPointOijs()
GetFilesEffectiveCompression Method int
GetFilesEffectiveCompression(Veeam.Backup.Core.IStor
[GitHub] [cloudstack] blueorangutan commented on pull request #6899: Count Resource Virtual Router
blueorangutan commented on PR #6899: URL: https://github.com/apache/cloudstack/pull/6899#issuecomment-1335057478 Trillian Build Failed (tid-5359) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6832: Allow root admin to deploy in VPCs in child domains
sonarcloud[bot] commented on PR #6832: URL: https://github.com/apache/cloudstack/pull/6832#issuecomment-1335041997 SonarCloud Quality Gate failed.  [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6832) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6832&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6832&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6832&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6832&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6832&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6832&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6832&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6832&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6832&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6832&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6832&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6832&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6832&metric=new_coverage&view=list) [34.1% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6832&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6832&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6832&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6511: [HEALTH] 4.18/main Health Check, please don't merge this!
blueorangutan commented on PR #6511: URL: https://github.com/apache/cloudstack/pull/6511#issuecomment-1335037904 @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6511: [HEALTH] 4.18/main Health Check, please don't merge this!
DaanHoogland commented on PR #6511: URL: https://github.com/apache/cloudstack/pull/6511#issuecomment-1335037534 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6832: Allow root admin to deploy in VPCs in child domains
sonarcloud[bot] commented on PR #6832: URL: https://github.com/apache/cloudstack/pull/6832#issuecomment-1335033095 SonarCloud Quality Gate failed.  [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6832) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6832&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6832&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6832&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6832&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6832&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6832&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6832&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6832&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6832&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6832&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6832&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6832&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6832&metric=new_coverage&view=list) [35.9% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6832&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6832&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6832&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6825: resolve sanity check last id file acces problems
sonarcloud[bot] commented on PR #6825: URL: https://github.com/apache/cloudstack/pull/6825#issuecomment-1335021701 SonarCloud Quality Gate failed.  [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6825) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6825&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6825&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6825&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6825&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6825&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6825&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6825&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6825&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6825&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6825&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6825&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6825&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6825&metric=new_coverage&view=list) [23.3% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6825&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6825&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6825&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6899: Count Resource Virtual Router
weizhouapache commented on code in PR #6899: URL: https://github.com/apache/cloudstack/pull/6899#discussion_r1037973030 ## server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java: ## @@ -44,7 +44,7 @@ import javax.inject.Inject; import javax.naming.ConfigurationException; - +import com.googlecode.ipv6.IPv6Network; Review Comment: revert this change ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6511: [HEALTH] 4.18/main Health Check, please don't merge this!
blueorangutan commented on PR #6511: URL: https://github.com/apache/cloudstack/pull/6511#issuecomment-1335012988 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6899: Count Resource Virtual Router
blueorangutan commented on PR #6899: URL: https://github.com/apache/cloudstack/pull/6899#issuecomment-1335011223 Trillian Build Failed (tid-5355) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6912: vmware: fix vmware vm snapshot operations for datastorecluster
blueorangutan commented on PR #6912: URL: https://github.com/apache/cloudstack/pull/6912#issuecomment-1335010336 Trillian Build Failed (tid-5351) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6526: [HEALTH] 4.17 Health Check please don't merge this
blueorangutan commented on PR #6526: URL: https://github.com/apache/cloudstack/pull/6526#issuecomment-1335007464 Trillian Build Failed (tid-5350) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6924: [Draft] User two factor authentication
weizhouapache commented on code in PR #6924:
URL: https://github.com/apache/cloudstack/pull/6924#discussion_r1037969392
##
api/src/main/java/org/apache/cloudstack/api/command/admin/user/UpdateUserCmd.java:
##
@@ -80,6 +80,9 @@ public class UpdateUserCmd extends BaseCmd {
@Parameter(name = ApiConstants.USERNAME, type = CommandType.STRING,
description = "Unique username")
private String username;
+@Parameter(name = ApiConstants.MANDATE_2FA, type = CommandType.BOOLEAN,
description = "Provide true to mandate the user to use two factor
authentication has to be enabled. This parameter is only used to mandate 2FA,
not to disable 2FA")
+private Boolean mandate2FA;
Review Comment:
add since ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6899: Count Resource Virtual Router
blueorangutan commented on PR #6899: URL: https://github.com/apache/cloudstack/pull/6899#issuecomment-1335003273 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6899: Count Resource Virtual Router
DaanHoogland commented on PR #6899: URL: https://github.com/apache/cloudstack/pull/6899#issuecomment-1335003138 @weizhouapache can you review this, given time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6899: Count Resource Virtual Router
DaanHoogland commented on PR #6899: URL: https://github.com/apache/cloudstack/pull/6899#issuecomment-1335002580 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6832: Allow root admin to deploy in VPCs in child domains
sonarcloud[bot] commented on PR #6832: URL: https://github.com/apache/cloudstack/pull/6832#issuecomment-1335002408 SonarCloud Quality Gate failed.  [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6832) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6832&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6832&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6832&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6832&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6832&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6832&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6832&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6832&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6832&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6832&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6832&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6832&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6832&metric=new_coverage&view=list) [35.9% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6832&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6832&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6832&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6571: [WIP] VM Autoscaling with virtual router
blueorangutan commented on PR #6571: URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1335002189 @borisstoyanov a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #6571: [WIP] VM Autoscaling with virtual router
borisstoyanov commented on PR #6571: URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1335001756 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6571: [WIP] VM Autoscaling with virtual router
blueorangutan commented on PR #6571: URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1334992728 @borisstoyanov a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #6571: [WIP] VM Autoscaling with virtual router
borisstoyanov commented on PR #6571: URL: https://github.com/apache/cloudstack/pull/6571#issuecomment-1334992109 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6858: allow a new upgrade version without DB changes to be inserted
blueorangutan commented on PR #6858: URL: https://github.com/apache/cloudstack/pull/6858#issuecomment-1334990749 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6858: allow a new upgrade version without DB changes to be inserted
DaanHoogland commented on PR #6858: URL: https://github.com/apache/cloudstack/pull/6858#issuecomment-1334990177 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6936: host affinity: fix vm cannot be started if a vm is stopped in the affinity group
blueorangutan commented on PR #6936: URL: https://github.com/apache/cloudstack/pull/6936#issuecomment-1334985594 @vladimirpetrov a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] vladimirpetrov commented on pull request #6936: host affinity: fix vm cannot be started if a vm is stopped in the affinity group
vladimirpetrov commented on PR #6936: URL: https://github.com/apache/cloudstack/pull/6936#issuecomment-1334984417 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6526: [HEALTH] 4.17 Health Check please don't merge this
blueorangutan commented on PR #6526: URL: https://github.com/apache/cloudstack/pull/6526#issuecomment-1334973542 Trillian Build Failed (tid-5347) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6783: Fixes script that perform change password on hosts
blueorangutan commented on PR #6783: URL: https://github.com/apache/cloudstack/pull/6783#issuecomment-1334971271 Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
