[GitHub] [cloudstack] khoinek commented on issue #6998: There is no secondary storage VM for system VM, start ssvm failed.

2022-12-19 Thread GitBox


khoinek commented on issue #6998:
URL: https://github.com/apache/cloudstack/issues/6998#issuecomment-1358940439

   
![image](https://user-images.githubusercontent.com/121023233/208607319-14534fd0-33aa-48c0-bc5e-4770daf3cbda.png)
   
   This is the problem i have when i run SSVM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] boring-cyborg[bot] commented on issue #7000: Prometheus integration ignores capacity_state

2022-12-19 Thread GitBox


boring-cyborg[bot] commented on issue #7000:
URL: https://github.com/apache/cloudstack/issues/7000#issuecomment-1358790909

   Thanks for opening your first issue here! Be sure to follow the issue 
template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] benj-n opened a new issue, #7000: Prometheus integration ignores capacity_state

2022-12-19 Thread GitBox


benj-n opened a new issue, #7000:
URL: https://github.com/apache/cloudstack/issues/7000

   
   
   # ISSUE TYPE
   
* Bug Report
   
   # COMPONENT NAME
   
   ~~~
   Prometheus integration
   ~~~
   
   # CLOUDSTACK VERSION
   
   
   ~~~
   4.17.X
   ~~~
   
   # CONFIGURATION
   
   
   
   # OS / ENVIRONMENT
   
   Irrelevant.
   
   # SUMMARY
   
   The prometheus integration returns inconsistent capacity values when a host 
is in "maintenance" and cloudstack-management service is restarted.
   
   # STEPS TO REPRODUCE
   
   
   
   ~~~
   1. Set "maintenance" status for a host
   2. In database, the capacity rows are deleted in the op_host_capacity table, 
for the said host
   3. Prometheus integration returns capacities with value=0 
   4. Restart cloudstack-management service while the host is still in 
maintenance
   5. In database, table op_host_capacity is populated, with capacity_state = 
Disabled
   6. Prometheus integration now returns capacity values from 
used/total_capacity columns, ignoring the capacity_state
   ~~~
   
   
   
   # EXPECTED RESULTS
   
   
   ~~~
   Prometheus integration returns capacity values=0 when the capacity is 
missing (eg. host is in maintenance) or when the capacity_state is set at 
Disabled (eg. host in maintenance and service is restarted)
   ~~~
   
   # ACTUAL RESULTS
   
   
   
   ~~~
   Prometheus integration returns capacity values all the time as long as the 
used/total_capacity columns exist, ignoring when the capacity_state is Disabled.
   ~~~
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6803: ui,server,api: resource metrics improvements

2022-12-19 Thread GitBox


blueorangutan commented on PR #6803:
URL: https://github.com/apache/cloudstack/pull/6803#issuecomment-1358762125

   Trillian test result (tid-5577)
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 39910 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6803-t5577-xenserver-71.zip
   Smoke tests completed. 105 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6959: Metrics plugin: expose full domain path instead of name

2022-12-19 Thread GitBox


blueorangutan commented on PR #6959:
URL: https://github.com/apache/cloudstack/pull/6959#issuecomment-1358756876

   Trillian test result (tid-5575)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 45001 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6959-t5575-kvm-centos7.zip
   Smoke tests completed. 105 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6550: Emc networker b

2022-12-19 Thread GitBox


blueorangutan commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1358755207

   Trillian test result (tid-5567)
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 53426 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6550-t5567-vmware-65u2.zip
   Smoke tests completed. 103 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_create_template_with_checksum_sha1 | `Error` | 5.16 | 
test_templates.py
   test_03_create_template_with_checksum_sha256 | `Error` | 5.17 | 
test_templates.py
   test_04_create_template_with_checksum_md5 | `Error` | 5.15 | 
test_templates.py
   test_02_upgrade_kubernetes_cluster | `Failure` | 537.80 | 
test_kubernetes_clusters.py
   test_08_upgrade_kubernetes_ha_cluster | `Error` | 4093.32 | 
test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.05 | 
test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 45.96 | 
test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] khoinek commented on issue #6998: There is no secondary storage VM for system VM, start ssvm failed.

2022-12-19 Thread GitBox


khoinek commented on issue #6998:
URL: https://github.com/apache/cloudstack/issues/6998#issuecomment-1358724740


   
![image_2022_12_20T01_50_39_265Z](https://user-images.githubusercontent.com/121023233/208562506-54032c24-a7d1-454a-b959-29ebebb3b59b.png)
   
![image_2022_12_20T01_51_04_027Z](https://user-images.githubusercontent.com/121023233/208562509-4faa4cd8-8656-4002-9af1-6e0143a8c188.png)
   Ok, thank you for your interest in my problem, the environment i am running 
for management server is Centos 7, hypervisor is hyper-v, shared storage using 
SMB and NFS on windows server 2019, i do lab and only add 1 bridged network 
card, I don't know if I need to add any other card for IP Public when creating 
zones ?
   Thank you very much.
   
   > @khoinek @haccolo1, can you give some more information please? How can we 
reproduce this scenario? What are the versions and other parameters of the 
environment you are running (i.e. what type of hypervisors/storage/network)? 
thanks
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6960: create parameter to determine whether roles are public or private

2022-12-19 Thread GitBox


blueorangutan commented on PR #6960:
URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1358721823

   Trillian test result (tid-5576)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 41973 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6960-t5576-kvm-centos7.zip
   Smoke tests completed. 103 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_create_pvlan_network | `Error` | 0.05 | test_pvlan.py
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 577.10 | 
test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] fermosan commented on pull request #6550: Emc networker b

2022-12-19 Thread GitBox


fermosan commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1358677190

   > @rohityadavcloud @weizhouapache @shwstppr @fermosan is there anything left 
to discuss here?
   
   @DaanHoogland i think that there are some questions to be answered. What is 
a rough estimation for the 4.18 release ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6550: Emc networker b

2022-12-19 Thread GitBox


blueorangutan commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1358676740

   Trillian test result (tid-5565)
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 46161 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6550-t5565-xenserver-71.zip
   Smoke tests completed. 105 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6832: Allow root admin to deploy in VPCs in child domains

2022-12-19 Thread GitBox


blueorangutan commented on PR #6832:
URL: https://github.com/apache/cloudstack/pull/6832#issuecomment-1358633901

   Trillian test result (tid-5570)
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 43643 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6832-t5570-vmware-65u2.zip
   Smoke tests completed. 104 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_create_template_with_checksum_sha1 | `Error` | 5.15 | 
test_templates.py
   test_03_create_template_with_checksum_sha256 | `Error` | 5.15 | 
test_templates.py
   test_04_create_template_with_checksum_md5 | `Error` | 5.14 | 
test_templates.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6550: Emc networker b

2022-12-19 Thread GitBox


blueorangutan commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1358630991

   Trillian test result (tid-5566)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 43733 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6550-t5566-kvm-centos7.zip
   Smoke tests completed. 104 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_autoscale_kubernetes_cluster | `Failure` | 32.90 | 
test_kubernetes_clusters.py
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 569.24 | 
test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6832: Allow root admin to deploy in VPCs in child domains

2022-12-19 Thread GitBox


blueorangutan commented on PR #6832:
URL: https://github.com/apache/cloudstack/pull/6832#issuecomment-1358592130

   Trillian test result (tid-5569)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 42594 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6832-t5569-kvm-centos7.zip
   Smoke tests completed. 104 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 676.87 | 
test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6242: Search for resource type efficiently

2022-12-19 Thread GitBox


blueorangutan commented on PR #6242:
URL: https://github.com/apache/cloudstack/pull/6242#issuecomment-1358574644

   Trillian test result (tid-5571)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 41771 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6242-t5571-kvm-centos7.zip
   Smoke tests completed. 105 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6661: Enable live volume migration for StorPool and small fixes

2022-12-19 Thread GitBox


blueorangutan commented on PR #6661:
URL: https://github.com/apache/cloudstack/pull/6661#issuecomment-1358534518

   Trillian test result (tid-5559)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 44325 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6661-t5559-kvm-centos7.zip
   Smoke tests completed. 105 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6273: Add `pre-commit` workflow with 3 Git hooks

2022-12-19 Thread GitBox


blueorangutan commented on PR #6273:
URL: https://github.com/apache/cloudstack/pull/6273#issuecomment-1358530892

   Trillian test result (tid-5552)
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 48695 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6273-t5552-vmware-65u2.zip
   Smoke tests completed. 102 look OK, 3 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_attach_and_distribute_multiple_volumes | `Failure` | 52.66 | 
test_attach_multiple_volumes.py
   test_02_create_template_with_checksum_sha1 | `Error` | 5.16 | 
test_templates.py
   test_03_create_template_with_checksum_sha256 | `Error` | 5.24 | 
test_templates.py
   test_04_create_template_with_checksum_md5 | `Error` | 5.17 | 
test_templates.py
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 655.49 | 
test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6995: Packages consolidation: merge suse15 to el8

2022-12-19 Thread GitBox


blueorangutan commented on PR #6995:
URL: https://github.com/apache/cloudstack/pull/6995#issuecomment-1358525575

   Trillian test result (tid-5573)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 39544 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6995-t5573-kvm-centos7.zip
   Smoke tests completed. 100 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 572.55 | 
test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6832: Allow root admin to deploy in VPCs in child domains

2022-12-19 Thread GitBox


blueorangutan commented on PR #6832:
URL: https://github.com/apache/cloudstack/pull/6832#issuecomment-1358519399

   Trillian test result (tid-5568)
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 40024 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6832-t5568-xenserver-71.zip
   Smoke tests completed. 105 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6995: Packages consolidation: merge suse15 to el8

2022-12-19 Thread GitBox


blueorangutan commented on PR #6995:
URL: https://github.com/apache/cloudstack/pull/6995#issuecomment-1358519129

   Trillian test result (tid-5572)
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 39340 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6995-t5572-xenserver-71.zip
   Smoke tests completed. 100 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_cancel_host_maintenace_with_no_migration_jobs | `Error` | 306.26 | 
test_host_maintenance.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 306.12 | 
test_host_maintenance.py
   test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 0.21 
| test_host_maintenance.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6273: Add `pre-commit` workflow with 3 Git hooks

2022-12-19 Thread GitBox


blueorangutan commented on PR #6273:
URL: https://github.com/apache/cloudstack/pull/6273#issuecomment-1358380123

   Trillian test result (tid-5551)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 42131 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6273-t5551-kvm-centos7.zip
   Smoke tests completed. 104 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 561.37 | 
test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6273: Add `pre-commit` workflow with 3 Git hooks

2022-12-19 Thread GitBox


blueorangutan commented on PR #6273:
URL: https://github.com/apache/cloudstack/pull/6273#issuecomment-1358327866

   Trillian test result (tid-5550)
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 40785 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6273-t5550-xenserver-71.zip
   Smoke tests completed. 104 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 567.96 | 
test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] soreana commented on pull request #6994: ui: persist networks config in deploy vm form

2022-12-19 Thread GitBox


soreana commented on PR #6994:
URL: https://github.com/apache/cloudstack/pull/6994#issuecomment-1358326457

   > Thanks @shwstppr . @soreana can you test if this solves your issue (#6974)?
   
   Thanks, @shwstppr, and @DaanHoogland. I've tested it and it looks good. I 
will also ask my colleagues to look at it tomorrow.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] soreana commented on pull request #6809: Reserve memory for host

2022-12-19 Thread GitBox


soreana commented on PR #6809:
URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1358288122

   > > @nvazquez @weizhouapache @GutoVeronezi @wido we need more reviews here, 
please
   > 
   > Yes, sure.
   > 
   > However, looking at this, doesn't this make the config setting in the KVM 
agent.properties redundant?
   
   I don't think so. The config in the agent.properties applied to one host, 
although this global setting applies to all hosts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] AlexanderKgr commented on issue #6941: Xcp-ng 8.2.1 - issues reverting to vm snapshot

2022-12-19 Thread GitBox


AlexanderKgr commented on issue #6941:
URL: https://github.com/apache/cloudstack/issues/6941#issuecomment-1358258022

   Anyone?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] wido commented on pull request #6809: Reserve memory for host

2022-12-19 Thread GitBox


wido commented on PR #6809:
URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1358090765

   > @nvazquez @weizhouapache @GutoVeronezi @wido we need more reviews here, 
please
   
   Yes, sure.
   
   However, looking at this, doesn't this make the config setting in the KVM 
agent.properties redundant?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] rohityadavcloud commented on pull request #6995: Packages consolidation: merge suse15 to el8

2022-12-19 Thread GitBox


rohityadavcloud commented on PR #6995:
URL: https://github.com/apache/cloudstack/pull/6995#issuecomment-1358086780

   rocky8 failures are consistent; I may defer and look at this manually.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6808: Allow privateips on console proxy

2022-12-19 Thread GitBox


sonarcloud[bot] commented on PR #6808:
URL: https://github.com/apache/cloudstack/pull/6808#issuecomment-1357954734

   SonarCloud Quality Gate failed.  [![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate 
failed')](https://sonarcloud.io/dashboard?id=apache_cloudstack=6808)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6808=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6808=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=6808=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6808=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6808=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=6808=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6808=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6808=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6808=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6808=false=CODE_SMELL)
 
[![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png
 
'E')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6808=false=CODE_SMELL)
 [268 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=6808=false=CODE_SMELL)
   
   
[![60.8%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png
 
'60.8%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=6808=new_coverage=list)
 [60.8% 
Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=6808=new_coverage=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=6808=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=6808=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #6809: Reserve memory for host

2022-12-19 Thread GitBox


GutoVeronezi commented on code in PR #6809:
URL: https://github.com/apache/cloudstack/pull/6809#discussion_r1052398464


##
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##
@@ -450,6 +449,7 @@ public class ConfigurationManagerImpl extends ManagerBase 
implements Configurati
 private Set overprovisioningFactorsForValidation;
 public static final String VM_USERDATA_MAX_LENGTH_STRING = 
"vm.userdata.max.length";
 
+public static final String HOST_RESERVED_MEM_MB_STRING = 
"host.reserved.mem.mb";

Review Comment:
   We could use `HOST_RESERVED_MEM_MB.key()` instead of declaring a constant 
with it.



##
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##
@@ -472,6 +472,8 @@ public class ConfigurationManagerImpl extends ManagerBase 
implements Configurati
 public static final ConfigKey 
ENABLE_DOMAIN_SETTINGS_FOR_CHILD_DOMAIN = new ConfigKey(Boolean.class, 
"enable.domain.settings.for.child.domain", "Advanced", "false",
 "Indicates whether the settings of parent domain should be applied 
for child domain. If true, the child domain will get value from parent domain 
if its not configured in child domain else global value is taken.",
 true, ConfigKey.Scope.Global, null);
+public static final ConfigKey HOST_RESERVED_MEM_MB = new 
ConfigKey<>("Advanced", Integer.class, HOST_RESERVED_MEM_MB_STRING, "1024",
+"Set an upper limit for memory in megabytes which will be reserved 
for host and not used for VM allocation.", true);

Review Comment:
   As hosts can behave differently between clusters, might the operators want 
to set a different value for each  cluster?



##
server/src/main/java/com/cloud/resource/ResourceManagerImpl.java:
##
@@ -2190,6 +2191,12 @@ protected HostVO createHostVO(final StartupCommand[] 
cmds, final ServerResource
 hostTags = implicitHostTags;
 }
 }
+
+// Update host memory reported by agent
+if (ssCmd.getHypervisorType().equals(HypervisorType.KVM) ||
+ssCmd.getHypervisorType().equals(HypervisorType.LXC)) {
+
host.setDom0MinMemory(Long.parseLong(_configDao.getValue(HOST_RESERVED_MEM_MB_STRING))
 * 1024L * 1024L);

Review Comment:
   We could use `HOST_RESERVED_MEM_MB.value()` here, instead of retrieving with 
`_configDao`.



##
engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java:
##
@@ -1862,4 +1871,50 @@ public void propagateChangeToAgents(Map 
params) {
 sendCommandToAgents(hostsPerZone, params);
 }
 }
+
+@Override
+public void updateCapacityOfHosts() {
+Map> hostsByZone = new HashMap<>();
+Map params = new HashMap<>();
+boolean status = true;
+List allHosts = 
_resourceMgr.listAllHostsInAllZonesByType(Host.Type.Routing);
+if (CollectionUtils.isEmpty(allHosts)) {
+return;
+}
+
+String value = HOST_RESERVED_MEM_MB.value().toString();
+params.put(HOST_RESERVED_MEM_MB.key(), value);
+for (HostVO host : allHosts) {
+Long zoneId = host.getDataCenterId();
+try {
+// Update the "ram" for all hosts
+long updatedHostRam = (host.getTotalMemory() + 
host.getDom0MinMemory()) - (Integer.parseInt(value) * 1024L * 1024L);
+if (updatedHostRam > 0) {
+host.setTotalMemory(updatedHostRam);
+// Update "dom0_memory" in host table
+host.setDom0MinMemory(Integer.parseInt(value) * 1024L * 
1024L);

Review Comment:
   We can use `ByteScaleUtils` for scale conversions.



##
engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java:
##
@@ -1862,4 +1871,50 @@ public void propagateChangeToAgents(Map 
params) {
 sendCommandToAgents(hostsPerZone, params);
 }
 }
+
+@Override
+public void updateCapacityOfHosts() {
+Map> hostsByZone = new HashMap<>();
+Map params = new HashMap<>();
+boolean status = true;
+List allHosts = 
_resourceMgr.listAllHostsInAllZonesByType(Host.Type.Routing);
+if (CollectionUtils.isEmpty(allHosts)) {
+return;
+}
+
+String value = HOST_RESERVED_MEM_MB.value().toString();
+params.put(HOST_RESERVED_MEM_MB.key(), value);
+for (HostVO host : allHosts) {
+Long zoneId = host.getDataCenterId();
+try {
+// Update the "ram" for all hosts
+long updatedHostRam = (host.getTotalMemory() + 
host.getDom0MinMemory()) - (Integer.parseInt(value) * 1024L * 1024L);

Review Comment:
   We can use `ByteScaleUtils` for scale conversions.



##
engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java:
##
@@ -1783,6 +1791,7 

[GitHub] [cloudstack] soreana commented on a diff in pull request #6918: Override vr service offering

2022-12-19 Thread GitBox


soreana commented on code in PR #6918:
URL: https://github.com/apache/cloudstack/pull/6918#discussion_r1052416162


##
framework/config/src/main/java/org/apache/cloudstack/framework/config/ConfigKey.java:
##
@@ -34,7 +34,7 @@
 public static final String CATEGORY_ALERT = "Alert";
 
 public static enum Scope {
-Global, Zone, Cluster, StoragePool, Account, ManagementServer, 
ImageStore, Domain
+Global, Zone, Cluster, StoragePool, Account, Domain, ManagementServer, 
ImageStore, Network

Review Comment:
   @JoaoJandre I didn't know that ACS uses the enums' order. It is surprising 
for me cause the order might change over time. :)
   Anyway, I'm not aware of any regression but I'm redoing the changes just to 
be safe.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] GutoVeronezi commented on pull request #6348: Improving code related to the Agent properties

2022-12-19 Thread GitBox


GutoVeronezi commented on PR #6348:
URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1357884843

   @DaanHoogland, I think that, with the last commit, we have all the cases 
addressed. If there is something I am missing, please, let me know.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2022-12-19 Thread GitBox


blueorangutan commented on PR #6991:
URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1357880201

   @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 
mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2022-12-19 Thread GitBox


DaanHoogland commented on PR #6991:
URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1357879168

   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2022-12-19 Thread GitBox


blueorangutan commented on PR #6991:
URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1357877812

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 
:heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5029


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] soreana opened a new issue, #6999: Security group fields in the listVirtualmachines API call's response doesn't change

2022-12-19 Thread GitBox


soreana opened a new issue, #6999:
URL: https://github.com/apache/cloudstack/issues/6999

   
   
   In listVirtualMachines' response, we have a security group field. After 
further investigation, we noticed that this field doesn't change at all even if 
I add the ingress rule to the VM.
   
   ```
   (local) > list virtualmachines id="152ee2cf-d9fb-4281-b222-1a9b1b73ef57" 
filter=id,name,displayname,securitygroup listall=true
   {
 "count": 1,
 "virtualmachine": [
   {
 "displayname": "Sina-test-security-groups",
 "id": "152ee2cf-d9fb-4281-b222-1a9b1b73ef57",
 "name": "Sina-test-security-groups",
 "securitygroup": [
   {
 "account": "admin",
 "description": "",
 "egressrule": [],
 "id": "a2a75240-a7f2-42a4-9812-a9954b2d5ab2",
 "ingressrule": [],
 "name": "Sina-test",
 "tags": [],
 "virtualmachineids": []
   }
 ]
   }
 ]
   }
   (local) > list securitygroups 
virtualmachineid=152ee2cf-d9fb-4281-b222-1a9b1b73ef57
   {
 "count": 1,
 "securitygroup": [
   {
 "account": "admin",
 "description": "",
 "domain": "ROOT",
 "domainid": "84c14489-6263-11e3-aa07-d89d6717918c",
 "egressrule": [],
 "id": "a2a75240-a7f2-42a4-9812-a9954b2d5ab2",
 "ingressrule": [
   {
 "cidr": "10.0.0.0/8",
 "endport": 20,
 "protocol": "tcp",
 "ruleid": "506815f8-1586-4353-ac70-8009cff65be8",
 "startport": 20,
 "tags": []
   }
 ],
 "name": "Sina-test",
 "tags": [],
 "virtualmachinecount": 1,
 "virtualmachineids": [
   "152ee2cf-d9fb-4281-b222-1a9b1b73ef57"
 ]
   }
 ]
   }
   ```
   
   # ISSUE TYPE
   
* Bug Report
   
   # COMPONENT NAME
   
   ~~~
   API
   ~~~
   
   # CLOUDSTACK VERSION
   
   
   ~~~
   4.17.2
   ~~~
   
   # CONFIGURATION
   
   ~~~
   Basic network with security group
   ~~~
   
   
   # SUMMARY
   
   
   When I was testing a firewall rules, I noticed that adding an ingress rules 
to a VM's security group doesn't have any affect on the `listVirtualmachines` 
api call output. The ingress rule is always empty. As a result our automation 
tools should call two APIs rather than one to get correct informations. One to 
get the informations about the VM and another one to get security groups.
   
   # STEPS TO REPRODUCE
   
   
   
   ~~~
   1. Call list virtual machine api call using cmk and check `securitygroup` 
field, it is empty.
   2. Add some ingress rules to the security group.
   3. Call list virtual machine api call using cmk and check `securitygroup` 
field again, it is empty. 
   ~~~
   
   
   
   # EXPECTED RESULTS
   
   
   ~~~
   The ingress rule added to the `securitygroup` field of the virtual machine 
API call.
   ~~~
   
   # ACTUAL RESULTS
   
   
   
   ~~~
   The ingress rule in `securitygroup` is empty.
   ~~~
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] GaOrtiga commented on pull request #6960: create parameter to determine whether roles are public or private

2022-12-19 Thread GitBox


GaOrtiga commented on PR #6960:
URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1357831572

   @DaanHoogland Oh, I see.
   Okay, I will look into it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6803: ui,server,api: resource metrics improvements

2022-12-19 Thread GitBox


blueorangutan commented on PR #6803:
URL: https://github.com/apache/cloudstack/pull/6803#issuecomment-1357819471

   @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 
mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6803: ui,server,api: resource metrics improvements

2022-12-19 Thread GitBox


DaanHoogland commented on PR #6803:
URL: https://github.com/apache/cloudstack/pull/6803#issuecomment-1357817702

   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2022-12-19 Thread GitBox


blueorangutan commented on PR #6991:
URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1357812437

   @DaanHoogland a Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6803: ui,server,api: resource metrics improvements

2022-12-19 Thread GitBox


blueorangutan commented on PR #6803:
URL: https://github.com/apache/cloudstack/pull/6803#issuecomment-1357799960

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 
:heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5028


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] GaOrtiga commented on pull request #6808: Allow privateips on console proxy

2022-12-19 Thread GitBox


GaOrtiga commented on PR #6808:
URL: https://github.com/apache/cloudstack/pull/6808#issuecomment-1357793822

   > @GaOrtiga as this is still in draft, should it be pushed to a later 
milestone? i.e. 4.19?
   
   Sorry about the delay to finish this, while creating the tests I found the 
error that was fixed here: https://github.com/apache/cloudstack/pull/6910
   This error needed to be fixed for the tests to run, so now that the fix was 
merged I came back for this PR.
   I believe I have finished the changes, it is working as expected so far.
   I will run some more tests and hopefully take out of draft this week.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] JoaoJandre commented on a diff in pull request #6918: Override vr service offering

2022-12-19 Thread GitBox


JoaoJandre commented on code in PR #6918:
URL: https://github.com/apache/cloudstack/pull/6918#discussion_r1052308831


##
framework/config/src/main/java/org/apache/cloudstack/framework/config/ConfigKey.java:
##
@@ -34,7 +34,7 @@
 public static final String CATEGORY_ALERT = "Alert";
 
 public static enum Scope {
-Global, Zone, Cluster, StoragePool, Account, ManagementServer, 
ImageStore, Domain
+Global, Zone, Cluster, StoragePool, Account, Domain, ManagementServer, 
ImageStore, Network

Review Comment:
   @soreana, in some places in ACS, the enums' order affect the feature's 
behavior (for instance, the AccountType's ordinal is saved into the database). 
Would this reordering affect the feature's behavior or cause any type of 
regression?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] JoaoJandre commented on pull request #6938: Create API to reassign volume

2022-12-19 Thread GitBox


JoaoJandre commented on PR #6938:
URL: https://github.com/apache/cloudstack/pull/6938#issuecomment-1357789914

   @DaanHoogland , I took a look at your proposal, and as we are working on the 
Log4j upgrade, as @GutoVeronezi commented 
(https://github.com/apache/cloudstack/pull/6973#issuecomment-1347285676), I 
would rather not applying an intermediate step.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on a diff in pull request #6840: infra: edge zones

2022-12-19 Thread GitBox


shwstppr commented on code in PR #6840:
URL: https://github.com/apache/cloudstack/pull/6840#discussion_r1052247427


##
services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java:
##
@@ -1307,15 +1308,12 @@ public void onScanStart() {
 
 @Override
 public Long[] getScannablePools() {
-List zones = _dcDao.listEnabledZones();
-
-Long[] dcIdList = new Long[zones.size()];
-int i = 0;
-for (DataCenterVO dc : zones) {
-dcIdList[i++] = dc.getId();
+List zones = _dcDao.listEnabledNonEdgeZones();
+List zoneIds = 
zones.stream().map(DataCenterVO::getId).collect(Collectors.toList());

Review Comment:
   @nvazquez since listEnabledNonEdgeZones uses `GenericDaoBase::listBy` it 
won't return null. It will always return a list and an empty list when no zones 
found.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6803: ui,server,api: resource metrics improvements

2022-12-19 Thread GitBox


blueorangutan commented on PR #6803:
URL: https://github.com/apache/cloudstack/pull/6803#issuecomment-1357734284

   @shwstppr a Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #6803: ui,server,api: resource metrics improvements

2022-12-19 Thread GitBox


shwstppr commented on PR #6803:
URL: https://github.com/apache/cloudstack/pull/6803#issuecomment-1357733357

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] github-actions[bot] commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2022-12-19 Thread GitBox


github-actions[bot] commented on PR #6991:
URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1357733245

   This pull request has merge conflicts. Dear author, please fix the conflicts 
and sync your branch with the base branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[cloudstack] branch main updated: README: that time of the year! :christmas_tree: (#6982)

2022-12-19 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/main by this push:
 new 95074f69ba2 README: that time of the year! :christmas_tree: (#6982)
95074f69ba2 is described below

commit 95074f69ba242f6190c23f2ba851fa560421c34d
Author: Rohit Yadav 
AuthorDate: Mon Dec 19 19:33:53 2022 +0530

README: that time of the year! :christmas_tree: (#6982)
---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README.md b/README.md
index 5fb5ba1a190..3cd3ac24ff8 100644
--- a/README.md
+++ b/README.md
@@ -1,6 +1,6 @@
 # Apache CloudStack [![Build 
Status](https://app.travis-ci.com/apache/cloudstack.svg?branch=main)](https://app.travis-ci.com/apache/cloudstack)
 [![Quality Gate 
Status](https://sonarcloud.io/api/project_badges/measure?project=apache_cloudstack=alert_status)](https://sonarcloud.io/dashboard?id=apache_cloudstack)
 
[![codecov](https://codecov.io/gh/apache/cloudstack/branch/main/graph/badge.svg)](https://codecov.io/gh/apache/cloudstack)
 
-![Apache CloudStack](tools/logo/apache_cloudstack.png)
+![Apache CloudStack](tools/logo/acsxmas.jpg)
 
 Apache CloudStack is open source software designed to deploy and manage large
 networks of virtual machines, as a highly available, highly scalable



[GitHub] [cloudstack] DaanHoogland merged pull request #6982: README: that time of the year! :christmas_tree:

2022-12-19 Thread GitBox


DaanHoogland merged PR #6982:
URL: https://github.com/apache/cloudstack/pull/6982


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6869: Support for parameter `cidrlist` added to the UI

2022-12-19 Thread GitBox


blueorangutan commented on PR #6869:
URL: https://github.com/apache/cloudstack/pull/6869#issuecomment-1357710646

   UI build: :heavy_check_mark:
   Live QA URL: https://qa.cloudstack.cloud/simulator/pr/6869 (QA-JID-19)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6869: Support for parameter `cidrlist` added to the UI

2022-12-19 Thread GitBox


blueorangutan commented on PR #6869:
URL: https://github.com/apache/cloudstack/pull/6869#issuecomment-1357704210

   @JoaoJandre a Jenkins job has been kicked to build UI QA env. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] JoaoJandre commented on pull request #6869: Support for parameter `cidrlist` added to the UI

2022-12-19 Thread GitBox


JoaoJandre commented on PR #6869:
URL: https://github.com/apache/cloudstack/pull/6869#issuecomment-1357703252

   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6960: create parameter to determine whether roles are public or private

2022-12-19 Thread GitBox


DaanHoogland commented on PR #6960:
URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1357695116

   No, I meant for the functionality in this PR in general. And I mean in an 
automated fashion so they can serve as regression tests in the future. I.e. 
automate the scenario you described under "How Has This Been Tested?".


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6959: Metrics plugin: expose full domain path instead of name

2022-12-19 Thread GitBox


blueorangutan commented on PR #6959:
URL: https://github.com/apache/cloudstack/pull/6959#issuecomment-1357691347

   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6959: Metrics plugin: expose full domain path instead of name

2022-12-19 Thread GitBox


DaanHoogland commented on PR #6959:
URL: https://github.com/apache/cloudstack/pull/6959#issuecomment-1357690906

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6960: create parameter to determine whether roles are public or private

2022-12-19 Thread GitBox


sonarcloud[bot] commented on PR #6960:
URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1357647858

   SonarCloud Quality Gate failed.  [![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate 
failed')](https://sonarcloud.io/dashboard?id=apache_cloudstack=6960)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6960=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6960=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=6960=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6960=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6960=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=6960=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6960=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6960=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6960=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6960=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=6960=false=CODE_SMELL)
 [3 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=6960=false=CODE_SMELL)
   
   
[![33.3%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/25-16px.png
 
'33.3%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=6960=new_coverage=list)
 [33.3% 
Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=6960=new_coverage=list)
  
   
[![4.6%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/5-16px.png
 
'4.6%')](https://sonarcloud.io/component_measures?id=apache_cloudstack=6960=new_duplicated_lines_density=list)
 [4.6% 
Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=6960=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6959: Metrics plugin: expose full domain path instead of name

2022-12-19 Thread GitBox


blueorangutan commented on PR #6959:
URL: https://github.com/apache/cloudstack/pull/6959#issuecomment-1357598680

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 
:heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5026


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6884: Update en.json

2022-12-19 Thread GitBox


DaanHoogland commented on PR #6884:
URL: https://github.com/apache/cloudstack/pull/6884#issuecomment-1357559627

   @alexandremattioli is this ready? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6892: Externalize KVM HA heartbeat frequency

2022-12-19 Thread GitBox


DaanHoogland commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1357556145

   > management:
   > 
   > ```
   > 022-12-02 14:36:53,653 DEBUG [c.c.a.ApiServlet] 
(qtp262366552-16:ctx-738fd6f7) (logid:944d439c) ===START===  10.0.35.111 -- GET 
 
apiKey=LIN6rqXuaJwMPfGYFh13qDwYz5VNNz1J2J6qIOWcd3oLQOq0WtD4CwRundBL6rzXToa3lQOC_vKjI3nkHtiD8Q=a94
   > 
89c75-dbcc-4a51-8081-a76fdff1345b=addHost=KVM=1ca6f4d3-fe8b-4eaf-be94-915fcd313a08=json=http%3A%2F%2F10.0.33.209=root=ddb1c828-a5eb-4010-83c6-cd9a681a9972=VVRH4DxK1Kow9bs%2B
   > jnuzGlWRam0%3D
   > 2022-12-02 14:36:53,657 DEBUG [c.c.a.ApiServer] 
(qtp262366552-16:ctx-738fd6f7 ctx-406aaf36) (logid:944d439c) CIDRs from which 
account 'Account 
[{"accountName":"admin","id":2,"uuid":"e1e1ae59-724d-11ed-9f35-1e002d000402"}]' 
is allowed to 
   > perform API calls: 0.0.0.0/0,::/0
   > 2022-12-02 14:36:53,659 INFO  [o.a.c.a.DynamicRoleBasedAPIAccessChecker] 
(qtp262366552-16:ctx-738fd6f7 ctx-406aaf36) (logid:944d439c) Account [Account 
[{"accountName":"admin","id":2,"uuid":"e1e1ae59-724d-11ed-9f35-1e002d000402"}]] 
is Roo
   > t Admin or Domain Admin, all APIs are allowed.
   > 2022-12-02 14:36:53,660 WARN  [o.a.c.a.ProjectRoleBasedApiAccessChecker] 
(qtp262366552-16:ctx-738fd6f7 ctx-406aaf36) (logid:944d439c) Project is null, 
ProjectRoleBasedApiAccessChecker only applies to projects, returning API 
[addHost] for
   >  user [User 
{"username":"admin","uuid":"6ca2d90b-98d3-4e6a-ba3b-328507d9044c"}.] as allowed.
   > 2022-12-02 14:36:53,660 DEBUG [o.a.c.a.StaticRoleBasedAPIAccessChecker] 
(qtp262366552-16:ctx-738fd6f7 ctx-406aaf36) (logid:944d439c) RoleService is 
enabled. We will use it instead of StaticRoleBasedAPIAccessChecker.
   > 2022-12-02 14:36:53,661 DEBUG [o.a.c.r.ApiRateLimitServiceImpl] 
(qtp262366552-16:ctx-738fd6f7 ctx-406aaf36) (logid:944d439c) API rate limiting 
is disabled. We will not use ApiRateLimitService.
   > 2022-12-02 14:36:53,667 INFO  [c.c.r.ResourceManagerImpl] 
(qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) 
Trying to add a new host at http://10.0.33.209 in data center 1
   > 2022-12-02 14:36:53,901 WARN  [c.c.u.s.SSHCmdHelper] 
(qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) 
Failed to authenticate with ssh key
   > 2022-12-02 14:36:53,902 ERROR [c.c.h.k.d.LibvirtServerDiscoverer] 
(qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) 
Failed to authenticate with ssh key
   > 2022-12-02 14:36:53,927 DEBUG [c.c.u.s.SSHCmdHelper] 
(qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) 
Executing cmd: ls /dev/kvm
   > 2022-12-02 14:36:55,159 DEBUG [c.c.u.s.SSHCmdHelper] 
(qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) SSH 
command: ls /dev/kvm
   > SSH command output:/dev/kvm
   > 
   > 
   > 2022-12-02 14:36:55,171 DEBUG [c.c.u.s.SSHCmdHelper] 
(qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) 
Executing cmd: sudo /usr/share/cloudstack-common/scripts/util/keystore-setup 
/etc/cloudstack/agent/agent.properties /etc/cloudstack/agent/
   > 2022-12-02 14:36:56,054 DEBUG [o.a.c.h.HAManagerImpl] 
(BackgroundTaskPollManager-4:ctx-cb611b95) (logid:78fc051a) HA health check 
task is running...
   > 2022-12-02 14:36:57,537 DEBUG [c.c.u.s.SSHCmdHelper] 
(qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) SSH 
command: sudo /usr/share/cloudstack-common/scripts/util/keystore-setup 
/etc/cloudstack/agent/agent.properties /etc/cloudstack/agent/
   > SSH command output:
   > 
   > 2022-12-02 14:36:57,597 DEBUG [c.c.u.s.SSHCmdHelper] 
(qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) 
Executing cmd: sudo 
/usr/share/cloudstack-common/scripts/util/keystore-cert-import 
/etc/cloudstack/agent/agent.properties 9MVW4zn3ytOMWKwp /etc/cloudstack/agent/
   > 2022-12-02 14:36:58,864 DEBUG [c.c.c.ConsoleProxyManagerImpl] 
(consoleproxy-1:ctx-ca157098) (logid:c345ffc8) Skip capacity scan as there is 
no Primary Storage in 'Up' state
   > 2022-12-02 14:36:59,921 DEBUG [c.c.u.s.SSHCmdHelper] 
(qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) SSH 
command: sudo /usr/share/cloudstack-common/scripts/util/keystore-cert-import 
/etc/cloudstack/agent/agent.properties 9MVW4zn3ytOMWKwp /etc/cloudstack/agent/
   > SSH command output:
   > chmod: cannot access ‘/etc/cloudstack/agent/cloud.key’: No such file or 
directory
   > 
   > 2022-12-02 14:36:59,921 DEBUG [c.c.u.s.SSHCmdHelper] 
(qtp262366552-16:ctx-738fd6f7 ctx-406aaf36 ctx-5aca3161) (logid:944d439c) 
Executing cmd: sudo 
/usr/share/cloudstack-common/scripts/util/keystore-cert-import 
/etc/cloudstack/agent/agent.properties 9MVW4zn3ytOMWKwp /etc/cloudstack/agent/
   > 2022-12-02 14:37:00,055 DEBUG [o.a.c.h.HAManagerImpl] 
(BackgroundTaskPollManager-1:ctx-b9a7c1a3) (logid:b4f987fc) HA health check 
task is running...
   > 2022-12-02 14:37:02,202 DEBUG [c.c.u.s.SSHCmdHelper] 

[GitHub] [cloudstack] nvazquez commented on a diff in pull request #6840: infra: edge zones

2022-12-19 Thread GitBox


nvazquez commented on code in PR #6840:
URL: https://github.com/apache/cloudstack/pull/6840#discussion_r1052123246


##
services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java:
##
@@ -1307,15 +1308,12 @@ public void onScanStart() {
 
 @Override
 public Long[] getScannablePools() {
-List zones = _dcDao.listEnabledZones();
-
-Long[] dcIdList = new Long[zones.size()];
-int i = 0;
-for (DataCenterVO dc : zones) {
-dcIdList[i++] = dc.getId();
+List zones = _dcDao.listEnabledNonEdgeZones();
+List zoneIds = 
zones.stream().map(DataCenterVO::getId).collect(Collectors.toList());

Review Comment:
   Can we add a null check for zones before this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] GaOrtiga commented on pull request #6960: create parameter to determine whether roles are public or private

2022-12-19 Thread GitBox


GaOrtiga commented on PR #6960:
URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1357545862

   > @GaOrtiga do you think regression/integration tests as sensible for this 
change?
   
   Do you mean for the PR as a whole or for this last change submitted?
   
   If it is for the whole PR, I have run some regression tests and all of them 
worked out properly, however if you have concerns about any specific 
functionality, I can run some more.
   
   If it is for this last change I don´t think any other testing is necessary, 
since the arguments deleted were really not being used.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] CharlesQueiroz commented on pull request #6899: Count Resource Virtual Router

2022-12-19 Thread GitBox


CharlesQueiroz commented on PR #6899:
URL: https://github.com/apache/cloudstack/pull/6899#issuecomment-1357535280

   Yes. Let me check... 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6892: Externalize KVM HA heartbeat frequency

2022-12-19 Thread GitBox


blueorangutan commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1357532971

   Trillian Build Failed (tid-5564)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] rohityadavcloud commented on pull request #6990: [HEALTH] 4.17.2.0 RC3 Health Check, please don't merge this!

2022-12-19 Thread GitBox


rohityadavcloud commented on PR #6990:
URL: https://github.com/apache/cloudstack/pull/6990#issuecomment-1357530896

   Nope @DaanHoogland this is the RC3 branch; I merged it to 4.17 following 
release process 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+Procedure after 
vote for RC3 passed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6808: Allow privateips on console proxy

2022-12-19 Thread GitBox


DaanHoogland commented on PR #6808:
URL: https://github.com/apache/cloudstack/pull/6808#issuecomment-1357524868

   @GaOrtiga as this is still in draft, should it be pushed to a later 
milestone? i.e. 4.19?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6426: Configurable MTU for VR

2022-12-19 Thread GitBox


blueorangutan commented on PR #6426:
URL: https://github.com/apache/cloudstack/pull/6426#issuecomment-1357515434

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 
:heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 5025


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6995: Packages consolidation: merge suse15 to el8

2022-12-19 Thread GitBox


blueorangutan commented on PR #6995:
URL: https://github.com/apache/cloudstack/pull/6995#issuecomment-1357508801

   @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 
mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6995: Packages consolidation: merge suse15 to el8

2022-12-19 Thread GitBox


DaanHoogland commented on PR #6995:
URL: https://github.com/apache/cloudstack/pull/6995#issuecomment-1357506196

   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6960: create parameter to determine whether roles are public or private

2022-12-19 Thread GitBox


DaanHoogland commented on PR #6960:
URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1357504759

   @GaOrtiga do you think regression/integration tests as sensible for this 
change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6960: create parameter to determine whether roles are public or private

2022-12-19 Thread GitBox


DaanHoogland commented on PR #6960:
URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1357504238

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6242: Search for resource type efficiently

2022-12-19 Thread GitBox


blueorangutan commented on PR #6242:
URL: https://github.com/apache/cloudstack/pull/6242#issuecomment-1357500847

   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6242: Search for resource type efficiently

2022-12-19 Thread GitBox


DaanHoogland commented on PR #6242:
URL: https://github.com/apache/cloudstack/pull/6242#issuecomment-1357500757

   @ravening can you add some tests? (or a #!human test description)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6242: Search for resource type efficiently

2022-12-19 Thread GitBox


DaanHoogland commented on PR #6242:
URL: https://github.com/apache/cloudstack/pull/6242#issuecomment-1357499768

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6995: Packages consolidation: merge suse15 to el8

2022-12-19 Thread GitBox


blueorangutan commented on PR #6995:
URL: https://github.com/apache/cloudstack/pull/6995#issuecomment-1357499694

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 
:heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5024


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6832: Allow root admin to deploy in VPCs in child domains

2022-12-19 Thread GitBox


blueorangutan commented on PR #6832:
URL: https://github.com/apache/cloudstack/pull/6832#issuecomment-1357496961

   @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 
mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6832: Allow root admin to deploy in VPCs in child domains

2022-12-19 Thread GitBox


DaanHoogland commented on PR #6832:
URL: https://github.com/apache/cloudstack/pull/6832#issuecomment-1357495791

   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6960: create parameter to determine whether roles are public or private

2022-12-19 Thread GitBox


blueorangutan commented on PR #6960:
URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1357494865

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 
:heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5023


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6550: Emc networker b

2022-12-19 Thread GitBox


blueorangutan commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1357489804

   @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 
mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6550: Emc networker b

2022-12-19 Thread GitBox


DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1357488321

   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on issue #6998: There is no secondary storage VM for system VM, start ssvm failed.

2022-12-19 Thread GitBox


DaanHoogland commented on issue #6998:
URL: https://github.com/apache/cloudstack/issues/6998#issuecomment-1357487707

   @khoinek @haccolo1, can you give some more information please?
   How can we reproduce this scenario?
   What are the versions and other parameters of the environment you are 
running (i.e. what type of hypervisors/storage/network)?
   thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6946: server: add Host Control Plane Status to uservm and systemvm response

2022-12-19 Thread GitBox


blueorangutan commented on PR #6946:
URL: https://github.com/apache/cloudstack/pull/6946#issuecomment-1357486103

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 
:heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5022


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6242: Search for resource type efficiently

2022-12-19 Thread GitBox


blueorangutan commented on PR #6242:
URL: https://github.com/apache/cloudstack/pull/6242#issuecomment-1357481480

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 
:heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5021


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6899: Count Resource Virtual Router

2022-12-19 Thread GitBox


DaanHoogland commented on PR #6899:
URL: https://github.com/apache/cloudstack/pull/6899#issuecomment-1357471477

   @CharlesQueiroz , the test environments mysteriously stop logging after 
   ```
   2022-12-19 10:45:55,415 DEBUG [o.a.c.f.c.i.ConfigDepotImpl] (main:null) 
(logid:) Retrieving keys from ConfigurationManagerImpl
   ```
   Can you have a look at your changes in that class, please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6012: Add volume group handling

2022-12-19 Thread GitBox


DaanHoogland commented on PR #6012:
URL: https://github.com/apache/cloudstack/pull/6012#issuecomment-1357462557

   @DK101010 the smoke test runs fail to start the system VMs due to
   ```
   2022-12-19 09:37:50,085 WARN  [c.c.v.VirtualMachineManagerImpl] 
(Work-Job-Executor-2:ctx-48cb44d7 job-4/job-30 ctx-f8c501d2) (logid:d647b5b8) 
Unable to orchestrate start VM instance 
{"id":2,"instanceName":"s-2-VM","type":"SecondaryStorageVm","uuid":"47535f32-97f4-4ad0-9393-64154953ac78"}
 due to [DB Exception on: com.mysql.cj.jdbc.ClientPreparedStatement: SELECT 
volume_group.id, volume_group.vm_id, volume_group.volume_id, 
volume_group.group_number FROM volume_group WHERE volume_group.vm_id = 2  AND 
volume_group.volume_id = 2  ORDER BY RAND() LIMIT 1].
   com.cloud.utils.exception.CloudRuntimeException: DB Exception on: 
com.mysql.cj.jdbc.ClientPreparedStatement: SELECT volume_group.id, 
volume_group.vm_id, volume_group.volume_id, volume_group.group_number FROM 
volume_group WHERE volume_group.vm_id = 2  AND volume_group.volume_id = 2  
ORDER BY RAND() LIMIT 1
   at 
com.cloud.utils.db.GenericDaoBase.searchIncludingRemoved(GenericDaoBase.java:424)
   at 
com.cloud.utils.db.GenericDaoBase.searchIncludingRemoved(GenericDaoBase.java:360)
   at 
com.cloud.utils.db.GenericDaoBase.findOneIncludingRemovedBy(GenericDaoBase.java:897)
   at 
com.cloud.utils.db.GenericDaoBase.findOneBy(GenericDaoBase.java:906)
   at 
com.cloud.storage.dao.VolumeGroupDaoImpl.findByVmAndVolume(VolumeGroupDaoImpl.java:67)
   at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   at java.base/java.lang.reflect.Method.invoke(Method.java:566)
   at 
org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344)
   at 
org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198)
   at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
   at 
com.cloud.utils.db.TransactionContextInterceptor.invoke(TransactionContextInterceptor.java:34)
   at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:175)
   at 
org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
   at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
   at 
org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215)
   at com.sun.proxy.$Proxy230.findByVmAndVolume(Unknown Source)
   at 
com.cloud.hypervisor.HypervisorGuruBase.lambda$addGroupsToDisks$0(HypervisorGuruBase.java:313)
   at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
   at 
com.cloud.hypervisor.HypervisorGuruBase.addGroupsToDisks(HypervisorGuruBase.java:312)
   at 
com.cloud.hypervisor.HypervisorGuruBase.toVirtualMachineTO(HypervisorGuruBase.java:256)
   at com.cloud.hypervisor.KVMGuru.implement(KVMGuru.java:116)
   at 
com.cloud.vm.VirtualMachineManagerImpl.orchestrateStart(VirtualMachineManagerImpl.java:1205)
   at 
com.cloud.vm.VirtualMachineManagerImpl.orchestrateStart(VirtualMachineManagerImpl.java:5333)
   at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   at java.base/java.lang.reflect.Method.invoke(Method.java:566)
   at 
com.cloud.vm.VmWorkJobHandlerProxy.handleVmWorkJob(VmWorkJobHandlerProxy.java:107)
   at 
com.cloud.vm.VirtualMachineManagerImpl.handleVmWorkJob(VirtualMachineManagerImpl.java:5457)
   at 
com.cloud.vm.VmWorkJobDispatcher.runJob(VmWorkJobDispatcher.java:102)
   at 
org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:620)
   at 
org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:48)
   at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:55)
   at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:102)
   at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:52)
   at 

[GitHub] [cloudstack] blueorangutan commented on pull request #6832: Allow root admin to deploy in VPCs in child domains

2022-12-19 Thread GitBox


blueorangutan commented on PR #6832:
URL: https://github.com/apache/cloudstack/pull/6832#issuecomment-1357462311

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 
:heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5020


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6899: Count Resource Virtual Router

2022-12-19 Thread GitBox


blueorangutan commented on PR #6899:
URL: https://github.com/apache/cloudstack/pull/6899#issuecomment-1357456209

   Trillian Build Failed (tid-5563)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6426: Configurable MTU for VR

2022-12-19 Thread GitBox


blueorangutan commented on PR #6426:
URL: https://github.com/apache/cloudstack/pull/6426#issuecomment-1357448791

   @NuxRo a Jenkins job has been kicked to build packages. It will be bundled 
with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I 
make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] NuxRo commented on pull request #6426: Configurable MTU for VR

2022-12-19 Thread GitBox


NuxRo commented on PR #6426:
URL: https://github.com/apache/cloudstack/pull/6426#issuecomment-1357448117

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6550: Emc networker b

2022-12-19 Thread GitBox


blueorangutan commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1357444633

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 
:heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5019


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] haccolo1 commented on issue #6998: There is no secondary storage VM for system VM, start ssvm failed.

2022-12-19 Thread GitBox


haccolo1 commented on issue #6998:
URL: https://github.com/apache/cloudstack/issues/6998#issuecomment-1357438258

   I have a problem same you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] khoinek commented on issue #6998: There is no secondary storage VM for system VM, start ssvm failed.

2022-12-19 Thread GitBox


khoinek commented on issue #6998:
URL: https://github.com/apache/cloudstack/issues/6998#issuecomment-1357433595

   
![image](https://user-images.githubusercontent.com/121023233/208405618-7a8651de-ecd4-4ee6-8448-17e6740fe340.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on issue #6993: Root volume of system vms is being listed

2022-12-19 Thread GitBox


DaanHoogland commented on issue #6993:
URL: https://github.com/apache/cloudstack/issues/6993#issuecomment-1357426975

   are they shown to normal users, than yes. If not then I would call it an 
accidental improvement, if not planned. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6995: Packages consolidation: merge suse15 to el8

2022-12-19 Thread GitBox


blueorangutan commented on PR #6995:
URL: https://github.com/apache/cloudstack/pull/6995#issuecomment-1357424009

   @DaanHoogland a Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6995: Packages consolidation: merge suse15 to el8

2022-12-19 Thread GitBox


DaanHoogland commented on PR #6995:
URL: https://github.com/apache/cloudstack/pull/6995#issuecomment-1357422837

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6803: ui,server,api: resource metrics improvements

2022-12-19 Thread GitBox


blueorangutan commented on PR #6803:
URL: https://github.com/apache/cloudstack/pull/6803#issuecomment-1357422444

   @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 
mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6803: ui,server,api: resource metrics improvements

2022-12-19 Thread GitBox


DaanHoogland commented on PR #6803:
URL: https://github.com/apache/cloudstack/pull/6803#issuecomment-1357421123

   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #6661: Enable live volume migration for StorPool and small fixes

2022-12-19 Thread GitBox


blueorangutan commented on PR #6661:
URL: https://github.com/apache/cloudstack/pull/6661#issuecomment-1357420947

   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6661: Enable live volume migration for StorPool and small fixes

2022-12-19 Thread GitBox


DaanHoogland commented on PR #6661:
URL: https://github.com/apache/cloudstack/pull/6661#issuecomment-1357419313

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[cloudstack] branch main updated: test: use normal user for createing networks, vpcs (#6988)

2022-12-19 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/main by this push:
 new 588287af17f test: use normal user for createing networks, vpcs (#6988)
588287af17f is described below

commit 588287af17f083504c9ea9c58ae53de89deb7f19
Author: Abhishek Kumar 
AuthorDate: Mon Dec 19 15:49:56 2022 +0530

test: use normal user for createing networks, vpcs (#6988)

When using admin=True in account creation with domain it creates a domain 
admin. It would be better to run tests as normal user.

Signed-off-by: Abhishek Kumar 
---
 test/integration/component/test_network_ipv6.py | 2 +-
 test/integration/component/test_vpc_ipv6.py | 2 +-
 test/integration/smoke/test_network_ipv6.py | 2 +-
 test/integration/smoke/test_vpc_ipv6.py | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/test/integration/component/test_network_ipv6.py 
b/test/integration/component/test_network_ipv6.py
index 30734d73d95..1e2c53879fd 100644
--- a/test/integration/component/test_network_ipv6.py
+++ b/test/integration/component/test_network_ipv6.py
@@ -135,7 +135,7 @@ class TestIpv6Network(cloudstackTestCase):
 cls.account = Account.create(
 cls.apiclient,
 cls.services["account"],
-admin=True,
+admin=False,
 domainid=cls.domain.id
 )
 cls._cleanup.append(cls.account)
diff --git a/test/integration/component/test_vpc_ipv6.py 
b/test/integration/component/test_vpc_ipv6.py
index fda46ea2378..bb44af936af 100644
--- a/test/integration/component/test_vpc_ipv6.py
+++ b/test/integration/component/test_vpc_ipv6.py
@@ -152,7 +152,7 @@ class TestIpv6Vpc(cloudstackTestCase):
 cls.account = Account.create(
 cls.apiclient,
 cls.services["account"],
-admin=True,
+admin=False,
 domainid=cls.domain.id
 )
 cls._cleanup.append(cls.account)
diff --git a/test/integration/smoke/test_network_ipv6.py 
b/test/integration/smoke/test_network_ipv6.py
index 41b7c85dea0..720f14e64da 100644
--- a/test/integration/smoke/test_network_ipv6.py
+++ b/test/integration/smoke/test_network_ipv6.py
@@ -135,7 +135,7 @@ class TestIpv6Network(cloudstackTestCase):
 cls.account = Account.create(
 cls.apiclient,
 cls.services["account"],
-admin=True,
+admin=False,
 domainid=cls.domain.id
 )
 cls._cleanup.append(cls.account)
diff --git a/test/integration/smoke/test_vpc_ipv6.py 
b/test/integration/smoke/test_vpc_ipv6.py
index e00c578809c..ce4d466acf0 100644
--- a/test/integration/smoke/test_vpc_ipv6.py
+++ b/test/integration/smoke/test_vpc_ipv6.py
@@ -152,7 +152,7 @@ class TestIpv6Vpc(cloudstackTestCase):
 cls.account = Account.create(
 cls.apiclient,
 cls.services["account"],
-admin=True,
+admin=False,
 domainid=cls.domain.id
 )
 cls._cleanup.append(cls.account)



[GitHub] [cloudstack] DaanHoogland merged pull request #6988: test: use normal user for creating networks, vpcs

2022-12-19 Thread GitBox


DaanHoogland merged PR #6988:
URL: https://github.com/apache/cloudstack/pull/6988


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host

2022-12-19 Thread GitBox


DaanHoogland commented on PR #6809:
URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1357416083

   @nvazquez @weizhouapache @GutoVeronezi @wido we need more reviews here, 
please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



  1   2   >