[GitHub] [cloudstack] weizhouapache commented on issue #6794: Cannot start cloudstack-agent after upgrade from 4.16.1 to 4.17.1
weizhouapache commented on issue #6794: URL: https://github.com/apache/cloudstack/issues/6794#issuecomment-1363705765 @levindecaro I think you need to remove cloud-plugin-hypervisor-kvm-4.15.0.0.jar -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6946: server: add Host Control Plane Status to uservm and systemvm response
blueorangutan commented on PR #6946: URL: https://github.com/apache/cloudstack/pull/6946#issuecomment-1363705556 @borisstoyanov a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #6946: server: add Host Control Plane Status to uservm and systemvm response
borisstoyanov commented on PR #6946: URL: https://github.com/apache/cloudstack/pull/6946#issuecomment-1363705110 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] levindecaro commented on issue #6794: Cannot start cloudstack-agent after upgrade from 4.16.1 to 4.17.1
levindecaro commented on issue #6794: URL: https://github.com/apache/cloudstack/issues/6794#issuecomment-1363702119 ``` [root@compute-20 ~]# cat /etc/redhat-release CentOS Linux release 7.9.2009 (Core) ``` ``` [root@compute-20 ~]# java -version openjdk version "11.0.11" 2021-04-20 LTS OpenJDK Runtime Environment 18.9 (build 11.0.11+9-LTS) OpenJDK 64-Bit Server VM 18.9 (build 11.0.11+9-LTS, mixed mode, sharing) ``` ``` [root@compute-20 ~]# ls -l /usr/share/cloudstack-agent/lib total 91352 -rw-r--r-- 1 root root 69409 Dec 22 17:57 activation-1.1.1.jar -rw-r--r-- 1 root root 17536 Dec 22 17:57 annotations-13.0.jar -rw-r--r-- 1 root root 90662 Dec 22 17:57 antisamy-1.5.3.jar -rw-r--r-- 1 root root 14768 Dec 22 17:57 aopalliance-repackaged-2.5.0-b42.jar -rw-r--r-- 1 root root 448794 Dec 22 17:57 apache-log4j-extras-1.2.17.jar -rw-r--r-- 1 root root 1930381 Dec 22 17:57 aspectjweaver-1.8.13.jar -rw-r--r-- 1 root root 1018510 Dec 22 17:57 aws-java-sdk-core-1.11.940.jar -rw-r--r-- 1 root root 594212 Dec 22 17:57 aws-java-sdk-kms-1.11.940.jar -rw-r--r-- 1 root root 1230346 Dec 22 17:57 aws-java-sdk-s3-1.11.940.jar -rw-r--r-- 1 root root8433 Dec 22 17:57 batik-constants-1.14.jar -rw-r--r-- 1 root root 330318 Dec 22 17:57 batik-css-1.14.jar -rw-r--r-- 1 root root 11466 Dec 22 17:57 batik-i18n-1.14.jar -rw-r--r-- 1 root root6663 Dec 22 17:57 batik-shared-resources-1.14.jar -rw-r--r-- 1 root root 127477 Dec 22 17:57 batik-util-1.14.jar -rw-r--r-- 1 root root 963713 Dec 22 17:57 bcpkix-jdk15on-1.70.jar -rw-r--r-- 1 root root 5867298 Dec 22 17:57 bcprov-jdk15on-1.70.jar -rw-r--r-- 1 root root 1457398 Dec 22 17:57 bctls-jdk15on-1.70.jar -rw-r--r-- 1 root root 482530 Dec 22 17:57 bcutil-jdk15on-1.70.jar -rw-r--r-- 1 root root 143992 Dec 22 17:57 bsh-core-2.0b4.jar -rw-r--r-- 1 root root 415348 Dec 22 17:57 cglib-nodep-3.3.0.jar -rw-r--r-- 1 root root 214381 Dec 22 17:57 checker-qual-3.5.0.jar -rw-r--r-- 1 root root 97055 Dec 22 17:57 cloud-agent-4.17.2.0.jar -rw-r--r-- 1 root root 2290269 Dec 22 17:57 cloud-api-4.17.2.0.jar -rw-r--r-- 1 root root 576521 Dec 22 17:57 cloud-core-4.17.2.0.jar -rw-r--r-- 1 root root 103668 Dec 22 17:57 cloud-engine-api-4.17.2.0.jar -rw-r--r-- 1 root root 76537 Dec 22 17:57 cloud-engine-components-api-4.17.2.0.jar -rw-r--r-- 1 root root 1873790 Dec 22 17:57 cloud-engine-schema-4.17.2.0.jar -rw-r--r-- 1 root root 167883 Dec 22 17:57 cloud-engine-storage-4.17.2.0.jar -rw-r--r-- 1 root root 17189 Dec 22 17:57 cloud-engine-storage-configdrive-4.17.2.0.jar -rw-r--r-- 1 root root 64512 Dec 22 17:57 cloud-engine-storage-image-4.17.2.0.jar -rw-r--r-- 1 root root 89243 Dec 22 17:57 cloud-engine-storage-volume-4.17.2.0.jar -rw-r--r-- 1 root root6665 Dec 22 17:57 cloud-framework-agent-lb-4.17.2.0.jar -rw-r--r-- 1 root root7622 Dec 22 17:57 cloud-framework-ca-4.17.2.0.jar -rw-r--r-- 1 root root 78031 Dec 22 17:57 cloud-framework-cluster-4.17.2.0.jar -rw-r--r-- 1 root root 29919 Dec 22 17:57 cloud-framework-config-4.17.2.0.jar -rw-r--r-- 1 root root 169293 Dec 22 17:57 cloud-framework-db-4.17.2.0.jar -rw-r--r-- 1 root root 10418 Dec 22 17:57 cloud-framework-direct-download-4.17.2.0.jar -rw-r--r-- 1 root root 12441 Dec 22 17:57 cloud-framework-events-4.17.2.0.jar -rw-r--r-- 1 root root 91967 Dec 22 17:57 cloud-framework-ipc-4.17.2.0.jar -rw-r--r-- 1 root root 120836 Dec 22 17:57 cloud-framework-jobs-4.17.2.0.jar -rw-r--r-- 1 root root 18092 Dec 22 17:57 cloud-framework-managed-context-4.17.2.0.jar -rw-r--r-- 1 root root 12346 Dec 22 17:57 cloud-framework-rest-4.17.2.0.jar -rw-r--r-- 1 root root 24812 Dec 22 17:57 cloud-framework-security-4.17.2.0.jar -rwxr-xr-x 1 root root 525409 Oct 23 2021 cloud-plugin-hypervisor-kvm-4.15.0.0.jar -rw-r--r-- 1 root root 593523 Dec 22 17:57 cloud-plugin-hypervisor-kvm-4.17.2.0.jar -rw-r--r-- 1 root root 84494 Dec 22 17:57 cloud-plugin-network-ovs-4.17.2.0.jar -rw-r--r-- 1 root root 82833 Dec 22 17:57 cloud-plugin-storage-volume-scaleio-4.17.2.0.jar -rw-r--r-- 1 root root 151621 Dec 22 17:57 cloud-plugin-storage-volume-storpool-4.17.2.0.jar -rw-r--r-- 1 root root 123023 Dec 22 17:57 cloud-secondary-storage-4.17.2.0.jar -rw-r--r-- 1 root root 3435303 Dec 22 17:57 cloud-server-4.17.2.0.jar -rw-r--r-- 1 root root 403787 Dec 22 17:57 cloud-utils-4.17.2.0.jar -rw-r--r-- 1 root root 233859 Dec 22 17:57 commons-beanutils-1.9.2.jar -rw-r--r-- 1 root root 353793 Dec 22 17:57 commons-codec-1.15.jar -rw-r--r-- 1 root root 575389 Dec 22 17:57 commons-collections-3.2.1.jar -rw-r--r-- 1 root root 1018316 Dec 22 17:57 commons-compress-1.21.jar -rw-r--r-- 1 root root 362679 Dec 22 17:57 commons-configuration-1.10.jar -rw-r--r-- 1 root root 25287 Dec 22 17:57
[GitHub] [cloudstack] top-secrett commented on issue #7019: Unable to migrate UEFI instances with XCP-NG
top-secrett commented on issue #7019: URL: https://github.com/apache/cloudstack/issues/7019#issuecomment-1363702279 > @top-secrett, can you try to migrate the VM via CLI? I've seen that there are some limitations in the UI for cases that are implemented and work in CS Can you help with it? I didn't work with CS CLI before -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6844: packaging: support Rocky9 (EL9) as KVM and management server host
blueorangutan commented on PR #6844: URL: https://github.com/apache/cloudstack/pull/6844#issuecomment-1363701049 @rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6844: packaging: support Rocky9 (EL9) as KVM and management server host
rohityadavcloud commented on PR #6844: URL: https://github.com/apache/cloudstack/pull/6844#issuecomment-1363700856 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
blueorangutan commented on PR #6942: URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1363689986 @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
weizhouapache commented on PR #6942: URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1363689827 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
sonarcloud[bot] commented on PR #6942: URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1363678057 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack=6942) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6942=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6942=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=6942=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6942=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6942=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=6942=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6942=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6942=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6942=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6942=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6942=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=6942=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6942=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=6942=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6942=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=6942=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] slavkap commented on pull request #6909: KVM support of iothreads
slavkap commented on PR #6909: URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1363676720 @wido, if you are talking about the IO policy, it could be set there, yes. But if the VM has a mixed type of volumes, probably it's a better option for each of them the IO policy to come from the storage pool -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework
blueorangutan commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1363671879 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5067 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework
blueorangutan commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1363671877 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
blueorangutan commented on PR #6942: URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1363671875 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5065 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6844: packaging: support Rocky9 (EL9) as KVM and management server host
blueorangutan commented on PR #6844: URL: https://github.com/apache/cloudstack/pull/6844#issuecomment-1363671876 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6840: infra: edge zones
blueorangutan commented on PR #6840: URL: https://github.com/apache/cloudstack/pull/6840#issuecomment-1363671870 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6844: packaging: support Rocky9 (EL9) as KVM and management server host
blueorangutan commented on PR #6844: URL: https://github.com/apache/cloudstack/pull/6844#issuecomment-1363671871 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5062 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6844: packaging: support Rocky9 (EL9) as KVM and management server host
blueorangutan commented on PR #6844: URL: https://github.com/apache/cloudstack/pull/6844#issuecomment-1363671874 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5063 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework
blueorangutan commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1363671873 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
blueorangutan commented on PR #6942: URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1363671872 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6840: infra: edge zones
blueorangutan commented on PR #6840: URL: https://github.com/apache/cloudstack/pull/6840#issuecomment-1363671878 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] slavkap commented on issue #7019: Unable to migrate UEFI instances with XCP-NG
slavkap commented on issue #7019: URL: https://github.com/apache/cloudstack/issues/7019#issuecomment-1363669333 @top-secrett, can you try to migrate the VM via CLI? I've seen that there are some limitations in the UI for cases that are implemented and work in CS -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6840: infra: edge zones
sonarcloud[bot] commented on PR #6840: URL: https://github.com/apache/cloudstack/pull/6840#issuecomment-1363664490 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack=6840) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6840=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6840=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=6840=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6840=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6840=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=6840=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6840=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6840=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6840=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6840=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6840=false=CODE_SMELL) [12 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=6840=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6840=new_coverage=list) [24.5% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=6840=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6840=new_duplicated_lines_density=list) [3.3% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=6840=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] top-secrett opened a new issue, #7019: Unable to migrate UEFI instances with XCP-NG
top-secrett opened a new issue, #7019: URL: https://github.com/apache/cloudstack/issues/7019 # ISSUE TYPE * Bug Report * Improvement Request * Enhancement Request * Feature Idea * Documentation Report * Other ~~~ # CLOUDSTACK VERSION ~~~ ~~~ # CONFIGURATION # OS / ENVIRONMENT # SUMMARY Unable to migrate UEFI instances with XCP-NG. But it is possible directly via XCP-NG # STEPS TO REPRODUCE ~~~ # ACTUAL RESULTS ~~~ ~~~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr closed pull request #6942: ssvm: synchorise when adding iptables and routing rules
shwstppr closed pull request #6942: ssvm: synchorise when adding iptables and routing rules URL: https://github.com/apache/cloudstack/pull/6942 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch main updated: systemvmtemplate: update Debian ISO URL and checksum (#7013)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/main by this push:
new d52e4d72b60 systemvmtemplate: update Debian ISO URL and checksum
(#7013)
d52e4d72b60 is described below
commit d52e4d72b60b3f56179b6fd30ac50ea11b326f52
Author: Rohit Yadav
AuthorDate: Fri Dec 23 11:26:38 2022 +0530
systemvmtemplate: update Debian ISO URL and checksum (#7013)
This fixes packer systemvmtemplate build
Signed-off-by: Rohit Yadav
---
pom.xml | 2 +-
.../appliance/systemvmtemplate/scripts/configure_systemvm_services.sh | 2 +-
tools/appliance/systemvmtemplate/template.json| 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/pom.xml b/pom.xml
index 51533139914..a105838141a 100644
--- a/pom.xml
+++ b/pom.xml
@@ -49,7 +49,7 @@
UTF-8
UTF-8
-
4.17.2.0
+
4.18.0.0
apache
https://sonarcloud.io
diff --git
a/tools/appliance/systemvmtemplate/scripts/configure_systemvm_services.sh
b/tools/appliance/systemvmtemplate/scripts/configure_systemvm_services.sh
index d40cbb89537..d1cfb4661fc 100644
--- a/tools/appliance/systemvmtemplate/scripts/configure_systemvm_services.sh
+++ b/tools/appliance/systemvmtemplate/scripts/configure_systemvm_services.sh
@@ -19,7 +19,7 @@
set -e
set -x
-CLOUDSTACK_RELEASE=4.17.2
+CLOUDSTACK_RELEASE=4.18.0
function configure_apache2() {
# Enable ssl, rewrite and auth
diff --git a/tools/appliance/systemvmtemplate/template.json
b/tools/appliance/systemvmtemplate/template.json
index 4ce996b416d..165caed7525 100644
--- a/tools/appliance/systemvmtemplate/template.json
+++ b/tools/appliance/systemvmtemplate/template.json
@@ -27,8 +27,8 @@
"format": "qcow2",
"headless": true,
"http_directory": "http",
- "iso_checksum":
"sha512:6a6607a05d57b7c62558e9c462fe5c6c04b9cfad2ce160c3e9140aa4617ab73aff7f5f745dfe51bbbe7b33c9b0e219a022ad682d6c327de0e53e40f079abf66a",
- "iso_url":
"https://cdimage.debian.org/debian-cd/11.5.0/amd64/iso-cd/debian-11.5.0-amd64-netinst.iso;,
+ "iso_checksum":
"sha512:224cd98011b9184e49f858a46096c6ff4894adff8945ce89b194541afdfd93b73b4666b0705234bd4dff42c0a914fdb6037dd0982efb5813e8a553d8e92e6f51",
+ "iso_url":
"https://cdimage.debian.org/debian-cd/11.6.0/amd64/iso-cd/debian-11.6.0-amd64-netinst.iso;,
"net_device": "virtio-net",
"output_directory": "../dist",
"qemuargs": [
[GitHub] [cloudstack] rohityadavcloud merged pull request #7013: systemvmtemplate: update Debian ISO URL and checksum
rohityadavcloud merged PR #7013: URL: https://github.com/apache/cloudstack/pull/7013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6840: infra: edge zones
blueorangutan commented on PR #6840: URL: https://github.com/apache/cloudstack/pull/6840#issuecomment-1363633696 @shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6840: infra: edge zones
shwstppr commented on PR #6840: URL: https://github.com/apache/cloudstack/pull/6840#issuecomment-1363633390 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on issue #6987: Project User kubeadmin is not working with project k8s clusters
davidjumani commented on issue #6987: URL: https://github.com/apache/cloudstack/issues/6987#issuecomment-1363587498 @aron-ac Can you please provide the ingress-nginx logs ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework
sonarcloud[bot] commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1363583803 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack=7015) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7015=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7015=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7015=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7015=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7015=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7015=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7015=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7015=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7015=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7015=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7015=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_cloudstack=7015=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7015=new_coverage=list) [0.4% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=7015=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7015=new_duplicated_lines_density=list) [0.5% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=7015=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6844: packaging: support Rocky9 (EL9) as KVM and management server host
sonarcloud[bot] commented on PR #6844: URL: https://github.com/apache/cloudstack/pull/6844#issuecomment-1363567836 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack=6844) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6844=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6844=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=6844=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6844=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6844=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=6844=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6844=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6844=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=6844=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6844=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=6844=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=6844=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6844=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_cloudstack=6844=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework
blueorangutan commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1363548220 @nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework
nvazquez commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1363547858 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!
blueorangutan commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1363534396 Trillian test result (tid-5617) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46160 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6991-t5617-vmware-65u2.zip Smoke tests completed. 104 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_create_template_with_checksum_sha1 | `Error` | 5.14 | test_templates.py test_03_create_template_with_checksum_sha256 | `Error` | 5.13 | test_templates.py test_04_create_template_with_checksum_md5 | `Error` | 5.13 | test_templates.py test_08_upgrade_kubernetes_ha_cluster | `Failure` | 614.46 | test_kubernetes_clusters.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework
blueorangutan commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1363531608 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework
nvazquez commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1363531390 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud closed pull request #6550: Emc networker b
rohityadavcloud closed pull request #6550: Emc networker b URL: https://github.com/apache/cloudstack/pull/6550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6844: packaging: support Rocky9 (EL9) as KVM and management server host
blueorangutan commented on PR #6844: URL: https://github.com/apache/cloudstack/pull/6844#issuecomment-1363527780 @rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6844: packaging: support Rocky9 (EL9) as KVM and management server host
rohityadavcloud commented on PR #6844: URL: https://github.com/apache/cloudstack/pull/6844#issuecomment-1363526747 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud opened a new pull request, #6844: packaging: support Rocky9 (EL9) as KVM and management server host
rohityadavcloud opened a new pull request, #6844: URL: https://github.com/apache/cloudstack/pull/6844 I was exploring to set up CloudStack env on a Rocky 9 or RHEL9 (no-cost subscription) and started this PR. (Also exploring setting up a new docker container image https://hub.docker.com/r/shapeblue/rocky9-cloudstack-builder and backend jenkins job "acs-el9-pkg-builder") Fixes: #6651 TODOs: - [x] Migrate git-pr to python3 on main branch (and fix the el9 jenkins job hack) https://github.com/apache/cloudstack/pull/6961 - [x] EL9 packaging job - [x] EL9 mgmt server support with MySQL - [x] EL9 usage server support - [x] EL9 KVM support (works see notes below) ~~- [ ] Consolidate EL9 pkging with EL8 using boolean conditionals~~ (due to Python site-path change, it may not be possible to do it correctly?) - [ ] Add EL9/Rocky9 template support in Trilian/BO - [ ] Run a round of smoketests with EL9 as both kvm and mgmt server host (I expect/hope this to pass) For EL9 KVM to work with cloudstack-agent, I had to remove the systemd service dependency on libvirtd and follow the guide to switch to modular daemon (perhaps using the old/monolithic way could work, but it didn't in my case): https://libvirt.org/daemons.html#monolithic-vs-modular-daemons After switching completely to modular daemons, I had to ensure that virtqemud was running with --listen, symlink the /etc/libvirt/libvirtd.conf -> /etc/libvirt/virtqemud.conf and start this: ``` systemctl start virtproxyd-tls.socket ``` Note: there are no network-scripts now; so after fixing cloudbr0 etc we need to only restart NetworkManager. Rest all seems to work. Misc notes, perhaps this isn't necessary but I did that as I was in a double nested env already: ``` [root@rocky9-kvm etc]# cat /etc/modules-load.d/br_netfilter.conf br_netfilter [root@rocky9-kvm etc]# cat /etc/modprobe.d/kvm.conf options kvm_intel nested=1 [root@rocky9-kvm etc]# cat /etc/sysctl.conf net.ipv4.ip_forward=1 net.bridge.bridge-nf-call-ip6tables = 0 net.bridge.bridge-nf-call-iptables = 0 net.bridge.bridge-nf-call-arptables = 0 [root@rocky9-kvm etc]# sysctl -p net.ipv4.ip_forward = 1 net.bridge.bridge-nf-call-ip6tables = 0 net.bridge.bridge-nf-call-iptables = 0 net.bridge.bridge-nf-call-arptables = 0 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud closed pull request #6844: packaging: support Rocky9 (EL9) as KVM and management server host
rohityadavcloud closed pull request #6844: packaging: support Rocky9 (EL9) as KVM and management server host URL: https://github.com/apache/cloudstack/pull/6844 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
blueorangutan commented on PR #6942: URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1363526105 @rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
rohityadavcloud commented on PR #6942: URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1363524993 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7013: systemvmtemplate: update Debian ISO URL and checksum
rohityadavcloud commented on PR #7013: URL: https://github.com/apache/cloudstack/pull/7013#issuecomment-1363522080 Errors not caused by this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7018: server: fix broken unit test in configurationManagerImplTest
rohityadavcloud commented on PR #7018: URL: https://github.com/apache/cloudstack/pull/7018#issuecomment-1363518245 Lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6995: Packages consolidation: merge suse15 to el8
blueorangutan commented on PR #6995: URL: https://github.com/apache/cloudstack/pull/6995#issuecomment-1363512897 @rohityadavcloud a Trillian-Jenkins test job (rocky8 mgmt + xcpng82) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!
blueorangutan commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1363511160 @rohityadavcloud a Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6995: Packages consolidation: merge suse15 to el8
rohityadavcloud commented on PR #6995: URL: https://github.com/apache/cloudstack/pull/6995#issuecomment-1363511625 @blueorangutan test rocky8 xcpng82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6995: Packages consolidation: merge suse15 to el8
blueorangutan commented on PR #6995: URL: https://github.com/apache/cloudstack/pull/6995#issuecomment-1363511322 Trillian test result (tid-5614) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 48128 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6995-t5614-kvm-rocky8.zip Smoke tests completed. 96 look OK, 5 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_list_snapshots_with_removed_data_store | `Error` | 9.48 | test_snapshots.py test_02_list_snapshots_with_removed_data_store | `Error` | 9.48 | test_snapshots.py test_01_add_primary_storage_disabled_host | `Error` | 0.72 | test_primary_storage.py test_01_primary_storage_nfs | `Error` | 0.15 | test_primary_storage.py ContextSuite context=TestStorageTags>:setup | `Error` | 0.26 | test_primary_storage.py test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 33.03 | test_kubernetes_clusters.py test_07_deploy_kubernetes_ha_cluster | `Failure` | 184.60 | test_kubernetes_clusters.py test_08_upgrade_kubernetes_ha_cluster | `Failure` | 75.97 | test_kubernetes_clusters.py test_09_delete_kubernetes_ha_cluster | `Failure` | 80.06 | test_kubernetes_clusters.py ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 164.12 | test_kubernetes_clusters.py test_01_migrate_VM_and_root_volume | `Error` | 117.74 | test_vm_life_cycle.py test_02_migrate_VM_with_two_data_disks | `Error` | 49.42 | test_vm_life_cycle.py test_01_secure_vm_migration | `Error` | 198.19 | test_vm_life_cycle.py test_02_unsecure_vm_migration | `Error` | 270.02 | test_vm_life_cycle.py test_03_secured_to_nonsecured_vm_migration | `Error` | 143.84 | test_vm_life_cycle.py test_08_migrate_vm | `Error` | 44.80 | test_vm_life_cycle.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 307.16 | test_hostha_kvm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!
rohityadavcloud commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1363509689 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7013: systemvmtemplate: update Debian ISO URL and checksum
blueorangutan commented on PR #7013: URL: https://github.com/apache/cloudstack/pull/7013#issuecomment-1363508824 Trillian test result (tid-5619) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43846 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7013-t5619-kvm-centos7.zip Smoke tests completed. 105 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 467.93 | test_vpc_redundant.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6995: Packages consolidation: merge suse15 to el8
blueorangutan commented on PR #6995: URL: https://github.com/apache/cloudstack/pull/6995#issuecomment-1363507529 @rohityadavcloud unsupported parameters provided. Supported mgmt server os are: `centos7, centos6, suse15, alma8, ubuntu18, ubuntu22, ubuntu20, rocky8`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-rocky8, kvm-alma8, kvm-ubuntu18, kvm-ubuntu20, kvm-ubuntu22, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, vmware-70u3, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6995: Packages consolidation: merge suse15 to el8
rohityadavcloud commented on PR #6995: URL: https://github.com/apache/cloudstack/pull/6995#issuecomment-1363505891 @blueorangutan test rocky8 xcpng-82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6995: Packages consolidation: merge suse15 to el8
blueorangutan commented on PR #6995: URL: https://github.com/apache/cloudstack/pull/6995#issuecomment-1363503995 @rohityadavcloud a Trillian-Jenkins test job (rocky8 mgmt + vmware-67u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6995: Packages consolidation: merge suse15 to el8
rohityadavcloud commented on PR #6995: URL: https://github.com/apache/cloudstack/pull/6995#issuecomment-1363501999 @blueorangutan test rocky8 vmware-67u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7013: systemvmtemplate: update Debian ISO URL and checksum
blueorangutan commented on PR #7013: URL: https://github.com/apache/cloudstack/pull/7013#issuecomment-1363495541 Trillian test result (tid-5620) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43609 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7013-t5620-vmware-65u2.zip Smoke tests completed. 105 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_create_template_with_checksum_sha1 | `Error` | 5.15 | test_templates.py test_03_create_template_with_checksum_sha256 | `Error` | 5.13 | test_templates.py test_04_create_template_with_checksum_md5 | `Error` | 5.17 | test_templates.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework
sonarcloud[bot] commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1363490173 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack=7015) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7015=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7015=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7015=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7015=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7015=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7015=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7015=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7015=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7015=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7015=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7015=false=CODE_SMELL) [9 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7015=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7015=new_coverage=list) [0.4% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack=7015=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7015=new_duplicated_lines_density=list) [0.5% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=7015=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!
blueorangutan commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1363478356 Trillian test result (tid-5616) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42148 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6991-t5616-kvm-centos7.zip Smoke tests completed. 105 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_08_upgrade_kubernetes_ha_cluster | `Failure` | 550.13 | test_kubernetes_clusters.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7013: systemvmtemplate: update Debian ISO URL and checksum
blueorangutan commented on PR #7013: URL: https://github.com/apache/cloudstack/pull/7013#issuecomment-1363476191 Trillian test result (tid-5618) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41128 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7013-t5618-xenserver-71.zip Smoke tests completed. 103 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_08_upgrade_kubernetes_ha_cluster | `Failure` | 597.24 | test_kubernetes_clusters.py test_list_vms_metrics_admin | `Error` | 0.11 | test_metrics_api.py test_01_deploy_vm_on_specific_host | `Error` | 1.16 | test_vm_deployment_planner.py test_02_deploy_vm_on_specific_cluster | `Error` | 1.13 | test_vm_deployment_planner.py test_03_deploy_vm_on_specific_pod | `Error` | 1.16 | test_vm_deployment_planner.py test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 1.16 | test_vm_deployment_planner.py test_05_deploy_vm_on_cluster_override_pod | `Error` | 1.17 | test_vm_deployment_planner.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!
blueorangutan commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1363455377 Trillian test result (tid-5615) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39534 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6991-t5615-xenserver-71.zip Smoke tests completed. 106 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework
blueorangutan commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1363443908 @nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework
nvazquez commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1363443703 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #7015: Secure KVM VNC Console Access Using the CA Framework
nvazquez commented on PR #7015: URL: https://github.com/apache/cloudstack/pull/7015#issuecomment-1363443411 @DaanHoogland @weizhouapache @slavkap many thanks for your reviews, have addressed them and also the sonarcloud reports. Can you please re-check? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6550: Emc networker b
blueorangutan commented on PR #6550: URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1363437445 Trillian test result (tid-5613) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43891 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6550-t5613-kvm-centos7.zip Smoke tests completed. 105 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_08_upgrade_kubernetes_ha_cluster | `Failure` | 590.78 | test_kubernetes_clusters.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a diff in pull request #7015: Secure KVM VNC Console Access Using the CA Framework
nvazquez commented on code in PR #7015:
URL: https://github.com/apache/cloudstack/pull/7015#discussion_r1055919649
##
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/vnc/NoVncClient.java:
##
@@ -239,16 +273,349 @@ public byte[] encodePassword(byte[] challenge, String
password) throws Exception
return response;
}
+/**
+ * Decide the RFB protocol version with the VNC server
+ * Reference:
https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#711protocolversion
+ */
+protected String handshakeProtocolVersion(RemoteEndpoint clientRemote)
throws IOException {
+// Read protocol version
+byte[] buf = new byte[12];
+tunnelInputStream.readFully(buf);
+String rfbProtocol = new String(buf);
+
+// Server should use RFB protocol 3.x
+if (!rfbProtocol.contains(RfbConstants.RFB_PROTOCOL_VERSION_MAJOR)) {
+s_logger.error("Cannot handshake with VNC server. Unsupported
protocol version: \"" + rfbProtocol + "\".");
+throw new RuntimeException(
+"Cannot handshake with VNC server. Unsupported protocol
version: \"" + rfbProtocol + "\".");
+}
+tunnelOutputStream.write(buf);
+return RfbConstants.RFB_PROTOCOL_VERSION + "\n";
+}
+
+/**
+ * Agree on the security type with the VNC server
+ * Reference:
https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#712security
+ * @return list of the security types to be processed
+ */
+protected List handshakeSecurityTypes(RemoteEndpoint
clientRemote, String vmPassword,
+ String host, int port)
throws IOException {
+int securityType = selectFromTheServerOfferedSecurityTypes();
+
+// Inform the server about our decision
+this.tunnelOutputStream.writeByte(securityType);
+
+byte[] numberTypesToClient = new byte[] { 1, (byte) securityType };
+clientRemote.sendBytes(ByteBuffer.wrap(numberTypesToClient, 0, 2));
+
+if (securityType == RfbConstants.V_ENCRYPT) {
+securityType = getVEncryptSecuritySubtype();
+}
+return VncSecurity.getSecurityStack(securityType, vmPassword, host,
port);
+}
+
+/**
+ * Obtain the VEncrypt subtype from the VNC server
+ *
+ * Reference:
https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#724vencrypt
+ */
+protected int getVEncryptSecuritySubtype() throws IOException {
Review Comment:
Done, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a diff in pull request #7015: Secure KVM VNC Console Access Using the CA Framework
nvazquez commented on code in PR #7015:
URL: https://github.com/apache/cloudstack/pull/7015#discussion_r1055918022
##
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyNoVncClient.java:
##
@@ -137,18 +145,80 @@ public void run() {
/**
* Authenticate to VNC server when not using websockets
+ *
+ * Since we are supporting the 3.8 version of the RFB protocol, there are
changes on the stages:
+ * 1. Handshake:
+ *1.a. Protocol version
+ *1.b. Security types
+ * 2. Security types
+ * 3. Initialisation
+ *
+ * Reference:
https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#7protocol-messages
* @throws IOException
*/
private void authenticateToVNCServer() throws IOException {
-if (!client.isVncOverWebSocketConnection()) {
+if (client.isVncOverWebSocketConnection()) {
+return;
+}
+
+if (client.isVncOverTunnel()) {
String ver = client.handshake();
session.getRemote().sendBytes(ByteBuffer.wrap(ver.getBytes(), 0,
ver.length()));
-byte[] b = client.authenticate(getClientHostPassword());
+byte[] b = client.authenticateTunnel(getClientHostPassword());
session.getRemote().sendBytes(ByteBuffer.wrap(b, 0, 4));
+} else {
+ByteBuffer verStr = client.handshakeProtocolVersion();
+sendMessageToVNCClient(verStr.array(), 12);
+
+int secType = client.handshakeSecurityType();
+byte[] numberTypesToClient = new byte[] { 1, (byte) secType };
+sendMessageToVNCClient(numberTypesToClient, 2);
+
+client.processHandshakeSecurityType(secType,
getClientHostPassword(),
+getClientHostAddress(), getClientHostPort());
+
+byte[] securityResultToClient = new byte[] { 0, 0, 0, 0 };
+sendMessageToVNCClient(securityResultToClient, 4);
+client.setWaitForNoVnc(true);
+
+while (client.isWaitForNoVnc()) {
+s_logger.debug("Waiting");
+}
Review Comment:
Done, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6995: Packages consolidation: merge suse15 to el8
blueorangutan commented on PR #6995: URL: https://github.com/apache/cloudstack/pull/6995#issuecomment-1363411620 Trillian test result (tid-5612) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 51035 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6995-t5612-kvm-rocky8.zip Smoke tests completed. 98 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_list_snapshots_with_removed_data_store | `Error` | 9.49 | test_snapshots.py test_02_list_snapshots_with_removed_data_store | `Error` | 9.49 | test_snapshots.py test_01_deploy_vm_from_direct_download_template_nfs_storage | `Error` | 1.22 | test_direct_download.py ContextSuite context=TestDirectDownloadTemplates>:teardown | `Error` | 1.07 | test_direct_download.py test_01_add_primary_storage_disabled_host | `Error` | 0.67 | test_primary_storage.py test_01_primary_storage_nfs | `Error` | 0.14 | test_primary_storage.py ContextSuite context=TestStorageTags>:setup | `Error` | 0.26 | test_primary_storage.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] wido commented on pull request #6909: KVM support of iothreads
wido commented on PR #6909: URL: https://github.com/apache/cloudstack/pull/6909#issuecomment-1363354604 Am I right that you can also set this on a per VM base using the VmDetails (Settings in the UI) rather then per storage pool? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] fermosan commented on pull request #6550: Emc networker b
fermosan commented on PR #6550: URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-136276 > > @rohityadavcloud @fermosan do we reset the package-lock.json on this? I think we can merge as soon as we have. > > re-ping, before this gets rained down by BO messages, @rohityadavcloud @fermosan @DaanHoogland @rohityadavcloud I thnik we can reset. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7018: server: fix broken unit test in configurationManagerImplTest
sonarcloud[bot] commented on PR #7018: URL: https://github.com/apache/cloudstack/pull/7018#issuecomment-1363322295 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack=7018) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7018=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7018=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7018=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7018=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7018=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7018=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7018=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7018=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7018=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7018=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack=7018=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7018=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7018=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_cloudstack=7018=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack=7018=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6808: Allow privateips on console proxy
weizhouapache commented on PR #6808: URL: https://github.com/apache/cloudstack/pull/6808#issuecomment-1363311376 no worries @GaOrtiga pr has been mergd. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch main updated: server: fix broken unit test in configurationManagerImplTest (#7018)
This is an automated email from the ASF dual-hosted git repository.
weizhou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/main by this push:
new 4ade096aeb2 server: fix broken unit test in
configurationManagerImplTest (#7018)
4ade096aeb2 is described below
commit 4ade096aeb255ca5c0cf3bf7f3e7c304d860dfda
Author: GaOrtiga <49285692+gaort...@users.noreply.github.com>
AuthorDate: Thu Dec 22 17:21:38 2022 -0300
server: fix broken unit test in configurationManagerImplTest (#7018)
Co-authored-by: Gabriel Ortiga Fernandes
---
.../test/java/com/cloud/configuration/ConfigurationManagerImplTest.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/server/src/test/java/com/cloud/configuration/ConfigurationManagerImplTest.java
b/server/src/test/java/com/cloud/configuration/ConfigurationManagerImplTest.java
index 324ce7f9cbc..e8bb8fae0b9 100644
---
a/server/src/test/java/com/cloud/configuration/ConfigurationManagerImplTest.java
+++
b/server/src/test/java/com/cloud/configuration/ConfigurationManagerImplTest.java
@@ -135,7 +135,7 @@ public class ConfigurationManagerImplTest {
PowerMockito.mockStatic(NetUtils.class);
PowerMockito.when(NetUtils.verifyInstanceName(Mockito.anyString())).thenReturn(false);
String testVariable =
configurationManagerImplSpy.validateRangeInstanceName("This string should not
be valid.");
-Assert.assertEquals("a valid instance name (instance names cannot
contain hyphen, space or plus sign)", testVariable);
+Assert.assertEquals("a valid instance name (instance names cannot
contain hyphens, spaces or plus signs)", testVariable);
}
@Test
[GitHub] [cloudstack] weizhouapache merged pull request #7018: server: fix broken unit test in configurationManagerImplTest
weizhouapache merged PR #7018: URL: https://github.com/apache/cloudstack/pull/7018 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7018: fix broken test
codecov[bot] commented on PR #7018: URL: https://github.com/apache/cloudstack/pull/7018#issuecomment-1363308867 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7018?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#7018](https://codecov.io/gh/apache/cloudstack/pull/7018?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (df497b9) into [main](https://codecov.io/gh/apache/cloudstack/commit/9f8533eaf028fe56affdc3b3d9b09abb10836f3b?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (9f8533e) will **increase** coverage by `0.01%`. > The diff coverage is `74.28%`. ```diff @@ Coverage Diff @@ ## main#7018 +/- ## + Coverage 11.30% 11.31% +0.01% - Complexity 7311 7332 +21 Files 2494 2494 Lines246783 246787 +4 Branches 3854238533 -9 + Hits 2789127929 +38 + Misses 215299 215260 -39 - Partials 3593 3598 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/7018?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ervisor/kvm/resource/LibvirtComputingResource.java](https://codecov.io/gh/apache/cloudstack/pull/7018/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydENvbXB1dGluZ1Jlc291cmNlLmphdmE=) | `18.34% <16.66%> (-0.25%)` | :arrow_down: | | [.../cloud/configuration/ConfigurationManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7018/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2NvbmZpZ3VyYXRpb24vQ29uZmlndXJhdGlvbk1hbmFnZXJJbXBsLmphdmE=) | `12.49% <79.03%> (+1.24%)` | :arrow_up: | | [.../src/main/java/com/cloud/configuration/Config.java](https://codecov.io/gh/apache/cloudstack/pull/7018/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2NvbmZpZ3VyYXRpb24vQ29uZmlnLmphdmE=) | `89.73% <100.00%> (+0.52%)` | :arrow_up: | | [...dstack/network/contrail/model/ModelObjectBase.java](https://codecov.io/gh/apache/cloudstack/pull/7018/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdEJhc2UuamF2YQ==) | `21.15% <0.00%> (-7.70%)` | :arrow_down: | | [...om/cloud/hypervisor/kvm/resource/LibvirtVMDef.java](https://codecov.io/gh/apache/cloudstack/pull/7018/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydFZNRGVmLmphdmE=) | `67.31% <0.00%> (-0.34%)` | :arrow_down: | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GaOrtiga commented on pull request #6808: Allow privateips on console proxy
GaOrtiga commented on PR #6808: URL: https://github.com/apache/cloudstack/pull/6808#issuecomment-1363267452 I created the PR https://github.com/apache/cloudstack/pull/7018 Sorry for the mistake. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GaOrtiga opened a new pull request, #7018: fix broken test
GaOrtiga opened a new pull request, #7018:
URL: https://github.com/apache/cloudstack/pull/7018
### Description
This PR fixes a broken test on ´configurationManagerImplTest´.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [X] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6808: Allow privateips on console proxy
weizhouapache commented on PR #6808: URL: https://github.com/apache/cloudstack/pull/6808#issuecomment-1363254934 > @DaanHoogland I applied one of the suggestions but forgot to update the tests with the current text. Now this test is broken, so, should we revert it or create a fix? @GaOrtiga I just faced the same issue. please create a pull request to fix the test asap -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] GaOrtiga commented on pull request #6808: Allow privateips on console proxy
GaOrtiga commented on PR #6808: URL: https://github.com/apache/cloudstack/pull/6808#issuecomment-1363252780 @DaanHoogland I applied one of the suggestions but forgot to update the tests with the current text. Now this test is broken, so, should we revert it or create a fix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #6794: Cannot start cloudstack-agent after upgrade from 4.16.1 to 4.17.1
weizhouapache commented on issue #6794: URL: https://github.com/apache/cloudstack/issues/6794#issuecomment-1363209875 @levindecaro Strange. We never see this issue in any testing environments with different OSes. Can you share the list of files in /usr/share/cloudstack-agent/lib ? which os and version, jdk version do you use ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] levindecaro commented on issue #6794: Cannot start cloudstack-agent after upgrade from 4.16.1 to 4.17.1
levindecaro commented on issue #6794: URL: https://github.com/apache/cloudstack/issues/6794#issuecomment-1363147551 @DaanHoogland Just tried to build 4.17.2 with this #6797, but it still fail after agent upgrade ``` Dec 22 22:40:08 compute-20.example.com java[1991061]: com.cloud.utils.exception.CloudRuntimeException: java.lang.InstantiationException: com.cloud.hypervisor.kvm.storage.ScaleIOStorageAdaptor Dec 22 22:40:08 compute-20.example.com java[1991061]: at com.cloud.hypervisor.kvm.storage.KVMStoragePoolManager.(KVMStoragePoolManager.java:116) Dec 22 22:40:08 compute-20.example.com java[1991061]: at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.configure(LibvirtComputingResource.java:1056) Dec 22 22:40:08 compute-20.example.com java[1991061]: at com.cloud.agent.Agent.(Agent.java:189) Dec 22 22:40:08 compute-20.example.com java[1991061]: at com.cloud.agent.AgentShell.launchNewAgent(AgentShell.java:451) Dec 22 22:40:08 compute-20.example.com java[1991061]: at com.cloud.agent.AgentShell.launchAgentFromClassInfo(AgentShell.java:420) Dec 22 22:40:08 compute-20.example.com java[1991061]: at com.cloud.agent.AgentShell.launchAgent(AgentShell.java:404) Dec 22 22:40:08 compute-20.example.com java[1991061]: at com.cloud.agent.AgentShell.start(AgentShell.java:510) Dec 22 22:40:08 compute-20.example.com java[1991061]: at com.cloud.agent.AgentShell.main(AgentShell.java:545) Dec 22 22:40:08 compute-20.example.com java[1991061]: Unable to start agent: java.lang.InstantiationException: com.cloud.hypervisor.kvm.storage.ScaleIOStorageAdaptor Dec 22 22:40:08 compute-20.example.com libvirtd[1965359]: 2022-12-22 14:40:08.496+: 1965359: error : virNetSocketReadWire:1806 : End of file while reading data: Input/output error ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a diff in pull request #7015: Secure KVM VNC Console Access Using the CA Framework
nvazquez commented on code in PR #7015:
URL: https://github.com/apache/cloudstack/pull/7015#discussion_r1055686997
##
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyNoVncClient.java:
##
@@ -137,18 +145,80 @@ public void run() {
/**
* Authenticate to VNC server when not using websockets
+ *
+ * Since we are supporting the 3.8 version of the RFB protocol, there are
changes on the stages:
+ * 1. Handshake:
+ *1.a. Protocol version
+ *1.b. Security types
+ * 2. Security types
+ * 3. Initialisation
+ *
+ * Reference:
https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#7protocol-messages
* @throws IOException
*/
private void authenticateToVNCServer() throws IOException {
-if (!client.isVncOverWebSocketConnection()) {
+if (client.isVncOverWebSocketConnection()) {
+return;
+}
+
+if (client.isVncOverTunnel()) {
String ver = client.handshake();
session.getRemote().sendBytes(ByteBuffer.wrap(ver.getBytes(), 0,
ver.length()));
-byte[] b = client.authenticate(getClientHostPassword());
+byte[] b = client.authenticateTunnel(getClientHostPassword());
session.getRemote().sendBytes(ByteBuffer.wrap(b, 0, 4));
+} else {
+ByteBuffer verStr = client.handshakeProtocolVersion();
+sendMessageToVNCClient(verStr.array(), 12);
+
+int secType = client.handshakeSecurityType();
+byte[] numberTypesToClient = new byte[] { 1, (byte) secType };
+sendMessageToVNCClient(numberTypesToClient, 2);
+
+client.processHandshakeSecurityType(secType,
getClientHostPassword(),
+getClientHostAddress(), getClientHostPort());
+
+byte[] securityResultToClient = new byte[] { 0, 0, 0, 0 };
+sendMessageToVNCClient(securityResultToClient, 4);
+client.setWaitForNoVnc(true);
+
+while (client.isWaitForNoVnc()) {
+s_logger.debug("Waiting");
+}
+
+String serverName = String.format("%s %s",
clientParam.getClientDisplayName(),
+client.isTLSConnectionEstablished() ? "(TLS backend)" :
"");
+byte[] bytesServerInit =
rewriteServerNameInServerInit(client.readServerInit(), serverName);
+s_logger.info(String.format("Server init message is %s (%s)",
Arrays.toString(bytesServerInit), new String(bytesServerInit)));
+session.getRemote().sendBytes(ByteBuffer.wrap(bytesServerInit));
+client.setWaitForNoVnc(true);
+while (client.isWaitForNoVnc()) {
+s_logger.debug("Waiting");
+}
+s_logger.info("Authenticated successfully");
Review Comment:
Sure, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.17'
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit fab4fc2a140c15e51d16b322bbc2552f56642a36 Merge: 91645349b06 08881d69c78 Author: Rohit Yadav AuthorDate: Thu Dec 22 22:55:15 2022 +0530 Merge remote-tracking branch 'origin/4.17' .../hypervisor/kvm/resource/LibvirtComputingResource.java | 13 +++-- test/integration/smoke/test_templates.py| 6 +++--- 2 files changed, 10 insertions(+), 9 deletions(-)
[cloudstack] branch main updated (91645349b06 -> fab4fc2a140)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 91645349b06 Allow privateips on console proxy (#6808) add fb22c5c3c95 kvm: correctly set vm cpu topology (#6870) add 08881d69c78 checksums for new macchinina ova template (#7001) new fab4fc2a140 Merge remote-tracking branch 'origin/4.17' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../hypervisor/kvm/resource/LibvirtComputingResource.java | 13 +++-- test/integration/smoke/test_templates.py| 6 +++--- 2 files changed, 10 insertions(+), 9 deletions(-)
[GitHub] [cloudstack] blueorangutan commented on pull request #6844: packaging: support Rocky9 (EL9) as KVM and management server host
blueorangutan commented on PR #6844: URL: https://github.com/apache/cloudstack/pull/6844#issuecomment-1363118115 @rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6844: packaging: support Rocky9 (EL9) as KVM and management server host
rohityadavcloud commented on PR #6844: URL: https://github.com/apache/cloudstack/pull/6844#issuecomment-1363117319 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6844: packaging: support Rocky9 (EL9) as KVM and management server host
blueorangutan commented on PR #6844: URL: https://github.com/apache/cloudstack/pull/6844#issuecomment-1363104245 @rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6844: packaging: support Rocky9 (EL9) as KVM and management server host
rohityadavcloud commented on PR #6844: URL: https://github.com/apache/cloudstack/pull/6844#issuecomment-1363103088 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a diff in pull request #7015: Secure KVM VNC Console Access Using the CA Framework
nvazquez commented on code in PR #7015:
URL: https://github.com/apache/cloudstack/pull/7015#discussion_r1055658022
##
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/vnc/NoVncClient.java:
##
@@ -239,16 +273,349 @@ public byte[] encodePassword(byte[] challenge, String
password) throws Exception
return response;
}
+/**
+ * Decide the RFB protocol version with the VNC server
+ * Reference:
https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#711protocolversion
+ */
+protected String handshakeProtocolVersion(RemoteEndpoint clientRemote)
throws IOException {
+// Read protocol version
+byte[] buf = new byte[12];
+tunnelInputStream.readFully(buf);
+String rfbProtocol = new String(buf);
+
+// Server should use RFB protocol 3.x
+if (!rfbProtocol.contains(RfbConstants.RFB_PROTOCOL_VERSION_MAJOR)) {
+s_logger.error("Cannot handshake with VNC server. Unsupported
protocol version: \"" + rfbProtocol + "\".");
+throw new RuntimeException(
+"Cannot handshake with VNC server. Unsupported protocol
version: \"" + rfbProtocol + "\".");
+}
+tunnelOutputStream.write(buf);
+return RfbConstants.RFB_PROTOCOL_VERSION + "\n";
+}
+
+/**
+ * Agree on the security type with the VNC server
+ * Reference:
https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#712security
+ * @return list of the security types to be processed
+ */
+protected List handshakeSecurityTypes(RemoteEndpoint
clientRemote, String vmPassword,
+ String host, int port)
throws IOException {
+int securityType = selectFromTheServerOfferedSecurityTypes();
+
+// Inform the server about our decision
+this.tunnelOutputStream.writeByte(securityType);
+
+byte[] numberTypesToClient = new byte[] { 1, (byte) securityType };
+clientRemote.sendBytes(ByteBuffer.wrap(numberTypesToClient, 0, 2));
+
+if (securityType == RfbConstants.V_ENCRYPT) {
+securityType = getVEncryptSecuritySubtype();
+}
+return VncSecurity.getSecurityStack(securityType, vmPassword, host,
port);
+}
+
+/**
+ * Obtain the VEncrypt subtype from the VNC server
+ *
+ * Reference:
https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#724vencrypt
+ */
+protected int getVEncryptSecuritySubtype() throws IOException {
+int majorVEncryptVersion = socketConnection.readUnsignedInteger(8);
+int minorVEncryptVersion = socketConnection.readUnsignedInteger(8);
+int vEncryptVersion = (majorVEncryptVersion << 8) |
minorVEncryptVersion;
+s_logger.debug("VEncrypt version: " + vEncryptVersion);
+socketConnection.writeUnsignedInteger(8, majorVEncryptVersion);
+if (vEncryptVersion >= 0x0002) {
+socketConnection.writeUnsignedInteger(8, 2);
+socketConnection.flushWriteBuffer();
+} else {
+socketConnection.writeUnsignedInteger(8, 0);
+socketConnection.flushWriteBuffer();
+throw new CloudRuntimeException("Server reported an unsupported
VeNCrypt version");
+}
+int ack = socketConnection.readUnsignedInteger(8);
+if (ack != 0) {
+throw new IOException("The VNC server did not agree on the
VEncrypt version");
+}
+
+int numberOfSubtypes = socketConnection.readUnsignedInteger(8);
+if (numberOfSubtypes <= 0) {
+throw new CloudRuntimeException("The server reported no VeNCrypt
sub-types");
+}
+int selectedSubtype = 0;
+for (int i = 0; i < numberOfSubtypes; i++) {
+while (!socketConnection.checkIfBytesAreAvailableForReading(4)) {
+s_logger.trace("Waiting for vEncrypt subtype");
+}
+int subtype = socketConnection.readUnsignedInteger(32);
+if (subtype == RfbConstants.V_ENCRYPT_X509_VNC) {
+selectedSubtype = subtype;
+break;
+}
+}
+
+s_logger.info("Selected VEncrypt subtype " + selectedSubtype);
+socketConnection.writeUnsignedInteger(32, selectedSubtype);
+socketConnection.flushWriteBuffer();
+
+return selectedSubtype;
+}
+
+private int selectFromTheServerOfferedSecurityTypes() throws IOException {
+int numberOfSecurityTypes = tunnelInputStream.readByte();
+if (numberOfSecurityTypes == 0) {
+int reasonLength = tunnelInputStream.readInt();
+byte[] reasonBuffer = new byte[reasonLength];
+tunnelInputStream.readFully(reasonBuffer);
+String reason = new String(reasonBuffer);
+String errMsg = "No security type provided by the VNC server,
reason: " + reason;
+s_logger.error(errMsg);
+throw
[GitHub] [cloudstack] nvazquez commented on a diff in pull request #7015: Secure KVM VNC Console Access Using the CA Framework
nvazquez commented on code in PR #7015:
URL: https://github.com/apache/cloudstack/pull/7015#discussion_r1055639044
##
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/vnc/NoVncClient.java:
##
@@ -239,16 +273,349 @@ public byte[] encodePassword(byte[] challenge, String
password) throws Exception
return response;
}
+/**
+ * Decide the RFB protocol version with the VNC server
+ * Reference:
https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#711protocolversion
+ */
+protected String handshakeProtocolVersion(RemoteEndpoint clientRemote)
throws IOException {
+// Read protocol version
+byte[] buf = new byte[12];
+tunnelInputStream.readFully(buf);
+String rfbProtocol = new String(buf);
+
+// Server should use RFB protocol 3.x
+if (!rfbProtocol.contains(RfbConstants.RFB_PROTOCOL_VERSION_MAJOR)) {
+s_logger.error("Cannot handshake with VNC server. Unsupported
protocol version: \"" + rfbProtocol + "\".");
+throw new RuntimeException(
+"Cannot handshake with VNC server. Unsupported protocol
version: \"" + rfbProtocol + "\".");
+}
+tunnelOutputStream.write(buf);
+return RfbConstants.RFB_PROTOCOL_VERSION + "\n";
+}
+
+/**
+ * Agree on the security type with the VNC server
+ * Reference:
https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#712security
+ * @return list of the security types to be processed
+ */
+protected List handshakeSecurityTypes(RemoteEndpoint
clientRemote, String vmPassword,
+ String host, int port)
throws IOException {
+int securityType = selectFromTheServerOfferedSecurityTypes();
+
+// Inform the server about our decision
+this.tunnelOutputStream.writeByte(securityType);
+
+byte[] numberTypesToClient = new byte[] { 1, (byte) securityType };
+clientRemote.sendBytes(ByteBuffer.wrap(numberTypesToClient, 0, 2));
+
+if (securityType == RfbConstants.V_ENCRYPT) {
+securityType = getVEncryptSecuritySubtype();
+}
+return VncSecurity.getSecurityStack(securityType, vmPassword, host,
port);
+}
+
+/**
+ * Obtain the VEncrypt subtype from the VNC server
+ *
+ * Reference:
https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#724vencrypt
+ */
+protected int getVEncryptSecuritySubtype() throws IOException {
+int majorVEncryptVersion = socketConnection.readUnsignedInteger(8);
+int minorVEncryptVersion = socketConnection.readUnsignedInteger(8);
+int vEncryptVersion = (majorVEncryptVersion << 8) |
minorVEncryptVersion;
+s_logger.debug("VEncrypt version: " + vEncryptVersion);
+socketConnection.writeUnsignedInteger(8, majorVEncryptVersion);
+if (vEncryptVersion >= 0x0002) {
+socketConnection.writeUnsignedInteger(8, 2);
+socketConnection.flushWriteBuffer();
+} else {
+socketConnection.writeUnsignedInteger(8, 0);
+socketConnection.flushWriteBuffer();
+throw new CloudRuntimeException("Server reported an unsupported
VeNCrypt version");
+}
+int ack = socketConnection.readUnsignedInteger(8);
+if (ack != 0) {
+throw new IOException("The VNC server did not agree on the
VEncrypt version");
+}
+
+int numberOfSubtypes = socketConnection.readUnsignedInteger(8);
+if (numberOfSubtypes <= 0) {
+throw new CloudRuntimeException("The server reported no VeNCrypt
sub-types");
+}
+int selectedSubtype = 0;
+for (int i = 0; i < numberOfSubtypes; i++) {
+while (!socketConnection.checkIfBytesAreAvailableForReading(4)) {
+s_logger.trace("Waiting for vEncrypt subtype");
Review Comment:
I've refactored this a bit, maybe the trace logs could be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6844: [WIP] packaging: support Rocky9 (EL9) as KVM and management server host
rohityadavcloud commented on PR #6844: URL: https://github.com/apache/cloudstack/pull/6844#issuecomment-1363021248 Verified the following cc @shwstppr - install epel-release and bridge-utils, net-tools - fix selinux issue (setenforce 0) - use nmcli or something else to configure cloudbr0 (network service is not longer available) - Check/put: in/etc/libvirt/qemu.conf `vnc_listen=0.0.0.0` - Create file /etc/sysconfig/libvirtd with content: `LIBVIRTD_ARGS="--listen"` - Put in /etc/libvirt/libvirtd.conf: ``` listen_tls = 0 listen_tcp = 1 tcp_port = "16509" auth_tcp = "none" mdns_adv = 0 ``` - Mark the libvirtd sockets: ``` systemctl mask libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket libvirtd-tls.socket libvirtd-tcp.socket systemctl restart libvirtd ``` That's enough to then run libvirtd and add KVM host. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
blueorangutan commented on PR #6942: URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1363015136 @rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
rohityadavcloud commented on PR #6942: URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1363014553 This is extremely rare case, reverted other changes except the synchornised fix. @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #6942: ssvm: synchorise when adding iptables and routing rules
rohityadavcloud commented on code in PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#discussion_r1055615955
##
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java:
##
@@ -2242,7 +2242,7 @@ public String allowOutgoingOnPrivate(String destCidr) {
addRouteToInternalIpOrCidr(_localgw, _eth1ip, _eth1mask, destCidr);
-return null;
+return msg;
Review Comment:
```suggestion
return null;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #6942: ssvm: synchorise when adding iptables and routing rules
rohityadavcloud commented on code in PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#discussion_r1055615751
##
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java:
##
@@ -2238,11 +2238,18 @@ public String allowOutgoingOnPrivate(String destCidr) {
if (result != null) {
s_logger.warn("Error in allowing outgoing to " + destCidr + ",
err=" + result);
return "Error in allowing outgoing to " + destCidr + ", err=" +
result;
+if (result != null) {
+msg = "Error in allowing outgoing to " + destCidr + ", err=" +
result;
+s_logger.warn(msg);
+} else {
+msg = null;
+break;
+}
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #6942: ssvm: synchorise when adding iptables and routing rules
rohityadavcloud commented on code in PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#discussion_r1055615111
##
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java:
##
@@ -2234,15 +2234,21 @@ public String allowOutgoingOnPrivate(String destCidr) {
command.add("-c");
command.add("iptables -I OUTPUT -o " + intf + " -d " + destCidr + " -p
tcp -m state --state NEW -m tcp -j ACCEPT");
-String result = command.execute();
-if (result != null) {
-s_logger.warn("Error in allowing outgoing to " + destCidr + ",
err=" + result);
-return "Error in allowing outgoing to " + destCidr + ", err=" +
result;
+String msg = null;
+for (int retry = 3; retry > 0; retry--) {
+String result = command.execute();
Review Comment:
```suggestion
String result = command.execute();
if (result != null) {
s_logger.warn("Error in allowing outgoing to " + destCidr + ",
err=" + result);
return "Error in allowing outgoing to " + destCidr + ", err=" +
result;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6995: Packages consolidation: merge suse15 to el8
rohityadavcloud commented on PR #6995: URL: https://github.com/apache/cloudstack/pull/6995#issuecomment-1363010753 I've manually tested installation of pkg on EL8, didn't get any errors in pkg installation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch main updated: Allow privateips on console proxy (#6808)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/main by this push:
new 91645349b06 Allow privateips on console proxy (#6808)
91645349b06 is described below
commit 91645349b069ce811bf0a609f2230ee0d2e1da3e
Author: GaOrtiga <49285692+gaort...@users.noreply.github.com>
AuthorDate: Thu Dec 22 12:43:45 2022 -0300
Allow privateips on console proxy (#6808)
Co-authored-by: Rodrigo D. Lopez
<19981369+rodrigodlo...@users.noreply.github.com>
Co-authored-by: Stephan Krug
Co-authored-by: Gabriel Ortiga Fernandes
---
.../main/java/com/cloud/configuration/Config.java | 10 +-
.../configuration/ConfigurationManagerImpl.java| 199 +
.../java/com/cloud/configuration/ConfigTest.java | 42 +
.../ConfigurationManagerImplTest.java | 194
4 files changed, 365 insertions(+), 80 deletions(-)
diff --git a/server/src/main/java/com/cloud/configuration/Config.java
b/server/src/main/java/com/cloud/configuration/Config.java
index 1dafb2855a9..c07115d87c2 100644
--- a/server/src/main/java/com/cloud/configuration/Config.java
+++ b/server/src/main/java/com/cloud/configuration/Config.java
@@ -244,7 +244,7 @@ public enum Config {
String.class,
"network.loadbalancer.haproxy.stats.auth",
"admin1:AdMiN123",
-"Load Balancer(haproxy) authetication string in the format
username:password",
+"Load Balancer(haproxy) authentication string in the format
username:password",
null),
NetworkLBHaproxyStatsPort(
"Network",
@@ -426,7 +426,7 @@ public enum Config {
"Console proxy command port that is used to communicate with
management server",
null),
ConsoleProxyRestart("Console Proxy", AgentManager.class, Boolean.class,
"consoleproxy.restart", "true", "Console proxy restart flag, defaulted to
true", null),
-ConsoleProxyUrlDomain("Console Proxy", AgentManager.class, String.class,
"consoleproxy.url.domain", "", "Console proxy url domain", "domainName"),
+ConsoleProxyUrlDomain("Console Proxy", AgentManager.class, String.class,
"consoleproxy.url.domain", "", "Console proxy url domain", "domainName",
"privateip"),
ConsoleProxySessionMax(
"Console Proxy",
AgentManager.class,
@@ -1783,7 +1783,7 @@ public enum Config {
private final String _name;
private final String _defaultValue;
private final String _description;
-private final String _range;
+private final String[] _range;
private final String _scope; // Parameter can be at different levels
(Zone/cluster/pool/account), by default every parameter is at global
private static final HashMap> s_scopeLevelConfigsMap
= new HashMap>();
@@ -1833,7 +1833,7 @@ public enum Config {
}
}
-private Config(String category, Class componentClass, Class type,
String name, String defaultValue, String description, String range) {
+private Config(String category, Class componentClass, Class type,
String name, String defaultValue, String description, String... range) {
_category = category;
_componentClass = componentClass;
_type = type;
@@ -1896,7 +1896,7 @@ public enum Config {
}
}
-public String getRange() {
+public String[] getRange() {
return _range;
}
diff --git
a/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
b/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
old mode 100755
new mode 100644
index b7ed11a61ab..7fa764d2f25
--- a/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
+++ b/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
@@ -1103,8 +1103,8 @@ public class ConfigurationManagerImpl extends ManagerBase
implements Configurati
}
}
Class type = null;
-final Config c = Config.getConfig(name);
-if (c == null) {
+final Config configuration = Config.getConfig(name);
+if (configuration == null) {
s_logger.warn("Did not find configuration " + name + " in
Config.java. Perhaps moved to ConfigDepot");
final ConfigKey configKey = _configDepot.get(name);
if(configKey == null) {
@@ -1113,7 +1113,7 @@ public class ConfigurationManagerImpl extends ManagerBase
implements Configurati
}
type = configKey.type();
} else {
-type = c.getType();
+type = configuration.getType();
}
//no need to validate further if a
//config can have null value.
@@ -1222,96 +1222,145 @@ public class ConfigurationManagerImpl extends
ManagerBase implements Configurati
}
}
-if(c
[GitHub] [cloudstack] DaanHoogland merged pull request #6808: Allow privateips on console proxy
DaanHoogland merged PR #6808: URL: https://github.com/apache/cloudstack/pull/6808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6808: Allow privateips on console proxy
DaanHoogland commented on PR #6808: URL: https://github.com/apache/cloudstack/pull/6808#issuecomment-1362988635 > @DaanHoogland > > `Do you plan to document this? ` Initially I did not plan on documenting since it is not a major change, but I can do it. > > `And do you plan to apply @RodrigoDLopez 'extra space suggestion?` I applied the suggestion, is there a concern regarding it? No concerns, I just wodered what to test/look for. I'm fine with merging as is but I think it will not be for those that do not know beforehand what to expect, so if you an find any documentation on the console proxy domain configuration it would be nice if you can add it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
