[GitHub] [cloudstack] blueorangutan commented on pull request #7479: cks: k8s cluster on vpc tier

[via GitHub]

blueorangutan commented on PR #7479:
URL: https://github.com/apache/cloudstack/pull/7479#issuecomment-1563807267

   [SF] Trillian Build Failed (tid-6591)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7479: cks: k8s cluster on vpc tier

[via GitHub]

blueorangutan commented on PR #7479:
URL: https://github.com/apache/cloudstack/pull/7479#issuecomment-1563806353

   @shwstppr a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #7479: cks: k8s cluster on vpc tier

[via GitHub]

shwstppr commented on PR #7479:
URL: https://github.com/apache/cloudstack/pull/7479#issuecomment-1563806088

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7313: server: improve storage GC to skip expunging possible duplicate volumes

[via GitHub]

blueorangutan commented on PR #7313:
URL: https://github.com/apache/cloudstack/pull/7313#issuecomment-1563798423

   [LL]Trillian test result (tid-6544)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 47715 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7313-t6544-kvm-centos7.zip
   Smoke tests completed. 105 look OK, 3 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_privategw_static_routes | `Failure` | 966.51 | 
test_privategw_acl.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
`Failure` | 356.44 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 303.64 | 
test_vpc_redundant.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 516.61 | test_vpc_vpn.py
   test_01_vpc_site2site_vpn_multiple_options | `Error` | 1184.62 | 
test_vpc_vpn.py
   test_01_vpc_site2site_vpn | `Error` | 449.88 | test_vpc_vpn.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7508: guestos: add Windows Server 2022

[via GitHub]

blueorangutan commented on PR #7508:
URL: https://github.com/apache/cloudstack/pull/7508#issuecomment-1563775334

   [LL]Trillian test result (tid-6543)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 45154 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7508-t6543-kvm-centos7.zip
   Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_11_destroy_ssvm | `Error` | 3.14 | test_ssvm.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 569.77 | test_vpc_vpn.py
   test_01_vpc_site2site_vpn_multiple_options | `Error` | 1182.97 | 
test_vpc_vpn.py
   test_01_vpc_site2site_vpn | `Error` | 447.56 | test_vpc_vpn.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7484: HAproxy based load balancer Customisation

[via GitHub]

blueorangutan commented on PR #7484:
URL: https://github.com/apache/cloudstack/pull/7484#issuecomment-1563747934

   Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 
:heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. 
SL-JID 6154


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7479: cks: k8s cluster on vpc tier

[via GitHub]

blueorangutan commented on PR #7479:
URL: https://github.com/apache/cloudstack/pull/7479#issuecomment-1563746595

   Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 
:heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. 
SL-JID 6153


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7484: HAproxy based load balancer Customisation

[via GitHub]

blueorangutan commented on PR #7484:
URL: https://github.com/apache/cloudstack/pull/7484#issuecomment-1563713955

   @rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It 
will be bundled with  SystemVM template(s). I'll keep you posted as I make 
progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7479: cks: k8s cluster on vpc tier

[via GitHub]

blueorangutan commented on PR #7479:
URL: https://github.com/apache/cloudstack/pull/7479#issuecomment-1563712706

   @rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It 
will be bundled with  SystemVM template(s). I'll keep you posted as I make 
progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7484: HAproxy based load balancer Customisation

[via GitHub]

rohityadavcloud commented on PR #7484:
URL: https://github.com/apache/cloudstack/pull/7484#issuecomment-1563712705

   @blueorangutan package 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7479: cks: k8s cluster on vpc tier

[via GitHub]

rohityadavcloud commented on PR #7479:
URL: https://github.com/apache/cloudstack/pull/7479#issuecomment-1563711664

   @blueorangutan package 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7509: cks: enable by default

[via GitHub]

rohityadavcloud commented on code in PR #7509:
URL: https://github.com/apache/cloudstack/pull/7509#discussion_r1206152492


##
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterService.java:
##
@@ -38,7 +38,7 @@ public interface KubernetesClusterService extends 
PluggableService, Configurable
 
 static final ConfigKey KubernetesServiceEnabled = new 
ConfigKey("Advanced", Boolean.class,
 "cloud.kubernetes.service.enabled",
-"false",
+"true",
 "Indicates whether Kubernetes Service plugin is enabled or not. 
Management server restart needed on change",
 false);

Review Comment:
   It seems it’s not dynamic config 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[cloudstack] branch main updated: Fix acquire console session issue (#7558)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/main by this push:
 new 2457d202ddf Fix acquire console session issue (#7558)
2457d202ddf is described below

commit 2457d202ddf80dca9252bc06476895fe923eaa3b
Author: Nicolas Vazquez 
AuthorDate: Thu May 25 22:50:45 2023 -0300

Fix acquire console session issue (#7558)

* Fix acquire console session issue

* Refactor
---
 engine/schema/src/main/java/com/cloud/vm/ConsoleSessionVO.java | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/engine/schema/src/main/java/com/cloud/vm/ConsoleSessionVO.java 
b/engine/schema/src/main/java/com/cloud/vm/ConsoleSessionVO.java
index 53e98226db8..81a11241e4b 100644
--- a/engine/schema/src/main/java/com/cloud/vm/ConsoleSessionVO.java
+++ b/engine/schema/src/main/java/com/cloud/vm/ConsoleSessionVO.java
@@ -27,6 +27,8 @@ import javax.persistence.GeneratedValue;
 import javax.persistence.GenerationType;
 import javax.persistence.Id;
 import javax.persistence.Table;
+import javax.persistence.Temporal;
+import javax.persistence.TemporalType;
 
 @Entity
 @Table(name = "console_session")
@@ -56,6 +58,7 @@ public class ConsoleSessionVO {
 private long hostId;
 
 @Column(name = "acquired")
+@Temporal(value = TemporalType.TIMESTAMP)
 private Date acquired;
 
 @Column(name = "removed")

[GitHub] [cloudstack] rohityadavcloud merged pull request #7558: Fix acquire console session issue

[via GitHub]

rohityadavcloud merged PR #7558:
URL: https://github.com/apache/cloudstack/pull/7558


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[cloudstack] branch main updated: refactor: remove duplicate inject (#7548)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/main by this push:
 new 0c13024329e refactor: remove duplicate inject (#7548)
0c13024329e is described below

commit 0c13024329e5119136efdbed52a205e5b0592461
Author: Abhishek Kumar 
AuthorDate: Fri May 26 07:19:54 2023 +0530

refactor: remove duplicate inject (#7548)

VolumeDao has been injected twice. This PR removes and refactors injection.

Signed-off-by: Abhishek Kumar 
---
 .../java/com/cloud/storage/StorageManagerImpl.java | 48 +++---
 1 file changed, 23 insertions(+), 25 deletions(-)

diff --git a/server/src/main/java/com/cloud/storage/StorageManagerImpl.java 
b/server/src/main/java/com/cloud/storage/StorageManagerImpl.java
index c1d17cc8f70..471aa6e2524 100644
--- a/server/src/main/java/com/cloud/storage/StorageManagerImpl.java
+++ b/server/src/main/java/com/cloud/storage/StorageManagerImpl.java
@@ -19,6 +19,7 @@ package com.cloud.storage;
 import static com.cloud.utils.NumbersUtil.toHumanReadableSize;
 
 import java.math.BigDecimal;
+import java.math.BigInteger;
 import java.net.URI;
 import java.net.URISyntaxException;
 import java.net.UnknownHostException;
@@ -37,6 +38,7 @@ import java.util.List;
 import java.util.Map;
 import java.util.Random;
 import java.util.Set;
+import java.util.UUID;
 import java.util.concurrent.ExecutionException;
 import java.util.concurrent.Executors;
 import java.util.concurrent.ScheduledExecutorService;
@@ -45,8 +47,6 @@ import java.util.stream.Collectors;
 
 import javax.inject.Inject;
 
-import com.google.common.collect.Sets;
-import com.cloud.vm.UserVmManager;
 import org.apache.cloudstack.annotation.AnnotationService;
 import org.apache.cloudstack.annotation.dao.AnnotationDao;
 import org.apache.cloudstack.api.ApiConstants;
@@ -229,11 +229,11 @@ import com.cloud.utils.db.TransactionLegacy;
 import com.cloud.utils.db.TransactionStatus;
 import com.cloud.utils.exception.CloudRuntimeException;
 import com.cloud.vm.DiskProfile;
+import com.cloud.vm.UserVmManager;
 import com.cloud.vm.VMInstanceVO;
 import com.cloud.vm.VirtualMachine.State;
 import com.cloud.vm.dao.VMInstanceDao;
-import java.math.BigInteger;
-import java.util.UUID;
+import com.google.common.collect.Sets;
 
 @Component
 public class StorageManagerImpl extends ManagerBase implements StorageManager, 
ClusterManagerListener, Configurable {
@@ -249,8 +249,6 @@ public class StorageManagerImpl extends ManagerBase 
implements StorageManager, C
 @Inject
 protected ConfigurationManager _configMgr;
 @Inject
-protected VolumeDao _volsDao;
-@Inject
 private VolumeDataStoreDao _volumeDataStoreDao;
 @Inject
 protected HostDao _hostDao;
@@ -299,7 +297,7 @@ public class StorageManagerImpl extends ManagerBase 
implements StorageManager, C
 @Inject
 protected HypervisorGuruManager _hvGuruMgr;
 @Inject
-protected VolumeDao _volumeDao;
+protected VolumeDao volumeDao;
 @Inject
 ConfigurationDao _configDao;
 @Inject
@@ -372,7 +370,7 @@ public class StorageManagerImpl extends ManagerBase 
implements StorageManager, C
 public boolean share(VMInstanceVO vm, List vols, HostVO host, 
boolean cancelPreviousShare) throws StorageUnavailableException {
 
 // if pool is in maintenance and it is the ONLY pool available; reject
-List rootVolForGivenVm = 
_volsDao.findByInstanceAndType(vm.getId(), Type.ROOT);
+List rootVolForGivenVm = 
volumeDao.findByInstanceAndType(vm.getId(), Type.ROOT);
 if (rootVolForGivenVm != null && rootVolForGivenVm.size() > 0) {
 boolean isPoolAvailable = 
isPoolAvailable(rootVolForGivenVm.get(0).getPoolId());
 if (!isPoolAvailable) {
@@ -436,7 +434,7 @@ public class StorageManagerImpl extends ManagerBase 
implements StorageManager, C
 for (StoragePoolHostVO storagePoolHostRef : storagePoolHostRefs) {
 StoragePoolVO PrimaryDataStoreVO = 
_storagePoolDao.findById(storagePoolHostRef.getPoolId());
 if (PrimaryDataStoreVO.getPoolType() == StoragePoolType.LVM || 
PrimaryDataStoreVO.getPoolType() == StoragePoolType.EXT) {
-SearchBuilder volumeSB = 
_volsDao.createSearchBuilder();
+SearchBuilder volumeSB = 
volumeDao.createSearchBuilder();
 volumeSB.and("poolId", volumeSB.entity().getPoolId(), 
SearchCriteria.Op.EQ);
 volumeSB.and("removed", volumeSB.entity().getRemoved(), 
SearchCriteria.Op.NULL);
 volumeSB.and("state", volumeSB.entity().getState(), 
SearchCriteria.Op.NIN);
@@ -450,7 +448,7 @@ public class StorageManagerImpl extends ManagerBase 
implements StorageManager, C
 volumeSC.setParameters("state", Volume.State.Expunging, 
Volume.State.Destroy);
 volumeSC.setJoinParameters("activeVmSB", 

[GitHub] [cloudstack] rohityadavcloud merged pull request #7548: refactor: remove duplicate inject

[via GitHub]

rohityadavcloud merged PR #7548:
URL: https://github.com/apache/cloudstack/pull/7548


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7548: refactor: remove duplicate inject

[via GitHub]

rohityadavcloud commented on PR #7548:
URL: https://github.com/apache/cloudstack/pull/7548#issuecomment-1563707464

   Failures due to env, tests lgtm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7548: refactor: remove duplicate inject

[via GitHub]

blueorangutan commented on PR #7548:
URL: https://github.com/apache/cloudstack/pull/7548#issuecomment-1563664511

   [SF] Trillian test result (tid-6580)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 56524 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7548-t6580-kvm-centos7.zip
   Smoke tests completed. 109 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_upgrade_kubernetes_cluster | `Failure` | 497.79 | 
test_kubernetes_clusters.py
   test_08_upgrade_kubernetes_ha_cluster | `Error` | 4032.28 | 
test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | 
test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 3699.84 | 
test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7558: Fix acquire console session issue

[via GitHub]

blueorangutan commented on PR #7558:
URL: https://github.com/apache/cloudstack/pull/7558#issuecomment-1563643320

   [SF] Trillian test result (tid-6578)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 58701 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7558-t6578-kvm-centos7.zip
   Smoke tests completed. 109 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_upgrade_kubernetes_cluster | `Error` | 3969.42 | 
test_kubernetes_clusters.py
   test_08_upgrade_kubernetes_ha_cluster | `Error` | 4038.74 | 
test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | 
test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 113.03 | 
test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7515: Feature: Add unmanaged kubernetes cluster

[via GitHub]

blueorangutan commented on PR #7515:
URL: https://github.com/apache/cloudstack/pull/7515#issuecomment-1563589506

   Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 
:heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. 
SL-JID 6152


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7344: [HEALTH] 4.19/main Health Check, please don't merge this!

[via GitHub]

blueorangutan commented on PR #7344:
URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1563587935

   [LL]Trillian test result (tid-6541)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 42501 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7344-t6541-kvm-centos7.zip
   Smoke tests completed. 109 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_redundant_vpc_site2site_vpn | `Failure` | 538.20 | test_vpc_vpn.py
   test_01_vpc_site2site_vpn_multiple_options | `Error` | 1194.96 | 
test_vpc_vpn.py
   test_01_vpc_site2site_vpn | `Error` | 445.55 | test_vpc_vpn.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7344: [HEALTH] 4.19/main Health Check, please don't merge this!

[via GitHub]

blueorangutan commented on PR #7344:
URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1563581720

   [LL]Trillian test result (tid-6539)
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 42116 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7344-t6539-xenserver-71.zip
   Smoke tests completed. 109 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_redundant_vpc_site2site_vpn | `Failure` | 615.66 | test_vpc_vpn.py
   test_01_vpc_site2site_vpn_multiple_options | `Error` | 1240.92 | 
test_vpc_vpn.py
   test_01_vpc_site2site_vpn | `Failure` | 290.06 | test_vpc_vpn.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7541: ui,api: make description option for createKubernetesCluster

[via GitHub]

blueorangutan commented on PR #7541:
URL: https://github.com/apache/cloudstack/pull/7541#issuecomment-1563567122

   [SF] Trillian test result (tid-6579)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 52071 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7541-t6579-kvm-centos7.zip
   Smoke tests completed. 109 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_08_upgrade_kubernetes_ha_cluster | `Error` | 4025.64 | 
test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.05 | 
test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 3685.52 | 
test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] vishesh92 commented on pull request #7515: Feature: Add unmanaged kubernetes cluster

[via GitHub]

vishesh92 commented on PR #7515:
URL: https://github.com/apache/cloudstack/pull/7515#issuecomment-1563526286

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7515: Feature: Add unmanaged kubernetes cluster

[via GitHub]

blueorangutan commented on PR #7515:
URL: https://github.com/apache/cloudstack/pull/7515#issuecomment-1563526848

   @vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] github-actions[bot] commented on pull request #7489: Flexible tags for hosts and storage pools

[via GitHub]

github-actions[bot] commented on PR #7489:
URL: https://github.com/apache/cloudstack/pull/7489#issuecomment-1563511025

   This pull request has merge conflicts. Dear author, please fix the conflicts 
and sync your branch with the base branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] github-actions[bot] commented on pull request #7408: Allow volume live storage migration in ScaleIO

[via GitHub]

github-actions[bot] commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1563510991

   This pull request has merge conflicts. Dear author, please fix the conflicts 
and sync your branch with the base branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

[via GitHub]

weizhouapache commented on code in PR #7515:
URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1205950709


##
ui/src/views/compute/KubernetesServiceTab.vue:
##
@@ -25,17 +25,14 @@
   
 
   
-  
+  

Review Comment:
   you can rollback the changes and use `managed` here



##
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java:
##
@@ -783,15 +843,16 @@ public void 
doInTransactionWithoutResult(TransactionStatus status) {
 List details = new ArrayList<>();
 long kubernetesClusterId = kubernetesCluster.getId();
 
-if (Network.GuestType.Shared.equals(network.getGuestType())) {
+if ((network != null && 
Network.GuestType.Shared.equals(network.getGuestType())) || !cmd.isManaged()) {

Review Comment:
   OK.
   it might be useful



##
tools/marvin/marvin/deployDataCenter.py:
##
@@ -1133,7 +1133,7 @@ def removeDataCenter(self):
 print("\nDeployDC: CleanUp Started")
 ret = FAILED
 if self.__dcCfgFile:
-file_to_read = open(self.__dcCfgFile, 'rb')
+file_to_read = open(self.__dcCfgFile, 'r')

Review Comment:
   this reverts #7521 , which seems wrong



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] pdion891 commented on pull request #6639: Update GPU support for V100,T4,A5500.

[via GitHub]

pdion891 commented on PR #6639:
URL: https://github.com/apache/cloudstack/pull/6639#issuecomment-1563343482

   @rohityadavcloud  yes, but at this point it would make sense to update it 
with recent GPU model.
   I will rebase this PR and add some more GPU to it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] jbampton opened a new pull request, #7562: Add basic `.editorconfig` file to help maintain consistent coding styles

[via GitHub]

jbampton opened a new pull request, #7562:
URL: https://github.com/apache/cloudstack/pull/7562

   ### Description
   
   This PR adds a simple `EditorConfig` file. I used only three settings to 
start with.  
   
   Lots of great projects already use EditorConfig:
   
   https://github.com/editorconfig/editorconfig/wiki/Projects-Using-EditorConfig
   
   And you can see how Apache Airflow does it:
   
   https://github.com/apache/airflow/blob/main/.editorconfig
   
   From the official site:
   
   "EditorConfig helps maintain consistent coding styles for multiple 
developers working on the same project across various editors and IDEs. The 
EditorConfig project consists of a file format for defining coding styles and a 
collection of text editor plugins that enable editors to read the file format 
and adhere to defined styles. EditorConfig files are easily readable and they 
work nicely with version control systems."
   
   https://editorconfig.org/
   
   A lot of editors already come bundled with support: 
https://editorconfig.org/#pre-installed
   
   Some editors require you to download a plugin: 
https://editorconfig.org/#download
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [X] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [X] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [X] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7558: Fix acquire console session issue

[via GitHub]

blueorangutan commented on PR #7558:
URL: https://github.com/apache/cloudstack/pull/7558#issuecomment-1563327076

   Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 
:heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. 
SL-JID 6151


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7558: Fix acquire console session issue

[via GitHub]

blueorangutan commented on PR #7558:
URL: https://github.com/apache/cloudstack/pull/7558#issuecomment-1563255979

   @nvazquez a [SF] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #7558: Fix acquire console session issue

[via GitHub]

nvazquez commented on PR #7558:
URL: https://github.com/apache/cloudstack/pull/7558#issuecomment-1563253996

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7344: [HEALTH] 4.19/main Health Check, please don't merge this!

[via GitHub]

blueorangutan commented on PR #7344:
URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1563250569

   [LL]Trillian test result (tid-6540)
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
   Total time taken: 23713 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7344-t6540-vmware-67u3.zip
   Smoke tests completed. 86 look OK, 0 have errors, 24 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   all_test_safe_shutdown | `Skipped` | --- | test_safe_shutdown.py
   all_test_metrics_api | `Skipped` | --- | test_metrics_api.py
   all_test_outofbandmanagement | `Skipped` | --- | test_outofbandmanagement.py
   all_test_outofbandmanagement_nestedplugin | `Skipped` | --- | 
test_outofbandmanagement_nestedplugin.py
   all_test_routers_iptables_default_policy | `Skipped` | --- | 
test_routers_iptables_default_policy.py
   all_test_secondary_storage | `Skipped` | --- | test_secondary_storage.py
   all_test_service_offerings | `Skipped` | --- | test_service_offerings.py
   all_test_storage_policy | `Skipped` | --- | test_storage_policy.py
   all_test_templates | `Skipped` | --- | test_templates.py
   all_test_update_security_group | `Skipped` | --- | 
test_update_security_group.py
   all_test_usage_events | `Skipped` | --- | test_usage_events.py
   all_test_vm_autoscaling | `Skipped` | --- | test_vm_autoscaling.py
   all_test_vm_deployment_planner | `Skipped` | --- | 
test_vm_deployment_planner.py
   all_test_vm_life_cycle | `Skipped` | --- | test_vm_life_cycle.py
   all_test_vm_lifecycle_unmanage_import | `Skipped` | --- | 
test_vm_lifecycle_unmanage_import.py
   all_test_vm_snapshot_kvm | `Skipped` | --- | test_vm_snapshot_kvm.py
   all_test_vm_snapshots | `Skipped` | --- | test_vm_snapshots.py
   all_test_volumes | `Skipped` | --- | test_volumes.py
   all_test_vpc_ipv6 | `Skipped` | --- | test_vpc_ipv6.py
   all_test_vpc_redundant | `Skipped` | --- | test_vpc_redundant.py
   all_test_vpc_router_nics | `Skipped` | --- | test_vpc_router_nics.py
   all_test_vpc_vpn | `Skipped` | --- | test_vpc_vpn.py
   all_test_host_maintenance | `Skipped` | --- | test_host_maintenance.py
   all_test_hostha_kvm | `Skipped` | --- | test_hostha_kvm.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[cloudstack-terraform-provider] branch main updated: Fix spelling (#59)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch main
in repository 
https://gitbox.apache.org/repos/asf/cloudstack-terraform-provider.git


The following commit(s) were added to refs/heads/main by this push:
 new 5e3e753  Fix spelling (#59)
5e3e753 is described below

commit 5e3e75394e169a43ed5a9818686b870e7288f63a
Author: John Bampton 
AuthorDate: Fri May 26 02:48:19 2023 +1000

Fix spelling (#59)
---
 README.md  | 4 ++--
 cloudstack/metadata.go | 2 +-
 cloudstack/resource_cloudstack_instance.go | 4 ++--
 cloudstack/resource_cloudstack_network.go  | 2 +-
 cloudstack/resource_cloudstack_network_offering.go | 4 ++--
 website/docs/d/instance.html.markdown  | 4 ++--
 6 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/README.md b/README.md
index 9c128cc..794ff18 100644
--- a/README.md
+++ b/README.md
@@ -7,7 +7,7 @@ Requirements
 -  [Terraform](https://www.terraform.io/downloads.html) 1.0.x
 -  [Go](https://golang.org/doc/install) 1.16+ (to build the provider 
plugin)
 
-Using the Provider from Terrafrom registry
+Using the Provider from Terraform registry
 --
 To install the CloudStack provider, copy and paste the below code into your 
Terraform configuration. Then, run terraform init.
 ```sh
@@ -85,7 +85,7 @@ $ export 
CLOUDSTACK_API_KEY=r_gszj7e0ttr_C6CP5QU_1IV82EIOtK4o_K9i_AltVztfO68wpXi
 $ export 
CLOUDSTACK_SECRET_KEY=tsfMDShFe94f4JkJfEh6_tZZ--w5jqEW7vGL2tkZGQgcdbnxNoq9fRmwAtU5MEGGXOrDlNA6tfvGK14fk_MB6w
 ```
 
-In order for all the tests to pass, you will need to create a new (empty) 
project in the UI called `terraform`. When the project is created you can run 
the Acceptance tests against the CloudStack Simulator by simply runnning:
+In order for all the tests to pass, you will need to create a new (empty) 
project in the UI called `terraform`. When the project is created you can run 
the Acceptance tests against the CloudStack Simulator by simply running:
 
 ```sh
 $ make testacc
diff --git a/cloudstack/metadata.go b/cloudstack/metadata.go
index 714c244..59f6801 100644
--- a/cloudstack/metadata.go
+++ b/cloudstack/metadata.go
@@ -59,7 +59,7 @@ func getMetadata(cs *cloudstack.CloudStackClient, d 
*schema.ResourceData, resour
if err != nil {
return nil, err
}
-   // Only return metadata values that were explicitely set
+   // Only return metadata values that were explicitly set
var existingFilter map[string]interface{}
if metadata, ok := d.GetOk("metadata"); ok {
existingFilter = metadata.(map[string]interface{})
diff --git a/cloudstack/resource_cloudstack_instance.go 
b/cloudstack/resource_cloudstack_instance.go
index 8922606..f083181 100644
--- a/cloudstack/resource_cloudstack_instance.go
+++ b/cloudstack/resource_cloudstack_instance.go
@@ -350,7 +350,7 @@ func resourceCloudStackInstanceRead(d *schema.ResourceData, 
meta interface{}) er
d.Set("display_name", vm.Displayname)
d.Set("group", vm.Group)
 
-   // In some rare cases (when destroying a machine failes) it can happen 
that
+   // In some rare cases (when destroying a machine fails) it can happen 
that
// an instance does not have any attached NIC anymore.
if len(vm.Nic) > 0 {
d.Set("network_id", vm.Nic[0].Networkid)
@@ -675,7 +675,7 @@ func getUserData(userData string, httpGetOnly bool) 
(string, error) {
if len(ud) > maxUD {
return "", fmt.Errorf(
"The supplied user_data contains %d bytes after 
encoding, "+
-   "this exeeds the limit of %d bytes", len(ud), 
maxUD)
+   "this exceeds the limit of %d bytes", len(ud), 
maxUD)
}
 
return ud, nil
diff --git a/cloudstack/resource_cloudstack_network.go 
b/cloudstack/resource_cloudstack_network.go
index febd0bb..405b9a2 100644
--- a/cloudstack/resource_cloudstack_network.go
+++ b/cloudstack/resource_cloudstack_network.go
@@ -224,7 +224,7 @@ func resourceCloudStackNetworkCreate(d 
*schema.ResourceData, meta interface{}) e
// Set the vpc id
p.SetVpcid(vpcid.(string))
 
-   // Since we're in a VPC, check if we want to assiciate an ACL 
list
+   // Since we're in a VPC, check if we want to associate an ACL 
list
if aclid, ok := d.GetOk("acl_id"); ok && aclid.(string) != none 
{
// Set the acl ID
p.SetAclid(aclid.(string))
diff --git a/cloudstack/resource_cloudstack_network_offering.go 
b/cloudstack/resource_cloudstack_network_offering.go
index e11ece2..a414ff3 100644
--- a/cloudstack/resource_cloudstack_network_offering.go
+++ b/cloudstack/resource_cloudstack_network_offering.go
@@ -135,10 +135,10 @@ func 

[cloudstack] branch main updated (47af4327455 -> ce44ff41486)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


from 47af4327455 Merge remote-tracking branch 'origin/4.18'
 add 8849e0f464c server: fix volume detach operation when no vm host (#7526)
 add 4138ca7c5d0 systemvmtemplate: fix Debian 11.7.0 ISO URL
 new ce44ff41486 Merge remote-tracking branch 'origin/4.18'

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../com/cloud/storage/VolumeApiServiceImpl.java| 68 +-
 .../cloud/storage/VolumeApiServiceImplTest.java| 54 ++---
 tools/appliance/systemvmtemplate/template.json |  4 +-
 3 files changed, 74 insertions(+), 52 deletions(-)

[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.18'

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit ce44ff4148676138a103c6a2e6a68845e5046ee0
Merge: 47af4327455 4138ca7c5d0
Author: Rohit Yadav 
AuthorDate: Thu May 25 22:16:16 2023 +0530

Merge remote-tracking branch 'origin/4.18'

 .../com/cloud/storage/VolumeApiServiceImpl.java| 68 +-
 .../cloud/storage/VolumeApiServiceImplTest.java| 54 ++---
 tools/appliance/systemvmtemplate/template.json |  4 +-
 3 files changed, 74 insertions(+), 52 deletions(-)

[cloudstack] branch 4.18 updated (8849e0f464c -> 4138ca7c5d0)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch 4.18
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


from 8849e0f464c server: fix volume detach operation when no vm host (#7526)
 add 4138ca7c5d0 systemvmtemplate: fix Debian 11.7.0 ISO URL

No new revisions were added by this update.

Summary of changes:
 tools/appliance/systemvmtemplate/template.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

[cloudstack-kubernetes-provider] branch main updated: Fix spelling (#49)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch main
in repository 
https://gitbox.apache.org/repos/asf/cloudstack-kubernetes-provider.git


The following commit(s) were added to refs/heads/main by this push:
 new a0469bcd Fix spelling (#49)
a0469bcd is described below

commit a0469bcd927f10a0136933cf0ad9f80685cd267e
Author: John Bampton 
AuthorDate: Fri May 26 02:11:23 2023 +1000

Fix spelling (#49)
---
 README.md  | 2 +-
 cloudstack_loadbalancer.go | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index 41838438..de548d7f 100644
--- a/README.md
+++ b/README.md
@@ -16,7 +16,7 @@ Refer:
 
 ## Deployment
 
-The CloudStack Kubernetes Provider is automatically deployed when a Kuberentes 
Cluster is created on CloudStack 4.16+
+The CloudStack Kubernetes Provider is automatically deployed when a Kubernetes 
Cluster is created on CloudStack 4.16+
 
 In order to communicate with CloudStack, a separate service user **kubeadmin** 
is created in the same account as the cluster owner.
 The provider uses this user's API keys to get the details of the cluster as 
well as update the networking rules. It is imperative that this user
diff --git a/cloudstack_loadbalancer.go b/cloudstack_loadbalancer.go
index d5793be9..b796dfa9 100644
--- a/cloudstack_loadbalancer.go
+++ b/cloudstack_loadbalancer.go
@@ -370,7 +370,7 @@ func (lb *loadBalancer) hasLoadBalancerIP() bool {
return lb.ipAddr != "" && lb.ipAddrID != ""
 }
 
-// getLoadBalancerIP retieves an existing IP or associates a new IP.
+// getLoadBalancerIP retrieves an existing IP or associates a new IP.
 func (lb *loadBalancer) getLoadBalancerIP(loadBalancerIP string) error {
if loadBalancerIP != "" {
return lb.getPublicIPAddress(loadBalancerIP)

[GitHub] [cloudstack] shwstppr commented on pull request #7509: cks: enable by default

[via GitHub]

shwstppr commented on PR #7509:
URL: https://github.com/apache/cloudstack/pull/7509#issuecomment-1563160667

   @weizhouapache test updates the config and restarts MS only when the config 
is false.
   If the config is made dynamic then restart won't be needed.
   Config was not made dynamic initially because APIs are accessible only when 
the config is true. If it is made dynamic then APIs would always be available. 
Though we can add checks that they throw proper error  when the config is false.
   In terms of overhead, only two GC and state scanner threads would be running 
additionally. We may also have to add a config to control interval for state 
scanner thread.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Kwakye-Emmanuel commented on issue #7371: how can we migrate vm from proxmox to cloudstack??

[via GitHub]

Kwakye-Emmanuel commented on issue #7371:
URL: https://github.com/apache/cloudstack/issues/7371#issuecomment-1563136715

   ok, please show me
   
   On Thu, May 25, 2023 at 3:27 PM leolage ***@***.***> wrote:
   
   > Hi, I can show you how to transfer a qcow image of a virtual machine to
   > the Cloudstack storage. I have previously accomplished this by creating a
   > virtual machine on Cloudstack and then replacing the disk file of the VM
   > with the qcow image copied from Proxmox.
   >
   > —
   > Reply to this email directly, view it on GitHub
   > ,
   > or unsubscribe
   > 

   > .
   > You are receiving this because you were mentioned.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[cloudstack-cloudmonkey] branch main updated: Fix spelling in `README.md` (#135)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git


The following commit(s) were added to refs/heads/main by this push:
 new 97a284d  Fix spelling in `README.md` (#135)
97a284d is described below

commit 97a284dd5e9df216693daf649b3f6b8091e6d88e
Author: John Bampton 
AuthorDate: Fri May 26 01:03:56 2023 +1000

Fix spelling in `README.md` (#135)
---
 README.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index 9b30884..35f0a80 100644
--- a/README.md
+++ b/README.md
@@ -2,7 +2,7 @@
 
 `cloudmonkey` :cloud::monkey_face: is a command line interface (CLI) for
 [Apache CloudStack](http://cloudstack.apache.org).
-CloudMonkey can be use both as an interactive shell and as a command line tool
+CloudMonkey can be used both as an interactive shell and as a command line tool
 which simplifies Apache CloudStack configuration and management.
 
 The modern cloudmonkey is a re-written and simplified port in Go and can be 
used
@@ -76,7 +76,7 @@ platforms such as Linux, Mac and Windows.
 If cloudmonkey is being upgraded from a version lower than v6.0.0, it must be 
noted
 that the cloudmonkey configuration path is changed from 
`~/.cloudmonkey/config` to 
 `~/.cmk/config` and a default `localcloud` profile is created. One would have 
to hence
-do an initial setup of basic configration such 
apikey/secretkey/username/password/url for the required profile(s) as required
+do an initial setup of basic configuration such 
apikey/secretkey/username/password/url for the required profile(s) as required
 
 ### License
 

[GitHub] [cloudstack] weizhouapache commented on pull request #7509: cks: enable by default

[via GitHub]

weizhouapache commented on PR #7509:
URL: https://github.com/apache/cloudstack/pull/7509#issuecomment-1563066544

   as far as remember, smoke test test_kubernetes_clusters.py updates the 
globals setting and restarts the mangement server.
   If the setting is dynamic, restarting mgmt server is not required (actually 
it is not required even if the setting is not dynamic)
   cc @shwstppr 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7313: server: improve storage GC to skip expunging possible duplicate volumes

[via GitHub]

blueorangutan commented on PR #7313:
URL: https://github.com/apache/cloudstack/pull/7313#issuecomment-1563052272

   @DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) 
has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #7313: server: improve storage GC to skip expunging possible duplicate volumes

[via GitHub]

DaanHoogland commented on PR #7313:
URL: https://github.com/apache/cloudstack/pull/7313#issuecomment-1563050541

   @blueorangutan LLtest


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6473: Fix backup dates

[via GitHub]

blueorangutan commented on PR #6473:
URL: https://github.com/apache/cloudstack/pull/6473#issuecomment-1563030099

   [LL]Trillian test result (tid-6537)
   Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server r8
   Total time taken: 23895 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6473-t6537-vmware-70u3.zip
   Smoke tests completed. 86 look OK, 0 have errors, 24 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   all_test_safe_shutdown | `Skipped` | --- | test_safe_shutdown.py
   all_test_metrics_api | `Skipped` | --- | test_metrics_api.py
   all_test_outofbandmanagement | `Skipped` | --- | test_outofbandmanagement.py
   all_test_outofbandmanagement_nestedplugin | `Skipped` | --- | 
test_outofbandmanagement_nestedplugin.py
   all_test_routers_iptables_default_policy | `Skipped` | --- | 
test_routers_iptables_default_policy.py
   all_test_secondary_storage | `Skipped` | --- | test_secondary_storage.py
   all_test_service_offerings | `Skipped` | --- | test_service_offerings.py
   all_test_storage_policy | `Skipped` | --- | test_storage_policy.py
   all_test_templates | `Skipped` | --- | test_templates.py
   all_test_update_security_group | `Skipped` | --- | 
test_update_security_group.py
   all_test_usage_events | `Skipped` | --- | test_usage_events.py
   all_test_vm_autoscaling | `Skipped` | --- | test_vm_autoscaling.py
   all_test_vm_deployment_planner | `Skipped` | --- | 
test_vm_deployment_planner.py
   all_test_vm_life_cycle | `Skipped` | --- | test_vm_life_cycle.py
   all_test_vm_lifecycle_unmanage_import | `Skipped` | --- | 
test_vm_lifecycle_unmanage_import.py
   all_test_vm_snapshot_kvm | `Skipped` | --- | test_vm_snapshot_kvm.py
   all_test_vm_snapshots | `Skipped` | --- | test_vm_snapshots.py
   all_test_volumes | `Skipped` | --- | test_volumes.py
   all_test_vpc_ipv6 | `Skipped` | --- | test_vpc_ipv6.py
   all_test_vpc_redundant | `Skipped` | --- | test_vpc_redundant.py
   all_test_vpc_router_nics | `Skipped` | --- | test_vpc_router_nics.py
   all_test_vpc_vpn | `Skipped` | --- | test_vpc_vpn.py
   all_test_host_maintenance | `Skipped` | --- | test_host_maintenance.py
   all_test_hostha_kvm | `Skipped` | --- | test_hostha_kvm.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #7526: server: fix volume detach operation when no vm host

[via GitHub]

DaanHoogland commented on PR #7526:
URL: https://github.com/apache/cloudstack/pull/7526#issuecomment-1562942909

   tested according to 
https://github.com/apache/cloudstack/issues/7525#issue-1707304990 and verified 
no extra disks attached to the VM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland merged pull request #7526: server: fix volume detach operation when no vm host

[via GitHub]

DaanHoogland merged PR #7526:
URL: https://github.com/apache/cloudstack/pull/7526


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[cloudstack] branch 4.18 updated (2b3e2e48a07 -> 8849e0f464c)

[dahn]

This is an automated email from the ASF dual-hosted git repository.

dahn pushed a change to branch 4.18
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


from 2b3e2e48a07 ui: show zones and offerings to users (#7557)
 add 8849e0f464c server: fix volume detach operation when no vm host (#7526)

No new revisions were added by this update.

Summary of changes:
 .../com/cloud/storage/VolumeApiServiceImpl.java| 68 +-
 .../cloud/storage/VolumeApiServiceImplTest.java| 54 ++---
 2 files changed, 72 insertions(+), 50 deletions(-)

[GitHub] [cloudstack] blueorangutan commented on pull request #7345: [HEALTH] 4.18 LTS Health Check, please don't merge this!

[via GitHub]

blueorangutan commented on PR #7345:
URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1562899053

   Trillian test result (tid-6532)
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
   Total time taken: 100666 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7345-t6532-vmware-67u3.zip
   Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_redundant_vpc_site2site_vpn | `Failure` | 1811.23 | test_vpc_vpn.py
   test_01_redundant_vpc_site2site_vpn | `Error` | 1811.28 | test_vpc_vpn.py
   test_01_vpc_site2site_vpn_multiple_options | `Failure` | 1858.01 | 
test_vpc_vpn.py
   test_01_vpc_site2site_vpn_multiple_options | `Error` | 1858.05 | 
test_vpc_vpn.py
   test_01_vpc_site2site_vpn | `Error` | 14685.58 | test_vpc_vpn.py
   test_01_vpc_site2site_vpn | `Error` | 14685.89 | test_vpc_vpn.py
   test_01_cancel_host_maintenace_with_no_migration_jobs | `Error` | 1806.71 | 
test_host_maintenance.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 1993.78 | 
test_host_maintenance.py
   test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 
1920.14 | test_host_maintenance.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] benj-n closed pull request #7535: Ensure cloudstack-usage debian package is installed after cloudstack-management

[via GitHub]

benj-n closed pull request #7535: Ensure cloudstack-usage debian package is 
installed after cloudstack-management
URL: https://github.com/apache/cloudstack/pull/7535


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6809: Reserve memory for host

[via GitHub]

blueorangutan commented on PR #6809:
URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1562878567

   Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 
:heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. 
SL-JID 6150


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.18'

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 47af43274559474cf83cba5f01291033b6e4bc05
Merge: 48af4625a22 2b3e2e48a07
Author: Rohit Yadav 
AuthorDate: Thu May 25 17:51:01 2023 +0530

Merge remote-tracking branch 'origin/4.18'

 ui/.env.primate-qa  |  2 +-
 ui/src/components/view/InfoCard.vue |  2 +-
 ui/src/config/router.js |  4 +++-
 ui/src/config/section/offering.js   | 37 +-
 ui/src/config/section/zone.js   | 45 +
 ui/src/utils/plugins.js |  2 +-
 6 files changed, 77 insertions(+), 15 deletions(-)

[cloudstack] branch main updated (48af4625a22 -> 47af4327455)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


from 48af4625a22 Fix end of file precommit for TemplateServiceImplTest.java 
(#7561)
 add 2b3e2e48a07 ui: show zones and offerings to users (#7557)
 new 47af4327455 Merge remote-tracking branch 'origin/4.18'

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 ui/.env.primate-qa |  2 +-
 ui/src/components/view/InfoCard.vue|  2 +-
 ui/src/config/router.js|  4 ++-
 ui/src/config/section/offering.js  | 37 +++---
 .../config/section/{plugin/cloudian.js => zone.js} | 31 ++
 ui/src/utils/plugins.js|  2 +-
 6 files changed, 56 insertions(+), 22 deletions(-)
 copy ui/src/config/section/{plugin/cloudian.js => zone.js} (52%)

[GitHub] [cloudstack] codecov[bot] commented on pull request #7559: Create user 'cloud' in cloudstack-usage postinstall

[via GitHub]

codecov[bot] commented on PR #7559:
URL: https://github.com/apache/cloudstack/pull/7559#issuecomment-1562810833

   ## 
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7559?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 Report
   > Merging 
[#7559](https://app.codecov.io/gh/apache/cloudstack/pull/7559?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 (faa744b) into 
[4.18](https://app.codecov.io/gh/apache/cloudstack/commit/5e71cea2c59217c92e8f271b315c8fd78136e89d?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 (5e71cea) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@Coverage Diff@@
   ##   4.18#7559   +/-   ##
   =
 Coverage 12.93%   12.93%   
   - Complexity 8949 8950+1 
   =
 Files  2716 2716   
 Lines256144   256144   
 Branches  3994739947   
   =
   + Hits  3314133142+1 
   + Misses   218842   218840-2 
   - Partials   4161 4162+1 
   ```
   
   
   [see 1 file with indirect coverage 
changes](https://app.codecov.io/gh/apache/cloudstack/pull/7559/indirect-changes?src=pr=tree-more_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD 
build times. [Learn 
more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] codecov[bot] commented on pull request #7551: pre-commit: apply `end-of-file-fixer` to all files

[via GitHub]

codecov[bot] commented on PR #7551:
URL: https://github.com/apache/cloudstack/pull/7551#issuecomment-1562807249

   ## 
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7551?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 Report
   > Merging 
[#7551](https://app.codecov.io/gh/apache/cloudstack/pull/7551?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 (46c33ef) into 
[main](https://app.codecov.io/gh/apache/cloudstack/commit/c9b103c8a7153cc480e5534be3a62629286257e3?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 (c9b103c) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@Coverage Diff@@
   ##   main#7551   +/-   ##
   =
 Coverage 12.95%   12.95%   
 Complexity 8986 8986   
   =
 Files  2728 2728   
 Lines256647   256647   
 Branches  4002440024   
   =
 Hits  3325733257   
 Misses   219210   219210   
 Partials   4180 4180   
   ```
   
   
   
   :mega: We’re building smart automated test selection to slash your CI/CD 
build times. [Learn 
more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7509: cks: enable by default

[via GitHub]

DaanHoogland commented on code in PR #7509:
URL: https://github.com/apache/cloudstack/pull/7509#discussion_r1205421428


##
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterService.java:
##
@@ -38,7 +38,7 @@ public interface KubernetesClusterService extends 
PluggableService, Configurable
 
 static final ConfigKey KubernetesServiceEnabled = new 
ConfigKey("Advanced", Boolean.class,
 "cloud.kubernetes.service.enabled",
-"false",
+"true",
 "Indicates whether Kubernetes Service plugin is enabled or not. 
Management server restart needed on change",
 false);

Review Comment:
   ```suggestion
   true);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #7509: cks: enable by default

[via GitHub]

DaanHoogland commented on PR #7509:
URL: https://github.com/apache/cloudstack/pull/7509#issuecomment-1562788737

   > LGTM, may need some discussion with the community
   
   @weizhouapache , is there any ramification on enabling it, like performance 
degradation? I don t see why we couldn't enable it if not. 
   
   > btw, can we make it as a dynamic setting so it does not require a 
management server restart ?
   
   @shwstppr , I checked the code and it seems to me we can make it dynamic. 
Any concerns with that?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] vishesh92 commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

[via GitHub]

vishesh92 commented on code in PR #7515:
URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1205416033


##
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java:
##
@@ -783,15 +843,16 @@ public void 
doInTransactionWithoutResult(TransactionStatus status) {
 List details = new ArrayList<>();
 long kubernetesClusterId = kubernetesCluster.getId();
 
-if (Network.GuestType.Shared.equals(network.getGuestType())) {
+if ((network != null && 
Network.GuestType.Shared.equals(network.getGuestType())) || !cmd.isManaged()) {

Review Comment:
   I want to allow whatever information the user wants to add to the un-managed 
clusters.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6809: Reserve memory for host

[via GitHub]

blueorangutan commented on PR #6809:
URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1562785460

   @soreana a [SF] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] soreana commented on pull request #6809: Reserve memory for host

[via GitHub]

soreana commented on PR #6809:
URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1562784146

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] vishesh92 commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

[via GitHub]

vishesh92 commented on code in PR #7515:
URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1205408466


##
engine/schema/src/main/resources/META-INF/db/schema-41810to41900.sql:
##
@@ -135,3 +135,7 @@ CREATE VIEW `cloud`.`async_job_view` AS
 UPDATE `cloud`.`console_session` SET removed=now();
 -- Modify acquired column in console_session to datetime type
 ALTER TABLE `cloud`.`console_session` DROP `acquired`, ADD `acquired` datetime 
COMMENT 'When the session was acquired' AFTER `host_id`;
+
+ALTER TABLE `cloud`.`kubernetes_cluster` ADD COLUMN is_managed tinyint(1) 
DEFAULT 1;
+
+ALTER TABLE `cloud`.`kubernetes_cluster` MODIFY COLUMN `kubernetes_version_id` 
bigint unsigned NULL;

Review Comment:
   It's removing the comment. let me fix that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[cloudstack] branch 4.18 updated: ui: show zones and offerings to users (#7557)

[dahn]

This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch 4.18
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.18 by this push:
 new 2b3e2e48a0 ui: show zones and offerings to users (#7557)
2b3e2e48a0 is described below

commit 2b3e2e48a07fed567239fa87874583ae730273e6
Author: Rohit Yadav 
AuthorDate: Thu May 25 17:14:44 2023 +0530

ui: show zones and offerings to users (#7557)

Signed-off-by: Rohit Yadav 
---
 ui/.env.primate-qa  |  2 +-
 ui/src/components/view/InfoCard.vue |  2 +-
 ui/src/config/router.js |  4 +++-
 ui/src/config/section/offering.js   | 37 +-
 ui/src/config/section/zone.js   | 45 +
 ui/src/utils/plugins.js |  2 +-
 6 files changed, 77 insertions(+), 15 deletions(-)

diff --git a/ui/.env.primate-qa b/ui/.env.primate-qa
index 3db8e24d33..006315c704 100644
--- a/ui/.env.primate-qa
+++ b/ui/.env.primate-qa
@@ -1 +1 @@
-CS_URL=http://primate-qa.cloudstack.cloud:8080
+CS_URL=https://qa.cloudstack.cloud/
diff --git a/ui/src/components/view/InfoCard.vue 
b/ui/src/components/view/InfoCard.vue
index e56fc6eb54..0b9ebf4265 100644
--- a/ui/src/components/view/InfoCard.vue
+++ b/ui/src/components/view/InfoCard.vue
@@ -26,7 +26,7 @@
   @click="showUploadModal(true)"
   v-clipboard:copy="name" >
   
-  
+  
 
   
   
diff --git a/ui/src/config/router.js b/ui/src/config/router.js
index 9f4616e97f..e7e8e64287 100644
--- a/ui/src/config/router.js
+++ b/ui/src/config/router.js
@@ -34,6 +34,7 @@ import account from '@/config/section/account'
 import domain from '@/config/section/domain'
 import role from '@/config/section/role'
 import infra from '@/config/section/infra'
+import zone from '@/config/section/zone'
 import offering from '@/config/section/offering'
 import config from '@/config/section/config'
 import tools from '@/config/section/tools'
@@ -44,7 +45,7 @@ function generateRouterMap (section) {
   var map = {
 name: section.name,
 path: '/' + section.name,
-hidden: section.hidden,
+hidden: 'show' in section ? !section.show() : section.hidden,
 meta: {
   title: section.title,
   icon: section.icon,
@@ -235,6 +236,7 @@ export function asyncRouterMap () {
   generateRouterMap(account),
   generateRouterMap(domain),
   generateRouterMap(infra),
+  generateRouterMap(zone),
   generateRouterMap(offering),
   generateRouterMap(config),
   generateRouterMap(tools),
diff --git a/ui/src/config/section/offering.js 
b/ui/src/config/section/offering.js
index d78ba2ec59..35acfbb674 100644
--- a/ui/src/config/section/offering.js
+++ b/ui/src/config/section/offering.js
@@ -21,15 +21,21 @@ export default {
   name: 'offering',
   title: 'label.menu.service.offerings',
   icon: 'shopping-outlined',
-  permission: ['listServiceOfferings', 'listDiskOfferings', 'listDomains'],
+  permission: ['listServiceOfferings', 'listDiskOfferings'],
   children: [
 {
   name: 'computeoffering',
   title: 'label.compute.offerings',
   docHelp: 
'adminguide/service_offerings.html#compute-and-disk-service-offerings',
   icon: 'cloud-outlined',
-  permission: ['listServiceOfferings', 'listDomains'],
-  params: { isrecursive: 'true' },
+  permission: ['listServiceOfferings'],
+  params: () => {
+var params = {}
+if (['Admin', 
'DomainAdmin'].includes(store.getters.userInfo.roletype)) {
+  params = { isrecursive: 'true' }
+}
+return params
+  },
   columns: ['name', 'displaytext', 'cpunumber', 'cpuspeed', 'memory', 
'domain', 'zone', 'order'],
   details: () => {
 var fields = ['name', 'id', 'displaytext', 'offerha', 
'provisioningtype', 'storagetype', 'iscustomized', 'iscustomizediops', 
'limitcpuuse', 'cpunumber', 'cpuspeed', 'memory', 'hosttags', 'tags', 
'storagetags', 'domain', 'zone', 'created', 'dynamicscalingenabled', 
'diskofferingstrictness', 'encryptroot']
@@ -51,7 +57,8 @@ export default {
 },
 {
   name: 'comments',
-  component: shallowRef(defineAsyncComponent(() => 
import('@/components/view/AnnotationsTab.vue')))
+  component: shallowRef(defineAsyncComponent(() => 
import('@/components/view/AnnotationsTab.vue'))),
+  show: (record, route, user) => { return ['Admin', 
'DomainAdmin'].includes(user.roletype) }
 }
   ],
   related: [{
@@ -138,8 +145,14 @@ export default {
   title: 'label.disk.offerings',
   icon: 'hdd-outlined',
   docHelp: 
'adminguide/service_offerings.html#compute-and-disk-service-offerings',
-  permission: ['listDiskOfferings', 'listDomains'],
-  params: { isrecursive: 'true' },
+  permission: ['listDiskOfferings'],
+  params: () 

[GitHub] [cloudstack] DaanHoogland merged pull request #7557: ui: show zones and offerings to users

[via GitHub]

DaanHoogland merged PR #7557:
URL: https://github.com/apache/cloudstack/pull/7557


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #7557: ui: show zones and offerings to users

[via GitHub]

DaanHoogland commented on PR #7557:
URL: https://github.com/apache/cloudstack/pull/7557#issuecomment-1562759579

   tested in qa again:
   as regular user I see
   
![image](https://github.com/apache/cloudstack/assets/2486961/9fb98c4e-92b5-46c4-b239-2de9913ce4a2)
   
![image](https://github.com/apache/cloudstack/assets/2486961/07d15fa2-2142-46c2-99e7-6c1db2057030)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #7561: Fix end of file precommit for TemplateServiceImplTest.java

[via GitHub]

weizhouapache commented on PR #7561:
URL: https://github.com/apache/cloudstack/pull/7561#issuecomment-1562719728

   small fix, not smoke tests required.
   merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[cloudstack] branch main updated: Fix end of file precommit for TemplateServiceImplTest.java (#7561)

[weizhou]

This is an automated email from the ASF dual-hosted git repository.

weizhou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/main by this push:
 new 48af4625a22 Fix end of file precommit for TemplateServiceImplTest.java 
(#7561)
48af4625a22 is described below

commit 48af4625a22610b0aa84305f479d1d31e927608b
Author: Vishesh 
AuthorDate: Thu May 25 16:41:09 2023 +0530

Fix end of file precommit for TemplateServiceImplTest.java (#7561)
---
 .../org/apache/cloudstack/storage/image/TemplateServiceImplTest.java| 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/engine/storage/image/src/test/java/org/apache/cloudstack/storage/image/TemplateServiceImplTest.java
 
b/engine/storage/image/src/test/java/org/apache/cloudstack/storage/image/TemplateServiceImplTest.java
index e2b07c5bbb6..bc6f37b201a 100644
--- 
a/engine/storage/image/src/test/java/org/apache/cloudstack/storage/image/TemplateServiceImplTest.java
+++ 
b/engine/storage/image/src/test/java/org/apache/cloudstack/storage/image/TemplateServiceImplTest.java
@@ -81,4 +81,4 @@ public class TemplateServiceImplTest {
 Mockito.when(templateDataStoreDao.findByTemplateZone(id, id, 
DataStoreRole.Image)).thenReturn(Mockito.mock(TemplateDataStoreVO.class));
 
Assert.assertTrue(templateService.isSkipTemplateStoreDownload(templateVO, id));
 }
-}
\ No newline at end of file
+}

[GitHub] [cloudstack] weizhouapache merged pull request #7561: Fix end of file precommit for TemplateServiceImplTest.java

[via GitHub]

weizhouapache merged PR #7561:
URL: https://github.com/apache/cloudstack/pull/7561


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7403: api,server,ui: vr,systemvm in public ip response

[via GitHub]

blueorangutan commented on PR #7403:
URL: https://github.com/apache/cloudstack/pull/7403#issuecomment-1562714189

   Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 
:heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. 
SL-JID 6149


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #7561: Fix end of file precommit for TemplateServiceImplTest.java

[via GitHub]

weizhouapache commented on PR #7561:
URL: https://github.com/apache/cloudstack/pull/7561#issuecomment-1562675048

   @vishesh92 
   can you rebase with 4.18 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #7558: Fix acquire console session issue

[via GitHub]

nvazquez commented on PR #7558:
URL: https://github.com/apache/cloudstack/pull/7558#issuecomment-1562668878

   Thanks @shwstppr - I have refactored the logic to add the missing annotation


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on a diff in pull request #7558: Fix acquire console session issue

[via GitHub]

nvazquez commented on code in PR #7558:
URL: https://github.com/apache/cloudstack/pull/7558#discussion_r1205319874


##
engine/schema/src/main/java/com/cloud/vm/dao/ConsoleSessionDaoImpl.java:
##
@@ -60,9 +65,20 @@ public int expungeSessionsOlderThanDate(Date date) {
 
 @Override
 public void acquireSession(String sessionUuid) {
+TransactionLegacy txn = TransactionLegacy.currentTxn();
 ConsoleSessionVO consoleSessionVO = findByUuid(sessionUuid);
-consoleSessionVO.setAcquired(new Date());
-update(consoleSessionVO.getId(), consoleSessionVO);
+long consoleSessionId = consoleSessionVO.getId();
+try {
+txn.start();
+PreparedStatement preparedStatement = 
txn.prepareAutoCloseStatement(ACQUIRE_CONSOLE_SESSION);
+preparedStatement.setDate(1, new java.sql.Date(-1L));
+preparedStatement.setLong(2, consoleSessionId);
+preparedStatement.executeUpdate();
+txn.commit();
+} catch (Exception e) {
+txn.rollback();
+LOGGER.warn(String.format("Failed acquiring console session id = 
%s: %s", consoleSessionId, e.getMessage()), e);
+}

Review Comment:
   I've refactored after @shwstppr's suggestion



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #7558: Fix acquire console session issue

[via GitHub]

nvazquez commented on PR #7558:
URL: https://github.com/apache/cloudstack/pull/7558#issuecomment-1562668086

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] vishesh92 opened a new pull request, #7561: Fix end of file precommit for TemplateServiceImplTest.java

[via GitHub]

vishesh92 opened a new pull request, #7561:
URL: https://github.com/apache/cloudstack/pull/7561

   ### Description
   pre-commit github action is breaking currently. This PR fixes the end of 
file in 
`engine/storage/image/src/test/java/org/apache/cloudstack/storage/image/TemplateServiceImplTest.java`
 to fix that.
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [x] Trivial
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7313: server: improve storage GC to skip expunging possible duplicate volumes

[via GitHub]

blueorangutan commented on PR #7313:
URL: https://github.com/apache/cloudstack/pull/7313#issuecomment-1562629967

   Trillian Build Failed (tid-6589)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7515: Feature: Add unmanaged kubernetes cluster

[via GitHub]

blueorangutan commented on PR #7515:
URL: https://github.com/apache/cloudstack/pull/7515#issuecomment-1562629513

   Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 
:heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. 
SL-JID 6148


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7403: api,server,ui: vr,systemvm in public ip response

[via GitHub]

blueorangutan commented on PR #7403:
URL: https://github.com/apache/cloudstack/pull/7403#issuecomment-1562627071

   @rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It 
will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep 
you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7313: server: improve storage GC to skip expunging possible duplicate volumes

[via GitHub]

blueorangutan commented on PR #7313:
URL: https://github.com/apache/cloudstack/pull/7313#issuecomment-1562627007

   @rohityadavcloud a [SF] Trillian-Jenkins test job (centos7 mgmt + 
kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7313: server: improve storage GC to skip expunging possible duplicate volumes

[via GitHub]

rohityadavcloud commented on PR #7313:
URL: https://github.com/apache/cloudstack/pull/7313#issuecomment-1562625750

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7403: api,server,ui: vr,systemvm in public ip response

[via GitHub]

rohityadavcloud commented on PR #7403:
URL: https://github.com/apache/cloudstack/pull/7403#issuecomment-1562625348

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7479: cks: k8s cluster on vpc tier

[via GitHub]

blueorangutan commented on PR #7479:
URL: https://github.com/apache/cloudstack/pull/7479#issuecomment-1562624111

   Trillian Build Failed (tid-6584)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7508: guestos: add Windows Server 2022

[via GitHub]

blueorangutan commented on PR #7508:
URL: https://github.com/apache/cloudstack/pull/7508#issuecomment-1562624585

   Trillian Build Failed (tid-6585)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7479: cks: k8s cluster on vpc tier

[via GitHub]

blueorangutan commented on PR #7479:
URL: https://github.com/apache/cloudstack/pull/7479#issuecomment-1562621313

   @rohityadavcloud a [SF] Trillian-Jenkins test job (centos7 mgmt + 
kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7479: cks: k8s cluster on vpc tier

[via GitHub]

rohityadavcloud commented on PR #7479:
URL: https://github.com/apache/cloudstack/pull/7479#issuecomment-1562620689

   
   @blueorangutan test
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7508: guestos: add Windows Server 2022

[via GitHub]

rohityadavcloud commented on PR #7508:
URL: https://github.com/apache/cloudstack/pull/7508#issuecomment-1562619942

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[cloudstack] branch main updated (b0d7a20d5d2 -> 8ff0071becf)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


from b0d7a20d5d2 CONTRIBUTING.md: remove unneeded whitespace from start of 
code blocks (#7553)
 add 8ff0071becf ui,api: make description option for 
createKubernetesCluster (#7541)

No new revisions were added by this update.

Summary of changes:
 .../command/user/kubernetes/cluster/CreateKubernetesClusterCmd.java  | 5 +++--
 ui/src/views/compute/CreateKubernetesCluster.vue | 1 -
 2 files changed, 3 insertions(+), 3 deletions(-)

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7541: ui,api: make description option for createKubernetesCluster

[via GitHub]

rohityadavcloud commented on PR #7541:
URL: https://github.com/apache/cloudstack/pull/7541#issuecomment-1562617213

   Merged based on Github actions smoketests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud merged pull request #7541: ui,api: make description option for createKubernetesCluster

[via GitHub]

rohityadavcloud merged PR #7541:
URL: https://github.com/apache/cloudstack/pull/7541


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

[via GitHub]

weizhouapache commented on code in PR #7515:
URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1205223919


##
engine/schema/src/main/resources/META-INF/db/schema-41810to41900.sql:
##
@@ -135,3 +135,7 @@ CREATE VIEW `cloud`.`async_job_view` AS
 UPDATE `cloud`.`console_session` SET removed=now();
 -- Modify acquired column in console_session to datetime type
 ALTER TABLE `cloud`.`console_session` DROP `acquired`, ADD `acquired` datetime 
COMMENT 'When the session was acquired' AFTER `host_id`;
+
+ALTER TABLE `cloud`.`kubernetes_cluster` ADD COLUMN is_managed tinyint(1) 
DEFAULT 1;
+
+ALTER TABLE `cloud`.`kubernetes_cluster` MODIFY COLUMN `kubernetes_version_id` 
bigint unsigned NULL;

Review Comment:
   the field has a comment before, will the comment be removed after 
modification ?
   ```
 `kubernetes_version_id` bigint unsigned NOT NULL COMMENT 'the ID of the 
Kubernetes version of this Kubernetes cluster',
   ```



##
engine/schema/src/main/resources/META-INF/db/schema-41810to41900.sql:
##
@@ -135,3 +135,7 @@ CREATE VIEW `cloud`.`async_job_view` AS
 UPDATE `cloud`.`console_session` SET removed=now();
 -- Modify acquired column in console_session to datetime type
 ALTER TABLE `cloud`.`console_session` DROP `acquired`, ADD `acquired` datetime 
COMMENT 'When the session was acquired' AFTER `host_id`;
+
+ALTER TABLE `cloud`.`kubernetes_cluster` ADD COLUMN is_managed tinyint(1) 
DEFAULT 1;

Review Comment:
   add a comment to the new column ?



##
plugins/integrations/kubernetes-service/src/main/java/org/apache/cloudstack/api/command/user/kubernetes/cluster/RemoveVirtualMachinesFromKubernetesClusterCmd.java:
##
@@ -0,0 +1,99 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.user.kubernetes.cluster;
+
+import com.cloud.kubernetes.cluster.KubernetesClusterService;
+import com.cloud.utils.exception.CloudRuntimeException;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.KubernetesClusterResponse;
+import org.apache.cloudstack.api.response.SuccessResponse;
+import org.apache.cloudstack.api.response.UserVmResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.log4j.Logger;
+
+import javax.inject.Inject;
+import java.util.List;
+
+@APICommand(name = "removeVirtualMachinesFromKubernetesCluster",
+description = "Remove VMs from a kubernetes cluster",
+responseObject = SuccessResponse.class,
+since = "4.19.0",
+authorized = {RoleType.Admin, RoleType.ResourceAdmin, 
RoleType.DomainAdmin, RoleType.User})
+public class RemoveVirtualMachinesFromKubernetesClusterCmd extends BaseCmd {
+public static final Logger LOGGER = 
Logger.getLogger(RemoveVirtualMachinesFromKubernetesClusterCmd.class.getName());
+
+@Inject
+public KubernetesClusterService kubernetesClusterService;
+
+/
+ API parameters /
+/
+
+@Parameter(name = ApiConstants.ID, type = CommandType.UUID,
+entityType = KubernetesClusterResponse.class,
+required = true,
+description = "the ID of the Kubernetes cluster")
+private Long id;
+
+@Parameter(name = ApiConstants.VIRTUAL_MACHINE_IDS, type = 
CommandType.LIST,
+collectionType=CommandType.UUID,
+entityType = UserVmResponse.class,
+required = true,
+description = "the IDs of the VMs to remove from the cluster")
+private List vmIds;
+
+/
+/// Accessors ///
+/
+
+public Long getId() {
+return id;
+}
+
+public List getVmIds() {
+return vmIds;
+   

[cloudstack-go] branch main updated: Fix generation for UUID type (#60)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack-go.git


The following commit(s) were added to refs/heads/main by this push:
 new 1b7c54e  Fix generation for UUID type (#60)
1b7c54e is described below

commit 1b7c54ef714785807556438cf2fd50a2891aff9f
Author: Vishesh 
AuthorDate: Thu May 25 14:40:59 2023 +0530

Fix generation for UUID type (#60)
---
 generate/generate.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/generate/generate.go b/generate/generate.go
index 6ac962f..3f693ec 100644
--- a/generate/generate.go
+++ b/generate/generate.go
@@ -1291,7 +1291,7 @@ func (s *service) generateConvertCode(cmd, name, typ 
string) {
pn := s.pn
 
switch typ {
-   case "string":
+   case "string", "UUID":
pn("u.Set(\"%s\", v.(string))", name)
case "int":
pn("vv := strconv.Itoa(v.(int))")

[cloudstack-go] branch main updated: Fix spelling (#62)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack-go.git


The following commit(s) were added to refs/heads/main by this push:
 new 20cbd1c  Fix spelling (#62)
20cbd1c is described below

commit 20cbd1c8e949fa72243aa4c94724b2a1b11bcf8d
Author: John Bampton 
AuthorDate: Thu May 25 19:10:32 2023 +1000

Fix spelling (#62)
---
 cloudstack/NetworkService.go | 6 +++---
 cloudstack/cloudstack.go | 6 +++---
 generate/generate.go | 6 +++---
 generate/listApis.json   | 6 +++---
 4 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/cloudstack/NetworkService.go b/cloudstack/NetworkService.go
index ef913bd..70696e5 100644
--- a/cloudstack/NetworkService.go
+++ b/cloudstack/NetworkService.go
@@ -351,7 +351,7 @@ func (s *NetworkService) 
NewAddOpenDaylightControllerParams(password string, phy
return p
 }
 
-// Adds an OpenDyalight controler
+// Adds an OpenDaylight controller
 func (s *NetworkService) AddOpenDaylightController(p 
*AddOpenDaylightControllerParams) (*AddOpenDaylightControllerResponse, error) {
resp, err := s.cs.newRequest("addOpenDaylightController", 
p.toURLValues())
if err != nil {
@@ -2210,7 +2210,7 @@ func (s *NetworkService) 
NewDeleteOpenDaylightControllerParams(id string) *Delet
return p
 }
 
-// Removes an OpenDyalight controler
+// Removes an OpenDaylight controller
 func (s *NetworkService) DeleteOpenDaylightController(p 
*DeleteOpenDaylightControllerParams) (*DeleteOpenDaylightControllerResponse, 
error) {
resp, err := s.cs.newRequest("deleteOpenDaylightController", 
p.toURLValues())
if err != nil {
@@ -4034,7 +4034,7 @@ func (s *NetworkService) GetOpenDaylightControllerByID(id 
string, opts ...Option
return nil, l.Count, fmt.Errorf("There is more then one result for 
OpenDaylightController UUID: %s!", id)
 }
 
-// Lists OpenDyalight controllers
+// Lists OpenDaylight controllers
 func (s *NetworkService) ListOpenDaylightControllers(p 
*ListOpenDaylightControllersParams) (*ListOpenDaylightControllersResponse, 
error) {
resp, err := s.cs.newRequest("listOpenDaylightControllers", 
p.toURLValues())
if err != nil {
diff --git a/cloudstack/cloudstack.go b/cloudstack/cloudstack.go
index 31b1078..5efbe9f 100644
--- a/cloudstack/cloudstack.go
+++ b/cloudstack/cloudstack.go
@@ -446,21 +446,21 @@ func (cs *CloudStackClient) GetAsyncJobResult(jobid 
string, timeout int64) (json
 }
 
 // Execute the request against a CS API. Will return the raw JSON data 
returned by the API and nil if
-// no error occured. If the API returns an error the result will be nil and 
the HTTP error code and CS
+// no error occurred. If the API returns an error the result will be nil and 
the HTTP error code and CS
 // error details. If a processing (code) error occurs the result will be nil 
and the generated error
 func (cs *CloudStackClient) newRequest(api string, params url.Values) 
(json.RawMessage, error) {
return cs.newRawRequest(api, false, params)
 }
 
 // Execute the request against a CS API using POST. Will return the raw JSON 
data returned by the API and
-// nil if no error occured. If the API returns an error the result will be nil 
and the HTTP error code
+// nil if no error occurred. If the API returns an error the result will be 
nil and the HTTP error code
 // and CS error details. If a processing (code) error occurs the result will 
be nil and the generated error
 func (cs *CloudStackClient) newPostRequest(api string, params url.Values) 
(json.RawMessage, error) {
return cs.newRawRequest(api, true, params)
 }
 
 // Execute a raw request against a CS API. Will return the raw JSON data 
returned by the API and nil if
-// no error occured. If the API returns an error the result will be nil and 
the HTTP error code and CS
+// no error occurred. If the API returns an error the result will be nil and 
the HTTP error code and CS
 // error details. If a processing (code) error occurs the result will be nil 
and the generated error
 func (cs *CloudStackClient) newRawRequest(api string, post bool, params 
url.Values) (json.RawMessage, error) {
params.Set("apiKey", cs.apiKey)
diff --git a/generate/generate.go b/generate/generate.go
index 65ff684..6ac962f 100644
--- a/generate/generate.go
+++ b/generate/generate.go
@@ -515,21 +515,21 @@ func (as *allServices) GeneralCode() ([]byte, error) {
pn("}")
pn("")
pn("// Execute the request against a CS API. Will return the raw JSON 
data returned by the API and nil if")
-   pn("// no error occured. If the API returns an error the result will be 
nil and the HTTP error code and CS")
+   pn("// no error occurred. If the API returns an error the result will 
be nil and the HTTP error code and CS")
pn("// error details. If a processing (code) error occurs the result 
will be nil and the generated 

[GitHub] [cloudstack] blueorangutan commented on pull request #7515: Feature: Add unmanaged kubernetes cluster

[via GitHub]

blueorangutan commented on PR #7515:
URL: https://github.com/apache/cloudstack/pull/7515#issuecomment-1562535274

   @weizhouapache a [SF] Jenkins job has been kicked to build packages. It will 
be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #7515: Feature: Add unmanaged kubernetes cluster

[via GitHub]

weizhouapache commented on PR #7515:
URL: https://github.com/apache/cloudstack/pull/7515#issuecomment-1562532598

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #7160: vmware: do not create vm datastore when attach an existing volume on solidfire

[via GitHub]

DaanHoogland commented on PR #7160:
URL: https://github.com/apache/cloudstack/pull/7160#issuecomment-1562528635

   > > > > @weizhouapache will we merge this? it is not harming anything as far 
as we can see, and only solidfire users can test it for us.
   > > > 
   > > > 
   > > > @DaanHoogland I am ok with merging this. but you know, I am the author 
:-)
   > > 
   > > 
   > > yes, but you kept it in draft untill now, so I am checking with you 
anyway.
   > 
   > ah, moved it to "ready for review". I will merge this if there is no 
objection until the end of Friday
   
   ok, let's merge as you suggested but keep the issue open as @rohityadavcloud 
suggested until a solidfire user confirmed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7524: secondary-storage: delete backedup snapshot dir on delete

[via GitHub]

DaanHoogland commented on code in PR #7524:
URL: https://github.com/apache/cloudstack/pull/7524#discussion_r1205193638


##
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java:
##
@@ -1997,6 +1997,17 @@ private void savePostUploadPSK(String psk) {
 }
 }
 
+protected String getSnapshotFilepathForDelete(String path, String 
snapshotName) {
+String finalPath = path + "/*" + snapshotName + "*";
+if (!path.endsWith(snapshotName)) {
+return finalPath;
+}

Review Comment:
   ```suggestion
   if (!path.endsWith(snapshotName)) {
   return path + "/*" + snapshotName + "*";
   }
   ```



##
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java:
##
@@ -1997,6 +1997,17 @@ private void savePostUploadPSK(String psk) {
 }
 }
 
+protected String getSnapshotFilepathForDelete(String path, String 
snapshotName) {
+String finalPath = path + "/*" + snapshotName + "*";
+if (!path.endsWith(snapshotName)) {
+return finalPath;
+}
+if (s_logger.isDebugEnabled()) {
+s_logger.debug(String.format("Snapshot file %s is present in the 
same name directory %s. Deleting the directory", snapshotName, path));
+}
+return path;
+}

Review Comment:
   @weizhouapache @shwstppr , we are dealing with a `String`, not a 
`File`/directory. I think this is ok, in this place. checking for existence 
should not happen in this method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7524: secondary-storage: delete backedup snapshot dir on delete

[via GitHub]

blueorangutan commented on PR #7524:
URL: https://github.com/apache/cloudstack/pull/7524#issuecomment-1562515914

   @DaanHoogland a [LL] Trillian-Jenkins test job (rocky8 mgmt + vmware-67u3) 
has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[cloudstack-www] branch docusaurus-staging updated (a8cc606a -> 044369c6)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch docusaurus-staging
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git


from a8cc606a fix menus (hide while publishing blog)
 add 044369c6 use different config for blog

No new revisions were added by this update.

Summary of changes:
 docusaurus.config.js  | 133 ++-
 docusaurus.config.js.bk   | 275 --
 docusaurus.config.js => docusaurus.config.js.blog |   0
 3 files changed, 129 insertions(+), 279 deletions(-)
 delete mode 100644 docusaurus.config.js.bk
 copy docusaurus.config.js => docusaurus.config.js.blog (100%)

[cloudstack-www] branch docusaurus-staging updated (f5139729 -> a8cc606a)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch docusaurus-staging
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git


from f5139729 new blog post: cseug 2023 roundup
 add a8cc606a fix menus (hide while publishing blog)

No new revisions were added by this update.

Summary of changes:
 docusaurus.config.js| 133 +---
 docusaurus.config.js => docusaurus.config.js.bk |   0
 2 files changed, 4 insertions(+), 129 deletions(-)
 copy docusaurus.config.js => docusaurus.config.js.bk (100%)

[GitHub] [cloudstack] DaanHoogland commented on pull request #7524: secondary-storage: delete backedup snapshot dir on delete

[via GitHub]

DaanHoogland commented on PR #7524:
URL: https://github.com/apache/cloudstack/pull/7524#issuecomment-1562513490

   @blueorangutan LLtest rocky8 vmware-67u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7559: Create user 'cloud' in cloudstack-usage postinstall

[via GitHub]

blueorangutan commented on PR #7559:
URL: https://github.com/apache/cloudstack/pull/7559#issuecomment-1562506971

   Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 
:heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. 
SL-JID 6147


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org