[GitHub] [cloudstack] blueorangutan commented on pull request #7731: Default value of force should be false for template delete operation

2023-07-07 Thread via GitHub


blueorangutan commented on PR #7731:
URL: https://github.com/apache/cloudstack/pull/7731#issuecomment-1626878934

   [SF] Trillian test result (tid-7025)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 43285 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7731-t7025-kvm-centos7.zip
   Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_03_deploy_vm_wrong_checksum | `Error` | 40.69 | test_templates.py
   test_09_list_templates_download_details | `Failure` | 0.05 | 
test_templates.py
   test_01_migrate_VM_and_root_volume | `Error` | 79.89 | test_vm_life_cycle.py
   test_02_migrate_VM_with_two_data_disks | `Error` | 52.63 | 
test_vm_life_cycle.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] Hossein4185 commented on issue #7716: SystemVm Template

2023-07-07 Thread via GitHub


Hossein4185 commented on issue #7716:
URL: https://github.com/apache/cloudstack/issues/7716#issuecomment-1626842297

   I deleted the record but template zones status remains active
   
![system-vm](https://github.com/apache/cloudstack/assets/136463236/27c11df8-8be7-4476-a28a-907cd6ae7e76)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7643: Generate cloud-init multipart user data for template append policy

2023-07-07 Thread via GitHub


blueorangutan commented on PR #7643:
URL: https://github.com/apache/cloudstack/pull/7643#issuecomment-1626389962

   [SF] Trillian test result (tid-7017)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 41609 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7643-t7017-kvm-centos7.zip
   Smoke tests completed. 112 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_migrate_VM_and_root_volume | `Error` | 78.69 | test_vm_life_cycle.py
   test_02_migrate_VM_with_two_data_disks | `Error` | 56.38 | 
test_vm_life_cycle.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7728: Add MGMT IP in management.network.cidr as alternate name in their self-signed certificate

2023-07-07 Thread via GitHub


blueorangutan commented on PR #7728:
URL: https://github.com/apache/cloudstack/pull/7728#issuecomment-1625984413

   [SF] Trillian test result (tid-7016)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 42093 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7728-t7016-kvm-centos7.zip
   Smoke tests completed. 111 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_migrate_VM_and_root_volume | `Error` | 81.86 | test_vm_life_cycle.py
   test_02_migrate_VM_with_two_data_disks | `Error` | 57.55 | 
test_vm_life_cycle.py
   test_05_vmschedule_test_e2e | `Failure` | 170.63 | test_vm_schedule.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] benj-n commented on pull request #7719: Add L2 networks to Zones with SG

2023-07-07 Thread via GitHub


benj-n commented on PR #7719:
URL: https://github.com/apache/cloudstack/pull/7719#issuecomment-1625984252

   > @DaanHoogland yes, very nice feature with small changes. I'd like to add 
it to 4.18.1.0 , unless someone objects. @benj-n can you rebase with 4.18 ?
   
   It's now rebased on 4.18.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] github-actions[bot] commented on pull request #7226: [VMware] apply IOPS in resize/migrate

2023-07-07 Thread via GitHub


github-actions[bot] commented on PR #7226:
URL: https://github.com/apache/cloudstack/pull/7226#issuecomment-1625980619

   This pull request has merge conflicts. Dear author, please fix the conflicts 
and sync your branch with the base branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] github-actions[bot] commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19

2023-07-07 Thread via GitHub


github-actions[bot] commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1625980554

   This pull request has merge conflicts. Dear author, please fix the conflicts 
and sync your branch with the base branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] github-actions[bot] commented on pull request #6892: Externalize KVM HA heartbeat frequency

2023-07-07 Thread via GitHub


github-actions[bot] commented on PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1625980482

   This pull request has merge conflicts. Dear author, please fix the conflicts 
and sync your branch with the base branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7344: [HEALTH] 4.19/main Health Check, please don't merge this!

2023-07-07 Thread via GitHub


sonarcloud[bot] commented on PR #7344:
URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1625917872

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack=7344)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7344=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7344=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7344=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7344=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7344=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7344=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7344=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7344=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7344=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7344=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7344=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7344=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_cloudstack=7344=coverage=list)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=apache_cloudstack=7344=duplicated_lines_density=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7345: [HEALTH] 4.18 LTS Health Check, please don't merge this!

2023-07-07 Thread via GitHub


sonarcloud[bot] commented on PR #7345:
URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1625910713

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack=7345)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7345=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7345=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7345=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7345=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7345=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7345=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7345=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7345=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7345=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7345=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7345=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7345=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_cloudstack=7345=coverage=list)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=apache_cloudstack=7345=duplicated_lines_density=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] benj-n commented on pull request #7719: Add L2 networks to Zones with SG

2023-07-07 Thread via GitHub


benj-n commented on PR #7719:
URL: https://github.com/apache/cloudstack/pull/7719#issuecomment-1625876377

   > btw: did you create the L2 network with specified vlan id ?
   
   Yes. Unfortunately, I can only have tagged traffic on the specific L2 
network I have for testing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19

2023-07-07 Thread via GitHub


blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1625857300

   Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_multiplication_x: 
el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian 
:heavy_multiplication_x: suse15. SL-JID 6440


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7733: test: fix ci failures on main branch

2023-07-07 Thread via GitHub


blueorangutan commented on PR #7733:
URL: https://github.com/apache/cloudstack/pull/7733#issuecomment-1625828348

   Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 
:heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. 
SL-JID 6438


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7722: unalias cp before package upgrade

2023-07-07 Thread via GitHub


blueorangutan commented on PR #7722:
URL: https://github.com/apache/cloudstack/pull/7722#issuecomment-1625794562

   [SF] Trillian test result (tid-7022)
   Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
   Total time taken: 747 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7722-t7022-kvm-rocky8.zip
   Smoke tests completed. 0 look OK, 0 have errors, 113 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   all_test_safe_shutdown | `Skipped` | --- | test_safe_shutdown.py
   all_test_scale_vm | `Skipped` | --- | test_scale_vm.py
   all_test_2fa | `Skipped` | --- | test_2fa.py
   all_test_regions | `Skipped` | --- | test_regions.py
   all_test_accounts | `Skipped` | --- | test_accounts.py
   all_test_nonstrict_affinity_group | `Skipped` | --- | 
test_nonstrict_affinity_group.py
   all_test_affinity_groups | `Skipped` | --- | test_affinity_groups.py
   all_test_internal_lb | `Skipped` | --- | test_internal_lb.py
   all_test_usage | `Skipped` | --- | test_usage.py
   all_test_affinity_groups_projects | `Skipped` | --- | 
test_affinity_groups_projects.py
   all_test_register_userdata | `Skipped` | --- | test_register_userdata.py
   all_test_annotations | `Skipped` | --- | test_annotations.py
   all_test_reset_vm_on_reboot | `Skipped` | --- | test_reset_vm_on_reboot.py
   all_test_async_job | `Skipped` | --- | test_async_job.py
   all_test_ipv6_infra | `Skipped` | --- | test_ipv6_infra.py
   all_test_attach_multiple_volumes | `Skipped` | --- | 
test_attach_multiple_volumes.py
   all_test_kubernetes_clusters | `Skipped` | --- | test_kubernetes_clusters.py
   all_test_backup_recovery_dummy | `Skipped` | --- | 
test_backup_recovery_dummy.py
   all_test_outofbandmanagement | `Skipped` | --- | test_outofbandmanagement.py
   all_test_certauthority_root | `Skipped` | --- | test_certauthority_root.py
   all_test_over_provisioning | `Skipped` | --- | test_over_provisioning.py
   all_test_console_endpoint | `Skipped` | --- | test_console_endpoint.py
   all_test_set_sourcenat | `Skipped` | --- | test_set_sourcenat.py
   all_test_create_list_domain_account_project | `Skipped` | --- | 
test_create_list_domain_account_project.py
   all_test_password_server | `Skipped` | --- | test_password_server.py
   all_test_create_network | `Skipped` | --- | test_create_network.py
   all_test_iso | `Skipped` | --- | test_iso.py
   all_test_snapshots | `Skipped` | --- | test_snapshots.py
   all_test_deploy_vgpu_enabled_vm | `Skipped` | --- | 
test_deploy_vgpu_enabled_vm.py
   all_test_migration | `Skipped` | --- | test_migration.py
   all_test_deploy_virtio_scsi_vm | `Skipped` | --- | 
test_deploy_virtio_scsi_vm.py
   all_test_multipleips_per_nic | `Skipped` | --- | test_multipleips_per_nic.py
   all_test_deploy_vm_extra_config_data | `Skipped` | --- | 
test_deploy_vm_extra_config_data.py
   all_test_persistent_network | `Skipped` | --- | test_persistent_network.py
   all_test_deploy_vm_iso | `Skipped` | --- | test_deploy_vm_iso.py
   all_test_portable_publicip | `Skipped` | --- | test_portable_publicip.py
   all_test_deploy_vm_iso_uefi | `Skipped` | --- | test_deploy_vm_iso_uefi.py
   all_test_nested_virtualization | `Skipped` | --- | 
test_nested_virtualization.py
   all_test_deploy_vm_root_resize | `Skipped` | --- | 
test_deploy_vm_root_resize.py
   all_test_network | `Skipped` | --- | test_network.py
   all_test_deploy_vm_with_userdata | `Skipped` | --- | 
test_deploy_vm_with_userdata.py
   all_test_network_acl | `Skipped` | --- | test_network_acl.py
   all_test_deploy_vms_in_parallel | `Skipped` | --- | 
test_deploy_vms_in_parallel.py
   all_test_ssvm | `Skipped` | --- | test_ssvm.py
   all_test_deploy_vms_with_varied_deploymentplanners | `Skipped` | --- | 
test_deploy_vms_with_varied_deploymentplanners.py
   all_test_resource_accounting | `Skipped` | --- | test_resource_accounting.py
   all_test_diagnostics | `Skipped` | --- | test_diagnostics.py
   all_test_portforwardingrules | `Skipped` | --- | test_portforwardingrules.py
   all_test_direct_download | `Skipped` | --- | test_direct_download.py
   all_test_primary_storage | `Skipped` | --- | test_primary_storage.py
   all_test_disk_offerings | `Skipped` | --- | test_disk_offerings.py
   all_test_network_ipv6 | `Skipped` | --- | test_network_ipv6.py
   all_test_disk_provisioning_types | `Skipped` | --- | 
test_disk_provisioning_types.py
   all_test_network_permissions | `Skipped` | --- | test_network_permissions.py
   all_test_domain_disk_offerings | `Skipped` | --- | 
test_domain_disk_offerings.py
   all_test_nic | `Skipped` | --- | test_nic.py
   all_test_staticroles | `Skipped` | --- | test_staticroles.py
   all_test_domain_network_offerings | `Skipped` | --- | 
test_domain_network_offerings.py
   all_test_nic_adapter_type | `Skipped` | --- | test_nic_adapter_type.py
   all_test_domain_service_offerings | `Skipped` | --- 

[GitHub] [cloudstack] blueorangutan commented on pull request #7344: [HEALTH] 4.19/main Health Check, please don't merge this!

2023-07-07 Thread via GitHub


blueorangutan commented on PR #7344:
URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1625791824

   @rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It 
will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep 
you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19

2023-07-07 Thread via GitHub


blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1625791745

   @rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It 
will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep 
you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] rohityadavcloud commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19

2023-07-07 Thread via GitHub


rohityadavcloud commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1625780200

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.18'

2023-07-07 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 5383bf64f43b19ef3b234853f42bad03130ea647
Merge: c956d329f5d f0cc76a3a82
Author: Rohit Yadav 
AuthorDate: Fri Jul 7 23:04:44 2023 +0530

Merge remote-tracking branch 'origin/4.18'

Signed-off-by: Rohit Yadav 

 .../cloud/agent/properties/AgentProperties.java|  7 ++
 .../agent/api/GetUnmanagedInstancesCommand.java|  4 +++-
 .../hypervisor/kvm/resource/BridgeVifDriver.java   |  5 +---
 .../hypervisor/kvm/resource/IvsVifDriver.java  |  6 +
 .../hypervisor/kvm/resource/OvsVifDriver.java  |  5 +---
 .../hypervisor/kvm/resource/VifDriverBase.java |  7 ++
 .../hypervisor/vmware/resource/VmwareResource.java | 28 --
 7 files changed, 36 insertions(+), 26 deletions(-)

diff --cc 
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
index 222d3ffb2ee,8b833b8221a..90bfdd6793c
--- 
a/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
+++ 
b/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
@@@ -82,6 -73,6 +73,8 @@@ import com.cloud.agent.api.AttachIsoAns
  import com.cloud.agent.api.AttachIsoCommand;
  import com.cloud.agent.api.BackupSnapshotAnswer;
  import com.cloud.agent.api.BackupSnapshotCommand;
++import com.cloud.agent.api.CheckGuestOsMappingAnswer;
++import com.cloud.agent.api.CheckGuestOsMappingCommand;
  import com.cloud.agent.api.CheckHealthAnswer;
  import com.cloud.agent.api.CheckHealthCommand;
  import com.cloud.agent.api.CheckNetworkAnswer;
@@@ -103,6 -94,6 +96,8 @@@ import com.cloud.agent.api.DeleteVMSnap
  import com.cloud.agent.api.DeleteVMSnapshotCommand;
  import com.cloud.agent.api.GetHostStatsAnswer;
  import com.cloud.agent.api.GetHostStatsCommand;
++import com.cloud.agent.api.GetHypervisorGuestOsNamesAnswer;
++import com.cloud.agent.api.GetHypervisorGuestOsNamesCommand;
  import com.cloud.agent.api.GetStoragePoolCapabilitiesAnswer;
  import com.cloud.agent.api.GetStoragePoolCapabilitiesCommand;
  import com.cloud.agent.api.GetStorageStatsAnswer;



[GitHub] [cloudstack] rohityadavcloud closed issue #7574: kvm: Agent does not honor control.cidr anymore

2023-07-07 Thread via GitHub


rohityadavcloud closed issue #7574: kvm: Agent does not honor control.cidr 
anymore
URL: https://github.com/apache/cloudstack/issues/7574


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[cloudstack] branch main updated (c956d329f5d -> 5383bf64f43)

2023-07-07 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


from c956d329f5d Fix test_vm_schedule's intermittent failures (#7726)
 add 2752c49fa72 agent: get the right controll cidr (#7580)
 add f0cc76a3a82 vmware: fix unmanaged instance listing when different name 
& internal CS name (#7641)
 new 5383bf64f43 Merge remote-tracking branch 'origin/4.18'

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../cloud/agent/properties/AgentProperties.java|  7 ++
 .../agent/api/GetUnmanagedInstancesCommand.java|  4 +++-
 .../hypervisor/kvm/resource/BridgeVifDriver.java   |  5 +---
 .../hypervisor/kvm/resource/IvsVifDriver.java  |  6 +
 .../hypervisor/kvm/resource/OvsVifDriver.java  |  5 +---
 .../hypervisor/kvm/resource/VifDriverBase.java |  7 ++
 .../hypervisor/vmware/resource/VmwareResource.java | 28 --
 7 files changed, 36 insertions(+), 26 deletions(-)



[GitHub] [cloudstack] rohityadavcloud closed pull request #7345: [HEALTH] 4.18 LTS Health Check, please don't merge this!

2023-07-07 Thread via GitHub


rohityadavcloud closed pull request #7345: [HEALTH] 4.18 LTS Health Check, 
please don't merge this!
URL: https://github.com/apache/cloudstack/pull/7345


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] rohityadavcloud closed pull request #7344: [HEALTH] 4.19/main Health Check, please don't merge this!

2023-07-07 Thread via GitHub


rohityadavcloud closed pull request #7344: [HEALTH] 4.19/main Health Check, 
please don't merge this!
URL: https://github.com/apache/cloudstack/pull/7344


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7345: [HEALTH] 4.18 LTS Health Check, please don't merge this!

2023-07-07 Thread via GitHub


blueorangutan commented on PR #7345:
URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1625729778

   @rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It 
will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep 
you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7731: Default value of force should be false for template delete operation

2023-07-07 Thread via GitHub


blueorangutan commented on PR #7731:
URL: https://github.com/apache/cloudstack/pull/7731#issuecomment-1625725627

   @rohityadavcloud a [SF] Trillian-Jenkins test job (centos7 mgmt + 
kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[cloudstack] branch 4.18 updated: vmware: fix unmanaged instance listing when different name & internal CS name (#7641)

2023-07-07 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.18
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.18 by this push:
 new f0cc76a3a82 vmware: fix unmanaged instance listing when different name 
& internal CS name (#7641)
f0cc76a3a82 is described below

commit f0cc76a3a824fb4c34ce07230557c2c5107131fa
Author: Abhishek Kumar 
AuthorDate: Fri Jul 7 23:00:25 2023 +0530

vmware: fix unmanaged instance listing when different name & internal CS 
name (#7641)

Currently, ACS can continue to show an imported instance/VM as an unmanaged 
instance if the name and internalCSName (custom attribute, 
cloud.vm.internal.name) is different for the instance/VM on vCenter. This PR 
while filtering managed instances from the instance list received from ESXi 
host also checks if the internal name for the instance is not in the managed 
instance names list.

Signed-off-by: Abhishek Kumar 
---
 .../agent/api/GetUnmanagedInstancesCommand.java  |  4 +++-
 .../hypervisor/vmware/resource/VmwareResource.java   | 20 
 2 files changed, 15 insertions(+), 9 deletions(-)

diff --git 
a/core/src/main/java/com/cloud/agent/api/GetUnmanagedInstancesCommand.java 
b/core/src/main/java/com/cloud/agent/api/GetUnmanagedInstancesCommand.java
index 968c58611bb..2cd80aebea1 100644
--- a/core/src/main/java/com/cloud/agent/api/GetUnmanagedInstancesCommand.java
+++ b/core/src/main/java/com/cloud/agent/api/GetUnmanagedInstancesCommand.java
@@ -19,6 +19,8 @@ package com.cloud.agent.api;
 
 import java.util.List;
 
+import org.apache.commons.collections.CollectionUtils;
+
 /**
  * Unmanaged instances are those virtual machines which are present at 
hypervisor end but not available in CloudStack.
  * Such virtual machines might have been created out of band, directly from 
hypervisor.
@@ -56,7 +58,7 @@ public class GetUnmanagedInstancesCommand extends Command {
 }
 
 public boolean hasManagedInstance(String name) {
-if (managedInstancesNames!=null && !managedInstancesNames.isEmpty()) {
+if (CollectionUtils.isNotEmpty(managedInstancesNames)) {
 return managedInstancesNames.contains(name);
 }
 return false;
diff --git 
a/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 
b/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
index aa26f63b3a9..8b833b8221a 100644
--- 
a/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
+++ 
b/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
@@ -38,6 +38,7 @@ import java.util.HashMap;
 import java.util.HashSet;
 import java.util.List;
 import java.util.Map;
+import java.util.Objects;
 import java.util.Random;
 import java.util.Set;
 import java.util.TimeZone;
@@ -47,12 +48,6 @@ import java.util.stream.Collectors;
 import javax.naming.ConfigurationException;
 import javax.xml.datatype.XMLGregorianCalendar;
 
-import com.cloud.agent.api.PatchSystemVmAnswer;
-import com.cloud.agent.api.PatchSystemVmCommand;
-import com.cloud.resource.ServerResourceBase;
-import com.cloud.utils.FileUtil;
-import com.cloud.utils.LogUtils;
-import com.cloud.utils.validation.ChecksumUtil;
 import org.apache.cloudstack.api.ApiConstants;
 import org.apache.cloudstack.storage.command.CopyCommand;
 import org.apache.cloudstack.storage.command.StorageSubSystemCommand;
@@ -66,8 +61,8 @@ import org.apache.cloudstack.vm.UnmanagedInstanceTO;
 import org.apache.commons.collections.CollectionUtils;
 import org.apache.commons.collections.MapUtils;
 import org.apache.commons.lang.ArrayUtils;
-import org.apache.commons.lang3.StringUtils;
 import org.apache.commons.lang.math.NumberUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.apache.log4j.Logger;
 import org.apache.log4j.NDC;
 import org.joda.time.Duration;
@@ -137,6 +132,8 @@ import com.cloud.agent.api.ModifyTargetsAnswer;
 import com.cloud.agent.api.ModifyTargetsCommand;
 import com.cloud.agent.api.NetworkUsageAnswer;
 import com.cloud.agent.api.NetworkUsageCommand;
+import com.cloud.agent.api.PatchSystemVmAnswer;
+import com.cloud.agent.api.PatchSystemVmCommand;
 import com.cloud.agent.api.PingCommand;
 import com.cloud.agent.api.PingRoutingCommand;
 import com.cloud.agent.api.PingTestCommand;
@@ -260,6 +257,7 @@ import com.cloud.network.Networks.TrafficType;
 import com.cloud.network.VmwareTrafficLabel;
 import com.cloud.network.router.VirtualRouterAutoScale;
 import com.cloud.resource.ServerResource;
+import com.cloud.resource.ServerResourceBase;
 import com.cloud.serializer.GsonHelper;
 import com.cloud.storage.Storage;
 import com.cloud.storage.Storage.StoragePoolType;
@@ -274,6 +272,8 @@ import com.cloud.storage.template.TemplateProp;
 import com.cloud.template.TemplateManager;
 

[GitHub] [cloudstack] rohityadavcloud merged pull request #7641: vmware: fix unmanaged instance listing when different name & internal CS name

2023-07-07 Thread via GitHub


rohityadavcloud merged PR #7641:
URL: https://github.com/apache/cloudstack/pull/7641


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] rohityadavcloud commented on pull request #7731: Default value of force should be false for template delete operation

2023-07-07 Thread via GitHub


rohityadavcloud commented on PR #7731:
URL: https://github.com/apache/cloudstack/pull/7731#issuecomment-1625723402

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] rohityadavcloud commented on pull request #7564: make NoopDbUpgrade do a systemvm template check

2023-07-07 Thread via GitHub


rohityadavcloud commented on PR #7564:
URL: https://github.com/apache/cloudstack/pull/7564#issuecomment-1625722424

   Needs another review and perhaps testing, LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7656: allow migration of all VMs with local storage on KVM

2023-07-07 Thread via GitHub


blueorangutan commented on PR #7656:
URL: https://github.com/apache/cloudstack/pull/7656#issuecomment-1625721575

   @rohityadavcloud a [SF] Trillian-Jenkins test job (centos7 mgmt + 
kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7634: guarantee MAC uniqueness

2023-07-07 Thread via GitHub


blueorangutan commented on PR #7634:
URL: https://github.com/apache/cloudstack/pull/7634#issuecomment-1625721537

   @rohityadavcloud a [SF] Trillian-Jenkins test job (centos7 mgmt + 
kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[cloudstack] branch 4.18 updated: agent: get the right controll cidr (#7580)

2023-07-07 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.18
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.18 by this push:
 new 2752c49fa72 agent: get the right controll cidr (#7580)
2752c49fa72 is described below

commit 2752c49fa72a1bfa50b6886c2249d493a0e235a9
Author: dahn 
AuthorDate: Fri Jul 7 19:27:58 2023 +0200

agent: get the right controll cidr (#7580)

Fixes: #7574
---
 .../src/main/java/com/cloud/agent/properties/AgentProperties.java  | 7 +++
 .../java/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java| 5 +
 .../main/java/com/cloud/hypervisor/kvm/resource/IvsVifDriver.java  | 6 +-
 .../main/java/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java  | 5 +
 .../main/java/com/cloud/hypervisor/kvm/resource/VifDriverBase.java | 7 +++
 5 files changed, 17 insertions(+), 13 deletions(-)

diff --git 
a/agent/src/main/java/com/cloud/agent/properties/AgentProperties.java 
b/agent/src/main/java/com/cloud/agent/properties/AgentProperties.java
index 9a031e001fa..5c7f4ed4b23 100644
--- a/agent/src/main/java/com/cloud/agent/properties/AgentProperties.java
+++ b/agent/src/main/java/com/cloud/agent/properties/AgentProperties.java
@@ -721,6 +721,13 @@ public class AgentProperties{
  */
 public static final Property IOTHREADS = new 
Property<>("iothreads", 1);
 
+/**
+ * BGP controll CIDR
+ * Data type: String.
+ * Default value: 169.254.0.0/16
+ */
+public static final Property CONTROL_CIDR = new 
Property<>("control.cidr", "169.254.0.0/16");
+
 public static class Property {
 private String name;
 private T defaultValue;
diff --git 
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
 
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
index 8d8271a2fbe..39ecc9182f0 100644
--- 
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
+++ 
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
@@ -65,10 +65,7 @@ public class BridgeVifDriver extends VifDriverBase {
 
 String networkScriptsDir = 
AgentPropertiesFileHandler.getPropertyValue(AgentProperties.NETWORK_SCRIPTS_DIR);
 
-String controlCidr = (String)params.get("control.cidr");
-if (StringUtils.isNotBlank(controlCidr)) {
-_controlCidr = controlCidr;
-}
+_controlCidr = getControlCidr(_controlCidr);
 
 String value = (String)params.get("scripts.timeout");
 _timeout = NumbersUtil.parseInt(value, 30 * 60) * 1000;
diff --git 
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/IvsVifDriver.java
 
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/IvsVifDriver.java
index c0dceb3832d..178728b7f96 100644
--- 
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/IvsVifDriver.java
+++ 
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/IvsVifDriver.java
@@ -26,7 +26,6 @@ import java.util.regex.Pattern;
 
 import javax.naming.ConfigurationException;
 
-import org.apache.commons.lang3.StringUtils;
 import org.apache.log4j.Logger;
 import org.libvirt.LibvirtException;
 
@@ -71,10 +70,7 @@ public class IvsVifDriver extends VifDriverBase {
 }
 _ivsIfUpPath = Script.findScript(utilScriptsDir, "qemu-ivs-ifup");
 
-String controlCidr = (String)params.get("control.cidr");
-if (StringUtils.isNotBlank(controlCidr)) {
-_controlCidr = controlCidr;
-}
+_controlCidr = getControlCidr(_controlCidr);
 }
 
 @Override
diff --git 
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java
 
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java
index c6867b3c146..3c4c9d48c9d 100644
--- 
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java
+++ 
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java
@@ -60,10 +60,7 @@ public class OvsVifDriver extends VifDriverBase {
 dpdkDriver = new DpdkDriverImpl();
 }
 
-String controlCidr = (String)params.get("control.cidr");
-if (StringUtils.isNotBlank(controlCidr)) {
-_controlCidr = controlCidr;
-}
+_controlCidr = getControlCidr(_controlCidr);
 
 String value = (String)params.get("scripts.timeout");
 _timeout = NumbersUtil.parseInt(value, 30 * 60) * 1000;
diff --git 
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/VifDriverBase.java
 
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/VifDriverBase.java
index 77aeec55459..b3ae4c1d704 100644
--- 

[GitHub] [cloudstack] rohityadavcloud merged pull request #7580: kvm agent: get the right controll cidr

2023-07-07 Thread via GitHub


rohityadavcloud merged PR #7580:
URL: https://github.com/apache/cloudstack/pull/7580


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] rohityadavcloud commented on pull request #7634: guarantee MAC uniqueness

2023-07-07 Thread via GitHub


rohityadavcloud commented on PR #7634:
URL: https://github.com/apache/cloudstack/pull/7634#issuecomment-1625720025

   ping @shwstppr @nvazquez for review
   @blueorangutan test 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] rohityadavcloud commented on pull request #7656: allow migration of all VMs with local storage on KVM

2023-07-07 Thread via GitHub


rohityadavcloud commented on PR #7656:
URL: https://github.com/apache/cloudstack/pull/7656#issuecomment-1625719542

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] rohityadavcloud commented on pull request #7722: unalias cp before package upgrade

2023-07-07 Thread via GitHub


rohityadavcloud commented on PR #7722:
URL: https://github.com/apache/cloudstack/pull/7722#issuecomment-1625719082

   
   @blueorangutan test rocky8 kvm-rocky8
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7733: test: fix ci failures on main branch

2023-07-07 Thread via GitHub


blueorangutan commented on PR #7733:
URL: https://github.com/apache/cloudstack/pull/7733#issuecomment-1625715649

   @rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It 
will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep 
you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[cloudstack] branch main updated: Fix test_vm_schedule's intermittent failures (#7726)

2023-07-07 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/main by this push:
 new c956d329f5d Fix test_vm_schedule's intermittent failures (#7726)
c956d329f5d is described below

commit c956d329f5dfc6cb682b1a91bb9ec8b552512ea5
Author: Vishesh 
AuthorDate: Fri Jul 7 22:51:38 2023 +0530

Fix test_vm_schedule's intermittent failures (#7726)

* Fix test_vm_schedule's intermittent failures

* Add smoke/test_vm_schedule to CI
---
 .github/workflows/ci.yml   |  1 +
 test/integration/smoke/test_vm_schedule.py | 13 -
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 731b514a542..d0061cb19af 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -125,6 +125,7 @@ jobs:
   smoke/test_usage
   smoke/test_usage_events
   smoke/test_vm_deployment_planner
+  smoke/test_vm_schedule
   smoke/test_vm_life_cycle
   smoke/test_vm_lifecycle_unmanage_import
   smoke/test_vm_snapshot_kvm
diff --git a/test/integration/smoke/test_vm_schedule.py 
b/test/integration/smoke/test_vm_schedule.py
index 87a5b0a9907..e66470dff73 100644
--- a/test/integration/smoke/test_vm_schedule.py
+++ b/test/integration/smoke/test_vm_schedule.py
@@ -530,13 +530,13 @@ class TestVMSchedule(cloudstackTestCase):
 )
 self.assertNotEqual(len(vmschedules), 0, "Check VM Schedule is 
created")
 
-# poll every 20 seconds (max waiting time is 4 minutes ) and check 
VM's state for changes
+# poll every 10 seconds (max waiting time is 6 minutes) and check VM's 
state for changes
 previous_state = self.virtual_machine.state
 self.debug("VM state: %s" % self.virtual_machine.state)
 is_stop_schedule_working = False
 is_start_schedule_working = False
-for i in range(0, 12):
-time.sleep(20)
+for i in range(0, 36):
+time.sleep(10)
 current_state = self.virtual_machine.update(self.apiclient).state
 self.debug("Polling VM state: %s" % current_state)
 if previous_state in ("Running", "Starting") and current_state in (
@@ -570,6 +570,9 @@ class TestVMSchedule(cloudstackTestCase):
 start_vmschedule.delete(self.apiclient)
 stop_vmschedule.delete(self.apiclient)
 
+# To ensure that all vm schedules have been deleted and all of their 
jobs have been completed
+time.sleep(15)
+
 # Verify VM Schedule is deleted
 self.assertEqual(
 VMSchedule.list(
@@ -586,10 +589,10 @@ class TestVMSchedule(cloudstackTestCase):
 "Check VM Schedule is deleted",
 )
 
-# Verify VM does not switch states after deleting schedules at least 
for 1.5 minutes
+# Verify VM does not switch states after deleting schedules at least 
for 2 minutes
 previous_state = self.virtual_machine.update(self.apiclient).state
 state_changed = False
-for i in range(0, 3):
+for i in range(0, 4):
 time.sleep(30)
 current_state = self.virtual_machine.update(self.apiclient).state
 if previous_state != current_state:



[GitHub] [cloudstack] blueorangutan commented on pull request #7735: Set encrypted PowerFlex disk format correctly

2023-07-07 Thread via GitHub


blueorangutan commented on PR #7735:
URL: https://github.com/apache/cloudstack/pull/7735#issuecomment-1625715602

   @rohityadavcloud a [SF] Trillian-Jenkins test job (centos7 mgmt + 
kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] rohityadavcloud merged pull request #7726: Fix test_vm_schedule's intermittent failures

2023-07-07 Thread via GitHub


rohityadavcloud merged PR #7726:
URL: https://github.com/apache/cloudstack/pull/7726


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] rohityadavcloud commented on pull request #7735: Set encrypted PowerFlex disk format correctly

2023-07-07 Thread via GitHub


rohityadavcloud commented on PR #7735:
URL: https://github.com/apache/cloudstack/pull/7735#issuecomment-1625714752

   @blueorangutan test
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] rohityadavcloud commented on pull request #7733: test: fix ci failures on main branch

2023-07-07 Thread via GitHub


rohityadavcloud commented on PR #7733:
URL: https://github.com/apache/cloudstack/pull/7733#issuecomment-1625714443

   @blueorangutan package
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] NuxRo commented on pull request #7719: Add L2 networks to Zones with SG

2023-07-07 Thread via GitHub


NuxRo commented on PR #7719:
URL: https://github.com/apache/cloudstack/pull/7719#issuecomment-1625687387

   Great feature. Did a bit of testing and largely my findings are similar to 
those of Wei, ie the VM gets connected in the appropriate L2 network, but no 
iptables or ebtables rules are set up for it, so far so good.
   
   A few notes:
   
   1 - network traffic between machines on separate HVs worked because iptables 
defaults to ACCEPT for INPUT, FORWARD and OUTPUT. If an operator makes changes 
there it will result in issues. This is just FYI, I am not saying we should do 
any action in this kind of scenarios.
   
   2 - Creating a VM _only_ on an L2 network is not possible currently, 
Cloudstack returns:
   ```Can specify only Shared Guest networks when deploy vm in Advance Security 
Group enabled zone```
   It would be **GREAT** if the feature allowed L2-only!
   
   3 - Network offering "Offering for L2 networks" did not produce a functional 
VM deployment for me, had to go for "Offering for L2 networks VLAN" and specify 
a VLAN. Not a major issue, but worth keeping in mind.
   
   4 - Last but NOT least, unlike Shared networks, the scope of L2 networks is 
_account_, so there can't be an expectation for multiple accounts to be able to 
connect in the same network. Just making sure we're aware of this. :)
   
   Looking forward to having this feature in Cloudstack!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7726: Fix test_vm_schedule's intermittent failures

2023-07-07 Thread via GitHub


blueorangutan commented on PR #7726:
URL: https://github.com/apache/cloudstack/pull/7726#issuecomment-1625662172

   [SF] Trillian test result (tid-7014)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 43377 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7726-t7014-kvm-centos7.zip
   Smoke tests completed. 112 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_migrate_VM_and_root_volume | `Error` | 79.70 | test_vm_life_cycle.py
   test_02_migrate_VM_with_two_data_disks | `Error` | 56.51 | 
test_vm_life_cycle.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7735: Set encrypted PowerFlex disk format correctly

2023-07-07 Thread via GitHub


blueorangutan commented on PR #7735:
URL: https://github.com/apache/cloudstack/pull/7735#issuecomment-1625656353

   Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 
:heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. 
SL-JID 6437


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7735: Set encrypted PowerFlex disk format correctly

2023-07-07 Thread via GitHub


blueorangutan commented on PR #7735:
URL: https://github.com/apache/cloudstack/pull/7735#issuecomment-1625590835

   @rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It 
will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep 
you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] rohityadavcloud commented on pull request #7735: Set encrypted PowerFlex disk format correctly

2023-07-07 Thread via GitHub


rohityadavcloud commented on PR #7735:
URL: https://github.com/apache/cloudstack/pull/7735#issuecomment-1625590421

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[cloudstack] branch main updated: Fix lint errors (#7727)

2023-07-07 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/main by this push:
 new d2cd3c81cbf Fix lint errors (#7727)
d2cd3c81cbf is described below

commit d2cd3c81cbf5a81580ef31f2d1195ab8cceb5ba5
Author: Vishesh 
AuthorDate: Fri Jul 7 21:02:42 2023 +0530

Fix lint errors (#7727)
---
 .../cloudstack/api/agent/test/CheckGuestOsMappingCommandTest.java   | 2 +-
 .../wrapper/xenbase/CitrixCheckGuestOsMappingCommandWrapper.java| 2 +-
 .../wrapper/xenbase/CitrixGetHypervisorGuestOsNamesCommandWrapper.java  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/core/src/test/java/org/apache/cloudstack/api/agent/test/CheckGuestOsMappingCommandTest.java
 
b/core/src/test/java/org/apache/cloudstack/api/agent/test/CheckGuestOsMappingCommandTest.java
index d92f3a4f5b4..3f68422d502 100644
--- 
a/core/src/test/java/org/apache/cloudstack/api/agent/test/CheckGuestOsMappingCommandTest.java
+++ 
b/core/src/test/java/org/apache/cloudstack/api/agent/test/CheckGuestOsMappingCommandTest.java
@@ -43,4 +43,4 @@ public class CheckGuestOsMappingCommandTest {
 assertEquals("centos64Guest", cmd.getGuestOsHypervisorMappingName());
 assertEquals("6.0", cmd.getHypervisorVersion());
 }
-}
\ No newline at end of file
+}
diff --git 
a/plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixCheckGuestOsMappingCommandWrapper.java
 
b/plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixCheckGuestOsMappingCommandWrapper.java
index 0e9f3c69378..68403d76ca4 100644
--- 
a/plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixCheckGuestOsMappingCommandWrapper.java
+++ 
b/plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixCheckGuestOsMappingCommandWrapper.java
@@ -64,4 +64,4 @@ public final class CitrixCheckGuestOsMappingCommandWrapper 
extends CommandWrappe
 return new CheckGuestOsMappingAnswer(command, 
e.getLocalizedMessage());
 }
 }
-}
\ No newline at end of file
+}
diff --git 
a/plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixGetHypervisorGuestOsNamesCommandWrapper.java
 
b/plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixGetHypervisorGuestOsNamesCommandWrapper.java
index c8e9782f2e5..0be3e5a5746 100644
--- 
a/plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixGetHypervisorGuestOsNamesCommandWrapper.java
+++ 
b/plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixGetHypervisorGuestOsNamesCommandWrapper.java
@@ -73,4 +73,4 @@ public final class 
CitrixGetHypervisorGuestOsNamesCommandWrapper extends Command
 return new GetHypervisorGuestOsNamesAnswer(command, 
e.getLocalizedMessage());
 }
 }
-}
\ No newline at end of file
+}



[GitHub] [cloudstack] rohityadavcloud merged pull request #7727: Fix lint errors

2023-07-07 Thread via GitHub


rohityadavcloud merged PR #7727:
URL: https://github.com/apache/cloudstack/pull/7727


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] vladimirpetrov commented on pull request #7615: Fix NPE when migrating volume without template

2023-07-07 Thread via GitHub


vladimirpetrov commented on PR #7615:
URL: https://github.com/apache/cloudstack/pull/7615#issuecomment-1625572830

   This happens after deleting the template and successfully migrating the VM. 
Then when I do stop/start of the VM it doesn't start because of this error 
@gpordeus .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] gpordeus commented on pull request #7615: Fix NPE when migrating volume without template

2023-07-07 Thread via GitHub


gpordeus commented on PR #7615:
URL: https://github.com/apache/cloudstack/pull/7615#issuecomment-1625566492

   > Hi @gpordeus, I tested and indeed there's no NPE anymore but the VMs are 
not able to start after a stop/start operation (on a KVM environment), did you 
notice the same behavior? 
![image](https://user-images.githubusercontent.com/12384665/251696194-77494474-a5d0-4580-ba20-c65178367f8f.png)
   
   Hi, @vladimirpetrov ! I did not, could you specify in which circumstances 
this happens? If it's before or after deleting the template and/or migrating, 
for instance.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] mlsorensen closed pull request #7729: Set encrypted PowerFlex datadisk format correctly

2023-07-07 Thread via GitHub


mlsorensen closed pull request #7729: Set encrypted PowerFlex datadisk format 
correctly
URL: https://github.com/apache/cloudstack/pull/7729


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] mlsorensen commented on pull request #7729: Set encrypted PowerFlex datadisk format correctly

2023-07-07 Thread via GitHub


mlsorensen commented on PR #7729:
URL: https://github.com/apache/cloudstack/pull/7729#issuecomment-1625540139

   Closing in favor of https://github.com/apache/cloudstack/pull/7735 - against 
4.18 branch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] mlsorensen opened a new pull request, #7735: Set encrypted PowerFlex disk format correctly

2023-07-07 Thread via GitHub


mlsorensen opened a new pull request, #7735:
URL: https://github.com/apache/cloudstack/pull/7735

   ### Description
   
   This PR:
   
   1) Sets disk format correctly according to thin/thick provisioned PowerFlex 
volumes when encryption is in play. It delegates the volume format to the 
implementation (ScaleIOStorageAdaptor) and ensures it is passed back so it is 
stored properly in the VolumeVO. 
   
   This allows us to trigger the code that resizes the qcow2 container if we 
are thin provisioned - this wasn't working for data volumes when VM was stopped 
because they were hard coded to RAW format.
   
   2) Defensive coding in case volume has no VM instance name (detached)
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   Tested locally against powerflex, both detached and attached volume.
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] codecov[bot] commented on pull request #7733: test: fix ci failures on main branch

2023-07-07 Thread via GitHub


codecov[bot] commented on PR #7733:
URL: https://github.com/apache/cloudstack/pull/7733#issuecomment-1625510613

   ## 
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7733?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 Report
   > Merging 
[#7733](https://app.codecov.io/gh/apache/cloudstack/pull/7733?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 (477d938) into 
[main](https://app.codecov.io/gh/apache/cloudstack/commit/a706bf2380e11590ef5a268550b63e89e57b5a8f?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 (a706bf2) will **decrease** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@ Coverage Diff  @@
   ##   main#7733  +/-   ##
   
   - Coverage 13.39%   13.39%   -0.01% 
   + Complexity 9346 9344   -2 
   
 Files  2743 2743  
 Lines258571   258571  
 Branches  4027940279  
   
   - Hits  3463934630   -9 
   - Misses   219558   219569  +11 
   + Partials   4374 4372   -2 
   ```
   
   
   [see 2 files with indirect coverage 
changes](https://app.codecov.io/gh/apache/cloudstack/pull/7733/indirect-changes?src=pr=tree-more_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD 
build times. [Learn 
more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] Stanley2911 opened a new issue, #7734: kubernetes issue

2023-07-07 Thread via GitHub


Stanley2911 opened a new issue, #7734:
URL: https://github.com/apache/cloudstack/issues/7734

   
   
   # ISSUE TYPE
   
* Bug Report
   
   # COMPONENT NAME
   
   Kubernetes
   
   # CLOUDSTACK VERSION 4.18.0
   
   
   # CONFIGURATION
   KVM on Rocky Linux 8.7
   
   
   # OS / ENVIRONMENT
   
   
   
   # SUMMARY
   Whenever I am provisioning a new Kubernetes cluster, the cluster goes into 
an error state. The error obtained on GUI is given below
   
   Error
   Failed to setup Kubernetes cluster : k8s as it does not have desired number 
of nodes in ready state
   
   Upon further inspection, the cluster has both controller & worker nodes in 
running state.
   
   
   
![image](https://github.com/apache/cloudstack/assets/134476960/8d949ea8-736b-478a-848f-603049373b3c)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] nvazquez commented on pull request #7712: [WIP] Extend import/export unmanaged instances to KVM

2023-07-07 Thread via GitHub


nvazquez commented on PR #7712:
URL: https://github.com/apache/cloudstack/pull/7712#issuecomment-1625458094

   Thanks @itsayushpandey I have tested the changes so far on an env with 2 KVM 
Alma Linux 8 hosts:
   - Could successfully unmanage an instance
   - When listing unmanaged instances in the cluster, I get the following error:
   
   2023-07-07 13:55:49,552 DEBUG [c.c.a.t.Request] 
(AgentManager-Handler-3:null) (logid:) Seq 1-1384575410439717051: Processing:  
{ Ans: , MgmtId: 167780820, via: 1, Ver: v1, Flags: 10, 
[{"com.cloud.agent.api.Answer":{"result":"false","details":"com.cloud.utils.exception.CloudRuntimeException:
 GetUnmanagedInstancesCommand failed due to name in virDomainLookupByName must 
not be NULL
at 
com.cloud.hypervisor.kvm.resource.wrapper.LibvirtGetUnmanagedInstancesCommandWrapper.execute(LibvirtGetUnmanagedInstancesCommandWrapper.java:79)
at 
com.cloud.hypervisor.kvm.resource.wrapper.LibvirtGetUnmanagedInstancesCommandWrapper.execute(LibvirtGetUnmanagedInstancesCommandWrapper.java:39)
at 
com.cloud.hypervisor.kvm.resource.wrapper.LibvirtRequestWrapper.execute(LibvirtRequestWrapper.java:78)
at 
com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.executeRequest(LibvirtComputingResource.java:1858)
at com.cloud.agent.Agent.processRequest(Agent.java:662)
at com.cloud.agent.Agent$AgentRequestHandler.doTask(Agent.java:1082)
at com.cloud.utils.nio.Task.call(Task.java:83)
at com.cloud.utils.nio.Task.call(Task.java:29)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at 
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at 
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:829)
   ","wait":"0","bypassHostMaintenance":"false"}}] }
   2023-07-07 13:55:49,552 DEBUG [c.c.a.t.Request] 
(qtp649329985-20:ctx-abfd666a ctx-9a38d1ab ctx-8b7eff9f) (logid:252f89b0) Seq 
1-1384575410439717051: Received:  { Ans: , MgmtId: 167780820, via: 
1(ref-trl-5219-k-Ma8-nicolas-vazquez-kvm1), Ver: v1, Flags: 10, { Answer } }
   2023-07-07 13:55:49,552 DEBUG [c.c.a.m.AgentManagerImpl] 
(qtp649329985-20:ctx-abfd666a ctx-9a38d1ab ctx-8b7eff9f) (logid:252f89b0) 
Details from executing class com.cloud.agent.api.GetUnmanagedInstancesCommand: 
com.cloud.utils.exception.CloudRuntimeException: GetUnmanagedInstancesCommand 
failed due to name in virDomainLookupByName must not be NULL
at 
com.cloud.hypervisor.kvm.resource.wrapper.LibvirtGetUnmanagedInstancesCommandWrapper.execute(LibvirtGetUnmanagedInstancesCommandWrapper.java:79)
at 
com.cloud.hypervisor.kvm.resource.wrapper.LibvirtGetUnmanagedInstancesCommandWrapper.execute(LibvirtGetUnmanagedInstancesCommandWrapper.java:39)
at 
com.cloud.hypervisor.kvm.resource.wrapper.LibvirtRequestWrapper.execute(LibvirtRequestWrapper.java:78)
at 
com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.executeRequest(LibvirtComputingResource.java:1858)
at com.cloud.agent.Agent.processRequest(Agent.java:662)
at com.cloud.agent.Agent$AgentRequestHandler.doTask(Agent.java:1082)
at com.cloud.utils.nio.Task.call(Task.java:83)
at com.cloud.utils.nio.Task.call(Task.java:29)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at 
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at 
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:829)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #7733: test: fix ci failures on main branch

2023-07-07 Thread via GitHub


shwstppr commented on PR #7733:
URL: https://github.com/apache/cloudstack/pull/7733#issuecomment-1625395915

   @DaanHoogland this is still wip. Tests are still failing on GH CI,
   ```
   
+---+-+---++
   | Test  | Result  | Time  | Test file
  |
   
+===+=+===++
   | test_03_create_vpc_with_specified_sou | Failure | 7.666 | 
test_set_sourcenat |
   | rce_nat_ip_address| |   |  
  |
   
+---+-+---++
   | test_04_change_source_nat_ip_address_ | Failure | 8.824 | 
test_set_sourcenat |
   | for_vpc   | |   |  
  |
   
+---+-+---++
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7733: test: fix ci failures on main branch

2023-07-07 Thread via GitHub


blueorangutan commented on PR #7733:
URL: https://github.com/apache/cloudstack/pull/7733#issuecomment-1625391508

   @DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will 
be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #7733: test: fix ci failures on main branch

2023-07-07 Thread via GitHub


DaanHoogland commented on PR #7733:
URL: https://github.com/apache/cloudstack/pull/7733#issuecomment-1625389262

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] rohityadavcloud commented on issue #7148: [SolidFire] Cannot attach volume which is detached from VM

2023-07-07 Thread via GitHub


rohityadavcloud commented on issue #7148:
URL: https://github.com/apache/cloudstack/issues/7148#issuecomment-1625383228

   @weizhouapache @shwstppr  I've tested this fix backported to a 4.17 env with 
Solidfire and VMware; it fixes the issue of previously failured where it would 
attempt to create datastore on an already created datastore for a solidfire 
iSCSI target. However, it doesn't address the issue 
https://github.com/apache/cloudstack/issues/7148 completely.
   
   The issue now it with the fix from 
https://github.com/apache/cloudstack/pull/7160, a solidfire data disk is 
detached successfully in CloudStack but we see failures to remove/unmount the 
iSCSI target on vCenter:
   https://github.com/apache/cloudstack/assets/95203/a0880f91-f8bb-4580-9944-b003284bbd3c;>
   
   Furthermore, in vCenter we see the datastore gets inaccessible (umounted 
with errors):
   
   https://github.com/apache/cloudstack/assets/95203/e6f5feb2-f54c-4b2b-9006-33917c3ac8d9;>
   
   Next time we try to attach the solidfire data disk in CloudStack, it fails 
as it somehow fails to mount the datastore on all hosts (error from cloudstack 
logs) and this is seen in vCenter:
   
   https://github.com/apache/cloudstack/assets/95203/ec2be0c5-fc63-4a8e-8a34-7ab7761dd6ae;>
   
   However, surprisingly if I attach from CloudStack and manually mount the 
inaccessible datastore in vCenter, then attach operation succeeds.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7643: Generate cloud-init multipart user data for template append policy

2023-07-07 Thread via GitHub


blueorangutan commented on PR #7643:
URL: https://github.com/apache/cloudstack/pull/7643#issuecomment-1625352434

   @shwstppr a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #7643: Generate cloud-init multipart user data for template append policy

2023-07-07 Thread via GitHub


shwstppr commented on PR #7643:
URL: https://github.com/apache/cloudstack/pull/7643#issuecomment-1625350810

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] github-actions[bot] commented on pull request #7150: Global ACL for VPCs

2023-07-07 Thread via GitHub


github-actions[bot] commented on PR #7150:
URL: https://github.com/apache/cloudstack/pull/7150#issuecomment-1625336137

   This pull request has merge conflicts. Dear author, please fix the conflicts 
and sync your branch with the base branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7344: [HEALTH] 4.19/main Health Check, please don't merge this!

2023-07-07 Thread via GitHub


sonarcloud[bot] commented on PR #7344:
URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1625298673

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack=7344)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7344=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7344=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack=7344=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7344=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7344=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack=7344=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7344=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7344=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7344=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7344=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack=7344=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack=7344=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_cloudstack=7344=coverage=list)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=apache_cloudstack=7344=duplicated_lines_density=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] shwstppr closed pull request #7344: [HEALTH] 4.19/main Health Check, please don't merge this!

2023-07-07 Thread via GitHub


shwstppr closed pull request #7344: [HEALTH] 4.19/main Health Check, please 
don't merge this!
URL: https://github.com/apache/cloudstack/pull/7344


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] shwstppr opened a new pull request, #7733: test: fix ci failures on main branch

2023-07-07 Thread via GitHub


shwstppr opened a new pull request, #7733:
URL: https://github.com/apache/cloudstack/pull/7733

   ### Description
   
   - Fixes k8s test failure on the simulator
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [x] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #7719: Add L2 networks to Zones with SG

2023-07-07 Thread via GitHub


weizhouapache commented on PR #7719:
URL: https://github.com/apache/cloudstack/pull/7719#issuecomment-1625201672

   > @weizhouapache @benj-n is this applicable for 4.18 as well?
   
   @DaanHoogland yes, very nice feature with small changes. I'd like to add it 
to 4.18.1.0 , unless someone objects.
   @benj-n can you rebase with 4.18 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] thorzinaung commented on issue #7725: Unable to create BackUP offering

2023-07-07 Thread via GitHub


thorzinaung commented on issue #7725:
URL: https://github.com/apache/cloudstack/issues/7725#issuecomment-1625185471

   @kiranchavala @DaanHoogland  as per your mentioned. i did all the step. now 
it's not showing error but i can't see external ID. I quite dont understand 
what is that mean and i still cant create backup offering. pls see attached 
file.
   
![](https://github.com/apache/cloudstack/assets/122773216/0385bf38-18cb-4219-b0c7-f27296f5c290)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7712: [WIP] Extend import/export unmanaged instances to KVM

2023-07-07 Thread via GitHub


blueorangutan commented on PR #7712:
URL: https://github.com/apache/cloudstack/pull/7712#issuecomment-1625179157

   @nvazquez a [SF] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] nvazquez commented on pull request #7712: [WIP] Extend import/export unmanaged instances to KVM

2023-07-07 Thread via GitHub


nvazquez commented on PR #7712:
URL: https://github.com/apache/cloudstack/pull/7712#issuecomment-1625176253

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] github-actions[bot] commented on pull request #7615: Fix NPE when migrating volume without template

2023-07-07 Thread via GitHub


github-actions[bot] commented on PR #7615:
URL: https://github.com/apache/cloudstack/pull/7615#issuecomment-1625161530

   This pull request has merge conflicts. Dear author, please fix the conflicts 
and sync your branch with the base branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[cloudstack] branch main updated (2132f46fcb3 -> a706bf2380e)

2023-07-07 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


from 2132f46fcb3 Merge branch '4.18'
 add 594c70dde0e Sync precommit config from main (#7732)
 new a706bf2380e Merge branch '4.18'

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../org/apache/cloudstack/direct/download/DirectDownloadHelper.java | 2 +-
 .../org/apache/cloudstack/direct/download/DirectTemplateDownloader.java | 2 +-
 .../cloudstack/direct/download/HttpsDirectTemplateDownloader.java   | 2 +-
 .../org/apache/cloudstack/direct/download/HttpsMultiTrustManager.java   | 2 +-
 .../cloudstack/direct/download/MetalinkDirectTemplateDownloader.java| 2 +-
 core/src/test/java/com/cloud/storage/JavaStorageLayerTest.java  | 1 -
 .../cloudstack/direct/download/BaseDirectTemplateDownloaderTest.java| 2 +-
 .../cloudstack/direct/download/HttpsDirectTemplateDownloaderTest.java   | 2 +-
 .../direct/download/MetalinkDirectTemplateDownloaderTest.java   | 2 +-
 plugins/storage/volume/storpool/README.md   | 1 -
 10 files changed, 8 insertions(+), 10 deletions(-)



[cloudstack] 01/01: Merge branch '4.18'

2023-07-07 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit a706bf2380e11590ef5a268550b63e89e57b5a8f
Merge: 2132f46fcb3 594c70dde0e
Author: Daan Hoogland 
AuthorDate: Fri Jul 7 11:49:35 2023 +0200

Merge branch '4.18'

 .../org/apache/cloudstack/direct/download/DirectDownloadHelper.java | 2 +-
 .../org/apache/cloudstack/direct/download/DirectTemplateDownloader.java | 2 +-
 .../cloudstack/direct/download/HttpsDirectTemplateDownloader.java   | 2 +-
 .../org/apache/cloudstack/direct/download/HttpsMultiTrustManager.java   | 2 +-
 .../cloudstack/direct/download/MetalinkDirectTemplateDownloader.java| 2 +-
 core/src/test/java/com/cloud/storage/JavaStorageLayerTest.java  | 1 -
 .../cloudstack/direct/download/BaseDirectTemplateDownloaderTest.java| 2 +-
 .../cloudstack/direct/download/HttpsDirectTemplateDownloaderTest.java   | 2 +-
 .../direct/download/MetalinkDirectTemplateDownloaderTest.java   | 2 +-
 plugins/storage/volume/storpool/README.md   | 1 -
 10 files changed, 8 insertions(+), 10 deletions(-)



[GitHub] [cloudstack] DaanHoogland commented on pull request #7727: Fix lint errors

2023-07-07 Thread via GitHub


DaanHoogland commented on PR #7727:
URL: https://github.com/apache/cloudstack/pull/7727#issuecomment-1625149386

   About 
https://github.com/apache/cloudstack/actions/runs/5475638802/jobs/9972019731?pr=7727
 manual running the source_nat tests passes:
   ```
   ...
   === TestName: test_03_create_vpc_with_specified_source_nat_ip_address | 
Status : SUCCESS ===
   
   === TestName: test_04_change_source_nat_ip_address_for_vpc | Status : 
SUCCESS ===
   
   ```
   and for kubernetes_clusters:
   ```
   === TestName: test_11_test_unmanaged_cluster_lifecycle | Status : SUCCESS ===
   ```
   with no exception on tear down.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #7719: Add L2 networks to Zones with SG

2023-07-07 Thread via GitHub


DaanHoogland commented on PR #7719:
URL: https://github.com/apache/cloudstack/pull/7719#issuecomment-1625144654

   @weizhouapache @benj-n is this applicable for 4.18 as well?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland merged pull request #7732: Sync precommit config from main

2023-07-07 Thread via GitHub


DaanHoogland merged PR #7732:
URL: https://github.com/apache/cloudstack/pull/7732


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] vladimirpetrov commented on pull request #7615: Fix NPE when migrating volume without template

2023-07-07 Thread via GitHub


vladimirpetrov commented on PR #7615:
URL: https://github.com/apache/cloudstack/pull/7615#issuecomment-1625112040

   Hi @gpordeus, I tested and indeed there's no NPE anymore but the VMs are not 
able to start after a stop/start operation (on a KVM environment), did you 
notice the same behavior?
   
![image](https://github.com/apache/cloudstack/assets/12384665/77494474-a5d0-4580-ba20-c65178367f8f)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] vishesh92 commented on pull request #7727: Fix lint errors

2023-07-07 Thread via GitHub


vishesh92 commented on PR #7727:
URL: https://github.com/apache/cloudstack/pull/7727#issuecomment-1625105184

   @DaanHoogland yes. Let's wait.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #7727: Fix lint errors

2023-07-07 Thread via GitHub


DaanHoogland commented on PR #7727:
URL: https://github.com/apache/cloudstack/pull/7727#issuecomment-1625087185

   @vishesh92 do you want to wait with merging this till after #7732 has been 
merged (forward)?
   cc @weizhouapache 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #7732: Sync precommit config from main

2023-07-07 Thread via GitHub


weizhouapache commented on PR #7732:
URL: https://github.com/apache/cloudstack/pull/7732#issuecomment-1625045393

   > @weizhouapache can you agree with this?
   
   @DaanHoogland 
   yes, looks good


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7727: Fix lint errors

2023-07-07 Thread via GitHub


blueorangutan commented on PR #7727:
URL: https://github.com/apache/cloudstack/pull/7727#issuecomment-1625005176

   [SF] Trillian test result (tid-7011)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 42861 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7727-t7011-kvm-centos7.zip
   Smoke tests completed. 111 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_migrate_VM_and_root_volume | `Error` | 77.75 | test_vm_life_cycle.py
   test_02_migrate_VM_with_two_data_disks | `Error` | 52.47 | 
test_vm_life_cycle.py
   test_05_vmschedule_test_e2e | `Failure` | 240.66 | test_vm_schedule.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #7732: Sync precommit config from main

2023-07-07 Thread via GitHub


DaanHoogland commented on PR #7732:
URL: https://github.com/apache/cloudstack/pull/7732#issuecomment-1625005022

   @weizhouapache can you agree with this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] codecov[bot] commented on pull request #7731: Default value of force should be false for template delete operation

2023-07-07 Thread via GitHub


codecov[bot] commented on PR #7731:
URL: https://github.com/apache/cloudstack/pull/7731#issuecomment-1624993198

   ## 
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7731?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 Report
   > Merging 
[#7731](https://app.codecov.io/gh/apache/cloudstack/pull/7731?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 (29ac938) into 
[4.18](https://app.codecov.io/gh/apache/cloudstack/commit/939ee9e1534a1e6013a74f92dbb151666b3887e3?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 (939ee9e) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@Coverage Diff@@
   ##   4.18#7731   +/-   ##
   =
 Coverage 13.02%   13.02%   
 Complexity 9026 9026   
   =
 Files  2719 2719   
 Lines256867   256867   
 Branches  4005140051   
   =
 Hits  3344533445   
 Misses   219233   219233   
 Partials   4189 4189   
   ```
   
   
   
   :mega: We’re building smart automated test selection to slash your CI/CD 
build times. [Learn 
more](https://about.codecov.io/iterative-testing/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7731: Default value of force should be false for template delete operation

2023-07-07 Thread via GitHub


blueorangutan commented on PR #7731:
URL: https://github.com/apache/cloudstack/pull/7731#issuecomment-1624979352

   Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 
:heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. 
SL-JID 6434


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] vishesh92 commented on pull request #7732: Sync precommit config from main

2023-07-07 Thread via GitHub


vishesh92 commented on PR #7732:
URL: https://github.com/apache/cloudstack/pull/7732#issuecomment-1624955942

   List of files with conflicts while merging with main
   
![image](https://github.com/apache/cloudstack/assets/8760112/396b1248-2239-4dff-aae9-5e4761821015)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #7719: Add L2 networks to Zones with SG

2023-07-07 Thread via GitHub


weizhouapache commented on PR #7719:
URL: https://github.com/apache/cloudstack/pull/7719#issuecomment-1624938671

   > > @benj-n have you tested it ? if so , can you share the related 
iptables/ebtables rules and output of `ipset list` command ?
   > 
   > In the test, a VM has a first NIC with shared network (and security 
groups) on vlan100/vnet16 and a second NIC with an L2 network (vlan2150/vnet20):
   > 
   > ```
   > root@node01:~# virsh domiflist i-2-596-VM
   >  Interface   Type Source ModelMAC
   > -
   >  vnet16  bridge   brbond0-100virtio   1e:00:06:00:20:29
   >  vnet20  bridge   brbond9-2150   virtio   02:00:1d:52:00:01
   > ```
   > 
   > The vnet20 and the L2 network are completely absent from iptables :
   > 
   > ```
   > Chain BF-brbond0-100-IN (1 references)
   >  pkts bytes target prot opt in out source   
destination
   > (...)
   >   240 24611 i-2-596-def  all  --  *  *   0.0.0.0/0
0.0.0.0/0PHYSDEV match --physdev-in vnet16 --physdev-is-bridged
   > 
   > Chain BF-brbond0-100-OUT (1 references)
   >  pkts bytes target prot opt in out source   
destination
   > (...)
   >   876 43779 i-2-596-def  all  --  *  *   0.0.0.0/0
0.0.0.0/0PHYSDEV match --physdev-out vnet16 --physdev-is-bridged
   > 
   > 
   > Chain i-2-596-VM (1 references)
   >  pkts bytes target prot opt in out source   
destination
   >14   973 ACCEPT icmp --  *  *   0.0.0.0/0
0.0.0.0/0icmptype 255
   >   417 21629 ACCEPT all  --  *  *   0.0.0.0/0
0.0.0.0/0state NEW
   >   150  6004 DROP   all  --  *  *   0.0.0.0/0
0.0.0.0/0
   > 
   > Chain i-2-596-VM-eg (1 references)
   >  pkts bytes target prot opt in out source   
destination
   >   136  9456 RETURN all  --  *  *   0.0.0.0/0
0.0.0.0/0state NEW
   > 0 0 DROP   all  --  *  *   0.0.0.0/0
0.0.0.0/0
   > 
   > Chain i-2-596-def (2 references)
   >  pkts bytes target prot opt in out source   
destination
   > 0 0 ACCEPT all  --  *  *   0.0.0.0/0
0.0.0.0/0state RELATED,ESTABLISHED
   >32 10556 ACCEPT udp  --  *  *   0.0.0.0/0
0.0.0.0/0PHYSDEV match --physdev-in vnet16 --physdev-is-bridged udp 
spt:68 dpt:67
   > 2   667 ACCEPT udp  --  *  *   0.0.0.0/0
0.0.0.0/0PHYSDEV match --physdev-out vnet16 --physdev-is-bridged 
udp spt:67 dpt:68
   > 0 0 DROP   udp  --  *  *   0.0.0.0/0
0.0.0.0/0PHYSDEV match --physdev-in vnet16 --physdev-is-bridged udp 
spt:67
   > 0 0 DROP   all  --  *  *   0.0.0.0/0
0.0.0.0/0PHYSDEV match --physdev-in vnet16 --physdev-is-bridged ! 
match-set i-2-596-VM src
   >   293 14506 DROP   all  --  *  *   0.0.0.0/0
0.0.0.0/0PHYSDEV match --physdev-out vnet16 --physdev-is-bridged ! 
match-set i-2-596-VM dst
   >72  4599 RETURN udp  --  *  *   0.0.0.0/0
0.0.0.0/0PHYSDEV match --physdev-in vnet16 --physdev-is-bridged 
match-set i-2-596-VM src udp dpt:53
   > 0 0 RETURN tcp  --  *  *   0.0.0.0/0
0.0.0.0/0PHYSDEV match --physdev-in vnet16 --physdev-is-bridged 
match-set i-2-596-VM src tcp dpt:53
   >   136  9456 i-2-596-VM-eg  all  --  *  *   0.0.0.0/0
0.0.0.0/0PHYSDEV match --physdev-in vnet16 --physdev-is-bridged 
match-set i-2-596-VM src
   >   581 28606 i-2-596-VM  all  --  *  *   0.0.0.0/0
0.0.0.0/0PHYSDEV match --physdev-out vnet16 --physdev-is-bridged
   > ```
   > 
   > The L2 is also completely absent from ip6tables:
   > 
   > ```
   > Chain BF-brbond0-100-IN (1 references)
   >  pkts bytes target prot opt in out source   
destination
   > (...)
   >90  6768 i-2-596-def  all  *  *   ::/0 ::/0 
PHYSDEV match --physdev-in vnet16 --physdev-is-bridged
   > 
   > Chain BF-brbond0-100-OUT (1 references)
   >  pkts bytes target prot opt in out source   
destination
   > (...)
   >21  2184 i-2-596-def  all  *  *   ::/0 ::/0 
PHYSDEV match --physdev-out vnet16 --physdev-is-bridged
   > 
   > Chain i-2-596-VM (1 references)
   >  pkts bytes target prot opt in out source   
destination
   > 0 0 ACCEPT icmpv6*  *   ::/0 ::/0
   > 0 0 ACCEPT all  *  *   ::/0 ::/0   
  state NEW
   >

[GitHub] [cloudstack] vishesh92 opened a new pull request, #7732: Sync precommit config from main

2023-07-07 Thread via GitHub


vishesh92 opened a new pull request, #7732:
URL: https://github.com/apache/cloudstack/pull/7732

   ### Description
   
   This PR syncs the pre-commit config from main branch. As of now forward 
merging of 4.18 to main is causing lint checks to fail for main.
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7728: Add MGMT IP in management.network.cidr as alternate name in their self-signed certificate

2023-07-07 Thread via GitHub


blueorangutan commented on PR #7728:
URL: https://github.com/apache/cloudstack/pull/7728#issuecomment-1624908210

   @DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) 
has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #7728: Add MGMT IP in management.network.cidr as alternate name in their self-signed certificate

2023-07-07 Thread via GitHub


DaanHoogland commented on PR #7728:
URL: https://github.com/apache/cloudstack/pull/7728#issuecomment-1624907208

   @blueorangutan test keepEnv


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] msteini closed issue #7721: zone installation wizard traffic types

2023-07-07 Thread via GitHub


msteini closed issue #7721: zone installation wizard traffic types
URL: https://github.com/apache/cloudstack/issues/7721


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7728: Add MGMT IP in management.network.cidr as alternate name in their self-signed certificate

2023-07-07 Thread via GitHub


blueorangutan commented on PR #7728:
URL: https://github.com/apache/cloudstack/pull/7728#issuecomment-1624891038

   [SF] Trillian test result (tid-7015)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 775 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7728-t7015-kvm-centos7.zip
   Smoke tests completed. 0 look OK, 0 have errors, 113 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   all_test_safe_shutdown | `Skipped` | --- | test_safe_shutdown.py
   all_test_scale_vm | `Skipped` | --- | test_scale_vm.py
   all_test_2fa | `Skipped` | --- | test_2fa.py
   all_test_regions | `Skipped` | --- | test_regions.py
   all_test_accounts | `Skipped` | --- | test_accounts.py
   all_test_nonstrict_affinity_group | `Skipped` | --- | 
test_nonstrict_affinity_group.py
   all_test_affinity_groups | `Skipped` | --- | test_affinity_groups.py
   all_test_internal_lb | `Skipped` | --- | test_internal_lb.py
   all_test_usage | `Skipped` | --- | test_usage.py
   all_test_affinity_groups_projects | `Skipped` | --- | 
test_affinity_groups_projects.py
   all_test_register_userdata | `Skipped` | --- | test_register_userdata.py
   all_test_annotations | `Skipped` | --- | test_annotations.py
   all_test_reset_vm_on_reboot | `Skipped` | --- | test_reset_vm_on_reboot.py
   all_test_async_job | `Skipped` | --- | test_async_job.py
   all_test_ipv6_infra | `Skipped` | --- | test_ipv6_infra.py
   all_test_attach_multiple_volumes | `Skipped` | --- | 
test_attach_multiple_volumes.py
   all_test_kubernetes_clusters | `Skipped` | --- | test_kubernetes_clusters.py
   all_test_backup_recovery_dummy | `Skipped` | --- | 
test_backup_recovery_dummy.py
   all_test_outofbandmanagement | `Skipped` | --- | test_outofbandmanagement.py
   all_test_certauthority_root | `Skipped` | --- | test_certauthority_root.py
   all_test_over_provisioning | `Skipped` | --- | test_over_provisioning.py
   all_test_console_endpoint | `Skipped` | --- | test_console_endpoint.py
   all_test_set_sourcenat | `Skipped` | --- | test_set_sourcenat.py
   all_test_create_list_domain_account_project | `Skipped` | --- | 
test_create_list_domain_account_project.py
   all_test_password_server | `Skipped` | --- | test_password_server.py
   all_test_create_network | `Skipped` | --- | test_create_network.py
   all_test_iso | `Skipped` | --- | test_iso.py
   all_test_snapshots | `Skipped` | --- | test_snapshots.py
   all_test_deploy_vgpu_enabled_vm | `Skipped` | --- | 
test_deploy_vgpu_enabled_vm.py
   all_test_migration | `Skipped` | --- | test_migration.py
   all_test_deploy_virtio_scsi_vm | `Skipped` | --- | 
test_deploy_virtio_scsi_vm.py
   all_test_multipleips_per_nic | `Skipped` | --- | test_multipleips_per_nic.py
   all_test_deploy_vm_extra_config_data | `Skipped` | --- | 
test_deploy_vm_extra_config_data.py
   all_test_persistent_network | `Skipped` | --- | test_persistent_network.py
   all_test_deploy_vm_iso | `Skipped` | --- | test_deploy_vm_iso.py
   all_test_portable_publicip | `Skipped` | --- | test_portable_publicip.py
   all_test_deploy_vm_iso_uefi | `Skipped` | --- | test_deploy_vm_iso_uefi.py
   all_test_nested_virtualization | `Skipped` | --- | 
test_nested_virtualization.py
   all_test_deploy_vm_root_resize | `Skipped` | --- | 
test_deploy_vm_root_resize.py
   all_test_network | `Skipped` | --- | test_network.py
   all_test_deploy_vm_with_userdata | `Skipped` | --- | 
test_deploy_vm_with_userdata.py
   all_test_network_acl | `Skipped` | --- | test_network_acl.py
   all_test_deploy_vms_in_parallel | `Skipped` | --- | 
test_deploy_vms_in_parallel.py
   all_test_ssvm | `Skipped` | --- | test_ssvm.py
   all_test_deploy_vms_with_varied_deploymentplanners | `Skipped` | --- | 
test_deploy_vms_with_varied_deploymentplanners.py
   all_test_resource_accounting | `Skipped` | --- | test_resource_accounting.py
   all_test_diagnostics | `Skipped` | --- | test_diagnostics.py
   all_test_portforwardingrules | `Skipped` | --- | test_portforwardingrules.py
   all_test_direct_download | `Skipped` | --- | test_direct_download.py
   all_test_primary_storage | `Skipped` | --- | test_primary_storage.py
   all_test_disk_offerings | `Skipped` | --- | test_disk_offerings.py
   all_test_network_ipv6 | `Skipped` | --- | test_network_ipv6.py
   all_test_disk_provisioning_types | `Skipped` | --- | 
test_disk_provisioning_types.py
   all_test_network_permissions | `Skipped` | --- | test_network_permissions.py
   all_test_domain_disk_offerings | `Skipped` | --- | 
test_domain_disk_offerings.py
   all_test_nic | `Skipped` | --- | test_nic.py
   all_test_staticroles | `Skipped` | --- | test_staticroles.py
   all_test_domain_network_offerings | `Skipped` | --- | 
test_domain_network_offerings.py
   all_test_nic_adapter_type | `Skipped` | --- | test_nic_adapter_type.py
   all_test_domain_service_offerings | `Skipped` | 

[GitHub] [cloudstack] blueorangutan commented on pull request #7731: Default value of force should be false for template delete operation

2023-07-07 Thread via GitHub


blueorangutan commented on PR #7731:
URL: https://github.com/apache/cloudstack/pull/7731#issuecomment-1624872246

   @harikrishna-patnala a [SF] Jenkins job has been kicked to build packages. 
It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll 
keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] harikrishna-patnala commented on pull request #7731: Default value of force should be false for template delete operation

2023-07-07 Thread via GitHub


harikrishna-patnala commented on PR #7731:
URL: https://github.com/apache/cloudstack/pull/7731#issuecomment-1624870701

   
   @blueorangutan package
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] harikrishna-patnala opened a new pull request, #7731: Default value of force should be false for template delete operation

2023-07-07 Thread via GitHub


harikrishna-patnala opened a new pull request, #7731:
URL: https://github.com/apache/cloudstack/pull/7731

   ### Description
   
   Default value of force should be false for the template delete operation
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #7728: Add MGMT IP in management.network.cidr as alternate name in their self-signed certificate

2023-07-07 Thread via GitHub


blueorangutan commented on PR #7728:
URL: https://github.com/apache/cloudstack/pull/7728#issuecomment-1624841036

   @DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) 
has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #7728: Add MGMT IP in management.network.cidr as alternate name in their self-signed certificate

2023-07-07 Thread via GitHub


DaanHoogland commented on PR #7728:
URL: https://github.com/apache/cloudstack/pull/7728#issuecomment-1624840799

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] DaanHoogland closed pull request #7726: Fix test_vm_schedule's intermittent failures

2023-07-07 Thread via GitHub


DaanHoogland closed pull request #7726: Fix test_vm_schedule's intermittent 
failures
URL: https://github.com/apache/cloudstack/pull/7726


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [cloudstack] harikrishna-patnala commented on pull request #7729: Set encrypted PowerFlex datadisk format correctly

2023-07-07 Thread via GitHub


harikrishna-patnala commented on PR #7729:
URL: https://github.com/apache/cloudstack/pull/7729#issuecomment-1624803894

   @mlsorensen can we target this to 4.18.1 please, this needs to change the 
base branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org