Re: [PR] Remove allocated snapshots / vm snapshots on start [cloudstack]
codecov[bot] commented on PR #8452: URL: https://github.com/apache/cloudstack/pull/8452#issuecomment-1878260709 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8452?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`6d916ca`)](https://app.codecov.io/gh/apache/cloudstack/commit/6d916cad348f5833a567c17f5c9dbccaf2135448?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 30.85% compared to head [(`a00734b`)](https://app.codecov.io/gh/apache/cloudstack/pull/8452?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 4.39%. > Report is 12 commits behind head on main. Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8452 +/- ## - Coverage 30.85% 4.39% -26.46% Files 5341 361 -4980 Lines374861 28621 -346240 Branches 545184992-49526 - Hits 1156591258 -114401 + Misses 243973 27224 -216749 + Partials 15229 139-15090 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8452/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8452/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8452/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.39% <ø> (+<0.01%)` | :arrow_up: | | [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8452/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8452?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove allocated snapshots / vm snapshots on start [cloudstack]
blueorangutan commented on PR #8452: URL: https://github.com/apache/cloudstack/pull/8452#issuecomment-1878260575 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove allocated snapshots / vm snapshots on start [cloudstack]
sureshanaparti commented on PR #8452: URL: https://github.com/apache/cloudstack/pull/8452#issuecomment-1878253899 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Remove allocated snapshots / vm snapshots on start [cloudstack]
sureshanaparti opened a new pull request, #8452:
URL: https://github.com/apache/cloudstack/pull/8452
### Description
This PR removes allocated snapshots / vm snapshots on start.
Fixes #8424
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]
blueorangutan commented on PR #8426: URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1878245730 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]
shwstppr commented on PR #8426: URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1878244587 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] VMware: VM import fails with default template [cloudstack]
shwstppr commented on issue #8432: URL: https://github.com/apache/cloudstack/issues/8432#issuecomment-1878244246 Fixed with #8429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] VMware: VM import fails with default template [cloudstack]
shwstppr closed issue #8432: VMware: VM import fails with default template URL: https://github.com/apache/cloudstack/issues/8432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch main updated: Fix VMware VM ingestion template selection and default template failure (#8429)
This is an automated email from the ASF dual-hosted git repository.
shwstppr pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/main by this push:
new 3f9dd4dc07f Fix VMware VM ingestion template selection and default
template failure (#8429)
3f9dd4dc07f is described below
commit 3f9dd4dc07ff40a4e0216014715e4fe37fc46d28
Author: Nicolas Vazquez
AuthorDate: Fri Jan 5 04:27:13 2024 -0300
Fix VMware VM ingestion template selection and default template failure
(#8429)
This PR fixes the template selection regression for VMware Ingestion in the
UI on 4.19.0 RC1 and adds back the default template selection for VMware
Fixes: #8428 #8432
---
.../java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java| 4 +++-
ui/src/views/tools/ImportUnmanagedInstance.vue| 8
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git
a/server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java
b/server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java
index b7190f4ff21..789e0bf06aa 100644
--- a/server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java
+++ b/server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java
@@ -,7 +,9 @@ public class UnmanagedVMsManagerImpl implements
UnmanagedVMsManager {
}
}
allDetails.put(VmDetailConstants.ROOT_DISK_CONTROLLER,
rootDisk.getController());
-allDetails.put(VmDetailConstants.ROOT_DISK_SIZE,
String.valueOf(rootDisk.getCapacity() / Resource.ResourceType.bytesToGiB));
+if (cluster.getHypervisorType() != Hypervisor.HypervisorType.VMware) {
+allDetails.put(VmDetailConstants.ROOT_DISK_SIZE,
String.valueOf(rootDisk.getCapacity() / Resource.ResourceType.bytesToGiB));
+}
try {
checkUnmanagedDiskAndOfferingForImport(unmanagedInstance.getName(), rootDisk,
null, validatedServiceOffering, owner, zone, cluster, migrateAllowed);
diff --git a/ui/src/views/tools/ImportUnmanagedInstance.vue
b/ui/src/views/tools/ImportUnmanagedInstance.vue
index 6433e68da57..a03ef3866ec 100644
--- a/ui/src/views/tools/ImportUnmanagedInstance.vue
+++ b/ui/src/views/tools/ImportUnmanagedInstance.vue
@@ -111,7 +111,7 @@
-
+
@@ -120,7 +120,7 @@
:value="templateType"
@change="changeTemplateType">
-
+
{{ $t('label.template.temporary.import') }}
@@ -667,7 +667,7 @@ export default {
nic.broadcasturi = 'pvlan://' + nic.vlanid + '-i' +
nic.isolatedpvlan
}
}
- if (this.cluster.hypervisortype === 'VMWare') {
+ if (this.cluster.hypervisortype === 'VMware') {
nic.meta = this.getMeta(nic, { macaddress: 'mac', vlanid: 'vlan',
networkname: 'network' })
} else {
nic.meta = this.getMeta(nic, { macaddress: 'mac', vlanid: 'vlan' })
@@ -849,7 +849,7 @@ export default {
this.nicsNetworksMapping = data
},
defaultTemplateType () {
- if (this.cluster.hypervisortype === 'VMWare') {
+ if (this.cluster.hypervisortype === 'VMware') {
return 'auto'
}
return 'custom'
Re: [I] 4.19.0 RC1 Regression on Vmware ingestion [cloudstack]
shwstppr closed issue #8428: 4.19.0 RC1 Regression on Vmware ingestion URL: https://github.com/apache/cloudstack/issues/8428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix VMware VM ingestion template selection and default template failure [cloudstack]
shwstppr merged PR #8429: URL: https://github.com/apache/cloudstack/pull/8429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix VMware VM ingestion template selection and default template failure [cloudstack]
shwstppr commented on code in PR #8429: URL: https://github.com/apache/cloudstack/pull/8429#discussion_r1442568048 ## ui/src/views/tools/ImportUnmanagedInstance.vue: ## @@ -111,7 +111,7 @@ - + Review Comment: @nvazquez @DaanHoogland I'm merging this as it is as default template import is blocking testing for #8426 . Please open a new PR if the refactoring is needed here :pray: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] DHCP in Virtual Router is not working [cloudstack]
li-liwen opened a new issue, #8451: URL: https://github.com/apache/cloudstack/issues/8451 # ISSUE TYPE * Bug Report * Improvement Request * Enhancement Request * Feature Idea * Documentation Report * Other # COMPONENT NAME ~~~ VR, DHCP ~~~ # CLOUDSTACK VERSION ~~~ 4.18.1 ~~~ # CONFIGURATION # OS / ENVIRONMENT # SUMMARY # STEPS TO REPRODUCE ~~~ 1. Fresh installation of cloudstack 4.18.1 with advanced zone 2. Download a Ubuntu server ISO or Ubuntu cloud image. 3. Create a VPC and isolated network under the VPC. 4. Boot the cloud image or ISO. 5. Connect the console and try to acquire IP address through DHCP. ~~~ # EXPECTED RESULTS ~~~ The VM successfully get the IP address that matches the IP address in the UI. ~~~ # ACTUAL RESULTS ~~~ The VM can't acquire the IP address automatically, but if I set the IP manually, the VM is able to function properly. (DNS, internet routing are all working) The dhcp_check.py in the UI is showing OK, but DHCP is not working properly. ~~~ https://github.com/apache/cloudstack/assets/53441624/ed1e9a7b-3e41-413f-8561-4ff174230473;> https://github.com/apache/cloudstack/assets/53441624/efbcd3f7-e559-4a88-a9c5-92f4d55b278a;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CleanUp Async Jobs after mgmt server maintenance [cloudstack]
blueorangutan commented on PR #8394: URL: https://github.com/apache/cloudstack/pull/8394#issuecomment-1878222939 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Provide option of disabling the domains [cloudstack]
kiranchavala opened a new issue, #8449: URL: https://github.com/apache/cloudstack/issues/8449 ISSUE TYPE Enhancement/Improvement Request COMPONENT NAME Component: API/ UI CLOUDSTACK VERSION Cloudstack version 4.18, SUMMARY Provide option of disabling the domains Steps to reproduce the issue 1. Navigate to Domains 2. Create a domain 3. There is no option to disable the domain available The only option present is to remove it Currently, Cloudstack supports the option of disabling of the accounts and users https://cloudstack.apache.org/api/apidocs-4.18/apis/disableAccount.html https://cloudstack.apache.org/api/apidocs-4.18/apis/disableUser.html It would be great if Cloudstack extends the feature to the domains also    Expected behaviour If a domain is disabled, it should not be listed during the creation of resources such as (network etc) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] System vm's volumes should be expunged when a primary storage is set in Maintenance Mode [cloudstack]
kiranchavala opened a new issue, #8450: URL: https://github.com/apache/cloudstack/issues/8450 ISSUE TYPE Enhancement/Improvement Request COMPONENT NAME Component: CLOUDSTACK VERSION Cloudstack version 4.18, SUMMARY System vm's volumes should be expunged when a primary storage is set in Maintenance Mode Currently, the system vm volumes are set in destroyed state and have to wait till the storage cleanup thread runs which is 24hrs by default Unless the systemvm's volumes are removed the primary storage can't be removed Steps to reproduce the behavior Example 1. Create a cloudstack enviroment with 2 Primary storages (cluster wide and zone wide) 2. Launch a vm with root disk and data disk ( Both disks are allocated in the cluster wide primary storage) 3. Put the cluster wide storage in Maintainence Mode 5. On putting the Cluster wide storage in Maintainence Mode. The vm goes into stopped state 6. The system vm volumes are recreated in the Zone wide storage 7. The system vm volumes associated with the cluster wide storage are marked in the destroyed state Screenshots   8. Admin user who wants to remove the Cluster wide storage cannot do so unless the system vm volumes are expunged and marked as removed and it depends on the global settings paramters storage.cleanup.interval storage.cleanup.delay storage.cleanup.enabled 9. This doesn't affect the vm disk as they are recreated in another active primary storage Expected behaviour Cloudstack should expunge the systemvm volumes instead of marking them destroyed. As systemvm volumes genrally doesn't contain important data. Or we could have pop up option asking the user if they want to expunge the systemvm volumes immediately when they put a primary storage in Maintenance mode ( some sort of configurable value) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]
shwstppr commented on PR #8426: URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1878192104 > @shwstppr Should it be re-targeted to 4.18? will make the change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ui: prevent scheduling readyforshutdown job when api inaccessible [cloudstack]
codecov[bot] commented on PR #8448: URL: https://github.com/apache/cloudstack/pull/8448#issuecomment-1878190618 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8448?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: `3 lines` in your changes are missing coverage. Please review. > Comparison is base [(`9d4f071`)](https://app.codecov.io/gh/apache/cloudstack/commit/9d4f0715d434c8ee1e064f8681093133241e34e2?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 30.80% compared to head [(`4acd066`)](https://app.codecov.io/gh/apache/cloudstack/pull/8448?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 4.39%. > Report is 4 commits behind head on main. | [Files](https://app.codecov.io/gh/apache/cloudstack/pull/8448?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [ui/src/components/page/GlobalLayout.vue](https://app.codecov.io/gh/apache/cloudstack/pull/8448?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-dWkvc3JjL2NvbXBvbmVudHMvcGFnZS9HbG9iYWxMYXlvdXQudnVl) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8448?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8448 +/- ## - Coverage 30.80% 4.39% -26.42% Files 5341 361 -4980 Lines374864 28622 -346242 Branches 545184993-49525 - Hits 1154851258 -114227 + Misses 244114 27225 -216889 + Partials 15265 139-15126 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8448/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8448/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8448/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.39% <0.00%> (ø)` | | | [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8448/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8448?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] ui: prevent scheduling readyforshutdown job when api inaccessible [cloudstack]
shwstppr opened a new pull request, #8448:
URL: https://github.com/apache/cloudstack/pull/8448
### Description
Non-admin accounts may not have access to the readyForShutdown API therefore
UI should not schedule the job.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CleanUp Async Jobs after mgmt server maintenance [cloudstack]
blueorangutan commented on PR #8394: URL: https://github.com/apache/cloudstack/pull/8394#issuecomment-1878170889 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CleanUp Async Jobs after mgmt server maintenance [cloudstack]
sureshanaparti commented on PR #8394: URL: https://github.com/apache/cloudstack/pull/8394#issuecomment-1878169594 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CleanUp Async Jobs after mgmt server maintenance [cloudstack]
sureshanaparti commented on code in PR #8394: URL: https://github.com/apache/cloudstack/pull/8394#discussion_r1442521408 ## framework/jobs/src/main/java/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java: ## @@ -35,12 +35,22 @@ import javax.inject.Inject; import javax.naming.ConfigurationException; +import com.cloud.network.Network; Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] minio: fix store user creation [cloudstack]
vladimirpetrov commented on PR #8425: URL: https://github.com/apache/cloudstack/pull/8425#issuecomment-1877878463 While testing this PR, I found the following issue, here are the steps to reproduce: As admin, create a bucket Create a new account test1 Log in with the account and create a minio bucket Log in as admin, delete the account Again create account with the same name Log in with the account and create another minio bucket Upload a file (not really necessary) Using the same account try to create a bucket that already exists (the one created in the first step). The operation will fail, obviously. Now go to the bucket again - the uploaded file is missing. Try to upload a new file. The operation fails with the following message:  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix reorder/list pools when cluster details are not set, while deploying vm / attaching volume [cloudstack]
blueorangutan commented on PR #8373: URL: https://github.com/apache/cloudstack/pull/8373#issuecomment-1877821247 [SF] Trillian test result (tid-8722) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 49111 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8373-t8722-kvm-centos7.zip Smoke tests completed. 121 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]
blueorangutan commented on PR #8426: URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1877813089 [SF] Trillian test result (tid-8721) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 55240 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8426-t8721-kvm-centos7.zip Smoke tests completed. 118 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_08_upgrade_kubernetes_ha_cluster | `Failure` | 919.94 | test_kubernetes_clusters.py test_09_delete_kubernetes_ha_cluster | `Failure` | 3616.66 | test_kubernetes_clusters.py test_10_vpc_tier_kubernetes_cluster | `Failure` | 56.46 | test_kubernetes_clusters.py ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 117.89 | test_kubernetes_clusters.py test_08_migrate_vm | `Error` | 44.96 | test_vm_life_cycle.py test_hostha_kvm_host_degraded | `Error` | 700.11 | test_hostha_kvm.py test_hostha_kvm_host_fencing | `Error` | 671.32 | test_hostha_kvm.py test_hostha_kvm_host_recovering | `Error` | 725.54 | test_hostha_kvm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]
weizhouapache commented on PR #8426: URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1877811637 @shwstppr Should it be re-targeted to 4.18? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] schema,engine-schema: explicit VMware 8.0.0.2 support, logs [cloudstack]
weizhouapache commented on PR #8444: URL: https://github.com/apache/cloudstack/pull/8444#issuecomment-1877704611 @shwstppr We could add 8.0a(8.0.0.1), 8.0b (8.0.0.2) and 8.0c (8.0.0.3) if missing This is a quick workaround. As Hari said, ideally we should use hypervisor capabilities of parent version, so we do not need to add hypervisor capabilities for each minor release. This could be part of 8.1.x and 8.2.x support task. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] engine-schema: fix finding guestos mapping with parent version [cloudstack]
blueorangutan commented on PR #8426: URL: https://github.com/apache/cloudstack/pull/8426#issuecomment-1877678316 [SF] Trillian test result (tid-8720) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 48289 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8426-t8720-vmware-67u3.zip Smoke tests completed. 119 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_list_sec_storage_vm | `Failure` | 0.06 | test_ssvm.py test_03_ssvm_internals | `Failure` | 0.06 | test_ssvm.py test_05_stop_ssvm | `Failure` | 0.05 | test_ssvm.py test_12_destroy_cpvm | `Error` | 7.46 | test_ssvm.py test_02_balanced_drs_algorithm | `Error` | 430.00 | test_cluster_drs.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add IOPS to disk offerings details [cloudstack]
hsato03 opened a new pull request, #8447:
URL: https://github.com/apache/cloudstack/pull/8447
### Description
When listing disk offerings through the UI, IOPS and read/write data for
these offerings is not presented, making it difficult to access information
about them.
For this reason, `Disk Read Rate (IOPS)`, `Disk Write Rate (IOPS)`, `Disk
Read Rate (BPS)`, `Disk Write Rate (BPS)` and `Max IOPS` data has been added to
the disk offering details.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [X] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
1. I created a disk offering with customized write and read rate values
using the `hypervisor` QoS type in the creation form;
2. I created a disk offering with max IOPS using the `storage` QoS type in
the creation form;
3. I accessed these disk offerings and verified that the `Disk Read Rate
(IOPS)`, `Disk Write Rate (IOPS)`, `Disk Read Rate (BPS)`, `Disk Write Rate
(BPS)` data were in the disk offering created in the step 1 and the `Max IOPS`
data was in the disk offering created in the step 2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [HEALTH] 4.19/main Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #7344: URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1877604620 @shwstppr a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19/main Health Check, please don't merge this! [cloudstack]
shwstppr commented on PR #7344: URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1877601987 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix KVM import and list unmanaged VMs [cloudstack]
blueorangutan commented on PR #8445: URL: https://github.com/apache/cloudstack/pull/8445#issuecomment-1877602080 @shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix KVM import and list unmanaged VMs [cloudstack]
shwstppr commented on PR #8445: URL: https://github.com/apache/cloudstack/pull/8445#issuecomment-1877600670 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix VMware VM ingestion template selection and default template failure [cloudstack]
blueorangutan commented on PR #8429: URL: https://github.com/apache/cloudstack/pull/8429#issuecomment-1877598615 [SF] Trillian test result (tid-8719) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 47062 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8429-t8719-vmware-70u3.zip Smoke tests completed. 120 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_balanced_drs_algorithm | `Error` | 424.72 | test_cluster_drs.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix KVM import and list unmanaged VMs [cloudstack]
blueorangutan commented on PR #8445: URL: https://github.com/apache/cloudstack/pull/8445#issuecomment-1877594832 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Refactor updateDiskOffering API [cloudstack]
hsato03 opened a new pull request, #8446:
URL: https://github.com/apache/cloudstack/pull/8446
### Description
This PR intends to refactor the `updateDiskOffering` API due to its size.
This method was separated into others in order to improve the readability of
the disk offering update process.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [X] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
I called the `updateDiskOffering` API and it is working as it did before the
refactoring. I also created some unit tests to maintain the current behavior
and avoid regressions in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] UI: Support enabling Elements of the Network Service Providers [cloudstack]
JoaoJandre commented on issue #8357: URL: https://github.com/apache/cloudstack/issues/8357#issuecomment-1877582735 As this is an improvement request, it is better suited for version 4.20.0, as 4.18.2 is mainly for bug fixes and critical issues. I'll be moving the milestone to 4.20.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix KVM import and list unmanaged VMs [cloudstack]
blueorangutan commented on PR #8445: URL: https://github.com/apache/cloudstack/pull/8445#issuecomment-1877515876 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix KVM import and list unmanaged VMs [cloudstack]
shwstppr commented on PR #8445: URL: https://github.com/apache/cloudstack/pull/8445#issuecomment-1877513144 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] LDAP API Error "does not contain a URL" java.naming.provider.url property does not contain a URL [cloudstack]
DaanHoogland commented on issue #8336: URL: https://github.com/apache/cloudstack/issues/8336#issuecomment-1877484751 @JoaoJandre I am not sure if this is a bug or environmental yet. If it is a bug sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix KVM import and list unmanaged VMs [cloudstack]
codecov[bot] commented on PR #8445: URL: https://github.com/apache/cloudstack/pull/8445#issuecomment-1877479336 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8445?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`746bae7`)](https://app.codecov.io/gh/apache/cloudstack/commit/746bae740eaa4a1cb2c130fa87c3ee05411228b1?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 30.79% compared to head [(`309c09b`)](https://app.codecov.io/gh/apache/cloudstack/pull/8445?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 4.39%. Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8445 +/- ## - Coverage 30.79% 4.39% -26.40% Files 5341 361 -4980 Lines374869 28621 -346248 Branches 545204992-49528 - Hits 1154291258 -114171 + Misses 244184 27224 -216960 + Partials 15256 139-15117 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8445/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8445/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8445/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.39% <ø> (ø)` | | | [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8445/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8445?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (cloudstack-www): Workflow run "Pages" is working again!
The GitHub Actions job "Pages" on cloudstack-www.git has succeeded. Run started by GitHub user DaanHoogland (triggered by DaanHoogland). Head commit for run: 76abc55816dcce7530bbdaf51347d1533d034808 / dahn bootstrap tabs working in docusaurus (#126) Report URL: https://github.com/apache/cloudstack-www/actions/runs/7412610004 With regards, GitHub Actions via GitBox
(cloudstack-www) branch docusaurus-staging updated (e36c81df -> 76abc558)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from e36c81df new design for cloud-builders (#124) add 76abc558 bootstrap tabs working in docusaurus (#126) No new revisions were added by this update. Summary of changes: docusaurus.config.js | 9 - static/scripts/bootstrap.bundle.min.js | 33 + 2 files changed, 41 insertions(+), 1 deletion(-) create mode 100644 static/scripts/bootstrap.bundle.min.js
[GH] (cloudstack-www): Workflow run "Pages" failed!
The GitHub Actions job "Pages" on cloudstack-www.git has failed. Run started by GitHub user DaanHoogland (triggered by DaanHoogland). Head commit for run: c782e3ebcd80fc21c0082d78a5117dd8a14a9e34 / dahn Update docusaurus.config.js Report URL: https://github.com/apache/cloudstack-www/actions/runs/7412583513 With regards, GitHub Actions via GitBox
[PR] Fix KVM import and list unmanaged VMs [cloudstack]
slavkap opened a new pull request, #8445:
URL: https://github.com/apache/cloudstack/pull/8445
### Description
This PR fixes part (issues 2 and3) of #8439
1 - Fix of VM insert for VMs with StorPool volumes
2 - Fix of the list/insert unmanaged VMs with RBD volumes
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### How Has This Been Tested?
manually tested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (cloudstack-www): Workflow run "Pages" failed!
The GitHub Actions job "Pages" on cloudstack-www.git has failed. Run started by GitHub user DaanHoogland (triggered by DaanHoogland). Head commit for run: 98fe27665f2f7e27ec839b2b814239428458a473 / Daan Hoogland have bootstrap tabs working in docusaurus Report URL: https://github.com/apache/cloudstack-www/actions/runs/7412573062 With regards, GitHub Actions via GitBox
Re: [I] LDAP API Error "does not contain a URL" java.naming.provider.url property does not contain a URL [cloudstack]
JoaoJandre commented on issue #8336: URL: https://github.com/apache/cloudstack/issues/8336#issuecomment-1877166442 It might be interesting to add this to 4.18.2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (cloudstack-www): Workflow run "Pages" failed!
The GitHub Actions job "Pages" on cloudstack-www.git has failed. Run started by GitHub user DaanHoogland (triggered by DaanHoogland). Head commit for run: a78dbcc294e1d1948d463305c112138082ea5865 / Daan Hoogland new integrations page Report URL: https://github.com/apache/cloudstack-www/actions/runs/7410651065 With regards, GitHub Actions via GitBox
[GH] (cloudstack-www): Workflow run "Pages" failed!
The GitHub Actions job "Pages" on cloudstack-www.git has failed. Run started by GitHub user DaanHoogland (triggered by DaanHoogland). Head commit for run: ab15bb0dfca4e98c4df7df18ba38c9902e6950f3 / Daan Hoogland new integrations page Report URL: https://github.com/apache/cloudstack-www/actions/runs/7410628693 With regards, GitHub Actions via GitBox
Re: [PR] [HEALTH] 4.19/main Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #7344: URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1877131227 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Some issues with managed/unmanaged VMs on KVM [cloudstack]
slavkap commented on issue #8439: URL: https://github.com/apache/cloudstack/issues/8439#issuecomment-1877101910 @shwstppr, yes, I will work on the second issue and probably will try to fix the problem with Ceph. For the first one, I need to understand the whole feature and right now I don't have much time :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (cloudstack-www): Workflow run "Pages" is working again!
The GitHub Actions job "Pages" on cloudstack-www.git has succeeded. Run started by GitHub user DaanHoogland (triggered by DaanHoogland). Head commit for run: e36c81df9a6a0666fec63d39306a3074c661c188 / dahn new design for cloud-builders (#124) Report URL: https://github.com/apache/cloudstack-www/actions/runs/7410177099 With regards, GitHub Actions via GitBox
(cloudstack-www) branch docusaurus-staging updated (4904fa86 -> e36c81df)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from 4904fa86 New design for kubernetes (#123) add e36c81df new design for cloud-builders (#124) No new revisions were added by this update. Summary of changes: src/pages/cloud-builders.mdx | 72 -- src/pages/cloud-builders/index.js | 200 ++ 2 files changed, 200 insertions(+), 72 deletions(-) delete mode 100644 src/pages/cloud-builders.mdx create mode 100644 src/pages/cloud-builders/index.js
[GH] (cloudstack-www): Workflow run "Pages" failed!
The GitHub Actions job "Pages" on cloudstack-www.git has failed. Run started by GitHub user DaanHoogland (triggered by DaanHoogland). Head commit for run: 139bbeebc08f1a5f5898019b9b846482bc164b81 / Daan Hoogland new design for cloud-builders Report URL: https://github.com/apache/cloudstack-www/actions/runs/7410147123 With regards, GitHub Actions via GitBox
Re: [PR] schema,engine-schema: explicit VMware 8.0.0.2 support, logs [cloudstack]
blueorangutan commented on PR #8444: URL: https://github.com/apache/cloudstack/pull/8444#issuecomment-1877090584 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (cloudstack-www): Workflow run "Pages" is working again!
The GitHub Actions job "Pages" on cloudstack-www.git has succeeded. Run started by GitHub user DaanHoogland (triggered by DaanHoogland). Head commit for run: 4904fa86b6067711fd7dc7b05ef472bb99b83728 / dahn New design for kubernetes (#123) Report URL: https://github.com/apache/cloudstack-www/actions/runs/7410083053 With regards, GitHub Actions via GitBox
(cloudstack-www) branch docusaurus-staging updated (6937fe36 -> 4904fa86)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from 6937fe36 static design from ui dev incorporated for main page add 4904fa86 New design for kubernetes (#123) No new revisions were added by this update. Summary of changes: src/pages/kubernetes.mdx | 107 src/pages/kubernetes/index.js | 290 ++ 2 files changed, 290 insertions(+), 107 deletions(-) delete mode 100644 src/pages/kubernetes.mdx create mode 100644 src/pages/kubernetes/index.js
[GH] (cloudstack-www): Workflow run "Pages" failed!
The GitHub Actions job "Pages" on cloudstack-www.git has failed. Run started by GitHub user DaanHoogland (triggered by DaanHoogland). Head commit for run: 03853f9bd6aaea4312a227a7021ff83871c0dbab / Daan Hoogland whitespace Report URL: https://github.com/apache/cloudstack-www/actions/runs/7410038457 With regards, GitHub Actions via GitBox
Re: [PR] [HEALTH] 4.19/main Health Check, please don't merge this! [cloudstack]
sonarcloud[bot] commented on PR #7344: URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1877084804 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack=7344) **Quality Gate passed** Kudos, no new issues were introduced! [0 New issues](https://sonarcloud.io/project/issues?id=apache_cloudstack=7344=false=true) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack=7344=false=true) No data about Coverage No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_cloudstack=7344) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack-www) branch docusaurus-staging updated (a8392c1f -> 6937fe36)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git omit a8392c1f new design for kubernetes omit dd00b818 new design / omit a9279585 static design from ui dev incorporated for main page add 6937fe36 static design from ui dev incorporated for main page This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (a8392c1f) \ N -- N -- N refs/heads/docusaurus-staging (6937fe36) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: src/pages/kubernetes.mdx | 107 src/pages/kubernetes/index.js | 290 -- 2 files changed, 107 insertions(+), 290 deletions(-) create mode 100644 src/pages/kubernetes.mdx delete mode 100644 src/pages/kubernetes/index.js
(cloudstack-www) branch docusaurus-staging updated (dd00b818 -> a8392c1f)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from dd00b818 new design / add a8392c1f new design for kubernetes No new revisions were added by this update. Summary of changes: src/pages/kubernetes.mdx | 107 src/pages/kubernetes/index.js | 290 ++ 2 files changed, 290 insertions(+), 107 deletions(-) delete mode 100644 src/pages/kubernetes.mdx create mode 100644 src/pages/kubernetes/index.js
(cloudstack-www) branch docusaurus-staging updated (a199c823 -> dd00b818)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from a199c823 blog in old site procedure add a9279585 static design from ui dev incorporated for main page add dd00b818 new design / No new revisions were added by this update. Summary of changes: docusaurus.config.js | 61 +- docusaurus.config.js.blog | 61 +- src/css/custom.css | 3692 src/css/img/ansible_bkg.png| Bin 0 -> 7885 bytes src/css/img/blue_splash_updated.svg| 21 + src/css/img/blue_splash_v2.png | Bin 0 -> 428964 bytes src/css/img/ceph_bkg.png | Bin 0 -> 156989 bytes src/css/img/citrix_bkg.png | Bin 0 -> 39246 bytes src/css/img/cloudian_bkg.png | Bin 0 -> 2164 bytes src/css/img/gluster_bkg.svg| 207 ++ src/css/img/grey_splash_updated.svg|7 + src/css/img/kubernetes_logo_banner.png | Bin 0 -> 492808 bytes src/css/img/light_blue_HERO_splash.png | Bin 0 -> 81282 bytes src/css/img/light_blue_splash_updated.svg | 17 + src/css/img/light_grey_splash.svg | 17 + src/css/img/light_lavander_HERO_splash.png | Bin 0 -> 81363 bytes src/css/img/light_lavander_HERO_splash.svg | 26 + src/css/img/pure_storage_bkg.svg | 63 + src/css/img/splash_outline_blue.png| Bin 0 -> 64555 bytes src/css/img/splash_outline_purple.png | Bin 0 -> 74606 bytes src/css/img/terraform_bkg.svg | 40 + src/css/img/veeam_bkg.png | Bin 0 -> 21329 bytes src/pages/index.tsx| 422 ++- static/img/ACS_logo.svg| 46 + static/img/ACS_logo_slogan.svg | 52 + ...ache CloudStack Infrastructure_illustration.svg | 513 +++ .../img/Apache CloudStack Proof of Concept_img.png | Bin 0 -> 73131 bytes static/img/Apache CloudStack at a Glance_img.png | Bin 0 -> 121850 bytes static/img/BT_logo.svg |7 + static/img/Backup_icon.svg | 29 + static/img/CloudOps_logo.svg | 20 + .../CloudStack_cloud_builderfs_illustration.png| Bin 0 -> 80024 bytes static/img/CloudStack_monkey_cloud.png | Bin 0 -> 193338 bytes static/img/CloudStack_release_illustration.png | Bin 0 -> 97614 bytes static/img/CloudStack_release_illustration2.png| Bin 0 -> 67716 bytes static/img/CloudStack_survey.png | Bin 0 -> 279076 bytes static/img/CloudStack_survey2.png | Bin 0 -> 275245 bytes static/img/CloudStack_survey3.png | Bin 0 -> 341774 bytes static/img/CloudStack_survey4.png | Bin 0 -> 273184 bytes static/img/Cloud_Solution_icon.svg | 29 + .../img/Delivering Public Cloud Services_img.png | Bin 0 -> 46485 bytes static/img/Frauhofer_logo.svg | 21 + static/img/Hypervisors_icon.svg| 33 + static/img/IKOULA_img.png | Bin 0 -> 60342 bytes static/img/KVM_logo.svg| 201 ++ static/img/Kshtish_img.png | Bin 0 -> 6279 bytes static/img/LinBit_img.png | Bin 0 -> 25891 bytes static/img/Logo_arsat.png | Bin 0 -> 1893 bytes static/img/M5Hosting_logo.png | Bin 0 -> 4416 bytes static/img/MSPs_icon.svg | 26 + static/img/MS_hyper-v_logo.png | Bin 0 -> 6067 bytes static/img/Multi-hypervisor_illustration.png | Bin 0 -> 107477 bytes static/img/StorPool Storage_img.png| Bin 0 -> 20924 bytes static/img/Sven_img.png| Bin 0 -> 3725 bytes static/img/Tamara_img.png | Bin 0 -> 6270 bytes static/img/Telcos_icon.svg | 34 + static/img/Terraform Solution Brief_img.png| Bin 0 -> 32700 bytes static/img/VM_ware_logo.svg| 16 + static/img/XCP-ng_logo.png | Bin 0 -> 5009 bytes static/img/Your.Online_img.png | Bin 0 -> 120262 bytes static/img/acronis_logo.svg| 16 + static/img/ansible_logo.svg| 12 + static/img/apache_cloudstack_services.png | Bin 0 -> 56146 bytes static/img/apiculus_logo.svg | 19 + static/img/automation_icon.svg | 26 + static/img/blog_icon.svg | 10 +
Re: [PR] JRE17 Migration Investigation [cloudstack]
blueorangutan commented on PR #8438: URL: https://github.com/apache/cloudstack/pull/8438#issuecomment-1877031404 @rohityadavcloud [SL] unsupported parameters provided. Supported mgmt server os are: `centos7, centos6, suse15, alma8, ubuntu18, ubuntu22, ubuntu20, rocky8, alma9`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-rocky8, kvm-alma8, kvm-alma9, kvm-ubuntu18, kvm-ubuntu20, kvm-ubuntu22, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, vmware-70u3, vmware-80, vmware-80u1, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] JRE17 Migration Investigation [cloudstack]
rohityadavcloud commented on PR #8438: URL: https://github.com/apache/cloudstack/pull/8438#issuecomment-1877029491 @blueorangutan test ol8 kvm-ol8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19/main Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #7344: URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1877028757 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]
blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1877028818 @sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19/main Health Check, please don't merge this! [cloudstack]
shwstppr commented on PR #7344: URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1877028266 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ui: fix default domainid for add account [cloudstack]
shwstppr merged PR #8435: URL: https://github.com/apache/cloudstack/pull/8435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch main updated (66ae96b5eb6 -> 746bae740ea)
This is an automated email from the ASF dual-hosted git repository. shwstppr pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 66ae96b5eb6 ui: fix layout for action button for template form (#8434) add 746bae740ea ui: fix default domainid for add account (#8435) No new revisions were added by this update. Summary of changes: ui/src/views/iam/AddAccount.vue | 1 - 1 file changed, 1 deletion(-)
Re: [PR] [HEALTH] 4.19/main Health Check, please don't merge this! [cloudstack]
shwstppr closed pull request #7344: [HEALTH] 4.19/main Health Check, please don't merge this! URL: https://github.com/apache/cloudstack/pull/7344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]
sureshanaparti commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1877019500 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.19/main Health Check, please don't merge this! [cloudstack]
shwstppr closed pull request #7344: [HEALTH] 4.19/main Health Check, please don't merge this! URL: https://github.com/apache/cloudstack/pull/7344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Some issues with managed/unmanaged VMs on KVM [cloudstack]
shwstppr commented on issue #8439: URL: https://github.com/apache/cloudstack/issues/8439#issuecomment-1877004929 @DaanHoogland @slavkap I don't think the issues should be considered blockers. KVM ingestion has been added recently and maybe we can document some of the unsupported cases. It would be great if we could have fixes for these though @slavkap do you plan to fix any? :smile: @nvazquez any suggestions as you've recently worked on it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] minio: fix store user creation [cloudstack]
shwstppr commented on code in PR #8425:
URL: https://github.com/apache/cloudstack/pull/8425#discussion_r1441677939
##
plugins/storage/object/minio/src/main/java/org/apache/cloudstack/storage/datastore/driver/MinIOObjectStoreDriverImpl.java:
##
@@ -250,20 +258,28 @@ public void deleteBucketPolicy(String bucketName, long
storeId) {
}
+protected void updateAccountCredentials(final long accountId, final String
accessKey, final String secretKey) {
+Map details = new HashMap<>();
+details.put(MINIO_ACCESS_KEY, accessKey);
+details.put(MINIO_SECRET_KEY, secretKey);
+_accountDetailsDao.persist(accountId, details);
+}
+
@Override
public boolean createUser(long accountId, long storeId) {
Account account = _accountDao.findById(accountId);
MinioAdminClient minioAdminClient = getMinIOAdminClient(storeId);
-String accessKey = "acs-"+account.getAccountName();
+String accessKey = getUserOrAccessKeyForAccount(account);
// Check user exists
try {
UserInfo userInfo = minioAdminClient.getUserInfo(accessKey);
if(userInfo != null) {
-s_logger.debug("User already exists in MinIO store:
"+accessKey);
+s_logger.info(String.format("User already exists in MinIO
store: %s, updating credentials", accessKey));
+updateAccountCredentials(accountId, accessKey,
userInfo.secretKey());
return true;
}
} catch (Exception e) {
-s_logger.debug("User does not exist. Creating user: "+accessKey);
+s_logger.debug("User does not exist. Creating user: " + accessKey);
Review Comment:
@DaanHoogland I don't think we need error level here. Based on the code I
understand ideally user shouldn't exist on the object store we create one.
Though I'm not sure if we should catchall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]
github-actions[bot] commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1876994689 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ui: fix default domainid for add account [cloudstack]
shwstppr commented on code in PR #8435:
URL: https://github.com/apache/cloudstack/pull/8435#discussion_r1441672253
##
ui/src/views/iam/AddAccount.vue:
##
@@ -303,7 +303,6 @@ export default {
} else {
this.loadMore(apiToCall, page + 1, sema)
}
-this.form.domainid = 0
Review Comment:
@rohityadavcloud don't think we need to remove domainid from the object as
API call will be just adding to the existing list so previous selection will
still be there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(cloudstack) branch main updated: ui: fix layout for action button for template form (#8434)
This is an automated email from the ASF dual-hosted git repository.
shwstppr pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/main by this push:
new 66ae96b5eb6 ui: fix layout for action button for template form (#8434)
66ae96b5eb6 is described below
commit 66ae96b5eb6ae6cdeb3f78fa08ea530461054c88
Author: Abhishek Kumar
AuthorDate: Thu Jan 4 17:33:55 2024 +0530
ui: fix layout for action button for template form (#8434)
Fixes layout for the action buttons on register template form
Signed-off-by: Abhishek Kumar
---
ui/src/views/image/RegisterOrUploadTemplate.vue | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/ui/src/views/image/RegisterOrUploadTemplate.vue
b/ui/src/views/image/RegisterOrUploadTemplate.vue
index 400d096596c..999a1b8d120 100644
--- a/ui/src/views/image/RegisterOrUploadTemplate.vue
+++ b/ui/src/views/image/RegisterOrUploadTemplate.vue
@@ -429,8 +429,10 @@
-{{ $t('label.cancel') }}
-{{ $t('label.ok') }}
+
+ {{ $t('label.cancel') }}
+ {{ $t('label.ok') }}
+
Re: [PR] ui: fix layout for action button for template form [cloudstack]
shwstppr merged PR #8434: URL: https://github.com/apache/cloudstack/pull/8434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ui: fix default domainid for add account [cloudstack]
rohityadavcloud commented on code in PR #8435:
URL: https://github.com/apache/cloudstack/pull/8435#discussion_r1441668829
##
ui/src/views/iam/AddAccount.vue:
##
@@ -303,7 +303,6 @@ export default {
} else {
this.loadMore(apiToCall, page + 1, sema)
}
-this.form.domainid = 0
Review Comment:
not sure if it's applicable here - there's also a way to delete
this.form.domainid if the key/value need to be removed from the object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] schema,engine-schema: explicit VMware 8.0.0.2 support, logs [cloudstack]
codecov[bot] commented on PR #8444: URL: https://github.com/apache/cloudstack/pull/8444#issuecomment-1876981857 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8444?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`9d4f071`)](https://app.codecov.io/gh/apache/cloudstack/commit/9d4f0715d434c8ee1e064f8681093133241e34e2?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 30.80% compared to head [(`9e3edb2`)](https://app.codecov.io/gh/apache/cloudstack/pull/8444?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 4.39%. > Report is 2 commits behind head on main. Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8444 +/- ## - Coverage 30.80% 4.39% -26.42% Files 5341 361 -4980 Lines374864 28622 -346242 Branches 545184992-49526 - Hits 1154851258 -114227 + Misses 244114 27225 -216889 + Partials 15265 139-15126 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8444/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8444/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8444/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.39% <ø> (ø)` | | | [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8444/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8444?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]
blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1876981680 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch main updated: Fix bootstrap exceptions (#8397)
This is an automated email from the ASF dual-hosted git repository.
shwstppr pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/main by this push:
new 687610dd5f5 Fix bootstrap exceptions (#8397)
687610dd5f5 is described below
commit 687610dd5f5c41c99ac9e7161481396a3c2305ae
Author: João Jandre <48719461+joaojan...@users.noreply.github.com>
AuthorDate: Thu Jan 4 08:57:24 2024 -0300
Fix bootstrap exceptions (#8397)
During management server initialization, some EmptyStackException and
BeansException exceptions are always thrown; These exceptions do not affect
ACS, however, they can cause confusion when observing the management server
startup logs with DEBUG level on. The causes of the exceptions have been
addressed.
Co-authored-by: João Jandre
---
.../module/model/impl/DefaultModuleDefinitionSet.java | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git
a/framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/model/impl/DefaultModuleDefinitionSet.java
b/framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/model/impl/DefaultModuleDefinitionSet.java
index 83d2feaa845..6c03c3ce9e1 100644
---
a/framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/model/impl/DefaultModuleDefinitionSet.java
+++
b/framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/model/impl/DefaultModuleDefinitionSet.java
@@ -101,9 +101,13 @@ public class DefaultModuleDefinitionSet implements
ModuleDefinitionSet {
log.debug(String.format("Trying to obtain module [%s]
context.", moduleDefinitionName));
ApplicationContext context =
getApplicationContext(moduleDefinitionName);
try {
-Runnable runnable = context.getBean("moduleStartup",
Runnable.class);
-log.info(String.format("Starting module [%s].",
moduleDefinitionName));
-runnable.run();
+if (context.containsBean("moduleStartup")) {
+Runnable runnable =
context.getBean("moduleStartup", Runnable.class);
+log.info(String.format("Starting module [%s].",
moduleDefinitionName));
+runnable.run();
+} else {
+log.debug(String.format("Could not get module [%s]
context bean.", moduleDefinitionName));
+}
} catch (BeansException e) {
log.warn(String.format("Failed to start module [%s]
due to: [%s].", moduleDefinitionName, e.getMessage()));
if (log.isDebugEnabled()) {
@@ -126,6 +130,10 @@ public class DefaultModuleDefinitionSet implements
ModuleDefinitionSet {
public void with(ModuleDefinition def, Stack
parents) {
try {
String moduleDefinitionName = def.getName();
+if (parents.isEmpty()) {
+log.debug(String.format("Could not find module [%s]
context as they have no parents.", moduleDefinitionName));
+return;
+}
log.debug(String.format("Trying to obtain module [%s]
context.", moduleDefinitionName));
ApplicationContext parent =
getApplicationContext(parents.peek().getName());
log.debug(String.format("Trying to load module [%s]
context.", moduleDefinitionName));
Re: [PR] Fix bootstrap exceptions [cloudstack]
shwstppr merged PR #8397: URL: https://github.com/apache/cloudstack/pull/8397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch main updated: ui: fix ssl check in image store browser (#8430)
This is an automated email from the ASF dual-hosted git repository.
shwstppr pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/main by this push:
new 2eaed804351 ui: fix ssl check in image store browser (#8430)
2eaed804351 is described below
commit 2eaed80435113f24ba7b66397d7a41079bd2b68b
Author: Vishesh
AuthorDate: Thu Jan 4 17:26:07 2024 +0530
ui: fix ssl check in image store browser (#8430)
This PR fixes the ssl in image store browser.
---
ui/src/components/view/ObjectStoreBrowser.vue | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/src/components/view/ObjectStoreBrowser.vue
b/ui/src/components/view/ObjectStoreBrowser.vue
index f2e68c8b954..531846a9da5 100644
--- a/ui/src/components/view/ObjectStoreBrowser.vue
+++ b/ui/src/components/view/ObjectStoreBrowser.vue
@@ -449,7 +449,7 @@ export default {
initMinioClient () {
if (!this.client) {
const url =
/https?:\/\/([^/]+)\/?/.exec(this.resource.url.split(this.resource.name)[0])[1]
-const isHttps = /^https/.test(url)
+const isHttps = /^https/.test(this.resource.url)
this.client = new Minio.Client({
endPoint: url.split(':')[0],
port: url.split(':').length > 1 ? parseInt(url.split(':')[1]) :
isHttps ? 443 : 80,
Re: [PR] Fix ssl check in object store browser [cloudstack]
shwstppr merged PR #8430: URL: https://github.com/apache/cloudstack/pull/8430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] VMware: VM ingestion broken in case of dynamically handled hypervisor/guest OS versions. [cloudstack]
shwstppr commented on issue #8412: URL: https://github.com/apache/cloudstack/issues/8412#issuecomment-1876974206 Based on the discussion with some of the participants here, I've created https://github.com/apache/cloudstack/pull/8444 to explicitly add support for VMware 8.0.0.2 and also add logs when capabilities retrieval falls back to the parent version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] schema,engine-schema: explicit VMware 8.0.0.2 support, logs [cloudstack]
blueorangutan commented on PR #8444: URL: https://github.com/apache/cloudstack/pull/8444#issuecomment-1876973320 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] schema,engine-schema: explicit VMware 8.0.0.2 support, logs [cloudstack]
shwstppr commented on PR #8444: URL: https://github.com/apache/cloudstack/pull/8444#issuecomment-1876972040 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] schema,engine-schema: explicit VMware 8.0.0.2 support, logs [cloudstack]
shwstppr opened a new pull request, #8444:
URL: https://github.com/apache/cloudstack/pull/8444
### Description
Fixes https://github.com/apache/cloudstack/issues/8412
Add support for 8.0.0.2 explicitly to prevent falling over to the parent
version
Adds log when hypervisor capabilities falling over to the parent version
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[I] Provide option of disabling the vpn users [cloudstack]
kiranchavala opened a new issue, #8443: URL: https://github.com/apache/cloudstack/issues/8443 ISSUE TYPE Enhancement/Improvement Request COMPONENT NAME Component: API/ UI CLOUDSTACK VERSION Cloudstack version 4.18, SUMMARY Provide option of disabling the vpn users Steps to reproduce the issue 1. Navigate to Network > VPN Users 2. Create a vpn user 3. There is no option to disable the vpn user  The only option present is to remove it It would be great if Cloudstack could follow the similar behavior of normal users of cloudstack  Currently, there is only removevpnuser api call https://cloudstack.apache.org/api/apidocs-4.18/apis/removeVpnUser.html Expected behavior Cloudstack can have a disableVPNuser api call similar to https://cloudstack.apache.org/api/apidocs-4.18/apis/disableUser.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Provide the option of disabling/Enabling Shared/Isolated/L2 networks, [cloudstack]
kiranchavala opened a new issue, #8442: URL: https://github.com/apache/cloudstack/issues/8442 ISSUE TYPE Enhancement/Improvement Request /Bug COMPONENT NAME Component: API/ UI CLOUDSTACK VERSION Cloudstack version 4.18, SUMMARY Provide the option of disabling/Enabling Shared/Isolated/L2 networks, Steps to reproduce the issue 1. Create a Shared network 2. Click on edit network  3. Currently, the only option is to use the updateNetwork api call and update the parameter "displaynetwork" or perform the action from UI https://cloudstack.apache.org/api/apidocs-4.18/apis/updateNetwork.html 4. But once the network is displaynetwork is set to true, there is no option to enable it back from UI **Bug part** 5. Also listNetwork api call doesn't list the networks where displaynetwork is set even when the listall parameter is passeed https://cloudstack.apache.org/api/apidocs-4.18/apis/listNetworks.html list networks filter=name,displaynetwork, listall=true **Expected behavior** It would be great, if we can add enable/disable network option or provide an option to disable the display network, in the UI or show some sort of filter column in the Ui for the list network page. Currently the admin user has update the database or execute the api call to display the network back again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Updating the secondary storage to readonly or readwrite doesn't show in the UI (Access) [cloudstack]
kiranchavala opened a new issue, #8441: URL: https://github.com/apache/cloudstack/issues/8441 ISSUE TYPE Enhancement/Improvement Request/ BUG COMPONENT NAME Component: API/ UI CLOUDSTACK VERSION Cloudstack version 4.18, SUMMARY Updating the secondary storage to read-only or read-write doesn't show in the UI (Access) **Steps to reproduce the issue** 1. Navigate To Infrastructure > Secondary Storage 2. Click on particular Secondary storage make it readonly. Also, there is no event generated for this action Screenshots   **Bug part** 3. Navigate Back To Infrastructure > Secondary Storage, there is no Data under Access Column  Backend api call https://cloudstack.apache.org/api/apidocs-4.18/apis/updateImageStore.html Expected behaviour For an Admin user, Cloudstack should show whether the storage is in ready only or ready write status in the UI. The respective event should also be populated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Provide the option of disabling the service offerings, system offerings, disk offerings [cloudstack]
kiranchavala opened a new issue, #8440: URL: https://github.com/apache/cloudstack/issues/8440 ISSUE TYPE Enhancement/Improvement Request COMPONENT NAME Component: API/ UI CLOUDSTACK VERSION Cloudstack version 4.18, SUMMARY Provide the option of disabling the service offerings, system offerings, disk offerings Currently, the following api's support Disabling the offering via state parameter and also in the UI https://cloudstack.apache.org/api/apidocs-4.18/apis/updateNetworkOffering.html https://cloudstack.apache.org/api/apidocs-4.18/apis/updateVPCOffering.html Screenshots   If Cloudstack could extend the same behavior to the service offering, system offerings, disk offering , it would be great https://cloudstack.apache.org/api/apidocs-4.18/apis/updateServiceOffering.html https://cloudstack.apache.org/api/apidocs-4.18/apis/updateDiskOffering.html So that if a particular service/disk offering is disabled, it won't be listed in the vm deployment page Currently, cloudstack can only update the offering access Screenshots  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ui: fix default domainid for add account [cloudstack]
shwstppr commented on PR #8435: URL: https://github.com/apache/cloudstack/pull/8435#issuecomment-1876948205 @DaanHoogland it is working for me. For you is the page to opening or login not working or the fix not working? Incognito window may help -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Some issues with managed/unmanaged VMs on KVM [cloudstack]
slavkap commented on issue #8439: URL: https://github.com/apache/cloudstack/issues/8439#issuecomment-1876904632 @DaanHoogland, it is not a blocker except if somebody uses the Basic network (the first issue). 2 and 3 probably can be fixed first with some limitation in the code that it works only for NFS and shared storage -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Some issues with managed/unmanaged VMs on KVM [cloudstack]
DaanHoogland commented on issue #8439: URL: https://github.com/apache/cloudstack/issues/8439#issuecomment-1876896181 @slavkap, Do you consider any of these issues a blocker? Does it make sense to split the issue in three tickets? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]
blueorangutan commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1876895785 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]
sureshanaparti commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1876894054 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]
sureshanaparti commented on PR #8418: URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1876893306 > @sureshanaparti, along with these changes is it better to call the registerUserData API using POST from UI ? changes done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add e2e tests for listing resources [cloudstack]
DaanHoogland commented on PR #8410: URL: https://github.com/apache/cloudstack/pull/8410#issuecomment-1876891458 the vmware version: Smoke tests completed. 127 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_balanced_drs_algorithm | `Failure` | 125.08 | test_cluster_drs.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
