Re: [PR] NSX integration [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #7919:
URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1901714714

   @nvazquez a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, 
rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run 
smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NSX integration [cloudstack]

2024-01-19 Thread via GitHub


nvazquez commented on PR #7919:
URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1901713699

   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] ui: fix create k8s cluster networks listing [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #8539:
URL: https://github.com/apache/cloudstack/pull/8539#issuecomment-1901703243

   UI build: :heavy_check_mark:
   Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8539 (QA-JID-266)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add advance settings to fine tune DRS imbalance calculation [cloudstack]

2024-01-19 Thread via GitHub


harikrishna-patnala commented on code in PR #8521:
URL: https://github.com/apache/cloudstack/pull/8521#discussion_r1460162351


##
plugins/drs/cluster/condensed/src/main/java/org/apache/cloudstack/cluster/Condensed.java:
##
@@ -21,78 +21,61 @@
 
 import com.cloud.host.Host;
 import com.cloud.offering.ServiceOffering;
-import com.cloud.utils.Pair;
 import com.cloud.utils.Ternary;
 import com.cloud.utils.component.AdapterBase;
 import com.cloud.vm.VirtualMachine;
+import org.apache.cloudstack.framework.config.ConfigKey;
 
 import javax.naming.ConfigurationException;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
 
 import static 
org.apache.cloudstack.cluster.ClusterDrsService.ClusterDrsImbalanceThreshold;
-import static org.apache.cloudstack.cluster.ClusterDrsService.ClusterDrsMetric;
+import static 
org.apache.cloudstack.cluster.ClusterDrsService.ClusterDrsMetricType;
 
 public class Condensed extends AdapterBase implements ClusterDrsAlgorithm {

Review Comment:
   @vishesh92 you will need to extend Configurable interface and add 
"ClusterDrsImbalanceSkipThreshold" in getConfigKeys() method to save this new 
config in the database.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] ui: fix create k8s cluster networks listing [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #8539:
URL: https://github.com/apache/cloudstack/pull/8539#issuecomment-1901681385

   @harikrishna-patnala a Jenkins job has been kicked to build UI QA env. I'll 
keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] systemvm: vncport evaluation [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #8369:
URL: https://github.com/apache/cloudstack/pull/8369#issuecomment-1901681325

   [SF] Trillian test result (tid-8886)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 53461 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8369-t8886-kvm-centos7.zip
   Smoke tests completed. 107 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_08_migrate_vm | `Error` | 0.06 | test_vm_life_cycle.py
   test_05_rvpc_multi_tiers | `Failure` | 719.27 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 719.29 | test_vpc_redundant.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] ui: fix create k8s cluster networks listing [cloudstack]

2024-01-19 Thread via GitHub


harikrishna-patnala commented on PR #8539:
URL: https://github.com/apache/cloudstack/pull/8539#issuecomment-1901680134

   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NSX integration [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #7919:
URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1901670271

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8390


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NSX integration [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #7919:
URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1901578181

   @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NSX integration [cloudstack]

2024-01-19 Thread via GitHub


nvazquez commented on PR #7919:
URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1901577833

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [WIP] System VMs/VRs upgrade to Python3 and Debian 12 [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #8497:
URL: https://github.com/apache/cloudstack/pull/8497#issuecomment-1901472213

   [SF] Trillian test result (tid-8883)
   Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22
   Total time taken: 52019 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8497-t8883-kvm-ubuntu22.zip
   Smoke tests completed. 121 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] on forName validate packages of classes to load [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-1901453628

   [SF] Trillian test result (tid-8885)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 45317 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8277-t8885-kvm-centos7.zip
   Smoke tests completed. 105 look OK, 4 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | 
test_affinity_groups.py
   ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | 
test_affinity_groups_projects.py
   test_01_non_strict_host_anti_affinity | `Error` | 0.08 | 
test_nonstrict_affinity_group.py
   test_02_non_strict_host_affinity | `Error` | 0.02 | 
test_nonstrict_affinity_group.py
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 829.15 | 
test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [WIP] System VMs/VRs upgrade to Python3 and Debian 12 [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #8497:
URL: https://github.com/apache/cloudstack/pull/8497#issuecomment-1901273521

   [SF] Trillian test result (tid-8881)
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server r8
   Total time taken: 47644 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8497-t8881-xenserver-71.zip
   Smoke tests completed. 121 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[I] Unable to delete old Secondary Storage [cloudstack]

2024-01-19 Thread via GitHub


nxsbi opened a new issue, #8540:
URL: https://github.com/apache/cloudstack/issues/8540

   
   
   # ISSUE TYPE
   
* Bug Report
   
   # COMPONENT NAME
   
   ~~~
   UI
   ~~~
   
   # CLOUDSTACK VERSION
   
   
   ~~~
   4.17.0
   ~~~
   
   # CONFIGURATION
   
   NA
   
   # OS / ENVIRONMENT
   
   
   CentOS 7
   # SUMMARY
   
   
   I need to retire an old Secondary Storage. I used the "migrate data from 
image store" option to move everything off. However, I am unable to delete the 
secondary storage.
   
   # STEPS TO REPRODUCE
   
   
   
   ~~~
   
   In log and on screen I see error - Cannot delete image store with active 
snapshots backup!
   
   
   I was able to find a similar issue - 
https://github.com/apache/cloudstack/issues/4613 - but seems it was not 
resolved. 
   I may be facing similar issue so checked the templates. 
   
   I also see that there are Template present in the old secondary storage. 
However, I do not see any way to delete the template from the old sec stor only 
without deleting from entire zone. 
   
   
   What is the correct way to ensure all necessary items are moved/deleted and 
I am able to delete secondary storage?
   
   
   ~~~
   
   
   
   # EXPECTED RESULTS
   
   
   ~~~
   On Secondary Storage Complete move, all components including templates 
should be moved and should be able to delete secondary storage.
   
   ~~~
   
   # ACTUAL RESULTS
   
   
   
   ~~~
   
   Getting error Cannot delete image store with active snapshots backup!
   
   
![image](https://github.com/apache/cloudstack/assets/71042351/5d9b464d-8143-4829-a498-8149fe0a978e)
   
   ~~~
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] ui: fix create k8s cluster networks listing [cloudstack]

2024-01-19 Thread via GitHub


codecov[bot] commented on PR #8539:
URL: https://github.com/apache/cloudstack/pull/8539#issuecomment-1901124879

   ## 
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8539?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Comparison is base 
[(`33bb92a`)](https://app.codecov.io/gh/apache/cloudstack/commit/33bb92acce2dd2f3b8a4c0d81fcc37a4714f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 13.16% compared to head 
[(`9ce80d5`)](https://app.codecov.io/gh/apache/cloudstack/pull/8539?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 13.16%.
   
   
   Additional details and impacted files
   
   
   ```diff
   @@Coverage Diff@@
   ##   4.18#8539   +/-   ##
   =
 Coverage 13.16%   13.16%   
 Complexity 9201 9201   
   =
 Files  2724 2724   
 Lines258077   258077   
 Branches  4022440224   
   =
 Hits  3398133981   
 Misses   219790   219790   
 Partials   4306 4306   
   ```
   
   
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8539?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #8530:
URL: https://github.com/apache/cloudstack/pull/8530#issuecomment-1901076751

   @weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) 
has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-01-19 Thread via GitHub


weizhouapache commented on PR #8530:
URL: https://github.com/apache/cloudstack/pull/8530#issuecomment-1901074446

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Veeam: Support Veeam 11 and 12 [cloudstack]

2024-01-19 Thread via GitHub


weizhouapache commented on PR #8241:
URL: https://github.com/apache/cloudstack/pull/8241#issuecomment-1901074025

   > @weizhouapache @DaanHoogland do we need to forward merge 4.18 branch now 
to cut 4.19 RC3 or can it wait for later?
   
   I can wait. 4.18.2/4.19.1 is good to me.
   (@rohityadavcloud might be the same)
   So it is up to you.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #8530:
URL: https://github.com/apache/cloudstack/pull/8530#issuecomment-1901069383

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8388


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Veeam: Support Veeam 11 and 12 [cloudstack]

2024-01-19 Thread via GitHub


shwstppr commented on PR #8241:
URL: https://github.com/apache/cloudstack/pull/8241#issuecomment-1901054977

   @weizhouapache @DaanHoogland do we need to forward merge 4.18 branch now to 
cut 4.19 RC3 or can it wait for later?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] ui: fix create k8s cluster networks listing [cloudstack]

2024-01-19 Thread via GitHub


shwstppr opened a new pull request, #8539:
URL: https://github.com/apache/cloudstack/pull/8539

   ### Description
   
   Fixes #8536
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] build/CI
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   
   
   
    How did you try to break this feature and the system with this change?
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NSX: Add passive monitor for NSX LB to test whether a server is available [cloudstack]

2024-01-19 Thread via GitHub


Pearl1594 commented on PR #8533:
URL: https://github.com/apache/cloudstack/pull/8533#issuecomment-1901043057

   @nvazquez please merge if you think it's good to go .. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NSX integration [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #7919:
URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1901028104

   @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NSX integration [cloudstack]

2024-01-19 Thread via GitHub


nvazquez commented on PR #7919:
URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1901027602

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(cloudstack) branch nsx-integration updated (330c99ca57b -> f01bb5d4400)

2024-01-19 Thread nvazquez
This is an automated email from the ASF dual-hosted git repository.

nvazquez pushed a change to branch nsx-integration
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


from 330c99ca57b fix test failure
 add f01bb5d4400 NSX: Improve segment deletion process (#8538)

No new revisions were added by this update.

Summary of changes:
 .../apache/cloudstack/resource/NsxResource.java| 35 +++---
 .../apache/cloudstack/service/NsxApiClient.java| 55 +++---
 .../apache/cloudstack/service/NsxServiceImpl.java  |  2 +-
 .../cloudstack/resource/NsxResourceTest.java   | 28 +++
 4 files changed, 62 insertions(+), 58 deletions(-)



Re: [PR] NSX: Improve segment deletion process [cloudstack]

2024-01-19 Thread via GitHub


nvazquez merged PR #8538:
URL: https://github.com/apache/cloudstack/pull/8538


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NSX: Improve segment deletion process [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #8538:
URL: https://github.com/apache/cloudstack/pull/8538#issuecomment-1901006478

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8387


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #8530:
URL: https://github.com/apache/cloudstack/pull/8530#issuecomment-1900983787

   @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will 
be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NSX integration [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #7919:
URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1900981925

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8386


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(cloudstack-kubernetes-provider) branch nsx-skip-firewall deleted (was 730e1584)

2024-01-19 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a change to branch nsx-skip-firewall
in repository 
https://gitbox.apache.org/repos/asf/cloudstack-kubernetes-provider.git


 was 730e1584 fix npe

The revisions that were on this branch are still contained in
other references; therefore, this change does not discard any commits
from the repository.



Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-01-19 Thread via GitHub


DaanHoogland commented on PR #8530:
URL: https://github.com/apache/cloudstack/pull/8530#issuecomment-1900965738

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NSX: Improve segment deletion process [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #8538:
URL: https://github.com/apache/cloudstack/pull/8538#issuecomment-1900892470

   @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NSX: Improve segment deletion process [cloudstack]

2024-01-19 Thread via GitHub


nvazquez commented on PR #8538:
URL: https://github.com/apache/cloudstack/pull/8538#issuecomment-1900885237

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(cloudstack) branch nsx-lb-passive-monitor updated (01e512c4d34 -> 56ce9e763f2)

2024-01-19 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository.

pearl11594 pushed a change to branch nsx-lb-passive-monitor
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


from 01e512c4d34 fix build failure
 add c325b8a64dd fix test
 add 13a2aab7754 fix test - build failure
 add 2aee0fbd5c5 fix test - build failure
 add 080f171c6d7 NSX: Cleanup NSX resources during k8s cluster cleanup 
(#8528)
 add c3b77cb7b82 Fix host stuck in connecting state (#8502)
 add 62efe7433db scripts: mark multipath scripts as executable (#8524)
 add 3bcf6f0faf4 Rename "Import QCOW" to "Import QCOW2." (#8519)
 add 8d42ca8ccfd Use project version on pom dependencies (#8529)
 add 80bbb29abfb CleanUp Async Jobs after mgmt server maintenance (#8394)
 add 33fc9d8443a Merge branch 'main' into nsx-integration
 add 330c99ca57b fix test failure
 add 56ce9e763f2 Merge branch 'nsx-integration' of 
https://github.com/apache/cloudstack into nsx-lb-passive-monitor

No new revisions were added by this update.

Summary of changes:
 .../cluster/KubernetesClusterHelper.java   |   1 +
 api/src/main/java/com/cloud/storage/Volume.java|  54 +---
 .../service/NetworkOrchestrationService.java   |   3 +
 .../subsystem/api/storage/VolumeService.java   |   5 +-
 .../com/cloud/agent/manager/AgentManagerImpl.java  |   1 +
 .../engine/orchestration/NetworkOrchestrator.java  |   3 +-
 .../datastore/provider/DefaultHostListener.java|   1 +
 .../cloudstack/storage/volume/VolumeObject.java|   2 +-
 .../storage/volume/VolumeServiceImpl.java  |  12 +-
 framework/direct-download/pom.xml  |   2 +-
 .../framework/jobs/impl/AsyncJobManagerImpl.java   | 143 ++---
 .../jobs/impl/AsyncJobManagerImplTest.java |  96 ++
 .../non-strict-host-anti-affinity/pom.xml  |   2 +-
 .../wrapper/LibvirtReadyCommandWrapper.java|   2 +-
 .../cluster/KubernetesClusterHelperImpl.java   |  13 ++
 .../cluster/dao/KubernetesClusterVmMapDao.java |   2 +
 .../cluster/dao/KubernetesClusterVmMapDaoImpl.java |  12 ++
 .../org/apache/cloudstack/service/NsxElement.java  |  21 +--
 .../apache/cloudstack/service/NsxElementTest.java  |   7 +-
 plugins/pom.xml|   4 +-
 scripts/storage/multipath/cleanStaleMaps.sh|   0
 scripts/storage/multipath/connectVolume.sh |   0
 scripts/storage/multipath/copyVolume.sh|   0
 scripts/storage/multipath/disconnectVolume.sh  |   0
 scripts/storage/multipath/resizeVolume.sh  |   0
 .../main/java/com/cloud/vm/UserVmManagerImpl.java  |  28 +++-
 .../core/spring-server-core-managers-context.xml   |   5 +-
 .../network/vpc/NetworkACLServiceImplTest.java |  22 +++-
 .../java/com/cloud/vpc/MockNetworkManagerImpl.java |  66 +-
 .../java/com/cloud/vpc/NetworkACLServiceTest.java  |   6 +
 ui/public/locales/en.json  |  10 +-
 ui/src/views/tools/ManageInstances.vue |   6 +-
 vmware-base/pom.xml|   2 +-
 33 files changed, 418 insertions(+), 113 deletions(-)
 create mode 100644 
framework/jobs/src/test/java/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImplTest.java
 mode change 100644 => 100755 scripts/storage/multipath/cleanStaleMaps.sh
 mode change 100644 => 100755 scripts/storage/multipath/connectVolume.sh
 mode change 100644 => 100755 scripts/storage/multipath/copyVolume.sh
 mode change 100644 => 100755 scripts/storage/multipath/disconnectVolume.sh
 mode change 100644 => 100755 scripts/storage/multipath/resizeVolume.sh



Re: [PR] NSX: Improve segment deletion process [cloudstack]

2024-01-19 Thread via GitHub


nvazquez commented on PR #8538:
URL: https://github.com/apache/cloudstack/pull/8538#issuecomment-1900874517

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NSX: Improve segment deletion process [cloudstack]

2024-01-19 Thread via GitHub


nvazquez commented on code in PR #8538:
URL: https://github.com/apache/cloudstack/pull/8538#discussion_r1459472151


##
plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxApiClient.java:
##
@@ -414,6 +433,30 @@ public void deleteSegment(long zoneId, long domainId, long 
accountId, Long vpcId
 }
 }
 
+protected void removeSegment(String segmentName) {
+LOGGER.debug(String.format("Removing the segment with ID %s", 
segmentName));
+Segments segmentService = (Segments) nsxService.apply(Segments.class);
+Segment segment = segmentService.get(segmentName);
+if (segment == null) {
+LOGGER.error(String.format("The segment with ID %s is not found, 
skipping removal", segmentName));
+return;
+}
+String siteId = getDefaultSiteId();
+String enforcementPointPath = getDefaultEnforcementPointPath(siteId);
+SegmentPorts segmentPortsService = (SegmentPorts) 
nsxService.apply(SegmentPorts.class);
+PolicyGroupMembersListResult segmentPortsList = 
segmentPortsService.list(DEFAULT_DOMAIN, segmentName, null, 
enforcementPointPath,
+false, null, 50L, false, null);

Review Comment:
   Its page size



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NSX integration [cloudstack]

2024-01-19 Thread via GitHub


Pearl1594 commented on PR #7919:
URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1900852432

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NSX integration [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #7919:
URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1900853188

   @Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #8530:
URL: https://github.com/apache/cloudstack/pull/8530#issuecomment-1900850181

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8385


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NSX: Improve segment deletion process [cloudstack]

2024-01-19 Thread via GitHub


Pearl1594 commented on code in PR #8538:
URL: https://github.com/apache/cloudstack/pull/8538#discussion_r1459452583


##
plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxApiClient.java:
##
@@ -414,6 +433,30 @@ public void deleteSegment(long zoneId, long domainId, long 
accountId, Long vpcId
 }
 }
 
+protected void removeSegment(String segmentName) {
+LOGGER.debug(String.format("Removing the segment with ID %s", 
segmentName));
+Segments segmentService = (Segments) nsxService.apply(Segments.class);
+Segment segment = segmentService.get(segmentName);
+if (segment == null) {
+LOGGER.error(String.format("The segment with ID %s is not found, 
skipping removal", segmentName));
+return;
+}
+String siteId = getDefaultSiteId();
+String enforcementPointPath = getDefaultEnforcementPointPath(siteId);
+SegmentPorts segmentPortsService = (SegmentPorts) 
nsxService.apply(SegmentPorts.class);
+PolicyGroupMembersListResult segmentPortsList = 
segmentPortsService.list(DEFAULT_DOMAIN, segmentName, null, 
enforcementPointPath,
+false, null, 50L, false, null);

Review Comment:
   what's 50 here? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(cloudstack) branch nsx-integration updated (33fc9d8443a -> 330c99ca57b)

2024-01-19 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository.

pearl11594 pushed a change to branch nsx-integration
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


from 33fc9d8443a Merge branch 'main' into nsx-integration
 add 330c99ca57b fix test failure

No new revisions were added by this update.

Summary of changes:
 .../test/java/org/apache/cloudstack/service/NsxElementTest.java| 7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)



(cloudstack) branch 4.18 updated: Veeam: Support Veeam 11 and 12 (#8241)

2024-01-19 Thread weizhou
This is an automated email from the ASF dual-hosted git repository.

weizhou pushed a commit to branch 4.18
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.18 by this push:
 new 33bb92acce2 Veeam: Support Veeam 11 and 12 (#8241)
33bb92acce2 is described below

commit 33bb92acce2dd2f3b8a4c0d81fcc37a4714f
Author: Wei Zhou 
AuthorDate: Fri Jan 19 18:42:01 2024 +0100

Veeam: Support Veeam 11 and 12 (#8241)

This PR fixes several issues in the testing of Veeam 11 and Veeam12
- Import Veeam.Backup.PowerShell and silently ignore the warning messages
- Fix issue when assign vm to backup offerings, which caused by separator 
(\r\n)
- Fix authorization failure in veeam 12a, which is because v1_4 is not 
supported in veeam 12a any more
- Fix exception if backup name has space
- Fix backup metrics in veeam12, which is because powershell command does 
not return the values needed
- Fix Incorrect datetime value, which is because powershell command returns 
a datetime which is not supported in Java
- Fix issue during backup restoration if VM has both ROOT and DATA disks.

This PR also has the following update
- Add integration test test/integration/smoke/test_backup_recovery_veeam.py
- Make some UI changes
- Add zone setting backup.plugin.veeam.version. If it is not set, 
CloudStack will get veeam version via powershell commands.
- Add zone setting backup.plugin.veeam.task.poll.interval and 
backup.plugin.veeam.task.poll.max.retry
---
 .../cloudstack/api/command/user/vm/ListVMsCmd.java |   4 +-
 .../backup/PrepareForBackupRestorationCommand.java |  43 +++
 .../schema/src/main/java/com/cloud/vm/NicVO.java   |  12 +
 .../src/main/java/com/cloud/vm/dao/NicDao.java |   2 +
 .../src/main/java/com/cloud/vm/dao/NicDaoImpl.java |   8 +
 .../org/apache/cloudstack/backup/BackupVO.java |  14 +
 plugins/backup/veeam/pom.xml   |  15 +
 .../cloudstack/backup/VeeamBackupProvider.java |  67 -
 .../cloudstack/backup/veeam/VeeamClient.java   | 285 +++---
 .../cloudstack/backup/veeam/api/BackupFile.java| 160 ++
 .../cloudstack/backup/veeam/api/BackupFiles.java   |  39 +++
 .../backup/veeam/api/VmRestorePoint.java   | 149 ++
 .../backup/veeam/api/VmRestorePoints.java  |  39 +++
 .../cloudstack/backup/veeam/VeeamClientTest.java   | 329 -
 .../java/com/cloud/hypervisor/guru/VMwareGuru.java |  17 +-
 .../hypervisor/vmware/resource/VmwareResource.java |  32 ++
 .../cloudstack/backup/BackupManagerImpl.java   |  29 +-
 .../smoke/test_backup_recovery_veeam.py| 302 +++
 tools/marvin/marvin/lib/base.py|  66 -
 ui/src/components/view/ListView.vue|   2 +-
 ui/src/config/section/compute.js   |   4 +-
 ui/src/config/section/storage.js   |   6 +-
 ui/src/views/compute/backup/BackupSchedule.vue |   8 +
 .../hypervisor/vmware/mo/VirtualMachineMO.java |  25 ++
 .../hypervisor/vmware/mo/VmdkFileDescriptor.java   |  59 
 25 files changed, 1654 insertions(+), 62 deletions(-)

diff --git 
a/api/src/main/java/org/apache/cloudstack/api/command/user/vm/ListVMsCmd.java 
b/api/src/main/java/org/apache/cloudstack/api/command/user/vm/ListVMsCmd.java
index e609655c580..bd3b0623312 100644
--- 
a/api/src/main/java/org/apache/cloudstack/api/command/user/vm/ListVMsCmd.java
+++ 
b/api/src/main/java/org/apache/cloudstack/api/command/user/vm/ListVMsCmd.java
@@ -95,8 +95,8 @@ public class ListVMsCmd extends BaseListTaggedResourcesCmd 
implements UserCmd {
 @Parameter(name = ApiConstants.DETAILS,
type = CommandType.LIST,
collectionType = CommandType.STRING,
-   description = "comma separated list of host details requested, "
-   + "value can be a list of [all, group, nics, stats, secgrp, 
tmpl, servoff, diskoff, iso, volume, min, affgrp]."
+   description = "comma separated list of vm details requested, "
+   + "value can be a list of [all, group, nics, stats, secgrp, 
tmpl, servoff, diskoff, backoff, iso, volume, min, affgrp]."
+ " If no parameter is passed in, the details will be 
defaulted to all")
 private List viewDetails;
 
diff --git 
a/core/src/main/java/org/apache/cloudstack/backup/PrepareForBackupRestorationCommand.java
 
b/core/src/main/java/org/apache/cloudstack/backup/PrepareForBackupRestorationCommand.java
new file mode 100644
index 000..25306fb5f73
--- /dev/null
+++ 
b/core/src/main/java/org/apache/cloudstack/backup/PrepareForBackupRestorationCommand.java
@@ -0,0 +1,43 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright 

Re: [PR] Veeam: Support Veeam 11 and 12 [cloudstack]

2024-01-19 Thread via GitHub


weizhouapache merged PR #8241:
URL: https://github.com/apache/cloudstack/pull/8241


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Veeam: Support Veeam 11 and 12 [cloudstack]

2024-01-19 Thread via GitHub


weizhouapache commented on PR #8241:
URL: https://github.com/apache/cloudstack/pull/8241#issuecomment-1900829000

   this PR has been reviewed by @rohityadavcloud @DaanHoogland 
   and verified by @borisstoyanov 
   thanks !
   
   merging


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(cloudstack-kubernetes-provider) branch main updated: NSX: (temp fix) Skip adding firewall rules for CKS Clusters on VPC tiers (#56)

2024-01-19 Thread weizhou
This is an automated email from the ASF dual-hosted git repository.

weizhou pushed a commit to branch main
in repository 
https://gitbox.apache.org/repos/asf/cloudstack-kubernetes-provider.git


The following commit(s) were added to refs/heads/main by this push:
 new 98bd3c58 NSX: (temp fix) Skip adding firewall rules for CKS Clusters 
on VPC tiers (#56)
98bd3c58 is described below

commit 98bd3c586943fd11614d979cdafcbb19a72af82e
Author: Pearl Dsilva 
AuthorDate: Fri Jan 19 12:25:47 2024 -0500

NSX: (temp fix) Skip adding firewall rules for CKS Clusters on VPC tiers 
(#56)

Currently CKP does not setup NetworkACLs for CKS clusters on VPC tiers, and 
fails to add Firewall rules - as Firewall isn't supported on VPCs. This is a 
partial fix, to skip setting up Firewall rules if the network doesn't support 
the service.
---
 cloudstack_loadbalancer.go | 19 ++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/cloudstack_loadbalancer.go b/cloudstack_loadbalancer.go
index b796dfa9..1859da7d 100644
--- a/cloudstack_loadbalancer.go
+++ b/cloudstack_loadbalancer.go
@@ -163,7 +163,15 @@ func (cs *CSCloud) EnsureLoadBalancer(ctx context.Context, 
clusterName string, s
}
}
 
-   if lbRule != nil {
+   network, count, err := lb.Network.GetNetworkByID(lb.networkID, 
cloudstack.WithProject(lb.projectID))
+   if err != nil {
+   if count == 0 {
+   return nil, err
+   }
+   return nil, err
+   }
+
+   if lbRule != nil && isFirewallSupported(network.Service) {
klog.V(4).Infof("Creating firewall rules for load 
balancer rule: %v (%v:%v:%v)", lbRuleName, protocol, lbRule.Publicip, port.Port)
if _, err := lb.updateFirewallRule(lbRule.Publicipid, 
int(port.Port), protocol, service.Spec.LoadBalancerSourceRanges); err != nil {
return nil, err
@@ -244,6 +252,15 @@ func (cs *CSCloud) UpdateLoadBalancer(ctx context.Context, 
clusterName string, s
return nil
 }
 
+func isFirewallSupported(services []cloudstack.NetworkServiceInternal) bool {
+   for _, svc := range services {
+   if svc.Name == "Firewall" {
+   return true
+   }
+   }
+   return false
+}
+
 // EnsureLoadBalancerDeleted deletes the specified load balancer if it exists, 
returning
 // nil if the load balancer specified either didn't exist or was successfully 
deleted.
 func (cs *CSCloud) EnsureLoadBalancerDeleted(ctx context.Context, clusterName 
string, service *corev1.Service) error {



Re: [PR] NSX: Add passive monitor for NSX LB to test whether a server is available [cloudstack]

2024-01-19 Thread via GitHub


Pearl1594 commented on code in PR #8533:
URL: https://github.com/apache/cloudstack/pull/8533#discussion_r1459382663


##
plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxApiClient.java:
##
@@ -111,6 +116,10 @@ public class NsxApiClient {
 protected static final String SEGMENTS_PATH = "/infra/segments";
 protected static final String DEFAULT_DOMAIN = "default";
 protected static final String GROUPS_PATH_PREFIX = 
"/infra/domains/default/groups";
+// TODO: Pass as global / zone-level setting?
+protected static final String NSX_LB_PASSIVE_MONITOR = 
"/infra/lb-monitor-profiles/default-passive-lb-monitor";

Review Comment:
   Honestly for everything, we'd need a better way of handling it that 
hard-coding it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(cloudstack) branch nsx-lb-passive-monitor updated (f7e3a1b1781 -> 01e512c4d34)

2024-01-19 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository.

pearl11594 pushed a change to branch nsx-lb-passive-monitor
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


from f7e3a1b1781 Add active monitors too
 add 01e512c4d34 fix build failure

No new revisions were added by this update.

Summary of changes:
 .../nsx/src/main/java/org/apache/cloudstack/service/NsxApiClient.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-01-19 Thread via GitHub


weizhouapache commented on code in PR #8530:
URL: https://github.com/apache/cloudstack/pull/8530#discussion_r1459367595


##
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java:
##
@@ -2287,28 +2287,39 @@ public synchronized String 
allowOutgoingOnPrivate(String destCidr) {
 if (!_inSystemVM) {
 return null;
 }
-Script command = new Script("/bin/bash", s_logger);
 String intf = "eth1";
-command.add("-c");
-command.add("iptables -D OUTPUT -o " + intf + " -d " + destCidr + " -p 
tcp -m state --state NEW -m tcp  -j ACCEPT");
+String rule =  String.format("OUTPUT -o %s -d %s -p tcp -m state 
--state NEW -m tcp  -j ACCEPT", intf, destCidr);
 
-/* ignore the String result =*/ command.execute();
-
-command = new Script("/bin/bash", s_logger);
-command.add("-c");
-command.add("iptables -I OUTPUT -o " + intf + " -d " + destCidr + " -p 
tcp -m state --state NEW -m tcp  -j ACCEPT");
+if (ruleNeedsAdding(rule)) {
+Script command = new Script("/bin/bash", s_logger);
+command.add("-c");
+command.add("iptables -I");
+command.add(rule);
 
-String result = command.execute();
-if (result != null) {
-s_logger.warn("Error in allowing outgoing to " + destCidr + ", 
err=" + result);
-return "Error in allowing outgoing to " + destCidr + ", err=" + 
result;
+String result = command.execute();
+if (result != null) {
+s_logger.warn("Error in allowing outgoing to " + destCidr + ", 
err=" + result);
+return "Error in allowing outgoing to " + destCidr + ", err=" 
+ result;
+}
+} else {
+s_logger.warn("Rule already defined in SVM: Error in allowing 
outgoing to " + destCidr);
 }
 
 addRouteToInternalIpOrCidr(_localgw, _eth1ip, _eth1mask, destCidr);
 
 return null;
 }
 
+private boolean ruleNeedsAdding(String rule) {
+Script command = new Script("/bin/bash", s_logger);
+command.add("-c");
+command.add("iptables -C");
+command.add("rule");

Review Comment:
   ```suggestion
   command.add(rule);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Unable to connect to docker simulator image [cloudstack]

2024-01-19 Thread via GitHub


mikehale commented on issue #8527:
URL: https://github.com/apache/cloudstack/issues/8527#issuecomment-1900767950

   I just confirmed everything works just fine on my Intel Mac, so this seems 
to be an issue with Apple Silicon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NSX: Improve segment deletion process [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #8538:
URL: https://github.com/apache/cloudstack/pull/8538#issuecomment-1900767675

   Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 8384


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NSX integration [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #7919:
URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1900767673

   Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 8383


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-01-19 Thread via GitHub


DaanHoogland commented on PR #8530:
URL: https://github.com/apache/cloudstack/pull/8530#issuecomment-1900753529

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #8530:
URL: https://github.com/apache/cloudstack/pull/8530#issuecomment-1900754252

   @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will 
be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-01-19 Thread via GitHub


DaanHoogland commented on PR #8530:
URL: https://github.com/apache/cloudstack/pull/8530#issuecomment-1900752116

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NSX integration [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #7919:
URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1900722764

   @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NSX: Improve segment deletion process [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #8538:
URL: https://github.com/apache/cloudstack/pull/8538#issuecomment-1900722805

   @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NSX integration [cloudstack]

2024-01-19 Thread via GitHub


nvazquez commented on PR #7919:
URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1900722296

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NSX: Improve segment deletion process [cloudstack]

2024-01-19 Thread via GitHub


nvazquez commented on PR #8538:
URL: https://github.com/apache/cloudstack/pull/8538#issuecomment-1900722085

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [WIP] System VMs/VRs upgrade to Python3 and Debian 12 [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #8497:
URL: https://github.com/apache/cloudstack/pull/8497#issuecomment-1900684755

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8382


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(cloudstack) branch nsx-integration updated (080f171c6d7 -> 33fc9d8443a)

2024-01-19 Thread nvazquez
This is an automated email from the ASF dual-hosted git repository.

nvazquez pushed a change to branch nsx-integration
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


from 080f171c6d7 NSX: Cleanup NSX resources during k8s cluster cleanup 
(#8528)
 add c3b77cb7b82 Fix host stuck in connecting state (#8502)
 add 62efe7433db scripts: mark multipath scripts as executable (#8524)
 add 3bcf6f0faf4 Rename "Import QCOW" to "Import QCOW2." (#8519)
 add 8d42ca8ccfd Use project version on pom dependencies (#8529)
 add 80bbb29abfb CleanUp Async Jobs after mgmt server maintenance (#8394)
 add 33fc9d8443a Merge branch 'main' into nsx-integration

No new revisions were added by this update.

Summary of changes:
 api/src/main/java/com/cloud/storage/Volume.java|  54 +---
 .../service/NetworkOrchestrationService.java   |   3 +
 .../subsystem/api/storage/VolumeService.java   |   5 +-
 .../com/cloud/agent/manager/AgentManagerImpl.java  |   1 +
 .../engine/orchestration/NetworkOrchestrator.java  |   3 +-
 .../datastore/provider/DefaultHostListener.java|   1 +
 .../cloudstack/storage/volume/VolumeObject.java|   2 +-
 .../storage/volume/VolumeServiceImpl.java  |  12 +-
 framework/direct-download/pom.xml  |   2 +-
 .../framework/jobs/impl/AsyncJobManagerImpl.java   | 143 ++---
 .../jobs/impl/AsyncJobManagerImplTest.java |  96 ++
 .../non-strict-host-anti-affinity/pom.xml  |   2 +-
 .../wrapper/LibvirtReadyCommandWrapper.java|   2 +-
 plugins/pom.xml|   4 +-
 scripts/storage/multipath/cleanStaleMaps.sh|   0
 scripts/storage/multipath/connectVolume.sh |   0
 scripts/storage/multipath/copyVolume.sh|   0
 scripts/storage/multipath/disconnectVolume.sh  |   0
 scripts/storage/multipath/resizeVolume.sh  |   0
 .../java/com/cloud/vpc/MockNetworkManagerImpl.java |  66 +-
 ui/public/locales/en.json  |  10 +-
 ui/src/views/tools/ManageInstances.vue |   6 +-
 vmware-base/pom.xml|   2 +-
 23 files changed, 321 insertions(+), 93 deletions(-)
 create mode 100644 
framework/jobs/src/test/java/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImplTest.java
 mode change 100644 => 100755 scripts/storage/multipath/cleanStaleMaps.sh
 mode change 100644 => 100755 scripts/storage/multipath/connectVolume.sh
 mode change 100644 => 100755 scripts/storage/multipath/copyVolume.sh
 mode change 100644 => 100755 scripts/storage/multipath/disconnectVolume.sh
 mode change 100644 => 100755 scripts/storage/multipath/resizeVolume.sh



Re: [I] Unable to connect to docker simulator image [cloudstack]

2024-01-19 Thread via GitHub


mikehale commented on issue #8527:
URL: https://github.com/apache/cloudstack/issues/8527#issuecomment-1900674168

   @weizhouapache thanks for all your time and help on this. I'm guessing that 
this is related to Apple Silicon and the [rosetta 
compatibility](https://www.docker.com/blog/docker-desktop-4-25/) layer that 
docker uses.
   
   I'm going to double check that by running on an old Intel Mac.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(cloudstack) branch nsx-integration updated (2aee0fbd5c5 -> 080f171c6d7)

2024-01-19 Thread nvazquez
This is an automated email from the ASF dual-hosted git repository.

nvazquez pushed a change to branch nsx-integration
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


from 2aee0fbd5c5 fix test - build failure
 add 080f171c6d7 NSX: Cleanup NSX resources during k8s cluster cleanup 
(#8528)

No new revisions were added by this update.

Summary of changes:
 .../cluster/KubernetesClusterHelper.java   |  1 +
 .../cluster/KubernetesClusterHelperImpl.java   | 13 ++
 .../cluster/dao/KubernetesClusterVmMapDao.java |  2 ++
 .../cluster/dao/KubernetesClusterVmMapDaoImpl.java | 12 ++
 .../org/apache/cloudstack/service/NsxElement.java  | 21 +---
 .../main/java/com/cloud/vm/UserVmManagerImpl.java  | 28 ++
 .../core/spring-server-core-managers-context.xml   |  5 ++--
 7 files changed, 66 insertions(+), 16 deletions(-)



Re: [PR] NSX: Cleanup NSX resources during k8s cluster cleanup [cloudstack]

2024-01-19 Thread via GitHub


nvazquez merged PR #8528:
URL: https://github.com/apache/cloudstack/pull/8528


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Cannot Delete Root admin account [cloudstack]

2024-01-19 Thread via GitHub


Tbaugus44 commented on issue #8531:
URL: https://github.com/apache/cloudstack/issues/8531#issuecomment-1900646169

   this has been solved thank you for your help. this article helped set up 
cloudmonkey.
   
   
https://kb.leaseweb.com/products/elastic-compute/managing-apache-cloudstack-api-and-automation
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Cannot Delete Root admin account [cloudstack]

2024-01-19 Thread via GitHub


Tbaugus44 closed issue #8531: Cannot Delete Root admin account 
URL: https://github.com/apache/cloudstack/issues/8531


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(cloudstack-kubernetes-provider) branch nsx-skip-firewall updated (f2870a38 -> 730e1584)

2024-01-19 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository.

pearl11594 pushed a change to branch nsx-skip-firewall
in repository 
https://gitbox.apache.org/repos/asf/cloudstack-kubernetes-provider.git


from f2870a38 NSX: (temp fix) Skip adding firewall rules for CKS Clusters 
on VPC tiers
 add 730e1584 fix npe

No new revisions were added by this update.

Summary of changes:
 cloudstack_loadbalancer.go | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)



Re: [PR] NSX: Add passive monitor for NSX LB to test whether a server is available [cloudstack]

2024-01-19 Thread via GitHub


nvazquez commented on code in PR #8533:
URL: https://github.com/apache/cloudstack/pull/8533#discussion_r1459186440


##
plugins/network-elements/nsx/src/main/java/org/apache/cloudstack/service/NsxApiClient.java:
##
@@ -111,6 +116,10 @@ public class NsxApiClient {
 protected static final String SEGMENTS_PATH = "/infra/segments";
 protected static final String DEFAULT_DOMAIN = "default";
 protected static final String GROUPS_PATH_PREFIX = 
"/infra/domains/default/groups";
+// TODO: Pass as global / zone-level setting?
+protected static final String NSX_LB_PASSIVE_MONITOR = 
"/infra/lb-monitor-profiles/default-passive-lb-monitor";

Review Comment:
   In that case, only this one should be a setting or other paths above as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NSX: Improve segment deletion process [cloudstack]

2024-01-19 Thread via GitHub


codecov[bot] commented on PR #8538:
URL: https://github.com/apache/cloudstack/pull/8538#issuecomment-1900588968

   ## 
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8538?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Comparison is base 
[(`a4f6305`)](https://app.codecov.io/gh/apache/cloudstack/commit/a4f63053b652756ef01ade5977d5c7685e098a04?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 30.95% compared to head 
[(`23b5aa0`)](https://app.codecov.io/gh/apache/cloudstack/pull/8538?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 4.37%.
   > Report is 4 commits behind head on nsx-integration.
   
   
   Additional details and impacted files
   
   
   ```diff
   @@  Coverage Diff  @@
   ## nsx-integration   #8538   +/-   ##
   =
   - Coverage  30.95%   4.37%   -26.58% 
   =
 Files   5377 361 -5016 
 Lines 378122   28792   -349330 
 Branches   550665049-50017 
   =
   - Hits  1170341259   -115775 
   + Misses245592   27393   -218199 
   + Partials   15496 140-15356 
   ```
   
   | 
[Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8538/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8538/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `?` | |
   | 
[uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8538/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `4.37% <ø> (ø)` | |
   | 
[unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8538/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8538?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] NSX: Improve segment deletion process [cloudstack]

2024-01-19 Thread via GitHub


nvazquez opened a new pull request, #8538:
URL: https://github.com/apache/cloudstack/pull/8538

   ### Description
   
   This PR...
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] build/CI
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   
   
   
    How did you try to break this feature and the system with this change?
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [WIP] System VMs/VRs upgrade to Python3 and Debian 12 [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #8497:
URL: https://github.com/apache/cloudstack/pull/8497#issuecomment-1900564661

   @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will 
be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [WIP] System VMs/VRs upgrade to Python3 and Debian 12 [cloudstack]

2024-01-19 Thread via GitHub


weizhouapache commented on PR #8497:
URL: https://github.com/apache/cloudstack/pull/8497#issuecomment-1900560602

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Question] signatureVersion and expires params in /client/console request [cloudstack]

2024-01-19 Thread via GitHub


nvazquez commented on issue #8299:
URL: https://github.com/apache/cloudstack/issues/8299#issuecomment-1900514464

   Hi @OlegChuev, as far as I know that endpoint may be deprecated. Have you 
tried a query to `/client/api?command=createConsoleEndpoint`? This is an 
API command and should support the parameters you are trying to use


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Veeam: Support Veeam 11 and 12 [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #8241:
URL: https://github.com/apache/cloudstack/pull/8241#issuecomment-1900509052

   @weizhouapache [SL] unsupported parameters provided. Supported mgmt server 
os are: `centos7, centos6, suse15, alma8, ubuntu18, ubuntu22, ubuntu20, rocky8, 
alma9`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-rocky8, 
kvm-alma8, kvm-alma9, kvm-ubuntu18, kvm-ubuntu20, kvm-ubuntu22, kvm-suse15, 
vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, 
vmware-70u3, vmware-80, vmware-80u1, xenserver-65sp1, xenserver-71, 
xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Veeam: Support Veeam 11 and 12 [cloudstack]

2024-01-19 Thread via GitHub


weizhouapache commented on PR #8241:
URL: https://github.com/apache/cloudstack/pull/8241#issuecomment-1900500585

   > @blueorangutan test ubuntu22 vmware-80
   
   test results
   ```
   Smoke tests completed. 107 look OK, 3 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_list_vms_metrics_admin | `Error` | 3624.48 | test_metrics_api.py
   test_list_vms_metrics_history | `Error` | 5.83 | test_metrics_api.py
   test_list_volumes_metrics_history | `Error` | 3603.50 | test_metrics_api.py
   test_01_deploy_vm_on_specific_host | `Error` | 18.96 | 
test_vm_deployment_planner.py
   test_02_deploy_vm_on_specific_cluster | `Error` | 3602.58 | 
test_vm_deployment_planner.py
   test_03_deploy_vm_on_specific_pod | `Error` | 1.44 | 
test_vm_deployment_planner.py
   test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 2.48 | 
test_vm_deployment_planner.py
   test_05_deploy_vm_on_cluster_override_pod | `Error` | 1.36 | 
test_vm_deployment_planner.py
   test_09_expunge_vm | `Failure` | 424.61 | test_vm_life_cycle.py
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #7345:
URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1900345645

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8381


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[I] Showing advanced settings of service offerings [cloudstack]

2024-01-19 Thread via GitHub


wverleger opened a new issue, #8537:
URL: https://github.com/apache/cloudstack/issues/8537

   
   
   # ISSUE TYPE
   
* Improvement Request
   
   # COMPONENT NAME
   ~~~
   UI
   ~~~
   
   # CLOUDSTACK VERSION
   ~~~
   4.18.1
   ~~~
   
   # CONFIGURATION
   
   
   
   # OS / ENVIRONMENT
   
   
   
   # SUMMARY
   
   One can't see the settings of service offerings on the details page.
   For example settings set for "compute offerings":
   
   
![cs_offerings](https://github.com/apache/cloudstack/assets/121959384/8ede46d5-81f4-4c9d-a4dc-f756796edfb4)
   
   
   # STEPS TO REPRODUCE
   
   
   
   ~~~
   Create a compute offering with custom settings. Go to detail page.
   ~~~
   
   
   
   # EXPECTED RESULTS
   
   
   ~~~
   See what kind of settings were used to create the offering.
   ~~~
   
   # ACTUAL RESULTS
   
   
   
   ~~~
   No information about creation settings.
   ~~~
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Showing advanced settings of service offerings [cloudstack]

2024-01-19 Thread via GitHub


boring-cyborg[bot] commented on issue #8537:
URL: https://github.com/apache/cloudstack/issues/8537#issuecomment-1900294904

   Thanks for opening your first issue here! Be sure to follow the issue 
template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] on forName validate packages of classes to load [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-1900257606

   @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) 
has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] on forName validate packages of classes to load [cloudstack]

2024-01-19 Thread via GitHub


DaanHoogland commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-1900257095

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] systemvm: vncport evaluation [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #8369:
URL: https://github.com/apache/cloudstack/pull/8369#issuecomment-1900257652

   @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) 
has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] systemvm: vncport evaluation [cloudstack]

2024-01-19 Thread via GitHub


DaanHoogland commented on PR #8369:
URL: https://github.com/apache/cloudstack/pull/8369#issuecomment-1900256437

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[I] Networks are getting listed in the create kubernetes form [cloudstack]

2024-01-19 Thread via GitHub


kiranchavala opened a new issue, #8536:
URL: https://github.com/apache/cloudstack/issues/8536

   ISSUE TYPE
   
   Bug
   
   COMPONENT NAME
   
   Component: UI
   
   CLOUDSTACK VERSION
   
   Cloudstack version 4.19 rc 2
   
   SUMMARY
   
   Networks are getting listed in the create kubernetes form
   
   
   Steps to reproduce the issue 
   
   1. Navigate to compute > Kubernetes > Create Kubernetes cluster 
   
   The network selection is listing the network twice.
   
   Cloudstack is calling the listnetworks api call twice
   
   Screenshot
   
   https://github.com/apache/cloudstack/assets/1401014/5129b740-0c65-4d63-b191-4c1b07e2d7f7";>
   
   https://github.com/apache/cloudstack/assets/1401014/9a9ac124-4f18-4e2a-9252-6c8480f55e46";>
   
   ---
   **This issue was not observed in 4.18 release, where the listNetworks call 
was being called only once**
   
   
   https://github.com/apache/cloudstack/assets/1401014/c2555c6e-3949-42c3-8c58-50415dec9c1c";>
   
   https://github.com/apache/cloudstack/assets/1401014/22114824-f4b9-40eb-b5b2-d215b89b8f40";>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(cloudstack) branch 4.18-dummy updated (55cc76d6209 -> 3beaaa7a2f8)

2024-01-19 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a change to branch 4.18-dummy
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


omit 55cc76d6209 don't merge
 add 76aff0f422a Add reconnect button to hosts on alert (#8468)
 add 3beaaa7a2f8 don't merge

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (55cc76d6209)
\
 N -- N -- N   refs/heads/4.18-dummy (3beaaa7a2f8)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

No new revisions were added by this update.

Summary of changes:
 ui/src/config/section/infra/hosts.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #7345:
URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1900245807

   @JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]

2024-01-19 Thread via GitHub


JoaoJandre commented on PR #7345:
URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1900245084

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] on forName validate packages of classes to load [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-1900224933

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8380


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] systemvm: vncport evaluation [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #8369:
URL: https://github.com/apache/cloudstack/pull/8369#issuecomment-1900143046

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8378


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] on forName validate packages of classes to load [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-1900132351

   @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will 
be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] on forName validate packages of classes to load [cloudstack]

2024-01-19 Thread via GitHub


DaanHoogland commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-1900118389

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-01-19 Thread via GitHub


DaanHoogland commented on code in PR #8530:
URL: https://github.com/apache/cloudstack/pull/8530#discussion_r1458707121


##
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java:
##
@@ -2290,6 +2290,12 @@ public synchronized String allowOutgoingOnPrivate(String 
destCidr) {
 Script command = new Script("/bin/bash", s_logger);
 String intf = "eth1";
 command.add("-c");
+command.add("iptables -D OUTPUT -o " + intf + " -d " + destCidr + " -p 
tcp -m state --state NEW -m tcp  -j ACCEPT");

Review Comment:
   ok, will try to implement that



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #8418:
URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1900103482

   @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It 
will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep 
you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] User data content size validation with actual length only, and some code improvements [cloudstack]

2024-01-19 Thread via GitHub


sureshanaparti commented on PR #8418:
URL: https://github.com/apache/cloudstack/pull/8418#issuecomment-1900101219

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] VM not migrating to alive KVM host, when KVM host down [cloudstack]

2024-01-19 Thread via GitHub


DaanHoogland commented on issue #8326:
URL: https://github.com/apache/cloudstack/issues/8326#issuecomment-1900092058

   @happyalexkg any update on this? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [WIP] System VMs/VRs upgrade to Python3 and Debian 12 [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #8497:
URL: https://github.com/apache/cloudstack/pull/8497#issuecomment-1900076687

   [SF] Trillian Build Failed (tid-8880)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HEALTH] 4.19/main Health Check, please don't merge this! [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #7344:
URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1900049354

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8377


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] systemvm: vncport evaluation [cloudstack]

2024-01-19 Thread via GitHub


blueorangutan commented on PR #8369:
URL: https://github.com/apache/cloudstack/pull/8369#issuecomment-1900046976

   @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will 
be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NSX integration [cloudstack]

2024-01-19 Thread via GitHub


github-actions[bot] commented on PR #7919:
URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1900044583

   This pull request has merge conflicts. Dear author, please fix the conflicts 
and sync your branch with the base branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] systemvm: vncport evaluation [cloudstack]

2024-01-19 Thread via GitHub


DaanHoogland commented on PR #8369:
URL: https://github.com/apache/cloudstack/pull/8369#issuecomment-1900045824

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] api,server,ui: tagged resource limits [cloudstack]

2024-01-19 Thread via GitHub


github-actions[bot] commented on PR #8362:
URL: https://github.com/apache/cloudstack/pull/8362#issuecomment-1900044614

   This pull request has merge conflicts. Dear author, please fix the conflicts 
and sync your branch with the base branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] How to register templates or ISO if I use cephfs for primary storage and secondary storage on apache cloudstack? [cloudstack]

2024-01-19 Thread via GitHub


weizhouapache commented on issue #8535:
URL: https://github.com/apache/cloudstack/issues/8535#issuecomment-1900034085

   @herdiansah571 
   did you add the cephfs as NFS ?
   
   can you check if SSVM is running and agent is Up ?
   
![image](https://github.com/apache/cloudstack/assets/57355700/11921e4f-efc9-47ec-9129-95195e48c1f9)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



  1   2   >