Re: [I] VPC Routing/Network Issue [cloudstack]
weizhouapache commented on issue #8562: URL: https://github.com/apache/cloudstack/issues/8562#issuecomment-1909575701 @midhunpjos as a workaround, can you add some iptables rules by the following command ? ``` iptables -t nat -I POSTROUTING -o ethX -j SNAT --to-source 99.127.xxx.93 ``` `ethX` is the device name of other subnet (99.127.xxx.32/27 or 99.127.xxx.96/27). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Added missing metrics English locale strings [cloudstack]
harikrishna-patnala commented on PR #8560: URL: https://github.com/apache/cloudstack/pull/8560#issuecomment-1909425727 > > @sureshanaparti this is based on main so I changed the milestone to 4.20. @kohrar if you wnat this in 4.18.2 please `git rebase --onto 4.18 ` cc @JoaoJandre > > @DaanHoogland Thanks. I didn't realize I targetted main. I'll keep that in mind in the future. I've created a new PR (#8564) that targets 4.18. Is this the correct approach? We don't have to create two PRs for two branches @kohrar. You can simply rebase this current branch with 4.18 (or force push to add_missing_en_locale) and change the apache:main to apache:4.18 in this PR itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Externalise a few timeouts & fix timeout for hostSupportsUefi in libvirt ready command wrapper [cloudstack]
vishesh92 commented on code in PR #8547: URL: https://github.com/apache/cloudstack/pull/8547#discussion_r1465880884 ## agent/conf/agent.properties: ## @@ -378,6 +378,10 @@ iscsi.session.cleanup.enabled=false # If the time is exceeded shutdown will be forced. #stop.script.timeout=120 +# Time (in seconds) to wait for scripts to complete. +# This is not used for every script execution. Review Comment: ```suggestion # This is currently used only while checking if the host supports UEFI. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Externalise a few timeouts & fix timeout for hostSupportsUefi in libvirt ready command wrapper [cloudstack]
vishesh92 commented on code in PR #8547:
URL: https://github.com/apache/cloudstack/pull/8547#discussion_r1465880741
##
agent/src/main/java/com/cloud/agent/properties/AgentProperties.java:
##
@@ -659,6 +659,14 @@ public class AgentProperties{
*/
public static final Property STOP_SCRIPT_TIMEOUT = new
Property<>("stop.script.timeout", 120);
+/**
+ * Time (in seconds) to wait for scripts to complete.
+ * This is not used for every script execution.
Review Comment:
```suggestion
* This is currently used only while checking if the host supports
UEFI.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Externalise a few timeouts & fix timeout for hostSupportsUefi in libvirt ready command wrapper [cloudstack]
blueorangutan commented on PR #8547: URL: https://github.com/apache/cloudstack/pull/8547#issuecomment-1909375195 [SF] Trillian test result (tid-8936) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41623 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8547-t8936-xenserver-71.zip Smoke tests completed. 120 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_trigger_shutdown | `Failure` | 341.90 | test_safe_shutdown.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] VPN client to site connection simultaneously for multiple users/PC in the 1 subnet [cloudstack]
tuanhoangth1603 commented on issue #8566:
URL: https://github.com/apache/cloudstack/issues/8566#issuecomment-1909336028
There is the log I got from the VR
```
Jan 25 04:22:22 r-443-VM charon[4019]: 15[NET] received packet: from
102.119.162.40[23171] to 102.119.162.26[4500] (444 bytes)
Jan 25 04:22:22 r-443-VM charon[4019]: 15[ENC] parsed QUICK_MODE request 3 [
HASH SA No ID ID NAT-OA NAT-OA ]
Jan 25 04:22:22 r-443-VM charon[4019]: 15[CFG] selected proposal:
ESP:AES_CBC_256/HMAC_SHA1_96/NO_EXT_SEQ
Jan 25 04:22:22 r-443-VM charon[4019]: 15[IKE] received 3600s lifetime,
configured 0s
Jan 25 04:22:22 r-443-VM charon[4019]: 15[IKE] received 25000 lifebytes,
configured 0
Jan 25 04:22:22 r-443-VM charon[4019]: 15[IKE] detected rekeying of CHILD_SA
L2TP-PSK{647}
Jan 25 04:22:22 r-443-VM charon[4019]: 15[ENC] generating QUICK_MODE
response 3 [ HASH SA No ID ID NAT-OA NAT-OA ]
Jan 25 04:22:22 r-443-VM charon[4019]: 15[NET] sending packet: from
102.119.162.26[4500] to 102.119.162.40[23171] (204 bytes)
Jan 25 04:22:22 r-443-VM charon[4019]: 12[NET] received packet: from
102.119.162.40[23171] to 102.119.162.26[4500] (76 bytes)
Jan 25 04:22:22 r-443-VM charon[4019]: 12[ENC] parsed INFORMATIONAL_V1
request 3468119228 [ HASH D ]
Jan 25 04:22:22 r-443-VM charon[4019]: 12[IKE] received DELETE for ESP
CHILD_SA with SPI 5af7e8ae
Jan 25 04:22:22 r-443-VM charon[4019]: 12[IKE] closing CHILD_SA
L2TP-PSK{647} with SPIs c8f197ae_i (132 bytes) 5af7e8ae_o (100 bytes) and TS
102.119.162.26/32[udp/l2f] === 102.119.162.40/32[udp/l2f]
Jan 25 04:22:22 r-443-VM charon[4019]: 12[IKE] closing CHILD_SA
L2TP-PSK{647} with SPIs c8f197ae_i (132 bytes) 5af7e8ae_o (100 bytes) and TS
102.119.162.26/32[udp/l2f] === 102.119.162.40/32[udp/l2f]
Jan 25 04:22:22 r-443-VM vpn[199474]: - 172.16.10.4 102.119.162.40 --
102.119.162.26
Jan 25 04:22:22 r-443-VM charon[4019]: 14[NET] received packet: from
102.119.162.40[23171] to 102.119.162.26[4500] (60 bytes)
Jan 25 04:22:22 r-443-VM charon[4019]: 14[ENC] parsed QUICK_MODE request 3 [
HASH ]
Jan 25 04:22:22 r-443-VM charon[4019]: 14[IKE] CHILD_SA L2TP-PSK{649}
established with SPIs c1c4921c_i 979b6bb8_o and TS 102.119.162.26/32[udp/l2f]
=== 102.119.162.40/32[udp/l2f]
Jan 25 04:22:22 r-443-VM charon[4019]: 14[IKE] CHILD_SA L2TP-PSK{649}
established with SPIs c1c4921c_i 979b6bb8_o and TS 102.119.162.26/32[udp/l2f]
=== 102.119.162.40/32[udp/l2f]
Jan 25 04:22:22 r-443-VM vpn[199481]: + 172.16.10.4 102.119.162.40 --
102.119.162.26
Jan 25 04:22:31 r-443-VM CRON[199415]: pam_unix(cron:session): session
closed for user root
Jan 25 04:22:32 r-443-VM xl2tpd[4033]: Maximum retries exceeded for tunnel
9071. Closing.
Jan 25 04:22:32 r-443-VM xl2tpd[4033]: Terminating pppd: sending TERM signal
to pid 197893
Jan 25 04:22:32 r-443-VM xl2tpd[4033]: Connection 5 closed to
102.119.162.40, port 1701 (Timeout)
Jan 25 04:22:32 r-443-VM pppd[197893]: Terminating on signal 15
Jan 25 04:22:32 r-443-VM pppd[197893]: Connect time 7.5 minutes.
Jan 25 04:22:32 r-443-VM pppd[197893]: Sent 0 bytes, received 2007 bytes.
Jan 25 04:22:32 r-443-VM charon[4019]: 09[KNL] interface ppp1 deactivated
Jan 25 04:22:32 r-443-VM charon[4019]: 07[KNL] 10.1.2.1 disappeared from ppp1
Jan 25 04:22:32 r-443-VM pppd[197893]: Script /etc/ppp/ip-down started (pid
199492)
Jan 25 04:22:32 r-443-VM pppd[197893]: Overriding mtu 1500 to 1410
Jan 25 04:22:32 r-443-VM pppd[197893]: PPPoL2TP options: lnsmode tid 9071
sid 35337 debugmask 0
Jan 25 04:22:32 r-443-VM pppd[197893]: Overriding mru 1500 to mtu value 1410
Jan 25 04:22:32 r-443-VM pppd[197893]: sent [LCP TermReq id=0x4 "User
request"]
Jan 25 04:22:32 r-443-VM pppd[197893]: rcvd [LCP TermAck id=0x4 "User
request"]
Jan 25 04:22:32 r-443-VM pppd[197893]: Connection terminated.
Jan 25 04:22:32 r-443-VM charon[4019]: 12[KNL] interface ppp1 deleted
Jan 25 04:22:32 r-443-VM pppd[197893]: Waiting for 1 child processes...
Jan 25 04:22:32 r-443-VM pppd[197893]: script /etc/ppp/ip-down, pid 199492
Jan 25 04:22:32 r-443-VM pppd[197893]: Script /etc/ppp/ip-down finished (pid
199492), status = 0x0
Jan 25 04:22:32 r-443-VM pppd[197893]: Exit.
Jan 25 04:22:33 r-443-VM xl2tpd[4033]: get_call: can't find call 35337 in
tunnel 9071
(ref=0/0)
Jan 25 04:22:33 r-443-VM xl2tpd[4033]: control_finish: Connection closed to
102.119.162.40, port 1701 (), Local: 9071, Remote: 5
Jan 25 04:22:33 r-443-VM charon[4019]: 13[NET] received packet: from
102.119.162.40[23171] to 102.119.162.26[4500] (76 bytes)
Jan 25 04:22:33 r-443-VM ipsec[4019]: 15[NET] sending packet: from
102.119.162.26[4500] to 102.119.162.40[1242] (204 bytes)
Jan 25 04:22:33 r-443-VM ipsec[4019]: 16[NET] received packet: from
102.119.162.40[1242] to 102.119.162.26[4500] (60 bytes)
Jan 25 04:22:33 r-443-VM ipsec[4019]: 16[ENC] parsed QUICK_MODE
[I] VPN client to site connection simultaneously for multiple users/PC in the 1 subnet [cloudstack]
tuanhoangth1603 opened a new issue, #8566: URL: https://github.com/apache/cloudstack/issues/8566 # ISSUE TYPE * Other # COMPONENT NAME VPN Client to site # CLOUDSTACK VERSION 4.17.2.0 # OS / ENVIRONMENT Ubuntu 20.04 # SUMMARY I created a VPC, where I enabled VPN Client to Site and created 2 users, vpn1 and vpn2. I used 2 PCs in the same subnet 172.16.10.0/24 to connect to the VPN. PC 1: Successfully connected to the VPN and can ping the VM within the VPC. PC 2: Unable to connect to the VPN if PC 1 is already connected to the VPN. If I disconnect the VPN on PC 1, then PC 2 can establish a VPN connection. I am using the Draytek Smart VPN app for both PCs. Is there any issue to be aware of when using VPN Client to Site for 2 or more PCs in the same network subnet? Thank you for any assistance! # EXPECTED RESULTS Both PCs can establish a VPN connection simultaneously. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [WIP] System VMs/VRs upgrade to Python3 and Debian 12 [cloudstack]
blueorangutan commented on PR #8497: URL: https://github.com/apache/cloudstack/pull/8497#issuecomment-1909161678 [SF] Trillian test result (tid-8931) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 55168 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8497-t8931-kvm-rocky8.zip Smoke tests completed. 120 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_08_upgrade_kubernetes_ha_cluster | `Failure` | 1002.43 | test_kubernetes_clusters.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] StoragePoolType as class [cloudstack]
blueorangutan commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1909138116 [SF] Trillian test result (tid-8932) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 54034 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8544-t8932-xenserver-71.zip Smoke tests completed. 121 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] docker simulator build failure [cloudstack]
boring-cyborg[bot] commented on issue #8565: URL: https://github.com/apache/cloudstack/issues/8565#issuecomment-1909132082 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] docker simulator build failure [cloudstack]
soulwhisper opened a new issue, #8565: URL: https://github.com/apache/cloudstack/issues/8565 I start simulator for tests, I ran commands below ```shell docker run --name simulator \ -p 5050:5050 \ -p 8080:8080 \ -d apache/cloudstack-simulator docker logs -f simulator ``` This is the output ```shell /usr/lib/python3/dist-packages/supervisor/options.py:473: UserWarning: Supervisord is running as root and it is searching for its configuration file in default locations (including its current working directory); you probably want to specify a "-c" argument specifying an absolute path to a configuration file for improved security. self.warnings.warn( 2024-01-24 23:27:08,018 CRIT Supervisor is running as root. Privileges were not dropped because no user is specified in the config file. If you intend to run as root, you can set user=root in the config file to avoid this message. 2024-01-24 23:27:08,018 INFO Included extra file "/etc/supervisor/conf.d/supervisord.conf" during parsing 2024-01-24 23:27:08,022 INFO RPC interface 'supervisor' initialized 2024-01-24 23:27:08,022 CRIT Server 'unix_http_server' running without any HTTP authentication checking 2024-01-24 23:27:08,022 INFO supervisord started with pid 1 2024-01-24 23:27:09,027 INFO spawned: 'cloudstack' with pid 7 2024-01-24 23:27:09,032 INFO spawned: 'cloudstack-ui' with pid 8 2024-01-24 23:27:09,035 INFO spawned: 'mysqld' with pid 9 > cloudstack-ui@4.18.1 serve /root/ui > vue-cli-service lint --no-fix && vue-cli-service serve [INFO] Scanning for projects... 2024-01-24 23:27:10,076 INFO success: cloudstack entered RUNNING state, process has stayed up for > than 1 seconds (startsecs) 2024-01-24 23:27:10,076 INFO success: cloudstack-ui entered RUNNING state, process has stayed up for > than 1 seconds (startsecs) 2024-01-24 23:27:10,076 INFO success: mysqld entered RUNNING state, process has stayed up for > than 1 seconds (startsecs) Downloading from central: https://repo.maven.apache.org/maven2/com/github/spotbugs/spotbugs-maven-plugin/3.1.12.2/spotbugs-maven-plugin-3.1.12.2.pom [WARNING] Failed to retrieve plugin descriptor for com.github.spotbugs:spotbugs-maven-plugin:3.1.12.2: Plugin com.github.spotbugs:spotbugs-maven-plugin:3.1.12.2 or one of its dependencies could not be resolved: Failed to read artifact descriptor for com.github.spotbugs:spotbugs-maven-plugin:jar:3.1.12.2 Downloading from central: https://repo.maven.apache.org/maven2/org/eclipse/jetty/jetty-maven-plugin/9.4.27.v20200227/jetty-maven-plugin-9.4.27.v20200227.pom [WARNING] Failed to retrieve plugin descriptor for org.eclipse.jetty:jetty-maven-plugin:9.4.27.v20200227: Plugin org.eclipse.jetty:jetty-maven-plugin:9.4.27.v20200227 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.eclipse.jetty:jetty-maven-plugin:jar:9.4.27.v20200227 Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-deploy-plugin/2.7/maven-deploy-plugin-2.7.pom [WARNING] Failed to retrieve plugin descriptor for org.apache.maven.plugins:maven-deploy-plugin:2.7: Plugin org.apache.maven.plugins:maven-deploy-plugin:2.7 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.apache.maven.plugins:maven-deploy-plugin:jar:2.7 Downloading from central: https://repo.maven.apache.org/maven2/org/eclipse/m2e/lifecycle-mapping/1.0.0/lifecycle-mapping-1.0.0.pom [WARNING] Failed to retrieve plugin descriptor for org.eclipse.m2e:lifecycle-mapping:1.0.0: Plugin org.eclipse.m2e:lifecycle-mapping:1.0.0 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-assembly-plugin/2.2.1/maven-assembly-plugin-2.2.1.pom [WARNING] Failed to retrieve plugin descriptor for org.apache.maven.plugins:maven-assembly-plugin:2.2.1: Plugin org.apache.maven.plugins:maven-assembly-plugin:2.2.1 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.apache.maven.plugins:maven-assembly-plugin:jar:2.2.1 Downloading from central: https://repo.maven.apache.org/maven2/org/codehaus/mojo/build-helper-maven-plugin/3.0.0/build-helper-maven-plugin-3.0.0.pom [WARNING] Failed to retrieve plugin descriptor for org.codehaus.mojo:build-helper-maven-plugin:3.0.0: Plugin org.codehaus.mojo:build-helper-maven-plugin:3.0.0 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.codehaus.mojo:build-helper-maven-plugin:jar:3.0.0 [WARNING] Failed to retrieve plugin descriptor for org.apache.maven.plugins:maven-deploy-plugin:2.7: Plugin org.apache.maven.plugins:maven-deploy-plugin:2.7 or one of its dependencies could not be resolved: Failed to
Re: [PR] NSX: Support internal LB service in NSX [cloudstack]
blueorangutan commented on PR #8559: URL: https://github.com/apache/cloudstack/pull/8559#issuecomment-1909113606 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NSX: Support internal LB service in NSX [cloudstack]
blueorangutan commented on PR #8559: URL: https://github.com/apache/cloudstack/pull/8559#issuecomment-1909041196 @Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NSX: Support internal LB service in NSX [cloudstack]
Pearl1594 commented on PR #8559: URL: https://github.com/apache/cloudstack/pull/8559#issuecomment-1909026756 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] StoragePoolType as class [cloudstack]
blueorangutan commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1909007942 [SF] Trillian test result (tid-8934) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46844 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8544-t8934-kvm-centos7.zip Smoke tests completed. 120 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_vpc_site2site_vpn_multiple_options | `Failure` | 308.87 | test_vpc_vpn.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allocate new ROOT volume (on restore virtual machine operation) only when resource count increment succeeds [cloudstack]
blueorangutan commented on PR #8555: URL: https://github.com/apache/cloudstack/pull/8555#issuecomment-1908749801 [SF] Trillian test result (tid-8926) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47292 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8555-t8926-kvm-centos7.zip Smoke tests completed. 120 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestSharedNetwork>:setup | `Error` | 53.62 | test_network.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch nsx-support-ilb updated (829d50c58c4 -> fca1df4ce7b)
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch nsx-support-ilb in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 829d50c58c4 NSX: Support internal LB service in NSX add fca1df4ce7b add lb removal logic No new revisions were added by this update. Summary of changes: .../src/main/java/org/apache/cloudstack/resource/NsxResource.java | 2 ++ .../src/main/java/org/apache/cloudstack/service/NsxApiClient.java | 8 ++-- ui/src/views/network/VpcTiersTab.vue | 3 ++- 3 files changed, 10 insertions(+), 3 deletions(-)
Re: [PR] Added missing metrics English locale strings [cloudstack]
kohrar commented on PR #8560: URL: https://github.com/apache/cloudstack/pull/8560#issuecomment-1908713400 > @sureshanaparti this is based on main so I changed the milestone to 4.20. @kohrar if you wnat this in 4.18.2 please `git rebase --onto 4.18 ` cc @JoaoJandre @DaanHoogland Thanks. I didn't realize I targetted main. I'll keep that in mind in the future. I've created a new PR (#8564) that targets 4.18. Is this the correct approach? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] UI: Added missing metrics English locale strings (for 4.18) [cloudstack]
kohrar opened a new pull request, #8564:
URL: https://github.com/apache/cloudstack/pull/8564
### Description
This is the same PR as #8560 but targets 4.18.
This PR fixes two missing English locale strings that are missing in the
metrics page in 4.18.1.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [x] Trivial
### Screenshots (if appropriate):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Externalise a few timeouts & fix timeout for hostSupportsUefi in libvirt ready command wrapper [cloudstack]
blueorangutan commented on PR #8547: URL: https://github.com/apache/cloudstack/pull/8547#issuecomment-1908590059 @vishesh92 a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Externalise a few timeouts & fix timeout for hostSupportsUefi in libvirt ready command wrapper [cloudstack]
vishesh92 commented on PR #8547: URL: https://github.com/apache/cloudstack/pull/8547#issuecomment-1908587823 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Externalise a few timeouts & fix timeout for hostSupportsUefi in libvirt ready command wrapper [cloudstack]
blueorangutan commented on PR #8547: URL: https://github.com/apache/cloudstack/pull/8547#issuecomment-1908584147 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow deletion of system VM templates [cloudstack]
weizhouapache commented on PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1908566764
> > @GaOrtiga @DaanHoogland sorry this PR is not needed in my opinion
>
> Having a workaround should not be a reason to restrict an operation. If
the operator does not know that you can circumvent this restriction they may
feel obliged to perform the operation directly in the DB, especially since the
exception thrown is very vague and editing the template's type to make it
deletable is very non-intuitive.
If the solution is not clear, make it clear then. for example
```
diff --git
a/server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java
b/server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java
index b886f0868f6..6456ca452ed 100644
--- a/server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java
+++ b/server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java
@@ -749,7 +749,7 @@ public class HypervisorTemplateAdapter extends
TemplateAdapterBase {
TemplateProfile profile = super.prepareDelete(cmd);
VMTemplateVO template = profile.getTemplate();
if (template.getTemplateType() == TemplateType.SYSTEM) {
-throw new InvalidParameterValueException("The DomR template
cannot be deleted.");
+throw new InvalidParameterValueException("The SYSTEM template
cannot be deleted. Please update template type to USER and retry.");
}
checkZoneImageStores(profile.getTemplate(),
profile.getZoneIdList());
return profile;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Allow deletion of system VM templates [cloudstack]
weizhouapache commented on PR #8556: URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1908559652 > The use case would be any operator that wants to delete `SYSTEM` templates and does not know about the workaround, since it's not really something self-explanatory. @GaOrtiga this can be fixed by a PR with changes in the error message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow deletion of system VM templates [cloudstack]
GaOrtiga commented on PR #8556: URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1908522137 > > @GaOrtiga as a user wants this convenience. Even when I agree that it is not vital, that would be enough for it to be needed. > > > > * Is there any more pressing objection @weizhouapache? > > * Alternatively, is there a modus operandus that would make for a more acceptable change? > > @DaanHoogland SYSTEM template is very important for cloudstack environments. We need to be very careful to remove it a force flag is not enough to me. > > since we already have a way to delete a SYSTEM template (see [#8556 (comment)](https://github.com/apache/cloudstack/pull/8556#issuecomment-1906168608)), this change is unnecessary. > > my question to @GaOrtiga @DaanHoogland is there special use case that we must be able to delete a SYSTEM template in one step ? The use case would be any operator that wants to delete `SYSTEM` templates and does not know about the workaround, since it's not really something self-explanatory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow deletion of system VM templates [cloudstack]
GaOrtiga commented on PR #8556: URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1908508050 > @GaOrtiga @DaanHoogland sorry this PR is not needed in my opinion Having a workaround should not be a reason to restrict an operation. If the operator does not know that you can circumvent this restriction they may feel obliged to perform the operation directly in the DB, especially since the exception thrown is very vague and editing the template's type to make it deletable is very non-intuitive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Externalise a few timeouts & fix timeout for hostSupportsUefi in libvirt ready command wrapper [cloudstack]
blueorangutan commented on PR #8547: URL: https://github.com/apache/cloudstack/pull/8547#issuecomment-1908462547 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Externalise a few timeouts & fix timeout for hostSupportsUefi in libvirt ready command wrapper [cloudstack]
vishesh92 commented on PR #8547: URL: https://github.com/apache/cloudstack/pull/8547#issuecomment-1908460969 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow deletion of system VM templates [cloudstack]
weizhouapache commented on PR #8556: URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1908414021 @DaanHoogland @GaOrtiga let me explain a bit more users might delete the unused SYSTEM template one or twice every year by average. It takes just few minutes. However, with this PR, they will be able to delete SYSTEM template by a single API/command. If the SYSTEM template is removed by mistake, it will be a critical issue . can you compare the pros and cons ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow deletion of system VM templates [cloudstack]
weizhouapache commented on PR #8556: URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1908378077 > @GaOrtiga as a user wants this convenience. Even when I agree that it is not vital, that would be enough for it to be needed. > > * Is there any more pressing objection @weizhouapache? > * Alternatively, is there a modus operandus that would make for a more acceptable change? @DaanHoogland SYSTEM template is very important for cloudstack environments. We need to be very careful to remove it a force flag is not enough to me. since we already have a way to delete a SYSTEM template (see https://github.com/apache/cloudstack/pull/8556#issuecomment-1906168608), this change is unnecessary. my question to @GaOrtiga @DaanHoogland is there special use case that we must be able to delete a SYSTEM template in one step ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add compute offering details in UI [cloudstack]
blueorangutan commented on PR #8563: URL: https://github.com/apache/cloudstack/pull/8563#issuecomment-1908360086 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8563 (QA-JID-269) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow deletion of system VM templates [cloudstack]
DaanHoogland commented on PR #8556: URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1908351734 @GaOrtiga as a user wants this convenience. Even when I agree that it is not vital, that would be enough for it to be needed. - Is there any more pressing objection @weizhouapache? - Alternatively, is there a modus operandus that would make for a more acceptable change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] VPC Routing/Network Issue [cloudstack]
weizhouapache commented on issue #8562: URL: https://github.com/apache/cloudstack/issues/8562#issuecomment-1908349794 @DaanHoogland added to 4.18.2.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] VPC Routing/Network Issue [cloudstack]
weizhouapache commented on issue #8562: URL: https://github.com/apache/cloudstack/issues/8562#issuecomment-1908348950 Just an update: I was able to reproduce the issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Added missing metrics English locale strings [cloudstack]
DaanHoogland commented on PR #8560: URL: https://github.com/apache/cloudstack/pull/8560#issuecomment-1908341928 @sureshanaparti this is based on main so I changed the milestone to 4.20. @kohrar if you wnat this in 4.18.2 please `git rebase --onto 4.18 ` cc @JoaoJandre -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add compute offering details in UI [cloudstack]
DaanHoogland commented on PR #8563: URL: https://github.com/apache/cloudstack/pull/8563#issuecomment-1908331471 @JoaoJandre don't see why this wouldn't work on 4.18.2 as welll. Let me know if you want me to backport. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add compute offering details in UI [cloudstack]
blueorangutan commented on PR #8563: URL: https://github.com/apache/cloudstack/pull/8563#issuecomment-1908330873 @DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add compute offering details in UI [cloudstack]
DaanHoogland commented on PR #8563: URL: https://github.com/apache/cloudstack/pull/8563#issuecomment-1908330034 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow deletion of system VM templates [cloudstack]
weizhouapache commented on PR #8556: URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1908317390 @GaOrtiga @DaanHoogland sorry this PR is not needed in my opinion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow deletion of system VM templates [cloudstack]
GaOrtiga commented on code in PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#discussion_r1465051345
##
server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java:
##
@@ -748,9 +748,6 @@ void checkAndRemoveTemplateDetails(VMTemplateVO template) {
public TemplateProfile prepareDelete(DeleteTemplateCmd cmd) {
TemplateProfile profile = super.prepareDelete(cmd);
VMTemplateVO template = profile.getTemplate();
-if (template.getTemplateType() == TemplateType.SYSTEM) {
-throw new InvalidParameterValueException("The DomR template cannot
be deleted.");
-}
Review Comment:
> ```
> if (template.getTemplateType() == TemplateType.SYSTEM && !
cmd.isForced()) {
> throw new InvalidParameterValueException("The DomR template
cannot be deleted.");
> }
> ```
>
> is what you mean @GaOrtiga ?
@DaanHoogland @weizhouapache given that this operation can only be carried
out by Root Admins, could we proceed with this proposed implementation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Allow deletion of system VM templates [cloudstack]
GaOrtiga commented on code in PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#discussion_r1465047023
##
server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java:
##
@@ -748,9 +748,6 @@ void checkAndRemoveTemplateDetails(VMTemplateVO template) {
public TemplateProfile prepareDelete(DeleteTemplateCmd cmd) {
TemplateProfile profile = super.prepareDelete(cmd);
VMTemplateVO template = profile.getTemplate();
-if (template.getTemplateType() == TemplateType.SYSTEM) {
-throw new InvalidParameterValueException("The DomR template cannot
be deleted.");
-}
Review Comment:
Yes, and also update the message in the exception.
##
server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java:
##
@@ -748,9 +748,6 @@ void checkAndRemoveTemplateDetails(VMTemplateVO template) {
public TemplateProfile prepareDelete(DeleteTemplateCmd cmd) {
TemplateProfile profile = super.prepareDelete(cmd);
VMTemplateVO template = profile.getTemplate();
-if (template.getTemplateType() == TemplateType.SYSTEM) {
-throw new InvalidParameterValueException("The DomR template cannot
be deleted.");
-}
Review Comment:
Yes, and I will also update the message in the exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Added missing metrics English locale strings [cloudstack]
blueorangutan commented on PR #8560: URL: https://github.com/apache/cloudstack/pull/8560#issuecomment-1908298787 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8560 (QA-JID-268) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add compute offering details in UI [cloudstack]
Pearl1594 commented on code in PR #8563:
URL: https://github.com/apache/cloudstack/pull/8563#discussion_r1465030956
##
ui/src/components/view/DetailsTab.vue:
##
@@ -91,6 +91,18 @@
+
+{{ dataResource.serviceofferingdetails.mincpunumber }}
+
+
+{{ dataResource.serviceofferingdetails.maxcpunumber }}
+
+
+{{ dataResource.serviceofferingdetails.minmemory }}
+
+
+{{ dataResource.serviceofferingdetails.maxmemory }}
+
Review Comment:
Could be reduced to
```suggestion
{{ dataResource.serviceofferingdetails[item] }}
```
##
ui/src/config/section/offering.js:
##
@@ -47,6 +47,22 @@ export default {
store.getters.apis.createServiceOffering.params.filter(x => x.name
=== 'rootdisksize').length > 0) {
fields.splice(12, 0, 'rootdisksize')
}
+if (store.getters.apis.createServiceOffering &&
+ store.getters.apis.createServiceOffering.params.filter(x => x.name
=== 'mincpunumber').length > 0) {
+ fields.push('mincpunumber')
+}
+if (store.getters.apis.createServiceOffering &&
+ store.getters.apis.createServiceOffering.params.filter(x => x.name
=== 'maxcpunumber').length > 0) {
+ fields.push('maxcpunumber')
+}
+if (store.getters.apis.createServiceOffering &&
+ store.getters.apis.createServiceOffering.params.filter(x => x.name
=== 'minmemory').length > 0) {
+ fields.push('minmemory')
+}
+if (store.getters.apis.createServiceOffering &&
+ store.getters.apis.createServiceOffering.params.filter(x => x.name
=== 'maxmemory').length > 0) {
+ fields.push('maxmemory')
+}
Review Comment:
```suggestion
const detailFields = ['minmemory', 'maxmemory', 'mincpunumber',
'maxcpunumber']
for (const field of detailFields) {
if (store.getters.apis.createServiceOffering &&
store.getters.apis.createServiceOffering.params.filter(x =>
field === x.name).length > 0) {
fields.push(field)
}
}
```
##
ui/src/components/view/DetailsTab.vue:
##
@@ -37,7 +37,7 @@
size="small"
:dataSource="fetchDetails()">
-
+
Review Comment:
```suggestion
<
```
To prevent the header to be listed in offerings that don't have these params
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Allow deletion of system VM templates [cloudstack]
DaanHoogland commented on code in PR #8556:
URL: https://github.com/apache/cloudstack/pull/8556#discussion_r1465022426
##
server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java:
##
@@ -748,9 +748,6 @@ void checkAndRemoveTemplateDetails(VMTemplateVO template) {
public TemplateProfile prepareDelete(DeleteTemplateCmd cmd) {
TemplateProfile profile = super.prepareDelete(cmd);
VMTemplateVO template = profile.getTemplate();
-if (template.getTemplateType() == TemplateType.SYSTEM) {
-throw new InvalidParameterValueException("The DomR template cannot
be deleted.");
-}
Review Comment:
```sugestion
if (template.getTemplateType() == TemplateType.SYSTEM && !
cmd.isForced()) {
throw new InvalidParameterValueException("The DomR template
cannot be deleted.");
}
```
is what you mean @GaOrtiga ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix ordering of secondary storages with the algorithm `firstfitleastconsumed` [cloudstack]
GaOrtiga commented on code in PR #8557:
URL: https://github.com/apache/cloudstack/pull/8557#discussion_r1465019618
##
engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/manager/ImageStoreProviderManagerImpl.java:
##
@@ -179,52 +179,24 @@ public DataStore getRandomImageStore(List
imageStores) {
@Override
public DataStore getImageStoreWithFreeCapacity(List
imageStores) {
-if (imageStores.size() > 1) {
-imageStores.sort(new Comparator() { // Sort data stores
based on free capacity
-@Override
-public int compare(DataStore store1, DataStore store2) {
-return
Long.compare(_statsCollector.imageStoreCurrentFreeCapacity(store1),
-
_statsCollector.imageStoreCurrentFreeCapacity(store2));
-}
-});
-for (DataStore imageStore : imageStores) {
-// Return image store if used percentage is less then
threshold value i.e. 90%.
-if (_statsCollector.imageStoreHasEnoughCapacity(imageStore)) {
-return imageStore;
-}
-}
-} else if (imageStores.size() == 1) {
-if
(_statsCollector.imageStoreHasEnoughCapacity(imageStores.get(0))) {
-return imageStores.get(0);
-}
+List orderedImageStores =
orderImageStoresOnFreeCapacity(imageStores);
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] add compute offering details in UI [cloudstack]
DaanHoogland commented on PR #8563: URL: https://github.com/apache/cloudstack/pull/8563#issuecomment-1908270132 :-1: from myself, the titles are visible when the fields are empty. That needs to be remedied. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Added missing metrics English locale strings [cloudstack]
blueorangutan commented on PR #8560: URL: https://github.com/apache/cloudstack/pull/8560#issuecomment-1908267146 @DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Added missing metrics English locale strings [cloudstack]
DaanHoogland commented on PR #8560: URL: https://github.com/apache/cloudstack/pull/8560#issuecomment-1908265633 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] cloudstack-ui RPM package has bad permissions [cloudstack]
DaanHoogland commented on issue #8558: URL: https://github.com/apache/cloudstack/issues/8558#issuecomment-1908244575 @kohrar I am not completely sure about your problem but it sounds like unintended. Would you have a fix to add to the packaging? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow deletion of system VM templates [cloudstack]
GaOrtiga commented on PR #8556: URL: https://github.com/apache/cloudstack/pull/8556#issuecomment-1908228049 > @GaOrtiga If you update the template to USER, then you will be able to remove it. this will prevent some human mistakes @weizhouapache I understand that there is a way to circumvent this restriction, however, since this would only be possible to Root Admins, I believe deleting it directly should still be an option. To address your concerns about this change, I could make the `force` flag necessary when the template's type is `SYSTEM`. Would this measure be enough to offset the concerns regarding this implementation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Normalize dates in Usage and Quota APIs [cloudstack]
DaanHoogland commented on PR #8243: URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-1908227425 @andrijapanicsb I know you have some experience with this, can you comment on this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add compute offering details in UI [cloudstack]
codecov[bot] commented on PR #8563: URL: https://github.com/apache/cloudstack/pull/8563#issuecomment-1908227301 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8563?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: `13 lines` in your changes are missing coverage. Please review. > Comparison is base [(`1925040`)](https://app.codecov.io/gh/apache/cloudstack/commit/19250403e645c76f60b17aa4aeb4dc915f5ca206?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 30.82% compared to head [(`e85dcaa`)](https://app.codecov.io/gh/apache/cloudstack/pull/8563?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 4.39%. | [Files](https://app.codecov.io/gh/apache/cloudstack/pull/8563?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [ui/src/config/section/offering.js](https://app.codecov.io/gh/apache/cloudstack/pull/8563?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-dWkvc3JjL2NvbmZpZy9zZWN0aW9uL29mZmVyaW5nLmpz) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8563?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [ui/src/components/view/DetailsTab.vue](https://app.codecov.io/gh/apache/cloudstack/pull/8563?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-dWkvc3JjL2NvbXBvbmVudHMvdmlldy9EZXRhaWxzVGFiLnZ1ZQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8563?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8563 +/- ## - Coverage 30.82% 4.39% -26.43% Files 5341 361 -4980 Lines375027 28639 -346388 Branches 545544993-49561 - Hits 1155921258 -114334 + Misses 244155 27242 -216913 + Partials 15280 139-15141 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8563/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8563/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8563/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.39% <0.00%> (-0.01%)` | :arrow_down: | | [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8563/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8563?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] VPC Routing/Network Issue [cloudstack]
weizhouapache commented on issue #8562: URL: https://github.com/apache/cloudstack/issues/8562#issuecomment-1908227163 > @weizhouapache 99.127.xxx.107 is used in an isolated network, but I can ping it from other VPC,or from public not from a specific VPC mentioned in issue. A Webserver is running behind 107, I cant telnet to port 443 from the VM in VPC under concern. got it, I thought the 99.127.xxx.107 is associated to the VPC and you created PF on it, which is not pingable from a VM... let me test it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add compute offering details in UI [cloudstack]
DaanHoogland commented on PR #8563: URL: https://github.com/apache/cloudstack/pull/8563#issuecomment-1908207676 @Pearl1594 I implemented your design but I feel I need to generalise it a bit more. Any advice appreciated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] add compute offering details in UI [cloudstack]
DaanHoogland opened a new pull request, #8563:
URL: https://github.com/apache/cloudstack/pull/8563
### Description
This PR...
Fixes: #8537
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] VPC Routing/Network Issue [cloudstack]
midhunpjos commented on issue #8562: URL: https://github.com/apache/cloudstack/issues/8562#issuecomment-1908185337 @weizhouapache 99.127.xxx.107 is used in an isolated network, but I can ping it from other VPC,or from public not from a specific VPC mentioned in issue. A Webserver is running behind 107, I cant telnet to port 443 from the VM in VPC under concern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] VPC Routing/Network Issue [cloudstack]
weizhouapache commented on issue #8562: URL: https://github.com/apache/cloudstack/issues/8562#issuecomment-1908169010 > @weizhouapache Yes .Port forwarding is enabled for the IP. Firewall is open for ICMP. Not only 99.127.xxx.107, 99.127.xxx.108... are not accessible from specific VPC VM. > > Another update.. In VPC If I acquire new IP and add static NAT to VM in VPC, then all Public subnets are pinging including 99.127.xxx.107 I think it is expected that the Public IP for port forwarding or load balacing is not pingable. only the ports for PF/LB are useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] VPC Routing/Network Issue [cloudstack]
midhunpjos commented on issue #8562: URL: https://github.com/apache/cloudstack/issues/8562#issuecomment-1908153374 @weizhouapache Yes .Port forwarding is enabled for the IP. Firewall is open for ICMP. Not only 99.127.xxx.107, 99.127.xxx.108... are not accessible from specific VPC VM. Another update.. In VPC If I acquire new IP and add static NAT to VM in VPC, then all Public subnets are pinging including 99.127.xxx.107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] VPC Routing/Network Issue [cloudstack]
weizhouapache commented on issue #8562: URL: https://github.com/apache/cloudstack/issues/8562#issuecomment-1908087822 > @weizhouapache Q: can you log into the VR, and check if the gateway of each public range is reachable ? Yes From the VR gateway of each subnet is reachable. The Public IP's are also reachable > > Q: can you create a tier with default_allow and test with a vm on it ? Current test in done on tier with default_allow. From the VM, the subnet 99.127.xxx.64/27 is reachable. (This is the GW of VR). Other subnet's gateway and IP's are not reachable. @midhunpjos is the IP `99.127.xxx.107` used for some purposes, e.g. static nat or port forwarding , load balancer ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] VPC Routing/Network Issue [cloudstack]
midhunpjos commented on issue #8562: URL: https://github.com/apache/cloudstack/issues/8562#issuecomment-1908054724 @weizhouapache Q: can you log into the VR, and check if the gateway of each public range is reachable ? Yes From the VR gateway of each subnet is reachable. The Public IP's are also reachable Q: can you create a tier with default_allow and test with a vm on it ? Current test in done on tier with default_allow. From the VM, the subnet 99.127.xxx.64/27 is reachable. (This is the GW of VR). Other subnet's gateway and IP's are not reachable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove sensitive params (VmPassword, etc) from VMWork log [cloudstack]
rohityadavcloud commented on PR #8553: URL: https://github.com/apache/cloudstack/pull/8553#issuecomment-1908018638 LGTM - let's merge for 4.19.1.0, after the freeze/4.19.0.0 GA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack-kubernetes-provider) branch release-v1.1.0 created (now be24d41b)
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a change to branch release-v1.1.0 in repository https://gitbox.apache.org/repos/asf/cloudstack-kubernetes-provider.git at be24d41b Update version to v1.1.0 in deployment.yaml This branch includes the following new commits: new be24d41b Update version to v1.1.0 in deployment.yaml The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
(cloudstack-kubernetes-provider) 01/01: Update version to v1.1.0 in deployment.yaml
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a commit to branch release-v1.1.0 in repository https://gitbox.apache.org/repos/asf/cloudstack-kubernetes-provider.git commit be24d41b5547170cfe39a1f4496ad62d0bd00229 Author: Wei Zhou AuthorDate: Wed Jan 24 12:11:00 2024 +0100 Update version to v1.1.0 in deployment.yaml --- deployment.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deployment.yaml b/deployment.yaml index 25989ac5..b0639dc0 100644 --- a/deployment.yaml +++ b/deployment.yaml @@ -143,7 +143,7 @@ spec: spec: containers: - name: cloud-controller-manager -image: apache/cloudstack-kubernetes-provider:v1.0.0 +image: apache/cloudstack-kubernetes-provider:v1.1.0 imagePullPolicy: IfNotPresent args: - --leader-elect=true
Re: [I] VPC Routing/Network Issue [cloudstack]
weizhouapache commented on issue #8562: URL: https://github.com/apache/cloudstack/issues/8562#issuecomment-1907903294 @midhunpjos - can you log into the VR, and check if the gateway of each public range is reachable ? - can you create a tier with `default_allow` and test with a vm on it ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] DHCP in Virtual Router is not working [cloudstack]
weizhouapache closed issue #8451: DHCP in Virtual Router is not working URL: https://github.com/apache/cloudstack/issues/8451 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Externalise a few timeouts & fix timeout for hostSupportsUefi in libvirt ready command wrapper [cloudstack]
harikrishna-patnala commented on code in PR #8547:
URL: https://github.com/apache/cloudstack/pull/8547#discussion_r1464718607
##
agent/src/main/java/com/cloud/agent/properties/AgentProperties.java:
##
@@ -659,6 +659,14 @@ public class AgentProperties{
*/
public static final Property STOP_SCRIPT_TIMEOUT = new
Property<>("stop.script.timeout", 120);
+/**
+ * Time (in seconds) to wait for scripts to complete.
+ * This is not used for every script execution.
+ * Data type: Integer.
+ * Default value: 60
+ */
+public static final Property AGENT_SCRIPT_TIMEOUT = new
Property<>("agent.script.timeout", 60);
Review Comment:
yeah correct but that has to be known to the operator right, we normally put
them in the properties file and comment them
eg.
# Instance Conversion from Vmware to KVM through virt-v2v. Enable verbose
mode
# virtv2v.verbose.enabled=false
##
agent/src/main/java/com/cloud/agent/properties/AgentProperties.java:
##
@@ -659,6 +659,14 @@ public class AgentProperties{
*/
public static final Property STOP_SCRIPT_TIMEOUT = new
Property<>("stop.script.timeout", 120);
+/**
+ * Time (in seconds) to wait for scripts to complete.
+ * This is not used for every script execution.
+ * Data type: Integer.
+ * Default value: 60
+ */
+public static final Property AGENT_SCRIPT_TIMEOUT = new
Property<>("agent.script.timeout", 60);
Review Comment:
yeah correct but that has to be known to the operator right, we normally put
them in the properties file and comment them
eg.
```
# Instance Conversion from Vmware to KVM through virt-v2v. Enable verbose
mode
# virtv2v.verbose.enabled=false
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] StoragePoolType as class [cloudstack]
blueorangutan commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1907867517 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Externalise a few timeouts & fix timeout for hostSupportsUefi in libvirt ready command wrapper [cloudstack]
vishesh92 commented on code in PR #8547:
URL: https://github.com/apache/cloudstack/pull/8547#discussion_r1464709838
##
agent/src/main/java/com/cloud/agent/properties/AgentProperties.java:
##
@@ -659,6 +659,14 @@ public class AgentProperties{
*/
public static final Property STOP_SCRIPT_TIMEOUT = new
Property<>("stop.script.timeout", 120);
+/**
+ * Time (in seconds) to wait for scripts to complete.
+ * This is not used for every script execution.
+ * Data type: Integer.
+ * Default value: 60
+ */
+public static final Property AGENT_SCRIPT_TIMEOUT = new
Property<>("agent.script.timeout", 60);
Review Comment:
We don't need to. If the user adds it in the file, it will get picked up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Externalise a few timeouts & fix timeout for hostSupportsUefi in libvirt ready command wrapper [cloudstack]
blueorangutan commented on PR #8547: URL: https://github.com/apache/cloudstack/pull/8547#issuecomment-1907824569 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack-www) branch docusaurus-staging updated (200721214 -> c0aadc441)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from 200721214 split the styles of the survey and survey announce block add c0aadc441 Fix grammar in Markdown files (#137) No new revisions were added by this update. Summary of changes: blog/2013-04-23-apache_cloudstack_weekly_news_22.md | 2 +- blog/2013-07-02-apache_cloudstack_weekly_news_12.md | 2 +- blog/2013-07-11-cloudstack_weekly_news_10_july.md | 2 +- blog/2013-08-16-announcing_the_cloudstack_collaboration_conference.md | 2 +- blog/2013-09-05-apache_cloudstack_weekly_news_42.md | 2 +- blog/2014-04-09-how_to_mitigate_openssl_heartbleed.md | 4 ++-- 6 files changed, 7 insertions(+), 7 deletions(-)
Re: [PR] Externalise a few timeouts & fix timeout for hostSupportsUefi in libvirt ready command wrapper [cloudstack]
harikrishna-patnala commented on code in PR #8547:
URL: https://github.com/apache/cloudstack/pull/8547#discussion_r1464654622
##
agent/src/main/java/com/cloud/agent/properties/AgentProperties.java:
##
@@ -659,6 +659,14 @@ public class AgentProperties{
*/
public static final Property STOP_SCRIPT_TIMEOUT = new
Property<>("stop.script.timeout", 120);
+/**
+ * Time (in seconds) to wait for scripts to complete.
+ * This is not used for every script execution.
+ * Data type: Integer.
+ * Default value: 60
+ */
+public static final Property AGENT_SCRIPT_TIMEOUT = new
Property<>("agent.script.timeout", 60);
Review Comment:
@vishesh92 we need to add this in agent.properties to make it configurable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Externalise a few timeouts & fix timeout for hostSupportsUefi in libvirt ready command wrapper [cloudstack]
sureshanaparti commented on code in PR #8547:
URL: https://github.com/apache/cloudstack/pull/8547#discussion_r1464645992
##
engine/storage/volume/src/main/java/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java:
##
@@ -121,7 +122,9 @@ private NicTO createNicTOFromNetworkAndOffering(NetworkVO
networkVO, NetworkOffe
public boolean hostConnect(long hostId, long poolId) throws
StorageConflictException {
StoragePool pool = (StoragePool)
this.dataStoreMgr.getDataStore(poolId, DataStoreRole.Primary);
ModifyStoragePoolCommand cmd = new ModifyStoragePoolCommand(true,
pool);
-cmd.setWait(60);
+cmd.setWait(Wait.value() / 5);
+s_logger.debug(String.format("Sending modify storage pool command to
agent: %d for storage pool: %d with timeout %d seconds",
+hostId, poolId, cmd.getWait() / 5));
Review Comment:
```suggestion
hostId, poolId, cmd.getWait()));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] StoragePoolType as class [cloudstack]
blueorangutan commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1907749634 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] VPN Client to site: Cannot ping to VM in VPC [cloudstack]
weizhouapache commented on issue #8454: URL: https://github.com/apache/cloudstack/issues/8454#issuecomment-1907733739 @tuanhoangth1603 I am closing this issue. please feel free to reopen it or create new issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] VPN Client to site: Cannot ping to VM in VPC [cloudstack]
weizhouapache closed issue #8454: VPN Client to site: Cannot ping to VM in VPC URL: https://github.com/apache/cloudstack/issues/8454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Externalise a few timeouts & fix timeout for hostSupportsUefi in libvirt ready command wrapper [cloudstack]
sureshanaparti commented on code in PR #8547:
URL: https://github.com/apache/cloudstack/pull/8547#discussion_r1464610998
##
engine/storage/volume/src/main/java/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java:
##
@@ -121,7 +122,7 @@ private NicTO createNicTOFromNetworkAndOffering(NetworkVO
networkVO, NetworkOffe
public boolean hostConnect(long hostId, long poolId) throws
StorageConflictException {
StoragePool pool = (StoragePool)
this.dataStoreMgr.getDataStore(poolId, DataStoreRole.Primary);
ModifyStoragePoolCommand cmd = new ModifyStoragePoolCommand(true,
pool);
-cmd.setWait(60);
+cmd.setWait(Wait.value()/5);
Review Comment:
```suggestion
cmd.setWait(Wait.value() / 5);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] StoragePoolType as class [cloudstack]
sureshanaparti commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1907718702 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] StoragePoolType as class [cloudstack]
sureshanaparti commented on code in PR #8544:
URL: https://github.com/apache/cloudstack/pull/8544#discussion_r1464590405
##
framework/db/src/main/java/com/cloud/utils/db/GenericDaoBase.java:
##
@@ -650,7 +655,7 @@ protected void setField(Object entity, Field field,
ResultSet rs, int index) thr
} else if (type == byte[].class) {
field.set(entity, rs.getBytes(index));
} else {
-field.set(entity, rs.getObject(index));
+field.set(entity,
_conversionSupport.convertToEntityAttribute(field, rs.getObject(index)));
Review Comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Externalise a few timeouts & fix timeout for hostSupportsUefi in libvirt ready command wrapper [cloudstack]
shwstppr commented on code in PR #8547:
URL: https://github.com/apache/cloudstack/pull/8547#discussion_r1464583734
##
engine/storage/volume/src/main/java/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java:
##
@@ -121,7 +122,7 @@ private NicTO createNicTOFromNetworkAndOffering(NetworkVO
networkVO, NetworkOffe
public boolean hostConnect(long hostId, long poolId) throws
StorageConflictException {
StoragePool pool = (StoragePool)
this.dataStoreMgr.getDataStore(poolId, DataStoreRole.Primary);
ModifyStoragePoolCommand cmd = new ModifyStoragePoolCommand(true,
pool);
-cmd.setWait(60);
+cmd.setWait(Wait.value()/5);
Review Comment:
@vishesh92 do we need to add some logging here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] StoragePoolType as class [cloudstack]
sureshanaparti commented on code in PR #8544:
URL: https://github.com/apache/cloudstack/pull/8544#discussion_r1464583628
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java:
##
@@ -775,23 +781,22 @@ public KVMPhysicalDisk createPhysicalDisk(String name,
KVMStoragePool pool,
s_logger.info("Attempting to create volume " + name + " (" +
pool.getType().toString() + ") in pool "
+ pool.getUuid() + " with size " + toHumanReadableSize(size));
-switch (pool.getType()) {
-case RBD:
-return createPhysicalDiskByLibVirt(name, pool,
PhysicalDiskFormat.RAW, provisioningType, size);
-case NetworkFilesystem:
-case Filesystem:
-switch (format) {
-case QCOW2:
-case RAW:
-return createPhysicalDiskByQemuImg(name, pool, format,
provisioningType, size, passphrase);
-case DIR:
-case TAR:
-return createPhysicalDiskByLibVirt(name, pool, format,
provisioningType, size);
-default:
-throw new CloudRuntimeException("Unexpected disk
format is specified.");
-}
-default:
-return createPhysicalDiskByLibVirt(name, pool, format,
provisioningType, size);
+StoragePoolType poolType = pool.getType();
Review Comment:
tried switch/case on poolType (string), noticed some errors with it. keeping
the new/refactored changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Externalise a few timeouts & fix timeout for hostSupportsUefi in libvirt ready command wrapper [cloudstack]
blueorangutan commented on PR #8547: URL: https://github.com/apache/cloudstack/pull/8547#issuecomment-1907705902 [SF] Trillian test result (tid-8924) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 48332 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8547-t8924-vmware-67u3.zip Smoke tests completed. 120 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_balanced_drs_algorithm | `Failure` | 135.16 | test_cluster_drs.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Externalise a few timeouts & fix timeout for hostSupportsUefi in libvirt ready command wrapper [cloudstack]
blueorangutan commented on PR #8547: URL: https://github.com/apache/cloudstack/pull/8547#issuecomment-1907700139 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Externalise a few timeouts & fix timeout for hostSupportsUefi in libvirt ready command wrapper [cloudstack]
vishesh92 commented on PR #8547: URL: https://github.com/apache/cloudstack/pull/8547#issuecomment-1907698821 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Externalise a few timeouts & fix timeout for hostSupportsUefi in libvirt ready command wrapper [cloudstack]
blueorangutan commented on PR #8547: URL: https://github.com/apache/cloudstack/pull/8547#issuecomment-1907692851 [SF] Trillian test result (tid-8923) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 48002 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8547-t8923-xenserver-71.zip Smoke tests completed. 120 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_08_upgrade_kubernetes_ha_cluster | `Failure` | 681.44 | test_kubernetes_clusters.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Externalise a few timeouts & fix timeout for hostSupportsUefi in libvirt ready command wrapper [cloudstack]
blueorangutan commented on PR #8547: URL: https://github.com/apache/cloudstack/pull/8547#issuecomment-1907670272 [SF] Trillian test result (tid-8925) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47048 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8547-t8925-kvm-centos7.zip Smoke tests completed. 121 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] StoragePoolType as class [cloudstack]
blueorangutan commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1907665475 @rohityadavcloud a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] StoragePoolType as class [cloudstack]
rohityadavcloud commented on PR #8544: URL: https://github.com/apache/cloudstack/pull/8544#issuecomment-1907664023 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (cloudstack-www): Workflow run "Pages" is working again!
The GitHub Actions job "Pages" on cloudstack-www.git has succeeded. Run started by GitHub user DaanHoogland (triggered by DaanHoogland). Head commit for run: 200721214e03263b1878467cc1fa57d4ed1469c7 / Daan Hoogland split the styles of the survey and survey announce block Report URL: https://github.com/apache/cloudstack-www/actions/runs/7637632942 With regards, GitHub Actions via GitBox
(cloudstack-www) branch docusaurus-staging updated (c6c9c02a5 -> 200721214)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from c6c9c02a5 Fix spelling (#136) add 200721214 split the styles of the survey and survey announce block No new revisions were added by this update. Summary of changes: src/css/custom.css | 7 --- src/pages/index.tsx | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-)
Re: [PR] Externalise a few timeouts & fix timeout for hostSupportsUefi in libvirt ready command wrapper [cloudstack]
vishesh92 commented on code in PR #8547:
URL: https://github.com/apache/cloudstack/pull/8547#discussion_r1464515044
##
engine/storage/volume/src/main/java/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java:
##
@@ -121,7 +135,7 @@ private NicTO createNicTOFromNetworkAndOffering(NetworkVO
networkVO, NetworkOffe
public boolean hostConnect(long hostId, long poolId) throws
StorageConflictException {
StoragePool pool = (StoragePool)
this.dataStoreMgr.getDataStore(poolId, DataStoreRole.Primary);
ModifyStoragePoolCommand cmd = new ModifyStoragePoolCommand(true,
pool);
-cmd.setWait(60);
+cmd.setWait(ModifyStoragePoolCommandWait.value());
Review Comment:
Use (wait.timeout / 6) here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Externalise a few timeouts & fix timeout for hostSupportsUefi in libvirt ready command wrapper [cloudstack]
vishesh92 commented on code in PR #8547:
URL: https://github.com/apache/cloudstack/pull/8547#discussion_r1464511864
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtReadyCommandWrapper.java:
##
@@ -51,11 +53,12 @@ public Answer execute(final ReadyCommand command, final
LibvirtComputingResource
private boolean hostSupportsUefi(boolean isUbuntuHost) {
String cmd = "rpm -qa | grep -i ovmf";
+int timeout =
AgentPropertiesFileHandler.getPropertyValue(AgentProperties.LIBVIRT_HOST_UEFI_SCRIPT_TIMEOUT)
* 1000; // Get property value & convert to milliseconds
Review Comment:
Add a common timeout for all scripts here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Added missing metrics English locale strings [cloudstack]
shwstppr commented on PR #8560: URL: https://github.com/apache/cloudstack/pull/8560#issuecomment-1907627264 @kohrar this needs to be targetted to 4.18 branch if you would want it to go in 4.18.2 cc @JoaoJandre -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (cloudstack-www): Workflow run "Pages" failed!
The GitHub Actions job "Pages" on cloudstack-www.git has failed. Run started by GitHub user jbampton (triggered by jbampton). Head commit for run: f0e33bfc8869698fcd33548af0fdb6b5f48bff08 / John Bampton Fix grammar in Markdown files Report URL: https://github.com/apache/cloudstack-www/actions/runs/7637378769 With regards, GitHub Actions via GitBox
