Re: [PR] zone wizard: allow only one untagged physical network with guest traffic type [cloudstack]

2024-02-07 Thread via GitHub


weizhouapache commented on PR #8625:
URL: https://github.com/apache/cloudstack/pull/8625#issuecomment-1933536938

   
   
   > > @vishesh92 can we add a new field in the wizard to specify the tag ? the 
API supports tags: 
https://cloudstack.apache.org/api/apidocs-4.19/apis/createPhysicalNetwork.html
   > 
   > @weizhouapache I have already added this.
   
   ok @vishesh92 
   The screenshot above was actually taken from the UI with your changes (to 
4.19 and fix some conflicts).
   maybe it is better to create the PR to 4.18. otherwise you have to fix the 
conflicts and test again when merge forward to 4.19.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] UI doesn't allow creating Guest Traffic on more than one Physical Network when existing Guest Traffic is not tagged. [cloudstack]

2024-02-07 Thread via GitHub


vishesh92 commented on issue #8279:
URL: https://github.com/apache/cloudstack/issues/8279#issuecomment-1933534342

   @andrijapanicsb This is the new UI for adding physical networks.
   
![image](https://github.com/apache/cloudstack/assets/8760112/3b3bbca7-d8c3-4fef-b7fd-50eccf8dc883)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] UI doesn't allow creating Guest Traffic on more than one Physical Network when existing Guest Traffic is not tagged. [cloudstack]

2024-02-07 Thread via GitHub


andrijapanicsb commented on issue #8279:
URL: https://github.com/apache/cloudstack/issues/8279#issuecomment-1933530750

   @vishesh92  Can you specify tags DURING the creation of the GUEST traffic?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] zone wizard: allow only one untagged physical network with guest traffic type [cloudstack]

2024-02-07 Thread via GitHub


vishesh92 commented on PR #8625:
URL: https://github.com/apache/cloudstack/pull/8625#issuecomment-1933526855

   > > @vishesh92 can we add a new field in the wizard to specify the tag ? the 
API supports tags: 
https://cloudstack.apache.org/api/apidocs-4.19/apis/createPhysicalNetwork.html
   > 
   > @weizhouapache I have already added this.
   
   Let me add a snapshot for the same.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] zone wizard: allow only one untagged physical network with guest traffic type [cloudstack]

2024-02-07 Thread via GitHub


vishesh92 commented on PR #8625:
URL: https://github.com/apache/cloudstack/pull/8625#issuecomment-1933525868

   > @vishesh92 can we add a new field in the wizard to specify the tag ? the 
API supports tags: 
https://cloudstack.apache.org/api/apidocs-4.19/apis/createPhysicalNetwork.html
   
   @weizhouapache I have already added this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] zone wizard: allow only one untagged physical network with guest traffic type [cloudstack]

2024-02-07 Thread via GitHub


weizhouapache commented on PR #8625:
URL: https://github.com/apache/cloudstack/pull/8625#issuecomment-1933506696

   @vishesh92 
   can we add a new field in the wizard to specify the tag ? 
   the API supports tags: 
https://cloudstack.apache.org/api/apidocs-4.19/apis/createPhysicalNetwork.html
   
   for example
   
![image](https://github.com/apache/cloudstack/assets/57355700/03f8f882-f434-40f6-b4ae-a6027975222c)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Allow altering only either CPU or memory during VM live scale [cloudstack]

2024-02-07 Thread via GitHub


blueorangutan commented on PR #8234:
URL: https://github.com/apache/cloudstack/pull/8234#issuecomment-1933499283

   [SF] Trillian test result (tid-9123)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 56752 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8234-t9123-kvm-centos7.zip
   Smoke tests completed. 122 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] UI doesn't allow creating Guest Traffic on more than one Physical Network when existing Guest Traffic is not tagged. [cloudstack]

2024-02-07 Thread via GitHub


vishesh92 commented on issue #8279:
URL: https://github.com/apache/cloudstack/issues/8279#issuecomment-1933455034

   @andrijapanicsb I have fixed the first part in #8625. 
   
   I am not sure what exactly is the issue with the second part. I am able to 
add a new physical network. When I add guest traffic type it fails if there is 
already an existing untagged physical network. I can edit the physical network 
to add the tags to either of them to resolve the issue. Is the second part 
really an issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [WIP] System VMs/VRs upgrade to Python3 and Debian 12 [cloudstack]

2024-02-07 Thread via GitHub


blueorangutan commented on PR #8497:
URL: https://github.com/apache/cloudstack/pull/8497#issuecomment-1933448994

   [SF] Trillian test result (tid-9122)
   Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22
   Total time taken: 54305 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8497-t9122-kvm-ubuntu22.zip
   Smoke tests completed. 122 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add advance settings to fine tune DRS imbalance calculation [cloudstack]

2024-02-07 Thread via GitHub


blueorangutan commented on PR #8521:
URL: https://github.com/apache/cloudstack/pull/8521#issuecomment-1933442591

   UI build: :heavy_check_mark:
   Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8521 (QA-JID-274)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] zone wizard: allow only one untagged physical network with guest traffic type [cloudstack]

2024-02-07 Thread via GitHub


blueorangutan commented on PR #8625:
URL: https://github.com/apache/cloudstack/pull/8625#issuecomment-1933437774

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8582


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add advance settings to fine tune DRS imbalance calculation [cloudstack]

2024-02-07 Thread via GitHub


blueorangutan commented on PR #8521:
URL: https://github.com/apache/cloudstack/pull/8521#issuecomment-1933429818

   @kiranchavala a Jenkins job has been kicked to build UI QA env. I'll keep 
you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add advance settings to fine tune DRS imbalance calculation [cloudstack]

2024-02-07 Thread via GitHub


kiranchavala commented on PR #8521:
URL: https://github.com/apache/cloudstack/pull/8521#issuecomment-1933429212

   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NSX integration [cloudstack]

2024-02-07 Thread via GitHub


blueorangutan commented on PR #7919:
URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1933428091

   [SF] Trillian test result (tid-9121)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 56820 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7919-t9121-kvm-centos7.zip
   Smoke tests completed. 126 look OK, 3 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_list_system_vms_metrics_history | `Failure` | 0.22 | test_metrics_api.py
   test_list_vms_metrics_user | `Error` | 3645.06 | test_metrics_api.py
   test_01_verify_ipv6_vpc | `Error` | 572.80 | test_vpc_ipv6.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 524.59 | 
test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | `Failure` | 1951.52 | 
test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
`Failure` | 427.00 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 588.90 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 588.92 | test_vpc_redundant.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Whether nested virtualization possible with KVM hosts? [cloudstack]

2024-02-07 Thread via GitHub


weizhouapache commented on issue #8596:
URL: https://github.com/apache/cloudstack/issues/8596#issuecomment-1933427937

   In the case of ubuntu22, what's the error in cloudstack mgmt and agent when 
you start a VM on it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NSX integration [cloudstack]

2024-02-07 Thread via GitHub


blueorangutan commented on PR #7919:
URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1933402247

   [SF] Trillian test result (tid-9120)
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
   Total time taken: 54906 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7919-t9120-vmware-67u3.zip
   Smoke tests completed. 127 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_balanced_drs_algorithm | `Error` | 421.40 | test_cluster_drs.py
   test_deploy_more_vms_than_limit_allows | `Error` | 130.23 | 
test_deploy_vms_in_parallel.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] zone wizard: allow only one untagged physical network with guest traffic type [cloudstack]

2024-02-07 Thread via GitHub


blueorangutan commented on PR #8625:
URL: https://github.com/apache/cloudstack/pull/8625#issuecomment-1933389580

   @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] zone wizard: allow only one untagged physical network with guest traffic type [cloudstack]

2024-02-07 Thread via GitHub


vishesh92 commented on PR #8625:
URL: https://github.com/apache/cloudstack/pull/8625#issuecomment-1933388183

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Whether nested virtualization possible with KVM hosts? [cloudstack]

2024-02-07 Thread via GitHub


naseemvk commented on issue #8596:
URL: https://github.com/apache/cloudstack/issues/8596#issuecomment-1933361885

   Okay. after instaling Hyper-V in server 2019 VM, the VM fails to boot. 
   
   Also we tested in a Ubuntu VM by enabling KVM. When we run a VM(L2) in that 
the nested VM fails at booting


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Adding vmId as part of error response when vm create fails. [cloudstack]

2024-02-07 Thread via GitHub


blueorangutan commented on PR #8484:
URL: https://github.com/apache/cloudstack/pull/8484#issuecomment-1933219955

   [SF] Trillian test result (tid-9117)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 42855 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8484-t9117-kvm-centos7.zip
   Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [WIP] System VMs/VRs upgrade to Python3 and Debian 12 [cloudstack]

2024-02-07 Thread via GitHub


blueorangutan commented on PR #8497:
URL: https://github.com/apache/cloudstack/pull/8497#issuecomment-1933092565

   [SF] Trillian test result (tid-9113)
   Environment: vmware-80 (x2), Advanced Networking with Mgmt server u22
   Total time taken: 47815 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8497-t9113-vmware-80.zip
   Smoke tests completed. 121 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_balanced_drs_algorithm | `Error` | 425.34 | test_cluster_drs.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]

2024-02-07 Thread via GitHub


blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1933088681

   @weizhouapache a [SL] Trillian-Jenkins matrix job (centos7 mgmt + 
xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been 
kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]

2024-02-07 Thread via GitHub


weizhouapache commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1933074666

   > > > Seems that packaging got stuck on this one; running again:
   > > 
   > > 
   > > might have been just the github api @GutoVeronezi (but rebuilding works;)
   > 
   > BO seems a bit under the weather today. At first, I thought it could be a 
problem with the PR; however, I built the packages normally, the tests ran 
successfully, and other PR's packaging tasks are not being reported as well 
(vide [#8605 
(comment)](https://github.com/apache/cloudstack/pull/8605#issuecomment-1932545257)).
 Any clue if the problem is only with reporting the results?
   
   @GutoVeronezi 
   packages are ready 6 hours ago. it seems we have reached the github limits 
again.
   
   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]

2024-02-07 Thread via GitHub


GutoVeronezi commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1932967832

   > > Seems that packaging got stuck on this one; running again:
   > 
   > might have been just the github api @GutoVeronezi (but rebuilding works;)
   
   BO seems a bit under the weather today. At first, I thought it could be a 
problem with the PR; however, I built the packages normally, the tests ran 
successfully, and other PR's packaging tasks are not being reported as well 
(vide https://github.com/apache/cloudstack/pull/8605#issuecomment-1932545257). 
Any clue if the problem is only with reporting the results?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Cannot Start a Win11 Vm in cloudstack [cloudstack]

2024-02-07 Thread via GitHub


Tbaugus44 commented on issue #8469:
URL: https://github.com/apache/cloudstack/issues/8469#issuecomment-1932766256

   Hey guys, we are working wit a Architect over at shapeblue to resolve this 
issue. we will post the solution once its been resolved


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[I] Allow Host to be put in Maintenance Mode while Up and Disabled [cloudstack]

2024-02-07 Thread via GitHub


damonb123 opened a new issue, #8626:
URL: https://github.com/apache/cloudstack/issues/8626

   
   
   # ISSUE TYPE
   
* Improvement Request
   
   # COMPONENT NAME
   
   ~~~
   UI, API
   ~~~
   
   # CLOUDSTACK VERSION
   
   
   ~~~
   4.18.1.0
   ~~~
   
   
   # SUMMARY
   
   Ability to put host in maintenance mode when host is Up and Disabled.  
Disabling the host prevents new loads from being added when performing 
maintenance on groups of host.  This prevents loads from being repeatedly 
moved.  Requiring the host to be re-enabled prior to putting in maintenance 
mode opens a window for a VM to be scheduled for the host.  Simplifies and 
improves the maintenance process.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Bug: UI fails with 503 just after a successful install [cloudstack]

2024-02-07 Thread via GitHub


WowYouCanReallyDance commented on issue #8218:
URL: https://github.com/apache/cloudstack/issues/8218#issuecomment-1932585020

   > > I'v deployed many times. And the strange thing is : it's not runned 
broken all the time. Sometimes it worked well.
   > 
   > @WowYouCanReallyDance the root cause could be the database (connection 
issue, or misconfiguration). can you restart mgmt server and share the new logs 
?
   
   I don't know why, but it's working nice now. The same DB type and version 
mysql:5.7, everything not changed yet. If you need the logs, I will provide to 
timely.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Allow at most one guest network with null tag in Zone creation wizard [cloudstack]

2024-02-07 Thread via GitHub


codecov[bot] commented on PR #8625:
URL: https://github.com/apache/cloudstack/pull/8625#issuecomment-1932579340

   ## 
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8625?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 Report
   Attention: `8 lines` in your changes are missing coverage. Please review.
   > Comparison is base 
[(`69e8ebc`)](https://app.codecov.io/gh/apache/cloudstack/commit/69e8ebc03fc705be91c244ebd2d44fca2c5f5593?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 13.16% compared to head 
[(`fe98856`)](https://app.codecov.io/gh/apache/cloudstack/pull/8625?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 4.38%.
   
   | 
[Files](https://app.codecov.io/gh/apache/cloudstack/pull/8625?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | Patch % | Lines |
   |---|---|---|
   | 
[.../infra/zone/ZoneWizardPhysicalNetworkSetupStep.vue](https://app.codecov.io/gh/apache/cloudstack/pull/8625?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-dWkvc3JjL3ZpZXdzL2luZnJhL3pvbmUvWm9uZVdpemFyZFBoeXNpY2FsTmV0d29ya1NldHVwU3RlcC52dWU=)
 | 0.00% | [8 Missing :warning: 
](https://app.codecov.io/gh/apache/cloudstack/pull/8625?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 |
   
   Additional details and impacted files
   
   
   ```diff
   @@ Coverage Diff  @@
   ##   4.18   #8625   +/-   ##
   
   - Coverage 13.16%   4.38%-8.79% 
   
 Files  2724 361 -2363 
 Lines258101   28705   -229396 
 Branches  402285007-35221 
   
   - Hits  339771258-32719 
   + Misses   219819   27308   -192511 
   + Partials   4305 139 -4166 
   ```
   
   | 
[Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8625/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8625/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | `4.38% <0.00%> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8625?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Allow at most one guest network with null tag in Zone creation wizard [cloudstack]

2024-02-07 Thread via GitHub


vishesh92 opened a new pull request, #8625:
URL: https://github.com/apache/cloudstack/pull/8625

   ### Description
   
   This PR fixes https://github.com/apache/cloudstack/issues/8279
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] build/CI
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   
   
   
    How did you try to break this feature and the system with this change?
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Flexible command timeout [cloudstack]

2024-02-07 Thread via GitHub


blueorangutan commented on PR #8605:
URL: https://github.com/apache/cloudstack/pull/8605#issuecomment-1932547235

   @GutoVeronezi a [SL] Jenkins job has been kicked to build packages. It will 
be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Flexible command timeout [cloudstack]

2024-02-07 Thread via GitHub


GutoVeronezi commented on PR #8605:
URL: https://github.com/apache/cloudstack/pull/8605#issuecomment-1932545257

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-07 Thread via GitHub


weizhouapache commented on code in PR #8624:
URL: https://github.com/apache/cloudstack/pull/8624#discussion_r1481813890


##
server/src/main/java/com/cloud/api/ApiResponseHelper.java:
##
@@ -992,6 +992,9 @@ private void addSystemVmInfoToIpResponse(NicVO nic, 
IPAddressResponse ipResponse
 if (!isAdmin) {
 return;
 }
+if 
(Nic.ReservationStrategy.PlaceHolder.equals(nic.getReservationStrategy())) {

Review Comment:
   it is defined as below
   ```
   public enum ReservationStrategy {
   PlaceHolder, Create, Start, Managed;
   }
   ```



##
server/src/main/java/com/cloud/api/ApiResponseHelper.java:
##
@@ -992,6 +992,9 @@ private void addSystemVmInfoToIpResponse(NicVO nic, 
IPAddressResponse ipResponse
 if (!isAdmin) {
 return;
 }
+if 
(Nic.ReservationStrategy.PlaceHolder.equals(nic.getReservationStrategy())) {

Review Comment:
   it is defined as below
   ```
   public enum ReservationStrategy {
   PlaceHolder, Create, Start, Managed;
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-07 Thread via GitHub


weizhouapache commented on code in PR #8624:
URL: https://github.com/apache/cloudstack/pull/8624#discussion_r1481812367


##
server/src/main/java/com/cloud/api/ApiResponseHelper.java:
##
@@ -992,6 +992,9 @@ private void addSystemVmInfoToIpResponse(NicVO nic, 
IPAddressResponse ipResponse
 if (!isAdmin) {
 return;
 }
+if 
(Nic.ReservationStrategy.PlaceHolder.equals(nic.getReservationStrategy())) {

Review Comment:
   it is defined as
   ```
   public enum ReservationStrategy {
   PlaceHolder, Create, Start, Managed;
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-07 Thread via GitHub


DaanHoogland commented on code in PR #8624:
URL: https://github.com/apache/cloudstack/pull/8624#discussion_r1481806524


##
server/src/main/java/com/cloud/api/ApiResponseHelper.java:
##
@@ -992,6 +992,9 @@ private void addSystemVmInfoToIpResponse(NicVO nic, 
IPAddressResponse ipResponse
 if (!isAdmin) {
 return;
 }
+if 
(Nic.ReservationStrategy.PlaceHolder.equals(nic.getReservationStrategy())) {

Review Comment:
   in the condition here. I'll check them tomorrow.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-07 Thread via GitHub


weizhouapache commented on code in PR #8624:
URL: https://github.com/apache/cloudstack/pull/8624#discussion_r1481787518


##
server/src/main/java/com/cloud/api/ApiResponseHelper.java:
##
@@ -992,6 +992,9 @@ private void addSystemVmInfoToIpResponse(NicVO nic, 
IPAddressResponse ipResponse
 if (!isAdmin) {
 return;
 }
+if 
(Nic.ReservationStrategy.PlaceHolder.equals(nic.getReservationStrategy())) {

Review Comment:
   Did you mean this code snippet or some where else?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] vpc: create vpc tiers with dns server of vpc instead of zone [cloudstack]

2024-02-07 Thread via GitHub


weizhouapache commented on code in PR #8621:
URL: https://github.com/apache/cloudstack/pull/8621#discussion_r1481783127


##
server/src/main/java/com/cloud/network/NetworkModelImpl.java:
##
@@ -2723,6 +2733,12 @@ public Pair getNetworkIp6Dns(final 
Network network, final DataCe
 if (StringUtils.isNotBlank(network.getIp6Dns1())) {
 return new Pair<>(network.getIp6Dns1(), network.getIp6Dns2());
 }
+if (network.getVpcId() != null) {
+Vpc vpc = vpcDao.findById(network.getVpcId());
+if (vpc != null && StringUtils.isNotBlank(vpc.getIp6Dns1())) {
+return new Pair<>(vpc.getIp6Dns1(), vpc.getIp6Dns2());
+}
+}

Review Comment:
   @DaanHoogland 
   There is a small difference:
   `ip4` vs `ip6`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Delete and Edit button for Guest IP ranges not visible in UI [cloudstack]

2024-02-07 Thread via GitHub


ccycv commented on issue #8623:
URL: https://github.com/apache/cloudstack/issues/8623#issuecomment-1932439018

   > did you by any change test with head of 4.18 (i.e. 4.18.2.0-SNAPSHOT)?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add UI to view and download usage records [cloudstack]

2024-02-07 Thread via GitHub


vishesh92 commented on PR #8615:
URL: https://github.com/apache/cloudstack/pull/8615#issuecomment-1932436922

   > @vishesh92 it seems to me this menu item should be under "tools". what do 
you think?
   
   IMO, Tools should have something which contains tools which are used very 
infrequently and Usage is something someone might use on a regular basis.
   I don't have any strong opinions about this, but as of now tools have just 
**Comments** & **Import-Export Instances**. Let me know how should we proceed 
on this.
   
   
![image](https://github.com/apache/cloudstack/assets/8760112/2fc9b8ef-e2a4-476b-9149-b7a2103a315e)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Delete and Edit button for Guest IP ranges not visible in UI [cloudstack]

2024-02-07 Thread via GitHub


DaanHoogland commented on issue #8623:
URL: https://github.com/apache/cloudstack/issues/8623#issuecomment-1932433216

   did you by any change test with head of 4.18 (i.e. 4.18.2.0-SNAPSHOT)?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Delete and Edit button for Guest IP ranges not visible in UI [cloudstack]

2024-02-07 Thread via GitHub


DaanHoogland commented on issue #8623:
URL: https://github.com/apache/cloudstack/issues/8623#issuecomment-1932430431

   ah, thanks, regression :(


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-07 Thread via GitHub


DaanHoogland commented on code in PR #8624:
URL: https://github.com/apache/cloudstack/pull/8624#discussion_r1481764751


##
server/src/main/java/com/cloud/api/ApiResponseHelper.java:
##
@@ -992,6 +992,9 @@ private void addSystemVmInfoToIpResponse(NicVO nic, 
IPAddressResponse ipResponse
 if (!isAdmin) {
 return;
 }
+if 
(Nic.ReservationStrategy.PlaceHolder.equals(nic.getReservationStrategy())) {

Review Comment:
   @weizhouapache , these are 4 more potential NPEs, did you check those?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add UI to view and download usage records [cloudstack]

2024-02-07 Thread via GitHub


DaanHoogland commented on PR #8615:
URL: https://github.com/apache/cloudstack/pull/8615#issuecomment-1932415173

   @vishesh92 it seems to me this menu item should be under "tools". what do 
you think?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Delete and Edit button for Guest IP ranges not visible in UI [cloudstack]

2024-02-07 Thread via GitHub


ccycv commented on issue #8623:
URL: https://github.com/apache/cloudstack/issues/8623#issuecomment-1932410182

   @DaanHoogland  the edit and delete buttons are missing, please see the 
screenshots from 4.18.x
   
   
![image](https://github.com/apache/cloudstack/assets/23322009/a9ecfa1a-5078-4ca7-b440-62ebcddd67e2)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Delete and Edit button for Guest IP ranges not visible in UI [cloudstack]

2024-02-07 Thread via GitHub


DaanHoogland commented on issue #8623:
URL: https://github.com/apache/cloudstack/issues/8623#issuecomment-1932394741

   Are you meaning to get an UI interface to updateVlanIpRange? (not sure what 
API applies from your image)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] vpc: create vpc tiers with dns server of vpc instead of zone [cloudstack]

2024-02-07 Thread via GitHub


DaanHoogland commented on code in PR #8621:
URL: https://github.com/apache/cloudstack/pull/8621#discussion_r1481730971


##
server/src/main/java/com/cloud/network/NetworkModelImpl.java:
##
@@ -2723,6 +2733,12 @@ public Pair getNetworkIp6Dns(final 
Network network, final DataCe
 if (StringUtils.isNotBlank(network.getIp6Dns1())) {
 return new Pair<>(network.getIp6Dns1(), network.getIp6Dns2());
 }
+if (network.getVpcId() != null) {
+Vpc vpc = vpcDao.findById(network.getVpcId());
+if (vpc != null && StringUtils.isNotBlank(vpc.getIp6Dns1())) {
+return new Pair<>(vpc.getIp6Dns1(), vpc.getIp6Dns2());
+}
+}

Review Comment:
   this block is implemented twice. can you extract to a method?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] To support multiple ports for autoscaling [cloudstack]

2024-02-07 Thread via GitHub


DaanHoogland commented on issue #8619:
URL: https://github.com/apache/cloudstack/issues/8619#issuecomment-1932349182

   at first sight this looks like a valid feature request @palashbiswas-git , 
but can you elaborate on the configurations/requests/settings that you expect 
and how they would bahave, including error handling.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]

2024-02-07 Thread via GitHub


DaanHoogland commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1932344697

   > Seems that packaging got stuck on this one; running again:
   
   might have been just the github api @GutoVeronezi (but rebuilding works;)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]

2024-02-07 Thread via GitHub


blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1932336232

   @GutoVeronezi a [SL] Jenkins job has been kicked to build packages. It will 
be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]

2024-02-07 Thread via GitHub


GutoVeronezi commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1932334511

   Seem packaging got stuck on this one; running again:
   
   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] SG: fix SQL exception when add security group rule with allowed account/group [cloudstack]

2024-02-07 Thread via GitHub


DaanHoogland commented on code in PR #8616:
URL: https://github.com/apache/cloudstack/pull/8616#discussion_r1481681257


##
engine/schema/src/main/java/com/cloud/network/security/dao/SecurityGroupVMMapDaoImpl.java:
##
@@ -131,7 +131,7 @@ public List listBySecurityGroup(long 
securityGroupId, Stat
 SearchCriteria sc = 
ListBySecurityGroupAndStates.create();
 sc.setParameters("securityGroupId", securityGroupId);
 sc.setParameters("states", (Object[])vmStates);
-return listBy(sc, null, true);

Review Comment:
   ok, let's keep it out of scope here 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] After upgrade from 4.18.0 to 4.18.1 cloudstack-agent not starting [cloudstack]

2024-02-07 Thread via GitHub


DaanHoogland commented on issue #8604:
URL: https://github.com/apache/cloudstack/issues/8604#issuecomment-1932310604

   I would sugest editing the host-detail in the database for the hosts in the 
cluster to match the contents of the redhat-release file. In that way freshly 
installed hosts should be able to join the cluster without further manipulation 
in /etc.
   
   can you share the original contents of /etc/redhat-release and the value 
that you replaced it with?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Bug: UI fails with 503 just after a successful install [cloudstack]

2024-02-07 Thread via GitHub


weizhouapache commented on issue #8218:
URL: https://github.com/apache/cloudstack/issues/8218#issuecomment-1932296435

   > I'v deployed many times. And the strange thing is : it's not runned broken 
all the time. Sometimes it worked well.
   
   @WowYouCanReallyDance 
   the root cause could be the database (connection issue, or misconfiguration).
   can you restart mgmt server and share the new logs ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] After upgrade from 4.18.0 to 4.18.1 cloudstack-agent not starting [cloudstack]

2024-02-07 Thread via GitHub


DaanHoogland commented on issue #8604:
URL: https://github.com/apache/cloudstack/issues/8604#issuecomment-1932296141

   If I read this correctly the file /etc/redhat-release was editted. this is 
not the correct procedure. Instead the host details for the hosts in the 
cluster should be updated. I see this didn t make it into the release notes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]

2024-02-07 Thread via GitHub


blueorangutan commented on PR #7345:
URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1932272086

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8574


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Allow altering only either CPU or memory during VM live scale [cloudstack]

2024-02-07 Thread via GitHub


blueorangutan commented on PR #8234:
URL: https://github.com/apache/cloudstack/pull/8234#issuecomment-1932271152

   @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) 
has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Allow altering only either CPU or memory during VM live scale [cloudstack]

2024-02-07 Thread via GitHub


DaanHoogland commented on PR #8234:
URL: https://github.com/apache/cloudstack/pull/8234#issuecomment-1932266514

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(cloudstack-www) branch main updated (0c0ad3c88 -> 78b293126)

2024-02-07 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git


from 0c0ad3c88 Merge branch 'staging-site'
 add 9ffc74a08 Merge branch 'main' back into staging-site
 add 78b293126 multiple redirects from html to dir style (#148)

No new revisions were added by this update.

Summary of changes:
 docusaurus.config.js | 10 +-
 package.json |  1 +
 static/.htaccess |  1 -
 static/robots.txt|  2 ++
 yarn.lock| 15 +++
 5 files changed, 27 insertions(+), 2 deletions(-)
 delete mode 100644 static/.htaccess
 create mode 100644 static/robots.txt



(cloudstack-www) branch Readme-update created (now 60234bb19)

2024-02-07 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a change to branch Readme-update
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git


  at 60234bb19 Update README.md

This branch includes the following new commits:

 new 60234bb19 Update README.md

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.




(cloudstack-www) 01/01: Update README.md

2024-02-07 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch Readme-update
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git

commit 60234bb19b405e9d30c54c3a9da26583718beb3e
Author: dahn 
AuthorDate: Wed Feb 7 15:44:18 2024 +0100

Update README.md
---
 README.md | 23 ++-
 1 file changed, 6 insertions(+), 17 deletions(-)

diff --git a/README.md b/README.md
index ff50a9b55..35037008e 100644
--- a/README.md
+++ b/README.md
@@ -33,6 +33,12 @@ Most changes are reflected live without having to restart 
the server.
 
 ## Building and Publishing
 
+It can be useful at times to start anew:
+
+```
+$ yarn clear
+```
+
 To build the website run the following:
 
 ```
@@ -44,20 +50,3 @@ served using any static contents hosting service. We've 
GitHub Actions based
 automation that can publish changes merged to 'main' branch being automatically
 published to the 'asf-site'.
 
-### temporary blog only publishing mech
-
-This procedure is obsolete as soon as the site is migrated to docusaurus 
completely
-
-1. Build the docusaruas branch locally:
-```
-   # checkout the right branch:
-   git checkout old-style-blogs
-   yarn clear
-   yarn install
-   yarn build
-```
-2. Then move the `build` directory to some other place, like `mv build ..`
-3. `git checkout -- .` and then checkout `git checkout asf-site` branch
-4. `cd content/` to manually copy artifacts from `../build/` path.
-5. Generally I copy the `assets`, `blog`, `img` and `files` directory in the 
content directory from `../../build/`
-6. git add  and commit/push to asf-site branch



(cloudstack-www) branch staging-site updated: multiple redirects from html to dir style (#148)

2024-02-07 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch staging-site
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git


The following commit(s) were added to refs/heads/staging-site by this push:
 new 78b293126 multiple redirects from html to dir style (#148)
78b293126 is described below

commit 78b2931263293b7d916dd942775505ebddd95df3
Author: dahn 
AuthorDate: Wed Feb 7 15:33:14 2024 +0100

multiple redirects from html to dir style (#148)

* multiple redirects from html to dir style

* more generic redirect
---
 docusaurus.config.js | 10 +-
 package.json |  1 +
 static/.htaccess |  1 -
 yarn.lock| 15 +++
 4 files changed, 25 insertions(+), 2 deletions(-)

diff --git a/docusaurus.config.js b/docusaurus.config.js
index 3282a07e7..4795b5395 100644
--- a/docusaurus.config.js
+++ b/docusaurus.config.js
@@ -15,7 +15,15 @@ const config = {
   favicon: 'img/favicon.ico',
 
   plugins: [
-['docusaurus-plugin-sass', {}],
+[
+  'docusaurus-plugin-sass',
+  {},
+],[
+  '@docusaurus/plugin-client-redirects',
+  {
+fromExtensions: ['html', 'htm'], // /myPage.html -> /myPage
+  },
+],
   ],
 
   presets: [
diff --git a/package.json b/package.json
index e0f0e1e69..d05c6c837 100644
--- a/package.json
+++ b/package.json
@@ -16,6 +16,7 @@
   },
   "dependencies": {
 "@docusaurus/core": "^2.3.1",
+"@docusaurus/plugin-client-redirects": "2.3.1",
 "@docusaurus/preset-classic": "^2.3.1",
 "@easyops-cn/docusaurus-search-local": "^0.27.0",
 "@mdx-js/react": "^1.6.22",
diff --git a/static/.htaccess b/static/.htaccess
deleted file mode 100644
index 9f81e3520..0
--- a/static/.htaccess
+++ /dev/null
@@ -1 +0,0 @@
-Redirect 301 /downloads.html /downloads/
diff --git a/yarn.lock b/yarn.lock
index 90f5b2533..c61025961 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -1376,6 +1376,21 @@
 react-helmet-async "*"
 react-loadable "npm:@docusaurus/react-loadable@5.5.2"
 
+"@docusaurus/plugin-client-redirects@2.3.1":
+  version "2.3.1"
+  resolved 
"https://registry.yarnpkg.com/@docusaurus/plugin-client-redirects/-/plugin-client-redirects-2.3.1.tgz#e75f373ef19032b0d059c0298f86d6cb18575ef6;
+  integrity 
sha512-Ye0z36/L8685ni0DIxHqPPaHIXFXiSF90QYiYfpODBX6NxvvveUTyylsDBU1GQhPXPn1bd39QgaOuZ+j9gfaog==
+  dependencies:
+"@docusaurus/core" "2.3.1"
+"@docusaurus/logger" "2.3.1"
+"@docusaurus/utils" "2.3.1"
+"@docusaurus/utils-common" "2.3.1"
+"@docusaurus/utils-validation" "2.3.1"
+eta "^2.0.0"
+fs-extra "^10.1.0"
+lodash "^4.17.21"
+tslib "^2.4.0"
+
 "@docusaurus/plugin-content-blog@2.3.1":
   version "2.3.1"
   resolved 
"https://registry.npmjs.org/@docusaurus/plugin-content-blog/-/plugin-content-blog-2.3.1.tgz;



[GH] (cloudstack-www): Workflow run "Pages" is working again!

2024-02-07 Thread GitBox


The GitHub Actions job "Pages" on cloudstack-www.git has succeeded.
Run started by GitHub user DaanHoogland (triggered by DaanHoogland).

Head commit for run:
8c2ed77d67e7984bd3f5b57b4c304298f2cb6eda / Daan Hoogland 
more generic redirect

Report URL: https://github.com/apache/cloudstack-www/actions/runs/7816328130

With regards,
GitHub Actions via GitBox



Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]

2024-02-07 Thread via GitHub


blueorangutan commented on PR #7345:
URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1932148387

   @JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]

2024-02-07 Thread via GitHub


JoaoJandre commented on PR #7345:
URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1932145907

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NSX integration [cloudstack]

2024-02-07 Thread via GitHub


blueorangutan commented on PR #7919:
URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1932122557

   @nvazquez a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, 
rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run 
smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NSX integration [cloudstack]

2024-02-07 Thread via GitHub


nvazquez commented on PR #7919:
URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1932100313

   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-07 Thread via GitHub


codecov[bot] commented on PR #8624:
URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-1932093115

   ## 
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8624?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Comparison is base 
[(`0d36098`)](https://app.codecov.io/gh/apache/cloudstack/commit/0d36098c76833ad3f7510f72e54ece3f3d7f3ba2?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 30.75% compared to head 
[(`1a5f3e5`)](https://app.codecov.io/gh/apache/cloudstack/pull/8624?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 4.39%.
   
   
   Additional details and impacted files
   
   
   ```diff
   @@ Coverage Diff  @@
   ##   4.19   #8624   +/-   ##
   
   - Coverage 30.75%   4.39%   -26.36% 
   
 Files  5346 361 -4985 
 Lines375435   28627   -346808 
 Branches  546034993-49610 
   
   - Hits 1154601258   -114202 
   + Misses   244742   27230   -217512 
   + Partials  15233 139-15094 
   ```
   
   | 
[Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8624/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8624/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | `?` | |
   | 
[uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8624/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | `4.39% <ø> (ø)` | |
   | 
[unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8624/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8624?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Change IP address for NIC or add secondary - IPs not visible - 4.19 [cloudstack]

2024-02-07 Thread via GitHub


ccycv commented on issue #8622:
URL: https://github.com/apache/cloudstack/issues/8622#issuecomment-1932082138

   @weizhouapache 
   
   Looks like now I see the IPs when I list for change but for add secondary, 
same issue and i see this in logs :
   
   `GET  
nicId=41665ed7-bd8a-4e54-acc0-ac364e2f0d0e==edf57c38-a206-4870-b67d-d32ab7680f81=listNics=json
   2024-02-07 13:42:58,565 ERROR [c.c.a.ApiServer] 
(qtp249034932-20:ctx-4ac5f9b9 ctx-940c481b) (logid:e1869f4e) unhandled 
exception executing api command: [Ljava.lang.String;@14ae457a
   java.lang.NullPointerException
   at com.cloud.vm.NicVO.getInstanceId(NicVO.java:256)
   at 
com.cloud.api.ApiResponseHelper.addSystemVmInfoToIpResponse(ApiResponseHelper.java:995)
   at 
com.cloud.api.ApiResponseHelper.addVmDetailsInIpResponse(ApiResponseHelper.java:982)
   at 
com.cloud.api.ApiResponseHelper.createIPAddressResponse(ApiResponseHelper.java:1042)
   at 
org.apache.cloudstack.api.command.user.address.ListPublicIpAddressesCmd.execute(ListPublicIpAddressesCmd.java:196)
   at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:172)
   at com.cloud.api.ApiServer.queueCommand(ApiServer.java:782)
   at com.cloud.api.ApiServer.handleRequest(ApiServer.java:603)
   at 
com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:347)
   at com.cloud.api.ApiServlet$1.run(ApiServlet.java:154)
   at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:55)
   at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:102)
   at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:52)
   at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:151)
   at com.cloud.api.ApiServlet.doGet(ApiServlet.java:105)
   at javax.servlet.http.HttpServlet.service(HttpServlet.java:645)
   at javax.servlet.http.HttpServlet.service(HttpServlet.java:750)
   at 
org.eclipse.jetty.servlet.ServletHolder$NotAsync.service(ServletHolder.java:1450)
   at 
org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:799)
   at 
org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:554)
   at 
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
   at 
org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:600)
   at 
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
   at 
org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:235)
   at 
org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1624)
   at 
org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
   at 
org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1440)
   at 
org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188)
   at 
org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:505)
   at 
org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1594)
   at 
org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186)
   at 
org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1355)
   at 
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
   at 
org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:772)
   at 
org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:146)
   at 
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
   at org.eclipse.jetty.server.Server.handle(Server.java:516)
   at 
org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:487)
   at 
org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:732)
   at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:479)
   at 
org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:277)
   at 
org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
   at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105)
   at 
org.eclipse.jetty.io.ssl.SslConnection$DecryptedEndPoint.onFillable(SslConnection.java:555)
   at 
org.eclipse.jetty.io.ssl.SslConnection.onFillable(SslConnection.java:410)
   at 
org.eclipse.jetty.io.ssl.SslConnection$2.succeeded(SslConnection.java:164)
   at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105)
   at 
org.eclipse.jetty.io.ChannelEndPoint$1.run(ChannelEndPoint.java:104)
   at 

Re: [I] Veeam Compatibility issue [cloudstack]

2024-02-07 Thread via GitHub


omurozlu commented on issue #8461:
URL: https://github.com/apache/cloudstack/issues/8461#issuecomment-1932080712

   > > @omurozlu if you just need to test the compatibility for testing 
purpose, you may try the latest nightly package, 
https://download.cloudstack.org/testing/nightly/
   > > (should be available in the upcoming 2024-02-07 4.19/4.20 packages)
   > 
   > thanks @shwstppr !
   > 
   > @omurozlu as @shwstppr said, you can try the nightly build of 4.19/4.20. 
The packages of 2024-02-06 contain the bug fix.
   
   ty for answer @weizhouapache  and @shwstppr 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (cloudstack-www): Workflow run "Pages" failed!

2024-02-07 Thread GitBox


The GitHub Actions job "Pages" on cloudstack-www.git has failed.
Run started by GitHub user DaanHoogland (triggered by DaanHoogland).

Head commit for run:
3741ca1b084508688598976c6d08856151a300c3 / dahn 
Update docusaurus.config.js

Report URL: https://github.com/apache/cloudstack-www/actions/runs/7815733249

With regards,
GitHub Actions via GitBox



[PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-07 Thread via GitHub


weizhouapache opened a new pull request, #8624:
URL: https://github.com/apache/cloudstack/pull/8624

   ### Description
   
   This PR fixes #8622 
   
   error
   ```
   2024-02-07 10:59:11,110 ERROR [c.c.a.ApiServer] 
(qtp1146825051-20:ctx-74413901 ctx-b91ecc51) (logid:aa41ab63) unhandled 
exception executing api command: [Ljava.lang.String;@5a46b058
   java.lang.NullPointerException
   at com.cloud.vm.NicVO.getInstanceId(NicVO.java:256)
   at 
com.cloud.api.ApiResponseHelper.addSystemVmInfoToIpResponse(ApiResponseHelper.java:995)
   at 
com.cloud.api.ApiResponseHelper.showVmInfoForSharedNetworks(ApiResponseHelper.java:1175)
   at 
com.cloud.api.ApiResponseHelper.createIPAddressResponse(ApiResponseHelper.java:1088)
   at 
org.apache.cloudstack.api.command.user.address.ListPublicIpAddressesCmd.execute(ListPublicIpAddressesCmd.java:196)
   ```
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] build/CI
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   
   
   
    How did you try to break this feature and the system with this change?
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (cloudstack-www): Workflow run "Pages" failed!

2024-02-07 Thread GitBox


The GitHub Actions job "Pages" on cloudstack-www.git has failed.
Run started by GitHub user DaanHoogland (triggered by DaanHoogland).

Head commit for run:
4ec5d3a1406f5d2b3ee808eecee66bf426456305 / Daan Hoogland 
multiple redirects from html to dir style

Report URL: https://github.com/apache/cloudstack-www/actions/runs/7815540753

With regards,
GitHub Actions via GitBox



(cloudstack-www) 01/01: Merge branch 'main' back into staging-site

2024-02-07 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch staging-site
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git

commit 9ffc74a08efec991d549fe87a4bdeeaff22dac8f
Merge: 7edb5adc2 0c0ad3c88
Author: Daan Hoogland 
AuthorDate: Wed Feb 7 14:20:21 2024 +0100

Merge branch 'main' back into staging-site




(cloudstack-www) branch staging-site updated (7edb5adc2 -> 9ffc74a08)

2024-02-07 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a change to branch staging-site
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git


from 7edb5adc2 redirects (#147)
 add 1ae85b9a5 Merge branch 'staging-site'
 add c3cfc271b staging
 add a7462bcd9 output dir for staging
 add 4844e2c10 Merge branch 'staging-site'
 add ee4d3a46f publish on merge to staging (#143)
 add 0c0ad3c88 Merge branch 'staging-site'
 new 9ffc74a08 Merge branch 'main' back into staging-site

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:



(cloudstack-www) branch asf-site updated: Automated CloudStack website deployment completed on branch @ 0c0ad3c880ceee53b1a8d87b25df0308536aef9a

2024-02-07 Thread github-bot
This is an automated email from the ASF dual-hosted git repository.

github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git


The following commit(s) were added to refs/heads/asf-site by this push:
 new 76f6ad5b1 Automated CloudStack website deployment completed on branch 
@ 0c0ad3c880ceee53b1a8d87b25df0308536aef9a
76f6ad5b1 is described below

commit 76f6ad5b100e506bb19bad3add04004d9f60dc82
Author: github-actions[bot] 
AuthorDate: Wed Feb 7 13:08:38 2024 +

Automated CloudStack website deployment completed on branch @ 
0c0ad3c880ceee53b1a8d87b25df0308536aef9a
---
 .asf.yaml | 2 +-
 .htaccess | 1 +
 search-index.json | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/.asf.yaml b/.asf.yaml
index fcd1cd3c2..e61159a99 100644
--- a/.asf.yaml
+++ b/.asf.yaml
@@ -45,7 +45,7 @@ notifications:
 # Staging and publishing profile for cloudstack-www.git:
 staging:
   profile: ~
-  whoami: staging-site
+  whoami: staged-site
   outputdir: content
 
 publish:
diff --git a/.htaccess b/.htaccess
new file mode 100644
index 0..9f81e3520
--- /dev/null
+++ b/.htaccess
@@ -0,0 +1 @@
+Redirect 301 /downloads.html /downloads/
diff --git a/search-index.json b/search-index.json
index 91beedb8b..8f465efbd 100644
--- a/search-index.json
+++ b/search-index.json
@@ -1 +1 @@
-[{"documents":[{"i":1,"t":"About Apache 
CloudStack","u":"/about","b":[]},{"i":2,"t":"Apache CloudStack API 
Documentation","u":"/api","b":[]},{"i":4,"t":"4.1.0 VOTE in Progress: Testers 
Welcome!","u":"/blog/4_1_0_vote_in","b":[]},{"i":6,"t":"Archived 
Releases","u":"/archives","b":[]},{"i":8,"t":"[ANNOUNCE] Announcing Apache 
CloudStack 
4.3.2","u":"/blog/announce_announcing_apache_cloudstack_4","b":[]},{"i":10,"t":"[ADVISORY]
 Apache CloudStack Advisory on KVM Shared Mount Point issues on ve [...]
\ No newline at end of file
+[{"documents":[{"i":1,"t":"About Apache 
CloudStack","u":"/about","b":[]},{"i":2,"t":"Apache CloudStack API 
Documentation","u":"/api","b":[]},{"i":4,"t":"Archived 
Releases","u":"/archives","b":[]},{"i":6,"t":"4.1.0 VOTE in Progress: Testers 
Welcome!","u":"/blog/4_1_0_vote_in","b":[]},{"i":8,"t":"[ADVISORY] Apache 
CloudStack Advisory on KVM Shared Mount Point issues on version 
4.17.0.0","u":"/blog/advisory-apache-cloudstack-advisory-on","b":[]},{"i":10,"t":"Announcing
 Apache™ CloudMonkey™  [...]
\ No newline at end of file



(cloudstack-www) branch staged-site created (now e9408f27c)

2024-02-07 Thread github-bot
This is an automated email from the ASF dual-hosted git repository.

github-bot pushed a change to branch staged-site
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git


  at e9408f27c Automated CloudStack https://cloudstack.staged.apache.org 
staging website deployment with cloudstack-www branch @ 
0c0ad3c880ceee53b1a8d87b25df0308536aef9a

This branch includes the following new commits:

 new e9408f27c Automated CloudStack https://cloudstack.staged.apache.org 
staging website deployment with cloudstack-www branch @ 
0c0ad3c880ceee53b1a8d87b25df0308536aef9a

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.




(cloudstack-www) 01/01: Merge branch 'staging-site'

2024-02-07 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git

commit 0c0ad3c880ceee53b1a8d87b25df0308536aef9a
Merge: ee4d3a46f 7edb5adc2
Author: Daan Hoogland 
AuthorDate: Wed Feb 7 14:06:19 2024 +0100

Merge branch 'staging-site'

 .asf.yaml| 2 +-
 .github/workflows/deploy.yml | 2 +-
 static/.htaccess | 1 +
 3 files changed, 3 insertions(+), 2 deletions(-)



Re: [PR] Adding vmId as part of error response when vm create fails. [cloudstack]

2024-02-07 Thread via GitHub


blueorangutan commented on PR #8484:
URL: https://github.com/apache/cloudstack/pull/8484#issuecomment-1932011651

   @weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) 
has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(cloudstack-www) branch main updated (ee4d3a46f -> 0c0ad3c88)

2024-02-07 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git


from ee4d3a46f publish on merge to staging (#143)
 add 826c4e357 publish on merge to staging
 add e2655f35b comma in date (#144)
 add 6c0e6d5e3 staging -> staged
 add 7edb5adc2 redirects (#147)
 new 0c0ad3c88 Merge branch 'staging-site'

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .asf.yaml| 2 +-
 .github/workflows/deploy.yml | 2 +-
 static/.htaccess | 1 +
 3 files changed, 3 insertions(+), 2 deletions(-)
 create mode 100644 static/.htaccess



(cloudstack-www) branch staging-site updated: redirects (#147)

2024-02-07 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch staging-site
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git


The following commit(s) were added to refs/heads/staging-site by this push:
 new 7edb5adc2 redirects (#147)
7edb5adc2 is described below

commit 7edb5adc2276c0f95054e99be253e15d5533acb6
Author: dahn 
AuthorDate: Wed Feb 7 14:03:15 2024 +0100

redirects (#147)
---
 static/.htaccess | 1 +
 1 file changed, 1 insertion(+)

diff --git a/static/.htaccess b/static/.htaccess
new file mode 100644
index 0..9f81e3520
--- /dev/null
+++ b/static/.htaccess
@@ -0,0 +1 @@
+Redirect 301 /downloads.html /downloads/



Re: [I] Change IP address for NIC or add secondary - IPs not visible - 4.19 [cloudstack]

2024-02-07 Thread via GitHub


weizhouapache commented on issue #8622:
URL: https://github.com/apache/cloudstack/issues/8622#issuecomment-1932002152

   @ccycv 
   can you check the management-server.log if there are similar erros like 
below ?
   ```
   2024-02-07 10:59:11,110 ERROR [c.c.a.ApiServer] 
(qtp1146825051-20:ctx-74413901 ctx-b91ecc51) (logid:aa41ab63) unhandled 
exception executing api command: [Ljava.lang.String;@5a46b058
   java.lang.NullPointerException
   at com.cloud.vm.NicVO.getInstanceId(NicVO.java:256)
   at 
com.cloud.api.ApiResponseHelper.addSystemVmInfoToIpResponse(ApiResponseHelper.java:995)
   at 
com.cloud.api.ApiResponseHelper.showVmInfoForSharedNetworks(ApiResponseHelper.java:1175)
   at 
com.cloud.api.ApiResponseHelper.createIPAddressResponse(ApiResponseHelper.java:1088)
   at 
org.apache.cloudstack.api.command.user.address.ListPublicIpAddressesCmd.execute(ListPublicIpAddressesCmd.java:196)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Change IP address for NIC or add secondary - IPs not visible - 4.19 [cloudstack]

2024-02-07 Thread via GitHub


weizhouapache commented on issue #8622:
URL: https://github.com/apache/cloudstack/issues/8622#issuecomment-1931996524

   @ccycv 
   I have reopened this as I think this is a valid bug


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Adding vmId as part of error response when vm create fails. [cloudstack]

2024-02-07 Thread via GitHub


weizhouapache commented on PR #8484:
URL: https://github.com/apache/cloudstack/pull/8484#issuecomment-1931989976

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Linstor: add HA support and small cleanups [cloudstack]

2024-02-07 Thread via GitHub


rp- commented on PR #8407:
URL: https://github.com/apache/cloudstack/pull/8407#issuecomment-1931966179

   I made a small change, to don't specify the full path to `hostname` to 
remedy concerns from this issue: 
https://github.com/apache/cloudstack/issues/8310


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [WIP] System VMs/VRs upgrade to Python3 and Debian 12 [cloudstack]

2024-02-07 Thread via GitHub


blueorangutan commented on PR #8497:
URL: https://github.com/apache/cloudstack/pull/8497#issuecomment-1931959481

   [SF] Trillian Build Failed (tid-9114)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Adding vmId as part of error response when vm create fails. [cloudstack]

2024-02-07 Thread via GitHub


blueorangutan commented on PR #8484:
URL: https://github.com/apache/cloudstack/pull/8484#issuecomment-1931950442

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8570


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] KVM volume snapshots are not full snapshots anymore [cloudstack]

2024-02-07 Thread via GitHub


GutoVeronezi commented on issue #8034:
URL: https://github.com/apache/cloudstack/issues/8034#issuecomment-1931935624

   > @GutoVeronezi , I saw this mitigation procedures from the release note, 
when we have hundreds VM affected by this linked snapshot issue, I'd like to 
ask rather than converting them, shall we just left it as it and just told the 
user do not delete any affected template instead. Any potential issue if we 
just keep it as is and proceed the 4.19 upgrade?
   
   Hello @levindecaro 
   
   If you will keep the snapshots as they are (so they get replaced over time), 
you have to bear in mind 2 points:
   - not delete the template (as you already proposed);
   - and, when reverting a snapshot, the host where the VM is running must have 
access to the primary storage referenced in the snapshots's backing 
store[^cluster-wide]. This is also valid for deploying VMs from templates 
created from snapshots [^cluster-wide].
   
   With that, your snapshots should work fine until they get replaced with new 
and consistent snapshots (on 4.19). 
   
   If you have any other doubt, just ping me.
   
   [^cluster-wide]: for instance, if you have a snapshot of a volume in a 
cluster primary storage, create a template from it, and try to deploy it in 
another cluster, you will face errors.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add UI to view and download usage records [cloudstack]

2024-02-07 Thread via GitHub


blueorangutan commented on PR #8615:
URL: https://github.com/apache/cloudstack/pull/8615#issuecomment-1931920152

   [SF] Trillian test result (tid-9106)
   Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
   Total time taken: 52074 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8615-t9106-kvm-alma9.zip
   Smoke tests completed. 121 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_list_system_vms_metrics_history | `Failure` | 0.21 | test_metrics_api.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]

2024-02-07 Thread via GitHub


blueorangutan commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1931909438

   @JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Normalize loggers and upgrade log4j 1.2 to log4j 2.19 [cloudstack]

2024-02-07 Thread via GitHub


JoaoJandre commented on PR #7131:
URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1931887128

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NSX integration [cloudstack]

2024-02-07 Thread via GitHub


blueorangutan commented on PR #7919:
URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1931878984

   @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NSX integration [cloudstack]

2024-02-07 Thread via GitHub


nvazquez commented on PR #7919:
URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1931875940

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(cloudstack) branch nsx-integration updated (bdd6f5540ff -> c1ae5ea2acd)

2024-02-07 Thread nvazquez
This is an automated email from the ASF dual-hosted git repository.

nvazquez pushed a change to branch nsx-integration
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


from bdd6f5540ff Fix
 add c1ae5ea2acd Fix unit test

No new revisions were added by this update.

Summary of changes:
 .../test/java/org/apache/cloudstack/utils/NsxControllerUtilsTest.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



Re: [I] Cloudstack should not allow to create resources with same name [cloudstack]

2024-02-07 Thread via GitHub


kiranchavala closed issue #8416: Cloudstack should not allow to create 
resources with same name
URL: https://github.com/apache/cloudstack/issues/8416


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Cloudstack should not allow to create resources with same name [cloudstack]

2024-02-07 Thread via GitHub


kiranchavala commented on issue #8416:
URL: https://github.com/apache/cloudstack/issues/8416#issuecomment-1931869210

   @DaanHoogland  thanks for looking into it, I agree it could cause backward 
compatability issue .
   
   we can close the issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Bug: UI fails with 503 just after a successful install [cloudstack]

2024-02-07 Thread via GitHub


WowYouCanReallyDance commented on issue #8218:
URL: https://github.com/apache/cloudstack/issues/8218#issuecomment-1931858135

   I'v deployed many times. And the strange thing is : it's not runned broken 
all the times. Sometimes it worked well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[I] Delete and Edit button for Guest IP ranges not visible in UI [cloudstack]

2024-02-07 Thread via GitHub


ccycv opened a new issue, #8623:
URL: https://github.com/apache/cloudstack/issues/8623

   
   
   # ISSUE TYPE
   
* Bug Report
   
   
   # COMPONENT NAME
   
   ~~~
   UI
   ~~~
   
   # CLOUDSTACK VERSION
   
   
   ~~~
   4.19
   ~~~
   
   # CONFIGURATION
   
   ~~~
   Advanced Networking 
   ~~~
   
   # OS / ENVIRONMENT
   
   ~~~
   CentOS 7
   ~~~
   
   # SUMMARY
   
   
   
   # STEPS TO REPRODUCE
   
   
   
   ~~~
   Check the Guest IP range for any network, type shared.
   
![image](https://github.com/apache/cloudstack/assets/23322009/a8232024-54fd-4b6f-9478-0280fceedf56)
   
   ~~~
   
   
   
   # EXPECTED RESULTS
   
   
   ~~~
   The option to edit/delete
   ~~~
   
   # ACTUAL RESULTS
   
   
   
   ~~~
   Not visible 
   ~~~
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Change IP address for NIC or add secondary - IPs not visible - 4.19 [cloudstack]

2024-02-07 Thread via GitHub


ccycv commented on issue #8622:
URL: https://github.com/apache/cloudstack/issues/8622#issuecomment-1931854049

   @weizhouapache 
   
   Yes, I closed because after I did a check via API, the IPs where listed in 
UI also..


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Adding vmId as part of error response when vm create fails. [cloudstack]

2024-02-07 Thread via GitHub


blueorangutan commented on PR #8484:
URL: https://github.com/apache/cloudstack/pull/8484#issuecomment-1931844775

   @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It 
will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep 
you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Adding vmId as part of error response when vm create fails. [cloudstack]

2024-02-07 Thread via GitHub


rohityadavcloud commented on PR #8484:
URL: https://github.com/apache/cloudstack/pull/8484#issuecomment-1931841823

   Thanks @weizhouapache I've addressed some of the cosmetics changes, cc 
@anniejili 
   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Adding vmId as part of error response when vm create fails. [cloudstack]

2024-02-07 Thread via GitHub


rohityadavcloud commented on code in PR #8484:
URL: https://github.com/apache/cloudstack/pull/8484#discussion_r1481326629


##
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##
@@ -4560,22 +4600,20 @@ private UserVmVO commitUserVm(final boolean isImport, 
final DataCenter zone, fin
 if (s_logger.isDebugEnabled()) {
 s_logger.debug("Successfully allocated DB entry for " + vm);
 }
-}
-CallContext.current().setEventDetails("Vm Id: " + vm.getUuid());
+} catch (CloudRuntimeException cre) {
+ArrayList epoList = cre.getIdProxyList();
+if (epoList == null || !epoList.stream().anyMatch(e -> 
e.getUuid().equals(vm.getUuid( {
+cre.addProxyObject(vm.getUuid(), "vmId");

Review Comment:
   ```suggestion
   cre.addProxyObject(vm.getUuid(), 
ApiConstants.VIRTUAL_MACHINE_ID);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



  1   2   >