Re: [PR] Change iops on offering change [cloudstack]
blueorangutan commented on PR #8872: URL: https://github.com/apache/cloudstack/pull/8872#issuecomment-2044160211 [SF] Trillian test result (tid-9757) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 50633 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8872-t9757-kvm-centos7.zip Smoke tests completed. 124 look OK, 5 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_list_system_vms_metrics_history | `Failure` | 0.21 | test_metrics_api.py test_list_vms_metrics_user | `Error` | 3643.43 | test_metrics_api.py test_create_pvlan_network | `Error` | 0.06 | test_pvlan.py test_04_deploy_vnf_appliance | `Error` | 102.49 | test_vnf_templates.py test_04_deploy_vnf_appliance | `Error` | 102.49 | test_vnf_templates.py test_05_delete_vnf_template | `Error` | 0.05 | test_vnf_templates.py ContextSuite context=TestVnfTemplates>:teardown | `Error` | 1.15 | test_vnf_templates.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 337.39 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | `Error` | 325.35 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 252.03 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | `Error` | 172.80 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Error` | 267.11 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Error` | 267.12 | test_vpc_redundant.py test_01_VPC_nics_after_destroy | `Error` | 165.13 | test_vpc_router_nics.py test_02_VPC_default_routes | `Error` | 170.37 | test_vpc_router_nics.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Ready for QA] New feature: Import DATA volume from storage pool [cloudstack]
blueorangutan commented on PR #8808: URL: https://github.com/apache/cloudstack/pull/8808#issuecomment-2044136034 [SF] Trillian test result (tid-9755) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 49961 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8808-t9755-kvm-rocky8.zip Smoke tests completed. 130 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2044120539 [SF] Trillian test result (tid-9759) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47374 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8800-t9759-kvm-centos7.zip Smoke tests completed. 127 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 292.22 | test_events_resource.py test_01_events_resource | `Error` | 292.23 | test_events_resource.py test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 89.92 | test_network_permissions.py ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.38 | test_network_permissions.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix assignVirtualMachine template checkAccess [cloudstack]
blueorangutan commented on PR #8886: URL: https://github.com/apache/cloudstack/pull/8886#issuecomment-2044112915 [SF] Trillian test result (tid-9752) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 57998 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8886-t9752-kvm-centos7.zip Smoke tests completed. 129 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feature: webhooks [cloudstack]
blueorangutan commented on PR #8674: URL: https://github.com/apache/cloudstack/pull/8674#issuecomment-2044109443 @shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feature: webhooks [cloudstack]
shwstppr commented on PR #8674: URL: https://github.com/apache/cloudstack/pull/8674#issuecomment-2044108920 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Updates to HPE-Primera and Pure FlashArray Drivers to use Host-based VLUN Assignments [cloudstack]
blueorangutan commented on PR #8889: URL: https://github.com/apache/cloudstack/pull/8889#issuecomment-2043961099 [SF] Trillian test result (tid-9753) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46660 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8889-t9753-kvm-centos7.zip Smoke tests completed. 129 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] libvirtstorage: Make sure netfs storage was really mounted [cloudstack]
blueorangutan commented on PR #8887: URL: https://github.com/apache/cloudstack/pull/8887#issuecomment-2043795414 [SF] Trillian test result (tid-9748) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 48556 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8887-t9748-kvm-centos7.zip Smoke tests completed. 126 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_nonsecured_to_secured_vm_migration | `Error` | 199.70 | test_vm_life_cycle.py test_01_verify_ipv6_vpc | `Error` | 576.15 | test_vpc_ipv6.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 564.73 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Failure` | 512.63 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Error` | 512.64 | test_vpc_redundant.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] explanatory error message on delete attempt of default system offering [cloudstack]
blueorangutan commented on PR #8883: URL: https://github.com/apache/cloudstack/pull/8883#issuecomment-2043742589 [SF] Trillian test result (tid-9747) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46102 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8883-t9747-kvm-centos7.zip Smoke tests completed. 110 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Normalize dates in Usage and Quota APIs [cloudstack]
blueorangutan commented on PR #8243: URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2043732856 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Virtual router is failed to start because firmware is EFI. [cloudstack]
hsato03 commented on issue #8734: URL: https://github.com/apache/cloudstack/issues/8734#issuecomment-2043699192 > > @rastopato @DaanHoogland > > I could reproduce this bug in my environment. This happens when the user's VM and the VR are stopped and the user starts its VM. In this process, the VR is created with the same boot parameters from the user's VM, which causes the VR to not start when the user VM has the UEFI boot type. On Monday I'll work on a PR to fix this situation. > > As a workaround, you can do a restart with cleanup of your network and, after the VR is up, you can start your VM. > > I tried this scenario @hsato03 , but still the VR starts as expected. not sure what other configuration is in play here. @DaanHoogland Maybe the network should be in `implemented` state. This bug just occurs in VMware by the way. I explained in more detail how to reproduce it in https://github.com/apache/cloudstack/pull/8894. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix VR inheriting _boot_ settings from user's VM [cloudstack]
hsato03 commented on PR #8894: URL: https://github.com/apache/cloudstack/pull/8894#issuecomment-2043690782 I will keep it in draft because I'm still testing it, but it's ready to be reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix VR inheriting _boot_ settings from user's VM [cloudstack]
hsato03 opened a new pull request, #8894:
URL: https://github.com/apache/cloudstack/pull/8894
### Description
In a situation where there is a stopped user VM and this VM's network VR is
also stopped, starting the user VM will also cause the VR to start. However, in
this situation, the VR is inheriting the user VM's boot settings, causing it to
not start when the user VM has the UEFI boot type.
Because of this, the inheritance of user VM boot settings has been removed
from VR and other boot settings have been defined in their place.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
I followed the same steps from `How did you try to break this feature and
the system with this change?` and verified that the user's VM and VR started
correctly.
How did you try to break this feature and the system with this change?
1. I created an isolated network (`isolated`);
2. I deployed a VM (`test`) using the `isolated` network and started it;
3. After implementing the `isolated` network, I stopped the VM `test` and
the VR of the `isolated` network;
4. I added the `UEFI=SECURE` setting to the `test` VM and started it again,
causing the `isolated` network VR to start as well;
5. The VR could not start because it had the UEFI boot type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Normalize dates in Usage and Quota APIs [cloudstack]
blueorangutan commented on PR #8243: URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2043636331 @winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Normalize dates in Usage and Quota APIs [cloudstack]
winterhazel commented on PR #8243: URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2043632913 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Normalize dates in Usage and Quota APIs [cloudstack]
winterhazel commented on code in PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#discussion_r1556424510
##
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaBalanceCmd.java:
##
@@ -43,10 +43,12 @@ public class QuotaBalanceCmd extends BaseCmd {
@Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.UUID,
required = true, entityType = DomainResponse.class, description = "If domain Id
is given and the caller is domain admin then the statement is generated for
domain.")
private Long domainId;
-@Parameter(name = ApiConstants.END_DATE, type = CommandType.DATE,
description = "End date range for quota query. Use -MM-dd as the date
format, e.g. startDate=2009-06-03.")
+@Parameter(name = ApiConstants.END_DATE, type = CommandType.DATE,
description = "End date range for quota query. " +
+ApiConstants.PARAMETER_DESCRIPTION_END_DATE_POSSIBLE_FORMATS)
private Date endDate;
-@Parameter(name = ApiConstants.START_DATE, type = CommandType.DATE,
description = "Start date range quota query. Use -MM-dd as the date format,
e.g. startDate=2009-06-01.")
+@Parameter(name = ApiConstants.START_DATE, type = CommandType.DATE,
description = "Start date range quota query. " +
Review Comment:
```suggestion
@Parameter(name = ApiConstants.START_DATE, type = CommandType.DATE,
description = "Start of the period of the Quota balance. " +
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] linstor: cleanup diskless nodes on disconnect [cloudstack]
JoaoJandre commented on PR #8790: URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2043562941 @DaanHoogland can we run the CI here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Normalize dates in Usage and Quota APIs [cloudstack]
GutoVeronezi commented on PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#issuecomment-2043303604
> > @winterhazel, you mentioned in the description that this PR also affects
quotaStatement and quotaBalance; however, I am not seeing changes in their
command classes. Could you check?
>
> The changes I mentioned were made in their workflow, not in their command
classes.
>
> Regarding `quotaStatement`, the following block has been removed from
`org.apache.cloudstack.quota.QuotaServiceImpl#getQuotaUsage` to allow providing
end dates in the future:
>
> ```diff
> -if (endDate.after(_respBldr.startOfNextDay())) {
> -throw new InvalidParameterValueException("Incorrect Date
Range. End date:" + endDate + " should not be in future. ");
> -}
> ```
>
> The same restriction has been removed for `quotaBalance` in
`org.apache.cloudstack.quota.QuotaServiceImpl#findQuotaBalanceVO`:
>
> ```diff
> -Date adjustedStartDate = computeAdjustedTime(startDate);
> -if (endDate.after(_respBldr.startOfNextDay())) {
> -throw new InvalidParameterValueException("Incorrect Date
Range. End date:" + endDate + " should not be in future. ");
> -} else if (startDate.before(endDate)) {
> -Date adjustedEndDate = computeAdjustedTime(endDate);
> +if (startDate.before(endDate)) {
> ```
>
> > Also, I checked the code and observed that both have an odd behavior:
they take the end date passed as parameters and calculate the next day to it,
to use it as the end date, instead of using what the caller passed, which means
it would not retrieve what the caller requested. It would be good to check this
behavior as well (Adjustment 2).
>
> We can check if this behavior makes sense and, if it does not, change how
these two APIs use the provided end date; but I think this change starts to get
out of the scope of this PR, and should be done in a separate one.
>
> > @winterhazel, you mentioned the API quotaTariffDelete in the PR's
description; however, I am not seeing changes in its command class. I also
checked the code and have not found a reason for this API being handled in this
PR. Was it a typo?
>
> As well as `quotaStatement` and `quotaBalance`, the mentioned change was
made in the workflow, not in the command class. In
`org.apache.cloudstack.api.response.QuotaResponseBuilderImpl#deleteQuotaTariff`,
I made it so that the actual removal date is persisted instead of a
manipulated one:
>
> ```diff
> -quotaTariff.setRemoved(_quotaService.computeAdjustedTime(new
Date()));
> +quotaTariff.setRemoved(new Date());
> ```
Thanks for the explanation, @winterhazel. It makes sense to handle/discuss
the `endDate` case in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Normalize dates in Usage and Quota APIs [cloudstack]
GutoVeronezi commented on code in PR #8243:
URL: https://github.com/apache/cloudstack/pull/8243#discussion_r1556182305
##
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaBalanceCmd.java:
##
@@ -43,10 +43,12 @@ public class QuotaBalanceCmd extends BaseCmd {
@Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.UUID,
required = true, entityType = DomainResponse.class, description = "If domain Id
is given and the caller is domain admin then the statement is generated for
domain.")
private Long domainId;
-@Parameter(name = ApiConstants.END_DATE, type = CommandType.DATE,
description = "End date range for quota query. Use -MM-dd as the date
format, e.g. startDate=2009-06-03.")
+@Parameter(name = ApiConstants.END_DATE, type = CommandType.DATE,
description = "End date range for quota query. " +
Review Comment:
```suggestion
@Parameter(name = ApiConstants.END_DATE, type = CommandType.DATE,
description = "End of the period of the Quota balance." +
```
##
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaStatementCmd.java:
##
@@ -45,10 +45,12 @@ public class QuotaStatementCmd extends BaseCmd {
@Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.UUID,
required = true, entityType = DomainResponse.class, description = "Optional, If
domain Id is given and the caller is domain admin then the statement is
generated for domain.")
private Long domainId;
-@Parameter(name = ApiConstants.END_DATE, type = CommandType.DATE, required
= true, description = "End date range for quota query. Use -MM-dd as the
date format, e.g. startDate=2009-06-03.")
+@Parameter(name = ApiConstants.END_DATE, type = CommandType.DATE, required
= true, description = "End date range for quota query. " +
+ApiConstants.PARAMETER_DESCRIPTION_END_DATE_POSSIBLE_FORMATS)
private Date endDate;
-@Parameter(name = ApiConstants.START_DATE, type = CommandType.DATE,
required = true, description = "Start date range quota query. Use -MM-dd as
the date format, e.g. startDate=2009-06-01.")
+@Parameter(name = ApiConstants.START_DATE, type = CommandType.DATE,
required = true, description = "Start date range quota query. " +
Review Comment:
```suggestion
@Parameter(name = ApiConstants.START_DATE, type = CommandType.DATE,
required = true, description = "Start of the period of the Quota statement. " +
```
##
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaBalanceCmd.java:
##
@@ -43,10 +43,12 @@ public class QuotaBalanceCmd extends BaseCmd {
@Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.UUID,
required = true, entityType = DomainResponse.class, description = "If domain Id
is given and the caller is domain admin then the statement is generated for
domain.")
private Long domainId;
-@Parameter(name = ApiConstants.END_DATE, type = CommandType.DATE,
description = "End date range for quota query. Use -MM-dd as the date
format, e.g. startDate=2009-06-03.")
+@Parameter(name = ApiConstants.END_DATE, type = CommandType.DATE,
description = "End date range for quota query. " +
+ApiConstants.PARAMETER_DESCRIPTION_END_DATE_POSSIBLE_FORMATS)
private Date endDate;
-@Parameter(name = ApiConstants.START_DATE, type = CommandType.DATE,
description = "Start date range quota query. Use -MM-dd as the date format,
e.g. startDate=2009-06-01.")
+@Parameter(name = ApiConstants.START_DATE, type = CommandType.DATE,
description = "Start date range quota query. " +
Review Comment:
```suggestion
@Parameter(name = ApiConstants.START_DATE, type = CommandType.DATE,
description = "Start of the period of the Quota Balance. " +
```
##
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaStatementCmd.java:
##
@@ -45,10 +45,12 @@ public class QuotaStatementCmd extends BaseCmd {
@Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.UUID,
required = true, entityType = DomainResponse.class, description = "Optional, If
domain Id is given and the caller is domain admin then the statement is
generated for domain.")
private Long domainId;
-@Parameter(name = ApiConstants.END_DATE, type = CommandType.DATE, required
= true, description = "End date range for quota query. Use -MM-dd as the
date format, e.g. startDate=2009-06-03.")
+@Parameter(name = ApiConstants.END_DATE, type = CommandType.DATE, required
= true, description = "End date range for quota query. " +
Review Comment:
```suggestion
@Parameter(name = ApiConstants.END_DATE, type = CommandType.DATE,
required = true, description = "End of the period of the Quota statement. " +
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
(cloudstack-www) branch staging-site updated: ccc 2024 blog post (#200)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch staging-site in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git The following commit(s) were added to refs/heads/staging-site by this push: new fc91074f ccc 2024 blog post (#200) fc91074f is described below commit fc91074f9d99e2423450f4f38672138e6ed217d3 Author: dahn AuthorDate: Mon Apr 8 18:06:43 2024 +0200 ccc 2024 blog post (#200) --- blog/2024-04-08-CCC2024-Madrid/index.md | 81 src/components/Events/index.tsx | 14 +- static/img/CCC-2024.png | Bin 0 -> 1016774 bytes 3 files changed, 94 insertions(+), 1 deletion(-) diff --git a/blog/2024-04-08-CCC2024-Madrid/index.md b/blog/2024-04-08-CCC2024-Madrid/index.md new file mode 100644 index ..800c3627 --- /dev/null +++ b/blog/2024-04-08-CCC2024-Madrid/index.md @@ -0,0 +1,81 @@ +--- +layout: post +title: CloudStack Collaboration Conference 2024 – Prepare to pack for Madrid, Spain in November +authors: [ivet] +tags: [news] +slug: ccc-2024 +--- + + + + +Get ready to mark your calendars and pack your bags because the +CloudStack Collaboration Conference 2024 is coming to Madrid, Spain! +From November 20th to 22nd, Orense 34 will be buzzing with excitement +as we gather for three days of immersive collaboration, insightful +discussions, and cutting-edge innovation. + + + + + +https://www.eventbrite.com/e/cloudstack-collaboration-conference-2024-tickets-879401903767; target="_blank">Register Now + + +## Exclusive In-Person Experience in 2024 + +This year's conference is breaking new ground by going exclusively +in-person. After careful consideration, collecting feedback from the +community and planning, this year we will offer to the community the +opportunity to meet face-to-face, fostering deeper connections and +more meaningful interactions than ever before. + +We did our best to deliver the CloudStack Community to everybody +interested during the pandemic time for a few years. Now, we are +focusing on growing the community and giving a chance to all +contributors, committers and people interested into the project, to +meet in-person and interact in a better way. + +## Hackathon Day - November 20th + +Kickstarting the event on November 20th is a hackathon. Developers, +engineers, and project committers will come together to unleash their +creativity, tackle real-world challenges, and push the boundaries of +what's possible within the CloudStack ecosystem. + +## Technical Sessions and Panels - November 21st and 22nd + +The excitement continues over the following two days with a jam-packed +schedule of technical sessions, thought-provoking talks, and engaging +panel discussions. Dive deep into the latest advancements, exchange +best practices, and explore emerging trends shaping the world of cloud +infrastructure and beyond. + +Button: Register Now - https://www.eventbrite.com/e/cloudstack-collaboration-conference-2024-tickets-879401903767 + +## Call for Sponsors + +As we prepare to make history in Madrid, we're extending a special +invitation to organizations interested in supporting and sponsoring +the CloudStack Collaboration Conference 2024. Showcase your commitment +to driving open-source technology forward, gain exposure to a diverse +audience of industry professionals, and position your brand as a +leader in the CloudStack community. Contact us today to explore +sponsorship opportunities and secure your place at this groundbreaking +event. + +CloudStack Collaboration Conference 2024 is not just a conference—it's +a celebration of open-source technology, collaboration, innovation, +and the boundless potential of the CloudStack ecosystem. Join us in +Madrid as we come together to share ideas, forge connections, and +shape the future of cloud technology. + + + +https://www.cloudstackcollab.org/wp-content/uploads/2024/04/Sponsorship-Prospectus-CCC24-web.pdf; target="_blank">Review the Sponsorship Opportunities + + +Don't forget to follow us on social media for the latest conference +updates and exclusive behind-the-scenes content! #CloudStackConf2024 diff --git a/src/components/Events/index.tsx b/src/components/Events/index.tsx index de6b7eb4..618db126 100644 --- a/src/components/Events/index.tsx +++ b/src/components/Events/index.tsx @@ -30,11 +30,23 @@ involved with the community. Sep 12, 2024 - Read More + Read More https://www.eventbrite.co.uk/e/cloudstack-european-user-group-germany-tickets-879369205967; target="_blank">Register Now + + + + CloudStack Collaboration Conference 2024 + Madrid, Spain + November 20-22, 2024 + + +
(cloudstack-documentation) 01/01: Merge release branch 4.19 to main
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git commit f5fc6e7a7245ef98ab03a697db86b30edceb4c55 Merge: b275541 7f8c887 Author: Daan Hoogland AuthorDate: Mon Apr 8 18:04:55 2024 +0200 Merge release branch 4.19 to main * 4.19: notes on POD-subnets (#391) Documentation for checkVolume API (#380) Document advance DRS settings (#374) veeam: update API commands and versions in doc (#357) Update virtual_machines.rst (#353) source/adminguide/backup_and_recovery.rst | 6 ++-- source/adminguide/clusters.rst| 24 source/adminguide/storage.rst | 48 +++ source/adminguide/veeam_plugin.rst| 25 +--- source/installguide/configuration.rst | 9 ++ source/quickinstallationguide/qig.rst | 3 ++ 6 files changed, 101 insertions(+), 14 deletions(-)
(cloudstack-documentation) branch 4.19 updated (5a47bef -> 7f8c887)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git from 5a47bef Documentation for checkVolume API (#380) add dd722eb Update virtual_machines.rst (#353) add 2cee719 notes on POD-subnets (#391) new 7f8c887 Merge branch '4.18' into 4.19 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: source/installguide/configuration.rst | 9 + source/quickinstallationguide/qig.rst | 3 +++ 2 files changed, 12 insertions(+)
(cloudstack-documentation) 01/01: Merge branch '4.18' into 4.19
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git commit 7f8c887c9046a4f491d6ce73b59d187be84edfae Merge: 5a47bef 2cee719 Author: Daan Hoogland AuthorDate: Mon Apr 8 18:04:23 2024 +0200 Merge branch '4.18' into 4.19 source/installguide/configuration.rst | 9 + source/quickinstallationguide/qig.rst | 3 +++ 2 files changed, 12 insertions(+)
(cloudstack-documentation) branch main updated (b275541 -> f5fc6e7)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git from b275541 feature: tagged resource limits (#379) add 6039ccf veeam: update API commands and versions in doc (#357) add c4272e3 Document advance DRS settings (#374) add 5a47bef Documentation for checkVolume API (#380) add dd722eb Update virtual_machines.rst (#353) add 2cee719 notes on POD-subnets (#391) add 7f8c887 Merge branch '4.18' into 4.19 new f5fc6e7 Merge release branch 4.19 to main The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: source/adminguide/backup_and_recovery.rst | 6 ++-- source/adminguide/clusters.rst| 24 source/adminguide/storage.rst | 48 +++ source/adminguide/veeam_plugin.rst| 25 +--- source/installguide/configuration.rst | 9 ++ source/quickinstallationguide/qig.rst | 3 ++ 6 files changed, 101 insertions(+), 14 deletions(-)
(cloudstack-documentation) branch 4.18 updated: notes on POD-subnets (#391)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git The following commit(s) were added to refs/heads/4.18 by this push: new 2cee719 notes on POD-subnets (#391) 2cee719 is described below commit 2cee719ff8bab70f42cea7d79d4c614a3b29bb10 Author: dahn AuthorDate: Mon Apr 8 18:00:48 2024 +0200 notes on POD-subnets (#391) --- source/installguide/configuration.rst | 9 + source/quickinstallationguide/qig.rst | 3 +++ 2 files changed, 12 insertions(+) diff --git a/source/installguide/configuration.rst b/source/installguide/configuration.rst index 049fe74..1ddc1e8 100644 --- a/source/installguide/configuration.rst +++ b/source/installguide/configuration.rst @@ -407,6 +407,9 @@ Basic Zone Configuration #. In a new zone, CloudStack adds the first pod for you. You can always add more pods later. For an overview of what a pod is, see :ref:`about-pods` +.. note:: + The network described below must be a subnet of the physical network marked as type "management". + To configure the first pod, enter the following, then click Next: - **Pod Name.** A name for the pod. @@ -602,6 +605,9 @@ Core Zone #. In a new zone, CloudStack adds the first pod for you. You can always add more pods later. For an overview of what a pod is, see :ref:`about-pods` +.. note:: + The network described below must be a subnet of the physical network marked as type "management". + To configure the first pod, enter the following, then click Next: - **Pod Name.** (Obligatory) A name for the pod. @@ -850,6 +856,9 @@ can add more pods at any time using the procedure in this section. Secondary Storage VMs, Console Proxy VMs, and DHCP. For more information, see System Reserved IP Addresses. +.. note:: + * The network described above must be a subnet of the management network. + #. Click OK. diff --git a/source/quickinstallationguide/qig.rst b/source/quickinstallationguide/qig.rst index 4183931..e2a85f9 100644 --- a/source/quickinstallationguide/qig.rst +++ b/source/quickinstallationguide/qig.rst @@ -730,6 +730,9 @@ will assign IPs from this range to system VMs. This will also be part of our loc #. End Reserved system IP - we will use ``172.16.10.30`` # (or e.g. 192.168.1.30) +.. note:: + * The network described above must be a subnet of the management network. + Click "Next" to continue. Guest Traffic
Re: [PR] Updates to HPE-Primera and Pure FlashArray Drivers to use Host-based VLUN Assignments [cloudstack]
rg9975 commented on PR #8889: URL: https://github.com/apache/cloudstack/pull/8889#issuecomment-2043087867 > @rg9975 the github actions show 1 succesfull check out of 22 probably not a structural issue with your code, but please have a look. A couple of lint issues I fixed, the rest of the failures appear to be an error with CodeCov plugin complaining about a 404 from a URL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack-www) 01/01: Merge branch 'staging-site'
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git commit e3ffda8b1f4b2aea9e2a145ce6ea0723cd297393 Merge: c3b94efe d0a97bbb Author: Daan Hoogland AuthorDate: Mon Apr 8 17:20:13 2024 +0200 Merge branch 'staging-site' blog/2024-04-08-CSEUG-Frankfurt/banner.jpg | Bin 0 -> 518500 bytes blog/2024-04-08-CSEUG-Frankfurt/index.md | 87 +++ blog/2024-04-08-CSEUG-Frankfurt/presentation.jpg | Bin 0 -> 120299 bytes blog/2024-04-08-CSEUG-Frankfurt/proio-logo.png | Bin 0 -> 6967 bytes src/components/Events/index.tsx | 24 --- static/img/CSEUG 2024.jpg| Bin 0 -> 518500 bytes 6 files changed, 100 insertions(+), 11 deletions(-)
(cloudstack-www) branch main updated (c3b94efe -> e3ffda8b)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from c3b94efe Merge remote-tracking branch 'origin/staging-site' add d0a97bbb CSEUG 2024 blog and events entry (#199) new e3ffda8b Merge branch 'staging-site' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: blog/2024-04-08-CSEUG-Frankfurt/banner.jpg | Bin 0 -> 518500 bytes blog/2024-04-08-CSEUG-Frankfurt/index.md | 87 +++ blog/2024-04-08-CSEUG-Frankfurt/presentation.jpg | Bin 0 -> 120299 bytes blog/2024-04-08-CSEUG-Frankfurt/proio-logo.png | Bin 0 -> 6967 bytes src/components/Events/index.tsx | 24 --- static/img/CSEUG 2024.jpg| Bin 0 -> 518500 bytes 6 files changed, 100 insertions(+), 11 deletions(-) create mode 100644 blog/2024-04-08-CSEUG-Frankfurt/banner.jpg create mode 100644 blog/2024-04-08-CSEUG-Frankfurt/index.md create mode 100644 blog/2024-04-08-CSEUG-Frankfurt/presentation.jpg create mode 100644 blog/2024-04-08-CSEUG-Frankfurt/proio-logo.png create mode 100644 static/img/CSEUG 2024.jpg
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
codecov-commenter commented on PR #8893: URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2042991370 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8893?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: Patch coverage is `50.0%` with `3 lines` in your changes are missing coverage. Please review. > Project coverage is 18.81%. Comparing base [(`2959cc6`)](https://app.codecov.io/gh/apache/cloudstack/commit/2959cc67652381e3a39b298e674a0bced5002337?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`9bd4f1e`)](https://app.codecov.io/gh/apache/cloudstack/pull/8893?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 3 commits behind head on main. | [Files](https://app.codecov.io/gh/apache/cloudstack/pull/8893?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [...ava/com/cloud/upgrade/dao/Upgrade41910to42000.java](https://app.codecov.io/gh/apache/cloudstack/pull/8893?src=pr=tree=engine%2Fschema%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fupgrade%2Fdao%2FUpgrade41910to42000.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9VcGdyYWRlNDE5MTB0bzQyMDAwLmphdmE=) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8893?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## main#8893 +/- ## = - Coverage 31.20% 18.81% -12.39% + Complexity3414617064-17082 = Files 5410 4879 -531 Lines380677 326963-53714 Branches 5557846200 -9378 = - Hits 11877361519-57254 - Misses 246169 256545+10376 + Partials 15735 8899 -6836 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8893/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8893/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `18.81% <50.00%> (-6.17%)` | :arrow_down: | | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8893/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | | [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8893/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8893?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] linstor: cleanup diskless nodes on disconnect [cloudstack]
blueorangutan commented on PR #8790: URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2042948485 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2042935753 @vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Change iops on offering change [cloudstack]
blueorangutan commented on PR #8872: URL: https://github.com/apache/cloudstack/pull/8872#issuecomment-2042935679 @vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Change iops on offering change [cloudstack]
vishesh92 commented on PR #8872: URL: https://github.com/apache/cloudstack/pull/8872#issuecomment-2042931857 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
vishesh92 commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2042928711 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Ready for QA] New feature: Import DATA volume from storage pool [cloudstack]
blueorangutan commented on PR #8808: URL: https://github.com/apache/cloudstack/pull/8808#issuecomment-2042865450 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Ready for QA] New feature: Import DATA volume from storage pool [cloudstack]
weizhouapache commented on PR #8808: URL: https://github.com/apache/cloudstack/pull/8808#issuecomment-2042861804 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] KVMHAMonitor getting initialized without host ha enabled [cloudstack]
GutoVeronezi commented on issue #8682: URL: https://github.com/apache/cloudstack/issues/8682#issuecomment-2042820902 > afaik, this has 0 things to do with host HA, VM HA or anything else. This scrip (kvmspheartbeat.sh) has been there for last 12 years (that I'm aware of) - and it only checks if NFS storage is accessible, and if not, reboots (forcefully) the host. > > They only way (to my knowledge) to disable host reboots is to comment out the lines that does some echo into sys/proc...etc - at the VERY end of the script (that echo triggers forcefull reboot) - just comment out that single "echo line and you are good. Storage migh be unaccessible (heartbeat fail) but nothing will happen (log messages will say "I'm rebooting" but script is not doing anything due to line commented out) @andrijapanicsb you can also disable this behavior with the agent property `reboot.host.and.alert.management.on.heartbeat.timeout`, as Wei stated in https://github.com/apache/cloudstack/issues/8682#issuecomment-2042289091. > > @weizhouapache I would suggest to take another look into that and change it default. In my opinion a host should not automatically reboot at all if no settings are configured. From what I know this looks to me like old behavior lost in the code. > > I agree with you. @sbrueseke > > cc @DaanHoogland @rohityadavcloud @andrijapanicsb @GutoVeronezi @wido your opinions ? PR #4586 introduced this property with default as `true` to keep the behavior; however, I also agree with @sbrueseke. With default as `true`, we are delegating to ACS the decision of rebooting the host, which might not be correct in several cases. I am inclined to make this property `false` by default and focus on alerting the operators about the situation, so they can take the right action over the environment. A redesign of the feature might be needed; however, we need discuss it first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] linstor: cleanup diskless nodes on disconnect [cloudstack]
blueorangutan commented on PR #8790: URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2042795851 @JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] linstor: cleanup diskless nodes on disconnect [cloudstack]
JoaoJandre commented on PR #8790: URL: https://github.com/apache/cloudstack/pull/8790#issuecomment-2042790802 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Change storage pool scope from Cluster to Zone and vise versa [cloudstack]
BryanMLima commented on code in PR #8875:
URL: https://github.com/apache/cloudstack/pull/8875#discussion_r1555813585
##
engine/schema/src/main/java/com/cloud/storage/dao/VolumeDaoImpl.java:
##
@@ -72,8 +79,14 @@ public class VolumeDaoImpl extends GenericDaoBase implements Vol
protected GenericSearchBuilder primaryStorageSearch2;
protected GenericSearchBuilder secondaryStorageSearch;
private final SearchBuilder poolAndPathSearch;
+protected SearchBuilder volumePoolNotInClusterSearch;
+
@Inject
ResourceTagDao _tagsDao;
+@Inject
+HostDao _hostDao;
+@Inject
+VMInstanceDao _vmDao;
Review Comment:
I would encourage to not use the old pattern of using `_` for private class
variables, as it is not part of the Java naming conventions. TBH, we should
probably update the CloudStack [coding
conventions](https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions)
to reflect this as well.
##
test/integration/smoke/test_primary_storage.py:
##
@@ -711,4 +854,4 @@ def test_03_migration_options_storage_tags(self):
self.debug("Suitable storage pools found: %s" % len(pools_suitable))
self.assertEqual(0, len(pools_suitable), "Check that there is no
migration option for volume")
-return
+return
Review Comment:
The pre-commit lint is failing because of the removed line at the EOF.
##
server/src/main/java/com/cloud/storage/StorageManagerImpl.java:
##
@@ -1148,6 +1151,95 @@ public PrimaryDataStoreInfo
updateStoragePool(UpdateStoragePoolCmd cmd) throws I
return (PrimaryDataStoreInfo)_dataStoreMgr.getDataStore(pool.getId(),
DataStoreRole.Primary);
}
+@Override
+public boolean changeStoragePoolScope(ChangeStoragePoolScopeCmd cmd)
throws IllegalArgumentException, InvalidParameterValueException,
PermissionDeniedException {
Review Comment:
Same here for this method, it only returns true or throws an exception.
##
server/src/main/java/com/cloud/storage/StorageManagerImpl.java:
##
@@ -1148,6 +1151,95 @@ public PrimaryDataStoreInfo
updateStoragePool(UpdateStoragePoolCmd cmd) throws I
return (PrimaryDataStoreInfo)_dataStoreMgr.getDataStore(pool.getId(),
DataStoreRole.Primary);
}
+@Override
+public boolean changeStoragePoolScope(ChangeStoragePoolScopeCmd cmd)
throws IllegalArgumentException, InvalidParameterValueException,
PermissionDeniedException {
+Long id = cmd.getId();
+
+Long accountId = cmd.getEntityOwnerId();
+if (!_accountMgr.isRootAdmin(accountId)) {
+throw new PermissionDeniedException("Only root admin can perform
this operation");
+}
+
+ScopeType newScope = EnumUtils.getEnumIgnoreCase(ScopeType.class,
cmd.getScope());
+if (newScope != ScopeType.ZONE && newScope != ScopeType.CLUSTER) {
+throw new InvalidParameterValueException("Invalid scope " +
newScope.toString() + "for Primary storage");
+}
+
+StoragePoolVO primaryStorage = _storagePoolDao.findById(id);
+if (primaryStorage == null) {
+throw new IllegalArgumentException("Unable to find storage pool
with ID: " + id);
+}
+
+if (!primaryStorage.getStatus().equals(StoragePoolStatus.Disabled)) {
+throw new InvalidParameterValueException("Scope of the Primary
storage with id "
++ primaryStorage.getUuid() +
+" cannot be changed, as it is not in the Disabled state");
+}
+
+ScopeType currentScope = primaryStorage.getScope();
+if (currentScope.equals(newScope)) {
+throw new InvalidParameterValueException("New scope must be
different than the current scope");
+}
+
+HypervisorType hypervisorType;
+if (currentScope.equals(ScopeType.CLUSTER)) {
+/*
+ * For cluster wide primary storage the hypervisor type might not
be set.
+ * So, get it from the clusterVO.
+ */
+Long clusterId = primaryStorage.getClusterId();
+ClusterVO clusterVO = _clusterDao.findById(clusterId);
+hypervisorType = clusterVO.getHypervisorType();
+} else {
+hypervisorType = primaryStorage.getHypervisor();
+}
+if (!zoneWidePoolSupportedHypervisorTypes.contains(hypervisorType)) {
+throw new InvalidParameterValueException("Primary storage scope
change is not supported for hypervisor type " + hypervisorType);
+}
+
+String providerName = primaryStorage.getStorageProviderName();
+DataStoreProvider storeProvider =
_dataStoreProviderMgr.getDataStoreProvider(providerName);
+PrimaryDataStoreLifeCycle lifeCycle = (PrimaryDataStoreLifeCycle)
storeProvider.getDataStoreLifeCycle();
+DataStore primaryStore = _dataStoreMgr.getPrimaryDataStore(id);
+
+Long zoneId =
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
blueorangutan commented on PR #8893: URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2042758241 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] KVMHAMonitor getting initialized without host ha enabled [cloudstack]
slavkap commented on issue #8682: URL: https://github.com/apache/cloudstack/issues/8682#issuecomment-2042747977 Hi all, KVMHAMonitor is initialized when the agent host is started (without knowing if HA is enabled/disabled). It is used either when Host HA is enabled to check the host. If there is a primary storage that supports Host HA (even if the HA is disabled) and some issue with the storage the script `kvmheartbeat.sh/kvmspheartbeat.sh` will be executed. Probably the fastest and easiest solution before a redesign we should set the agent property [reboot.host.and.alert.management.on.heartbeat.timeout](https://github.com/apache/cloudstack/blob/3fd5680d9a1a6591e9aa209abc44e3b40a3d9e54/agent/src/main/java/com/cloud/agent/properties/AgentProperties.java#L561) to be disabled by default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feature: webhooks [cloudstack]
blueorangutan commented on PR #8674: URL: https://github.com/apache/cloudstack/pull/8674#issuecomment-2042709487 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
DaanHoogland commented on PR #8893: URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2042700925 code looks good, but let's wait untill we are sure 4.19.1 is out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix spelling in code comments [cloudstack]
DaanHoogland commented on PR #8866: URL: https://github.com/apache/cloudstack/pull/8866#issuecomment-2042694216 @sureshanaparti , I don't think smoke tests are needed for these changes, do you agree? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Ready for QA] New feature: Import DATA volume from storage pool [cloudstack]
blueorangutan commented on PR #8808: URL: https://github.com/apache/cloudstack/pull/8808#issuecomment-2042669216 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix spelling in code comments [cloudstack]
blueorangutan commented on PR #8866: URL: https://github.com/apache/cloudstack/pull/8866#issuecomment-2042608763 [SF] Trillian Build Failed (tid-9754) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) 01/01: Merge remote-tracking branch 'apache/4.19'
This is an automated email from the ASF dual-hosted git repository.
weizhou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
commit 3fd5680d9a1a6591e9aa209abc44e3b40a3d9e54
Merge: 2959cc67652 c7626ebfd63
Author: Wei Zhou
AuthorDate: Mon Apr 8 14:16:33 2024 +0200
Merge remote-tracking branch 'apache/4.19'
.../router/VirtualNetworkApplianceManagerImpl.java | 49 +-
.../VpcVirtualNetworkApplianceManagerImpl.java | 26
2 files changed, 56 insertions(+), 19 deletions(-)
diff --cc
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
index a5c5c8a3e08,19d8fc72b29..b9f1350615b
---
a/server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
+++
b/server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
@@@ -2589,6 -2573,35 +2571,35 @@@ Configurable, StateListener lbs =
_loadBalancerDao.listByNetworkIdAndScheme(guestNetworkId, Scheme.Public);
+ final List lbRules = new
ArrayList();
+ if (_networkModel.isProviderSupportServiceInNetwork(guestNetworkId,
Service.Lb, provider)) {
+ // Re-apply load balancing rules
+ createLoadBalancingRulesList(lbRules, lbs);
+ }
+
-s_logger.debug("Found " + lbRules.size() + " load balancing rule(s)
to apply as a part of domR " + router + " start.");
++logger.debug("Found " + lbRules.size() + " load balancing rule(s) to
apply as a part of domR " + router + " start.");
+ if (!lbRules.isEmpty()) {
+
_commandSetupHelper.createApplyLoadBalancingRulesCommands(lbRules, router,
cmds, guestNetworkId);
+ }
+ }
+
+ protected void createLoadBalancingRulesList(List
lbRules, final List lbs) {
+ for (final LoadBalancerVO lb : lbs) {
+ final List dstList =
_lbMgr.getExistingDestinations(lb.getId());
+ final List policyList =
_lbMgr.getStickinessPolicies(lb.getId());
+ final List hcPolicyList =
_lbMgr.getHealthCheckPolicies(lb.getId());
+ final Ip sourceIp =
_networkModel.getPublicIpAddress(lb.getSourceIpAddressId()).getAddress();
+ final LbSslCert sslCert = _lbMgr.getLbSslCert(lb.getId());
+ final LoadBalancingRule loadBalancing = new LoadBalancingRule(lb,
dstList, policyList, hcPolicyList, sourceIp, sslCert, lb.getLbProtocol());
+ lbRules.add(loadBalancing);
+ }
+ }
+
private void createDefaultEgressFirewallRule(final List
rules, final long networkId) {
final NetworkVO network = _networkDao.findById(networkId);
final NetworkOfferingVO offering =
_networkOfferingDao.findById(network.getNetworkOfferingId());
diff --cc
server/src/main/java/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
index b22343081ff,1c1dc568b2c..f45386ca8a7
---
a/server/src/main/java/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
+++
b/server/src/main/java/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
@@@ -131,9 -134,7 +135,11 @@@ public class VpcVirtualNetworkAppliance
@Inject
protected HypervisorGuruManager _hvGuruMgr;
@Inject
+protected NetworkDao networkDao;
+@Inject
+protected VpcDao vpcDao;
++@Inject
+ private LoadBalancerDao loadBalancerDao;
@Override
public boolean configure(final String name, final Map
params) throws ConfigurationException {
@@@ -537,6 -536,24 +545,24 @@@
return true;
}
+ private void createApplyLoadBalancingRulesCommandsForVpc(final Commands
cmds, DomainRouterVO domainRouterVO, Provider provider,
+ List> guestNics) {
+ final List lbs =
loadBalancerDao.listByVpcIdAndScheme(domainRouterVO.getVpcId(), Scheme.Public);
+ final List lbRules = new ArrayList<>();
+ createLoadBalancingRulesList(lbRules, lbs);
-s_logger.debug("Found " + lbRules.size() + " load balancing rule(s)
to apply as a part of VPC VR " + domainRouterVO + " start.");
++logger.debug("Found " + lbRules.size() + " load balancing rule(s) to
apply as a part of VPC VR " + domainRouterVO + " start.");
+ if (!lbRules.isEmpty()) {
+ for (final Pair nicNtwk : guestNics) {
+ final Nic guestNic = nicNtwk.first();
+ final long guestNetworkId = guestNic.getNetworkId();
+ if
(_networkModel.isProviderSupportServiceInNetwork(guestNetworkId, Service.Lb,
provider)) {
+
_commandSetupHelper.createApplyLoadBalancingRulesCommands(lbRules,
domainRouterVO, cmds, guestNetworkId);
+ break;
+ }
+ }
+ }
+ }
+
@Override
protected List getDefaultServicesToMonitor(NetworkVO
network) {
if (network.getTrafficType() ==
(cloudstack) branch main updated (2959cc67652 -> 3fd5680d9a1)
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 2959cc67652 cleanup collaborators (#) add a5508acc54d server: fix haproxy misconfiguration after VPC VR start (#8881) add c7626ebfd63 Merge remote-tracking branch 'apache/4.18' into 4.19 new 3fd5680d9a1 Merge remote-tracking branch 'apache/4.19' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../router/VirtualNetworkApplianceManagerImpl.java | 49 +- .../VpcVirtualNetworkApplianceManagerImpl.java | 26 2 files changed, 56 insertions(+), 19 deletions(-)
(cloudstack) 01/01: Merge remote-tracking branch 'apache/4.18' into 4.19
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a commit to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit c7626ebfd6323b7bb656dbe5bf221a8c811769fd Merge: c25264bada3 a5508acc54d Author: Wei Zhou AuthorDate: Mon Apr 8 14:14:04 2024 +0200 Merge remote-tracking branch 'apache/4.18' into 4.19 .../router/VirtualNetworkApplianceManagerImpl.java | 49 +- .../VpcVirtualNetworkApplianceManagerImpl.java | 26 2 files changed, 56 insertions(+), 19 deletions(-)
Re: [PR] Temporarily backup StorPool volume before expunge [cloudstack]
sureshanaparti commented on code in PR #8843:
URL: https://github.com/apache/cloudstack/pull/8843#discussion_r1555718413
##
engine/schema/src/main/java/com/cloud/storage/dao/SnapshotDetailsDaoImpl.java:
##
@@ -18,11 +18,44 @@
*/
package com.cloud.storage.dao;
+import java.sql.PreparedStatement;
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.util.ArrayList;
+import java.util.List;
+
import org.apache.cloudstack.resourcedetail.ResourceDetailsDaoBase;
+import com.cloud.utils.db.TransactionLegacy;
+import com.cloud.utils.exception.CloudRuntimeException;
+
public class SnapshotDetailsDaoImpl extends
ResourceDetailsDaoBase implements SnapshotDetailsDao {
+private static final String GET_SNAPSHOT_DETAILS_ON_ZONE = "select s.*
from snapshot_details s left join snapshots ss on ss.id=s.snapshot_id where
ss.data_center_id=? and s.name=?";
Review Comment:
```suggestion
private static final String GET_SNAPSHOT_DETAILS_ON_ZONE = "SELECT s.*
FROM snapshot_details s LEFT JOIN snapshots ss ON ss.id = s.snapshot_id WHERE
ss.data_center_id = ? AND s.name = ?";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(cloudstack) branch 4.19 updated (c25264bada3 -> c7626ebfd63)
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a change to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git from c25264bada3 UI Fixes: allow filtering on alertype in UI & add events tab (#8630) add a5508acc54d server: fix haproxy misconfiguration after VPC VR start (#8881) new c7626ebfd63 Merge remote-tracking branch 'apache/4.18' into 4.19 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../router/VirtualNetworkApplianceManagerImpl.java | 49 +- .../VpcVirtualNetworkApplianceManagerImpl.java | 26 2 files changed, 56 insertions(+), 19 deletions(-)
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
blueorangutan commented on PR #8893: URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-204258 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Temporarily backup StorPool volume before expunge [cloudstack]
sureshanaparti commented on code in PR #8843:
URL: https://github.com/apache/cloudstack/pull/8843#discussion_r1555716862
##
plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/driver/StorPoolStatsCollector.java:
##
@@ -185,4 +205,90 @@ private void getClusterStats(JsonArray data, Map> map)
}
}
}
+
+class StorPoolSnapshotsWithDelayDelete implements Runnable {
+
+@Override
+public void run() {
+List spPools =
storagePoolDao.findPoolsByProvider(StorPoolUtil.SP_PROVIDER_NAME);
+if (CollectionUtils.isNotEmpty(spPools)) {
+Map onePoolforZone = new HashMap<>();
+for (StoragePoolVO storagePoolVO : spPools) {
+onePoolforZone.put(storagePoolVO.getDataCenterId(),
storagePoolVO);
+}
+for (StoragePoolVO storagePool : onePoolforZone.values()) {
+List snapshotsDetails =
snapshotDetailsDao.findDetailsByZoneAndKey(storagePool.getDataCenterId(),
"SP_DELAY_DELETE");
Review Comment:
```suggestion
List snapshotsDetails =
snapshotDetailsDao.findDetailsByZoneAndKey(storagePool.getDataCenterId(),
StorPoolUtil.SP_DELAY_DELETE);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
weizhouapache commented on PR #8893: URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2042586598 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]
weizhouapache opened a new pull request, #8893:
URL: https://github.com/apache/cloudstack/pull/8893
### Description
This PR move upgrade files for 4.19.0->4.20.0 to 4.19.1->4.20.0
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Temporarily backup StorPool volume before expunge [cloudstack]
sureshanaparti commented on code in PR #8843:
URL: https://github.com/apache/cloudstack/pull/8843#discussion_r1555713980
##
plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/driver/StorPoolStatsCollector.java:
##
@@ -70,7 +86,7 @@ enum StorPoolObject {
public boolean start() {
List spPools =
storagePoolDao.findPoolsByProvider(StorPoolUtil.SP_PROVIDER_NAME);
if (CollectionUtils.isNotEmpty(spPools)) {
-executor = Executors.newScheduledThreadPool(2,new
NamedThreadFactory("StorPoolStatsCollector"));
+executor = Executors.newScheduledThreadPool(3,new
NamedThreadFactory("StorPoolStatsCollector"));
Review Comment:
```suggestion
executor = Executors.newScheduledThreadPool(3, new
NamedThreadFactory("StorPoolStatsCollector"));
```
can take value from any config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Temporarily backup StorPool volume before expunge [cloudstack]
sureshanaparti commented on code in PR #8843:
URL: https://github.com/apache/cloudstack/pull/8843#discussion_r1555708565
##
plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/driver/StorPoolPrimaryDataStoreDriver.java:
##
@@ -431,6 +439,54 @@ public void deleteAsync(DataStore dataStore, DataObject
data, AsyncCompletionCal
callback.complete(res);
}
+private void tryToSnapshotVolumeBeforeDelete(VolumeInfo vinfo, String
name, SpConnectionDesc conn) {
+Integer deleteAfter =
StorPoolConfigurationManager.DeleteAfterInterval.value();
+if (deleteAfter != null && deleteAfter > 0 && vinfo.getPassphraseId()
== null) {
+createTemporarySnapshot(vinfo, name, deleteAfter, conn);
+} else {
+StorPoolUtil.spLog("The volume [%s] is not marked to be
snapshoted. Check the global setting `storpool.delete.after.interval` or the
volume is encrypted [%s]", name, deleteAfter, vinfo.getPassphraseId() != null);
Review Comment:
```suggestion
StorPoolUtil.spLog("The volume [%s] is not marked to be
snapshotted. Check the global setting `storpool.delete.after.interval` or the
volume is encrypted [%s]", name, deleteAfter, vinfo.getPassphraseId() != null);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] fix: clean magic value, and update if-else to switch [cloudstack]
sureshanaparti commented on code in PR #8848:
URL: https://github.com/apache/cloudstack/pull/8848#discussion_r1555703046
##
services/console-proxy/rdpconsole/src/main/java/common/Client.java:
##
@@ -47,6 +47,10 @@ enum Protocol {
NONE, VNC, RDP, HYPERV
}
+private static final String VNC = "vnc";
+private static final String RDP = "rdp";
+private static final String HYPERV = "hyperv";
Review Comment:
i think, no need of this string definitions, try with string to enum
constant conversion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] KVMHAMonitor getting initialized without host ha enabled [cloudstack]
andrijapanicsb commented on issue #8682: URL: https://github.com/apache/cloudstack/issues/8682#issuecomment-2042561467 afaik, this has 0 things to do with host HA, VM HA or anything else. This scrip (kvmspheartbeat.sh) has been there for last 12 years (that I'm aware of) - and it only checks if NFS storage is accessible, and if not, reboots (forcefully) the host. They only way (to my knowledge) to disable host reboots is to comment out the lines that does some echo into sys/proc...etc - at the VERY end of the script (that echo triggers forcefull reboot) - just comment out that single "echo line and you are good. Storage migh be unaccessible (heartbeat fail) but nothing will happen (log messages will say "I'm rebooting" but script is not doing anything due to line commented out) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix spelling in code comments [cloudstack]
blueorangutan commented on PR #8866: URL: https://github.com/apache/cloudstack/pull/8866#issuecomment-2042554358 @sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix spelling in code comments [cloudstack]
sureshanaparti commented on PR #8866: URL: https://github.com/apache/cloudstack/pull/8866#issuecomment-2042553270 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] KVMHAMonitor getting initialized without host ha enabled [cloudstack]
DaanHoogland commented on issue #8682: URL: https://github.com/apache/cloudstack/issues/8682#issuecomment-2042551810 @sbrueseke , I beg to differ, when storage can not be reached all VMs will be running on read-only disks from there on in. This means the hosts is useless and VMs need to reboot according to VM-HA. This behaviour was implemented before Host-HA was conceived and is not related. Maybe a redesign is in place but as of now this works as designed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feature: webhooks [cloudstack]
blueorangutan commented on PR #8674: URL: https://github.com/apache/cloudstack/pull/8674#issuecomment-2042550964 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feature: webhooks [cloudstack]
shwstppr commented on PR #8674: URL: https://github.com/apache/cloudstack/pull/8674#issuecomment-2042548286 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] KVMHAMonitor getting initialized without host ha enabled [cloudstack]
weizhouapache commented on issue #8682: URL: https://github.com/apache/cloudstack/issues/8682#issuecomment-2042545776 > @weizhouapache I would suggest to take another look into that and change it default. In my opinion a host should not automatically reboot at all if no settings are configured. From what I know this looks to me like old behavior lost in the code. I agree with you. @sbrueseke cc @DaanHoogland @rohityadavcloud @andrijapanicsb @GutoVeronezi @wido your opinions ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] libvirtstorage: Make sure netfs storage was really mounted [cloudstack]
sureshanaparti commented on code in PR #8887:
URL: https://github.com/apache/cloudstack/pull/8887#discussion_r1555689697
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java:
##
@@ -692,6 +702,10 @@ public KVMStoragePool createStoragePool(String name,
String host, int port, Stri
sp.create(0);
}
+if (type == StoragePoolType.NetworkFilesystem) {
+checkNetfsStoragePoolMounted(name);
Review Comment:
yes, got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Updates to HPE-Primera and Pure FlashArray Drivers to use Host-based VLUN Assignments [cloudstack]
blueorangutan commented on PR #8889: URL: https://github.com/apache/cloudstack/pull/8889#issuecomment-2042544024 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Updates to HPE-Primera and Pure FlashArray Drivers to use Host-based VLUN Assignments [cloudstack]
DaanHoogland commented on PR #8889: URL: https://github.com/apache/cloudstack/pull/8889#issuecomment-2042541340 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Updates to HPE-Primera and Pure FlashArray Drivers to use Host-based VLUN Assignments [cloudstack]
DaanHoogland commented on PR #8889: URL: https://github.com/apache/cloudstack/pull/8889#issuecomment-2042541081 @rg9975 the github actions show 1 succesfull check out of 22 :eyes: probably not a structural issue with your code, but please have a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Ready for QA] New feature: Import DATA volume from storage pool [cloudstack]
blueorangutan commented on PR #8808: URL: https://github.com/apache/cloudstack/pull/8808#issuecomment-2042537119 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] The sensitvie information job object may leak [cloudstack]
DaanHoogland commented on issue #8854: URL: https://github.com/apache/cloudstack/issues/8854#issuecomment-2042535762 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Ready for QA] New feature: Import DATA volume from storage pool [cloudstack]
weizhouapache commented on PR #8808: URL: https://github.com/apache/cloudstack/pull/8808#issuecomment-2042533978 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] sanatise trace logging of async jobs [cloudstack]
DaanHoogland opened a new pull request, #8892:
URL: https://github.com/apache/cloudstack/pull/8892
### Description
This PR...
Fixes: #8854
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [x] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] KVMHAMonitor getting initialized without host ha enabled [cloudstack]
sbrueseke commented on issue #8682: URL: https://github.com/apache/cloudstack/issues/8682#issuecomment-2042529564 @weizhouapache I would suggest to take another look into that and change it default. In my opinion a host should not automatically reboot at all if no settings are configured. From what I know this looks to me like old behavior lost in the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] KVMHAMonitor getting initialized without host ha enabled [cloudstack]
weizhouapache commented on issue #8682: URL: https://github.com/apache/cloudstack/issues/8682#issuecomment-2042521887 > > > > > @DaanHoogland now I am confused! Why is KVMHAMonitor rebooting hosts when the host is unable to write a heartbeat file to any storage when any HA setting is disabled in the UI? Do you know the reason for that? > > > > > > > > > > > > @sbrueseke You can add a setting in `/etc/cloudstack/agent.properties` and restart cloudstack-agent > > > > ``` > > > > reboot.host.and.alert.management.on.heartbeat.timeout=false > > > > ``` > > > > > > > > > I know this workaround. My question is if this setting should be added by the management server instead of manually. Is there any legit reason KVMHAMonitor should reboot a host when all HA settings are disabled in the UI? > > > > > > @sbrueseke as I understand, the Host HA means the HA solutions by OOBM/IPMI > > Can you explain the root cause why KVMHAMonitor needs to reboot the host when a storage is read only? @sbrueseke it is the old behaviour introduced more than 10 years ago. I am not clear why. there were lots of discussion in the past https://github.com/apache/cloudstack/pull/2722 https://github.com/apache/cloudstack/issues/2890 https://github.com/apache/cloudstack/pull/2984 https://github.com/apache/cloudstack/pull/4586 and #4708 since storage issue rarely happens, it may be ok for users to change the setting in agent.properties -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] The sensitvie information job object may leak [cloudstack]
DaanHoogland commented on issue #8854: URL: https://github.com/apache/cloudstack/issues/8854#issuecomment-2042523709 ok, I'll add another clean action there, thanks @1561316811 and @lujiefsi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2042518073 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Updates to HPE-Primera and Pure FlashArray Drivers to use Host-based VLUN Assignments [cloudstack]
blueorangutan commented on PR #8889: URL: https://github.com/apache/cloudstack/pull/8889#issuecomment-2042516551 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix assignVirtualMachine template checkAccess [cloudstack]
blueorangutan commented on PR #8886: URL: https://github.com/apache/cloudstack/pull/8886#issuecomment-2042515327 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix assignVirtualMachine template checkAccess [cloudstack]
DaanHoogland commented on PR #8886: URL: https://github.com/apache/cloudstack/pull/8886#issuecomment-2042514324 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Change iops on offering change [cloudstack]
blueorangutan commented on PR #8872: URL: https://github.com/apache/cloudstack/pull/8872#issuecomment-2042489738 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] KVMHAMonitor getting initialized without host ha enabled [cloudstack]
sbrueseke commented on issue #8682: URL: https://github.com/apache/cloudstack/issues/8682#issuecomment-2042484114 > > > > @DaanHoogland now I am confused! Why is KVMHAMonitor rebooting hosts when the host is unable to write a heartbeat file to any storage when any HA setting is disabled in the UI? Do you know the reason for that? > > > > > > > > > @sbrueseke You can add a setting in `/etc/cloudstack/agent.properties` and restart cloudstack-agent > > > ``` > > > reboot.host.and.alert.management.on.heartbeat.timeout=false > > > ``` > > > > > > I know this workaround. My question is if this setting should be added by the management server instead of manually. Is there any legit reason KVMHAMonitor should reboot a host when all HA settings are disabled in the UI? > > @sbrueseke as I understand, the Host HA means the HA solutions by OOBM/IPMI Can you explain the root cause why KVMHAMonitor needs to reboot the host when a storage is read only? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] sanatise log in case multiple passwordsa have been passed [cloudstack]
DaanHoogland opened a new pull request, #8891:
URL: https://github.com/apache/cloudstack/pull/8891
### Description
This PR...
Fixes: #8852
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [x] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] KVMHAMonitor getting initialized without host ha enabled [cloudstack]
weizhouapache commented on issue #8682: URL: https://github.com/apache/cloudstack/issues/8682#issuecomment-2042464792 > > > @DaanHoogland now I am confused! Why is KVMHAMonitor rebooting hosts when the host is unable to write a heartbeat file to any storage when any HA setting is disabled in the UI? Do you know the reason for that? > > > > > > @sbrueseke You can add a setting in `/etc/cloudstack/agent.properties` and restart cloudstack-agent > > ``` > > reboot.host.and.alert.management.on.heartbeat.timeout=false > > ``` > > I know this workaround. My question is if this setting should be added by the management server instead of manually. Is there any legit reason KVMHAMonitor should reboot a host when all HA settings are disabled in the UI? @sbrueseke as I understand, the Host HA means the HA solutions by OOBM/IPMI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Sesitive information of request.getRequestLine() may leak [cloudstack]
DaanHoogland commented on issue #8852: URL: https://github.com/apache/cloudstack/issues/8852#issuecomment-2042459913 I see, I will add an extra cleanString here as well, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] log sanitation on output of jobs [cloudstack]
DaanHoogland opened a new pull request, #8890:
URL: https://github.com/apache/cloudstack/pull/8890
### Description
This PR...
Fixes: #8853
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [x] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] The sensitvie information job object may leak [cloudstack]
lujiefsi commented on issue #8854: URL: https://github.com/apache/cloudstack/issues/8854#issuecomment-2042446303 I understand his explanation roughly. First, he provided this link: https://github.com/apache/cloudstack/blob/2959cc67652381e3a39b298e674a0bced5002337/plugins/outofbandmanagement-drivers/ipmitool/src/main/java/org/apache/cloudstack/outofbandmanagement/driver/ipmitool/IpmitoolWrapper.java#L175 This is to demonstrate that CloudStack is careful to remove sensitive information even from trace-level logs. Next, he referenced this link: https://github.com/apache/cloudstack/blob/2959cc67652381e3a39b298e674a0bced5002337/framework/jobs/src/main/java/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java#L637 This suggests that the 'job' variable is sensitive because of the code `StringUtils.cleanString(job.toString())`, where `StringUtils.cleanString` is used to scrub passwords, indicating that 'job' contains sensitive information like passwords. However, this subsequent piece of code: https://github.com/apache/cloudstack/blob/2959cc67652381e3a39b298e674a0bced5002337/framework/jobs/src/main/java/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java#L647 logs the 'job' at the trace level. Given the precedent that CloudStack removes sensitive information from trace logs, and since there's an earlier statement to clean sensitive info from the job, he suggests that the logging at: https://github.com/apache/cloudstack/blob/2959cc67652381e3a39b298e674a0bced5002337/framework/jobs/src/main/java/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java#L647 might be problematic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] The sensitive information of uri may leak [cloudstack]
DaanHoogland commented on issue #8853: URL: https://github.com/apache/cloudstack/issues/8853#issuecomment-2042416493 You are right, I will create a PR to add a call to `StringUtils.cleanString()` here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] The sensitvie information job object may leak [cloudstack]
DaanHoogland commented on issue #8854: URL: https://github.com/apache/cloudstack/issues/8854#issuecomment-2042407883 @1561316811 you are not convincing me - why is job a sensitive variable? - if so, why would the operator not be allowed to see it - how can this be abused? I see no exploit for this. please enlighten us to what can happen and how would that be done? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2042399497 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Updates to HPE-Primera and Pure FlashArray Drivers to use Host-based VLUN Assignments [cloudstack]
blueorangutan commented on PR #8889: URL: https://github.com/apache/cloudstack/pull/8889#issuecomment-2042399410 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Updates to HPE-Primera and Pure FlashArray Drivers to use Host-based VLUN Assignments [cloudstack]
DaanHoogland commented on PR #8889: URL: https://github.com/apache/cloudstack/pull/8889#issuecomment-2042398438 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
vishesh92 commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2042397099 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Virtual router is failed to start because firmware is EFI. [cloudstack]
DaanHoogland commented on issue #8734: URL: https://github.com/apache/cloudstack/issues/8734#issuecomment-2042396369 > @rastopato @DaanHoogland > > I could reproduce this bug in my environment. This happens when the user's VM and the VR are stopped and the user starts its VM. In this process, the VR is created with the same boot parameters from the user's VM, which causes the VR to not start when the user VM has the UEFI boot type. On Monday I'll work on a PR to fix this situation. > > As a workaround, you can do a restart with cleanup of your network and, after the VR is up, you can start your VM. I tried this scenario @hsato03 , but still the VR starts as expected. not sure what other configuration is in play here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack-www) branch staging-site updated: CSEUG 2024 blog and events entry (#199)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch staging-site in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git The following commit(s) were added to refs/heads/staging-site by this push: new d0a97bbb CSEUG 2024 blog and events entry (#199) d0a97bbb is described below commit d0a97bbb6adc02f1624f2f5a55c69c7dbbc2f639 Author: dahn AuthorDate: Mon Apr 8 12:23:37 2024 +0200 CSEUG 2024 blog and events entry (#199) --- blog/2024-04-08-CSEUG-Frankfurt/banner.jpg | Bin 0 -> 518500 bytes blog/2024-04-08-CSEUG-Frankfurt/index.md | 87 +++ blog/2024-04-08-CSEUG-Frankfurt/presentation.jpg | Bin 0 -> 120299 bytes blog/2024-04-08-CSEUG-Frankfurt/proio-logo.png | Bin 0 -> 6967 bytes src/components/Events/index.tsx | 24 --- static/img/CSEUG 2024.jpg| Bin 0 -> 518500 bytes 6 files changed, 100 insertions(+), 11 deletions(-) diff --git a/blog/2024-04-08-CSEUG-Frankfurt/banner.jpg b/blog/2024-04-08-CSEUG-Frankfurt/banner.jpg new file mode 100644 index ..f3c103f7 Binary files /dev/null and b/blog/2024-04-08-CSEUG-Frankfurt/banner.jpg differ diff --git a/blog/2024-04-08-CSEUG-Frankfurt/index.md b/blog/2024-04-08-CSEUG-Frankfurt/index.md new file mode 100644 index ..25871f4b --- /dev/null +++ b/blog/2024-04-08-CSEUG-Frankfurt/index.md @@ -0,0 +1,87 @@ +--- +layout: post +title: CloudStack European User Group – September 12th, Frankfurt, Germany +tags: [news] +authors: [ivet] +slug: cseug-2024 +--- + + + + + +# Apache CloudStack is thrilled to share that the autumn edition of + CloudStack European User Group 2024 is scheduled for September 12th + and will happen in Frankfurt, Germany! + +The event will be hosted by proIO – а German Private Cloud and Managed +Hosting Provider and a long-time CloudStack community supporter. The +venue to accommodate the CloudStack European User Group 2024 is Nio +House Frankfurt. + + + + +https://www.eventbrite.co.uk/e/cloudstack-european-user-group-germany-tickets-879369205967; target="_blank">Register Now + + + +## Why Join the CSEUG + +CloudStack European User Group is a get-together for the European +CloudStack Community. CSEUG is a 1-day technical event, where you will +be able to meet the leading CloudStack experts, users and skilful +engineers from the open-source world. You can expect technical talks, +user stories, new features and integrations presentations and more. + + + +## Call for Presentations + +The Call for Presentations is also open. We encourage you to submit +your session early, to maximise the chance of it being accepted. Also, +please keep in mind sessions are expected to be held in-person. Click +here to submit your session proposal - +https://forms.gle/7gREjJWAusZndGnL7 + +## Who is the Conference for? + +The event is aimed at developers, operators and users to discuss and +evolve the open-source software project, its functionality and +real-world operability. This event will introduce you to the +CloudStack family, community leaders, project members and +contributors. + +CSEUG welcomes attendees from all over the globe. Our core audience is +enterprises, cloud service providers, telcos and MSPs. Every region +sends its best and brightest to share insights and knowledge on +open-source technology, orchestrating public and private clouds, +building IaaS. + + +https://www.eventbrite.co.uk/e/cloudstack-european-user-group-germany-tickets-879369205967; target="_blank">Register Now + + +## Meet ProIO – Our host + +[](https://www.proIO.com/) + +proIO is a Private Cloud Provider dedicated to empowering German SMBs +across various industries through its Infrastructure-as-a-Service and +Managed Hosting solutions, based out of Frankfurt, Germany. Deeply +rooted in its belief in open-source technology, proIO is recognized +for its expertise through its longstanding use of Apache +CloudStack. This commitment to open-source principles is further +highlighted by CEO Swen Brüseke, who is frequently featured at +community events, sharing insights and fostering dialogue with the +community. + +"CloudStack empowers proIO to offer solutions that are precisely +tailored to meet our customers' unique business needs," states +Swen. "With its minimal footprint, flexibility, ease of use, and +compatibility with standard hardware, we're positioned to enhance and +streamline our customers' IT infrastructure. This approach reflects +our dedication to delivering highly effective, customer-centric +solutions." diff --git a/blog/2024-04-08-CSEUG-Frankfurt/presentation.jpg b/blog/2024-04-08-CSEUG-Frankfurt/presentation.jpg new file mode 100644 index ..880eeb45 Binary files /dev/null and b/blog/2024-04-08-CSEUG-Frankfurt/presentation.jpg differ diff --git
Re: [PR] Change iops on offering change [cloudstack]
blueorangutan commented on PR #8872: URL: https://github.com/apache/cloudstack/pull/8872#issuecomment-2042377428 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Change iops on offering change [cloudstack]
vishesh92 commented on PR #8872: URL: https://github.com/apache/cloudstack/pull/8872#issuecomment-2042373446 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2042338425 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add The name of the Qemu binary to look for. [cloudstack]
weizhouapache commented on code in PR #8855: URL: https://github.com/apache/cloudstack/pull/8855#discussion_r154098 ## tools/appliance/systemvmtemplate/template.json: ## @@ -22,6 +22,7 @@ "" ], "boot_wait": "5s", + "qemu_binary": "qemu-system-x86_64", Review Comment: @a1768623020 can you move this to line 34 ? the parameters are ordered now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
