Re: [PR] test: fix unknown parameter hostid in test_vm_life_cycle.py [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8948:
URL: https://github.com/apache/cloudstack/pull/8948#issuecomment-2071468343

   [SF] Trillian test result (tid-9950)
   Environment: xcpng82 (x2), Advanced Networking with Mgmt server a9
   Total time taken: 68675 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8948-t9950-xcpng82.zip
   Smoke tests completed. 123 look OK, 6 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_events_resource | `Error` | 281.98 | test_events_resource.py
   test_01_events_resource | `Error` | 281.99 | test_events_resource.py
   test_01_condensed_drs_algorithm | `Failure` | 167.79 | test_cluster_drs.py
   test_02_balanced_drs_algorithm | `Failure` | 185.87 | test_cluster_drs.py
   test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 197.89 
| test_network_permissions.py
   ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.51 | 
test_network_permissions.py
   test_01_non_strict_host_anti_affinity | `Error` | 215.74 | 
test_nonstrict_affinity_group.py
   test_02_non_strict_host_affinity | `Error` | 126.08 | 
test_nonstrict_affinity_group.py
   test_deploy_vm_with_registered_userdata | `Error` | 819.45 | 
test_register_userdata.py
   test_deploy_vm_with_registered_userdata_with_override_policy_allow | `Error` 
| 828.89 | test_register_userdata.py
   test_deploy_vm_with_registered_userdata_with_override_policy_append | 
`Error` | 830.95 | test_register_userdata.py
   test_deploy_vm_with_registered_userdata_with_params | `Error` | 829.45 | 
test_register_userdata.py
   test_01_deploy_vm_on_specific_host | `Error` | 0.12 | 
test_vm_deployment_planner.py
   test_02_deploy_vm_on_specific_cluster | `Error` | 0.11 | 
test_vm_deployment_planner.py
   test_03_deploy_vm_on_specific_pod | `Error` | 0.14 | 
test_vm_deployment_planner.py
   test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 0.17 | 
test_vm_deployment_planner.py
   test_05_deploy_vm_on_cluster_override_pod | `Error` | 0.13 | 
test_vm_deployment_planner.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] New feature: Implicit host tags [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8929:
URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2071441794

   [SF] Trillian test result (tid-9958)
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
   Total time taken: 46346 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8929-t9958-vmware-67u3.zip
   Smoke tests completed. 119 look OK, 11 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_events_resource | `Error` | 209.14 | test_events_resource.py
   test_01_events_resource | `Error` | 209.15 | test_events_resource.py
   test_DeployVmAntiAffinityGroup_in_project | `Error` | 122.00 | 
test_affinity_groups_projects.py
   test_DeployVmAntiAffinityGroup | `Error` | 47.16 | test_affinity_groups.py
   test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 53.65 | 
test_kubernetes_clusters.py
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.09 | 
test_kubernetes_clusters.py
   test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 104.01 
| test_network_permissions.py
   ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.49 | 
test_network_permissions.py
   test_01_non_strict_host_anti_affinity | `Failure` | 150.67 | 
test_nonstrict_affinity_group.py
   test_02_non_strict_host_affinity | `Error` | 100.17 | 
test_nonstrict_affinity_group.py
   test_01_verify_ipv6_vpc | `Error` | 3.45 | test_vpc_ipv6.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 5.79 | 
test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | `Error` | 5.86 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
`Error` | 6.19 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Error` | 5.84 | 
test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 5.59 | test_vpc_redundant.py
   test_01_VPC_nics_after_destroy | `Error` | 6.41 | test_vpc_router_nics.py
   test_02_VPC_default_routes | `Error` | 5.75 | test_vpc_router_nics.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 3.79 | test_vpc_vpn.py
   test_01_vpc_site2site_vpn_multiple_options | `Failure` | 3.49 | 
test_vpc_vpn.py
   test_01_vpc_remote_access_vpn | `Failure` | 1.24 | test_vpc_vpn.py
   test_01_vpc_site2site_vpn | `Failure` | 3.51 | test_vpc_vpn.py
   test_01_cancel_host_maintenace_with_no_migration_jobs | `Error` | 0.08 | 
test_host_maintenance.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 0.07 | 
test_host_maintenance.py
   test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 0.07 
| test_host_maintenance.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] New feature: Implicit host tags [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8929:
URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2071434077

   [SF] Trillian test result (tid-9959)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 46026 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8929-t9959-kvm-centos7.zip
   Smoke tests completed. 128 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_events_resource | `Error` | 304.08 | test_events_resource.py
   test_01_events_resource | `Error` | 304.09 | test_events_resource.py
   test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 88.48 
| test_network_permissions.py
   ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.42 | 
test_network_permissions.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Unable to Secure CloudStack System VMs with Dynamic URL [cloudstack]

2024-04-22 Thread via GitHub


vishnuvs369 commented on issue #8957:
URL: https://github.com/apache/cloudstack/issues/8957#issuecomment-2071405857

   @weizhouapache 
   I restarted management server and destoyed system vm's, still its not 
working.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8898:
URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2071278169

   [SF] Trillian test result (tid-9945)
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
   Total time taken: 64704 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8898-t9945-vmware-67u3.zip
   Smoke tests completed. 62 look OK, 19 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_deploy_vm_start_failure | `Error` | 108.28 | test_deploy_vm.py
   test_deploy_vm_volume_creation_failure | `Error` | 99.98 | test_deploy_vm.py
   test01_template_download_URL_expire | `Error` | 15026.64 | 
test_escalations_templates.py
   test_vm_ha | `Error` | 99.71 | test_vm_ha.py
   test_vm_sync | `Error` | 179.54 | test_vm_sync.py
   ContextSuite context=TestDeployVmWithAffinityGroup>:teardown | `Error` | 
147.65 | test_affinity_groups_projects.py
   runTest | `Error` | 0.00 | test_network.py
   test_02_deploy_vm_root_resize | `Failure` | 0.14 | 
test_deploy_vm_root_resize.py
   test_02_vpc_privategw_static_routes | `Failure` | 232.05 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 213.33 | 
test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 370.87 | 
test_privategw_acl.py
   test_UpdateConfigParamWithScope | `Error` | 0.79 | test_global_settings.py
   test_07_project_resources_account_delete | `Error` | 5.60 | test_projects.py
   test_08_cleanup_after_project_delete | `Error` | 7.74 | test_projects.py
   ContextSuite context=TestProjectResources>:teardown | `Error` | 9.96 | 
test_projects.py
   ContextSuite context=TestProjectSuspendActivate>:teardown | `Error` | 97.50 
| test_projects.py
   test_03_user_role_dont_see_annotations | `Failure` | 3.00 | 
test_host_annotations.py
   test_dedicatePublicIpRange | `Error` | 0.04 | test_public_ip_range.py
   test_create_pvlan_network | `Error` | 0.06 | test_pvlan.py
   test_oobm_background_powerstate_sync | `Failure` | 20.82 | 
test_outofbandmanagement.py
   test_oobm_enabledisable_across_clusterzones | `Error` | 33.18 | 
test_outofbandmanagement.py
   test_oobm_issue_power_cycle | `Error` | 18.81 | test_outofbandmanagement.py
   test_oobm_issue_power_off | `Error` | 19.80 | test_outofbandmanagement.py
   test_oobm_issue_power_on | `Error` | 19.80 | test_outofbandmanagement.py
   test_oobm_issue_power_reset | `Error` | 18.79 | test_outofbandmanagement.py
   test_oobm_issue_power_soft | `Error` | 18.83 | test_outofbandmanagement.py
   test_oobm_issue_power_status | `Error` | 18.78 | test_outofbandmanagement.py
   test_oobm_multiple_mgmt_server_ownership | `Failure` | 27.93 | 
test_outofbandmanagement.py
   test_oobm_zchange_password | `Error` | 7.42 | test_outofbandmanagement.py
   test_03_RVR_Network_check_router_state | `Failure` | 149.85 | 
test_routers_network_ops.py
   test_02_create_template_with_checksum_sha1 | `Error` | 5.24 | 
test_templates.py
   test_03_create_template_with_checksum_sha256 | `Error` | 5.19 | 
test_templates.py
   test_04_create_template_with_checksum_md5 | `Error` | 5.24 | 
test_templates.py
   test_01_migrate_VM_and_root_volume | `Error` | 95.69 | test_vm_life_cycle.py
   test_02_migrate_VM_with_two_data_disks | `Error` | 62.93 | 
test_vm_life_cycle.py
   test_03_migrate_detached_volume | `Error` | 61.72 | test_vm_life_cycle.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 351.37 | 
test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | `Failure` | 332.59 | 
test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
`Failure` | 215.55 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 171.50 | 
test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 301.70 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 337.39 | test_vpc_redundant.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Failure` | 208.79 | 
test_host_maintenance.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] field enlarged and db upgrade [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8675:
URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2071249259

   [SF] Trillian test result (tid-9949)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 52880 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8675-t9949-kvm-centos7.zip
   Smoke tests completed. 125 look OK, 4 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_events_resource | `Error` | 293.82 | test_events_resource.py
   test_01_events_resource | `Error` | 293.83 | test_events_resource.py
   test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 84.65 
| test_network_permissions.py
   ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.46 | 
test_network_permissions.py
   test_01_secure_vm_migration | `Error` | 133.78 | test_vm_life_cycle.py
   test_01_secure_vm_migration | `Error` | 133.79 | test_vm_life_cycle.py
   test_02_unsecure_vm_migration | `Error` | 0.02 | test_vm_life_cycle.py
   test_03_secured_to_nonsecured_vm_migration | `Error` | 0.02 | 
test_vm_life_cycle.py
   test_04_nonsecured_to_secured_vm_migration | `Error` | 0.02 | 
test_vm_life_cycle.py
   test_02_redundant_VPC_default_routes | `Failure` | 1900.56 | 
test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 715.11 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 715.13 | test_vpc_redundant.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] server: fix duplicated records for templates if there are multiple zones [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8933:
URL: https://github.com/apache/cloudstack/pull/8933#issuecomment-2071215122

   [SF] Trillian test result (tid-9951)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 51237 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8933-t9951-kvm-centos7.zip
   Smoke tests completed. 127 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_events_resource | `Error` | 290.88 | test_events_resource.py
   test_01_events_resource | `Error` | 290.89 | test_events_resource.py
   test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 87.79 
| test_network_permissions.py
   ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.40 | 
test_network_permissions.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] cleanup some smoke tests [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8196:
URL: https://github.com/apache/cloudstack/pull/8196#issuecomment-2071213844

   [SF] Trillian test result (tid-9954)
   Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
   Total time taken: 47713 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8196-t9954-kvm-alma9.zip
   Smoke tests completed. 110 look OK, 5 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_add_primary_storage_disabled_host | `Error` | 0.25 | 
test_primary_storage.py
   test_03_migration_options_storage_tags | `Error` | 0.02 | 
test_primary_storage.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 9.67 | 
test_snapshots.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 9.67 | 
test_snapshots.py
   ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | 
test_service_offerings.py
   test_01_deploy_vm_on_specific_host | `Error` | 0.10 | 
test_vm_deployment_planner.py
   test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 0.17 | 
test_vm_deployment_planner.py
   test_08_migrate_vm | `Error` | 0.08 | test_vm_life_cycle.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] test: fix unknown parameter hostid in test_vm_life_cycle.py [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8948:
URL: https://github.com/apache/cloudstack/pull/8948#issuecomment-2071122078

   [SF] Trillian test result (tid-9952)
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server r8
   Total time taken: 44838 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8948-t9952-xenserver-71.zip
   Smoke tests completed. 127 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_events_resource | `Error` | 223.89 | test_events_resource.py
   test_01_events_resource | `Error` | 223.89 | test_events_resource.py
   test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 106.21 
| test_network_permissions.py
   ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.50 | 
test_network_permissions.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #7345:
URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-2071081857

   [SF] Trillian test result (tid-9946)
   Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
   Total time taken: 50670 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7345-t9946-kvm-alma9.zip
   Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Bug: UI fails with 503 just after a successful install [cloudstack]

2024-04-22 Thread via GitHub


rightkick commented on issue #8218:
URL: https://github.com/apache/cloudstack/issues/8218#issuecomment-2071051994

   I confirm that after setting the the `cluster.node.IP` at 
`/etc/cloudstack/management/db.properties` to be the VM IP where ACS is 
installed, and restarting `cloudstack-management.service` I got the login 
prompt. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Update en.json [cloudstack]

2024-04-22 Thread via GitHub


NuxRo opened a new pull request, #8958:
URL: https://github.com/apache/cloudstack/pull/8958

   Replace "Control Plane" with "Compute Resource"
   
   ### Description
   
   A simple replacement so it makes sense to people, sorry but "**Control Plane 
Status**" is not very meaningful and took a while to figure out what it meant.
   
   We should just say agent or vcenter.. I used "**Compute Resource**" instead, 
hopefully that's general enough and meaningful.
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] build/CI
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [x] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   
   
   
    How did you try to break this feature and the system with this change?
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(cloudstack) branch NuxRo-patch-1 created (now f11f0a94bf2)

2024-04-22 Thread nux
This is an automated email from the ASF dual-hosted git repository.

nux pushed a change to branch NuxRo-patch-1
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


  at f11f0a94bf2 Update en.json

This branch includes the following new commits:

 new f11f0a94bf2 Update en.json

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.




(cloudstack) 01/01: Update en.json

2024-04-22 Thread nux
This is an automated email from the ASF dual-hosted git repository.

nux pushed a commit to branch NuxRo-patch-1
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit f11f0a94bf29576f36e19ab0f7f446317b5d3cd2
Author: NuxRo 
AuthorDate: Mon Apr 22 22:46:00 2024 +0100

Update en.json

Replace "Control Plane" with "Compute Resource"
---
 ui/public/locales/en.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ui/public/locales/en.json b/ui/public/locales/en.json
index dd4c6398edd..48d98c99857 100644
--- a/ui/public/locales/en.json
+++ b/ui/public/locales/en.json
@@ -992,7 +992,7 @@
 "label.host.alerts": "Hosts in alert state",
 "label.host.name": "Host name",
 "label.host.tag": "Host tag",
-"label.hostcontrolstate": "Control Plane Status",
+"label.hostcontrolstate": "Compute Resource Status",
 "label.hostid": "Host",
 "label.hostname": "Host",
 "label.hostname.tooltip": "Destination Host. Volume should be located in local 
storage of this Host",
@@ -2938,7 +2938,7 @@
 "message.chart.statistic.info": "The shown charts are self-adjustable, that 
means, if the value gets close to the limit or overpass it, it will grow to 
adjust the shown value",
 "message.guest.traffic.in.advanced.zone": "Guest Network traffic is 
communication between end-user Instances. Specify a range of VLAN IDs or VXLAN 
Network identifiers (VNIs) to carry guest traffic for each physical Network.",
 "message.guest.traffic.in.basic.zone": "Guest Network traffic is communication 
between end-user Instances. Specify a range of IP addresses that CloudStack can 
assign to guest Instances. Make sure this range does not overlap the reserved 
system IP range.",
-"message.host.controlstate": "The Control Plane Status of this Instance is ",
+"message.host.controlstate": "The Compute Resource Status for this Instance is 
",
 "message.host.controlstate.retry": "Some actions on this Instance will fail, 
if so please wait a while and retry.",
 "message.host.dedicated": "Host Dedicated",
 "message.host.dedication.released": "Host dedication released.",



Re: [PR] KVM: enable no-mac-spoofing on virtual nics [cloudstack]

2024-04-22 Thread via GitHub


wido commented on PR #8951:
URL: https://github.com/apache/cloudstack/pull/8951#issuecomment-2070862069

   > > > > My suggestion:
   > > > > ```
   > > > > * Enable this in Libvirt
   > > > > 
   > > > > * Remove functionality from security_group.py
   > > > > ```
   > > > 
   > > > 
   > > > meaning, @wido , this is good but we need to add a removal of some of 
the " -j DROP/ACCEPT" lines from the script? sounds like some precision 
surgery. Do you know which ones to drop? cc @weizhouapache .
   > > 
   > > 
   > > It would, I think if you take a look it starts here:
   > > 
https://github.com/apache/cloudstack/blob/8ff2c018cc5b3fc69bcd8756695d04b384e46ab8/scripts/vm/network/security_group.py#L280
   > > 
   > > 
   > > * default_ebtables_rules()
   > > * destroy_ebtables_rules()
   > > 
   > > Those would no longer be needed
   > 
   > @wido actually I am thinking of disabling this change for vms with 
security groups the script `security_group.py` programs iptables/ebtables rules 
including the mac/ip/arp anti-spoofing, it has been proved to be working well 
with both ipv4/ipv6 addresses and one/multiple network nics. this PR only 
contains `no-mac-spoofing` which is not good enough to replace the 
`security_group.py`. it looks like a precise surgery to remove the ebtables 
rules, as @DaanHoogland said. we could drop the methods in `security_group.py` 
if all mac/ip/arp anti-spoofing are supported (see the PR description).
   > 
   > other than that, the upgrade could be an issue as the VMs started in old 
versions (before upgrade) do not have the configuration in their VM XML 
definition.
   
   Sounds good. I would only add this to VMs without any SG. That would get my 
approval.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Possibility to choose the source NAT IP address on a isolated network or VPC [cloudstack]

2024-04-22 Thread via GitHub


BryanMLima commented on code in PR #6442:
URL: https://github.com/apache/cloudstack/pull/6442#discussion_r1575277096


##
ui/src/views/network/CreateIsolatedNetworkForm.vue:
##
@@ -291,6 +291,36 @@
   
 
   
+  
+
+  
+
+
+  
+  
+
+  
+
+
+  
+  
+
+  
+
+
+  

Review Comment:
   @DaanHoogland, this code seems duplicated, considering that the network 
domain and account fields are already present in the form. Is this on purpose?
   
   While working on PR #8919, there is no option to create a network for a 
project, so I was thinking of adding the `Ownership` component to this view as 
well and removing this duplicate code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] log sanitation on output of jobs [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8890:
URL: https://github.com/apache/cloudstack/pull/8890#issuecomment-2070761669

   [SF] Trillian test result (tid-9943)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 45141 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8890-t9943-kvm-centos7.zip
   Smoke tests completed. 127 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_events_resource | `Error` | 300.34 | test_events_resource.py
   test_01_events_resource | `Error` | 300.35 | test_events_resource.py
   test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 91.74 
| test_network_permissions.py
   ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.36 | 
test_network_permissions.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] GUI whitelabel runtime system [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8942:
URL: https://github.com/apache/cloudstack/pull/8942#issuecomment-2070718209

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9365


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] server: Fix NPE when migrating volume without template [cloudstack]

2024-04-22 Thread via GitHub


gpordeus commented on PR #7615:
URL: https://github.com/apache/cloudstack/pull/7615#issuecomment-2070489439

   > @gpordeus should we still try to merge this? (as 4.18 is coming to end of 
maintemnance)
   
   @DaanHoogland I suppose not, especially with #8911. I'm closing this, but 
I'll still be working on #5759. I was sidetracked, but I'll give it priority 
now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] server: Fix NPE when migrating volume without template [cloudstack]

2024-04-22 Thread via GitHub


gpordeus closed pull request #7615: server: Fix NPE when migrating volume 
without template
URL: https://github.com/apache/cloudstack/pull/7615


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] GUI whitelabel runtime system [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8942:
URL: https://github.com/apache/cloudstack/pull/8942#issuecomment-2070447497

   @BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] GUI whitelabel runtime system [cloudstack]

2024-04-22 Thread via GitHub


BryanMLima commented on PR #8942:
URL: https://github.com/apache/cloudstack/pull/8942#issuecomment-2070441878

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Unable to Secure CloudStack System VMs with Dynamic URL [cloudstack]

2024-04-22 Thread via GitHub


weizhouapache commented on issue #8957:
URL: https://github.com/apache/cloudstack/issues/8957#issuecomment-2070331812

   > @weizhouapache I enabled the following settings in global settings 
consoleproxy.ssl True secstorage.encrypt.copy True
   > 
   > Also Added domains in the below fields consoleproxy.url.domain 
secstorage.ssl.cert.domain
   
   If you have restarted the management server, destroy the system vms and retry


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Unable to Secure CloudStack System VMs with Dynamic URL [cloudstack]

2024-04-22 Thread via GitHub


vishnuvs369 commented on issue #8957:
URL: https://github.com/apache/cloudstack/issues/8957#issuecomment-2070325780

   I enabled the following settings in global settings 
   consoleproxy.ssl  True
   secstorage.encrypt.copy True
   
   Also Added domains in the below fields
   consoleproxy.url.domain 
   secstorage.ssl.cert.domain
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(cloudstack) branch 4.19 updated: server: Fix null pointer exception in restore VM (#8930)

2024-04-22 Thread weizhou
This is an automated email from the ASF dual-hosted git repository.

weizhou pushed a commit to branch 4.19
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.19 by this push:
 new c081f60427d server: Fix null pointer exception in restore VM (#8930)
c081f60427d is described below

commit c081f60427d63f98f51665f6af5128d47bf92568
Author: Vishesh 
AuthorDate: Mon Apr 22 22:51:16 2024 +0530

server: Fix null pointer exception in restore VM (#8930)
---
 server/src/main/java/com/cloud/vm/UserVmManagerImpl.java | 13 -
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java 
b/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
index 566fcb38fc9..6c8aec0da48 100644
--- a/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
+++ b/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
@@ -7699,8 +7699,19 @@ public class UserVmManagerImpl extends ManagerBase 
implements UserVmManager, Vir
 }
 _accountMgr.checkAccess(caller, null, true, vm);
 
+VMTemplateVO template;
+if (newTemplateId != null) {
+template = _templateDao.findById(newTemplateId);
+if (template == null) {
+throw new InvalidParameterValueException("Cannot find template 
with ID " + newTemplateId);
+}
+} else {
+template = _templateDao.findById(vm.getTemplateId());
+if (template == null) {
+throw new InvalidParameterValueException("Cannot find template 
linked with VM");
+}
+}
 DiskOffering diskOffering = rootDiskOfferingId != null ? 
validateAndGetDiskOffering(rootDiskOfferingId, vm, caller) : null;
-VMTemplateVO template = _templateDao.findById(newTemplateId);
 if (template.getSize() != null) {
 String rootDiskSize = 
details.get(VmDetailConstants.ROOT_DISK_SIZE);
 Long templateSize = template.getSize();



Re: [PR] Fix null pointer exception in restore VM [cloudstack]

2024-04-22 Thread via GitHub


weizhouapache merged PR #8930:
URL: https://github.com/apache/cloudstack/pull/8930


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix null pointer exception in restore VM [cloudstack]

2024-04-22 Thread via GitHub


weizhouapache commented on PR #8930:
URL: https://github.com/apache/cloudstack/pull/8930#issuecomment-2070315587

   This is a regression issue of #8800 
   
   step to reproduce the issue: 
   - restore vm
   - prior to this PR: got NPE exception
   - with this PR: it works


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Unable to Secure CloudStack System VMs with Dynamic URL [cloudstack]

2024-04-22 Thread via GitHub


weizhouapache commented on issue #8957:
URL: https://github.com/apache/cloudstack/issues/8957#issuecomment-2070303602

   @vishnuvs369 
   what are the related globals settings ?
   check https://www.shapeblue.com/securing-cloudstack-4-11-with-https-tls/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Enhance Redundant Virtual Routers to 3 Routers, with RAFT Algorithm (or similar) [cloudstack]

2024-04-22 Thread via GitHub


weizhouapache commented on issue #8954:
URL: https://github.com/apache/cloudstack/issues/8954#issuecomment-2070274379

   > Okay noted @weizhouapache , we havent had any Master/Master issues because 
we completely removed the redundancy as it gave us more predictability.
   > 
   > But are there any tests we can run to ensure our networks are configured 
correctly?
   Everyone has different physical routers.
   you can create a test isolated network with redundant VRs, and let it 
running for some days.
   
   > 
   > Also, what should i do with this feature request? Do i close it?
   
   @btzq 
   I have added it to milestone "unplanned". let's keep it open 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] KVM Incremental Snapshots/Backups [cloudstack]

2024-04-22 Thread via GitHub


JoaoJandre commented on issue #8907:
URL: https://github.com/apache/cloudstack/issues/8907#issuecomment-2070247722

   > Impressive design @JoaoJandre . I scanned through it , so I may have 
missed this; is any coalescing occurring on the backed up snapshots for a VM? 
i.e. with snapshots 1,2,3 the user want to delete snapshot 2 in your chapter on 
deletion (see [deletion 
diagram](https://camo.githubusercontent.com/a62928a140dbc4f71dc41354c16e1157709cc315e81080767718d3fd2bed1880/68747470733a2f2f7265732e636c6f7564696e6172792e636f6d2f73632d636c6f7564732f696d6167652f75706c6f61642f76313730333737323139392f73706563732f636c6f7564737461636b2f6b766d2d696e6372656d656e74616c2d736e617073686f74732f4e65775f496e6372656d656e74616c5f4261636b75705f44656c6574696f6e5f315f6f33663537682e706e67)
 ) the snapshot remains but becomes hidden because the DB entry is deleted. 
when the volume is completely deleted or the user want the create a snapshot, 
How will the 'hidden' increment be handled by cloudstack?
   
   @DaanHoogland, there will be no coalescing on the backend, except when the 
user decides to restore the snapshot (see section 2.2). Also, the DB entry will 
not be deleted, the entry on the `snapshots` table will be marked as destroyed, 
so that it is not listed, but the entry on `snapshot_store_ref` will remain, 
this way we will not lose the reference to where the snapshot is. 
   
   In your example, if the snapshots are on primary storage, when the volume is 
deleted, all of snapshots will get deleted as well (this is the current 
behavior); if the snapshots are on secondary storage, they will remain (this is 
also the current behavior), and the rules described in [deletion 
diagram](https://camo.githubusercontent.com/a62928a140dbc4f71dc41354c16e1157709cc315e81080767718d3fd2bed1880/68747470733a2f2f7265732e636c6f7564696e6172792e636f6d2f73632d636c6f7564732f696d6167652f75706c6f61642f76313730333737323139392f73706563732f636c6f7564737461636b2f6b766d2d696e6372656d656e74616c2d736e617073686f74732f4e65775f496e6372656d656e74616c5f4261636b75705f44656c6574696f6e5f315f6f33663537682e706e67)
 still apply. 
   
   About the snapshot creation after the user deletes one of the snapshots in 
the middle of the chain, this will not have any relevant effect. The snapshot 
can still be created as usual (all the files are unchanged); the size of the 
snapshot chain will be calculated using the `parent_snapshot_id` column on 
`snapshot_store_ref` (which, as explained before, will not be affected by the 
snapshot deletion on this case). The snapshot chain size calculation is 
actually already implemented in the code for Xen (see 
   
https://github.com/apache/cloudstack/blob/8ff2c018cc5b3fc69bcd8756695d04b384e46ab8/engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/DefaultSnapshotStrategy.java#L152)
 we can use a similar logic for the KVM implementation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fixup resource limit checks [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8935:
URL: https://github.com/apache/cloudstack/pull/8935#issuecomment-2070121038

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 9364


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [Ready for review] New feature: Import DATA volume from storage pool [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8808:
URL: https://github.com/apache/cloudstack/pull/8808#issuecomment-2070091615

   @weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) 
has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [Ready for review] New feature: Import DATA volume from storage pool [cloudstack]

2024-04-22 Thread via GitHub


weizhouapache commented on PR #8808:
URL: https://github.com/apache/cloudstack/pull/8808#issuecomment-2070083656

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Cloudstack API end point getting failed while deploying nginx as loadbalancer on kubernetes [cloudstack]

2024-04-22 Thread via GitHub


PaX101 commented on issue #8936:
URL: https://github.com/apache/cloudstack/issues/8936#issuecomment-2070076831

   We are experiensing the same issue, it looks to be the same issue as 4.18 
where the pages would take a very long time to load where they were pulling all 
data instead of what was needed. The command causing this slowness is:
   
   
https://my.url.com/client/api?apiKey=myapikeyhere=listVirtualMachines=true=json=mysignature
   
   If i run this command in a browser the API takes around 5-10 minutes to load 
it, however is i try to run normal commands on the API such as 
listVirtualMachinesMetrics it is instant.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] New feature: Implicit host tags [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8929:
URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2070062584

   @weizhouapache a [SL] Trillian-Jenkins matrix job (centos7 mgmt + 
xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been 
kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] New feature: Implicit host tags [cloudstack]

2024-04-22 Thread via GitHub


weizhouapache commented on PR #8929:
URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2070058028

   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix KVM live migration with NFS volumes [cloudstack]

2024-04-22 Thread via GitHub


weizhouapache commented on PR #8952:
URL: https://github.com/apache/cloudstack/pull/8952#issuecomment-2070054908

   
   > @weizhouapache A `LinkedHashSet` is an ordered version of `HashSet`, 
considering that we don't care for order in this case, the `HashSet` should be 
better (as we won't have the ordering overhead). 
   
   ok makes sense


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(cloudstack-www) branch main updated (9f19b79c -> 7fdcc9f2)

2024-04-22 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git


from 9f19b79c headings (#206)
 add f12e5aa5 smaller headings (#207)
 add 7fdcc9f2 one last header (#208)

No new revisions were added by this update.

Summary of changes:
 blog/2024-04-22-apache-coceu-2024/index.md | 14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)



(cloudstack-www) branch staging-site updated: one last header (#208)

2024-04-22 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch staging-site
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git


The following commit(s) were added to refs/heads/staging-site by this push:
 new 7fdcc9f2 one last header (#208)
7fdcc9f2 is described below

commit 7fdcc9f2977115592e9699dc426cb9b5d93d0ec3
Author: dahn 
AuthorDate: Mon Apr 22 17:22:16 2024 +0200

one last header (#208)
---
 blog/2024-04-22-apache-coceu-2024/index.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/blog/2024-04-22-apache-coceu-2024/index.md 
b/blog/2024-04-22-apache-coceu-2024/index.md
index a7fcecdd..edb1cdd7 100644
--- a/blog/2024-04-22-apache-coceu-2024/index.md
+++ b/blog/2024-04-22-apache-coceu-2024/index.md
@@ -70,7 +70,7 @@ This presentation will address the design and efforts of the 
ACS
 community to implement a native rating feature that will allow more
 flexibility and reduce the need for external systems.
 
-### Importing KVM instances from external KVM hosts or QCOW2, [Andrija 
Panić](https://www.linkedin.com/in/andrijapanic/) – Tuesday 4th at 14:40 – 
15:10 (Harmony 1)
+## Importing KVM instances from external KVM hosts or QCOW2, [Andrija 
Panić](https://www.linkedin.com/in/andrijapanic/) – Tuesday 4th at 14:40 – 
15:10 (Harmony 1)
 
 CloudStack recently introduced a few hypervisor migration features, to
 help cloud operators migrate existing VM workloads into CloudStack. In



Re: [PR] Fixup resource limit checks [cloudstack]

2024-04-22 Thread via GitHub


vishesh92 commented on PR #8935:
URL: https://github.com/apache/cloudstack/pull/8935#issuecomment-2069865236

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fixup resource limit checks [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8935:
URL: https://github.com/apache/cloudstack/pull/8935#issuecomment-2069867413

   @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(cloudstack-www) branch staging-site updated: smaller headings (#207)

2024-04-22 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch staging-site
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git


The following commit(s) were added to refs/heads/staging-site by this push:
 new f12e5aa5 smaller headings (#207)
f12e5aa5 is described below

commit f12e5aa55e4d2447477ccb2dfd95dc649828fff4
Author: dahn 
AuthorDate: Mon Apr 22 17:14:49 2024 +0200

smaller headings (#207)
---
 blog/2024-04-22-apache-coceu-2024/index.md | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/blog/2024-04-22-apache-coceu-2024/index.md 
b/blog/2024-04-22-apache-coceu-2024/index.md
index d098927a..a7fcecdd 100644
--- a/blog/2024-04-22-apache-coceu-2024/index.md
+++ b/blog/2024-04-22-apache-coceu-2024/index.md
@@ -42,12 +42,12 @@ href="https://eu.communityovercode.org/schedule/; 
target="_blank">Event Schedule
 Below you can find a list of all the sessions about Apache CloudStack
 – all of which will be held by Apache CloudStack community members.
 
-### What’s New in CloudStack, [Boris 
Stoyanov](https://www.linkedin.com/in/bstoyanov/) – Monday 3rd at 13:20 – 13:50 
(Harmony 3)
+## What’s New in CloudStack, [Boris 
Stoyanov](https://www.linkedin.com/in/bstoyanov/) – Monday 3rd at 13:20 – 13:50 
(Harmony 3)
 
 In this session, CloudStack PMC Member Boris will be covering the
 latest major features in Apache CloudStack over the past few releases.
 
-### Transitioning from VMware to Apache CloudStack: A Path to Profitability 
and Competitiveness, [Marco Sinhoreli](https://www.linkedin.com/in/msinhore/) – 
Tuesday 4th at 12:30 – 13:00 (Harmony 1) 
+## Transitioning from VMware to Apache CloudStack: A Path to Profitability 
and Competitiveness, [Marco Sinhoreli](https://www.linkedin.com/in/msinhore/) – 
Tuesday 4th at 12:30 – 13:00 (Harmony 1) 
 
 In this session, Marco will explore the potential of migrating from
 VMware to Apache CloudStack with KVM. VMware vSphere is a robust cloud
@@ -64,7 +64,7 @@ profitability, and enhance competitiveness. He will also 
cover the
 practical steps and considerations in planning and executing this
 transition effectively.
 
-### Making Apache CloudStack market ready with a native rating 
solution,[Daniel Salvador](https://www.linkedin.com/in/gutoveronezi/),[Bryan 
Lima](https://www.linkedin.com/in/bryan-lima/), [João 
Paraquetti](https://www.linkedin.com/in/jo%C3%A3o-jandre-136a32159/),[Rafael 
Weingärtner](http://cloudstack.apache.org) – Tuesday 4th at 14:00 – 14:30 
(Harmony 1)
+## Making Apache CloudStack market ready with a native rating 
solution,[Daniel Salvador](https://www.linkedin.com/in/gutoveronezi/),[Bryan 
Lima](https://www.linkedin.com/in/bryan-lima/), [João 
Paraquetti](https://www.linkedin.com/in/jo%C3%A3o-jandre-136a32159/),[Rafael 
Weingärtner](http://cloudstack.apache.org) – Tuesday 4th at 14:00 – 14:30 
(Harmony 1)
 
 This presentation will address the design and efforts of the ACS
 community to implement a native rating feature that will allow more
@@ -79,7 +79,7 @@ external KVM hosts to KVM hosts managed by CloudStack. 
Andrija will
 also show how you can quickly deploy an instance from a previously
 prepared qcow2 image.
 
-### Incremental snapshots/backups in KVM plugin of Apache CloudStack, [Daniel 
Salvador](https://www.linkedin.com/in/gutoveronezi/), [Bryan 
Lima](https://www.linkedin.com/in/bryan-lima/), [João 
Paraquetti](https://www.linkedin.com/in/jo%C3%A3o-jandre-136a32159/),[Rafael 
Weingärtner](http://cloudstack.apache.org) – Tuesday 4th at 15:20 – 15:50 
(Harmony 1)
+## Incremental snapshots/backups in KVM plugin of Apache CloudStack, 
[Daniel Salvador](https://www.linkedin.com/in/gutoveronezi/), [Bryan 
Lima](https://www.linkedin.com/in/bryan-lima/), [João 
Paraquetti](https://www.linkedin.com/in/jo%C3%A3o-jandre-136a32159/),[Rafael 
Weingärtner](http://cloudstack.apache.org) – Tuesday 4th at 15:20 – 15:50 
(Harmony 1)
 
 Apache CloudStack (ACS) and KVM are a combination that many
 organizations decided to adopt. KVM is a widely used hypervisor with a
@@ -95,7 +95,7 @@ address the design and efforts of the ACS community to support
 incremental snapshots/backups for the KVM plugin. Thus, creating a
 native backup solution in ACS that supports differential copies.
 
-### VNF Integration and Support in Apache CloudStack, [Wei 
Zhou](https://www.linkedin.com/in/wei-zhou-3635b633/) – Tuesday 4th at 16:10 – 
16:40 (Harmony 1)
+## VNF Integration and Support in Apache CloudStack, [Wei 
Zhou](https://www.linkedin.com/in/wei-zhou-3635b633/) – Tuesday 4th at 16:10 – 
16:40 (Harmony 1)
 
 In this session, Wei will present how CloudStack 4.19 adds the
 capability to easily and quickly perform a light-touch integration of
@@ -104,7 +104,7 @@ and end users to offer a broader range of networking 
services while
 empowering end-users to effortlessly deploy their own virtualized
 network functions (VNFs).
 
-### SDN Options in Apache 

(cloudstack-www) branch staging-site updated: headings (#206)

2024-04-22 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch staging-site
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git


The following commit(s) were added to refs/heads/staging-site by this push:
 new 9f19b79c headings (#206)
9f19b79c is described below

commit 9f19b79c4bcc1175b7edb1afd04678d93ba67db4
Author: dahn 
AuthorDate: Mon Apr 22 16:56:05 2024 +0200

headings (#206)
---
 blog/2024-04-22-apache-coceu-2024/index.md | 16 +---
 1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/blog/2024-04-22-apache-coceu-2024/index.md 
b/blog/2024-04-22-apache-coceu-2024/index.md
index c5b46a9d..d098927a 100644
--- a/blog/2024-04-22-apache-coceu-2024/index.md
+++ b/blog/2024-04-22-apache-coceu-2024/index.md
@@ -64,18 +64,13 @@ profitability, and enhance competitiveness. He will also 
cover the
 practical steps and considerations in planning and executing this
 transition effectively.
 
-Making Apache CloudStack market ready with a native rating solution,
-[Daniel Salvador](https://www.linkedin.com/in/gutoveronezi/),
-[Bryan Lima](https://www.linkedin.com/in/bryan-lima/), [João 
Paraquetti](https://www.linkedin.com/in/jo%C3%A3o-jandre-136a32159/),
-[Rafael Weingärtner]((http://cloudstack.apache.org) – Tuesday 4th at 14:00 – 
14:30 (Harmony 1)
+### Making Apache CloudStack market ready with a native rating 
solution,[Daniel Salvador](https://www.linkedin.com/in/gutoveronezi/),[Bryan 
Lima](https://www.linkedin.com/in/bryan-lima/), [João 
Paraquetti](https://www.linkedin.com/in/jo%C3%A3o-jandre-136a32159/),[Rafael 
Weingärtner](http://cloudstack.apache.org) – Tuesday 4th at 14:00 – 14:30 
(Harmony 1)
 
 This presentation will address the design and efforts of the ACS
 community to implement a native rating feature that will allow more
 flexibility and reduce the need for external systems.
 
-
-
-Importing KVM instances from external KVM hosts or QCOW2, [Andrija 
Panić](https://www.linkedin.com/in/andrijapanic/) – Tuesday 4th at 14:40 – 
15:10 (Harmony 1)
+### Importing KVM instances from external KVM hosts or QCOW2, [Andrija 
Panić](https://www.linkedin.com/in/andrijapanic/) – Tuesday 4th at 14:40 – 
15:10 (Harmony 1)
 
 CloudStack recently introduced a few hypervisor migration features, to
 help cloud operators migrate existing VM workloads into CloudStack. In
@@ -84,8 +79,7 @@ external KVM hosts to KVM hosts managed by CloudStack. 
Andrija will
 also show how you can quickly deploy an instance from a previously
 prepared qcow2 image.
 
-Incremental snapshots/backups in KVM plugin of Apache CloudStack, [Daniel 
Salvador](https://www.linkedin.com/in/gutoveronezi/), [Bryan 
Lima](https://www.linkedin.com/in/bryan-lima/), [João 
Paraquetti](https://www.linkedin.com/in/jo%C3%A3o-jandre-136a32159/),
-[Rafael Weingärtner](http://cloudstack.apache.org) – Tuesday 4th at 15:20 – 
15:50 (Harmony 1)
+### Incremental snapshots/backups in KVM plugin of Apache CloudStack, [Daniel 
Salvador](https://www.linkedin.com/in/gutoveronezi/), [Bryan 
Lima](https://www.linkedin.com/in/bryan-lima/), [João 
Paraquetti](https://www.linkedin.com/in/jo%C3%A3o-jandre-136a32159/),[Rafael 
Weingärtner](http://cloudstack.apache.org) – Tuesday 4th at 15:20 – 15:50 
(Harmony 1)
 
 Apache CloudStack (ACS) and KVM are a combination that many
 organizations decided to adopt. KVM is a widely used hypervisor with a
@@ -101,7 +95,7 @@ address the design and efforts of the ACS community to 
support
 incremental snapshots/backups for the KVM plugin. Thus, creating a
 native backup solution in ACS that supports differential copies.
 
-VNF Integration and Support in Apache CloudStack, [Wei 
Zhou](https://www.linkedin.com/in/wei-zhou-3635b633/) – Tuesday 4th at 16:10 – 
16:40 (Harmony 1) 
+### VNF Integration and Support in Apache CloudStack, [Wei 
Zhou](https://www.linkedin.com/in/wei-zhou-3635b633/) – Tuesday 4th at 16:10 – 
16:40 (Harmony 1)
 
 In this session, Wei will present how CloudStack 4.19 adds the
 capability to easily and quickly perform a light-touch integration of
@@ -110,7 +104,7 @@ and end users to offer a broader range of networking 
services while
 empowering end-users to effortlessly deploy their own virtualized
 network functions (VNFs).
 
-SDN Options in Apache CloudStack, [Alexandre 
Mattioli](https://www.linkedin.com/in/alexandremattiolibastos/) – Tuesday 4th 
at 16:50 – 17:20 (Harmony 1)
+### SDN Options in Apache CloudStack, [Alexandre 
Mattioli](https://www.linkedin.com/in/alexandremattiolibastos/) – Tuesday 4th 
at 16:50 – 17:20 (Harmony 1)
 
 Apache CloudStack integrates with two major SDN solutions, Tungsten
 Fabric (OpenSDN) for KVM environments and NSX for VMWare ESX



(cloudstack-www) branch main updated (c2b2032b -> 9f19b79c)

2024-04-22 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git


from c2b2032b Update users.mdx (#198)
 add 42363d96 initial blog (#205)
 add b0e2b334 remove garbage
 add 9f19b79c headings (#206)

No new revisions were added by this update.

Summary of changes:
 blog/2024-04-22-apache-coceu-2024/banner.png | Bin 0 -> 616125 bytes
 blog/2024-04-22-apache-coceu-2024/index.md   | 113 +++
 2 files changed, 113 insertions(+)
 create mode 100644 blog/2024-04-22-apache-coceu-2024/banner.png
 create mode 100644 blog/2024-04-22-apache-coceu-2024/index.md



Re: [I] problem on adding new node to kubernetes [cloudstack]

2024-04-22 Thread via GitHub


ugenk commented on issue #8943:
URL: https://github.com/apache/cloudstack/issues/8943#issuecomment-2069758061

   The exception originates from here:
   
https://github.com/apache/cloudstack/blob/4.19.0.1/plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterResourceModifierActionWorker.java#L520
   Has it been addressed in https://github.com/apache/cloudstack/pull/8107


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(cloudstack-www) branch staged-site updated: Automated CloudStack https://cloudstack.staged.apache.org staging website deployment with cloudstack-www branch @ b0e2b3342f2901615a850abbb23c00ba9ac7c329

2024-04-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository.

github-bot pushed a commit to branch staged-site
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git


The following commit(s) were added to refs/heads/staged-site by this push:
 new 57410a87 Automated CloudStack https://cloudstack.staged.apache.org 
staging website deployment with cloudstack-www branch @ 
b0e2b3342f2901615a850abbb23c00ba9ac7c329
57410a87 is described below

commit 57410a872f51e1a8a2cce4e61cc6d1dfc6a749b8
Author: github-actions[bot] 
AuthorDate: Mon Apr 22 14:43:19 2024 +

Automated CloudStack https://cloudstack.staged.apache.org staging website 
deployment with cloudstack-www branch @ b0e2b3342f2901615a850abbb23c00ba9ac7c329
---
 search-index.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/search-index.json b/search-index.json
index ff2f145a..a36ed103 100644
--- a/search-index.json
+++ b/search-index.json
@@ -1 +1 @@
-[{"documents":[{"i":1,"t":"About Apache 
CloudStack","u":"/about","b":[]},{"i":2,"t":"Apache CloudStack API 
Documentation","u":"/api","b":[]},{"i":4,"t":"4.1.0 VOTE in Progress: Testers 
Welcome!","u":"/blog/4_1_0_vote_in","b":[]},{"i":6,"t":"Archived 
Releases","u":"/archives","b":[]},{"i":8,"t":"[ADVISORY] Apache CloudStack 
Advisory on KVM Shared Mount Point issues on version 
4.17.0.0","u":"/blog/advisory-apache-cloudstack-advisory-on","b":[]},{"i":10,"t":"[ANNOUNCE]
 Announcing Apache Clo [...]
\ No newline at end of file
+[{"documents":[{"i":1,"t":"Apache CloudStack API 
Documentation","u":"/api","b":[]},{"i":3,"t":"About Apache 
CloudStack","u":"/about","b":[]},{"i":4,"t":"Archived 
Releases","u":"/archives","b":[]},{"i":6,"t":"4.1.0 VOTE in Progress: Testers 
Welcome!","u":"/blog/4_1_0_vote_in","b":[]},{"i":8,"t":"[ADVISORY] Apache 
CloudStack Advisory on KVM Shared Mount Point issues on version 
4.17.0.0","u":"/blog/advisory-apache-cloudstack-advisory-on","b":[]},{"i":10,"t":"[ANNOUNCE]
 Announcing Apache Clo [...]
\ No newline at end of file



(cloudstack-www) branch staging-site updated: remove garbage

2024-04-22 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch staging-site
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git


The following commit(s) were added to refs/heads/staging-site by this push:
 new b0e2b334 remove garbage
b0e2b334 is described below

commit b0e2b3342f2901615a850abbb23c00ba9ac7c329
Author: Daan Hoogland 
AuthorDate: Mon Apr 22 16:41:18 2024 +0200

remove garbage
---
 blog/2024-04-22-apache-coceu-2024/index.md~ | 23 ---
 1 file changed, 23 deletions(-)

diff --git a/blog/2024-04-22-apache-coceu-2024/index.md~ 
b/blog/2024-04-22-apache-coceu-2024/index.md~
deleted file mode 100644
index ab40edff..
--- a/blog/2024-04-22-apache-coceu-2024/index.md~
+++ /dev/null
@@ -1,23 +0,0 @@

-layout: post
-title: Apache Community over Code 2024 – June 3rd-5th, Bratislava, Slovakia
-tags: [news]
-authors: [jamie]
-slug: coceu-2024

-
-
-![](banner.png "Blog Header Image")
-
-On 3-5th June, the [Apache Software
-Foundation](https://www.apache.org) will be holding the annual
-[Community Over Code EU](https://eu.communityovercode.org/)
-conference. This year, attendees can anticipate engaging sessions led
-by Apache CloudStack community members at the event. It serves as a
-prime platform to stay aware of the newest developments within Apache
-Software Foundation (ASF) projects and their associated
-communities. Taking place in the charming city of Bratislava,
-Slovakia, this event fosters an environment conducive to
-collaborative, vendor-neutral discussions. Open-source communities
-from across the globe will converge to freely exchange ideas and
-strategize on various projects.
\ No newline at end of file



Re: [I] Wrong resource usage often reported in multiple area [cloudstack]

2024-04-22 Thread via GitHub


levindecaro commented on issue #8927:
URL: https://github.com/apache/cloudstack/issues/8927#issuecomment-2069675672

   @rajujith i did, but doesn't help


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Enhance Redundant Virtual Routers to 3 Routers, with RAFT Algorithm (or similar) [cloudstack]

2024-04-22 Thread via GitHub


btzq commented on issue #8954:
URL: https://github.com/apache/cloudstack/issues/8954#issuecomment-2069641008

   Okay noted, we havent had any Master/Master issues because we completely 
removed the redundancy as it gave us more predictability. 
   
   But are there any tests we can run to ensure our networks are configured 
correctly? 
   
   Also, what should i do with this feature request? Do i close it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2069563893

   [SF] Trillian Build Failed (tid-9956)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix KVM live migration with NFS volumes [cloudstack]

2024-04-22 Thread via GitHub


JoaoJandre commented on PR #8952:
URL: https://github.com/apache/cloudstack/pull/8952#issuecomment-2069552668

   > > > > @JoaoJandre will you back to 4.18 ? (I am not sure if there will be 
4.18.3.0)
   > > > 
   > > > 
   > > > @JoaoJandre , we can merge as is or merge to 4.18 and merge forward. 
For anybody doing custom maintenance that will be convenient. Just say yes or 
no... ;)
   > > 
   > > 
   > > @DaanHoogland @weizhouapache I don't think we'll have a 4.18.3.0, but 
I've rebased anyway.
   > 
   > @JoaoJandre thanks for rebasing
   > 
   > although it worked in my testing, I wonder if `LinkedHashSet` is better 
than `HashSet`
   
   @weizhouapache A `LinkedHashSet` is an ordered version of `HashSet`, 
considering that we don't care for order in this case, the `HashSet` should be 
better (as we won't have the ordering overhead). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(cloudstack-go) 01/01: Merge pull request #82 from apache/dependabot/go_modules/golang.org/x/net-0.23.0

2024-04-22 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack-go.git

commit cfcbcba8e4bfb3e855daa248ce2dc324a25c6e05
Merge: 9ebea3b 1af5124
Author: dahn 
AuthorDate: Mon Apr 22 15:56:27 2024 +0200

Merge pull request #82 from 
apache/dependabot/go_modules/golang.org/x/net-0.23.0

Bump golang.org/x/net from 0.17.0 to 0.23.0

 go.mod |  6 +++---
 go.sum | 20 
 2 files changed, 15 insertions(+), 11 deletions(-)



(cloudstack-go) branch main updated (9ebea3b -> cfcbcba)

2024-04-22 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack-go.git


from 9ebea3b  Merge pull request #81 from 
step-security-bot/stepsecurity_remediation_1711185908
 add 1af5124  Bump golang.org/x/net from 0.17.0 to 0.23.0
 new cfcbcba  Merge pull request #82 from 
apache/dependabot/go_modules/golang.org/x/net-0.23.0

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 go.mod |  6 +++---
 go.sum | 20 
 2 files changed, 15 insertions(+), 11 deletions(-)



(cloudstack-go) branch dependabot/go_modules/golang.org/x/net-0.23.0 deleted (was 1af5124)

2024-04-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository.

github-bot pushed a change to branch 
dependabot/go_modules/golang.org/x/net-0.23.0
in repository https://gitbox.apache.org/repos/asf/cloudstack-go.git


 was 1af5124  Bump golang.org/x/net from 0.17.0 to 0.23.0

The revisions that were on this branch are still contained in
other references; therefore, this change does not discard any commits
from the repository.



Re: [PR] pre-commit: add hook to trim trailing whitespace [cloudstack]

2024-04-22 Thread via GitHub


codecov-commenter commented on PR #8205:
URL: https://github.com/apache/cloudstack/pull/8205#issuecomment-2069438074

   ## 
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8205?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 31.16%. Comparing base 
[(`cadbb56`)](https://app.codecov.io/gh/apache/cloudstack/commit/cadbb563afaa907a45e8931cb8a95e8ca5b8f034?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 to head 
[(`9177024`)](https://app.codecov.io/gh/apache/cloudstack/pull/8205?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   > Report is 88 commits behind head on main.
   
   > :exclamation: Current head 9177024 differs from pull request most recent 
head 8b3d91f. Consider uploading reports for the commit 8b3d91f to get more 
accurate results
   
   
   Additional details and impacted files
   
   
   ```diff
   @@  Coverage Diff  @@
   ##   main#8205   +/-   ##
   =
   + Coverage 15.13%   31.16%   +16.02% 
   - Complexity1346934041+20572 
   =
 Files  4863 5404  +541 
 Lines326031   380305+54274 
 Branches  4583855506 +9668 
   =
   + Hits  49349   118524+69175 
   + Misses   270066   246077-23989 
   - Partials   661615704 +9088 
   ```
   
   | 
[Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8205/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8205/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | `24.93% <ø> (+9.80%)` | :arrow_up: |
   | 
[uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8205/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | `4.34% <ø> (?)` | |
   | 
[unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8205/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | `16.88% <ø> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8205?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] New feature: Implicit host tags [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8929:
URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2069396819

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9363


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [UI] Add option to specify account/project while deploying VMs [cloudstack]

2024-04-22 Thread via GitHub


KlausDornsbach commented on PR #8919:
URL: https://github.com/apache/cloudstack/pull/8919#issuecomment-2069312253

   lgtm, also tested manipulating the VMs in the user end in both domain and 
project scopes and it is working fine.
   Tested stopping, resuming, rebooting, scaling and deleting


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix KVM live migration with NFS volumes [cloudstack]

2024-04-22 Thread via GitHub


weizhouapache commented on PR #8952:
URL: https://github.com/apache/cloudstack/pull/8952#issuecomment-2069310150

   > > > @JoaoJandre will you back to 4.18 ? (I am not sure if there will be 
4.18.3.0)
   > > 
   > > 
   > > @JoaoJandre , we can merge as is or merge to 4.18 and merge forward. For 
anybody doing custom maintenance that will be convenient. Just say yes or no... 
;)
   > 
   > @DaanHoogland @weizhouapache I don't think we'll have a 4.18.3.0, but I've 
rebased anyway.
   
   @JoaoJandre 
   thanks for rebasing
   
   although it worked in my testing, I wonder if `LinkedHashSet` is better than 
`HashSet`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Change storage pool scope from Cluster to Zone and vise versa [cloudstack]

2024-04-22 Thread via GitHub


abh1sar commented on code in PR #8875:
URL: https://github.com/apache/cloudstack/pull/8875#discussion_r1574654750


##
ui/src/views/infra/changeStoragePoolScope.vue:
##
@@ -0,0 +1,226 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+
+  
+
+  
+
+  
+
+  
+
+  
+  
+
+  
+
+  

Review Comment:
   Its working :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Change storage pool scope from Cluster to Zone and vise versa [cloudstack]

2024-04-22 Thread via GitHub


github-actions[bot] commented on PR #8875:
URL: https://github.com/apache/cloudstack/pull/8875#issuecomment-2069250234

   This pull request has merge conflicts. Dear author, please fix the conflicts 
and sync your branch with the base branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] New feature: Implicit host tags [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8929:
URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2069218374

   @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will 
be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] New feature: Implicit host tags [cloudstack]

2024-04-22 Thread via GitHub


codecov-commenter commented on PR #8929:
URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2069249026

   ## 
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8929?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 Report
   Attention: Patch coverage is `25.53191%` with `70 lines` in your changes are 
missing coverage. Please review.
   > Project coverage is 15.05%. Comparing base 
[(`a5508ac`)](https://app.codecov.io/gh/apache/cloudstack/commit/a5508acc54d1638ba469f4d7ce9898b81b5209d0?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 to head 
[(`232a982`)](https://app.codecov.io/gh/apache/cloudstack/pull/8929?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   > Report is 585 commits behind head on main.
   
   | 
[Files](https://app.codecov.io/gh/apache/cloudstack/pull/8929?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | Patch % | Lines |
   |---|---|---|
   | 
[.../main/java/com/cloud/host/dao/HostTagsDaoImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/8929?src=pr=tree=engine%2Fschema%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fhost%2Fdao%2FHostTagsDaoImpl.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9ob3N0L2Rhby9Ib3N0VGFnc0Rhb0ltcGwuamF2YQ==)
 | 27.69% | [44 Missing and 3 partials :warning: 
](https://app.codecov.io/gh/apache/cloudstack/pull/8929?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 |
   | 
[...ervisor/kvm/resource/LibvirtComputingResource.java](https://app.codecov.io/gh/apache/cloudstack/pull/8929?src=pr=tree=plugins%2Fhypervisors%2Fkvm%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fhypervisor%2Fkvm%2Fresource%2FLibvirtComputingResource.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydENvbXB1dGluZ1Jlc291cmNlLmphdmE=)
 | 0.00% | [7 Missing :warning: 
](https://app.codecov.io/gh/apache/cloudstack/pull/8929?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 |
   | 
[...pache/cloudstack/api/response/HostTagResponse.java](https://app.codecov.io/gh/apache/cloudstack/pull/8929?src=pr=tree=api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcloudstack%2Fapi%2Fresponse%2FHostTagResponse.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2FwaS9yZXNwb25zZS9Ib3N0VGFnUmVzcG9uc2UuamF2YQ==)
 | 0.00% | [3 Missing :warning: 
](https://app.codecov.io/gh/apache/cloudstack/pull/8929?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 |
   | 
[...schema/src/main/java/com/cloud/host/HostTagVO.java](https://app.codecov.io/gh/apache/cloudstack/pull/8929?src=pr=tree=engine%2Fschema%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fhost%2FHostTagVO.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9ob3N0L0hvc3RUYWdWTy5qYXZh)
 | 25.00% | [3 Missing :warning: 
](https://app.codecov.io/gh/apache/cloudstack/pull/8929?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 |
   | 
[...ain/java/com/cloud/api/query/QueryManagerImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/8929?src=pr=tree=server%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fapi%2Fquery%2FQueryManagerImpl.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2FwaS9xdWVyeS9RdWVyeU1hbmFnZXJJbXBsLmphdmE=)
 | 0.00% | [3 Missing :warning: 
](https://app.codecov.io/gh/apache/cloudstack/pull/8929?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 |
   | 
[...udstack/api/response/HostForMigrationResponse.java](https://app.codecov.io/gh/apache/cloudstack/pull/8929?src=pr=tree=api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcloudstack%2Fapi%2Fresponse%2FHostForMigrationResponse.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2FwaS9yZXNwb25zZS9Ib3N0Rm9yTWlncmF0aW9uUmVzcG9uc2UuamF2YQ==)
 | 0.00% | [2 Missing :warning: 
](https://app.codecov.io/gh/apache/cloudstack/pull/8929?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 |
   | 

Re: [PR] Fix KVM live migration with NFS volumes [cloudstack]

2024-04-22 Thread via GitHub


JoaoJandre commented on PR #8952:
URL: https://github.com/apache/cloudstack/pull/8952#issuecomment-2069239277

   > > @JoaoJandre will you back to 4.18 ? (I am not sure if there will be 
4.18.3.0)
   > 
   > @JoaoJandre , we can merge as is or merge to 4.18 and merge forward. For 
anybody doing custom maintenance that will be convenient. Just say yes or no... 
;)
   
   @DaanHoogland @weizhouapache I don't think we'll have a 4.18.3.0, but I've 
rebased anyway.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[I] Unable to Secure CloudStack System VMs with Dynamic URL [cloudstack]

2024-04-22 Thread via GitHub


vishnuvs369 opened a new issue, #8957:
URL: https://github.com/apache/cloudstack/issues/8957

   # ISSUE TYPE
   * Other
   
   # COMPONENT NAME
   
   ~~~
   
   ~~~
   
   # CLOUDSTACK VERSION
   
   
   ~~~
   
   ~~~
   
   
   
   # SUMMARY
   
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(cloudstack-go) branch main updated (f763951 -> 9ebea3b)

2024-04-22 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack-go.git


from f763951  Restore methods with optional params for 4.19 compatability 
(#80)
 add ddff197  [StepSecurity] ci: Harden GitHub Actions
 new 9ebea3b  Merge pull request #81 from 
step-security-bot/stepsecurity_remediation_1711185908

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .github/workflows/build.yml | 3 +++
 1 file changed, 3 insertions(+)



(cloudstack-go) 01/01: Merge pull request #81 from step-security-bot/stepsecurity_remediation_1711185908

2024-04-22 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack-go.git

commit 9ebea3b44acd8e7e6d59687206844c3d0c64fa86
Merge: f763951 ddff197
Author: dahn 
AuthorDate: Mon Apr 22 13:54:34 2024 +0200

Merge pull request #81 from 
step-security-bot/stepsecurity_remediation_1711185908

[StepSecurity] ci: Harden GitHub Actions

 .github/workflows/build.yml | 3 +++
 1 file changed, 3 insertions(+)



Re: [PR] New feature: Implicit host tags [cloudstack]

2024-04-22 Thread via GitHub


weizhouapache commented on PR #8929:
URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2069216220

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [Ready for review] New feature: Import DATA volume from storage pool [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8808:
URL: https://github.com/apache/cloudstack/pull/8808#issuecomment-2069210985

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9362


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Wrong resource usage often reported in multiple area [cloudstack]

2024-04-22 Thread via GitHub


rajujith commented on issue #8927:
URL: https://github.com/apache/cloudstack/issues/8927#issuecomment-2069208868

   @levindecaro  have you tried updating resource count for the account after 
deleting the VM as a workaround? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2069198525

   [SF] Trillian Build Failed (tid-9955)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Change storage pool scope from Cluster to Zone and vise versa [cloudstack]

2024-04-22 Thread via GitHub


shwstppr commented on code in PR #8875:
URL: https://github.com/apache/cloudstack/pull/8875#discussion_r1574592360


##
ui/src/views/infra/changeStoragePoolScope.vue:
##
@@ -0,0 +1,226 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+
+  
+
+  
+
+  
+
+  
+
+  
+  
+
+  
+
+  

Review Comment:
   Not sure but can it be something like,
   ```
 
   
 
   
 
   ```
   
   Need to check this actually works :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] on forName validate packages of classes to load [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-2069137713

   @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) 
has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] on forName validate packages of classes to load [cloudstack]

2024-04-22 Thread via GitHub


DaanHoogland commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-2069133249

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] KVM: enable no-mac-spoofing on virtual nics [cloudstack]

2024-04-22 Thread via GitHub


DaanHoogland commented on PR #8951:
URL: https://github.com/apache/cloudstack/pull/8951#issuecomment-2069129882

   > actually I am thinking of disabling this change for vms with security 
groups
   
   I second that. It will be simpler and the will not cripple the much security 
groups implementation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Change storage pool scope from Cluster to Zone and vise versa [cloudstack]

2024-04-22 Thread via GitHub


DaanHoogland commented on code in PR #8875:
URL: https://github.com/apache/cloudstack/pull/8875#discussion_r1574579125


##
test/integration/smoke/test_primary_storage.py:
##
@@ -363,6 +363,151 @@ def test_01_add_primary_storage_disabled_host(self):
 return
 
 
+class TestPrimaryStorageScope(cloudstackTestCase):

Review Comment:
   I see your point and want to add that for maintainability it is preferable 
to have a single test class per file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]

2024-04-22 Thread via GitHub


DaanHoogland commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2069121983

   @weizhouapache , as admin user I can not register an iso : 
   
![image](https://github.com/apache/cloudstack/assets/2486961/7089e8d9-ff93-458b-b51e-2a6653a2675e)
   not sure if this is related.
   as a normal user I don't even get to the overview : 
   
![image](https://github.com/apache/cloudstack/assets/2486961/18ec869f-ec60-4d2a-8a4b-a7b6e07698d6)
   as shown in the image , the user doesn't even get the button to register the 
iso.
   
   FYI, haven't investigated this yet:
   
   ```
   2024-04-22 11:02:55,541 ERROR [c.c.a.ApiServer] 
(qtp239372207-16:ctx-cc15c2af ctx-2969dc60) (logid:3e39b3ff) unhandled 
exception executing api command: [Ljava.lang.String;@4eefc745
   java.lang.NullPointerException
   at 
com.cloud.kubernetes.version.KubernetesVersionManagerImpl.createKubernetesSupportedVersionResponse(KubernetesVersionManagerImpl.java:107)
   at 
com.cloud.kubernetes.version.KubernetesVersionManagerImpl.createKubernetesSupportedVersionListResponse(KubernetesVersionManagerImpl.java:117)
   at 
com.cloud.kubernetes.version.KubernetesVersionManagerImpl.listKubernetesSupportedVersions(KubernetesVersionManagerImpl.java:278)
   at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   at java.base/java.lang.reflect.Method.invoke(Method.java:566)
   at 
org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344)
   at 
org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198)
   at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
   at 
org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
   at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
   at 
org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215)
   at com.sun.proxy.$Proxy439.listKubernetesSupportedVersions(Unknown 
Source)
   at 
org.apache.cloudstack.api.command.user.kubernetes.version.ListKubernetesSupportedVersionsCmd.execute(ListKubernetesSupportedVersionsCmd.java:99)
   at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:163)
   at com.cloud.api.ApiServer.queueCommand(ApiServer.java:803)
   at com.cloud.api.ApiServer.handleRequest(ApiServer.java:624)
   at 
com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:342)
   at com.cloud.api.ApiServlet$1.run(ApiServlet.java:149)
   at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:55)
   at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:102)
   at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:52)
   at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:146)
   at com.cloud.api.ApiServlet.doGet(ApiServlet.java:100)
   at javax.servlet.http.HttpServlet.service(HttpServlet.java:645)
   at javax.servlet.http.HttpServlet.service(HttpServlet.java:750)
   at 
org.eclipse.jetty.servlet.ServletHolder$NotAsync.service(ServletHolder.java:1450)
   at 
org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:799)
   at 
org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:554)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [Ready for review] New feature: Import DATA volume from storage pool [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8808:
URL: https://github.com/apache/cloudstack/pull/8808#issuecomment-2069081478

   @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will 
be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [Ready for review] New feature: Import DATA volume from storage pool [cloudstack]

2024-04-22 Thread via GitHub


weizhouapache commented on PR #8808:
URL: https://github.com/apache/cloudstack/pull/8808#issuecomment-2069077518

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [Ready for review] New feature: Import DATA volume from storage pool [cloudstack]

2024-04-22 Thread via GitHub


weizhouapache commented on PR #8808:
URL: https://github.com/apache/cloudstack/pull/8808#issuecomment-2069077421

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] on forName validate packages of classes to load [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-2069074158

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9361


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] test: fix unknown parameter hostid in test_vm_life_cycle.py [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8948:
URL: https://github.com/apache/cloudstack/pull/8948#issuecomment-2069057909

   @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + xenserver-71) 
has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] KVM: enable no-mac-spoofing on virtual nics [cloudstack]

2024-04-22 Thread via GitHub


weizhouapache commented on PR #8951:
URL: https://github.com/apache/cloudstack/pull/8951#issuecomment-2069055435

   > > > My suggestion:
   > > > ```
   > > > * Enable this in Libvirt
   > > > 
   > > > * Remove functionality from security_group.py
   > > > ```
   > > 
   > > 
   > > meaning, @wido , this is good but we need to add a removal of some of 
the " -j DROP/ACCEPT" lines from the script? sounds like some precision 
surgery. Do you know which ones to drop? cc @weizhouapache .
   > 
   > It would, I think if you take a look it starts here:
   > 
   > 
https://github.com/apache/cloudstack/blob/8ff2c018cc5b3fc69bcd8756695d04b384e46ab8/scripts/vm/network/security_group.py#L280
   > 
   > * default_ebtables_rules()
   > * destroy_ebtables_rules()
   > 
   > Those would no longer be needed
   
   @wido 
   actually I am thinking of disabling this change for vms with security groups
   the script `security_group.py` programs iptables/ebtables rules including 
the mac/ip/arp anti-spoofing, it has been proved to be working well with both 
ipv4/ipv6 addresses and one/multiple network nics.
   this PR only contains `no-mac-spoofing` which is not good enough to replace 
the `security_group.py`. it looks like a precise surgery to remove the ebtables 
rules, as @DaanHoogland said.
   we could drop the methods in `security_group.py` if all mac/ip/arp 
anti-spoofing are supported (see the PR description).
   
   other than that, the upgrade could be an issue as the VMs started in old 
versions (before upgrade) do not have the configuration in their VM XML 
definition.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] test: fix unknown parameter hostid in test_vm_life_cycle.py [cloudstack]

2024-04-22 Thread via GitHub


weizhouapache commented on PR #8948:
URL: https://github.com/apache/cloudstack/pull/8948#issuecomment-2069057056

   @blueorangutan test rocky8 xenserver-71


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Change storage pool scope from Cluster to Zone and vise versa [cloudstack]

2024-04-22 Thread via GitHub


abh1sar commented on code in PR #8875:
URL: https://github.com/apache/cloudstack/pull/8875#discussion_r1574530881


##
ui/src/views/infra/changeStoragePoolScope.vue:
##
@@ -0,0 +1,226 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+
+  
+
+  
+
+  
+
+  
+
+  
+  
+
+  
+
+  

Review Comment:
   message.action.primary.storage.scope.cluster is specific to cluster.
   message.warn.change.primary.storage.scope is a generic msg about changing 
the storage pool scope (zone and cluster).
   
   Is there a way we can combine these msgs into a single warning box?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]

2024-04-22 Thread via GitHub


DaanHoogland commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2069046916

   > Smoke tests completed. 56 look OK, 54 have errors, 0 did not run
   
   note that this is a normal rate for security group zones :(


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] field enlarged and db upgrade [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8675:
URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2069036281

   @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) 
has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] server: fix duplicated records for templates if there are multiple zones [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8933:
URL: https://github.com/apache/cloudstack/pull/8933#issuecomment-2069044029

   @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) 
has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] server: fix duplicated records for templates if there are multiple zones [cloudstack]

2024-04-22 Thread via GitHub


DaanHoogland commented on PR #8933:
URL: https://github.com/apache/cloudstack/pull/8933#issuecomment-2069041543

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] field enlarged and db upgrade [cloudstack]

2024-04-22 Thread via GitHub


DaanHoogland commented on PR #8675:
URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2069031924

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] server: fix duplicated records for templates if there are multiple zones [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8933:
URL: https://github.com/apache/cloudstack/pull/8933#issuecomment-2069028392

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9360


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] test: fix unknown parameter hostid in test_vm_life_cycle.py [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8948:
URL: https://github.com/apache/cloudstack/pull/8948#issuecomment-2069027789

   [SF] Trillian Build Failed (tid-9947)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] KVM: enable no-mac-spoofing on virtual nics [cloudstack]

2024-04-22 Thread via GitHub


wido commented on PR #8951:
URL: https://github.com/apache/cloudstack/pull/8951#issuecomment-2068983414

   > > My suggestion:
   > > ```
   > > * Enable this in Libvirt
   > > 
   > > * Remove functionality from security_group.py
   > > ```
   > 
   > meaning, @wido , this is good but we need to add a removal of some of the 
" -j DROP/ACCEPT" lines from the script? sounds like some precision surgery. Do 
you know which ones to drop? cc @weizhouapache .
   
   It would, I think if you take a look it starts here: 
https://github.com/apache/cloudstack/blob/8ff2c018cc5b3fc69bcd8756695d04b384e46ab8/scripts/vm/network/security_group.py#L280
   
   - default_ebtables_rules()
   - destroy_ebtables_rules()
   
   Those would no longer be needed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] field enlarged and db upgrade [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8675:
URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2068959917

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9359


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] on forName validate packages of classes to load [cloudstack]

2024-04-22 Thread via GitHub


DaanHoogland commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-2068940990

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] on forName validate packages of classes to load [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-2068945094

   @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will 
be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix KVM live migration with NFS volumes [cloudstack]

2024-04-22 Thread via GitHub


DaanHoogland commented on PR #8952:
URL: https://github.com/apache/cloudstack/pull/8952#issuecomment-2068936065

   > @JoaoJandre will you back to 4.18 ? (I am not sure if there will be 
4.18.3.0)
   
   @JoaoJandre , we can merge as is or merge to 4.18 and merge forward. For 
anybody doing custom maintenance that will be convenient. Just say yes or no... 
;)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] test: fix unknown parameter hostid in test_vm_life_cycle.py [cloudstack]

2024-04-22 Thread via GitHub


blueorangutan commented on PR #8948:
URL: https://github.com/apache/cloudstack/pull/8948#issuecomment-2068941253

   @DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + xenserver-74) 
has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix KVM live migration with NFS volumes [cloudstack]

2024-04-22 Thread via GitHub


DaanHoogland closed pull request #8952: Fix KVM live migration with NFS volumes
URL: https://github.com/apache/cloudstack/pull/8952


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] test: fix unknown parameter hostid in test_vm_life_cycle.py [cloudstack]

2024-04-22 Thread via GitHub


DaanHoogland commented on PR #8948:
URL: https://github.com/apache/cloudstack/pull/8948#issuecomment-2068937162

   @blueorangutan test alma9 xenserver-74


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] KVM: enable no-mac-spoofing on virtual nics [cloudstack]

2024-04-22 Thread via GitHub


DaanHoogland commented on PR #8951:
URL: https://github.com/apache/cloudstack/pull/8951#issuecomment-2068917569

   > My suggestion:
   > 
   > * Enable this in Libvirt
   > 
   > * Remove functionality from security_group.py
   
   meaning, @wido , this is good but we need to add a removal of some of the " 
-j DROP/ACCEPT" lines from the script? sounds like some precision surgery. Do 
you know which ones to drop? cc @weizhouapache .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



  1   2   >