Re: [PR] Change storage pool scope from Cluster to Zone and vise versa [cloudstack]

2024-04-24 Thread via GitHub


abh1sar commented on PR #8875:
URL: https://github.com/apache/cloudstack/pull/8875#issuecomment-2076427276

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8602:
URL: https://github.com/apache/cloudstack/pull/8602#issuecomment-2076426027

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9418


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #7345:
URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-2076426029

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9416


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HEALTH] 4.19 Health Check, please don't merge this! [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8601:
URL: https://github.com/apache/cloudstack/pull/8601#issuecomment-2076426030

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9417


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Change storage pool scope from Cluster to Zone and vise versa [cloudstack]

2024-04-24 Thread via GitHub


abh1sar closed pull request #8875: Change storage pool scope from Cluster to 
Zone and vise versa
URL: https://github.com/apache/cloudstack/pull/8875


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8968:
URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2076410713

   [SF] Trillian Build Failed (tid-10006)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8968:
URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2076410708

   [SF] Trillian Build Failed (tid-10004)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8968:
URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2076381959

   @rohityadavcloud a [SL] Trillian-Jenkins matrix job (centos7 mgmt + 
xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been 
kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] plugin: fix nsx build failure with mvn 3.9 [cloudstack]

2024-04-24 Thread via GitHub


codecov-commenter commented on PR #8974:
URL: https://github.com/apache/cloudstack/pull/8974#issuecomment-2076379333

   ## 
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8974?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 4.27%. Comparing base 
[(`836ef9e`)](https://app.codecov.io/gh/apache/cloudstack/commit/836ef9ec709a30f85d2269f31fb475cf94254852?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 to head 
[(`6735dd1`)](https://app.codecov.io/gh/apache/cloudstack/pull/8974?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   
   
   Additional details and impacted files
   
   
   ```diff
   @@ Coverage Diff  @@
   ##   main   #8974   +/-   ##
   
   - Coverage 15.28%   4.27%   -11.02% 
   
 Files  5425 363 -5062 
 Lines473878   29549   -444329 
 Branches  582865188-53098 
   
   - Hits  724531262-71191 
   + Misses   393368   28145   -365223 
   + Partials   8057 142 -7915 
   ```
   
   | 
[Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8974/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8974/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | `4.27% <ø> (ø)` | |
   | 
[unittests](https://app.codecov.io/gh/apache/cloudstack/pull/8974/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8974?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub


rohityadavcloud commented on PR #8968:
URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2076377490

   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] codecov isn't able to upload when PR is from forks [cloudstack]

2024-04-24 Thread via GitHub


rohityadavcloud closed issue #8972: codecov isn't able to upload when PR is 
from forks
URL: https://github.com/apache/cloudstack/issues/8972


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] plugin: fix nsx build failure with mvn 3.9 [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8974:
URL: https://github.com/apache/cloudstack/pull/8974#issuecomment-2076370445

   @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It 
will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep 
you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] plugin: fix nsx build failure with mvn 3.9 [cloudstack]

2024-04-24 Thread via GitHub


rohityadavcloud commented on PR #8974:
URL: https://github.com/apache/cloudstack/pull/8974#issuecomment-2076368786

   @blueorangutan package 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Maven build with noredist and simulator flags failing [cloudstack]

2024-04-24 Thread via GitHub


rohityadavcloud commented on issue #8820:
URL: https://github.com/apache/cloudstack/issues/8820#issuecomment-2076367959

   I've proposed a fix here https://github.com/apache/cloudstack/pull/8974 
@Pearl1594 @nvazquez 
   cc @slavkap @weizhouapache @vishesh92 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Maven build with noredist and simulator flags failing [cloudstack]

2024-04-24 Thread via GitHub


rohityadavcloud commented on issue #8820:
URL: https://github.com/apache/cloudstack/issues/8820#issuecomment-2076367373

   My env details are:
   ```
   Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
   Maven home: /opt/homebrew/Cellar/maven/3.9.6/libexec
   Java version: 11.0.16.1, vendor: Homebrew, runtime: 
/opt/homebrew/Cellar/openjdk@11/11.0.16.1_1/libexec/openjdk.jdk/Contents/Home
   Default locale: en_IN, platform encoding: UTF-8
   OS name: "mac os x", version: "14.4.1", arch: "aarch64", family: "mac"
   ```
   
   Thanks all, I could run this again today and same error for me:
   ```
   mvn clean install -P developer,systemvm -Dnoredist -Dsimulator  -T8
   ...
   [ERROR] Failed to execute goal on project cloud-plugin-network-nsx: Could 
not resolve dependencies for project 
org.apache.cloudstack:cloud-plugin-network-nsx:jar:4.20.0.0-SNAPSHOT: The 
following artifacts could not be resolved: 
com.vmware.vapi:vapi-samltoken:jar:2.40.0 (absent): Could not find artifact 
com.vmware.vapi:vapi-samltoken:jar:2.40.0 in repo.jenkins-ci.org.releases 
(https://repo.jenkins-ci.org/releases/) -> [Help 1]
   ```
   
   On debugging further, it's coming as indirect dependency of:
   ```
985 [DEBUG]com.vmware.vapi:vapi-authentication:jar:2.40.0:compile
986 [DEBUG]   com.vmware.vapi:vapi-samltoken:jar:2.40.0:compile 

 987 [DEBUG]   org.slf4j:slf4j-api:jar:1.7.29:compile
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] plugin: fix nsx build failure with mvn 3.9 [cloudstack]

2024-04-24 Thread via GitHub


rohityadavcloud opened a new pull request, #8974:
URL: https://github.com/apache/cloudstack/pull/8974

   This excludes indirect dependencies of vapi-authentication to allow build to 
work, with mvn 3.9 on Darwin environments.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [x] build/CI
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [x] Major
   - [ ] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [x] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   Tested as a local build on this env:
   
   ```
   Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
   Maven home: /opt/homebrew/Cellar/maven/3.9.6/libexec
   Java version: 11.0.16.1, vendor: Homebrew, runtime: 
/opt/homebrew/Cellar/openjdk@11/11.0.16.1_1/libexec/openjdk.jdk/Contents/Home
   Default locale: en_IN, platform encoding: UTF-8
   OS name: "mac os x", version: "14.4.1", arch: "aarch64", family: "mac"
   ```
   
    How did you try to break this feature and the system with this change?
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub


codecov-commenter commented on PR #8968:
URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2076358747

   ## 
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8968?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 4.31%. Comparing base 
[(`0514cae`)](https://app.codecov.io/gh/apache/cloudstack/commit/0514caedd6a2c861ef8ed34f0ecaf20c068ed6fb?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 to head 
[(`fb82e35`)](https://app.codecov.io/gh/apache/cloudstack/pull/8968?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   > Report is 4 commits behind head on 4.19.
   
   
   Additional details and impacted files
   
   
   ```diff
   @@ Coverage Diff  @@
   ##   4.19   #8968   +/-   ##
   
   - Coverage 15.65%   4.31%   -11.34% 
   
 Files  5155 363 -4792 
 Lines363437   29171   -334266 
 Branches  532865089-48197 
   
   - Hits  569021260-55642 
   + Misses   299834   27770   -272064 
   + Partials   6701 141 -6560 
   ```
   
   | 
[Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8968/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8968/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | `4.31% <ø> (ø)` | |
   | 
[unittests](https://app.codecov.io/gh/apache/cloudstack/pull/8968/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8968?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub


rohityadavcloud closed pull request #8968: framework/db: introduce a new MySQL 
table based distributed lock
URL: https://github.com/apache/cloudstack/pull/8968


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8602:
URL: https://github.com/apache/cloudstack/pull/8602#issuecomment-2076348570

   @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It 
will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep 
you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HEALTH] 4.19 Health Check, please don't merge this! [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8601:
URL: https://github.com/apache/cloudstack/pull/8601#issuecomment-2076348517

   @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It 
will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep 
you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]

2024-04-24 Thread via GitHub


rohityadavcloud closed pull request #7345: [HEALTH] 4.18 LTS Health Check, 
please don't merge this!
URL: https://github.com/apache/cloudstack/pull/7345


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]

2024-04-24 Thread via GitHub


rohityadavcloud commented on PR #8602:
URL: https://github.com/apache/cloudstack/pull/8602#issuecomment-2076347157

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]

2024-04-24 Thread via GitHub


rohityadavcloud closed pull request #8602: [HEALTH] 4.20/main Health Check, 
please don't merge this!
URL: https://github.com/apache/cloudstack/pull/8602


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #7345:
URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-2076348474

   @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It 
will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep 
you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Unstable 4.19 and main branch smoketests [cloudstack]

2024-04-24 Thread via GitHub


rohityadavcloud commented on issue #8931:
URL: https://github.com/apache/cloudstack/issues/8931#issuecomment-2076347924

   Let's do a new round of smoketests and close this if branches are stable 
enough cc @sureshanaparti @weizhouapache @DaanHoogland 
   
   4.18 - https://github.com/apache/cloudstack/pull/7345
   4.19 - https://github.com/apache/cloudstack/pull/8601
   main/4.20 -  https://github.com/apache/cloudstack/pull/8602


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HEALTH] 4.19 Health Check, please don't merge this! [cloudstack]

2024-04-24 Thread via GitHub


rohityadavcloud closed pull request #8601: [HEALTH] 4.19 Health Check, please 
don't merge this!
URL: https://github.com/apache/cloudstack/pull/8601


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Restarting management server causes multiple entries for the same node [cloudstack]

2024-04-24 Thread via GitHub


rohityadavcloud commented on issue #8174:
URL: https://github.com/apache/cloudstack/issues/8174#issuecomment-2076344324

   This happens on a server which is used both as management server and KVM 
hosts (and docker host), the number of interfaces keep on changing over time 
and the current code is flaky to be deterministic about which interface to 
pick. I've addressed this at: 
https://github.com/apache/cloudstack/pull/8968/commits/fb82e352bf4cd9306421effdd91bdc6e9387df5f
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] codecov isn't able to upload when PR is from forks [cloudstack]

2024-04-24 Thread via GitHub


rohityadavcloud commented on issue #8972:
URL: https://github.com/apache/cloudstack/issues/8972#issuecomment-2076342818

   I've bumped version used across 4.18-4.19-main branches to use `v4`; since 
they only get kicked when changes are on the branch; I've merged/fwd-merged 
changes directly on these branches.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(cloudstack) branch main updated (27124c10319 -> 836ef9ec709)

2024-04-24 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


from 27124c10319 Add ability to set cpu.threadspercore similar to existing 
cpu.corespersocket (#8850)
 add 3b0e6ac90c0 VR: fix dnmasq misconfiguration if there are multiple IP 
ranges in a shared network (#8741)
 add 77df9ad4d78 codecov: fix Github action workflow
 add 5745674da5f Merge remote-tracking branch 'origin/4.18' into 4.19
 add 4c27574570d .github: fix codecov action configuration
 new 836ef9ec709 Merge remote-tracking branch 'origin/4.19'

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .github/workflows/ci.yml |  2 +-
 .github/workflows/codecov.yml|  2 +-
 .github/workflows/ui.yml |  2 +-
 systemvm/debian/opt/cloud/bin/cs/CsDhcp.py   |  2 +-
 systemvm/debian/opt/cloud/bin/cs/CsHelper.py | 12 +---
 ui/src/views/compute/wizard/NetworkConfiguration.vue |  2 +-
 6 files changed, 10 insertions(+), 12 deletions(-)



(cloudstack) 01/01: Merge remote-tracking branch 'origin/4.19'

2024-04-24 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 836ef9ec709a30f85d2269f31fb475cf94254852
Merge: 27124c10319 4c27574570d
Author: Rohit Yadav 
AuthorDate: Thu Apr 25 09:55:09 2024 +0530

Merge remote-tracking branch 'origin/4.19'

Signed-off-by: Rohit Yadav 

 Conflicts:
systemvm/debian/opt/cloud/bin/cs/CsHelper.py

 .github/workflows/ci.yml |  2 +-
 .github/workflows/codecov.yml|  2 +-
 .github/workflows/ui.yml |  2 +-
 systemvm/debian/opt/cloud/bin/cs/CsDhcp.py   |  2 +-
 systemvm/debian/opt/cloud/bin/cs/CsHelper.py | 12 +---
 ui/src/views/compute/wizard/NetworkConfiguration.vue |  2 +-
 6 files changed, 10 insertions(+), 12 deletions(-)




(cloudstack) 02/02: .github: fix codecov action configuration

2024-04-24 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.19
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 4c27574570d183e5f9203be0164fed9d4295302e
Author: Rohit Yadav 
AuthorDate: Thu Apr 25 09:46:37 2024 +0530

.github: fix codecov action configuration

`token` is documented to work with codecov-action@v4

Signed-off-by: Rohit Yadav 
---
 .github/workflows/ci.yml | 2 +-
 .github/workflows/ui.yml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 87edfe890b0..6a6ea33b14a 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -312,7 +312,7 @@ jobs:
   echo -e "Simulator CI Test Results: (only failures listed)\n"
   python3 ./tools/marvin/xunit-reader.py integration-test-results/
 
-  - uses: codecov/codecov-action@v3
+  - uses: codecov/codecov-action@v4
 with:
   files: jacoco-coverage.xml
   fail_ci_if_error: true
diff --git a/.github/workflows/ui.yml b/.github/workflows/ui.yml
index b3230eeaca3..476526aff32 100644
--- a/.github/workflows/ui.yml
+++ b/.github/workflows/ui.yml
@@ -55,7 +55,7 @@ jobs:
   npm run lint
   npm run test:unit
 
-  - uses: codecov/codecov-action@v3
+  - uses: codecov/codecov-action@v4
 with:
   working-directory: ui
   files: ./coverage/lcov.info



(cloudstack) 01/02: Merge remote-tracking branch 'origin/4.18' into 4.19

2024-04-24 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.19
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 5745674da5ffbaa65a5a275e0cd5b63b8472663a
Merge: 0514caedd6a 77df9ad4d78
Author: Rohit Yadav 
AuthorDate: Thu Apr 25 09:45:08 2024 +0530

Merge remote-tracking branch 'origin/4.18' into 4.19

 .github/workflows/codecov.yml|  2 +-
 systemvm/debian/opt/cloud/bin/cs/CsDhcp.py   |  2 +-
 systemvm/debian/opt/cloud/bin/cs/CsHelper.py | 14 ++
 ui/src/views/compute/wizard/NetworkConfiguration.vue |  2 +-
 4 files changed, 9 insertions(+), 11 deletions(-)




(cloudstack) branch 4.19 updated (0514caedd6a -> 4c27574570d)

2024-04-24 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch 4.19
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


from 0514caedd6a Merge release branch 4.18 to 4.19
 add 3b0e6ac90c0 VR: fix dnmasq misconfiguration if there are multiple IP 
ranges in a shared network (#8741)
 add 77df9ad4d78 codecov: fix Github action workflow
 new 5745674da5f Merge remote-tracking branch 'origin/4.18' into 4.19
 new 4c27574570d .github: fix codecov action configuration

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .github/workflows/ci.yml |  2 +-
 .github/workflows/codecov.yml|  2 +-
 .github/workflows/ui.yml |  2 +-
 systemvm/debian/opt/cloud/bin/cs/CsDhcp.py   |  2 +-
 systemvm/debian/opt/cloud/bin/cs/CsHelper.py | 14 ++
 ui/src/views/compute/wizard/NetworkConfiguration.vue |  2 +-
 6 files changed, 11 insertions(+), 13 deletions(-)



(cloudstack) branch 4.18 updated: codecov: fix Github action workflow

2024-04-24 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.18
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.18 by this push:
 new 77df9ad4d78 codecov: fix Github action workflow
77df9ad4d78 is described below

commit 77df9ad4d788d0f452ed2c82970de9a534278a27
Author: Rohit Yadav 
AuthorDate: Thu Apr 25 09:43:50 2024 +0530

codecov: fix Github action workflow

Signed-off-by: Rohit Yadav 
---
 .github/workflows/codecov.yml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/codecov.yml b/.github/workflows/codecov.yml
index fcbcf9b8bfc..2a45e87d41e 100644
--- a/.github/workflows/codecov.yml
+++ b/.github/workflows/codecov.yml
@@ -47,9 +47,11 @@ jobs:
   cd nonoss && bash -x install-non-oss.sh && cd ..
   mvn -P quality -Dsimulator -Dnoredist clean install -T$(nproc)
 
-  - uses: codecov/codecov-action@v3
+  - uses: codecov/codecov-action@v4
 with:
   files: ./client/target/site/jacoco-aggregate/jacoco.xml
   fail_ci_if_error: true
+  flags: unittests
   verbose: true
   name: codecov
+  token: ${{ secrets.CODECOV_TOKEN }}



Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8968:
URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2076322406

   [SF] Trillian Build Failed (tid-10001)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8968:
URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2076322351

   [SF] Trillian Build Failed (tid-10003)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8968:
URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2076295342

   @rohityadavcloud a [SL] Trillian-Jenkins matrix job (centos7 mgmt + 
xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been 
kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub


rohityadavcloud commented on PR #8968:
URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2076294562

   @blueorangutan test matrix 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix KVM live migration with NFS volumes [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8952:
URL: https://github.com/apache/cloudstack/pull/8952#issuecomment-2076120703

   [SF] Trillian test result (tid-9984)
   Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
   Total time taken: 46882 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8952-t9984-kvm-rocky8.zip
   Smoke tests completed. 108 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_list_cpvm_vm | `Failure` | 0.08 | test_ssvm.py
   test_04_cpvm_internals | `Failure` | 0.05 | test_ssvm.py
   test_01_migrate_VM_and_root_volume | `Error` | 93.40 | test_vm_life_cycle.py
   test_02_migrate_VM_with_two_data_disks | `Error` | 56.56 | 
test_vm_life_cycle.py
   test_08_migrate_vm | `Error` | 47.59 | test_vm_life_cycle.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8624:
URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2076088875

   [SF] Trillian test result (tid-9979)
   Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
   Total time taken: 52035 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8624-t9979-kvm-rocky8.zip
   Smoke tests completed. 126 look OK, 4 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_events_resource | `Error` | 423.30 | test_events_resource.py
   test_03_network_operations_on_created_vm_of_otheruser | `Failure` | 146.54 | 
test_network_permissions.py
   test_03_network_operations_on_created_vm_of_otheruser | `Error` | 146.55 | 
test_network_permissions.py
   ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.54 | 
test_network_permissions.py
   test_01_nic | `Error` | 232.10 | test_nic.py
   test_02_trigger_shutdown | `Failure` | 346.90 | test_safe_shutdown.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fixup listing of serivce offering & storagepools with tags [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8937:
URL: https://github.com/apache/cloudstack/pull/8937#issuecomment-2076084264

   [SF] Trillian test result (tid-9983)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 46632 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8937-t9983-kvm-centos7.zip
   Smoke tests completed. 129 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_events_resource | `Error` | 422.19 | test_events_resource.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] systemvm: add template_zone_ref record when add a new zone with same hypervisor type [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8395:
URL: https://github.com/apache/cloudstack/pull/8395#issuecomment-2076080520

   [SF] Trillian test result (tid-9981)
   Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
   Total time taken: 49175 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8395-t9981-kvm-rocky8.zip
   Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] VR: fix dnmasq misconfiguration if there are multiple IP ranges in a shared network [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8741:
URL: https://github.com/apache/cloudstack/pull/8741#issuecomment-2075952155

   [SF] Trillian test result (tid-9982)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 42891 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8741-t9982-kvm-centos7.zip
   Smoke tests completed. 109 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_08_migrate_vm | `Error` | 0.08 | test_vm_life_cycle.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8968:
URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2075913682

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9412


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] server: add global setting consoleproxy.sslEnabled [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8809:
URL: https://github.com/apache/cloudstack/pull/8809#issuecomment-2075900287

   [SF] Trillian test result (tid-9978)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 44910 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8809-t9978-kvm-centos7.zip
   Smoke tests completed. 129 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_events_resource | `Error` | 423.26 | test_events_resource.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Update en.json [cloudstack]

2024-04-24 Thread via GitHub


NuxRo commented on PR #8958:
URL: https://github.com/apache/cloudstack/pull/8958#issuecomment-2075858595

   > > Should it be host state/status?
   > 
   > @NuxRo ?
   
   Well, we could go a step further and call it "hypervisor", but it could also 
be a vcenter if it's vmware, so.. don't know. I'm all for making things as 
clear as possible. Happy to accept alternatives.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add logs to CPVM connection process [cloudstack]

2024-04-24 Thread via GitHub


bernardodemarco commented on code in PR #8924:
URL: https://github.com/apache/cloudstack/pull/8924#discussion_r1578507302


##
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyNoVNCHandler.java:
##
@@ -104,20 +105,20 @@ public void onConnect(final Session session) throws 
IOException, InterruptedExce
 try {
 port = Integer.parseInt(portStr);
 } catch (NumberFormatException e) {
-logger.error("Invalid port value in query string: {}. Expected a 
number.", portStr, e);
+logger.error(String.format("Invalid port value in query string: 
%s. Expected a number.", portStr), e);

Review Comment:
   I'm not really sure why, but the `logger` fields of 
`com.cloud.consoleproxy.ConsoleProxyNoVNCHandler` and 
`com.cloud.consoleproxy.vnc.NoVncClient` are not instantiated directly from 
`log4j`. They're generated from a static method from the 
`com.cloud.consoleproxy.util.Logger` helper class.
   
   The problem is that this helper class does not implement the new APIs 
provided by the new version of `log4j`, especially those that accept multiple 
parameters. As a consequence of that, `String.format()` must be used to log 
messages in those two classes.
   
   IMO, it should be evaluated if the helper class is still needed. If so, we 
need to implement new methods to be able to use the new syntax provided by 
`log4j2`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8968:
URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2075803100

   @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It 
will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep 
you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub


rohityadavcloud commented on PR #8968:
URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2075801690

   @blueorangutan package 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Extra parameter for UpdateImageStore [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8941:
URL: https://github.com/apache/cloudstack/pull/8941#issuecomment-2075784735

   [SF] Trillian Build Failed (tid-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [UI] Add option to specify account/project while deploying VMs and creating networks [cloudstack]

2024-04-24 Thread via GitHub


DaanHoogland commented on PR #8919:
URL: https://github.com/apache/cloudstack/pull/8919#issuecomment-2075771022

   Did some more testing @BryanMLima the illusive "Request failed." actually 
happens when selecting a domain in your dialog that doesn't contain any 
account/users.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Updates to HPE-Primera and Pure FlashArray Drivers to use Host-based VLUN Assignments [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8889:
URL: https://github.com/apache/cloudstack/pull/8889#issuecomment-2075766888

   [SF] Trillian test result (tid-9975)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 47208 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8889-t9975-kvm-centos7.zip
   Smoke tests completed. 129 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_events_resource | `Error` | 409.70 | test_events_resource.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8968:
URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2075678540

   [SF] Trillian Build Failed (tid-9993)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8968:
URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2075662209

   [SF] Trillian Build Failed (tid-9991)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8968:
URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2075660318

   [SF] Trillian Build Failed (tid-9995)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] api: listApis should return params based on caller [cloudstack]

2024-04-24 Thread via GitHub


shwstppr opened a new pull request, #8973:
URL: https://github.com/apache/cloudstack/pull/8973

   ### Description
   
   API params can be marked accessible to selected role types using  
`authorized` values in API command class.
   The existing behaviour of lisApis API was to return all parameters of the 
API irrespective of the caller's role type. This PR fixes it by adding checks 
to filter params.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] build/CI
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   
   
   
    How did you try to break this feature and the system with this change?
   
   
   
   
   
   
   Tested by setting an API param as,
   ```
   @Parameter(name = ApiConstants.SCOPE, type = BaseCmd.CommandType.STRING, 
description = "Scope of the Webhook",
   authorized = {RoleType.Admin, RoleType.DomainAdmin})
   private String scope;
   ```
   
   Using cmk,
   
   ```
   (localcloud)  > set username admin
   (localcloud)  > sync
   Discovered 766 APIs
   (localcloud)  > list apis name=createWebhook filter=name,params
   {
 "api": [
   {
 "name": "createWebhook",
 "params": [
   {
 "description": "an optional domainId for the Webhook. If the 
account parameter is used, domainId must also be used.",
 "length": 255,
 "name": "domainid",
 "related": "listDomainChildren,listDomains",
 "required": false,
 "type": "uuid"
   },
   {
 "description": "Project for the Webhook",
 "length": 255,
 "name": "projectid",
 "related": "activateProject,suspendProject",
 "required": false,
 "type": "uuid"
   },
   {
 "description": "An optional account for the Webhook. Must be used 
with domainId.",
 "length": 255,
 "name": "account",
 "required": false,
 "type": "string"
   },
   {
 "description": "Scope of the Webhook",
 "length": 255,
 "name": "scope",
 "required": false,
 "type": "string"
   },
   {
 "description": "Secret key of the Webhook",
 "length": 255,
 "name": "secretkey",
 "required": false,
 "type": "string"
   },
   {
 "description": "If set to true then SSL verification will be done 
for the Webhook otherwise not",
 "length": 255,
 "name": "sslverification",
 "required": false,
 "type": "boolean"
   },
   {
 "description": "Payload URL of the Webhook",
 "length": 255,
 "name": "payloadurl",
 "required": true,
 "type": "string"
   },
   {
 "description": "State of the Webhook",
 "length": 255,
 "name": "state",
 "required": false,
 "type": "string"
   },
   {
 "description": "Name for the Webhook",
 "length": 255,
 "name": "name",
 "required": true,
 "type": "string"
   },
   {
 "description": "Description for the Webhook",
 "length": 255,
 "name": "description",
 "required": false,
 "type": "string"
   }
 ]
   }
 ],
 "count": 1
   }
   (localcloud)  > set username user
   (localcloud)  > sync
   Discovered 340 APIs
   (localcloud)  > list apis name=createWebhook filter=name,params
   {
 "api": [
   {
 "name": "createWebhook",
 "params": [
   {
 "description": "an optional domainId for the Webhook. If the 
account parameter is used, domainId must also be used.",
 "length": 255,
 "name": "domainid",
 "related": "listDomainChildren,listDomains",
 "required": false,
 "type": "uuid"
   },
   {
 "description": "Project for the Webhook",
 "length": 255,
 "name": "projectid",
 "related": "activateProject,suspendProject",
 "required": false,
 "type": 

Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8968:
URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2075611590

   @rohityadavcloud a [SL] Trillian-Jenkins matrix job (centos7 mgmt + 
xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been 
kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub


rohityadavcloud commented on PR #8968:
URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2075608905

   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8968:
URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2075603681

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9411


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] codecov isn't able to upload when PR is from forks [cloudstack]

2024-04-24 Thread via GitHub


rohityadavcloud commented on issue #8972:
URL: https://github.com/apache/cloudstack/issues/8972#issuecomment-2075552713

   This may need use of 
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] codecov isn't able to upload when PR is from forks [cloudstack]

2024-04-24 Thread via GitHub


rohityadavcloud commented on issue #8972:
URL: https://github.com/apache/cloudstack/issues/8972#issuecomment-2075550660

   Example 
https://github.com/apache/cloudstack/actions/runs/8820758171/job/24215084459?pr=8968


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[I] codecov isn't able to upload when PR is from forks [cloudstack]

2024-04-24 Thread via GitHub


rohityadavcloud opened a new issue, #8972:
URL: https://github.com/apache/cloudstack/issues/8972

   PRs from fork (not this repo's own branch) isn't able to upload codecov 
results as the CODECOV_TOKEN isn't accessible to the GitHub action workflow.
   
   # ISSUE TYPE
   
* Bug Report
   
   # COMPONENT NAME
   
   ~~~
   Github Actions
   ~~~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8968:
URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2075477872

   @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It 
will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep 
you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub


rohityadavcloud commented on PR #8968:
URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2075475893

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] sanatise log in case multiple passwords have been passed [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8891:
URL: https://github.com/apache/cloudstack/pull/8891#issuecomment-2075472394

   [SF] Trillian test result (tid-9974)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 45404 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8891-t9974-kvm-centos7.zip
   Smoke tests completed. 129 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_events_resource | `Error` | 415.91 | test_events_resource.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix `deleteAccount` API to prevent deletion of the caller [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8743:
URL: https://github.com/apache/cloudstack/pull/8743#issuecomment-2075464697

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9410


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] IP address conflicts held by public IPs of virtual routers [cloudstack]

2024-04-24 Thread via GitHub


bragonznx commented on issue #8967:
URL: https://github.com/apache/cloudstack/issues/8967#issuecomment-2075401415

   Hi
   
   We need that to be fix, how can we help ?
   
   Best
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [UI] Add option to specify account/project while deploying VMs and creating networks [cloudstack]

2024-04-24 Thread via GitHub


BryanMLima commented on PR #8919:
URL: https://github.com/apache/cloudstack/pull/8919#issuecomment-2075398153

   > > Thanks for testing @DaanHoogland, I got this error in the QA 
environment, though it is using the 4.19 branch to build it. However, when I 
built locally with the main branch, this situation does not occur, I am able to 
create a network for a different account in the deployment view.
   > > Could you reproduce this error when building locally? This might be a 
problem with the QA environment.
   > 
   > I actually think it should fail (while deploying in domain A creating a 
network in domain B), but i'll give it a go anyway.
   
   The `DeployVM` view utilizes the component `CreateNetwork`, indirectly. And 
the `CreateNetwork` component is agnostic, therefore, I do not see a problem 
allowing privilege users to create a network different from the VM's owner — 
even if it does not make sense. This was already the previous behaviour, the 
ownership component just gave it more flexibility allowing to create for 
projects as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] IP address conflicts held by public IPs of virtual routers [cloudstack]

2024-04-24 Thread via GitHub


vdombrovski commented on issue #8967:
URL: https://github.com/apache/cloudstack/issues/8967#issuecomment-2075380164

   @DaanHoogland here is how I successfully reproduced the issue on our QA 
platform:
   
   ```
   56 bytes from 1e:00:4d:00:00:c1 (XX.YY.17.30): index=959 time=275.810 usec
   56 bytes from 1e:00:6b:00:00:c2 (XX.YY.17.30): index=960 time=337.038 usec
   ```
   
   You were right, this is a timing issue. Here is the raw cmk code to 
reproduce:
   
   - Create 2 isolated networks, network-a and network-b (mine are ids 
c6a4bc87-93cc-499c-8fdc-4e44b4d0fca0 and 7e2aa0f1-c536-4162-be43-aea277ae80aa
   - You don't need to add any VMs, only playing with virtual routers is enough 
to cause the issue
   - Target a specific IP address, in my case XX.YY.17.30 
(id=f1988f51-c9e5-46e4-9393-2a873b2610e0)
   - Create 2 scripts as follows (make sure cmk works properly on your machine, 
I'm using 6.2.0)
   - Run both scripts in parallel in a while true loop as follows:
   
   Terminal 1:
   ```sh
   while true; do bash ./test1.sh; done
   ```
   Terminal 2:
   ```sh
   while true; do bash ./test2.sh; done
   ```
   
   - Test with arping on the IP (arping XX.YY.17.30), it should take around 2-3 
mins on a platform with 0 load.
   
   ```
   #test1.sh
   
   cmk associate ipaddress projectid=05019f40-8552-4856-9cf1-02ae1b7e2621 
zoneid=3adfd657-7e4e-4613-99da-49b3a0ef9db7 ipaddress=XX.YY.17.30 account=qa 
networkid=c6a4bc87-93cc-499c-8fdc-4e44b4d0fca0 # Network A
   
   cmk createLoadBalancerRule algorithm=roundrobin 
publicipid=f1988f51-c9e5-46e4-9393-2a873b2610e0 publicport=22 privateport=22 
name=vm-a
   
   cmk disassociate ipaddress id=f1988f51-c9e5-46e4-9393-2a873b2610e0
   
   cmk associate ipaddress projectid=05019f40-8552-4856-9cf1-02ae1b7e2621 
zoneid=3adfd657-7e4e-4613-99da-49b3a0ef9db7 ipaddress=XX.YY.17.30 account=qa 
networkid=7e2aa0f1-c536-4162-be43-aea277ae80aa # network B
   
   cmk createLoadBalancerRule algorithm=roundrobin 
publicipid=f1988f51-c9e5-46e4-9393-2a873b2610e0 publicport=22 privateport=22 
name=vm-b
   
   cmk disassociate ipaddress id=f1988f51-c9e5-46e4-9393-2a873b2610e0
   ```
   
   ```
   #test2.sh
   
   cmk associate ipaddress projectid=05019f40-8552-4856-9cf1-02ae1b7e2621 
zoneid=3adfd657-7e4e-4613-99da-49b3a0ef9db7 ipaddress=XX.YY.17.30 account=qa 
networkid=c6a4bc87-93cc-499c-8fdc-4e44b4d0fca0 # Network A
   
   cmk createLoadBalancerRule algorithm=roundrobin 
publicipid=f1988f51-c9e5-46e4-9393-2a873b2610e0 publicport=23 privateport=23 
name=vm-a
   
   cmk createLoadBalancerRule algorithm=roundrobin 
publicipid=f1988f51-c9e5-46e4-9393-2a873b2610e0 publicport=24 privateport=24 
name=vm-a
   
   cmk disassociate ipaddress id=f1988f51-c9e5-46e4-9393-2a873b2610e0
   
   cmk associate ipaddress projectid=05019f40-8552-4856-9cf1-02ae1b7e2621 
zoneid=3adfd657-7e4e-4613-99da-49b3a0ef9db7 ipaddress=XX.YY.17.30 account=qa 
networkid=7e2aa0f1-c536-4162-be43-aea277ae80aa # network B
   
   cmk createLoadBalancerRule algorithm=roundrobin 
publicipid=f1988f51-c9e5-46e4-9393-2a873b2610e0 publicport=23 privateport=23 
name=vm-b
   
   cmk createLoadBalancerRule algorithm=roundrobin 
publicipid=f1988f51-c9e5-46e4-9393-2a873b2610e0 publicport=24 privateport=24 
name=vm-b
   
   cmk disassociate ipaddress id=f1988f51-c9e5-46e4-9393-2a873b2610e0
   ```
   
   Now I understand that handling concurrency isn't really a priority for this 
project (see another issue from last year: 
https://github.com/apache/cloudstack/issues/7907)
   
   However, with the introduction of more vectors of automation (Terraform, 
Kubernetes), I believe that these types of issues might become really common. 
In our case, the IP conflicts have impacted more than 10 IPs total on a pool of 
400 IPs, which is 2.5%.
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix `deleteAccount` API to prevent deletion of the caller [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8743:
URL: https://github.com/apache/cloudstack/pull/8743#issuecomment-2075287161

   @BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix `deleteAccount` API to prevent deletion of the caller [cloudstack]

2024-04-24 Thread via GitHub


BryanMLima commented on PR #8743:
URL: https://github.com/apache/cloudstack/pull/8743#issuecomment-2075284780

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8898:
URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2075237347

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9409


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Improve logs in primary storage removal process [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8649:
URL: https://github.com/apache/cloudstack/pull/8649#issuecomment-2075237325

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9408


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix link to removed volumes being shown in info card [cloudstack]

2024-04-24 Thread via GitHub


winterhazel commented on PR #8833:
URL: https://github.com/apache/cloudstack/pull/8833#issuecomment-2075234849

   Thanks for testing @lucas-a-martins. At first, I think the issue regarding 
invalid links in the list view should be tackled in another PR, but I'll 
investigate how it could be implemented to see if it makes sense to unify how 
the validation is performed with this one.
   
   > @winterhazel , I marked this for 4.20 now as it is targeted for main. Do 
you want this in 4.19?
   
   @DaanHoogland sure, I'll target 4.19.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] IP address conflicts held by public IPs of virtual routers [cloudstack]

2024-04-24 Thread via GitHub


weizhouapache commented on issue #8967:
URL: https://github.com/apache/cloudstack/issues/8967#issuecomment-2075229433

   did a quick test, everything looks good
   this may need intensive testing to reproduce the issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] VR: fix dnmasq misconfiguration if there are multiple IP ranges in a shared network [cloudstack]

2024-04-24 Thread via GitHub


weizhouapache commented on PR #8741:
URL: https://github.com/apache/cloudstack/pull/8741#issuecomment-2075227230

   > cloud-scripts.tgz
   
   @ccycv 
   if you use maven to rebuild the tarball, the scripts in the tarball should 
be executable
   
   ```
   mvn -P developer,systemvm clean install -pl systemvm/
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Limit `listRoles` API visibility [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8639:
URL: https://github.com/apache/cloudstack/pull/8639#issuecomment-2075220670

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9407


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[I] Cannot add a tag to an existing Compute offering [cloudstack]

2024-04-24 Thread via GitHub


0sorkon opened a new issue, #8971:
URL: https://github.com/apache/cloudstack/issues/8971

   # ISSUE TYPE
   
* Bug Report
   
   # COMPONENT NAME
   ~~~
   API
   ~~~
   # CLOUDSTACK VERSION
   
   
   ~~~
   4.18.1.0
   ~~~
   
   # CONFIGURATION
   
   
   
   # OS / ENVIRONMENT
   
   
   
   # SUMMARY
   Cannot add a storage tag to an existing Compute offering with enabled 
"Compute only disk offering". When I try to add it via GUI, I get an error 
Request failed. (502)
   ```Request failed with status code 502```
   
![image](https://github.com/apache/cloudstack/assets/3714094/bf53fa5b-cb97-493f-8ab7-df83fd7c75bc)
   At the same time in the management server logs: 
   ```There are active volumes using the disk offering ... Please first add the 
new tags to the mentioned storage pools before adding them to the disk 
offering```
   However, there is already a tag in Primary storage
   
![image](https://github.com/apache/cloudstack/assets/3714094/af2138d8-cf90-4372-be97-28f26f0c7ebe)
   Translated with DeepL.com (free version)
   
   
   # STEPS TO REPRODUCE
   * add tag to storage
   * try to add atg to compute offering
   # EXPECTED RESULTS
   The tag is successfully added. volumes are created according to the tag in 
the compute offering.
   # ACTUAL RESULTS
   
   
   
   ~~~
   
   ~~~
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Hide volumes tab in instance page when user does not have permission to list volumes [cloudstack]

2024-04-24 Thread via GitHub


winterhazel commented on PR #8713:
URL: https://github.com/apache/cloudstack/pull/8713#issuecomment-2075150895

   > @sureshanaparti are your concerns met?
   
   Ping @sureshanaparti 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [UI] Add option to specify account/project while deploying VMs and creating networks [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8919:
URL: https://github.com/apache/cloudstack/pull/8919#issuecomment-2075147817

   [SF] Trillian Build Failed (tid-9989)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Extra parameter for UpdateImageStore [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8941:
URL: https://github.com/apache/cloudstack/pull/8941#issuecomment-2075136725

   [SF] Trillian Build Failed (tid-9987)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [UI] Add option to specify account/project while deploying VMs and creating networks [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8919:
URL: https://github.com/apache/cloudstack/pull/8919#issuecomment-2075123702

   [SF] Trillian Build Failed (tid-9988)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [UI] Add option to specify account/project while deploying VMs and creating networks [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8919:
URL: https://github.com/apache/cloudstack/pull/8919#issuecomment-2075098359

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9404


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8968:
URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2075098362

   Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9406


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Extra parameter for UpdateImageStore [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8941:
URL: https://github.com/apache/cloudstack/pull/8941#issuecomment-2075098360

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9405


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Wrong resource usage often reported in multiple area [cloudstack]

2024-04-24 Thread via GitHub


levindecaro commented on issue #8927:
URL: https://github.com/apache/cloudstack/issues/8927#issuecomment-2075067604

   @DaanHoogland 
   
   So far, I heard it is a intermitted issue from users, when they do some 
excess create/start/stop/destroy VM within a short period. After hours, the 
resource never went down, so i need to recalculate their used resource and 
update db table manually to solve this problem.
   
   For the snapshot usage from secondary storage, there are nothing listed in 
volume snapshot, but resource limit page shown there are consumed spaces.
   
   I'm no idea how to sort out it is a actual used space or just a orphan 
record.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8898:
URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2075041403

   @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will 
be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]

2024-04-24 Thread via GitHub


DaanHoogland commented on PR #8898:
URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2075039409

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8898:
URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2075012326

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9403


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] IP address conflicts held by public IPs of virtual routers [cloudstack]

2024-04-24 Thread via GitHub


DaanHoogland commented on issue #8967:
URL: https://github.com/apache/cloudstack/issues/8967#issuecomment-2075009281

   oh, that,
   ```
   2024-04-23 13:11:27,089 WARNING  Unable to find and process databag for 
file: ip_associations.json.a81b47b8-2a91-42a2-a529-1de42849049c, for json 
type=ip_associations
   ```
   , sounds like a weird timing issue, as if two merge deamons are tryimg to 
process the file at the same time and one has already moved it...???
   
   and it seems here,
   ```
   2024-04-04 04:43:30,162 INFO Delete rule -D VPN_XX.YY.25.156 -m state 
--state RELATED,ESTABLISHED -j ACCEPT from table mangle
   2024-04-04 04:43:36,448 INFO Address found in DataBag ==> {u'public_ip': 
u'XX.YY.25.156', u'one_to_one_nat': False, u'nic_dev_id': 2, u'network': 
u'XX.YY.25.0/24', u'first_i_p': False, u'netmask': u'255.255.255.0', 
u'source_nat': False, u'broadcast': u'XX.YY.25.255', u'add': True, 
u'is_private_gateway': False, u'nw_type': u'public', u'device': u'eth2', 
u'vif_mac_address': u'1e:00:63:00:04:b5', u'cidr': u'XX.YY.25.156/24', 
u'gateway': u'XX.YY.25.1', u'new_nic': False, u'size': u'24'}
   ```
   , that almost 0.3 second the after the deletion it is added again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Improve logs in primary storage removal process [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8649:
URL: https://github.com/apache/cloudstack/pull/8649#issuecomment-2075009152

   @BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Improve logs in primary storage removal process [cloudstack]

2024-04-24 Thread via GitHub


BryanMLima commented on PR #8649:
URL: https://github.com/apache/cloudstack/pull/8649#issuecomment-2075005065

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Limit `listRoles` API visibility [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8639:
URL: https://github.com/apache/cloudstack/pull/8639#issuecomment-2075004653

   @BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Limit `listRoles` API visibility [cloudstack]

2024-04-24 Thread via GitHub


BryanMLima commented on PR #8639:
URL: https://github.com/apache/cloudstack/pull/8639#issuecomment-207469

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix ordering of secondary storages with the algorithm `firstfitleastconsumed` [cloudstack]

2024-04-24 Thread via GitHub


BryanMLima commented on PR #8557:
URL: https://github.com/apache/cloudstack/pull/8557#issuecomment-2074988854

   @sureshanaparti could you trigger the CI here?
   cc @DaanHoogland 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub


blueorangutan commented on PR #8968:
URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2074982813

   @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It 
will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep 
you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub


rohityadavcloud commented on PR #8968:
URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2074980538

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] KVM Incremental Snapshots/Backups [cloudstack]

2024-04-24 Thread via GitHub


JoaoJandre commented on issue #8907:
URL: https://github.com/apache/cloudstack/issues/8907#issuecomment-2074978778

   > > > Ok, one more, will coalescing of snapshots on secondary be implemented 
at all? (and do we think we need it?)
   > > 
   > > 
   > > I don't see a reason to coalesce snapshots on secondary. We would be 
losing the option to revert to a snapshot in the middle of the chain.
   > > The only exception is when creating a template/volume from snapshot, in 
this case, to not mess too much with the current implementation, we will create 
a temporary coalesced snapshot before sending the command to the SSVM. But 
after the template/volume is created, the temporary coalesced snapshot will be 
removed.
   > 
   > one thing I was thinking of is when chains become very long , e.g. an 
automatic snapshot with scheduled deletes. Just a thought though, we can burn 
that bridge ones we try to cross it.
   
   The chain size will be controlled by `snapshot.delta.max` (which has a 
pretty high default value in my opinion). When the chain reaches this 
threshold, a new one will be created, that is, a new full snapshot will be 
taken and the next snapshots will be based on this one.
   
   About the snapshot policies, this is covered a little by section 2.1.1. But 
when the `maxSnaps` is reached, the old snapshots will start to get removed 
(still following the deletion rules on section 2.4).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] VR: fix dnmasq misconfiguration if there are multiple IP ranges in a shared network [cloudstack]

2024-04-24 Thread via GitHub


ccycv commented on PR #8741:
URL: https://github.com/apache/cloudstack/pull/8741#issuecomment-2074977423

   > > Failed to fetch results with details: bash: line 1: 
/opt/cloud/bin/filesystem_writable_check.py: Permission denied
   > > Update: after making the file 
/opt/cloud/bin/filesystem_writable_check.py executable, the health check works 
fine.
   > 
   > @ccycv did you replace the files in /opt/cloud/bin when you tested this PR 
? some files (including filesystem_writable_check.py) are not executable in 
source code, you can mark them all as executable
   > 
   > ```
   > chmod +x /opt/cloud/bin/*
   > ```
   
   I have only replaced the cloud-scripts.tgz on the management server and did 
the router rebuild.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub


rohityadavcloud commented on PR #8968:
URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2074973924

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



  1   2   3   >