[GitHub] [cloudstack] DaanHoogland commented on pull request #4047: Look for active templates for VR deployment

[GitBox]

DaanHoogland commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-727925713


   ok tnx @nvazquez . As said I do have my doubt as I think we might be hiding 
the issue, but will not  .



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4047: Look for active templates for VR deployment

[GitBox]

DaanHoogland commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-712787104


   @nvazquez do you have an opinion as well on this?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4047: Look for active templates for VR deployment

[GitBox]

DaanHoogland commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-665506324


   as per your description @ravening, "If the template from which VR is created 
got deleted, the state
   is set to inactive and removed to null.", it seems the 'real' bug is that 
removed is set to null whilst it should be set to the time of deletion. Your 
code will work, but is it not hiding this 'real' problem? Being very defensive, 
we might want to address both issues.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org