[GitHub] [cloudstack] DaanHoogland commented on pull request #4078: Cleanup download urls when SSVM destroyed
DaanHoogland commented on pull request #4078: URL: https://github.com/apache/cloudstack/pull/4078#issuecomment-729530067 > > > > @ravening can you deal with the comment or should we move to a later milestone? > > > > > > > > > @DaanHoogland there is no need for functional change. It's a different opinion on coding style. > > > > > > I am not talking about extracting that block of code, I asked you to. Both @rhtyd and @sureshanaparti raised concerns. > > @DaanHoogland will look into it today while you're at it, can you extract that code block, please? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4078: Cleanup download urls when SSVM destroyed
DaanHoogland commented on pull request #4078: URL: https://github.com/apache/cloudstack/pull/4078#issuecomment-729478108 > > @ravening can you deal with the comment or should we move to a later milestone? > > @DaanHoogland there is no need for functional change. It's a different opinion on coding style. I am not talking about extracting that block of code, I asked you to. Both @rhtyd and @sureshanaparti raised concerns. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4078: Cleanup download urls when SSVM destroyed
DaanHoogland commented on pull request #4078: URL: https://github.com/apache/cloudstack/pull/4078#issuecomment-729143729 @ravening can you deal with the comment or should we move to a later milestone? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4078: Cleanup download urls when SSVM destroyed
DaanHoogland commented on pull request #4078: URL: https://github.com/apache/cloudstack/pull/4078#issuecomment-724925355 @rhtyd @sureshanaparti are your concerns met? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4078: Cleanup download urls when SSVM destroyed
DaanHoogland commented on pull request #4078: URL: https://github.com/apache/cloudstack/pull/4078#issuecomment-718156699 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4078: Cleanup download urls when SSVM destroyed
DaanHoogland commented on pull request #4078: URL: https://github.com/apache/cloudstack/pull/4078#issuecomment-718044253 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4078: Cleanup download urls when SSVM destroyed
DaanHoogland commented on pull request #4078: URL: https://github.com/apache/cloudstack/pull/4078#issuecomment-718005312 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4078: Cleanup download urls when SSVM destroyed
DaanHoogland commented on pull request #4078: URL: https://github.com/apache/cloudstack/pull/4078#issuecomment-717935827 @ravening can you answer @rhtyd 's question @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4078: Cleanup download urls when SSVM destroyed
DaanHoogland commented on pull request #4078: URL: https://github.com/apache/cloudstack/pull/4078#issuecomment-694923730 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4078: Cleanup download urls when SSVM destroyed
DaanHoogland commented on pull request #4078: URL: https://github.com/apache/cloudstack/pull/4078#issuecomment-665057020 @sureshanaparti do you approve the changes? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4078: Cleanup download urls when SSVM destroyed
DaanHoogland commented on pull request #4078: URL: https://github.com/apache/cloudstack/pull/4078#issuecomment-630109012 > So when we destroy the SSVM, we clean up the download_url link so that it will generate a new download_url link when template/volume is downloaded again. right, I was confusing `vm_template.url` with `template_store_ref.download_url` totally sensible fix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
