[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1567944751 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1563938876 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1415364729 > @DaanHoogland Yes, I'm working on this PR. If nothing goes wrong, I can manage to fix it crossed_fingers > Due to the VM reinstall issue last week, I couldn't work on this. So when are you ready, +-? keep in mind that we need time to test and merge as well) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1415329515 @soreana , will you work on this before RC cutting? (I might postpone another week, but really want to more forward) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1401544520 > Trillian test result (tid-5952) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43104 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6809-t5952-kvm-centos7.zip Smoke tests completed. 105 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: > Test Result Time (s)Test File > test_create_pvlan_network `Error` 0.05test_pvlan.py > test_01_redundant_vpc_site2site_vpn`Failure` 618.32 test_vpc_vpn.py @soreana , and at this please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host
DaanHoogland commented on PR #6809:
URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1400629956
> Manual setting of values works fine but the reset functionality doesn't
change the value in database:
>
> ```
> (localcloud) > update configuration name=host.reserved.mem.mb value=2048
> {
> "configuration": {
> "category": "Advanced",
> "description": "Set an upper limit for memory in megabytes which will
be reserved for host and not used for VM allocation.",
> "isdynamic": true,
> "name": "host.reserved.mem.mb",
> "value": "2048"
> }
> }
>
> (localcloud) > list configurations name=host.reserved.mem.mb
> {
> "configuration": [
> {
> "category": "Advanced",
> "description": "Set an upper limit for memory in megabytes which
will be reserved for host and not used for VM allocation.",
> "isdynamic": true,
> "name": "host.reserved.mem.mb",
> "value": "2048"
> }
> ],
> "count": 1
> }
>
> mysql> select dom0_memory,ram from host where type="Routing" and removed
is null\G
> *** 1. row ***
> dom0_memory: 1073741824
> ram: 7234621440
> *** 2. row ***
> dom0_memory: 1073741824
> ram: 7234629632
> 2 rows in set (0,00 sec)
> ```
>
> But when the 'reset' functionality is used:
>
> ```
> (localcloud) > reset configuration name=host.reserved.mem.mb
> {
> "configuration": {
> "category": "Advanced",
> "description": "Set an upper limit for memory in megabytes which will
be reserved for host and not used for VM allocation.",
> "isdynamic": true,
> "name": "host.reserved.mem.mb",
> "value": "1024"
> }
> }
> ```
>
> The value is changed only in the global setting, but not updated in the
database:
>
> ```
> (localcloud) > list configurations name=host.reserved.mem.mb
> {
> "configuration": [
> {
> "category": "Advanced",
> "description": "Set an upper limit for memory in megabytes which
will be reserved for host and not used for VM allocation.",
> "isdynamic": true,
> "name": "host.reserved.mem.mb",
> "value": "1024"
> }
> ],
> "count": 1
> }
>
> mysql> select dom0_memory,ram from host where type="Routing" and removed
is null\G
> *** 1. row ***
> dom0_memory: 2147483648
> ram: 6160879616
> *** 2. row ***
> dom0_memory: 2147483648
> ram: 6160887808
> 2 rows in set (0,00 sec)
> ```
@soreana can you look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1400018432 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1398358906 > @wido That in my view > > > Overall it is looking good. > > What I am missing is a validation that nobody can set a value <0 or maybe a super large like 1TB or example. Do we maybe need to set some lower and upper limits? > > @wido That is a good idea, but I'm not sure if there is a good way to validate the settings. Do you have any suggestion, where I can run those validations? @soreana can you add a setting for that? @wido @weizhouapache is this really needed? this is an operator action anyway, isn´t it? they should know how to tune their cloud!?! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1398224805 @weizhouapache @wido @GutoVeronezi is this ready?/are you satisfied?/ did any of you test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1386977827 @soreana will you still change the new setting to be cluste scoped? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1376871901 @soreana can you fix the conflicts and address @GutoVeronezi 's comments please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-136453 > > @wido @soreana , we don´t have true granularity, but we can, if the scope is cluster, edit at global level a vaule that will then function as a default on cluster level. No need to keep the global level to be able to set it globally. I think though, that the global level will only function as default to those clusters that have not set it yet. I am not sure about the reset. > > @DaanHoogland, regarding the behavior of the configurations, once we change a configuration on cluster level or another scope (except global), an entry in `cloud._details` (`cluster_details` for `Cluster`, `data_center_details` for `Zone`, and so on) is persisted, and then, for that scope, this entry will guide the behavior instead of the entry in `cloud.configurations` (global level). For resetting those configurations to the global (default) value, we can use the API [resetConfiguration](https://cloudstack.apache.org/api/apidocs-4.17/apis/resetConfiguration.html). Exactly, which should be good enough. Editing the global level should set the default on a scoped level. It might be that a scoped level that has not set this setting, keeps using the default value from the global level though, instead of the edited global value. I have not tested that and if it does that would be a bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1365801988 > > @wido That is a good point. What would be the best? Should I make it cluster-level or add another cluster-level setting and keep the global one? > > We can add granularity, right? So it can be global, but also per cluster, correct? If not, I'd suggest cluster only. @wido @soreana , we don´t have true granularity, but we can, if the scope is cluster, edit at global level a vaule that will then function as a default on cluster level. No need to keep the global level to be able to set it globally. I think though, that the global level will only function as default to those clusters that have not set it yet. I am not sure about the reset. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1362836204 @soreana can you look at the conflicts, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1357416083 @nvazquez @weizhouapache @GutoVeronezi @wido we need more reviews here, please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1354715876 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1347995958 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1280581620 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1280465856 @soreana I think nothing serious left. Can you answer the outstanding comments. I'll re-run the packaging/tests afterwards. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1279092217 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1278748701 @soreana i see an error during build: ``` [ERROR] /jenkins/workspace/acs-centos7-pkg-builder/dist/rpmbuild/BUILD/cloudstack-4.18.0.0-SNAPSHOT/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:101:8: Unused import - org.apache.cloudstack.framework.messagebus.MessageSubscriber. [UnusedImports] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1274795353 > @DaanHoogland Can I also have this one on 4.18, please ? :) marked for 4.18 @soreana -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
