[GitHub] [cloudstack] GabrielBrascher commented on issue #3969: Snapshot deletion issues
GabrielBrascher commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-610149382 @DaanHoogland @andrijapanicsb please ignore the previous test results. The issues that I got were related with SSVM not working (VM running, but agent was down). Therefore, those failures when deleting snapshot on secondary storage are not related with this PR. The fact that the deletion worked without any exception even with SSVM failing to delete de snapshot on secondary is a problem. It could lead to snapshot garbage issue on secondary storage. But that is not critical and we can (should) leave such issue for a future release. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on issue #3969: Snapshot deletion issues
GabrielBrascher commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-610143513 I did a few tests and it does not delete on secondary storage. Tests considered the following scenarios (with `snapshot.backup.to.secondary=TRUE`): 1. KVM + Ceph (primary) & NFS (scondary). Result: snapshot deleted properly on primary storage; snapshot stays on secondary. The snapshot state is Ready at table `snapshot_store_ref`. 2. KVM + NFS (primary & secondary). Result: snapshot deleted properly on primary storage; snapshot stays on secondary. The snapshot state is Destroying at table `snapshot_store_ref`. I am debugging and re-checking previous commits to find at which point this stopped working. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on issue #3969: Snapshot deletion issues
GabrielBrascher commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-608559503 @harikrishna-patnala thanks for sharing that commit. Can you please share a branch with that commit? The access issue is due to the fact that Apache branches are open only for committers. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on issue #3969: Snapshot deletion issues
GabrielBrascher commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-606109537 @andrijapanicsb sounds good to me, considering the raised context and all tests done so far. Let's run a few more tests then. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on issue #3969: Snapshot deletion issues
GabrielBrascher commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-605983772 Got it @davidjumani, thanks for the feedback. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on issue #3969: Snapshot deletion issues
GabrielBrascher commented on issue #3969: Snapshot deletion issues
URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-604436002
@andrijapanicsb thank you very much for all the tests. Here follows an
update on `snapshot.backup.to.secondary = FALSE`.
I have been testing this implementation (tested with 4.13.1 and also on a
port to 4.14.0). The snapshotting with `snapshot.backup.to.secondary = FALSE`
seems to be working fine for me. Created and deleted on (i) XenServer + NFS,
(ii) KVM + NFS, (iii) KVM + Ceph.
Environment:
- CloudStack management node: Ubuntu 18.04
- KVM nodes: Ubuntu 18.04
- XenServer 6.5
Can you please share more details on the issue that you had? Are there
exceptions on management or the agent node? Is the DB being correctly updated
(snapshots, volumes, snapshot_store_ref)?
Note that snapshots on NFS as primary storage is a bit different than on
secondary. The snapshot handling for NFS (primary) is executed with the help of
the
[managesnapshot.sh](https://github.com/apache/cloudstack/blob/da865f08d30df5e177154049215fb6f4b54e5252/scripts/storage/qcow2/managesnapshot.sh#L72)
script. That script on KVM + NFS (primary) creates a lvm, which makes a bit
tricky to find the snapshot volume compared to other approaches (e.g. ceph:
`rbd snap ls foo`, nfs secondary: `ls -lah /export/secondary/snapshots/`,
XenServer: `xe vdi-list`).
Basically the script runs a lvm lvcreate: `lvm lvcreate --size ${lv_bytes}b
--name "${snapshotname}-cow" ${vg} >&2 || return 2`. Let's say that the volume
path is `/mnt//`.
Thus, the snapshot path will become something as `/mnt///`. However, one looking at the NFS storage via `ls
/mnt//` will see something as `/mnt//`.
Is that happening on your test environment?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on issue #3969: Snapshot deletion issues
GabrielBrascher commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-602799830 @andrijapanicsb thanks for all the tests, I am going to check this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on issue #3969: Snapshot deletion issues
GabrielBrascher commented on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-600081395 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
