[GitHub] [cloudstack] JoaoJandre commented on pull request #7489: Flexible tags for hosts and storage pools
JoaoJandre commented on PR #7489: URL: https://github.com/apache/cloudstack/pull/7489#issuecomment-1739835693 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7489: Flexible tags for hosts and storage pools
JoaoJandre commented on PR #7489: URL: https://github.com/apache/cloudstack/pull/7489#issuecomment-1671859990 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7489: Flexible tags for hosts and storage pools
JoaoJandre commented on PR #7489:
URL: https://github.com/apache/cloudstack/pull/7489#issuecomment-1635811868
The errors shown do not seem related to this PR:
tests `test_01_migrate_VM_and_root_volume` and
`test_02_migrate_VM_with_two_data_disks` had this exception:
```
Exception during migrate: org.libvirt.LibvirtException: internal error:
unable to execute QEMU command \'migrate\': this feature or command is not
currently supported].
```
test `test_hostha_enable_ha_when_host_in_maintenance` had this error:
```
Exception: Job failed: {accountid : '68039dd6-218d-11ee-9ada-1e00b100025e',
account : 'admin', domainid : '4a36939c-218d-11ee-9ada-1e00b100025e',
domainpath : 'ROOT', userid : '6804b9c6-218d-11ee-9ada-1e00b100025e', cmd :
'org.apache.cloudstack.api.command.admin.host.PrepareForMaintenanceCmd',
jobstatus : 2, jobprocstatus : 0, jobresultcode : 530, jobresulttype :
'object', jobresult : {errorcode : 530, errortext : 'Failed to prepare host for
maintenance due to: Unable to prepare for maintenance host 2'}, jobinstancetype
: 'Host', jobinstanceid : 'd1012677-2f8a-4c3b-890c-5480d922c0c7', created :
'2023-07-14T02:49:06+', completed : '2023-07-14T02:49:06+', jobid :
'587fe5b8-a738-4be9-8246-a19fc62fb139'} ]]>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7489: Flexible tags for hosts and storage pools
JoaoJandre commented on PR #7489: URL: https://github.com/apache/cloudstack/pull/7489#issuecomment-1634209643 @DaanHoogland the errors shown in the xen env do not seam related to this PR, could we retry with kvm? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7489: Flexible tags for hosts and storage pools
JoaoJandre commented on PR #7489: URL: https://github.com/apache/cloudstack/pull/7489#issuecomment-1623566059 @DaanHoogland the errors shown in the marvin logs do not seem to be related to the changes in my PR. All the ones I checked had "HTTP connection refused" errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7489: Flexible tags for hosts and storage pools
JoaoJandre commented on PR #7489: URL: https://github.com/apache/cloudstack/pull/7489#issuecomment-1589135572 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7489: Flexible tags for hosts and storage pools
JoaoJandre commented on PR #7489: URL: https://github.com/apache/cloudstack/pull/7489#issuecomment-1568781634 > > Sounds interesting - as long as we keep the original behaviour a default (backward compatibility), I think this would be an interesting feature. It does add complexity (as with anything else), so proper documentation should be in place. > > @JoaoJandre , can you reply this comment, please? As I read this the old behaviour is intact without change. But is there any risk that a user may think they use an old fashion tag but end up creating a dynamic one? Sure, as I stated on https://github.com/apache/cloudstack/pull/7489#issuecomment-1538269766, the current behavior is kept; therefore, the use of tag as rules is optional. Users have to explicitly inform the `isTagARule` parameter as true when calling the APIs to make the tags be interpreted as rules. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] JoaoJandre commented on pull request #7489: Flexible tags for hosts and storage pools
JoaoJandre commented on PR #7489: URL: https://github.com/apache/cloudstack/pull/7489#issuecomment-1538269766 > @JoaoJandre could a global setting and its use in the deployment planner be enough to make the deployment and related lifecycles are strictly or non-strictly allowed the by deployment planner? This would be the simplest solution, however, it would be limited as well. A setting like that would either make all hosts accept or not accept offerings without tags (same with storage pools). The solution proposed in this PR makes the hosts and storage tags much more flexible; for instance, you could have hosts that accept untagged offerings, while others do not. Furthermore, being able to write a rule in JS opens space for operator creativity, and they would have a much finer control over their cloud environment. Also, the current behavior is kept, therefore, the use of tag as rules is optional. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
