[GitHub] [cloudstack] Spaceman1984 commented on issue #4246: plugPublicNic forgot to sort the nic devices before plug a new public network

2020-08-19 Thread GitBox 


Spaceman1984 commented on issue #4246:
URL: https://github.com/apache/cloudstack/issues/4246#issuecomment-677192035


   @echoidcf These are the steps I took to try to reproduce this error and was 
unsuccessful:
   
   * Place a breakpoint in code on the first line inside plugPublicNic() method.
   * Deploy a vmware zone.
   * Wait for the system VMs to come up, connect and the built-in template to 
download and install.
   * Deploy a new instance using the built-in template.
   * Wait for the instance to get deployed.
   
   * Create a new account with admin privileges.
   * Create a new public ip range and assign to newly created account.
   * Log out and log in with new user.
   * Deploy an instance.
   * Wait for the instance to get deployed.
   
   In this process the plugPublicNic() method was never called because addVif 
was always false at the point when the new instance was deployed.
   
   Please post steps how to reproduce.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on issue #4246: plugPublicNic forgot to sort the nic devices before plug a new public network

2020-08-12 Thread GitBox 


Spaceman1984 commented on issue #4246:
URL: https://github.com/apache/cloudstack/issues/4246#issuecomment-672777391


   > But after something (maybe vcenter restart or esxi host upgrade or etc, we 
are not sure the exact trigger), it changed like
   
   @echoidcf I need to know how to get it into this state^^ (restarting the 
host didn't change the order).
   I have found the piece of code you mentioned inside 
prepareNetworkElementCommand() which is called when a VR is started.
   I'm not sure how to get plugPublicNic() called, is there a specific action 
you take to have addVif be set to true? 
   
   ```
   if (addVif) {
   plugPublicNic(vmMo, vlanId, ip);
   ...
   }
   ```
   
   From the code it seems as if plugPublicNic() is called when there are no 
public networks on vsphere.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on issue #4246: plugPublicNic forgot to sort the nic devices before plug a new public network

2020-08-11 Thread GitBox 


Spaceman1984 commented on issue #4246:
URL: https://github.com/apache/cloudstack/issues/4246#issuecomment-671842382


   @rhtyd, I'm on this one



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on issue #4246: plugPublicNic forgot to sort the nic devices before plug a new public network

2020-08-07 Thread GitBox 


Spaceman1984 commented on issue #4246:
URL: https://github.com/apache/cloudstack/issues/4246#issuecomment-670404032


   @rhtyd I'll take a look



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org