[GitHub] [cloudstack] matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the tags from virtual router

2019-06-13 Thread GitBox
matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the 
tags from virtual router
URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-501742318
 
 
   @ustcweizhou sorry, i use a modified cloudstack that save the tags in 
virtual router, it is a good new feature for you guys or not ? 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the tags from virtual router

2019-06-13 Thread GitBox
matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the 
tags from virtual router
URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-501742318
 
 
   @ustcweizhou sorry, i use a modified cloudstack that save the tags in 
virtual router, it is a new feature for you guys or not ? 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the tags from virtual router

2019-06-11 Thread GitBox
matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the 
tags from virtual router
URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-500877609
 
 
   > > > @matheusdaluz thanks. could you tell me how to see the tags in the 
virtual router ?
   > > 
   > > 
   > > @ustcweizhou in the folder /var/www/html/metadata and ip from network.
   > 
   > thanks @matheusdaluz
   > Which cloudstack version are you using ? I did not find information 
related to resource tags in the folders you mentioned.
   > It would be nice if you can give some examples
   > (1) file/content before destroying a vm
   > (2) changes after destroying a vm
   > 
   > Anyway, the changes in 
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java looks good to me.
   
   @ustcweizhou 4.11 version
   some examples
   1- Vm with tags in virtual router and before i'm destroying
   
![image](https://user-images.githubusercontent.com/8479880/59282205-e509da80-8c3e-11e9-9ed0-bff89b446205.png)
   
   2 - Vm destroy and tags gone.
   ![Screen Shot 2019-06-11 at 11 46 
28](https://user-images.githubusercontent.com/8479880/59282331-1d111d80-8c3f-11e9-9a1f-857469e14ed1.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the tags from virtual router

2019-06-11 Thread GitBox
matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the 
tags from virtual router
URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-500877609
 
 
   > > > @matheusdaluz thanks. could you tell me how to see the tags in the 
virtual router ?
   > > 
   > > 
   > > @ustcweizhou in the folder /var/www/html/metadata and ip from network.
   > 
   > thanks @matheusdaluz
   > Which cloudstack version are you using ? I did not find information 
related to resource tags in the folders you mentioned.
   > It would be nice if you can give some examples
   > (1) file/content before destroying a vm
   > (2) changes after destroying a vm
   > 
   > Anyway, the changes in 
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java looks good to me.
   
   @ustcweizhou 4.11 version
   some examples
   1- Vm with tags in virtual router and before i destroying
   
![image](https://user-images.githubusercontent.com/8479880/59282205-e509da80-8c3e-11e9-9ed0-bff89b446205.png)
   
   2 - Vm destroy and tags gone.
   ![Screen Shot 2019-06-11 at 11 46 
28](https://user-images.githubusercontent.com/8479880/59282331-1d111d80-8c3f-11e9-9a1f-857469e14ed1.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the tags from virtual router

2019-06-10 Thread GitBox
matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the 
tags from virtual router
URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-500162256
 
 
   > @matheusdaluz thanks. could you tell me how to see the tags in the virtual 
router ?
   
   @ustcweizhou in the folder /var/www/html/metadata and ip from network.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the tags from virtual router

2019-06-08 Thread GitBox
matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the 
tags from virtual router
URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-500158483
 
 
   @ustcweizhou  
   First you ought to create a network and after that attach the vm, next step 
is create tags to vm, after you destroy the vm and you'll see the tags in 
virtual router yet.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the tags from virtual router

2019-06-08 Thread GitBox
matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the 
tags from virtual router
URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-500158483
 
 
   @ustcweizhou  
   First you ought to create a network and after that attach the vm, next step 
is create tags to vm after you destroy the vm and you'll see the tags in 
virtual router yet.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the tags from virtual router

2019-06-08 Thread GitBox
matheusdaluz edited a comment on issue #3389: when destroy the vms, delete the 
tags from virtual router
URL: https://github.com/apache/cloudstack/pull/3389#issuecomment-500158483
 
 
   @ustcweizhou  You should add a tag and after that destroy the vm.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services