[GitHub] [cloudstack] nathanejohnson commented on issue #3986: Change listVpcOfferings endpoint and createVpcOffering endpoint
nathanejohnson commented on issue #3986: Change listVpcOfferings endpoint and createVpcOffering endpoint URL: https://github.com/apache/cloudstack/pull/3986#issuecomment-606331193 This isn't host specific, in this case "hypervisor specific" implies that for kvm these knobs are part of the domain xml, instead of from some external storage provider. I do think in a perfect world these would have been implemented in such a way that it would be easy to override on a per-VM basis, such as with "custom", but that's now how it's done today, and it wouldn't be the easiest lift in the world to do it either. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nathanejohnson commented on issue #3986: Change listVpcOfferings endpoint and createVpcOffering endpoint
nathanejohnson commented on issue #3986: Change listVpcOfferings endpoint and createVpcOffering endpoint URL: https://github.com/apache/cloudstack/pull/3986#issuecomment-605081929 @DaanHoogland it would impact them once they restarted, yes. And I can see this being an argument around cores, ram etc. But for hypervisor based IO limits, we have no current concept of "custom", which is how people get around static cpu and memory limits today. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nathanejohnson commented on issue #3986: Change listVpcOfferings endpoint and createVpcOffering endpoint
nathanejohnson commented on issue #3986: Change listVpcOfferings endpoint and createVpcOffering endpoint URL: https://github.com/apache/cloudstack/pull/3986#issuecomment-605037679 @DaanHoogland so regarding the "no edit to service / disk offerings" , I'm not sure I completely understand your stance on this? In fact, there is a PR we're considering that would allow users to modify the hypervisor based disk iops / rate limiting parameters? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services