[GitHub] [cloudstack] pbankonier commented on issue #3332: Switch instance to another compute/service offering

2019-05-28 Thread GitBox
pbankonier commented on issue #3332: Switch instance to another compute/service 
offering
URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-496443657
 
 
   @nathanejohnson @svenvogel @DennisKonrad I close this issue since we 
resolved it in the PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] pbankonier commented on issue #3332: Switch instance to another compute/service offering

2019-05-20 Thread GitBox
pbankonier commented on issue #3332: Switch instance to another compute/service 
offering
URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-494024906
 
 
   @nathanejohnson The problem is from line 2371 in the 
ConfigurationManagerImpl.java. You changed the condition from 'isCustomizedIops 
!= null' to 'Boolean.TRUE.equals(isCustomizedIops)' and removed the else case 
where minIops and maxIops gets set to null;
   This changes the behavior in case isCustomizedIops is null. Now the minIops 
and maxIops values get set to 0 instead of null.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services