[GitHub] [cloudstack] rahulbcn27 commented on a diff in pull request #7112: Make display elements optional

[via GitHub]

rahulbcn27 commented on code in PR #7112:
URL: https://github.com/apache/cloudstack/pull/7112#discussion_r1086207743


##
api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkCmd.java:
##
@@ -218,7 +219,10 @@ public String getNetworkName() {
 }
 
 public String getDisplayText() {
-return displayText;
+if(displayText == null)

Review Comment:
   StringUtils.isEmpty(displayText) ? name : displayText; added as suggested by 
Daan.



##
api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkCmd.java:
##
@@ -47,6 +47,7 @@
 import com.cloud.offering.NetworkOffering;
 import com.cloud.utils.net.NetUtils;
 
+

Review Comment:
   Fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rahulbcn27 commented on a diff in pull request #7112: Make display elements optional

[via GitHub]

rahulbcn27 commented on code in PR #7112:
URL: https://github.com/apache/cloudstack/pull/7112#discussion_r1086207398


##
api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkCmd.java:
##
@@ -218,7 +218,10 @@ public String getNetworkName() {
 }
 
 public String getDisplayText() {
-return displayText;
+if(displayText == null)
+return name;
+else
+return displayText;

Review Comment:
   Fixed as suggested



##
api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkCmd.java:
##
@@ -47,6 +47,7 @@
 import com.cloud.offering.NetworkOffering;
 import com.cloud.utils.net.NetUtils;
 
+

Review Comment:
   Fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rahulbcn27 commented on a diff in pull request #7112: Make display elements optional

[via GitHub]

rahulbcn27 commented on code in PR #7112:
URL: https://github.com/apache/cloudstack/pull/7112#discussion_r1084831626


##
api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkCmd.java:
##
@@ -218,7 +218,10 @@ public String getNetworkName() {
 }
 
 public String getDisplayText() {
-return displayText;
+if(displayText == null)
+return name;
+else
+return displayText;

Review Comment:
   Made the changes  as suggested.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rahulbcn27 commented on a diff in pull request #7112: Make display elements optional

[via GitHub]

rahulbcn27 commented on code in PR #7112:
URL: https://github.com/apache/cloudstack/pull/7112#discussion_r1083228833


##
ui/src/views/network/CreateIsolatedNetworkForm.vue:
##
@@ -40,7 +40,7 @@