[GitHub] [cloudstack] rhtyd commented on issue #3434: Build css from scss sources in client ui build
rhtyd commented on issue #3434: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-562891094 @pbankonier @svenvogel - with primate in, kindly close this. Let's move all major UI development work in Primate. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3434: Build css from scss sources in client ui build
rhtyd commented on issue #3434: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-552519058 @pbankonier @svenvogel - do you think we can close this now that we have Primate? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3434: Build css from scss sources in client ui build
rhtyd commented on issue #3434: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-508095165 Thanks for explaining @pbankonier I would have asked for a complete design document for all sorts of UI changes that are coming because they have long term impact on all developers including build and CI systems. I'm sure there are others in the community who're unable to track the intent spread across a couple of related PRs. I was not aware of the PR https://github.com/apache/cloudstack/pull/3307 and was not tracking it as it was not tagged against a milestone (just added one because it's already merged). Generally reviewers, RMs and co-RMs working towards a release/milestone may not track PRs that bring wide amount of changes or break several existing PRs because it will be a lot of work to get authors of existing PRs which may get merge conflict if a PR like this would be merged. We have about 90-100 open items on 4.13.0.0 milestone and many of which have UI/css changes or are UI issues that may require fixes in css files. Due to this, I have moved milestone of this PR to 4.14, hope I've your support and understanding. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3434: Build css from scss sources in client ui build
rhtyd commented on issue #3434: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-507970381 @webermaximilian92 I see some large css files removed, I don't understand if we're removing them how does that affect our build/usage?  @pbankonier can you fix the conflict GitHub is complaining about? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3434: Build css from scss sources in client ui build
rhtyd commented on issue #3434: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-507269720 Thanks @svenvogel but I still see several large changes and file renames and I'm not sure I understand what is intended to be here. I can make out that it introduces a new gulp/npm dependency during build. Please have a look at: https://github.com/apache/cloudstack/pull/3444#issuecomment-507180721 Copied from above: ``` there have been several css/UI related PRs proposed recently, can you start a discussion thread on dev@ to explain what are the goals and refactorings you're trying to do. I'm personally not sure where the UI changes are heading and would like to learn more. Typically any framework/component related changes and refactorings may have a design document to capture this that is shared with the dev community for review and discussion. Any proposals and discussions are welcome on dev@. Thanks. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3434: Build css from scss sources in client ui build
rhtyd commented on issue #3434: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-506650335 @svenvogel I'll readded this PR to 4.13.0.0 milestone on your remark. Keep us posted, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3434: Build css from scss sources in client ui build
rhtyd commented on issue #3434: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-506447817 In the present form renaming ui folder just because it feels like may not be encouraged because it will cause conflicts for so many existing PRs and will cause porting and forward merging issues. Let's visit this in future, at least after 4.13. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3434: Build css from scss sources in client ui build
rhtyd commented on issue #3434: Build css from scss sources in client ui build URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-506398641 Can you explain why move the ui directory to client? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
