[GitHub] [cloudstack] rhtyd commented on pull request #4032: Suspending the VM prior to deleting snapshots to avoid corruption, th…

2021-02-25 Thread GitBox


rhtyd commented on pull request #4032:
URL: https://github.com/apache/cloudstack/pull/4032#issuecomment-786037814


   Did another round of code review, LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4032: Suspending the VM prior to deleting snapshots to avoid corruption, th…

2021-02-23 Thread GitBox


rhtyd commented on pull request #4032:
URL: https://github.com/apache/cloudstack/pull/4032#issuecomment-784116493


   @weizhouapache have you done any manual testing on this?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4032: Suspending the VM prior to deleting snapshots to avoid corruption, th…

2021-02-19 Thread GitBox


rhtyd commented on pull request #4032:
URL: https://github.com/apache/cloudstack/pull/4032#issuecomment-781988610


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4032: Suspending the VM prior to deleting snapshots to avoid corruption, th…

2021-02-19 Thread GitBox


rhtyd commented on pull request #4032:
URL: https://github.com/apache/cloudstack/pull/4032#issuecomment-781927615


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4032: Suspending the VM prior to deleting snapshots to avoid corruption, th…

2020-06-16 Thread GitBox


rhtyd commented on pull request #4032:
URL: https://github.com/apache/cloudstack/pull/4032#issuecomment-645109835


   @ggoodrich-ipp could you check if `quiescevm` is true in the 
`createSnapshot` API? Would that be better than doing it by default?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4032: Suspending the VM prior to deleting snapshots to avoid corruption, th…

2020-06-11 Thread GitBox


rhtyd commented on pull request #4032:
URL: https://github.com/apache/cloudstack/pull/4032#issuecomment-643062751


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4032: Suspending the VM prior to deleting snapshots to avoid corruption, th…

2020-06-11 Thread GitBox


rhtyd commented on pull request #4032:
URL: https://github.com/apache/cloudstack/pull/4032#issuecomment-642598175


   @ggoodrich-ipp can you fix the conflicts, thanks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org