[GitHub] [cloudstack] rhtyd commented on pull request #4228: Dont add host back after agent service restart

2020-10-12 Thread GitBox 


rhtyd commented on pull request #4228:
URL: https://github.com/apache/cloudstack/pull/4228#issuecomment-707030955


   ping @ravening any update? thanks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4228: Dont add host back after agent service restart

2020-09-25 Thread GitBox 


rhtyd commented on pull request #4228:
URL: https://github.com/apache/cloudstack/pull/4228#issuecomment-698154589


   @ravening @weizhouapache can you share your manual test results if any?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4228: Dont add host back after agent service restart

2020-09-24 Thread GitBox 


rhtyd commented on pull request #4228:
URL: https://github.com/apache/cloudstack/pull/4228#issuecomment-698154589


   @ravening @weizhouapache can you share your manual test results if any?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4228: Dont add host back after agent service restart

2020-09-09 Thread GitBox 


rhtyd commented on pull request #4228:
URL: https://github.com/apache/cloudstack/pull/4228#issuecomment-689870779


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4228: Dont add host back after agent service restart

2020-08-05 Thread GitBox 


rhtyd commented on pull request #4228:
URL: https://github.com/apache/cloudstack/pull/4228#issuecomment-669059632


   @ravening I think resetting the host, zone, cluster, etc to default (or 
remove) should be enough. Post agent restart the agent will not know where to 
connect.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4228: Dont add host back after agent service restart

2020-08-04 Thread GitBox 


rhtyd commented on pull request #4228:
URL: https://github.com/apache/cloudstack/pull/4228#issuecomment-668400923


   Well @ravening fixing it otherwise would break some people's way of 
deploying/adding KVM host. Perhaps there's an easy way to reset the host 
(domain/IP) and zone/pod/cluster settings in the agent.properties (i.e. reset 
or remove them) when a host is removed?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4228: Dont add host back after agent service restart

2020-07-30 Thread GitBox 


rhtyd commented on pull request #4228:
URL: https://github.com/apache/cloudstack/pull/4228#issuecomment-666127252


   @ravening this will break the host-add feature for a lot of users who use 
the functionality to add a KVM host out-of-band without using the addHost API.
   
   Instead a middle-ground fix could be to remove a host's certificates when a 
KVM host is removed (all the /etc/cloudstack/agent/cloud.* files) which will 
stop KVM agent connections to be accepted by the management server for most 
deployments (i.e. CA plugin and auth strictness enabled).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org