[GitHub] [cloudstack] skattoju4 edited a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV
skattoju4 edited a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509373239 @svenvogel yeah @ustcweizhou suggestion is cleaner / more generic the windows specific logic can be removed. As pointed out the issue is guest OSs without pv support using managed storage. (sorry missed previous messages) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] skattoju4 edited a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV
skattoju4 edited a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-493221612 @kiwiflyer after discussing this with @swill i have a better understanding. Essentially registering an ISO is supposed to be hypervisor agnostic. We can only know valid options for disk controller in the context of a selected hypervisor which in the case of ISOs is during VM creation. Given this it makes sense to have the option of specifying hypervisor specific options during VM creation. Currently this comes from vm details in the case of non ISO based templates but is not set the case of ISO based templates. As a result the agent tries to guess the disk controller based on the OS type specified during ISO template registration. Maintaining this guessing logic is not ideal. The deployVirtualMachine api has a details map that can be used to pass the rootDiskController value which is used by the KVM agent. We were able to verify this using cloud monkey. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] skattoju4 edited a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV
skattoju4 edited a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-493221612 @kiwiflyer after discussing this with @swill i have a better understanding. Essentially registering an ISO is supposed to be hypervisor agnostic. We can only know valid options for disk controller in the context of a selected hypervisor which in the case of ISOs is during VM creation. Given this it makes sense to have the option of specifying hypervisor specific options during VM creation. The deployVirtualMachine api has a details map that can be used to pass this info. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] skattoju4 edited a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV
skattoju4 edited a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-493125862 I think since we always create vms from templates this should be specified when registering templates (iso or otherwise) to be consistent with the current workflow. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
