weizhouapache commented on pull request #4019:
URL: https://github.com/apache/cloudstack/pull/4019#issuecomment-665507567
> code looks good @weizhouapache but two questions:
>
> 1. I see the test was deleted and not replaced. any directive on other
than manual testing (it might be covoured by marvin already?)
> 2. when you say "Same steps succeed with this PR (the vm will be restored
twice)., "How was this tesgted", do you mean to say that the VM will exist
twice after restore? Is this the functionality we want?
@DaanHoogland
Hi,
1. I removed the unit tests as the method has been moved frm
UserVmManagerImpl.java to VirtualMachineManagerImpl.java
2. if vm is restored twice, without this patch, the two restoration will be
performed in parallel, there will be two ROOT disks, vm cannot be started .
With this patch, the second restoration will be performed when the first
restoration is done, hence there is only 1 ROOT disk.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
