[GitHub] DaanHoogland commented on a change in pull request #2175: 4.10 to 4.11 upgrade path

2017-07-12 Thread git 
DaanHoogland commented on a change in pull request #2175: 4.10 to 4.11 upgrade 
path
URL: https://github.com/apache/cloudstack/pull/2175#discussion_r126894928
 
 

 ##
 File path: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java
 ##
 @@ -104,210 +105,353 @@
 
 public class DatabaseUpgradeChecker implements SystemIntegrityChecker {
 private static final Logger s_logger = 
Logger.getLogger(DatabaseUpgradeChecker.class);
-
-protected Map _upgradeMap = new 
HashMap<>();
-
-@Inject
-VersionDao _dao;
-
 private final ImmutableList availableVersions;
+protected Map _upgradeMap = new 
HashMap<>();
+@Inject VersionDao _dao;
 
 public DatabaseUpgradeChecker() {
 
 Review comment:
   split the reformat into a separate commit
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2175: 4.10 to 4.11 upgrade path

2017-07-12 Thread git 
DaanHoogland commented on a change in pull request #2175: 4.10 to 4.11 upgrade 
path
URL: https://github.com/apache/cloudstack/pull/2175#discussion_r126894928
 
 

 ##
 File path: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java
 ##
 @@ -104,210 +105,353 @@
 
 public class DatabaseUpgradeChecker implements SystemIntegrityChecker {
 private static final Logger s_logger = 
Logger.getLogger(DatabaseUpgradeChecker.class);
-
-protected Map _upgradeMap = new 
HashMap<>();
-
-@Inject
-VersionDao _dao;
-
 private final ImmutableList availableVersions;
+protected Map _upgradeMap = new 
HashMap<>();
+@Inject VersionDao _dao;
 
 public DatabaseUpgradeChecker() {
 
 Review comment:
   split the reformat into a separate commit
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services