[GitHub] mike-tutkowski commented on issue #2315: A comprehensive solution for CLOUDSTACK-9025 and CLOUDSTACK-10128.
mike-tutkowski commented on issue #2315: A comprehensive solution for CLOUDSTACK-9025 and CLOUDSTACK-10128. URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-355708764 I've read through the code and the existing comments about it. I don't think I have anything to add above and beyond what's already been discussed here. LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mike-tutkowski commented on issue #2315: A comprehensive solution for CLOUDSTACK-9025 and CLOUDSTACK-10128.
mike-tutkowski commented on issue #2315: A comprehensive solution for CLOUDSTACK-9025 and CLOUDSTACK-10128. URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-351507718 @rhtyd I haven't actually examined the code for this PR. I was serving mainly as a source of answers for questions regarding how this feature might interact with managed storage. Let me know if we still need reviewers. At the time being, I've been racing pretty hard to finish up another project, so I probably couldn't spend the necessary time until, say, mid next week. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services