[GitHub] mike-tutkowski commented on issue #2499: Updates to capacity management
mike-tutkowski commented on issue #2499: Updates to capacity management URL: https://github.com/apache/cloudstack/pull/2499#issuecomment-387175659 I went ahead and pushed the cherry-picked commit to #2621. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mike-tutkowski commented on issue #2499: Updates to capacity management
mike-tutkowski commented on issue #2499: Updates to capacity management URL: https://github.com/apache/cloudstack/pull/2499#issuecomment-387167133 Hey @rhtyd - What's the official process for backporting a PR like this that has already been merged? Should I just cherry pick the commit to 4.11.1? Clearly there's not much tracking going on that way, but I'm not sure how we officially do this. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mike-tutkowski commented on issue #2499: Updates to capacity management
mike-tutkowski commented on issue #2499: Updates to capacity management URL: https://github.com/apache/cloudstack/pull/2499#issuecomment-386774645 Yes, @rhtyd, you are correct that this PR is a good candidate for 4.11.1. I can create a PR to back port it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mike-tutkowski commented on issue #2499: Updates to capacity management
mike-tutkowski commented on issue #2499: Updates to capacity management URL: https://github.com/apache/cloudstack/pull/2499#issuecomment-381250553 Two LGTMs and regression tests looking good, so merging. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mike-tutkowski commented on issue #2499: Updates to capacity management
mike-tutkowski commented on issue #2499: Updates to capacity management URL: https://github.com/apache/cloudstack/pull/2499#issuecomment-380929090 I looked at several of the error messages for a recent test run of #2486 and it seems the list is quite similar to the list of error messages for this PR. As such, I suggest it is likely that none of the errors that are listed for this test run are related to this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mike-tutkowski commented on issue #2499: Updates to capacity management
mike-tutkowski commented on issue #2499: Updates to capacity management URL: https://github.com/apache/cloudstack/pull/2499#issuecomment-380926801 The test environment is having an issue when we try to put an NFS-based primary storage in maintenance mode. In test_primary_storage.py, the first error is related to that and then we later see other errors where adding a new primary storage with the same name fails because it's already in use (presumably we were originally going to delete the primary storage after putting it in maintenance mode, but putting it in maintenance mode failed). Is this error scenario unique to this PR? It seems like the code in this PR wouldn't be responsible for such a situation. On the up side, both Jenkins and Travis passed. **test_primary_storage.py:** errorText:Primary storage with id 5 cannot be disabled. Storage pool state : Maintenance\n' errorText:Failed to add data store: Storage pool nfs://10.2.0.16/acs/primary/pr2499-t2490-kvm-centos7/marvin_pri1 already in use by another pod (id=1)\n' **(two of these errors)** **test_routers.py:** 'AssertionError: Check uptime is less than 3 mins or not\n' **test_snapshots.py:** errorText:Failed to add data store: Storage pool nfs://10.2.0.16/acs/primary/pr2499-t2490-kvm-centos7/nfs2 already in use by another pod (id=1)\n' **test_vm_life_cycle.py:** errortext : u'Cannot migrate VM, destination host is not in correct state, has status: Up, state: Disabled' This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mike-tutkowski commented on issue #2499: Updates to capacity management
mike-tutkowski commented on issue #2499: Updates to capacity management URL: https://github.com/apache/cloudstack/pull/2499#issuecomment-380260288 These test failures do not seem to be related to this PR. Here are some examples of the errors: **test_primary_storage.py:** errorText:Primary storage with id 5 cannot be disabled. errorText:Failed to add data store: Storage pool nfs://10.2.0.16/acs/primary/pr2499-t2470-kvm-centos7/marvin_pri1 already in use by another pod (id=1)\n'] **test_snapshots.py:** errorText:Failed to add data store: Storage pool nfs://10.2.0.16/acs/primary/pr2499-t2470-kvm-centos7/nfs2 already in use by another pod (id=1)\n'] **test_vm_life_cycle.py:** errortext : u'Cannot migrate VM, destination host is not in correct state, has status: Up, state: Disabled'}, accountid : u'be964da7-397f-11e8-a179-06965801071a'}\n"] This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mike-tutkowski commented on issue #2499: Updates to capacity management
mike-tutkowski commented on issue #2499: Updates to capacity management URL: https://github.com/apache/cloudstack/pull/2499#issuecomment-379440520 All test errors seem inapplicable to this PR. Here are some examples: test_primary_storage.py: errorText:Failed to add data store: Storage pool nfs://10.2.0.16/acs/primary/pr2499-t2464-kvm-centos7/marvin_pri1 already in use by another pod (id=1)\n'] test_snapshots.py: errorText:Failed to add data store: Storage pool nfs://10.2.0.16/acs/primary/pr2499-t2464-kvm-centos7/nfs2 already in use by another pod (id=1)\n'] test_templates.py: 'AssertionError: Extract Template Failed with invalid URL http://192.168.100.96/userdata/99b8334e-ecaa-405b-9168-e902981a3c40.qcow2 (template id: 8cc43b7f-00e7-4250-acbc-53be1de58627)\n'] test_vm_life_cycle.py: errortext : u'Cannot migrate VM, destination host is not in correct state, has status: Up, state: Disabled'}, accountid : u'c600e427-38a5-11e8-a6b6-06db8e010701'}\n"] test_volumes.py: 'AssertionError: Extract Volume Failed with invalid URL http://192.168.100.96/userdata/c146f89d-12e8-4a34-8087-79e66e110239.qcow2 (vol id: ab60d379-a5d3-471a-b17f-7df204e48e53)\n'] This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mike-tutkowski commented on issue #2499: Updates to capacity management
mike-tutkowski commented on issue #2499: Updates to capacity management URL: https://github.com/apache/cloudstack/pull/2499#issuecomment-379437282 I've added an integration test. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mike-tutkowski commented on issue #2499: Updates to capacity management
mike-tutkowski commented on issue #2499: Updates to capacity management URL: https://github.com/apache/cloudstack/pull/2499#issuecomment-378367284 I'm pretty sure none of those test failures has to do with this PR. The PR code relates only to managed storage (which none of those tests test). On top of it, the code is really concerned with somewhat of a corner case in managed storage (which none of those tests would test either). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mike-tutkowski commented on issue #2499: Updates to capacity management
mike-tutkowski commented on issue #2499: Updates to capacity management URL: https://github.com/apache/cloudstack/pull/2499#issuecomment-375087770 I plan to write a Marvin test for this, but - in the meanwhile - wanted to get this PR opened so reviewers could provide comments on the production-focused code. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
