[GitHub] rafaelweingartner commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'.
rafaelweingartner commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'. URL: https://github.com/apache/cloudstack/pull/2572#issuecomment-381552499 @borisstoyanov yes I did. I created RPM packages with this PR, then I installed them, and used ACS to see if there was something broken. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'.
rafaelweingartner commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'. URL: https://github.com/apache/cloudstack/pull/2572#issuecomment-381159586 The method `encodeURIComponent` is not a third party library. It is a native function in Javascript. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'.
rafaelweingartner commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'. URL: https://github.com/apache/cloudstack/pull/2572#issuecomment-381138853 Good question. Why not use directly a function that everybody knows (everybody that works with javascript)? When I first encountered it, I spent some time trying to find its documentation in the Javascript specs. Just then, I discovered that it was a wrapper created in CloudStack's javascript. This wrapper does not help us with anything. Moreover, it was not used consistently in the code base. There are quite a lot of places using the 'encodeURIComponent'. If we want to write less, we should first stop duplicating code ;) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'.
rafaelweingartner commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'. URL: https://github.com/apache/cloudstack/pull/2572#issuecomment-381138853 Good question. Why not use directly a function that everybody knows (everybody that works with javascript)? When I first encountered it, I spent some time trying to find its documentation in the Javascript specs. Just then, I discovered that it was a wrapper created in CloudStack's javascript. This wrapper does not help us with anything. Moreover, it was not used consistently in the code base. There are quite a lot of places using the 'encodeURIComponent'. If we want to write less, we should first stop copying and pasting code ;) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
