[GitHub] rhtyd commented on a change in pull request #2175: 4.10 to 4.11 upgrade path

[git]

rhtyd commented on a change in pull request #2175: 4.10 to 4.11 upgrade path
URL: https://github.com/apache/cloudstack/pull/2175#discussion_r126969725
 
 

 ##
 File path: engine/schema/src/com/cloud/upgrade/dao/Upgrade41000to41100.java
 ##
 @@ -0,0 +1,84 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package com.cloud.upgrade.dao;
+
+import com.cloud.utils.exception.CloudRuntimeException;
+import com.cloud.utils.script.Script;
+import org.apache.log4j.Logger;
+
+import java.io.File;
+import java.sql.Connection;
+
+public class Upgrade41000to41100 implements DbUpgrade {
+final static Logger LOG = Logger.getLogger(Upgrade41000to41100.class);
+
+public static class MemoryValues {
 
 Review comment:
   @DaanHoogland why do we have this class here?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2175: 4.10 to 4.11 upgrade path

[git]

rhtyd commented on a change in pull request #2175: 4.10 to 4.11 upgrade path
URL: https://github.com/apache/cloudstack/pull/2175#discussion_r126882899
 
 

 ##
 File path: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java
 ##
 @@ -104,210 +105,353 @@
 
 public class DatabaseUpgradeChecker implements SystemIntegrityChecker {
 private static final Logger s_logger = 
Logger.getLogger(DatabaseUpgradeChecker.class);
-
-protected Map _upgradeMap = new 
HashMap<>();
-
-@Inject
-VersionDao _dao;
-
 private final ImmutableList availableVersions;
+protected Map _upgradeMap = new 
HashMap<>();
+@Inject VersionDao _dao;
 
 public DatabaseUpgradeChecker() {
 
 Review comment:
   @DaanHoogland it will be hard to review the changes as there as all the 
newlines and formating has changed. Kindly revert some of that, for example 
having the `@Annotations` above the variable declarations.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services