[GitHub] rhtyd commented on issue #2175: 4.10 to 4.11 upgrade path
rhtyd commented on issue #2175: 4.10 to 4.11 upgrade path URL: https://github.com/apache/cloudstack/pull/2175#issuecomment-315036224 mysql> use cloud;mysql> select * from version; ++--+-+--+ | id | version | updated | step | ++--+-+--+ | 1 | 4.0.0| 2017-07-13 15:41:33 | Complete | | 2 | 4.1.0| 2017-07-13 10:11:53 | Complete | | 3 | 4.2.0| 2017-07-13 10:12:06 | Complete | | 4 | 4.2.1| 2017-07-13 10:12:06 | Complete | | 5 | 4.3.0| 2017-07-13 10:12:12 | Complete | | 6 | 4.4.0| 2017-07-13 10:12:20 | Complete | | 7 | 4.4.1| 2017-07-13 10:12:20 | Complete | | 8 | 4.4.2| 2017-07-13 10:12:20 | Complete | | 9 | 4.5.0| 2017-07-13 10:12:24 | Complete | | 10 | 4.5.1| 2017-07-13 10:12:24 | Complete | | 11 | 4.5.2| 2017-07-13 10:12:25 | Complete | | 12 | 4.6.0| 2017-07-13 10:12:26 | Complete | | 13 | 4.6.1| 2017-07-13 10:12:26 | Complete | | 14 | 4.7.0| 2017-07-13 10:12:27 | Complete | | 15 | 4.7.1| 2017-07-13 10:12:27 | Complete | | 16 | 4.8.0| 2017-07-13 10:12:27 | Complete | | 17 | 4.8.1| 2017-07-13 10:12:27 | Complete | | 18 | 4.9.0| 2017-07-13 10:12:30 | Complete | | 19 | 4.9.1.0 | 2017-07-13 10:12:31 | Complete | | 20 | 4.9.2.0 | 2017-07-13 10:12:31 | Complete | | 21 | 4.9.3.0 | 2017-07-13 10:12:31 | Complete | | 22 | 4.10.0.0 | 2017-07-13 10:12:32 | Complete | | 23 | 4.11.0.0 | 2017-07-13 10:12:33 | Complete | ++--+-+--+ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2175: 4.10 to 4.11 upgrade path
rhtyd commented on issue #2175: 4.10 to 4.11 upgrade path URL: https://github.com/apache/cloudstack/pull/2175#issuecomment-315034735 LGTM, tested locally. Thanks @DaanHoogland This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2175: 4.10 to 4.11 upgrade path
rhtyd commented on issue #2175: 4.10 to 4.11 upgrade path URL: https://github.com/apache/cloudstack/pull/2175#issuecomment-314787369 Sorry !LGTM, @DaanHoogland please remove unnecessary classes from 410->411 upgrade path class. Remove unnecessary formatting, makes harder to review backward compatibility issues. We need to test for a fresh installation which path runs first 4.1->4.2 or 4.10/4.11 since I suspect there could be a slight db upgrade issue when 4.1 and 4.10 version strings are compared (it might be possible that we don't have that issue anymore). Finally squash your changes and with good git commit summary and formatting. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2175: 4.10 to 4.11 upgrade path
rhtyd commented on issue #2175: 4.10 to 4.11 upgrade path URL: https://github.com/apache/cloudstack/pull/2175#issuecomment-314787369 Sorry !LGTM, @DaanHoogland please remove unnecessary classes from 410->411 upgrade path class. Remove unnecessary formatting, makes harder to review backward compatibility issues. We need to test for a fresh installation which path runs first 4.1->4.2 or 4.10/4.11 since I suspect there could be a slight db upgrade issue when 4.1 and 4.10 version strings are compared (it might be possible that we don't have that issue anymore). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
