[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-357531723 Tests LGTM. Merging this based on two code reviews and test results. Post merging I'll kick a smoketest round and work with @mike-tutkowski and others to fix any regressions. Thanks everyone for their contributions and work (of course the author!). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-357528879 Fantastic @mike-tutkowski, thanks for your support. I'll merge the PR as soon as XenServer test results are back (maybe in next hour). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-357523437 Okay @mike-tutkowski I'll take your word on it and request that you work with us in case we find regression post-merge. I'll cut RC1 tomorrow, but given our experience it's unlikely that RC1 graduates to a release which will get attention from community to start testing it and buy you some time to fix smoketest/regression and solidfire related tests failures. Do you agree and willing to work? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-357518363 @mike-tutkowski /cc @rafaelweingartner @DaanHoogland I relooked at each of the errors, the only outstanding issues are with vmware test results, rest have been addressed in #2403: test_change_service_offering_for_vm_with_snapshots | Failure | 299.25 | test_vm_snapshots.py Based on my analysis of the logs and test results, all the kvm and xenserver failures are not related to this PR. The `test_public_ip_range.py` test adds a fake public IP range which if not removed causes new ssvm/cpvm to pick a fake public IP that causes iso/template/volume download and setup related failures, the new tests (failing sometimes now) were introduced in #2295. If you can comment on that one failing vmware test (see above) we can accept this - please see that asap @mike-tutkowski @DaanHoogland @rafaelweingartner. The test has been suggestd to be fixed, as soon as xenserver-65sp1 results are back and they don't show this regression I can accept the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-357518363 @mike-tutkowski /cc @rafaelweingartner @DaanHoogland I relooked at each of the errors, the only outstanding issues are with vmware test results, rest have been addressed in #2403: test_change_service_offering_for_vm_with_snapshots | Failure | 299.25 | test_vm_snapshots.py Based on my analysis of the logs and test results, all the kvm and xenserver failures are not related to this PR. The `test_public_ip_range.py` test adds a fake public IP range which if not removed causes new ssvm/cpvm to pick a fake public IP that causes iso/template/volume download and setup related failures, the new tests (failing sometimes now) were introduced in #2295. If you can comment on that one failing vmware test (see above) we can accept this - please see that asap @mike-tutkowski @DaanHoogland @rafaelweingartner. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-357515571 @mike-tutkowski can you have a look at errors from last smoketest run? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-357515571 @mike-tutkowski can you have a look at errors from last smoketest run? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-357433200 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-357431197 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-357429270 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-357373197 @mike-tutkowski can you also resolve the conflicts? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-357338437 @mike-tutkowski thanks, please also fix any conflicts? (fyi I fixed conflict this morning after merging config drive PR on your PR). After fixing ping me, I can kick another test round. We now have 0 smoketest failures on KVM, VMware and XenServer with Trillian and 0 failures with Travis with this PR: https://github.com/apache/cloudstack/pull/2403 I assessed the failures, you'll need to look at following failures: (it's possible these failures are not caused by your PR but environment related) XenServer: test_change_service_offering_for_vm_with_snapshots | Failure | 293.60 | test_vm_snapshots.py KVM: test_router_dhcphosts | Failure | 44.53 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPHosts>:teardown | Error | 73.03 | test_router_dhcphosts.py test_01_list_sec_storage_vm | Failure | 0.07 | test_ssvm.py test_05_stop_ssvm | Failure | 62.65 | test_ssvm.py test_03_deploy_vm_wrong_checksum | Error | 20.55 | test_templates.py ContextSuite context=TestCreateTemplateWithDirectDownload>:teardown | Error | 32.88 | test_templates.py test_04_extract_template | Failure | 128.27 | test_templates.py ContextSuite context=TestISOUsage>:setup | Error | 0.00 | test_usage.py test_06_download_detached_volume | Failure | 137.57 | test_volumes.py test_07_resize_fail | Failure | 4.23 | test_volumes.py VMware: test_01_list_sec_storage_vm | Failure | 0.11 | test_ssvm.py test_05_stop_ssvm | Failure | 83.51 | test_ssvm.py test_04_extract_template | Failure | 132.45 | test_templates.py ContextSuite context=TestISOUsage>:setup | Error | 0.00 | test_usage.py test_change_service_offering_for_vm_with_snapshots | Failure | 351.93 | test_vm_snapshots.py test_01_create_volume | Failure | 150.18 | test_volumes.py test_06_download_detached_volume | Failure | 177.71 | test_volumes.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-357192853 @mike-tutkowski this is the only outstanding feature PR towards the 4.11 milestone. If we can demonstrate that no new smoketest regressions are caused by this PR, we can accept this PR time bound by end of this week (including weekends, if you will). You can reference the latest results on master from "smoketest" results on PR #2376 . Support for reviewing, testing appreciated @rafaelweingartner @DaanHoogland @wido and others This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-357192853 @mike-tutkowski this is the only outstanding feature PR towards the 4.11 milestone. If we can demonstrate that no new smoketest regressions are caused by this PR, we can accept this PR. You can reference the latest results on master from "smoketest" results on PR #2376 . Support for reviewing, testing appreciated @rafaelweingartner @DaanHoogland @wido and others This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-357188589 @mike-tutkowski see ONLY the smoketest failures on #2376 at the very end. Smoke tests failures are the only which mentions they are smoketests (about 66-67 tests). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-357188589 @mike-tutkowski see ONLY the smoketest failures on #2376 at the very end. Smoke tests failures are the only which mentions they are smoketests (about 66-67 tests). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-357187975 @mike-tutkowski ignore travis failure for now (known and not caused by your PR, it intermittently passes and I'll look into it in a separate PR). I see some new failures caused by this PR, please verify and advise: XenServer: test_02_edit_template | Failure | 90.10 | test_templates.py test_change_service_offering_for_vm_with_snapshots | Failure | 293.60 | test_vm_snapshots.py I'll update this when kvm, vmware tests are back. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-357040294 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-357028925 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-357028869 Mike see the smoketests from #2376 for baseline master failures. It's too risky to accept big feature prs where we're seeing a lot failures. You can appreciate I've been engaging with all the PR authors, including extending the freeze/cut date. If we have consensus to further delay the release l by waiting for outstanding 4.11 milestone PRs I don't have a problem. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-356663773 @mike-tutkowski please fix the conflicts This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-356640255 Hi @mike-tutkowski I've tried to fix some failures, you can compare failures against baseline master branch from #2376 (I'll kick another round tonight). Given high failure rate and that we're already past the cut/freeze, do you think the PR would be stable and ready for merge? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-356210968 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-356200573 Thanks @mike-tutkowski I'll rekick tests, meanwhile continue and share solidfire related regression testing. @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-356196162 @mike-tutkowski can you look at several of the failures, many could be env related. Also fix the conflict? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-356109368 @mike-tutkowski can you try the new debian9 systemvmtemplates, get from http://dl.rohityadav.cloud/debian9/ or build yourself using qemu+packer using tools/appliance/build.sh This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-356056163 Thanks @mike-tutkowski I've created a PR #2394 to fix Travis failures. I've kicked a test run in the background now. Meanwhile, can you run solidfire tests against your PR and ensure that they are all passing, and share results as well? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355885076 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355885069 Travis keeps failing, please check @mike-tutkowski This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355880852 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355835398 Thanks @mike-tutkowski This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-35581 @mike-tutkowski can you fix runtime issue, management server fails to start with: /cc @DaanHoogland ``` 2018-01-07 18:27:32,548 ERROR [o.a.c.s.m.w.CloudStackContextLoaderListener] (main:null) (logid:) Failed to start CloudStack java.io.IOException: Resource [jar:file:/usr/share/cloudstack-management/lib/cloudstack-4.11.0.0-SNAPSHOT.jar!/META-INF/cloudstack/sioc/module.properties] is expected to exist at [classpath:META-INF/cloudstack/vmware-sioc/module.properties] please ensure the name property is correct at org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinition.checkNameMatchesSelf(DefaultModuleDefinition.java:108) ``` Due to this issue and without a fix, we can not further test/review this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355765016 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355762580 Travis is green. @DaanHoogland @rafaelweingartner are you lgtm on it? @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355762580 Travis is green. @DaanHoogland are you lgtm on it? @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355490723 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355481636 @mike-tutkowski can you resolve the conflicts, also see any outstanding issue @DaanHoogland @rafaelweingartner are you lgtm on this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-354958002 @mike-tutkowski can you fix the conflicts and address outstanding issues? Additional code review is also requested. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-353929041 @mike-tutkowski I've left some comments, my only major concern is the placement of the `SIOC API plug-in for VMware SIOC` otherwise LGTM. Since it touches upon various parts of the code, the final acceptance would require running regression smoke tests on KVM/VMware/XenServer which we'll do once we've additional lgtm/reviews from others. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-353929041 @mike-tutkowski I've left some comments, my only major concern is the placement of the `SIOC API plug-in for VMware SIOC` otherwise LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-353770200 @mike-tutkowski I've resolved conflict issue, will run some tests. Please check my resolution. @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-353705223 Thanks @mike-tutkowski I'll do review and help run tests next week. Happy holidays! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-351996849 @mike-tutkowski ping me when you want review/tests to be run, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-348123079 @mike-tutkowski thanks for replying, looking forward to your changes. Once you're done, please ping people on this PR and ask explicitly. I may find some time to review by end of next week. Can you also add a link to a FS (if any)? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-348123079 @mike-tutkowski thanks for replying, looking forward to your changes. Once you're done, please ping people on this PR and ask explicitly. I may find some time to review by end of next week. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-347542196 @mike-tutkowski is this ready for prime time review and testing, or still in progress? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-345143722 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
