[GitHub] rhtyd commented on issue #2977: Defer was broken in VR because of json name change. Fix if statement.
rhtyd commented on issue #2977: Defer was broken in VR because of json name change. Fix if statement. URL: https://github.com/apache/cloudstack/pull/2977#issuecomment-433848037 @wido sorry, my bad. I was trying to rebase but made a mistake and github closed it as I force pushed on his branch (github allows maintainers to push on a contributor's PR branch). I've re-submitted his change, he will not lose his authorship on the commit. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2977: Defer was broken in VR because of json name change. Fix if statement.
rhtyd commented on issue #2977: Defer was broken in VR because of json name change. Fix if statement. URL: https://github.com/apache/cloudstack/pull/2977#issuecomment-433847690 oops sorry @RPDiep I was trying to fix the change for you, accidentally overwrote to your master branch with latest master. I'll resubmit a PR on your behalf: https://github.com/apache/cloudstack/pull/2979 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2977: Defer was broken in VR because of json name change. Fix if statement.
rhtyd commented on issue #2977: Defer was broken in VR because of json name change. Fix if statement. URL: https://github.com/apache/cloudstack/pull/2977#issuecomment-433808773 Ping @RPDiep @wido @GabrielBrascher we would want to cut RC4 soon, it would be great to include this bugfix please send this against 4.11 soon, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2977: Defer was broken in VR because of json name change. Fix if statement.
rhtyd commented on issue #2977: Defer was broken in VR because of json name change. Fix if statement. URL: https://github.com/apache/cloudstack/pull/2977#issuecomment-433800860 Thanks @RPDiep can you change the branch to 4.11 and rebase your branch against 4.11? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
