[GitHub] swill commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections
swill commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections URL: https://github.com/apache/cloudstack/pull/2190#issuecomment-321532383 @rhtyd it doesn't look like the tests actually kicked off on this one. Thanks... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] swill commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections
swill commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections URL: https://github.com/apache/cloudstack/pull/2190#issuecomment-320346082 Yes, I looked. It was unable to acquire an IP, so it errored. It looked like there was a lot of other failures and I am assuming it failed due to things not getting cleaned up correctly in the environment. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] swill commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections
swill commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections URL: https://github.com/apache/cloudstack/pull/2190#issuecomment-320082795 @rhtyd can you kick off the tests again. This issue looks like an environment issue. There are a lot of tests failing in this case unrelated to my code. It looks like there was issues cleaning up other tests or something like that because my test failed because it was unable to acquire a public IP. Given the scale of the failures in this run, I am pretty sure the cause is an environment problem. Can we test again so we see if we get different results? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] swill commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections
swill commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections URL: https://github.com/apache/cloudstack/pull/2190#issuecomment-319153678 @borisstoyanov or @rhtyd sorry, yet again... Can one of you kick tests on this again? Thanks... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] swill commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections
swill commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections URL: https://github.com/apache/cloudstack/pull/2190#issuecomment-318364112 Sorry for the repetition here. We have changes to marvin in our local CI which we have not had a chance to push upstream yet. @borisstoyanov or @rhtyd can one of you kick off the tests again? Thanks... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] swill commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections
swill commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections URL: https://github.com/apache/cloudstack/pull/2190#issuecomment-318179550 @borisstoyanov or @rhtyd please kick off the tests again. I forgot that we have not pushed the marvin update to properly test projects yet. That PR is coming, but for now I have change the test to use the standard `account` and `domain` style testing. @syed will likely push the addition to properly test projects through marvin as a different PR at some point soon. Please kick off the tests again. Thanks... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] swill commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections
swill commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections URL: https://github.com/apache/cloudstack/pull/2190#issuecomment-317539514 @borisstoyanov and @rhtyd, can you please kick off the test suite again now that we have added more comprehensive testing of the feature. Also, if you wouldn't mind reviewing the new code as well that would be appreciated. Thanks... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] swill commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections
swill commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections URL: https://github.com/apache/cloudstack/pull/2190#issuecomment-317427843 I will be adding S2S VPN tests to this PR because even though the community tests are passing, we have CI tests that were still failing up until this last push (still untested). Please don't merge this until I have given it the green light. I need to port our testing into marvin so I can contribute it with this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] swill commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections
swill commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections URL: https://github.com/apache/cloudstack/pull/2190#issuecomment-316810048 I created and linked a Jira ticket for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] swill commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections
swill commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections URL: https://github.com/apache/cloudstack/pull/2190#issuecomment-316810048 I created and lined a Jira ticket for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
