Re: [PR] [Usage] Create VPC billing [cloudstack]
DaanHoogland merged PR #7235: URL: https://github.com/apache/cloudstack/pull/7235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
stephankruggg commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-2067156241 > @stephankruggg did you test this? Yes, prior to approving this PR I ran the same tests as @SadiJr, as far as I can remember. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
DaanHoogland commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-2066696578 @stephankruggg did you test this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
blueorangutan commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-2062814169 [SF] Trillian test result (tid-9880) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 49576 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7235-t9880-kvm-centos7.zip Smoke tests completed. 128 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_extract_Iso | `Failure` | 1.09 | test_iso.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
blueorangutan commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-2060961936 [SF] Trillian Build Failed (tid-9872) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
blueorangutan commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-2060628908 [SF] Trillian Build Failed (tid-9868) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
blueorangutan commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-2058941056 [SF] Trillian Build Failed (tid-9853) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
blueorangutan commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-2058900205 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
DaanHoogland commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-2058898429 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
blueorangutan commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-2020763803 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
blueorangutan commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-2020595556 @BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
BryanMLima commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-2020589665 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
blueorangutan commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-2017731799 Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9029 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
blueorangutan commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-2017674870 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
DaanHoogland commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-2017671230 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
BryanMLima commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-2004074831 @DaanHoogland @sureshanaparti, do you guys think this PR can go to the `4.19.1.0` release? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
github-actions[bot] commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1999305005 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
blueorangutan commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1995315059 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8927 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
blueorangutan commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1995036896 @BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
BryanMLima commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1995032186 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
blueorangutan commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1994787858 [SF] Trillian Build Failed (tid-9462) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
blueorangutan commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1988677624 [SF] Trillian Build Failed (tid-9433) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
blueorangutan commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1988666250 @DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
DaanHoogland commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1988664588 @blueorangutan test alma9 kvm-alma9 keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
DaanHoogland commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1988664034 > [SF] Trillian test result (tid-9407) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 49287 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7235-t9407-kvm-centos7.zip Smoke tests completed. 128 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: > Test Result Time (s)Test File > test_02_list_cpvm_vm `Failure` 0.04test_ssvm.py > test_04_cpvm_internals `Failure` 0.03test_ssvm.py looks not related but will retest just to be sure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
blueorangutan commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1982582700 [SF] Trillian test result (tid-9407) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 49287 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7235-t9407-kvm-centos7.zip Smoke tests completed. 128 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_list_cpvm_vm | `Failure` | 0.04 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.03 | test_ssvm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
blueorangutan commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1981282925 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
DaanHoogland commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1981277102 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
blueorangutan commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1977213628 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
blueorangutan commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1977101063 @BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
BryanMLima commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1977098702 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
blueorangutan commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1973359910 Packaging result [SF]: ✔️ el7 ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 8830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
blueorangutan commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1973253676 @BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
BryanMLima commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1973250831 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
BryanMLima commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1973145094 As @SadiJr is focusing in other tasks, I will be working on this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
github-actions[bot] commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1934109927 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
github-actions[bot] commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1882870782 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
github-actions[bot] commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1859725984 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
blueorangutan commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1852441226 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8032 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
blueorangutan commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1852324305 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
DaanHoogland commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1852302155 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
BryanMLima commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1852226644 @SadiJr, the lint is failing due to the end of the schema files. You need to add an extra line at the end. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
SadiJr commented on code in PR #7235:
URL: https://github.com/apache/cloudstack/pull/7235#discussion_r1424011388
##
engine/schema/src/main/resources/META-INF/db/schema-41800to41810.sql:
##
@@ -47,3 +47,17 @@ WHERE so.default_use = 1 AND so.vm_type IN ('domainrouter',
'secondarystoragevm'
-- fix erronous commas in guest_os names
UPDATE `cloud`.`guest_os_hypervisor` SET guest_os_name = 'rhel9_64Guest' WHERE
guest_os_name = 'rhel9_64Guest,';
CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.guest_os', 'display', 'tinyint(1)
DEFAULT ''1'' COMMENT ''should this guest_os be shown to the end user'' ');
+
+CREATE TABLE IF NOT EXISTS `cloud_usage`.`usage_vpc` (
+ `id` bigint(20) unsigned NOT NULL AUTO_INCREMENT,
+ `vpc_id` bigint(20) unsigned NOT NULL,
+ `zone_id` bigint(20) unsigned NOT NULL,
+ `account_id` bigint(20) unsigned NOT NULL,
+ `domain_id` bigint(20) unsigned NOT NULL,
+ `state` varchar(100) DEFAULT NULL,
+ `created` datetime NOT NULL,
+ `removed` datetime DEFAULT NULL,
+ PRIMARY KEY (`id`)
+) ENGINE=InnoDB CHARSET=utf8;
+
+ALTER TABLE `cloud_usage`.`cloud_usage` ADD state VARCHAR(100) DEFAULT NULL;
Review Comment:
@DaanHoogland sorry for the delay, and done, thanks for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
SadiJr commented on code in PR #7235:
URL: https://github.com/apache/cloudstack/pull/7235#discussion_r1424010267
##
api/src/main/java/com/cloud/event/EventTypes.java:
##
@@ -1172,4 +1172,8 @@ public static Class getEntityClassForEvent(String
eventName) {
return null;
}
+
+public static boolean isVpcEvent(String eventType) {
+return EventTypes.EVENT_VPC_CREATE.equals(eventType) ||
EventTypes.EVENT_VPC_DELETE.equals(eventType);
Review Comment:
@DaanHoogland from my point of view, as the VPC update API only changes
metadata such as name, MTU, etc., I see no need to handle the update event here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
blueorangutan commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1847298721 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
blueorangutan commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1847185759 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
DaanHoogland commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1847182888 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
github-actions[bot] commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1833559200 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
SadiJr commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1821429982 @DaanHoogland Sorry for the delay, I will check the suggestions and work on this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
DaanHoogland commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-1814163316 @SadiJr @stephankruggg as there is work to do here, I am moving it to unplanned (not sure who else to cc) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Usage] Create VPC billing [cloudstack]
DaanHoogland commented on code in PR #7235:
URL: https://github.com/apache/cloudstack/pull/7235#discussion_r1377702673
##
engine/schema/src/main/resources/META-INF/db/schema-41800to41810.sql:
##
@@ -47,3 +47,17 @@ WHERE so.default_use = 1 AND so.vm_type IN ('domainrouter',
'secondarystoragevm'
-- fix erronous commas in guest_os names
UPDATE `cloud`.`guest_os_hypervisor` SET guest_os_name = 'rhel9_64Guest' WHERE
guest_os_name = 'rhel9_64Guest,';
CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.guest_os', 'display', 'tinyint(1)
DEFAULT ''1'' COMMENT ''should this guest_os be shown to the end user'' ');
+
+CREATE TABLE IF NOT EXISTS `cloud_usage`.`usage_vpc` (
+ `id` bigint(20) unsigned NOT NULL AUTO_INCREMENT,
+ `vpc_id` bigint(20) unsigned NOT NULL,
+ `zone_id` bigint(20) unsigned NOT NULL,
+ `account_id` bigint(20) unsigned NOT NULL,
+ `domain_id` bigint(20) unsigned NOT NULL,
+ `state` varchar(100) DEFAULT NULL,
+ `created` datetime NOT NULL,
+ `removed` datetime DEFAULT NULL,
+ PRIMARY KEY (`id`)
+) ENGINE=InnoDB CHARSET=utf8;
+
+ALTER TABLE `cloud_usage`.`cloud_usage` ADD state VARCHAR(100) DEFAULT NULL;
Review Comment:
@SadiJr this really nees addressing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
