Re: [PR] Backroll Plugin [cloudstack]
blueorangutan commented on PR #8251: URL: https://github.com/apache/cloudstack/pull/8251#issuecomment-2077166741 [SF] Trillian Build Failed (tid-10027) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Backroll Plugin [cloudstack]
PeterBackroll opened a new pull request, #8251:
URL: https://github.com/apache/cloudstack/pull/8251
### Description
This is the pull request for Backroll Plugin (a backup & restore plugin).
This plugin allows users to use Backroll as backup provider inside
Cloudstack.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Backroll Plugin [cloudstack]
DaanHoogland closed pull request #8251: Backroll Plugin URL: https://github.com/apache/cloudstack/pull/8251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Backroll Plugin [cloudstack]
rajujith commented on PR #8251: URL: https://github.com/apache/cloudstack/pull/8251#issuecomment-2077010179 @PeterBackroll I would like to try backroll with CloudStack, could you provide some documents to configure it with cloudstack. If could respond to the changes recommended above I would test it after you have made any changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Backroll Plugin [cloudstack]
andrijapanicsb commented on PR #8251: URL: https://github.com/apache/cloudstack/pull/8251#issuecomment-1881035301 @PeterBackroll do we have any docs on how to configure the plugin, what kind of storage is supported, any limitations, etc? Thx! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Backroll Plugin [cloudstack]
DaanHoogland commented on code in PR #8251:
URL: https://github.com/apache/cloudstack/pull/8251#discussion_r1412343730
##
plugins/backup/backroll/src/main/java/org/apache/cloudstack/backup/BackrollBackupProvider.java:
##
@@ -0,0 +1,390 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.backup;
+
+import java.net.URISyntaxException;
+import java.security.KeyManagementException;
+import java.security.NoSuchAlgorithmException;
+import java.text.MessageFormat;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.stream.Collectors;
+
+import javax.inject.Inject;
+
+import org.apache.cloudstack.backup.Backup.Metric;
+import org.apache.cloudstack.backup.backroll.BackrollClient;
+import org.apache.cloudstack.backup.backroll.model.BackrollBackupMetrics;
+import org.apache.cloudstack.backup.backroll.model.BackrollTaskStatus;
+import org.apache.cloudstack.backup.backroll.model.BackrollVmBackup;
+import org.apache.cloudstack.backup.dao.BackupDao;
+import org.apache.log4j.Logger;
+import org.joda.time.DateTime;
+
+import com.cloud.utils.Pair;
+import com.cloud.utils.component.AdapterBase;
+import com.cloud.utils.exception.CloudRuntimeException;
+import com.cloud.vm.VMInstanceVO;
+import com.cloud.vm.VirtualMachine;
+import com.cloud.vm.dao.VMInstanceDao;
+
+import org.apache.cloudstack.framework.config.ConfigKey;
+import org.apache.cloudstack.framework.config.Configurable;
+import org.apache.commons.collections.CollectionUtils;
+import org.apache.commons.lang3.StringUtils;
+
+public class BackrollBackupProvider extends AdapterBase implements
BackupProvider, Configurable {
+
+private static final Logger s_logger =
Logger.getLogger(BackrollBackupProvider.class);
+public static final String BACKUP_IDENTIFIER = "-CSBKP-";
+
+public ConfigKey BackrollUrlConfigKey = new
ConfigKey<>("Advanced", String.class,
+"backup.plugin.backroll.config.url",
+"http://api.backup.demo.ccc:5050/api/v1;,
+"Url for backroll plugin by DIMSI", true, ConfigKey.Scope.Zone);
+
+public ConfigKey BackrollAppNameConfigKey = new
ConfigKey<>("Advanced", String.class,
+"backup.plugin.backroll.config.appname",
+"backroll_api",
+"App Name for backroll plugin by DIMSI", true, ConfigKey.Scope.Zone);
+
+public ConfigKey BackrollPasswordConfigKey = new
ConfigKey<>("Advanced", String.class,
+"backup.plugin.backroll.config.password",
+"VviX8dALauSyYJMqVYJqf3UyZOpO3joS",
+"Password for backroll plugin by DIMSI", true, ConfigKey.Scope.Zone);
+
+private BackrollClient backrollClient;
+
+@Inject
+private BackupDao backupDao;
+@Inject
+private VMInstanceDao vmInstanceDao;
+
+@Override
+public String getName() {
+return "backroll";
+}
+
+@Override
+public String getDescription() {
+return "Backroll Backup Plugin";
+}
+
+@Override
+public List listBackupOfferings(Long zoneId) {
+s_logger.debug("Listing backup policies on backroll B Plugin");
+BackrollClient client = getClient(zoneId);
+String urlToRequest = client.getBackupOfferingUrl();
+if(!StringUtils.isEmpty(urlToRequest)){
+return client.getBackupOfferings(urlToRequest);
+}
+return new ArrayList();
+}
+
+@Override
+public boolean isValidProviderOffering(Long zoneId, String uuid) {
+s_logger.info("Checking if backup offering exists on the Backroll
Backup Provider");
+return true;
+}
+
+@Override
+public boolean assignVMToBackupOffering(VirtualMachine vm, BackupOffering
backupOffering) {
+s_logger.info("Creating VM backup for VM " + vm.getInstanceName() + "
from backup offering " + backupOffering.getName());
+((VMInstanceVO) vm).setBackupExternalId(backupOffering.getUuid());
+return true;
+}
+
+@Override
+public boolean restoreVMFromBackup(VirtualMachine vm, Backup backup) {
+s_logger.debug("Restoring vm " + vm.getUuid() + "from backup " +
backup.getUuid() + " on the backroll Backup Provider");
+boolean isSuccess =
Re: [PR] Backroll Plugin [cloudstack]
DaanHoogland commented on code in PR #8251:
URL: https://github.com/apache/cloudstack/pull/8251#discussion_r1404104274
##
plugins/backup/backroll/src/main/java/org/apache/cloudstack/backup/backroll/api/command/GetBackrollHello.java:
##
@@ -0,0 +1,56 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.backup.backroll.api.command;
+
+/* import org.apache.log4j.Logger;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.backup.backroll.api.response.ApiHelloResponse; */
+
+/* @APICommand(name = "getBackrollHello", responseObject =
ApiHelloResponse.class, description = "Get Hello",
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false) */
Review Comment:
code in comment (stealing git's job;)
Makes me think if this class is really needed? maybe remove it from the PR?
##
plugins/backup/backroll/src/main/java/org/apache/cloudstack/backup/backroll/api/response/ApiHelloResponse.java:
##
@@ -0,0 +1,32 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.backup.backroll.api.response;
+
+import org.apache.cloudstack.api.BaseResponse;
+
+import com.cloud.serializer.Param;
+import com.google.gson.annotations.SerializedName;
+
+public class ApiHelloResponse extends BaseResponse {
Review Comment:
should this class be included?
##
plugins/backup/backroll/src/main/java/org/apache/cloudstack/backup/backroll/api/command/GetBackrollHello.java:
##
@@ -0,0 +1,56 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.backup.backroll.api.command;
+
+/* import org.apache.log4j.Logger;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.backup.backroll.api.response.ApiHelloResponse; */
+
+/* @APICommand(name = "getBackrollHello", responseObject =
ApiHelloResponse.class, description = "Get Hello",
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false) */
+public class GetBackrollHello {//extends BaseCmd {
+/* private static final Logger LOGGER =
Logger.getLogger(GetBackrollHello.class.getName());
+private static final String NAME = "gethelloresponse";
+
+
+/
+/// API Implementation///
+/
+
+@Override
+public String getCommandName() {
+return NAME;
+}
+
+@Override
+public long getEntityOwnerId() {
+return 0;
+}
+
+@Override
+public void execute() {
Re: [PR] Backroll Plugin [cloudstack]
shwstppr commented on PR #8251: URL: https://github.com/apache/cloudstack/pull/8251#issuecomment-1829303546 @PeterBackroll can you please have a look at the GH actions failures -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Backroll Plugin [cloudstack]
blueorangutan commented on PR #8251: URL: https://github.com/apache/cloudstack/pull/8251#issuecomment-1827274541 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Backroll Plugin [cloudstack]
blueorangutan commented on PR #8251: URL: https://github.com/apache/cloudstack/pull/8251#issuecomment-1827207054 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Backroll Plugin [cloudstack]
rohityadavcloud commented on PR #8251: URL: https://github.com/apache/cloudstack/pull/8251#issuecomment-1827205569 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Backroll Plugin [cloudstack]
DaanHoogland commented on code in PR #8251:
URL: https://github.com/apache/cloudstack/pull/8251#discussion_r1403261130
##
plugins/backup/backroll/src/main/java/org/apache/cloudstack/backup/backroll/model/response/metrics/virtualMachineBackups/VirtualMachineBackupsResponse.java:
##
@@ -0,0 +1,11 @@
+package
org.apache.cloudstack.backup.backroll.model.response.metrics.virtualMachineBackups;
Review Comment:
```suggestion
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.
package
org.apache.cloudstack.backup.backroll.model.response.metrics.virtualMachineBackups;
```
##
plugins/backup/backroll/src/test/java/org/apache/cloudstack/backup/backroll/BackrollClientTest.java:
##
@@ -0,0 +1,22 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.backup.backroll;
+
+public class BackrollClientTest {
+
+}
Review Comment:
```suggestion
}
```
##
plugins/backup/backroll/src/main/java/org/apache/cloudstack/backup/backroll/model/response/policy/BackrollBackupPolicyResponse.java:
##
@@ -0,0 +1,38 @@
+package org.apache.cloudstack.backup.backroll.model.response.policy;
Review Comment:
```suggestion
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.
package org.apache.cloudstack.backup.backroll.model.response.policy;
```
##
plugins/backup/backroll/src/main/java/org/apache/cloudstack/backup/backroll/model/response/metrics/virtualMachineBackups/Archives.java:
##
@@ -0,0 +1,19 @@
+package
org.apache.cloudstack.backup.backroll.model.response.metrics.virtualMachineBackups;
Review Comment:
```suggestion
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.
package
org.apache.cloudstack.backup.backroll.model.response.metrics.virtualMachineBackups;
```
##
Re: [PR] Backroll Plugin [cloudstack]
PeterBackroll commented on PR #8251: URL: https://github.com/apache/cloudstack/pull/8251#issuecomment-1822272563 Hi @DaanHoogland Yes I will add a documentation PR as soon as possible :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Backroll Plugin [cloudstack]
blueorangutan commented on PR #8251: URL: https://github.com/apache/cloudstack/pull/8251#issuecomment-1821809865 [SF] Trillian test result (tid-8383) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45945 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8251-t8383-kvm-centos7.zip Smoke tests completed. 117 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_08_upgrade_kubernetes_ha_cluster | `Failure` | 672.30 | test_kubernetes_clusters.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Backroll Plugin [cloudstack]
blueorangutan commented on PR #8251: URL: https://github.com/apache/cloudstack/pull/8251#issuecomment-1820537639 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Backroll Plugin [cloudstack]
DaanHoogland commented on PR #8251: URL: https://github.com/apache/cloudstack/pull/8251#issuecomment-1820534266 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Backroll Plugin [cloudstack]
DaanHoogland commented on PR #8251: URL: https://github.com/apache/cloudstack/pull/8251#issuecomment-1820533111 @PeterBackroll , nice to see this coming in. Will you add a documentation PR as well? I think you'll have a lot of reviews ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Backroll Plugin [cloudstack]
blueorangutan commented on PR #8251: URL: https://github.com/apache/cloudstack/pull/8251#issuecomment-1819697734 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Backroll Plugin [cloudstack]
codecov[bot] commented on PR #8251: URL: https://github.com/apache/cloudstack/pull/8251#issuecomment-1819663234 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8251?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: `594 lines` in your changes are missing coverage. Please review. > Comparison is base [(`3ec3007`)](https://app.codecov.io/gh/apache/cloudstack/commit/3ec30076356124439b5e50cb1a057e3b164afc0d?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 30.18% compared to head [(`1f51822`)](https://app.codecov.io/gh/apache/cloudstack/pull/8251?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 19.00%. > Report is 200 commits behind head on main. | [Files](https://app.codecov.io/gh/apache/cloudstack/pull/8251?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [...che/cloudstack/backup/backroll/BackrollClient.java](https://app.codecov.io/gh/apache/cloudstack/pull/8251?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cGx1Z2lucy9iYWNrdXAvYmFja3JvbGwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svYmFja3VwL2JhY2tyb2xsL0JhY2tyb2xsQ2xpZW50LmphdmE=) | 0.00% | [342 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8251?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...ache/cloudstack/backup/BackrollBackupProvider.java](https://app.codecov.io/gh/apache/cloudstack/pull/8251?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cGx1Z2lucy9iYWNrdXAvYmFja3JvbGwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svYmFja3VwL0JhY2tyb2xsQmFja3VwUHJvdmlkZXIuamF2YQ==) | 4.14% | [185 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8251?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...dstack/backup/backroll/model/BackrollOffering.java](https://app.codecov.io/gh/apache/cloudstack/pull/8251?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cGx1Z2lucy9iYWNrdXAvYmFja3JvbGwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svYmFja3VwL2JhY2tyb2xsL21vZGVsL0JhY2tyb2xsT2ZmZXJpbmcuamF2YQ==) | 0.00% | [13 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8251?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...tack/backup/backroll/model/BackrollTaskStatus.java](https://app.codecov.io/gh/apache/cloudstack/pull/8251?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cGx1Z2lucy9iYWNrdXAvYmFja3JvbGwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svYmFja3VwL2JhY2tyb2xsL21vZGVsL0JhY2tyb2xsVGFza1N0YXR1cy5qYXZh) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8251?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...dstack/backup/backroll/model/BackrollVmBackup.java](https://app.codecov.io/gh/apache/cloudstack/pull/8251?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cGx1Z2lucy9iYWNrdXAvYmFja3JvbGwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svYmFja3VwL2JhY2tyb2xsL21vZGVsL0JhY2tyb2xsVm1CYWNrdXAuamF2YQ==) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8251?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...k/backup/backroll/model/BackrollBackupMetrics.java](https://app.codecov.io/gh/apache/cloudstack/pull/8251?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cGx1Z2lucy9iYWNrdXAvYmFja3JvbGwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svYmFja3VwL2JhY2tyb2xsL21vZGVsL0JhY2tyb2xsQmFja3VwTWV0cmljcy5qYXZh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8251?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...oudstack/backup/backroll/model/BackrollBackup.java](https://app.codecov.io/gh/apache/cloudstack/pull/8251?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-cGx1Z2lucy9iYWNrdXAvYmFja3JvbGwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svYmFja3VwL2JhY2tyb2xsL21vZGVsL0JhY2tyb2xsQmFja3VwLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8251?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | |
Re: [PR] Backroll Plugin [cloudstack]
blueorangutan commented on PR #8251: URL: https://github.com/apache/cloudstack/pull/8251#issuecomment-1819622862 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Backroll Plugin [cloudstack]
weizhouapache commented on PR #8251: URL: https://github.com/apache/cloudstack/pull/8251#issuecomment-1819620248 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Backroll Plugin [cloudstack]
boring-cyborg[bot] commented on PR #8251: URL: https://github.com/apache/cloudstack/pull/8251#issuecomment-1819436879 Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) Here are some useful points: - In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation) - Be patient and persistent. It might take some time to get a review or get the final approval from the committers. - Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts. - Please follow [ASF Code of Conduct](https://github.com/apache/.github/blob/main/.github/CODE_OF_CONDUCT.md) for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack. - Be sure to read the [CloudStack Coding Conventions](https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions). Apache CloudStack is a community-driven project and together we are making it better . In case of doubts contact the developers at: Mailing List: d...@cloudstack.apache.org (https://cloudstack.apache.org/mailing-lists.html) Slack: https://apachecloudstack.slack.com/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Backroll Plugin [cloudstack]
PeterBackroll opened a new pull request, #8251:
URL: https://github.com/apache/cloudstack/pull/8251
### Description
This is the pull request for Backroll Plugin (a backup & restore plugin).
This plugin allows users to use Backroll as backup provider inside
Cloudstack.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [X ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
